fix bug 1879 (first part, not completely fixed yet)

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@9948 a592a061-630c-0410-9148-cb99ea01b6c8

diff --git a/src/insets/ChangeLog b/src/insets/ChangeLog
index c6f53a4368ddf21f514be902d5fe359efa0460c2..322c9173f36c42df89d4340662f22490ba325aa5 100644 (file)
--- a/src/insets/ChangeLog
+++ b/src/insets/ChangeLog
@@ -1,3 +1,10 @@
+2005-05-17  Georg Baum  <Georg.Baum@post.rwth-aachen.de>
+
+       * insetbase.C (getStatus): allow LFUN_INSET_MODIFY unconditionally
+       * insetbibitem.C, insetbibtex.C, insetlabel.C (doDispatch): call
+       cur.noUpdate() if nothing changed
+       * insetlatexaccent.[Ch]: spelling fixes
+
 2005-05-13  Martin Vermeer  <martin.vermeer@hut.fi>
 
        * insetcollapsable.C (doDispatch): fix

diff --git a/src/insets/insetbase.C b/src/insets/insetbase.C
index ff11495034d2a2de6ca00bbc531a8dcf0793b527..dcbc08fac9fcab7a4bce033a4295dbc0d64e22f0 100644 (file)
--- a/src/insets/insetbase.C
+++ b/src/insets/insetbase.C
@@ -151,14 +151,11 @@ bool InsetBase::getStatus(LCursor &, FuncRequest const & cmd,
 
        switch (cmd.action) {
        case LFUN_INSET_MODIFY:
-               // Only allow modification of our own data.
+               // Allow modification of our data.
                // This needs to be handled in the doDispatch method of our
                // instantiatable children.
-               if (lyxCode() == translate(cmd.getArg(0))) {
-                       flag.enabled(true);
-                       return true;
-               }
-               return false;
+               flag.enabled(true);
+               return true;
 
        case LFUN_INSET_INSERT:
                // Don't allow insertion of new insets.

diff --git a/src/insets/insetbibitem.C b/src/insets/insetbibitem.C
index ffea9da709a3089873293ef74fe430f19bc082bc..c26cb17a6e530884b2cbf37228256a377c0f4e71 100644 (file)
--- a/src/insets/insetbibitem.C
+++ b/src/insets/insetbibitem.C
@@ -63,6 +63,8 @@ void InsetBibitem::doDispatch(LCursor & cur, FuncRequest & cmd)
                InsetCommandMailer::string2params("bibitem", cmd.argument, p);
                if (!p.getCmdName().empty())
                        setParams(p);
+               else
+                       cur.noUpdate();
                break;
        }
 

diff --git a/src/insets/insetbibtex.C b/src/insets/insetbibtex.C
index 56d4ba5831de389c6fbd513b95959ebeea798b14..0fde04aa1f214110cfdbe5541dc7f44c32352ea8 100644 (file)
--- a/src/insets/insetbibtex.C
+++ b/src/insets/insetbibtex.C
@@ -78,6 +78,8 @@ void InsetBibtex::doDispatch(LCursor & cur, FuncRequest & cmd)
                InsetCommandMailer::string2params("bibtex", cmd.argument, p);
                if (!p.getCmdName().empty())
                        setParams(p);
+               else
+                       cur.noUpdate();
                break;
        }
 

diff --git a/src/insets/insetlabel.C b/src/insets/insetlabel.C
index edffe585ade7da28aff342fa2d4f14670d5c5708..ccdef93a06f1c94de82ef92e2f417f46bc0854ab 100644 (file)
--- a/src/insets/insetlabel.C
+++ b/src/insets/insetlabel.C
@@ -100,7 +100,7 @@ void InsetLabel::doDispatch(LCursor & cur, FuncRequest & cmd)
                InsetCommandParams p;
                InsetCommandMailer::string2params("label", cmd.argument, p);
                if (p.getCmdName().empty()) {
-                       cur.undispatched();
+                       cur.noUpdate();
                        break;
                }
                if (p.getContents() != params().getContents())

diff --git a/src/insets/insetlatexaccent.C b/src/insets/insetlatexaccent.C
index a2a2bca1e68d394b7ff839ba3133739ba53bf676..f79feb29bd99a97f401e1d44e12d9e3c929258c2 100644 (file)
--- a/src/insets/insetlatexaccent.C
+++ b/src/insets/insetlatexaccent.C
@@ -166,7 +166,7 @@ void InsetLatexAccent::checkContents()
                break;
        default:
                lyxerr[Debug::KEY] << "Default" << endl;
-               // unknow accent (or something else)
+               // unknown accent (or something else)
                return;
        }
 

diff --git a/src/insets/insetlatexaccent.h b/src/insets/insetlatexaccent.h
index c5a726054fe1c2f18001c342510f2303177b0205..5fd5abee756b3de2a09824c20e72d526cd331502 100644 (file)
--- a/src/insets/insetlatexaccent.h
+++ b/src/insets/insetlatexaccent.h
@@ -66,7 +66,7 @@ public:
        // should this inset be handled like a normal charater
        bool isChar() const { return true; }
 
-       // is this equivalent to a letter?
+       /// is this equivalent to a letter?
        virtual bool isLetter() const { return candisp; }
 
        /// all the accent types