Revert "Update previews on preference change (#9507)"

The referenced commit lead to performance issues and possibly
crashes in some cases when saving preferences. Thanks to Guillaume
for discovering the issues. See #9828 for more discussion.

I hope to come up with a better fix for #9507.

This reverts commit 390ae05444cf4899a3028dcbbfe1095ecd2d207a.

diff --git a/src/BufferList.cpp b/src/BufferList.cpp
index 68a1e808cb07ab98672b4f5a49185e7dba0f4f05..c253282b795c029ea244769362d4fee5d9e6ca5c 100644 (file)
--- a/src/BufferList.cpp
+++ b/src/BufferList.cpp
@@ -344,15 +344,6 @@ void BufferList::recordCurrentAuthor(Author const & author)
 }
 
 
-void BufferList::updatePreviews()
-{
-       BufferStorage::iterator it = bstore.begin();
-       BufferStorage::iterator end = bstore.end();
-       for (; it != end; ++it)
-               (*it)->updatePreviews();
-}
-
-
 int BufferList::bufferNum(FileName const & fname) const
 {
        FileNameList const buffers(fileNames());

diff --git a/src/BufferList.h b/src/BufferList.h
index 242eff03bea24d34d5750b670bd9511767055b64..4f9cb95c05cb6d177aa3637ed9a8a01bfebe5832 100644 (file)
--- a/src/BufferList.h
+++ b/src/BufferList.h
@@ -115,8 +115,6 @@ public:
        //@{
        /// reset current author for all buffers
        void recordCurrentAuthor(Author const & author);
-       /// update previews for all buffers, e.g. for Prefs update
-       void updatePreviews();
        /// Call changed() on all buffers, internal or not
        void changed(bool update_metrics) const;
        /// emergency save for all buffers

diff --git a/src/frontends/qt4/GuiPrefs.cpp b/src/frontends/qt4/GuiPrefs.cpp
index f7c00f45bfb11d7a5a4a62c6e9977b906a46d931..a0764027213b49b1a896a8f26d84c3d15e79e3eb 100644 (file)
--- a/src/frontends/qt4/GuiPrefs.cpp
+++ b/src/frontends/qt4/GuiPrefs.cpp
@@ -3371,8 +3371,6 @@ void GuiPreferences::dispatchParams()
                update_screen_font_ = false;
        }
 
-       theBufferList().updatePreviews();
-
        // The Save button has been pressed
        if (isClosing())
                dispatch(FuncRequest(LFUN_PREFERENCES_SAVE));