Revert "use std::move() instead of copying when value is no longer used"

This reverts commit e685d31f5aadadd9c84c80a604818d49f5853dbf.

diff --git a/src/BufferView.cpp b/src/BufferView.cpp
index 63833ba8cad3c458375b4f92b6c9c95e62909337..a7348362cc0f3f537eaef1560abdd1e66dd2a238 100644 (file)
--- a/src/BufferView.cpp
+++ b/src/BufferView.cpp
@@ -1707,7 +1707,7 @@ void BufferView::dispatch(FuncRequest const & cmd, DispatchResult & dr)
                        string label = dit.innerParagraph().getLabelForXRef();
                        if (!label.empty()) {
                                // if the paragraph has a label, we refer to this
-                               string const arg = (type.empty()) ? move(label) : move(label) + " " + type;
+                               string const arg = (type.empty()) ? label : label + " " + type;
                                lyx::dispatch(FuncRequest(LFUN_REFERENCE_INSERT, arg));
                                break;
                        } else {

diff --git a/src/Encoding.cpp b/src/Encoding.cpp
index 267298927f8f96445be740d1083a901b2d0713c2..cff17ee051807d3051c2666a4eb8012a0d4d53ba 100644 (file)
--- a/src/Encoding.cpp
+++ b/src/Encoding.cpp
@@ -798,7 +798,7 @@ docstring Encodings::convertLaTeXCommands(docstring const & str, bool const lite
                if (!cnvtd.empty()) {
                        // it did, so we'll take that bit and proceed with what's left
                        ret += cnvtd;
-                       val = move(rem);
+                       val = rem;
                        continue;
                }
                // it's a command of some sort

diff --git a/src/insets/InsetNomencl.cpp b/src/insets/InsetNomencl.cpp
index f853f1461956b4c052ad27dae7f85172cfc18e0a..5db3c0ac8759a8e0691799a435ee1d4ea2151d02 100644 (file)
--- a/src/insets/InsetNomencl.cpp
+++ b/src/insets/InsetNomencl.cpp
@@ -440,7 +440,7 @@ docstring nomenclWidest(Buffer const & buffer)
                                msymb.size();
                        if (wx > w) {
                                w = wx;
-                               symb = move(symbol);
+                               symb = symbol;
                        }
                }
        }