]> git.lyx.org Git - features.git/commitdiff
Fix backspace deletion of selected items with change tracking
authorJuergen Spitzmueller <spitz@lyx.org>
Mon, 13 Jan 2020 08:48:56 +0000 (09:48 +0100)
committerJean-Marc Lasgouttes <lasgouttes@lyx.org>
Thu, 18 Jun 2020 13:48:50 +0000 (15:48 +0200)
Move cursor at beginning of selection after deletion. Else backspace
operation gets stuck in a loop (tries to remove the selection again
and again).

This also fixes backspace deletion of insets with confirmDeletion() == true.

Fixes #11630

src/Text3.cpp

index 664ffb459b8fbd0c9426908330ae36565795e3b8..8643411da1cf0d695fc5c04fd478ccc84afb6cfc 100644 (file)
@@ -1250,7 +1250,13 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                                }
                        }
                } else {
+                       DocIterator const dit = cur.selectionBegin();
                        cutSelection(cur, false);
+                       if (cur.buffer()->params().track_changes)
+                               // since we're doing backwards deletion,
+                               // and the selection is not really cut,
+                               // move cursor before selection (#11630)
+                               cur.setCursor(dit);
                        singleParUpdate = false;
                }
                break;