* src/text3.C:

	* src/BufferView.C: add comments on why several
	change tracking-related LFUNs are always enabled

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@16034 a592a061-630c-0410-9148-cb99ea01b6c8

diff --git a/src/BufferView.C b/src/BufferView.C
index 7193ced711bac1f3e980acf838c401c56da681e4..2935ba27dc66b00f6686c0bb0a509387ba58cfd2 100644 (file)
--- a/src/BufferView.C
+++ b/src/BufferView.C
@@ -653,7 +653,11 @@ FuncStatus BufferView::getStatus(FuncRequest const & cmd)
        case LFUN_CHANGE_NEXT:
        case LFUN_ALL_CHANGES_ACCEPT:
        case LFUN_ALL_CHANGES_REJECT:
-               flag.enabled(buffer_); // FIXME: Change tracking (MG)
+               // TODO: context-sensitive enabling of LFUNs
+               // In principle, these command should only be enabled if there
+               // is a change in the document. However, without proper
+               // optimizations, this will inevitably result in poor performance.
+               flag.enabled(buffer_);
                break;
 
        case LFUN_BUFFER_TOGGLE_COMPRESSION: {

diff --git a/src/text3.C b/src/text3.C
index 2a4b78c8250b1ddb9255b0df782bc89da59d93be..5b45e9d4b917d4b94a6260b1a77439cd4dd269a1 100644 (file)
--- a/src/text3.C
+++ b/src/text3.C
@@ -1742,7 +1742,13 @@ bool LyXText::getStatus(LCursor & cur, FuncRequest const & cmd,
 
        case LFUN_CHANGE_ACCEPT:
        case LFUN_CHANGE_REJECT:
-               enable = true; // FIXME: Change tracking (MG)
+               // TODO: context-sensitive enabling of LFUN_CHANGE_ACCEPT/REJECT
+               // In principle, these LFUNs should only be enabled if there
+               // is a change at the current position/in the current selection.
+               // However, without proper optimizations, this will inevitably
+               // result in unacceptable performance - just imagine a user who
+               // wants to select the complete content of a long document.
+               enable = true;
                break;
 
        case LFUN_WORD_DELETE_FORWARD: