]> git.lyx.org Git - features.git/commitdiff
Fix disabling of widgets for (simple) Search dialog
authorJean-Marc Lasgouttes <lasgouttes@lyx.org>
Thu, 3 Dec 2020 14:31:35 +0000 (15:31 +0100)
committerJean-Marc Lasgouttes <lasgouttes@lyx.org>
Thu, 3 Dec 2020 14:44:55 +0000 (15:44 +0100)
This allows to remove the calls to ButtonController::addReadonly,
which are placebo since 78ade7e6.

src/frontends/qt/GuiSearch.cpp

index 1d209a24d0c71ba54cb002210e5c940154d8d6a2..e5821261232e2c1109612b1f1205f695c3b05fbf 100644 (file)
@@ -66,9 +66,6 @@ GuiSearch::GuiSearch(GuiView & lv)
 
        bc().setPolicy(ButtonPolicy::NoRepeatedApplyReadOnlyPolicy);
        bc().setCancel(buttonBox->button(QDialogButtonBox::Close));
-       bc().addReadOnly(replaceCO);
-       bc().addReadOnly(replacePB);
-       bc().addReadOnly(replaceallPB);
 
        findCO->setCompleter(0);
        replaceCO->setCompleter(0);
@@ -80,6 +77,7 @@ GuiSearch::GuiSearch(GuiView & lv)
 
 void GuiSearch::showEvent(QShowEvent * e)
 {
+       findChanged();
        findPB->setFocus();
        findCO->lineEdit()->selectAll();
        GuiDialog::showEvent(e);
@@ -88,15 +86,12 @@ void GuiSearch::showEvent(QShowEvent * e)
 
 void GuiSearch::findChanged()
 {
-       if (findCO->currentText().isEmpty()) {
-               findPB->setEnabled(false);
-               replacePB->setEnabled(false);
-               replaceallPB->setEnabled(false);
-       } else {
-               findPB->setEnabled(true);
-               replacePB->setEnabled(!isBufferReadonly());
-               replaceallPB->setEnabled(!isBufferReadonly());
-       }
+       bool const replace = !findCO->currentText().isEmpty() && !isBufferReadonly();
+       findPB->setEnabled(replace);
+       replacePB->setEnabled(replace);
+       replaceallPB->setEnabled(replace);
+       replaceLA->setEnabled(replace);
+       replaceCO->setEnabled(replace);
 }