]> git.lyx.org Git - features.git/commitdiff
Revert "Add mechanism to change icons in RTL mode"
authorJean-Marc Lasgouttes <lasgouttes@lyx.org>
Tue, 14 Apr 2020 16:30:44 +0000 (18:30 +0200)
committerJean-Marc Lasgouttes <lasgouttes@lyx.org>
Thu, 18 Jun 2020 13:48:56 +0000 (15:48 +0200)
This is really too clumsy. Revert in preparation for a better
mechanism.

This reverts commit 2898c335be6114194a15cb1aafe4a3c7c170f212.

49 files changed:
lib/Makefile.am
lib/images/bidi_ltr_depth-decrement.svgz [deleted file]
lib/images/bidi_ltr_depth-increment.svgz [deleted file]
lib/images/bidi_ltr_layout-toggle_Description.svgz [deleted file]
lib/images/bidi_ltr_layout-toggle_Enumerate.svgz [deleted file]
lib/images/bidi_ltr_layout-toggle_Itemize.svgz [deleted file]
lib/images/bidi_ltr_layout-toggle_List.svgz [deleted file]
lib/images/bidi_ltr_layout-toggle_Section.svgz [deleted file]
lib/images/bidi_rtl_depth-decrement.svgz [deleted file]
lib/images/bidi_rtl_depth-increment.svgz [deleted file]
lib/images/bidi_rtl_layout-toggle_Description.svgz [deleted file]
lib/images/bidi_rtl_layout-toggle_Enumerate.svgz [deleted file]
lib/images/bidi_rtl_layout-toggle_Itemize.svgz [deleted file]
lib/images/bidi_rtl_layout-toggle_List.svgz [deleted file]
lib/images/bidi_rtl_layout-toggle_Section.svgz [deleted file]
lib/images/classic/bidi_ltr_depth-decrement.png [deleted file]
lib/images/classic/bidi_ltr_depth-increment.png [deleted file]
lib/images/classic/bidi_ltr_layout-toggle_Description.png [deleted file]
lib/images/classic/bidi_ltr_layout-toggle_Enumerate.png [deleted file]
lib/images/classic/bidi_ltr_layout-toggle_Itemize.png [deleted file]
lib/images/classic/bidi_ltr_layout-toggle_List.png [deleted file]
lib/images/classic/bidi_ltr_layout-toggle_Section.png [deleted file]
lib/images/classic/bidi_rtl_depth-decrement.png [deleted file]
lib/images/classic/bidi_rtl_depth-increment.png [deleted file]
lib/images/classic/bidi_rtl_layout-toggle_Description.png [deleted file]
lib/images/classic/bidi_rtl_layout-toggle_Enumerate.png [deleted file]
lib/images/classic/bidi_rtl_layout-toggle_Itemize.png [deleted file]
lib/images/classic/bidi_rtl_layout-toggle_List.png [deleted file]
lib/images/classic/bidi_rtl_layout-toggle_Section.png [deleted file]
lib/images/oxygen/bidi_ltr_depth-decrement.svgz [deleted file]
lib/images/oxygen/bidi_ltr_depth-increment.svgz [deleted file]
lib/images/oxygen/bidi_ltr_layout-toggle_Description.svgz [deleted file]
lib/images/oxygen/bidi_ltr_layout-toggle_Enumerate.svgz [deleted file]
lib/images/oxygen/bidi_ltr_layout-toggle_Itemize.svgz [deleted file]
lib/images/oxygen/bidi_ltr_layout-toggle_List.svgz [deleted file]
lib/images/oxygen/bidi_ltr_layout-toggle_Section.svgz [deleted file]
lib/images/oxygen/bidi_rtl_depth-decrement.svgz [deleted file]
lib/images/oxygen/bidi_rtl_depth-increment.svgz [deleted file]
lib/images/oxygen/bidi_rtl_layout-toggle_Description.svgz [deleted file]
lib/images/oxygen/bidi_rtl_layout-toggle_Enumerate.svgz [deleted file]
lib/images/oxygen/bidi_rtl_layout-toggle_Itemize.svgz [deleted file]
lib/images/oxygen/bidi_rtl_layout-toggle_List.svgz [deleted file]
lib/images/oxygen/bidi_rtl_layout-toggle_Section.svgz [deleted file]
lib/ui/stdtoolbars.inc
src/FuncCode.h
src/LyXAction.cpp
src/frontends/qt/Action.cpp
src/frontends/qt/GuiApplication.cpp
src/frontends/qt/GuiToolbar.cpp

index a84be5b3e288d4d87eca63268c59b4e5dc18a12a..0e51df7a13a8ffd71f9a992fdca5bee81101a1f7 100644 (file)
@@ -516,22 +516,6 @@ dist_images_DATA1X = \
        images/all-changes-accept.svgz \
        images/all-changes-reject.svgz \
        images/banner.svgz \
-       images/bidi_ltr_depth-decrement.svgz \
-       images/bidi_ltr_depth-increment.svgz \
-       images/bidi_ltr_layout-toggle_Description.svgz \
-       images/bidi_ltr_layout-toggle_Enumerate.svgz \
-       images/bidi_ltr_layout-toggle_Itemize.svgz \
-       images/bidi_ltr_layout-toggle_Labeling.svgz \
-       images/bidi_ltr_layout-toggle_List.svgz \
-       images/bidi_ltr_layout-toggle_Section.svgz \
-       images/bidi_rtl_depth-decrement.svgz \
-       images/bidi_rtl_depth-increment.svgz \
-       images/bidi_rtl_layout-toggle_Description.svgz \
-       images/bidi_rtl_layout-toggle_Enumerate.svgz \
-       images/bidi_rtl_layout-toggle_Itemize.svgz \
-       images/bidi_rtl_layout-toggle_Labeling.svgz \
-       images/bidi_rtl_layout-toggle_List.svgz \
-       images/bidi_rtl_layout-toggle_Section.svgz \
        images/bookmark-goto.svgz \
        images/bookmark-goto_0.svgz \
        images/bookmark-save.svgz \
@@ -1819,22 +1803,6 @@ imagesoxygendir = $(imagesdir)/oxygen
 dist_imagesoxygen_DATA1X = \
        images/oxygen/all-changes-accept.svgz \
        images/oxygen/all-changes-reject.svgz \
-       images/oxygen/bidi_ltr_depth-decrement.svgz \
-       images/oxygen/bidi_ltr_depth-increment.svgz \
-       images/oxygen/bidi_ltr_layout-toggle_Description.svgz \
-       images/oxygen/bidi_ltr_layout-toggle_Enumerate.svgz \
-       images/oxygen/bidi_ltr_layout-toggle_Itemize.svgz \
-       images/oxygen/bidi_ltr_layout-toggle_Labeling.svgz \
-       images/oxygen/bidi_ltr_layout-toggle_List.svgz \
-       images/oxygen/bidi_ltr_layout-toggle_Section.svgz \
-       images/oxygen/bidi_rtl_depth-decrement.svgz \
-       images/oxygen/bidi_rtl_depth-increment.svgz \
-       images/oxygen/bidi_rtl_layout-toggle_Description.svgz \
-       images/oxygen/bidi_rtl_layout-toggle_Enumerate.svgz \
-       images/oxygen/bidi_rtl_layout-toggle_Itemize.svgz \
-       images/oxygen/bidi_rtl_layout-toggle_Labeling.svgz \
-       images/oxygen/bidi_rtl_layout-toggle_List.svgz \
-       images/oxygen/bidi_rtl_layout-toggle_Section.svgz \
        images/oxygen/bookmark-goto.svgz \
        images/oxygen/bookmark-goto_0.svgz \
        images/oxygen/bookmark-save.svgz \
@@ -2039,22 +2007,6 @@ imagesclassicdir = $(imagesdir)/classic
 dist_imagesclassic_DATA = \
        images/classic/all-changes-accept.png  \
        images/classic/all-changes-reject.png  \
-       images/classic/bidi_ltr_depth-decrement.png \
-       images/classic/bidi_ltr_depth-increment.png \
-       images/classic/bidi_ltr_layout-toggle_Description.png \
-       images/classic/bidi_ltr_layout-toggle_Enumerate.png \
-       images/classic/bidi_ltr_layout-toggle_Itemize.png \
-       images/classic/bidi_ltr_layout-toggle_Labeling.png \
-       images/classic/bidi_ltr_layout-toggle_List.png \
-       images/classic/bidi_ltr_layout-toggle_Section.png \
-       images/classic/bidi_rtl_depth-decrement.png \
-       images/classic/bidi_rtl_depth-increment.png \
-       images/classic/bidi_rtl_layout-toggle_Description.png \
-       images/classic/bidi_rtl_layout-toggle_Enumerate.png \
-       images/classic/bidi_rtl_layout-toggle_Itemize.png \
-       images/classic/bidi_rtl_layout-toggle_Labeling.png \
-       images/classic/bidi_rtl_layout-toggle_List.png \
-       images/classic/bidi_rtl_layout-toggle_Section.png \
        images/classic/bookmark-goto.png  \
        images/classic/bookmark-goto_0.png  \
        images/classic/bookmark-save.png  \
diff --git a/lib/images/bidi_ltr_depth-decrement.svgz b/lib/images/bidi_ltr_depth-decrement.svgz
deleted file mode 100644 (file)
index 45bee9d..0000000
Binary files a/lib/images/bidi_ltr_depth-decrement.svgz and /dev/null differ
diff --git a/lib/images/bidi_ltr_depth-increment.svgz b/lib/images/bidi_ltr_depth-increment.svgz
deleted file mode 100644 (file)
index 088996d..0000000
Binary files a/lib/images/bidi_ltr_depth-increment.svgz and /dev/null differ
diff --git a/lib/images/bidi_ltr_layout-toggle_Description.svgz b/lib/images/bidi_ltr_layout-toggle_Description.svgz
deleted file mode 100644 (file)
index 00cc0aa..0000000
Binary files a/lib/images/bidi_ltr_layout-toggle_Description.svgz and /dev/null differ
diff --git a/lib/images/bidi_ltr_layout-toggle_Enumerate.svgz b/lib/images/bidi_ltr_layout-toggle_Enumerate.svgz
deleted file mode 100644 (file)
index aaab675..0000000
Binary files a/lib/images/bidi_ltr_layout-toggle_Enumerate.svgz and /dev/null differ
diff --git a/lib/images/bidi_ltr_layout-toggle_Itemize.svgz b/lib/images/bidi_ltr_layout-toggle_Itemize.svgz
deleted file mode 100644 (file)
index 53bde57..0000000
Binary files a/lib/images/bidi_ltr_layout-toggle_Itemize.svgz and /dev/null differ
diff --git a/lib/images/bidi_ltr_layout-toggle_List.svgz b/lib/images/bidi_ltr_layout-toggle_List.svgz
deleted file mode 100644 (file)
index 5266ad5..0000000
Binary files a/lib/images/bidi_ltr_layout-toggle_List.svgz and /dev/null differ
diff --git a/lib/images/bidi_ltr_layout-toggle_Section.svgz b/lib/images/bidi_ltr_layout-toggle_Section.svgz
deleted file mode 100644 (file)
index 65b4335..0000000
Binary files a/lib/images/bidi_ltr_layout-toggle_Section.svgz and /dev/null differ
diff --git a/lib/images/bidi_rtl_depth-decrement.svgz b/lib/images/bidi_rtl_depth-decrement.svgz
deleted file mode 100644 (file)
index cd87995..0000000
Binary files a/lib/images/bidi_rtl_depth-decrement.svgz and /dev/null differ
diff --git a/lib/images/bidi_rtl_depth-increment.svgz b/lib/images/bidi_rtl_depth-increment.svgz
deleted file mode 100644 (file)
index 7a77e62..0000000
Binary files a/lib/images/bidi_rtl_depth-increment.svgz and /dev/null differ
diff --git a/lib/images/bidi_rtl_layout-toggle_Description.svgz b/lib/images/bidi_rtl_layout-toggle_Description.svgz
deleted file mode 100644 (file)
index 8a421ea..0000000
Binary files a/lib/images/bidi_rtl_layout-toggle_Description.svgz and /dev/null differ
diff --git a/lib/images/bidi_rtl_layout-toggle_Enumerate.svgz b/lib/images/bidi_rtl_layout-toggle_Enumerate.svgz
deleted file mode 100644 (file)
index 203ac9f..0000000
Binary files a/lib/images/bidi_rtl_layout-toggle_Enumerate.svgz and /dev/null differ
diff --git a/lib/images/bidi_rtl_layout-toggle_Itemize.svgz b/lib/images/bidi_rtl_layout-toggle_Itemize.svgz
deleted file mode 100644 (file)
index dc8b357..0000000
Binary files a/lib/images/bidi_rtl_layout-toggle_Itemize.svgz and /dev/null differ
diff --git a/lib/images/bidi_rtl_layout-toggle_List.svgz b/lib/images/bidi_rtl_layout-toggle_List.svgz
deleted file mode 100644 (file)
index b24502f..0000000
Binary files a/lib/images/bidi_rtl_layout-toggle_List.svgz and /dev/null differ
diff --git a/lib/images/bidi_rtl_layout-toggle_Section.svgz b/lib/images/bidi_rtl_layout-toggle_Section.svgz
deleted file mode 100644 (file)
index 8d9e340..0000000
Binary files a/lib/images/bidi_rtl_layout-toggle_Section.svgz and /dev/null differ
diff --git a/lib/images/classic/bidi_ltr_depth-decrement.png b/lib/images/classic/bidi_ltr_depth-decrement.png
deleted file mode 100644 (file)
index deddc47..0000000
Binary files a/lib/images/classic/bidi_ltr_depth-decrement.png and /dev/null differ
diff --git a/lib/images/classic/bidi_ltr_depth-increment.png b/lib/images/classic/bidi_ltr_depth-increment.png
deleted file mode 100644 (file)
index 07afff7..0000000
Binary files a/lib/images/classic/bidi_ltr_depth-increment.png and /dev/null differ
diff --git a/lib/images/classic/bidi_ltr_layout-toggle_Description.png b/lib/images/classic/bidi_ltr_layout-toggle_Description.png
deleted file mode 100644 (file)
index c9305c5..0000000
Binary files a/lib/images/classic/bidi_ltr_layout-toggle_Description.png and /dev/null differ
diff --git a/lib/images/classic/bidi_ltr_layout-toggle_Enumerate.png b/lib/images/classic/bidi_ltr_layout-toggle_Enumerate.png
deleted file mode 100644 (file)
index 8c63143..0000000
Binary files a/lib/images/classic/bidi_ltr_layout-toggle_Enumerate.png and /dev/null differ
diff --git a/lib/images/classic/bidi_ltr_layout-toggle_Itemize.png b/lib/images/classic/bidi_ltr_layout-toggle_Itemize.png
deleted file mode 100644 (file)
index 92a67f0..0000000
Binary files a/lib/images/classic/bidi_ltr_layout-toggle_Itemize.png and /dev/null differ
diff --git a/lib/images/classic/bidi_ltr_layout-toggle_List.png b/lib/images/classic/bidi_ltr_layout-toggle_List.png
deleted file mode 100644 (file)
index 6875511..0000000
Binary files a/lib/images/classic/bidi_ltr_layout-toggle_List.png and /dev/null differ
diff --git a/lib/images/classic/bidi_ltr_layout-toggle_Section.png b/lib/images/classic/bidi_ltr_layout-toggle_Section.png
deleted file mode 100644 (file)
index e17c0dd..0000000
Binary files a/lib/images/classic/bidi_ltr_layout-toggle_Section.png and /dev/null differ
diff --git a/lib/images/classic/bidi_rtl_depth-decrement.png b/lib/images/classic/bidi_rtl_depth-decrement.png
deleted file mode 100644 (file)
index c5c10d0..0000000
Binary files a/lib/images/classic/bidi_rtl_depth-decrement.png and /dev/null differ
diff --git a/lib/images/classic/bidi_rtl_depth-increment.png b/lib/images/classic/bidi_rtl_depth-increment.png
deleted file mode 100644 (file)
index 82517d8..0000000
Binary files a/lib/images/classic/bidi_rtl_depth-increment.png and /dev/null differ
diff --git a/lib/images/classic/bidi_rtl_layout-toggle_Description.png b/lib/images/classic/bidi_rtl_layout-toggle_Description.png
deleted file mode 100644 (file)
index 9725c96..0000000
Binary files a/lib/images/classic/bidi_rtl_layout-toggle_Description.png and /dev/null differ
diff --git a/lib/images/classic/bidi_rtl_layout-toggle_Enumerate.png b/lib/images/classic/bidi_rtl_layout-toggle_Enumerate.png
deleted file mode 100644 (file)
index 9b22744..0000000
Binary files a/lib/images/classic/bidi_rtl_layout-toggle_Enumerate.png and /dev/null differ
diff --git a/lib/images/classic/bidi_rtl_layout-toggle_Itemize.png b/lib/images/classic/bidi_rtl_layout-toggle_Itemize.png
deleted file mode 100644 (file)
index 2e86102..0000000
Binary files a/lib/images/classic/bidi_rtl_layout-toggle_Itemize.png and /dev/null differ
diff --git a/lib/images/classic/bidi_rtl_layout-toggle_List.png b/lib/images/classic/bidi_rtl_layout-toggle_List.png
deleted file mode 100644 (file)
index 5f0c84e..0000000
Binary files a/lib/images/classic/bidi_rtl_layout-toggle_List.png and /dev/null differ
diff --git a/lib/images/classic/bidi_rtl_layout-toggle_Section.png b/lib/images/classic/bidi_rtl_layout-toggle_Section.png
deleted file mode 100644 (file)
index e17c0dd..0000000
Binary files a/lib/images/classic/bidi_rtl_layout-toggle_Section.png and /dev/null differ
diff --git a/lib/images/oxygen/bidi_ltr_depth-decrement.svgz b/lib/images/oxygen/bidi_ltr_depth-decrement.svgz
deleted file mode 100644 (file)
index fe32886..0000000
Binary files a/lib/images/oxygen/bidi_ltr_depth-decrement.svgz and /dev/null differ
diff --git a/lib/images/oxygen/bidi_ltr_depth-increment.svgz b/lib/images/oxygen/bidi_ltr_depth-increment.svgz
deleted file mode 100644 (file)
index 3cf9dfd..0000000
Binary files a/lib/images/oxygen/bidi_ltr_depth-increment.svgz and /dev/null differ
diff --git a/lib/images/oxygen/bidi_ltr_layout-toggle_Description.svgz b/lib/images/oxygen/bidi_ltr_layout-toggle_Description.svgz
deleted file mode 100644 (file)
index aa0ae3a..0000000
Binary files a/lib/images/oxygen/bidi_ltr_layout-toggle_Description.svgz and /dev/null differ
diff --git a/lib/images/oxygen/bidi_ltr_layout-toggle_Enumerate.svgz b/lib/images/oxygen/bidi_ltr_layout-toggle_Enumerate.svgz
deleted file mode 100644 (file)
index ad79d56..0000000
Binary files a/lib/images/oxygen/bidi_ltr_layout-toggle_Enumerate.svgz and /dev/null differ
diff --git a/lib/images/oxygen/bidi_ltr_layout-toggle_Itemize.svgz b/lib/images/oxygen/bidi_ltr_layout-toggle_Itemize.svgz
deleted file mode 100644 (file)
index bf45803..0000000
Binary files a/lib/images/oxygen/bidi_ltr_layout-toggle_Itemize.svgz and /dev/null differ
diff --git a/lib/images/oxygen/bidi_ltr_layout-toggle_List.svgz b/lib/images/oxygen/bidi_ltr_layout-toggle_List.svgz
deleted file mode 100644 (file)
index 036a6f9..0000000
Binary files a/lib/images/oxygen/bidi_ltr_layout-toggle_List.svgz and /dev/null differ
diff --git a/lib/images/oxygen/bidi_ltr_layout-toggle_Section.svgz b/lib/images/oxygen/bidi_ltr_layout-toggle_Section.svgz
deleted file mode 100644 (file)
index 2e14680..0000000
Binary files a/lib/images/oxygen/bidi_ltr_layout-toggle_Section.svgz and /dev/null differ
diff --git a/lib/images/oxygen/bidi_rtl_depth-decrement.svgz b/lib/images/oxygen/bidi_rtl_depth-decrement.svgz
deleted file mode 100644 (file)
index ceb1a7d..0000000
Binary files a/lib/images/oxygen/bidi_rtl_depth-decrement.svgz and /dev/null differ
diff --git a/lib/images/oxygen/bidi_rtl_depth-increment.svgz b/lib/images/oxygen/bidi_rtl_depth-increment.svgz
deleted file mode 100644 (file)
index b2890f4..0000000
Binary files a/lib/images/oxygen/bidi_rtl_depth-increment.svgz and /dev/null differ
diff --git a/lib/images/oxygen/bidi_rtl_layout-toggle_Description.svgz b/lib/images/oxygen/bidi_rtl_layout-toggle_Description.svgz
deleted file mode 100644 (file)
index 4c906b1..0000000
Binary files a/lib/images/oxygen/bidi_rtl_layout-toggle_Description.svgz and /dev/null differ
diff --git a/lib/images/oxygen/bidi_rtl_layout-toggle_Enumerate.svgz b/lib/images/oxygen/bidi_rtl_layout-toggle_Enumerate.svgz
deleted file mode 100644 (file)
index 19907b4..0000000
Binary files a/lib/images/oxygen/bidi_rtl_layout-toggle_Enumerate.svgz and /dev/null differ
diff --git a/lib/images/oxygen/bidi_rtl_layout-toggle_Itemize.svgz b/lib/images/oxygen/bidi_rtl_layout-toggle_Itemize.svgz
deleted file mode 100644 (file)
index 1f71c41..0000000
Binary files a/lib/images/oxygen/bidi_rtl_layout-toggle_Itemize.svgz and /dev/null differ
diff --git a/lib/images/oxygen/bidi_rtl_layout-toggle_List.svgz b/lib/images/oxygen/bidi_rtl_layout-toggle_List.svgz
deleted file mode 100644 (file)
index ca26ee0..0000000
Binary files a/lib/images/oxygen/bidi_rtl_layout-toggle_List.svgz and /dev/null differ
diff --git a/lib/images/oxygen/bidi_rtl_layout-toggle_Section.svgz b/lib/images/oxygen/bidi_rtl_layout-toggle_Section.svgz
deleted file mode 100644 (file)
index ba5dfa5..0000000
Binary files a/lib/images/oxygen/bidi_rtl_layout-toggle_Section.svgz and /dev/null differ
index 94fcfee4f4056e1859e9d1b00cc26a4e216b7f88..4af3606425a8064ec28e38126a5c9ae3594be994 100644 (file)
@@ -113,20 +113,12 @@ ToolbarSet
 
        Toolbar "extra" "Extra"
                Item "Default" "layout"
-               # The bidi function is used here to select a different
-               # icon depending on the direction of the current text.
-               Item "Numbered list" "bidi ltr layout-toggle Enumerate"
-               Item "Numbered list" "bidi rtl layout-toggle Enumerate"
-               Item "Itemized list" "bidi ltr layout-toggle Itemize"
-               Item "Itemized list" "bidi rtl layout-toggle Itemize"
-               Item "Labeled List" "bidi ltr layout-toggle Labeling"
-               Item "Labeled List" "bidi rtl layout-toggle Labeling"
-               Item "Description" "bidi ltr layout-toggle Description"
-               Item "Description" "bidi rtl layout-toggle Description"
-               Item "Increase depth" "bidi ltr depth-increment"
-               Item "Increase depth" "bidi rtl depth-increment"
-               Item "Decrease depth" "bidi ltr depth-decrement"
-               Item "Decrease depth" "bidi rtl depth-decrement"
+               Item "Numbered list" "layout-toggle Enumerate"
+               Item "Itemized list" "layout-toggle Itemize"
+               Item "Labeled List" "layout-toggle Labeling"
+               Item "Description" "layout-toggle Description"
+               Item "Increase depth" "depth-increment"
+               Item "Decrease depth" "depth-decrement"
                Separator
                Item "Insert figure float" "float-insert figure"
                Item "Insert table float" "float-insert table"
index 762bc035caf96562b384e84ab0cf0abfb4b104d6..84deea34dfe7b04bb2a1012531bce968ff127053 100644 (file)
@@ -485,9 +485,8 @@ enum FuncCode
        LFUN_BUFFER_WRITE_AS_TEMPLATE,  // spitz, 20190323
        LFUN_TABULAR_STYLE_INSERT,      // spitz, 20190325
        LFUN_PARAGRAPH_SELECT,          // Kornel, 20190416
-       LFUN_BIDI,
-       // 380
        LFUN_BUFFER_RESET_EXPORT,       // spitz 20191226
+       // 380
        LFUN_MASTER_BUFFER_FORALL,      // spitz 20191231
        LFUN_IF_RELATIVES,              // spitz 20200102
        LFUN_LASTACTION                 // end of the table
index 6089e5e8d9167638c5b9b907dc6f3f8ca1482c1e..9f4d3a558916039f191ecfa6be0e92a23950dd45 100644 (file)
@@ -332,20 +332,6 @@ void LyXAction::init()
                { LFUN_BIBTEX_DATABASE_DEL, "bibtex-database-del", Noop, Edit },
 
 
-/*!
- * \var lyx::FuncCode lyx::LFUN_BIDI
- * \li Action: Helper function for bidirectional toolbar icons
- * \li Notion: In a text, the function is marked as `unknown' when the
-               current direction does not correspond to DIRECTION (ltr
-               or rtl). Otherwise the function behaves exactly as
-               ACTION. The result is that ACTION will be associated to
-               a different icon depending on text direction.
- * \li Syntax: bidi <DIRECTION> <ACTION>
- * \li Origin: JMarc, 21 July 2019
- * \endvar
- */
-               { LFUN_BIDI, "bidi", Noop, System },
-
 /*!
  * \var lyx::FuncCode lyx::LFUN_BOOKMARK_CLEAR
  * \li Action: Clears the list of saved bookmarks.
index 0609351a4152111c2697c47e4aae8dbc330d2477..bd102e6b73a8f987c248ec55dec6e07759ee35c0 100644 (file)
@@ -76,7 +76,6 @@ void Action::update()
                setCheckable(false);
        }
 
-       setVisible(!status.unknown());
        setEnabled(status.enabled());
 }
 
index 573ebb905fa67d444653368ae2ab57062e19f27b..64ab6cf07ef25a6e2b11451ab569059e89c1d6d9 100644 (file)
 #include "support/lassert.h"
 #include "support/lstrings.h"
 #include "support/lyxalgo.h" // sorted
+#include "support/textutils.h"
 #include "support/Messages.h"
 #include "support/os.h"
 #include "support/Package.h"
 #include "support/TempFile.h"
-#include "support/textutils.h"
 
 #ifdef Q_OS_MAC
 #include "support/AppleScript.h"
@@ -928,7 +928,7 @@ public:
 struct GuiApplication::Private
 {
        Private(): language_model_(0), meta_fake_bit(NoModifier),
-                  global_menubar_(0)
+               global_menubar_(0)
        {
        #if (QT_VERSION < 0x050000) || (QT_VERSION >= 0x050400)
        #if defined(Q_OS_WIN) || defined(Q_CYGWIN_WIN)
@@ -1292,24 +1292,6 @@ bool GuiApplication::getStatus(FuncRequest const & cmd, FuncStatus & flag) const
                break;
        }
 
-       case LFUN_BIDI: {
-               string const dir = cmd.getArg(0);
-               string const lfun = cmd.getLongArg(1);
-               BufferView const * bv =
-                       current_view_ ? current_view_->currentBufferView() : nullptr;
-               bool rtl = bv ? bv->cursor().innerParagraph().isRTL(bv->buffer().params())
-                             : layoutDirection() == Qt::RightToLeft;
-               if (((rtl && dir != "rtl") || (!rtl && dir != "ltr"))) {
-                       flag.setUnknown(true);
-                       flag.setEnabled(false);
-               } else {
-                       FuncRequest func(lyxaction.lookupFunc(lfun));
-                       func.setOrigin(cmd.origin());
-                       flag = getStatus(func);
-               }
-               break;
-       }
-
        case LFUN_IF_RELATIVES: {
                string const lfun = to_utf8(cmd.argument());
                BufferView const * bv =
@@ -1898,7 +1880,6 @@ void GuiApplication::dispatch(FuncRequest const & cmd, DispatchResult & dr)
                lyxrc.cursor_follows_scrollbar = !lyxrc.cursor_follows_scrollbar;
                break;
 
-       // --- syntax commands ----------------------------
        case LFUN_REPEAT: {
                // repeat command
                string countstr;
@@ -2050,18 +2031,6 @@ void GuiApplication::dispatch(FuncRequest const & cmd, DispatchResult & dr)
                break;
        }
 
-       case LFUN_BIDI: {
-               string const lfun = cmd.getLongArg(1);
-               FuncRequest func(lyxaction.lookupFunc(cmd.getLongArg(1)));
-               func.setOrigin(cmd.origin());
-               FuncStatus const stat = getStatus(func);
-               if (stat.enabled()) {
-                       dispatch(func);
-                       break;
-               }
-               break;
-       }
-
        case LFUN_IF_RELATIVES: {
                string const lfun = to_utf8(cmd.argument());
                FuncRequest func(lyxaction.lookupFunc(lfun));
index 2e8c2b4ec0ead835b523024ea02ed304b77388ce..9da33067018ef0ad6045b543891834e911fd6017 100644 (file)
@@ -519,7 +519,8 @@ void GuiToolbar::add(ToolbarItem const & item)
                break;
        }
        case ToolbarItem::COMMAND: {
-               addAction(addItem(item));
+               if (!getStatus(*item.func_).unknown())
+                       addAction(addItem(item));
                break;
                }
        default: