]> git.lyx.org Git - features.git/commitdiff
use more stringstream, remove some cruft
authorLars Gullik Bjønnes <larsbj@gullik.org>
Wed, 9 May 2001 09:14:50 +0000 (09:14 +0000)
committerLars Gullik Bjønnes <larsbj@gullik.org>
Wed, 9 May 2001 09:14:50 +0000 (09:14 +0000)
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@1991 a592a061-630c-0410-9148-cb99ea01b6c8

12 files changed:
src/ChangeLog
src/LaTeXFeatures.C
src/buffer.C
src/buffer.h
src/frontends/kde/ChangeLog
src/frontends/kde/FormParagraph.C
src/frontends/kde/paradlg.C
src/frontends/kde/paradlg.h
src/frontends/qt2/ChangeLog
src/frontends/qt2/FormParagraph.C
src/paragraph.C
src/text2.C

index 096a440cc9d728fd42d49d3e45ab92ad4bb84b59..b2f3c44d357a91d8b77b1b819fe4df79b6702860 100644 (file)
@@ -1,3 +1,7 @@
+2001-05-09  Lars Gullik Bjønnes  <larsbj@birdstep.com>
+
+       * paragraph.C (String): use stringstream
+
 2001-05-08  Lars Gullik Bjønnes  <larsbj@birdstep.com>
 
        * paragraph.C (writeFile): remove footflag arg
index d01f6b3b8b32f56bc69060228acba5149461d3c1..b4030a9fe82b54521c2be80aa091c625819e0bb3 100644 (file)
@@ -152,6 +152,7 @@ string const LaTeXFeatures::getPackages() const
                if (! tclass.provides(LyXTextClass::makeidx)
                    && params.language->babel() != "french") // french provides
                                                             // \index !
+                       // French should not be hardcoded. (Lgb)
                        packages << "\\usepackage{makeidx}\n";
                packages << "\\makeindex\n";
        }
@@ -329,52 +330,6 @@ string const LaTeXFeatures::getMacros() const
        // floats
        getFloatDefinitions(macros);
 
-#if 0
-       // Here we will output the code to create the needed float styles.
-       // We will try to do this as minimal as possible.
-       // \floatstyle{ruled}
-       // \newfloat{algorithm}{htbp}{loa}
-       // \floatname{algorithm}{Algorithm}
-       UsedFloats::const_iterator cit = usedFloats.begin();
-       UsedFloats::const_iterator end = usedFloats.end();
-       ostringstream floats;
-       for (; cit != end; ++cit) {
-               Floating const & fl = floatList.getType((*cit));
-
-               // For builtin floats we do nothing.
-               if (fl.builtin()) continue;
-               
-               // We have to special case "table" and "figure"
-               if (fl.type() == "tabular" || fl.type() == "figure") {
-                       // Output code to modify "table" or "figure"
-                       // but only if builtin == false
-               } else {
-                       // The other non builtin floats.
-
-                       string type = fl.type();
-                       string placement = fl.placement();
-                       string ext = fl.ext();
-                       string within = fl.within();
-                       string style = fl.style();
-                       string name = fl.name();
-                       floats << "\\floatstyle{" << style << "}\n"
-                              << "\\newfloat{" << type << "}{" << placement
-                              << "}{" << ext << "}";
-                       if (!within.empty())
-                               floats << "[" << within << "]";
-                       floats << "\n"
-                              << "\\floatname{" << type << "}{"
-                              << name << "}\n";
-
-                       // What missing here is to code to minimalize the code
-                       // outputted so that the same flotastyle will not be
-                       // used several times. when the same style is still in
-                       // effect. (Lgb)
-               }
-       }
-       macros += floats.str().c_str();
-#endif
-       
        for (LanguageList::const_iterator cit = UsedLanguages.begin();
             cit != UsedLanguages.end(); ++cit)
                if (!(*cit)->latex_options().empty())
@@ -415,13 +370,13 @@ string const LaTeXFeatures::getIncludedFiles(string const & fname) const
             fi != end; ++fi)
                sgmlpreamble << "\n<!ENTITY " << fi->first
                             << (IsSGMLFilename(fi->second) ? " SYSTEM \"" : " \"" )
-                            << MakeRelPath(fi->second,basename) << "\">";
+                            << MakeRelPath(fi->second, basename) << "\">";
 
        return sgmlpreamble.str().c_str();
 }
 
 
-void LaTeXFeatures::showStruct() const{
+void LaTeXFeatures::showStruct() const {
        lyxerr << "LyX needs the following commands when LaTeXing:"
               << "\n***** Packages:" << getPackages()
               << "\n***** Macros:" << getMacros()
index 68e11ca773c89ceb83e0c568d4ebef6c651081a7..dce9cf38ee9d2b4291278aa73fb89dddd88111ff 100644 (file)
@@ -1778,8 +1778,7 @@ void Buffer::makeLaTeXFile(string const & fname,
                if (tokenPos(tclass.opt_fontsize(),
                             '|', params.fontsize) >= 0) {
                        // only write if existing in list (and not default)
-                       options << params.fontsize;
-                       options << "pt,";
+                       options << params.fontsize << "pt,";
                }
                
                
index 4e6db6dc84f24a56559cc50fe51e02110e6e9aac..021b56c74e5f2c13b446ba6b019f28fb5e67ead1 100644 (file)
@@ -197,7 +197,7 @@ public:
        void markDepClean(string const & name);
        
        ///
-       void setUnnamed(bool flag=true);
+       void setUnnamed(bool flag = true);
 
        ///
        bool isUnnamed();
@@ -574,6 +574,7 @@ bool operator!=(Buffer::TocItem const & a, Buffer::TocItem const & b) {
        // No need to compare depth.
 }
 
+
 ///
 inline
 bool operator==(Buffer::inset_iterator const & iter1,
@@ -582,6 +583,7 @@ bool operator==(Buffer::inset_iterator const & iter1,
                && (iter1.par == 0 || iter1.it == iter2.it);
 }
 
+
 ///
 inline
 bool operator!=(Buffer::inset_iterator const & iter1,
@@ -589,4 +591,3 @@ bool operator!=(Buffer::inset_iterator const & iter1,
        return !(iter1 == iter2);
 }
 #endif
-
index a6bfe6afb3595aa844c2ec1f36863336c64af6a6..7c55c45493bdd408983cc4f5f34f58645c1c9cda 100644 (file)
@@ -1,3 +1,8 @@
+2001-05-09  Lars Gullik Bjønnes  <larsbj@birdstep.com>
+
+       * FormParagraph.C: remove !NEW_INSETS and !NO_PEXTRA cruft
+       * paradlg.[Ch]: ditto
+
 2001-04-17  Lars Gullik Bjønnes  <larsbj@birdstep.com>
 
        * dlg/emptytable.h: C++ mode, inhrit privately from noncopyable
index e140ac24a6237c6979ca09c7dcf371a7515230df..b9525118ce59a2fd21da99019ad32550e2f949c1 100644 (file)
@@ -67,11 +67,7 @@ void FormParagraph::update(bool switched)
        if (align==LYX_ALIGN_LAYOUT)
                align = textclasslist.Style(buf->params.textclass, par->GetLayout()).align;
 
-#ifndef NEW_INSETS
-       LyXParagraph const * physpar = par->FirstPhysicalPar();
-#else
        LyXParagraph const * physpar = par;
-#endif
 
        if (physpar->params.spaceTop().kind() == VSpace::LENGTH) {
                LyXGlueLength above = physpar->params.spaceTop().length();
@@ -106,29 +102,6 @@ void FormParagraph::update(bool switched)
                          physpar->params.spaceBottom().kind(),
                          physpar->params.spaceTop().keep(),
                          physpar->params.spaceBottom().keep());
-
-#ifndef NO_PEXTRA 
-       // now the extras page
-
-       LyXLength extrawidth;
-       float val = 0.0;
-       LyXLength::UNIT unit = LyXLength::CM;
-
-       if (isValidLength(par->params.pextraWidth(), &extrawidth)) {
-               lyxerr[Debug::GUI] << "Reading extra width \"" << extrawidth.asString() << "\"" << endl;
-               val = extrawidth.value();
-               unit = extrawidth.unit();
-       }
-
-       lyxerr[Debug::GUI] << "Reading widthp \"" << par->params.pextraWidthp() << "\"" << endl;
-
-       dialog_->setExtra(val, unit, par->params.pextraWidthp(),
-                         par->params.pextraAlignment(),
-                         par->params.pextraHfill(),
-                         par->params.pextraStartMinipage(),
-                         static_cast<LyXParagraph::PEXTRA_TYPE>
-                         (par->params.pextraType()));
-#endif // NO_PEXTRA
 }
 
 
@@ -164,28 +137,6 @@ void FormParagraph::apply()
                spaceabove, spacebelow, dialog_->getAlign(),
                dialog_->getLabelWidth(), dialog_->getNoIndent());
 
-#ifndef NO_PEXTRA
-       // extra stuff
-
-       string width("");
-       string widthp("");
-
-       LyXLength extrawidth(dialog_->getExtraWidth());
-       if (extrawidth.unit() == LyXLength::UNIT_NONE) {
-               widthp = dialog_->getExtraWidthPercent();
-       } else
-               width = extrawidth.asString();
-
-       lyxerr[Debug::GUI] << "Setting extrawidth \"" << width << "\"" << endl;
-       lyxerr[Debug::GUI] << "Setting percent extrawidth \"" << widthp << "\"" << endl;
-
-       lv_->view()->text->SetParagraphExtraOpt(lv_->view(),
-               dialog_->getExtraType(), width, widthp,
-               dialog_->getExtraAlign(),
-               dialog_->getHfillBetween(),
-               dialog_->getStartNewMinipage());
-#endif // NO_PEXTRA 
-
        lv_->view()->update(lv_->view()->text, 
                            BufferView::SELECT |
                            BufferView::FITCUR |
@@ -198,10 +149,12 @@ void FormParagraph::apply()
 void FormParagraph::show()
 {
        if (!dialog_)
-               dialog_ = new ParaDialog(this, 0, _("LyX: Paragraph Options"), false);
+               dialog_ = new ParaDialog(this, 0,
+                                        _("LyX: Paragraph Options"), false);
 
        if (!dialog_->isVisible())
-               h_ = d_->hideBufferDependent.connect(slot(this, &FormParagraph::hide));
+               h_ = d_->hideBufferDependent
+                       .connect(slot(this, &FormParagraph::hide));
 
        dialog_->raise();
        dialog_->setActiveWindow();
index 6bd6c141198e7e4a72fd8959c263b456f5a762d6..7b00638d89360de3ea8318f6866f916c8baa864d 100644 (file)
@@ -29,10 +29,6 @@ ParaDialog::ParaDialog(FormParagraph * form, QWidget * parent, char const * name
 
        generalpage = new ParaGeneralDialog(this, "generalpage");
        tabstack->addTabPage(generalpage, _("&General"));
-#ifndef NO_PEXTRA
-       extrapage = new ParaExtraDialog(this, "extrapage");
-       tabstack->addTabPage(extrapage, _("&Extra"));
-#endif
 
        setUpdatesEnabled(true);
        update();
@@ -200,82 +196,6 @@ void ParaDialog::setBelowLength(float val, float plus, float minus,
 }
 
 
-#ifndef NO_PEXTRA
-void ParaDialog::setExtra(float widthval, LyXLength::UNIT units, const string percent, int align,
-       bool hfill, bool startminipage, LyXParagraph::PEXTRA_TYPE type)
-{
-       if (type!=LyXParagraph::PEXTRA_NONE) {
-               lyxerr[Debug::GUI] << "percent : $" << percent << "$ widthval " << widthval << " unit " << long(units) << endl;
-               if (percent != "") {
-                       extrapage->line_widthvalue->setText(percent.c_str());
-                       extrapage->combo_widthvalueunits->setCurrentItem(11);
-               } else {
-                       int unit = 0;
-                       extrapage->line_widthvalue->setText(tostr(widthval).c_str());
-                       switch (units) {
-                               case LyXLength::CM: unit = 0; break;
-                               case LyXLength::IN: unit = 1; break;
-                               case LyXLength::PT: unit = 2; break;
-                               case LyXLength::MM: unit = 3; break;
-                               case LyXLength::PC: unit = 4; break;
-                               case LyXLength::EX: unit = 5; break;
-                               case LyXLength::EM: unit = 6; break;
-                               case LyXLength::SP: unit = 7; break;
-                               case LyXLength::BP: unit = 8; break;
-                               case LyXLength::DD: unit = 9; break;
-                               case LyXLength::CC: unit = 10; break;
-                               case LyXLength::MU: unit = 0; break;
-                               case LyXLength::UNIT_NONE: unit = 0; break;
-                               default:
-                                       lyxerr[Debug::GUI] << "Unknown unit " << long(units) << endl;
-                       }
-                       extrapage->combo_widthvalueunits->setCurrentItem(unit);
-               }
-       } else
-               extrapage->line_widthvalue->setText("");
-
-       switch (align) {
-               case LyXParagraph::MINIPAGE_ALIGN_TOP:
-                       extrapage->radio_top->setChecked(true);
-                       break;
-               case LyXParagraph::MINIPAGE_ALIGN_MIDDLE:
-                       extrapage->radio_middle->setChecked(true);
-                       break;
-               case LyXParagraph::MINIPAGE_ALIGN_BOTTOM:
-                       extrapage->radio_bottom->setChecked(true);
-                       break;
-       }
-       
-       extrapage->check_hfillbetween->setChecked(hfill);
-       extrapage->check_startnewminipage->setChecked(startminipage);
-
-       extrapage->specialalignment->setEnabled(type==LyXParagraph::PEXTRA_MINIPAGE);
-       extrapage->radio_top->setEnabled(type==LyXParagraph::PEXTRA_MINIPAGE);
-       extrapage->radio_middle->setEnabled(type==LyXParagraph::PEXTRA_MINIPAGE);
-       extrapage->radio_bottom->setEnabled(type==LyXParagraph::PEXTRA_MINIPAGE);
-       extrapage->line_widthvalue->setEnabled(type!=LyXParagraph::PEXTRA_NONE);
-       extrapage->combo_widthvalueunits->setEnabled(type!=LyXParagraph::PEXTRA_NONE);
-       extrapage->check_hfillbetween->setEnabled(type==LyXParagraph::PEXTRA_MINIPAGE);
-       extrapage->check_startnewminipage->setEnabled(type==LyXParagraph::PEXTRA_MINIPAGE);
-
-       switch (type) {
-               case LyXParagraph::PEXTRA_NONE:
-                       extrapage->combo_type->setCurrentItem(0);
-                       break;
-               case LyXParagraph::PEXTRA_INDENT:
-                       extrapage->combo_type->setCurrentItem(1);
-                       break;
-               case LyXParagraph::PEXTRA_MINIPAGE:
-                       extrapage->combo_type->setCurrentItem(2);
-                       break;
-               case LyXParagraph::PEXTRA_FLOATFLT:
-                       extrapage->combo_type->setCurrentItem(3);
-                       break;
-       }
-}
-#endif // NO_PEXTRA 
-
-
 LyXGlueLength ParaDialog::getAboveLength() const
 {
        LyXGlueLength len(
@@ -304,46 +224,3 @@ LyXGlueLength ParaDialog::getBelowLength() const
        
        return len;
 }
-
-
-#ifndef NO_PEXTRA
-LyXLength ParaDialog::getExtraWidth() const
-{
-
-       if (extrapage->combo_widthvalueunits->currentItem() != 11) {
-               LyXLength::UNIT unit = LyXLength::CM;
-               switch (extrapage->combo_widthvalueunits->currentItem()) {
-                       case 0: unit = LyXLength::CM; break;
-                       case 1: unit = LyXLength::IN; break;
-                       case 2: unit = LyXLength::PT; break;
-                       case 3: unit = LyXLength::MM; break;
-                       case 4: unit = LyXLength::PC; break;
-                       case 5: unit = LyXLength::EX; break;
-                       case 6: unit = LyXLength::EM; break;
-                       case 7: unit = LyXLength::SP; break;
-                       case 8: unit = LyXLength::BP; break;
-                       case 9: unit = LyXLength::DD; break;
-                       case 10: unit = LyXLength::CC; break;
-                       case 11: unit = LyXLength::CM; break;
-                       default:
-                               lyxerr[Debug::GUI] << "Unknown unit " << extrapage->combo_widthvalueunits->currentItem() << endl;
-               }
-               LyXLength len(strToDbl(extrapage->line_widthvalue->text()), unit);
-               return len;
-       } else {
-               LyXLength len(0.0, LyXLength::UNIT_NONE);
-               return len;
-       }
-}
-
-
-string ParaDialog::getExtraWidthPercent() const
-{
-       double val = strToDbl(extrapage->line_widthvalue->text());
-       if (val > 100.0)
-               val = 100.0;
-       if (val < 0.0)
-               val = 0.0;
-       return tostr(val);
-}
-#endif // NO_PEXTRA
index bc3375849864aa232263c1859a9d27070ec86b9c..ca11f21665475a0b4882694a01ada610866ff8ec 100644 (file)
@@ -38,9 +38,6 @@ public:
        void setSpace(VSpace::vspace_kind, VSpace::vspace_kind, bool, bool);
        void setAboveLength(float, float, float, LyXGlueLength::UNIT, LyXGlueLength::UNIT, LyXGlueLength::UNIT);
        void setBelowLength(float, float, float, LyXGlueLength::UNIT, LyXGlueLength::UNIT, LyXGlueLength::UNIT);
-#ifndef NO_PEXTRA 
-       void setExtra(float, LyXGlueLength::UNIT, const string, int, bool, bool, LyXParagraph::PEXTRA_TYPE);
-#endif 
 
        char const * getLabelWidth() const {
                return generalpage->line_labelwidth->text();
@@ -95,38 +92,6 @@ public:
        LyXGlueLength getAboveLength() const;
 
        LyXGlueLength getBelowLength() const;
-#ifndef NO_PEXTRA
-       LyXLength getExtraWidth() const;
-
-       string getExtraWidthPercent() const;
-
-       LyXParagraph::PEXTRA_TYPE getExtraType() const {
-               switch (extrapage->combo_type->currentItem()) {
-                       case 0: return LyXParagraph::PEXTRA_NONE;
-                       case 1: return LyXParagraph::PEXTRA_INDENT;
-                       case 2: return LyXParagraph::PEXTRA_MINIPAGE;
-                       case 3: return LyXParagraph::PEXTRA_FLOATFLT;
-               }
-               return LyXParagraph::PEXTRA_NONE;
-       }
-
-       LyXParagraph::MINIPAGE_ALIGNMENT getExtraAlign() const {
-               if (extrapage->radio_top->isChecked())
-                       return LyXParagraph::MINIPAGE_ALIGN_TOP;
-               if (extrapage->radio_middle->isChecked())
-                       return LyXParagraph::MINIPAGE_ALIGN_MIDDLE;
-               return LyXParagraph::MINIPAGE_ALIGN_BOTTOM;
-       }
-
-       bool getHfillBetween() const {
-               return extrapage->check_hfillbetween->isChecked();
-       }
-
-       bool getStartNewMinipage() const {
-               return extrapage->check_startnewminipage->isChecked();
-       }
-#endif
 protected:
        void closeEvent(QCloseEvent * e);
 
@@ -135,10 +100,6 @@ private:
 
        /// the general tab page
        ParaGeneralDialog * generalpage;
-#ifndef NO_PEXTRA 
-       /// the extra options tab page
-       ParaExtraDialog * extrapage;
-#endif
  
        VSpace::vspace_kind getSpaceKind(int val) const {
                switch (val) {
index 9bc9b0b1beeb2e9044d49f82981595910deccf26..a52314e2af3f0967f371ffd0096d3fcc7f49e23e 100644 (file)
@@ -1,3 +1,7 @@
+2001-05-09  Lars Gullik Bjønnes  <larsbj@birdstep.com>
+
+       * FormParagraph.C: remove !NEW_INSETS and !NO_PEXTRA cruft
+
 2001-04-03  John Levon  <moz@compsoc.man.ac.uk>
 
        * FormCharacter.C:
index ecb65b8bcc2c49b2f4f1c294497916cb3c96ee27..17fd71e5f77e8d8cd90574cffad78196cd5e22f3 100644 (file)
@@ -23,6 +23,7 @@ using SigC::slot;
 using Liason::setMinibuffer;
 using std::endl;
 
+
 FormParagraph::FormParagraph(LyXView *v, Dialogs *d)
        : dialog_(0), lv_(v), d_(d), h_(0)
 {
@@ -32,11 +33,13 @@ FormParagraph::FormParagraph(LyXView *v, Dialogs *d)
        d->showLayoutParagraph.connect(slot(this, &FormParagraph::show));
 }
 
+
 FormParagraph::~FormParagraph()
 {
        delete dialog_;
 }
 
+
 void FormParagraph::update(bool switched)
 {
        if (switched) {
@@ -47,14 +50,14 @@ void FormParagraph::update(bool switched)
        if (!lv_->view()->available())
                return;
 
-       Buffer *buf = lv_->view()->buffer();
+       Buffer * buf = lv_->view()->buffer();
 
        if (readonly!=buf->isReadonly()) {
                readonly = buf->isReadonly();
                dialog_->setReadOnly(readonly);
        }
 
-       LyXText *text = 0;
+       LyXText * text = 0;
 
        if (lv_->view()->theLockingInset())
                text = lv_->view()->theLockingInset()->getLyXText(lv_->view());
@@ -62,18 +65,14 @@ void FormParagraph::update(bool switched)
        if (!text)
                text = lv_->view()->text;
 
-       LyXParagraph *par = text->cursor.par();
+       LyXParagraph * par = text->cursor.par();
 
        int align = par->GetAlign();
 
        if (align==LYX_ALIGN_LAYOUT)
                align = textclasslist.Style(buf->params.textclass, par->GetLayout()).align;
 
-#ifndef NEW_INSETS
-       ParagraphParameters *params = &(par->FirstPhysicalPar()->params);
-#else
        ParagraphParameters *params = &(par->params);
-#endif
 
        if (params->spaceTop().kind() == VSpace::LENGTH) {
                LyXGlueLength above = params->spaceTop().length();
@@ -119,6 +118,7 @@ void FormParagraph::update(bool switched)
                static_cast<LyXParagraph::PEXTRA_TYPE>(params->pextraType()));
 }
 
+
 void FormParagraph::apply()
 {
        if (readonly)
@@ -163,13 +163,6 @@ void FormParagraph::apply()
        lyxerr[Debug::GUI] << "Setting extrawidth \"" << width << "\"" << endl;
        lyxerr[Debug::GUI] << "Setting percent extrawidth \"" << widthp << "\"" << endl;
 
-#ifndef NO_PEXTRA
-       lv_->view()->text->SetParagraphExtraOpt(lv_->view(),
-               dialog_->getExtraType(), width, widthp,
-               dialog_->getExtraAlign(),
-               dialog_->getHfillBetween(),
-               dialog_->getStartNewMinipage());
-#endif
        lv_->view()->update(lv_->view()->text,
                            BufferView::SELECT |
                            BufferView::FITCUR |
@@ -179,14 +172,17 @@ void FormParagraph::apply()
        setMinibuffer(lv_, _("Paragraph layout set"));
 }
 
+
 void FormParagraph::show()
 {
        if (!dialog_)
-               dialog_ = new ParagraphDlgImpl(this, 0, _("LyX: Paragraph Options"), false);
+               dialog_ = new ParagraphDlgImpl(this, 0,
+                                              _("LyX: Paragraph Options"),
+                                              false);
 
        if (!dialog_->isVisible())
-               h_ = d_->hideBufferDependent.connect(slot(this, &FormParagraph::hide));
-
+               h_ = d_->hideBufferDependent
+                       .connect(slot(this, &FormParagraph::hide));
 
        dialog_->raise();
        dialog_->setActiveWindow();
@@ -195,11 +191,13 @@ void FormParagraph::show()
        dialog_->show();
 }
 
+
 void FormParagraph::close()
 {
        h_.disconnect();
 }
 
+
 void FormParagraph::hide()
 {
        dialog_->hide();
index 8472c72e5949a1d058fb17aec467f81c3769d10a..c7705c72583213e616b313f66a15a8e582ee6386 100644 (file)
@@ -1526,7 +1526,7 @@ bool LyXParagraph::SimpleTeXOnePar(Buffer const * buf,
        LyXLayout const & style =
                textclasslist.Style(bparams.textclass,
                                    GetLayout());
-       LyXFont basefont, last_font;
+       LyXFont basefont;
 
        // Maybe we have to create a optional argument.
        size_type main_body;
@@ -1636,7 +1636,7 @@ bool LyXParagraph::SimpleTeXOnePar(Buffer const * buf,
                // Fully instantiated font
                LyXFont font = getFont(bparams, i);
 
-               last_font = running_font;
+               LyXFont last_font = running_font;
 
                // Spaces at end of font change are simulated to be
                // outside font change, i.e. we write "\textXX{text} "
@@ -2322,23 +2322,21 @@ string const LyXParagraph::String(Buffer const * buffer,
                            LyXParagraph::size_type beg,
                            LyXParagraph::size_type end)
 {
-       string s;
+       std::ostringstream ost;
 
        if (beg == 0 && !params.labelString().empty())
-               s += params.labelString() + ' ';
+               ost << params.labelString() << ' ';
 
        for (LyXParagraph::size_type i = beg; i < end; ++i) {
-               value_type c = GetUChar(buffer->params, i);
+               value_type const c = GetUChar(buffer->params, i);
                if (IsPrintable(c))
-                       s += c;
+                       ost << c;
                else if (c == META_INSET) {
-                       std::ostringstream ost;
                        GetInset(i)->Ascii(buffer, ost);
-                       s += ost.str().c_str();
                }
        }
 
-       return s;
+       return ost.str().c_str();
 }
 
 
index 572e1778df32d66d15056375b4e9856079ec3df7..08df463fd1ae5c1541bd1e439ed4bd570efb9049 100644 (file)
@@ -2692,7 +2692,7 @@ Undo * LyXText::CreateUndo(Buffer * buf, Undo::undo_kind kind,
                LyXParagraph * tmppar = start;
                LyXParagraph * tmppar2 = new LyXParagraph(*tmppar);
                tmppar2->id(tmppar->id());
-
+               
                // a memory optimization: Just store the layout information
                // when only edit
                if (kind == Undo::EDIT){