Modify string list in place instead of copying it

Spotted by Coverity scan.

diff --git a/src/frontends/qt/GuiBibtex.cpp b/src/frontends/qt/GuiBibtex.cpp
index 47dda81032fd726bd0da2dd7c13be5414c4f12dc..e6eff146f5f387c128accfbffd71cd6a192e9423 100644 (file)
--- a/src/frontends/qt/GuiBibtex.cpp
+++ b/src/frontends/qt/GuiBibtex.cpp
@@ -317,14 +317,10 @@ void GuiBibtex::relAbsPressed()
        QString const new_item = (p == LP_Absolute)
                        ? toqstr(file.relPath(buffer().filePath()))
                        : toqstr(file.absoluteFilePath());
-       QStringList sb;
-       for (QString s : selected_bibs_) {
+       for (QString & s : selected_bibs_) {
                if (s == qf)
-                       sb << new_item;
-               else
-                       sb << s;
+                       s = new_item;
        }
-       selected_bibs_ = sb;
        setSelectedBibs(selected_bibs_);
        selectedLV->selectRow(selected_bibs_.indexOf(new_item));
        changed();