Pass a docstring parameter by address

Spotted by Coverity scan.

diff --git a/src/insets/InsetCommandParams.cpp b/src/insets/InsetCommandParams.cpp
index a0d02e224568211197a81efd1f60279d88ea2704..6701c20d5f09e78489693ebe7c6174952d6e841f 100644 (file)
--- a/src/insets/InsetCommandParams.cpp
+++ b/src/insets/InsetCommandParams.cpp
@@ -99,7 +99,7 @@ static ParamInfo const & findInfo(InsetCode code, string const & cmdName)
 
 ParamInfo::ParamData::ParamData(std::string const & s, ParamType t,
                                 ParamHandling h, bool ignore,
-                                docstring default_value)
+                                docstring const & default_value)
        : name_(s), type_(t), handling_(h), ignore_(ignore),
          default_value_(default_value)
 {}

diff --git a/src/insets/InsetCommandParams.h b/src/insets/InsetCommandParams.h
index 5f463454c0b34fe73cfe29345c66ffb643adc4ef..2faaf3f545799b6a7d1c9283f5272c4152cd50d8 100644 (file)
--- a/src/insets/InsetCommandParams.h
+++ b/src/insets/InsetCommandParams.h
@@ -55,7 +55,7 @@ public:
                ///
                ParamData(std::string const &, ParamType, ParamHandling = HANDLING_NONE,
                          bool ignore = false,
-                         docstring default_value = docstring());
+                         docstring const & default_value = docstring());
                ///
                std::string name() const { return name_; }
                ///