Disable certain change tracking commands when there are no changes

Fix TODO

diff --git a/src/BufferView.cpp b/src/BufferView.cpp
index 9c19cae800264ae59f1c06fa0c4f5d8931cf1184..a158393579f74558e6b74cc9ee8b3c8cd64b3ca2 100644 (file)
--- a/src/BufferView.cpp
+++ b/src/BufferView.cpp
@@ -1130,11 +1130,7 @@ bool BufferView::getStatus(FuncRequest const & cmd, FuncStatus & flag)
        case LFUN_CHANGE_PREVIOUS:
        case LFUN_ALL_CHANGES_ACCEPT:
        case LFUN_ALL_CHANGES_REJECT:
-               // TODO: context-sensitive enabling of LFUNs
-               // In principle, these command should only be enabled if there
-               // is a change in the document. However, without proper
-               // optimizations, this will inevitably result in poor performance.
-               flag.setEnabled(true);
+               flag.setEnabled(buffer_.areChangesPresent());
                break;
 
        case LFUN_SCREEN_UP:

diff --git a/src/Changes.cpp b/src/Changes.cpp
index 1b1bceefed414c2fa2b556480ad091c94f936c72..88ecaf256dc2776dcc6a90c029713bbaf9173eca 100644 (file)
--- a/src/Changes.cpp
+++ b/src/Changes.cpp
@@ -138,6 +138,8 @@ void Changes::set(Change const & change, pos_type const start, pos_type const en
                        << ", author: " << change.author 
                        << ", time: " << long(change.changetime)
                        << ") in range (" << start << ", " << end << ")");
+               if (!isChanged())
+                       is_update_required_ = true;
        }
 
        Range const newRange(start, end);