]> git.lyx.org Git - features.git/commitdiff
fix external dialog
authorJohn Levon <levon@movementarian.org>
Thu, 31 Oct 2002 20:45:57 +0000 (20:45 +0000)
committerJohn Levon <levon@movementarian.org>
Thu, 31 Oct 2002 20:45:57 +0000 (20:45 +0000)
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@5568 a592a061-630c-0410-9148-cb99ea01b6c8

src/frontends/qt2/ChangeLog
src/frontends/qt2/QExternal.C

index c10a005cdd9a66dd60f38998469968e0fa15e8cd..1fb051d704f0fa898034561bc2d0a4356b0ebd9b 100644 (file)
@@ -1,9 +1,13 @@
 2002-10-31  John Levon  <levon@movementarian.org>
 
-       * qt2/QGraphics.C:
-       * qt2/QGraphicsDialog.C:
-       * qt2/QGraphicsDialog.h:
-       * qt2/ui/QGraphicsDialog.ui: bb unit fixes
+       * QExternal.C: fix crash, valid check
+2002-10-31  John Levon  <levon@movementarian.org>
+
+       * QGraphics.C:
+       * QGraphicsDialog.C:
+       * QGraphicsDialog.h:
+       * ui/QGraphicsDialog.ui: bb unit fixes
  
 2002-10-30  John Levon  <levon@movementarian.org>
 
index 90042d0370395dc9b95be1202107c41d0f38b40e..69f2a6965f87fd23578895208e0b3eec9d5abb7c 100644 (file)
@@ -74,7 +74,7 @@ string const & QExternal::helpText()
 {
        InsetExternal::Params & params = controller().params();
 
-       params.templ = controller().getTemplate(dialog_->externalCO->currentItem() + 1);
+       params.templ = controller().getTemplate(dialog_->externalCO->currentItem());
        return params.templ.helpText;
 }
 
@@ -86,15 +86,5 @@ void QExternal::apply()
        params.filename = dialog_->fileED->text().latin1();
        params.parameters = dialog_->paramsED->text().latin1();
 
-       params.templ = controller().getTemplate(dialog_->externalCO->currentItem() + 1);
-}
-
-
-bool QExternal::isValid()
-{
-       bool const valid = !string(dialog_->fileED->text()).empty();
-       dialog_->viewPB->setEnabled(valid);
-       dialog_->editPB->setEnabled(valid);
-       dialog_->updatePB->setEnabled(valid);
-       return valid;
+       params.templ = controller().getTemplate(dialog_->externalCO->currentItem());
 }