* src/BufferView.C: add comments on why several
change tracking-related LFUNs are always enabled
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@16034
a592a061-630c-0410-9148-
cb99ea01b6c8
case LFUN_CHANGE_NEXT:
case LFUN_ALL_CHANGES_ACCEPT:
case LFUN_ALL_CHANGES_REJECT:
case LFUN_CHANGE_NEXT:
case LFUN_ALL_CHANGES_ACCEPT:
case LFUN_ALL_CHANGES_REJECT:
- flag.enabled(buffer_); // FIXME: Change tracking (MG)
+ // TODO: context-sensitive enabling of LFUNs
+ // In principle, these command should only be enabled if there
+ // is a change in the document. However, without proper
+ // optimizations, this will inevitably result in poor performance.
+ flag.enabled(buffer_);
break;
case LFUN_BUFFER_TOGGLE_COMPRESSION: {
break;
case LFUN_BUFFER_TOGGLE_COMPRESSION: {
case LFUN_CHANGE_ACCEPT:
case LFUN_CHANGE_REJECT:
case LFUN_CHANGE_ACCEPT:
case LFUN_CHANGE_REJECT:
- enable = true; // FIXME: Change tracking (MG)
+ // TODO: context-sensitive enabling of LFUN_CHANGE_ACCEPT/REJECT
+ // In principle, these LFUNs should only be enabled if there
+ // is a change at the current position/in the current selection.
+ // However, without proper optimizations, this will inevitably
+ // result in unacceptable performance - just imagine a user who
+ // wants to select the complete content of a long document.
+ enable = true;
break;
case LFUN_WORD_DELETE_FORWARD:
break;
case LFUN_WORD_DELETE_FORWARD: