Also rename first_visible_cell to first_visible_cell_. I wonder though whether this variable is still useful.
Coverity issue 23383
InsetTabular::InsetTabular(Buffer * buf, row_type rows,
col_type columns)
: Inset(buf), tabular(buf, max(rows, row_type(1)), max(columns, col_type(1))),
InsetTabular::InsetTabular(Buffer * buf, row_type rows,
col_type columns)
: Inset(buf), tabular(buf, max(rows, row_type(1)), max(columns, col_type(1))),
- rowselect_(false), colselect_(false)
+ first_visible_cell_(0), offset_valign_(0), rowselect_(false), colselect_(false)
bool const original_selection_state = pi.selected;
idx_type idx = 0;
bool const original_selection_state = pi.selected;
idx_type idx = 0;
- first_visible_cell = Tabular::npos;
+ first_visible_cell_ = Tabular::npos;
int yy = y + offset_valign_;
for (row_type r = 0; r < tabular.nrows(); ++r) {
int yy = y + offset_valign_;
for (row_type r = 0; r < tabular.nrows(); ++r) {
- if (first_visible_cell == Tabular::npos)
- first_visible_cell = idx;
+ if (first_visible_cell_ == Tabular::npos)
+ first_visible_cell_ = idx;
pi.selected |= isCellSelected(cur, r, c);
int const cx = nx + tabular.textHOffset(idx);
pi.selected |= isCellSelected(cur, r, c);
int const cx = nx + tabular.textHOffset(idx);
// int const t = cur.bv().top_y() + cur.bv().height();
// if (t < yo() + tabular.getHeightOfTabular()) {
// cur.bv().scrollDocView(t, true);
// int const t = cur.bv().top_y() + cur.bv().height();
// if (t < yo() + tabular.getHeightOfTabular()) {
// cur.bv().scrollDocView(t, true);
-// cur.idx() = tabular.cellBelow(first_visible_cell) + col;
+// cur.idx() = tabular.cellBelow(first_visible_cell_) + col;
// } else {
// cur.idx() = tabular.getFirstCellInRow(tabular.rows() - 1) + col;
// }
// } else {
// cur.idx() = tabular.getFirstCellInRow(tabular.rows() - 1) + col;
// }
// if (yo() > 0)
// cur.idx() = col;
// else
// if (yo() > 0)
// cur.idx() = col;
// else
-// cur.idx() = tabular.cellBelow(first_visible_cell) + col;
+// cur.idx() = tabular.cellBelow(first_visible_cell_) + col;
// } else {
// cur.idx() = col;
// }
// } else {
// cur.idx() = col;
// }
row_type row_start, row_type row_end,
col_type col_start, col_type col_end) const;
///
row_type row_start, row_type row_end,
col_type col_start, col_type col_end) const;
///
- mutable idx_type first_visible_cell;
+ mutable idx_type first_visible_cell_;
/// The vertical offset of the table due to the vertical
/// alignment with respect to the baseline.
mutable int offset_valign_;
/// The vertical offset of the table due to the vertical
/// alignment with respect to the baseline.
mutable int offset_valign_;