]> git.lyx.org Git - lyx.git/commit
This is the result of an audit of all static variables, looking
authorRichard Heck <rgheck@lyx.org>
Mon, 7 Oct 2013 22:59:05 +0000 (18:59 -0400)
committerRichard Heck <rgheck@lyx.org>
Mon, 21 Apr 2014 15:51:57 +0000 (11:51 -0400)
commitfdbe775b9f5468e8f53dc83a66583f412b5970fb
tree025078a8d495a01e9578acd0deb39f2c9da8c5cd
parent3d6790607ef6dec5c5be8b1a720eb1ca31c3a15b
This is the result of an audit of all static variables, looking
for possible thread conflicts, of the sort Georg resolved at
6a30211f. I have made static variables const where possible,
and marked cases that looked potentially problematic with the
comment:
// FIXME THREAD
Many of these definitely are vulnerable to concurrent access, such
as the static variables declared at the start of output_latex.cpp.
Suppose, e.g., we were outputting latex and also displaying the
source of a different document.

I'd appreciate it if others could grep for "FIXME THREAD" and see
if some of these are harmless, or what.
51 files changed:
src/BiblioInfo.cpp
src/Buffer.cpp
src/BufferList.cpp
src/BufferParams.cpp
src/BufferView.cpp
src/Changes.cpp
src/ConverterCache.cpp
src/CutAndPaste.cpp
src/FloatList.cpp
src/FontList.cpp
src/FontList.h
src/Format.cpp
src/KeyMap.cpp
src/LaTeX.cpp
src/LaTeXFeatures.cpp
src/Layout.cpp
src/buffer_funcs.cpp
src/frontends/qt4/FindAndReplace.cpp
src/frontends/qt4/GuiCitation.cpp
src/frontends/qt4/GuiDelimiter.cpp
src/frontends/qt4/GuiDocument.cpp
src/frontends/qt4/GuiFontLoader.cpp
src/frontends/qt4/GuiGraphics.cpp
src/frontends/qt4/GuiInclude.cpp
src/frontends/qt4/GuiListings.cpp
src/frontends/qt4/GuiPainter.cpp
src/frontends/qt4/GuiParagraph.cpp
src/frontends/qt4/GuiSymbols.cpp
src/frontends/qt4/GuiViewSource.cpp
src/frontends/qt4/GuiWorkArea.cpp
src/graphics/GraphicsConverter.cpp
src/graphics/GraphicsLoader.cpp
src/graphics/PreviewLoader.cpp
src/insets/InsetBibitem.cpp
src/insets/InsetBox.cpp
src/insets/InsetIPAMacro.cpp
src/insets/InsetInclude.cpp
src/insets/InsetNote.cpp
src/insets/InsetPhantom.cpp
src/insets/InsetRef.cpp
src/insets/InsetRef.h
src/insets/InsetScript.cpp
src/output_latex.cpp
src/sgml.cpp
src/support/FileName.cpp
src/support/Systemcall.cpp
src/support/debug.cpp
src/support/environment.cpp
src/support/filetools.cpp
src/support/lstrings.cpp
src/support/os.cpp