]> git.lyx.org Git - lyx.git/commit
Pass shared_ptr<> arguments by const reference
authorJean-Marc Lasgouttes <lasgouttes@lyx.org>
Fri, 13 Sep 2024 12:54:43 +0000 (14:54 +0200)
committerJean-Marc Lasgouttes <lasgouttes@lyx.org>
Fri, 13 Sep 2024 12:54:43 +0000 (14:54 +0200)
commit3af0bad22a9f6200fcfc09534f5c0925ad63271c
treefda4a05a55baeb213df459d578c1e2ad28de70b2
parent58ee4c9ec74172b7600f1cc5d2299eba465496d7
Pass shared_ptr<> arguments by const reference

These arguments are not expensive to copy. However, it makes sense to
pass such pointers by const reference when they are just intended for
reading.

Some reading about this issue is here:
https://www.internalpointers.com/post/move-smart-pointers-and-out-functions-modern-c

Fixes some Coverity scan defects.
src/TocBuilder.cpp
src/TocBuilder.h
src/frontends/qt/Action.cpp
src/frontends/qt/Action.h
src/frontends/qt/TocModel.cpp
src/frontends/qt/TocModel.h
src/support/FileMonitor.cpp
src/support/FileMonitor.h