X-Git-Url: https://git.lyx.org/gitweb/?a=blobdiff_plain;f=src%2Ftext2.C;h=a570b387d498bc6d98110e482c25e1f2a57ad88a;hb=ee2966faba5563fb853f31f4d3d1785d380e1332;hp=5ae0ce3006185f73b24ffb96b6cadb87968dedc0;hpb=4d96e200f04d2a3f83c5bcf8fb63fb1659bafca6;p=lyx.git

diff --git a/src/text2.C b/src/text2.C
index 5ae0ce3006..a570b387d4 100644
--- a/src/text2.C
+++ b/src/text2.C
@@ -26,6 +26,7 @@
 #include "bufferlist.h"
 #include "bufferparams.h"
 #include "BufferView.h"
+#include "bufferview_funcs.h"
 #include "Bullet.h"
 #include "coordcache.h"
 #include "cursor.h"
@@ -41,6 +42,7 @@
 #include "lyxrc.h"
 #include "lyxrow.h"
 #include "paragraph.h"
+#include "TextMetrics.h"
 #include "paragraph_funcs.h"
 #include "ParagraphParameters.h"
 #include "pariterator.h"
@@ -51,7 +53,7 @@
 
 #include "frontends/FontMetrics.h"
 
-#include "insets/insetenv.h"
+#include "insets/InsetEnv.h"
 
 #include "mathed/InsetMathHull.h"
 
@@ -71,30 +73,13 @@ using std::max;
 using std::min;
 
 
-LyXText::LyXText(BufferView * bv)
-	: maxwidth_(bv ? bv->workWidth() : 100),
-	  current_font(LyXFont::ALL_INHERIT),
+LyXText::LyXText()
+	: current_font(LyXFont::ALL_INHERIT),
 	  background_color_(LColor::background),
 	  autoBreakRows_(false)
 {}
 
 
-void LyXText::init(BufferView * bv)
-{
-	BOOST_ASSERT(bv);
-	maxwidth_ = bv->workWidth();
-	dim_.wid = maxwidth_;
-	dim_.asc = 10;
-	dim_.des = 10;
-
-	pit_type const end = paragraphs().size();
-	for (pit_type pit = 0; pit != end; ++pit)
-		pars_[pit].rows().clear();
-
-	updateLabels(*bv->buffer());
-}
-
-
 bool LyXText::isMainText(Buffer const & buffer) const
 {
 	return &buffer.text() == this;
@@ -109,7 +94,7 @@ InsetBase * LyXText::checkInsetHit(BufferView & bv, int x, int y)
 
 	Paragraph const & par = pars_[pit];
 
-	lyxerr[Debug::DEBUG]
+	LYXERR(Debug::DEBUG)
 		<< BOOST_CURRENT_FUNCTION
 		<< ": x: " << x
 		<< " y: " << y
@@ -120,12 +105,12 @@ InsetBase * LyXText::checkInsetHit(BufferView & bv, int x, int y)
 	for (; iit != iend; ++iit) {
 		InsetBase * inset = iit->inset;
 #if 1
-		lyxerr[Debug::DEBUG]
+		LYXERR(Debug::DEBUG)
 			<< BOOST_CURRENT_FUNCTION
 			<< ": examining inset " << inset << endl;
 
 		if (bv.coordCache().getInsets().has(inset))
-			lyxerr[Debug::DEBUG]
+			LYXERR(Debug::DEBUG)
 				<< BOOST_CURRENT_FUNCTION
 				<< ": xo: " << inset->xo(bv) << "..."
 				<< inset->xo(bv) + inset->width()
@@ -134,18 +119,18 @@ InsetBase * LyXText::checkInsetHit(BufferView & bv, int x, int y)
 				<< inset->yo(bv) + inset->descent()
 				<< endl;
 		else
-			lyxerr[Debug::DEBUG]
+			LYXERR(Debug::DEBUG)
 				<< BOOST_CURRENT_FUNCTION
 				<< ": inset has no cached position" << endl;
 #endif
 		if (inset->covers(bv, x, y)) {
-			lyxerr[Debug::DEBUG]
+			LYXERR(Debug::DEBUG)
 				<< BOOST_CURRENT_FUNCTION
 				<< ": Hit inset: " << inset << endl;
 			return inset;
 		}
 	}
-	lyxerr[Debug::DEBUG]
+	LYXERR(Debug::DEBUG)
 		<< BOOST_CURRENT_FUNCTION
 		<< ": No inset hit. " << endl;
 	return 0;
@@ -350,9 +335,11 @@ void LyXText::setLayout(Buffer const & buffer, pit_type start, pit_type end,
 	LyXLayout_ptr const & lyxlayout = bufparams.getLyXTextClass()[layout];
 
 	for (pit_type pit = start; pit != end; ++pit) {
-		pars_[pit].applyLayout(lyxlayout);
+		Paragraph & par = pars_[pit];
+		par.applyLayout(lyxlayout);
 		if (lyxlayout->margintype == MARGIN_MANUAL)
-			pars_[pit].setLabelWidthString(buffer.translateLabel(lyxlayout->labelstring()));
+			par.setLabelWidthString(par.translateIfPossible(
+				lyxlayout->labelstring(), buffer.params()));
 	}
 }
 
@@ -367,7 +354,7 @@ void LyXText::setLayout(LCursor & cur, string const & layout)
 	LyXLayout_ptr const & lyxlayout = params.getLyXTextClass()[layout];
 	if (lyxlayout->is_environment) {
 		// move everything in a new environment inset
-		lyxerr[Debug::DEBUG] << "setting layout " << layout << endl;
+		LYXERR(Debug::DEBUG) << "setting layout " << layout << endl;
 		lyx::dispatch(FuncRequest(LFUN_LINE_BEGIN));
 		lyx::dispatch(FuncRequest(LFUN_LINE_END_SELECT));
 		lyx::dispatch(FuncRequest(LFUN_CUT));
@@ -502,7 +489,8 @@ void LyXText::setFont(LCursor & cur, LyXFont const & font, bool toggleall)
 bool LyXText::cursorHome(LCursor & cur)
 {
 	BOOST_ASSERT(this == cur.text());
-	Row const & row = cur.paragraph().getRow(cur.pos(),cur.boundary());
+	ParagraphMetrics const & pm = cur.bv().parMetrics(this, cur.pit());
+	Row const & row = pm.getRow(cur.pos(),cur.boundary());
 	return setCursor(cur, cur.pit(), row.pos());
 }
 
@@ -685,7 +673,7 @@ bool LyXText::setCursor(LCursor & cur, pit_type par, pos_type pos,
 {
 	LCursor old = cur;
 	setCursorIntern(cur, par, pos, setfont, boundary);
-	return deleteEmptyParagraphMechanism(cur, old);
+	return cur.bv().checkDepm(cur, old);
 }
 
 
@@ -719,7 +707,6 @@ void LyXText::setCursorIntern(LCursor & cur,
 	BOOST_ASSERT(this == cur.text());
 	cur.boundary(boundary);
 	setCursor(cur.top(), par, pos);
-	cur.setTargetX();
 	if (setfont)
 		setCurrentFont(cur);
 }
@@ -763,153 +750,13 @@ void LyXText::setCurrentFont(LCursor & cur)
 	}
 }
 
-
-// x is an absolute screen coord
-// returns the column near the specified x-coordinate of the row
-// x is set to the real beginning of this column
-pos_type LyXText::getColumnNearX(BufferView const & bv, pit_type const pit,
-				 Row const & row, int & x, bool & boundary) const
-{
-	Buffer const & buffer = *bv.buffer();
-	int const xo = bv.coordCache().get(this, pit).x_;
-	x -= xo;
-	RowMetrics const r = computeRowMetrics(buffer, pit, row);
-	Paragraph const & par = pars_[pit];
-
-	pos_type vc = row.pos();
-	pos_type end = row.endpos();
-	pos_type c = 0;
-	LyXLayout_ptr const & layout = par.layout();
-
-	bool left_side = false;
-
-	pos_type body_pos = par.beginOfBody();
-
-	double tmpx = r.x;
-	double last_tmpx = tmpx;
-
-	if (body_pos > 0 &&
-	    (body_pos > end || !par.isLineSeparator(body_pos - 1)))
-		body_pos = 0;
-
-	// check for empty row
-	if (vc == end) {
-		x = int(tmpx) + xo;
-		return 0;
-	}
-
-	frontend::FontMetrics const & fm 
-		= theFontMetrics(getLabelFont(buffer, par));
-
-	while (vc < end && tmpx <= x) {
-		c = bidi.vis2log(vc);
-		last_tmpx = tmpx;
-		if (body_pos > 0 && c == body_pos - 1) {
-			// FIXME UNICODE
-			docstring const lsep = from_utf8(layout->labelsep);
-			tmpx += r.label_hfill + fm.width(lsep);
-			if (par.isLineSeparator(body_pos - 1))
-				tmpx -= singleWidth(buffer, par, body_pos - 1);
-		}
-
-		if (par.hfillExpansion(row, c)) {
-			tmpx += singleWidth(buffer, par, c);
-			if (c >= body_pos)
-				tmpx += r.hfill;
-			else
-				tmpx += r.label_hfill;
-		} else if (par.isSeparator(c)) {
-			tmpx += singleWidth(buffer, par, c);
-			if (c >= body_pos)
-				tmpx += r.separator;
-		} else {
-			tmpx += singleWidth(buffer, par, c);
-		}
-		++vc;
-	}
-
-	if ((tmpx + last_tmpx) / 2 > x) {
-		tmpx = last_tmpx;
-		left_side = true;
-	}
-
-	BOOST_ASSERT(vc <= end);  // This shouldn't happen.
-
-	boundary = false;
-	// This (rtl_support test) is not needed, but gives
-	// some speedup if rtl_support == false
-	bool const lastrow = lyxrc.rtl_support && row.endpos() == par.size();
-
-	// If lastrow is false, we don't need to compute
-	// the value of rtl.
-	bool const rtl = lastrow ? isRTL(buffer, par) : false;
-	if (lastrow &&
-	    ((rtl  &&  left_side && vc == row.pos() && x < tmpx - 5) ||
-	     (!rtl && !left_side && vc == end  && x > tmpx + 5)))
-		c = end;
-	else if (vc == row.pos()) {
-		c = bidi.vis2log(vc);
-		if (bidi.level(c) % 2 == 1)
-			++c;
-	} else {
-		c = bidi.vis2log(vc - 1);
-		bool const rtl = (bidi.level(c) % 2 == 1);
-		if (left_side == rtl) {
-			++c;
-			boundary = bidi.isBoundary(buffer, par, c);
-		}
-	}
-
-// I believe this code is not needed anymore (Jug 20050717)
-#if 0
-	// The following code is necessary because the cursor position past
-	// the last char in a row is logically equivalent to that before
-	// the first char in the next row. That's why insets causing row
-	// divisions -- Newline and display-style insets -- must be treated
-	// specially, so cursor up/down doesn't get stuck in an air gap -- MV
-	// Newline inset, air gap below:
-	if (row.pos() < end && c >= end && par.isNewline(end - 1)) {
-		if (bidi.level(end -1) % 2 == 0)
-			tmpx -= singleWidth(buffer, par, end - 1);
-		else
-			tmpx += singleWidth(buffer, par, end - 1);
-		c = end - 1;
-	}
-
-	// Air gap above display inset:
-	if (row.pos() < end && c >= end && end < par.size()
-	    && par.isInset(end) && par.getInset(end)->display()) {
-		c = end - 1;
-	}
-	// Air gap below display inset:
-	if (row.pos() < end && c >= end && par.isInset(end - 1)
-	    && par.getInset(end - 1)->display()) {
-		c = end - 1;
-	}
-#endif
-
-	x = int(tmpx) + xo;
-	pos_type const col = c - row.pos();
-
-	if (!c || end == par.size())
-		return col;
-
-	if (c==end && !par.isLineSeparator(c-1) && !par.isNewline(c-1)) {
-		boundary = true;
-		return col;
-	}
-
-	return min(col, end - 1 - row.pos());
-}
-
-
 // y is screen coordinate
-pit_type LyXText::getPitNearY(BufferView & bv, int y)
+pit_type LyXText::getPitNearY(BufferView & bv, int y) const
 {
 	BOOST_ASSERT(!paragraphs().empty());
 	BOOST_ASSERT(bv.coordCache().getParPos().find(this) != bv.coordCache().getParPos().end());
 	CoordCache::InnerParPosCache const & cc = bv.coordCache().getParPos().find(this)->second;
-	lyxerr[Debug::DEBUG]
+	LYXERR(Debug::DEBUG)
 		<< BOOST_CURRENT_FUNCTION
 		<< ": y: " << y << " cache size: " << cc.size()
 		<< endl;
@@ -921,52 +768,59 @@ pit_type LyXText::getPitNearY(BufferView & bv, int y)
 	CoordCache::InnerParPosCache::const_iterator et = cc.end();
 	CoordCache::InnerParPosCache::const_iterator last = et; last--;
 
+	TextMetrics & tm = bv.textMetrics(this);
+	ParagraphMetrics const & pm = tm.parMetrics(it->first);
+
 	// If we are off-screen (before the visible part)
 	if (y < 0
 		// and even before the first paragraph in the cache.
-		&& y < it->second.y_ - int(pars_[it->first].ascent())) {
+		&& y < it->second.y_ - int(pm.ascent())) {
 		//  and we are not at the first paragraph in the inset.
 		if (it->first == 0)
 			return 0;
 		// then this is the paragraph we are looking for.
 		pit = it->first - 1;
 		// rebreak it and update the CoordCache.
-		redoParagraph(bv, pit);
+		tm.redoParagraph(pit);
 		bv.coordCache().parPos()[this][pit] =
-			Point(0, it->second.y_ - pars_[it->first].descent());
+			Point(0, it->second.y_ - pm.descent());
 		return pit;
 	}
 
+	ParagraphMetrics const & pm_last = bv.parMetrics(this, last->first);
+
 	// If we are off-screen (after the visible part)
 	if (y > bv.workHeight()
 		// and even after the first paragraph in the cache.
-		&& y >= last->second.y_ + int(pars_[last->first].descent())) {
+		&& y >= last->second.y_ + int(pm_last.descent())) {
 		pit = last->first + 1;
 		//  and we are not at the last paragraph in the inset.
-		if (pit == pars_.size())
+		if (pit == int(pars_.size()))
 			return last->first;
 		// then this is the paragraph we are looking for.
 		// rebreak it and update the CoordCache.
-		redoParagraph(bv, pit);
+		tm.redoParagraph(pit);
 		bv.coordCache().parPos()[this][pit] =
-			Point(0, last->second.y_ + pars_[last->first].ascent());
+			Point(0, last->second.y_ + pm_last.ascent());
 		return pit;
 	}
 
 	for (; it != et; ++it) {
-		lyxerr[Debug::DEBUG]
+		LYXERR(Debug::DEBUG)
 			<< BOOST_CURRENT_FUNCTION
 			<< "  examining: pit: " << it->first
 			<< " y: " << it->second.y_
 			<< endl;
 
-		if (it->first >= pit && int(it->second.y_) - int(pars_[it->first].ascent()) <= y) {
+		ParagraphMetrics const & pm = bv.parMetrics(this, it->first);
+
+		if (it->first >= pit && int(it->second.y_) - int(pm.ascent()) <= y) {
 			pit = it->first;
 			yy = it->second.y_;
 		}
 	}
 
-	lyxerr[Debug::DEBUG]
+	LYXERR(Debug::DEBUG)
 		<< BOOST_CURRENT_FUNCTION
 		<< ": found best y: " << yy << " for pit: " << pit
 		<< endl;
@@ -977,11 +831,12 @@ pit_type LyXText::getPitNearY(BufferView & bv, int y)
 
 Row const & LyXText::getRowNearY(BufferView const & bv, int y, pit_type pit) const
 {
-	Paragraph const & par = pars_[pit];
-	int yy = bv.coordCache().get(this, pit).y_ - par.ascent();
-	BOOST_ASSERT(!par.rows().empty());
-	RowList::const_iterator rit = par.rows().begin();
-	RowList::const_iterator const rlast = boost::prior(par.rows().end());
+	ParagraphMetrics const & pm = bv.parMetrics(this, pit);
+
+	int yy = bv.coordCache().get(this, pit).y_ - pm.ascent();
+	BOOST_ASSERT(!pm.rows().empty());
+	RowList::const_iterator rit = pm.rows().begin();
+	RowList::const_iterator const rlast = boost::prior(pm.rows().end());
 	for (; rit != rlast; yy += rit->height(), ++rit)
 		if (yy + rit->height() > y)
 			break;
@@ -999,18 +854,14 @@ InsetBase * LyXText::editXY(LCursor & cur, int x, int y)
 	}
 	pit_type pit = getPitNearY(cur.bv(), y);
 	BOOST_ASSERT(pit != -1);
-	// When another window is opened with the same document, rows()
-	// will be cleared so pars_[pit].rows() might be empty when switching
-	// between windwos. A better solution is that each buffer view
-	// has its own rows() for the same buffer.
-	if (pars_[pit].rows().empty())
-		redoParagraph(cur.bv(), pit);
+
 	Row const & row = getRowNearY(cur.bv(), y, pit);
 	bool bound = false;
 
+	TextMetrics const & tm = cur.bv().textMetrics(this);
 	int xx = x; // is modified by getColumnNearX
 	pos_type const pos = row.pos()
-		+ getColumnNearX(cur.bv(), pit, row, xx, bound);
+		+ tm.getColumnNearX(pit, row, xx, bound);
 	cur.pit() = pit;
 	cur.pos() = pos;
 	cur.boundary(bound);
@@ -1074,13 +925,15 @@ bool LyXText::cursorLeft(LCursor & cur)
 		return setCursor(cur, cur.pit(), cur.pos(), true, true);
 	}
 	if (cur.pos() != 0) {
-		bool boundary = cur.boundary();
 		bool updateNeeded = setCursor(cur, cur.pit(), cur.pos() - 1, true, false);
 		if (!checkAndActivateInset(cur, false)) {
+			/** FIXME: What's this cause purpose???
+			bool boundary = cur.boundary();
 			if (false && !boundary &&
 			    bidi.isBoundary(cur.buffer(), cur.paragraph(), cur.pos() + 1))
 				updateNeeded |=
 					setCursor(cur, cur.pit(), cur.pos() + 1, true, true);
+			*/
 		}
 		return updateNeeded;
 	}
@@ -1130,14 +983,19 @@ bool LyXText::cursorUp(LCursor & cur)
 	// Tell BufferView to test for FitCursor in any case!
 	cur.updateFlags(Update::FitCursor);
 
-	Paragraph const & par = cur.paragraph();
-	int row;
-	int const x = cur.targetX();
+	TextMetrics const & tm = cur.bv().textMetrics(this);
+	ParagraphMetrics const & pm = tm.parMetrics(cur.pit());
 
+	int row;
 	if (cur.pos() && cur.boundary())
-		row = par.pos2row(cur.pos()-1);
+		row = pm.pos2row(cur.pos()-1);
 	else
-		row = par.pos2row(cur.pos());
+		row = pm.pos2row(cur.pos());
+
+	// remember current position only if we are not at the end of a row.
+	if (cur.pos() != pm.rows()[row].endpos())
+		cur.setTargetX();
+	int const x = cur.targetX();
 
 	if (!cur.selection()) {
 		int const y = bv_funcs::getPos(cur.bv(), cur, cur.boundary()).y_;
@@ -1145,7 +1003,7 @@ bool LyXText::cursorUp(LCursor & cur)
 		// Go to middle of previous row. 16 found to work OK;
 		// 12 = top/bottom margin of display math
 		int const margin = 3 * InsetMathHull::displayMargin() / 2;
-		editXY(cur, x, y - par.rows()[row].ascent() - margin);
+		editXY(cur, x, y - pm.rows()[row].ascent() - margin);
 		cur.clearSelection();
 
 		// This happens when you move out of an inset.
@@ -1156,19 +1014,21 @@ bool LyXText::cursorUp(LCursor & cur)
 		if (dummy == old)
 			++dummy.pos();
 
-		return deleteEmptyParagraphMechanism(dummy, old);
+		cur.bv().checkDepm(dummy, old);
+		return false;
 	}
 
 	bool updateNeeded = false;
 
 	if (row > 0) {
 		updateNeeded |= setCursor(cur, cur.pit(),
-			x2pos(cur.bv(), cur.pit(), row - 1, x));
+			tm.x2pos(cur.pit(), row - 1, x));
 	} else if (cur.pit() > 0) {
 		--cur.pit();
 		//cannot use 'par' now
+		ParagraphMetrics const & pmcur = cur.bv().parMetrics(this, cur.pit());
 		updateNeeded |= setCursor(cur, cur.pit(),
-			x2pos(cur.bv(), cur.pit(), cur.paragraph().rows().size() - 1, x));
+			tm.x2pos(cur.pit(), pmcur.rows().size() - 1, x));
 	}
 
 	cur.x_target() = x;
@@ -1182,21 +1042,26 @@ bool LyXText::cursorDown(LCursor & cur)
 	// Tell BufferView to test for FitCursor in any case!
 	cur.updateFlags(Update::FitCursor);
 
-	Paragraph const & par = cur.paragraph();
-	int row;
-	int const x = cur.targetX();
+	TextMetrics const & tm = cur.bv().textMetrics(this);
+	ParagraphMetrics const & pm = tm.parMetrics(cur.pit());
 
+	int row;
 	if (cur.pos() && cur.boundary())
-		row = par.pos2row(cur.pos()-1);
+		row = pm.pos2row(cur.pos()-1);
 	else
-		row = par.pos2row(cur.pos());
+		row = pm.pos2row(cur.pos());
+
+	// remember current position only if we are not at the end of a row.
+	if (cur.pos() != pm.rows()[row].endpos())
+		cur.setTargetX();
+	int const x = cur.targetX();
 
 	if (!cur.selection()) {
 		int const y = bv_funcs::getPos(cur.bv(), cur, cur.boundary()).y_;
 		LCursor old = cur;
 		// To middle of next row
 		int const margin = 3 * InsetMathHull::displayMargin() / 2;
-		editXY(cur, x, y + par.rows()[row].descent() + margin);
+		editXY(cur, x, y + pm.rows()[row].descent() + margin);
 		cur.clearSelection();
 
 		// This happens when you move out of an inset.
@@ -1206,25 +1071,25 @@ bool LyXText::cursorDown(LCursor & cur)
 		LCursor dummy = cur;
 		if (dummy == old)
 			++dummy.pos();
-
-		bool const changed = deleteEmptyParagraphMechanism(dummy, old);
+		
+		bool const changed = cur.bv().checkDepm(dummy, old);
 
 		// Make sure that cur gets back whatever happened to dummy(Lgb)
 		if (changed)
 			cur = dummy;
 
-		return changed;
+		return false;
 	}
 
 	bool updateNeeded = false;
 
-	if (row + 1 < int(par.rows().size())) {
+	if (row + 1 < int(pm.rows().size())) {
 		updateNeeded |= setCursor(cur, cur.pit(),
-			x2pos(cur.bv(), cur.pit(), row + 1, x));
+			tm.x2pos(cur.pit(), row + 1, x));
 	} else if (cur.pit() + 1 < int(paragraphs().size())) {
 		++cur.pit();
 		updateNeeded |= setCursor(cur, cur.pit(),
-			x2pos(cur.bv(), cur.pit(), 0, x));
+			tm.x2pos(cur.pit(), 0, x));
 	}
 
 	cur.x_target() = x;
@@ -1275,15 +1140,10 @@ void LyXText::fixCursorAfterDelete(CursorSlice & cur, CursorSlice const & where)
 }
 
 
-bool LyXText::deleteEmptyParagraphMechanism(LCursor & cur, LCursor & old)
+bool LyXText::deleteEmptyParagraphMechanism(LCursor & cur,
+		LCursor & old, bool & need_anchor_change)
 {
-	// Would be wrong to delete anything if we have a selection.
-	if (cur.selection())
-		return false;
-
-	//lyxerr[Debug::DEBUG] << "DEPM: cur:\n" << cur << "old:\n" << old << endl;
-	// old should point to us
-	BOOST_ASSERT(old.text() == this);
+	//LYXERR(Debug::DEBUG) << "DEPM: cur:\n" << cur << "old:\n" << old << endl;
 
 	Paragraph & oldpar = old.paragraph();
 
@@ -1320,9 +1180,7 @@ bool LyXText::deleteEmptyParagraphMechanism(LCursor & cur, LCursor & old)
 		    && oldpar.isLineSeparator(old.pos())
 		    && oldpar.isLineSeparator(old.pos() - 1)
 		    && !oldpar.isDeleted(old.pos() - 1)) {
-			oldpar.eraseChar(old.pos() - 1, false); // do not track changes in DEPM
-			// rebreak it and update the CoordCache.
-			redoParagraph(cur.bv(), old.pit());
+			oldpar.eraseChar(old.pos() - 1, cur.buffer().params().trackChanges);
 #ifdef WITH_WARNINGS
 #warning This will not work anymore when we have multiple views of the same buffer
 // In this case, we will have to correct also the cursors held by
@@ -1332,7 +1190,7 @@ bool LyXText::deleteEmptyParagraphMechanism(LCursor & cur, LCursor & old)
 			// correct all cursor parts
 			if (same_par) {
 				fixCursorAfterDelete(cur.top(), old.top());
-				cur.resetAnchor();
+				need_anchor_change = true;
 			}
 			return true;
 		}
@@ -1369,40 +1227,73 @@ bool LyXText::deleteEmptyParagraphMechanism(LCursor & cur, LCursor & old)
 				// their address has changed. Therefore we
 				// need to `regenerate' cur. (JMarc)
 				cur.updateInsets(&(cur.bottom().inset()));
-				cur.resetAnchor();
+				need_anchor_change = true;
 			}
 		}
-		// There is a crash reported by Edwin Leuven (16/04/2006) because of:
-		//ParIterator par_it(old);
-		//updateLabels(old.buffer(), par_it);
-		// So for now we do the full update:
-		updateLabels(old.buffer());
 		return true;
 	}
 
-	if (oldpar.stripLeadingSpaces())
-		cur.resetAnchor();
+	if (oldpar.stripLeadingSpaces(cur.buffer().params().trackChanges)) {
+		need_anchor_change = true;
+		// We return true here because the Paragraph contents changed and
+		// we need a redraw before further action is processed.
+		return true;
+	}
 
 	return false;
 }
 
 
-void LyXText::recUndo(LCursor & cur, pit_type first, pit_type last) const
+void LyXText::deleteEmptyParagraphMechanism(pit_type first, pit_type last, bool trackChanges)
 {
-	recordUndo(cur, Undo::ATOMIC, first, last);
+	BOOST_ASSERT(first >= 0 && first <= last && last < (int) pars_.size());
+
+	for (pit_type pit = first; pit <= last; ++pit) {
+		Paragraph & par = pars_[pit];
+
+		// We allow all kinds of "mumbo-jumbo" when freespacing.
+		if (par.isFreeSpacing())
+			continue;
+
+		for (pos_type pos = 1; pos < par.size(); ++pos) {
+			if (par.isLineSeparator(pos) && par.isLineSeparator(pos - 1)
+			    && !par.isDeleted(pos - 1)) {
+				if (par.eraseChar(pos - 1, trackChanges)) {
+					--pos;
+				}
+			}
+		}
+
+		// don't delete anything if this is the only remaining paragraph within the given range
+		// note: LyXText::acceptOrRejectChanges() sets the cursor to 'first' after calling DEPM 
+		if (first == last)
+			continue;
+
+		// don't delete empty paragraphs with keepempty set
+		if (par.allowEmpty())
+			continue;
+
+		if (par.empty() || (par.size() == 1 && par.isLineSeparator(0))) {
+			pars_.erase(boost::next(pars_.begin(), pit));
+			--pit;
+			--last;
+			continue;
+		}
+
+		par.stripLeadingSpaces(trackChanges);
+	}
 }
 
 
-void LyXText::recUndo(LCursor & cur, pit_type par) const
+void LyXText::recUndo(LCursor & cur, pit_type first, pit_type last) const
 {
-	recordUndo(cur, Undo::ATOMIC, par, par);
+	recordUndo(cur, Undo::ATOMIC, first, last);
 }
 
 
-int defaultRowHeight()
+void LyXText::recUndo(LCursor & cur, pit_type par) const
 {
-	return int(theFontMetrics(LyXFont(LyXFont::ALL_SANE)).maxHeight() *  1.2);
+	recordUndo(cur, Undo::ATOMIC, par, par);
 }
 
-
 } // namespace lyx