X-Git-Url: https://git.lyx.org/gitweb/?a=blobdiff_plain;f=src%2Fsupport%2Fqstring_helpers.h;h=9c28092811ed9c980ff04f89c18ec0531a5a2efa;hb=dae8555234f0e5c8358b91c307d91b219c664617;hp=b47f5fe5fe0c39c3bd3d78ec3f9859d174662b3c;hpb=55217e352c5dd1e2f912ed0b6e565002b16cfcc1;p=lyx.git

diff --git a/src/support/qstring_helpers.h b/src/support/qstring_helpers.h
index b47f5fe5fe..9c28092811 100644
--- a/src/support/qstring_helpers.h
+++ b/src/support/qstring_helpers.h
@@ -12,22 +12,23 @@
 #ifndef QSTRING_HELPERS_H
 #define QSTRING_HELPERS_H
 
-#include "support/docstring.h"
+#include "support/strfwd.h"
 
-#include <QString>
+class QString;
 
 namespace lyx {
 
+class LyXErr;
+
+LyXErr & operator<<(LyXErr &, QString const &);
+
 /**
  * toqstr - convert a UTF8 encoded char * into a QString
  *
  * This should not be used, since all possibly non-ASCII stuff should be
  * stored in a docstring.
  */
-inline QString const toqstr(char const * str)
-{
-	return QString::fromUtf8(str);
-}
+QString toqstr(char const * str);
 
 
 /**
@@ -36,14 +37,11 @@ inline QString const toqstr(char const * str)
  * This should not be used, since all possibly non-ASCII stuff should be
  * stored in a docstring.
  */
-inline QString const toqstr(std::string const & str)
-{
-	return toqstr(str.c_str());
-}
+QString toqstr(std::string const & str);
 
 
 /// Is \p c a valid utf16 char?
-inline bool is_utf16(char_type c)
+inline bool is_utf16(unsigned int c)
 {
 	// 0xd800 ... 0xdfff is the range of surrogate pairs.
 	return c < 0xd800 || (c > 0xdfff && c < 0x10000);
@@ -56,13 +54,15 @@ inline bool is_utf16(char_type c)
  * This is the preferred method of converting anything that possibly
  * contains non-ASCII stuff to QString.
  */
-inline QString const toqstr(docstring const & ucs4)
-{
-	// If possible we let qt do the work, since this version does not
-	// need to be superfast.
-	return QString::fromUcs4(reinterpret_cast<uint const *>(ucs4.data()), ucs4.length());
-}
+QString toqstr(docstring const & ucs4);
 
+/**
+ * toqstr - convert a UCS4 encoded character into a QString
+ *
+ * This is the preferred method of converting anything that possibly
+ * contains non-ASCII stuff to QString.
+ */
+QString toqstr(char_type ucs4);
 
 /**
  * qstring_to_ucs4 - convert a QString into a UCS4 encoded docstring
@@ -70,8 +70,7 @@ inline QString const toqstr(docstring const & ucs4)
  * This is the preferred method of converting anything that possibly
  * contains non-ASCII stuff to docstring.
  */
-docstring const qstring_to_ucs4(QString const & qstr);
-
+docstring qstring_to_ucs4(QString const & qstr);
 
 /**
  * fromqstr - convert a QString into a UTF8 encoded std::string
@@ -79,7 +78,7 @@ docstring const qstring_to_ucs4(QString const & qstr);
  * This should not be used except for output to lyxerr, since all possibly
  * non-ASCII stuff should be stored in a docstring.
  */
-std::string const fromqstr(QString const & str);
+std::string fromqstr(QString const & str);
 
 } // namespace lyx