X-Git-Url: https://git.lyx.org/gitweb/?a=blobdiff_plain;f=src%2Finsets%2Finsetbox.C;h=2af61d15e5f8c4343bb0e4a04d02b8b7be3cc14b;hb=e28331ed63062dea10d0a21b9ec12034b4b17b9a;hp=ce28dccd9a32966f98a4c39c80f729d3a3558362;hpb=6c300f72a217722652dc27db9108e1050028979c;p=lyx.git

diff --git a/src/insets/insetbox.C b/src/insets/insetbox.C
index ce28dccd9a..2af61d15e5 100644
--- a/src/insets/insetbox.C
+++ b/src/insets/insetbox.C
@@ -44,6 +44,7 @@ using std::endl;
 namespace {
 
 typedef Translator<std::string, InsetBox::BoxType> BoxTranslator;
+typedef Translator<docstring, InsetBox::BoxType> BoxTranslatorLoc;
 
 BoxTranslator const init_boxtranslator()
 {
@@ -57,15 +58,14 @@ BoxTranslator const init_boxtranslator()
 }
 
 
-BoxTranslator const init_boxtranslator_loc()
+BoxTranslatorLoc const init_boxtranslator_loc()
 {
-	// FIXME UNICODE
-	BoxTranslator translator(to_utf8(_("Boxed")), InsetBox::Boxed);
-	translator.addPair(to_utf8(_("Frameless")), InsetBox::Frameless);
-	translator.addPair(to_utf8(_("ovalbox")), InsetBox::ovalbox);
-	translator.addPair(to_utf8(_("Ovalbox")), InsetBox::Ovalbox);
-	translator.addPair(to_utf8(_("Shadowbox")), InsetBox::Shadowbox);
-	translator.addPair(to_utf8(_("Doublebox")), InsetBox::Doublebox);
+	BoxTranslatorLoc translator(_("Boxed"), InsetBox::Boxed);
+	translator.addPair(_("Frameless"), InsetBox::Frameless);
+	translator.addPair(_("ovalbox"), InsetBox::ovalbox);
+	translator.addPair(_("Ovalbox"), InsetBox::Ovalbox);
+	translator.addPair(_("Shadowbox"), InsetBox::Shadowbox);
+	translator.addPair(_("Doublebox"), InsetBox::Doublebox);
 	return translator;
 }
 
@@ -77,9 +77,9 @@ BoxTranslator const & boxtranslator()
 }
 
 
-BoxTranslator const & boxtranslator_loc()
+BoxTranslatorLoc const & boxtranslator_loc()
 {
-	static BoxTranslator translator = init_boxtranslator_loc();
+	static BoxTranslatorLoc translator = init_boxtranslator_loc();
 	return translator;
 }
 
@@ -88,7 +88,7 @@ BoxTranslator const & boxtranslator_loc()
 
 void InsetBox::init()
 {
-	setInsetName("Box");
+	setInsetName(from_ascii("Box"));
 	setButtonLabel();
 }
 
@@ -149,7 +149,6 @@ void InsetBox::setButtonLabel()
 	BoxType btype = boxtranslator().find(params_.type);
 
 	docstring label;
-	// FIXME UNICODE
 	label += _("Box");
 	label += " (";
 	if (btype == Frameless) {
@@ -158,8 +157,7 @@ void InsetBox::setButtonLabel()
 		else
 			label += _("Minipage");
 	} else
-		// FXIME unicode
-		label += from_utf8(boxtranslator_loc().find(btype));
+		label += boxtranslator_loc().find(btype);
 	label += ")";
 
 	setLabel(label);
@@ -170,13 +168,21 @@ void InsetBox::setButtonLabel()
 }
 
 
-void InsetBox::metrics(MetricsInfo & m, Dimension & dim) const
+bool InsetBox::hasFixedWidth() const
+{
+      return params_.inner_box || params_.special != "width";
+}
+
+
+bool InsetBox::metrics(MetricsInfo & m, Dimension & dim) const
 {
 	MetricsInfo mi = m;
-	if (params_.inner_box || params_.special != "width")
+	if (hasFixedWidth())
 		mi.base.textwidth = params_.width.inPixels(m.base.textwidth);
 	InsetCollapsable::metrics(mi, dim);
+	bool const changed = dim_ != dim;
 	dim_ = dim;
+	return changed;
 }
 
 
@@ -198,7 +204,7 @@ void InsetBox::doDispatch(LCursor & cur, FuncRequest & cmd)
 	switch (cmd.action) {
 
 	case LFUN_INSET_MODIFY: {
-		lyxerr << "InsetBox::dispatch MODIFY" << endl;
+		//lyxerr << "InsetBox::dispatch MODIFY" << endl;
 		InsetBoxMailer::string2params(to_utf8(cmd.argument()), params_);
 		setButtonLabel();
 		break;