X-Git-Url: https://git.lyx.org/gitweb/?a=blobdiff_plain;f=src%2Finsets%2FInsetLine.cpp;h=087dba7df2cc8a8fa429d4aaae2f4fec39d2f7dd;hb=f151b932c248f7d78e54c085cd942d0aa9e4c475;hp=be05fe14234b2e4201733cb6742e6d55306c5210;hpb=d179943b8f89eab2cefa6a2cac9dc20c9187254c;p=lyx.git

diff --git a/src/insets/InsetLine.cpp b/src/insets/InsetLine.cpp
index be05fe1423..087dba7df2 100644
--- a/src/insets/InsetLine.cpp
+++ b/src/insets/InsetLine.cpp
@@ -3,6 +3,7 @@
  * This file is part of LyX, the document processor.
  * Licence details can be found in the file COPYING.
  *
+ * \author Abdelrazak Younes
  * \author André Pönitz
  * \author Uwe Stöhr
  *
@@ -14,6 +15,7 @@
 #include "InsetLine.h"
 
 #include "Buffer.h"
+#include "Cursor.h"
 #include "Dimension.h"
 #include "DispatchResult.h"
 #include "FuncRequest.h"
@@ -33,6 +35,8 @@
 #include "support/gettext.h"
 #include "support/lstrings.h"
 
+#include <cstdlib>
+
 using namespace std;
 
 namespace lyx {
@@ -41,7 +45,7 @@ using frontend::Painter;
 
 
 InsetLine::InsetLine(Buffer * buf, InsetCommandParams const & p)
-	: InsetCommand(buf, p, "line")
+	: InsetCommand(buf, p), height_(0), offset_(0)
 {}
 
 
@@ -70,12 +74,12 @@ void InsetLine::doDispatch(Cursor & cur, FuncRequest & cmd)
 	case LFUN_INSET_MODIFY: {
 		InsetCommandParams p(LINE_CODE);
 		// FIXME UNICODE
-		InsetCommand::string2params("line",
-			to_utf8(cmd.argument()), p);
+		InsetCommand::string2params(to_utf8(cmd.argument()), p);
 		if (p.getCmdName().empty()) {
 			cur.noScreenUpdate();
 			break;
 		}
+		cur.recordUndo();
 		setParams(p);
 		break;
 	}
@@ -104,67 +108,62 @@ bool InsetLine::getStatus(Cursor & cur, FuncRequest const & cmd,
 void InsetLine::metrics(MetricsInfo & mi, Dimension & dim) const
 {
 	frontend::FontMetrics const & fm = theFontMetrics(mi.base.font);
-	dim.asc = fm.maxAscent();
-	dim.des = fm.maxDescent();
-	
-	Length width = Length(to_ascii(getParam("width")));
-	int w = 
-		width.inPixels(mi.base.textwidth,
-		fm.width(char_type('M')));
+	int const max_width = mi.base.textwidth;
+
+	Length const width(to_ascii(getParam("width")));
+	dim.wid = width.inPixels(mi.base);
 
 	// assure that the line inset is not outside of the window
 	// check that it doesn't exceed the outer boundary
-	if (w > mi.base.textwidth)
-		w = mi.base.textwidth;
+	if (dim.wid > max_width)
+		dim.wid = max_width;
 
 	// set a minimal width
-	int const minw = (w < 0) ? 3 * 8 : 4;
-	dim.wid = max(minw, abs(w));
+	int const minw = (dim.wid < 0) ? 24 : 4;
+	dim.wid = max(minw, abs(dim.wid));
+
+	Length height = Length(to_ascii(getParam("height")));
+	height_ = height.inPixels(mi.base);
+
+	// get the length of the parameters in pixels
+	Length offset = Length(to_ascii(getParam("offset")));
+	offset_ = offset.inPixels(mi.base);
+
+	dim.asc = max(fm.maxAscent(), offset_ + height_);
+	dim.des = max(fm.maxDescent(), - offset_);
 
 	// Cache the inset dimension
 	setDimCache(mi, dim);
 }
 
 
-void InsetLine::draw(PainterInfo & pi, int x, int y) const
+Dimension const InsetLine::dimension(BufferView const & bv) const
 {
-	Dimension const dim = dimension(*pi.base.bv);
+	// We cannot use InsetCommand::dimension() as this returns the dimension
+	// of the button, which is not used here.
+	return Inset::dimension(bv);
+}
 
-	frontend::FontMetrics const & fm = theFontMetrics(pi.base.font);
 
-	// get the length of the parameters in pixels
-	Length offset = Length(to_ascii(getParam("offset")));
-	int o = 
-		offset.inPixels(pi.base.textwidth,
-		fm.width(char_type('M')));
-	Length width = Length(to_ascii(getParam("width")));
-	int w = 
-		width.inPixels(pi.base.textwidth,
-		fm.width(char_type('M')));
-	Length height = Length(to_ascii(getParam("height")));
-	int h = 
-		height.inPixels(pi.base.textwidth,
-		fm.width(char_type('M')));
+void InsetLine::draw(PainterInfo & pi, int x, int y) const
+{
+	Dimension const dim = dimension(*pi.base.bv);
 
 	// get the surrounding text color
-	FontInfo f = pi.base.font;
-	Color Line_color = f.realColor();
-
-	// assure that the drawn line is not outside of the window
-	// check that it doesn't exceed the outer boundary
-	if (x + w - h/2 - 2 > pi.base.textwidth)
-		w = pi.base.textwidth - x + h/2 + 2;
-	// check that it doesn't exceed the upper boundary
-	if (y - o - h/2 < 0)
-		o = y - h/2 - 2;
+	Color Line_color = pi.base.font.realColor();
 
 	// the offset is a vertical one
-	pi.pain.line(x + h/2 + 1, y - o - h/2, x + w - h/2 - 2, y - o - h/2,
-		Line_color, Painter::line_solid, float(h));
+	// the horizontal dimension must be corrected with the heigth because
+	// of left and right border of the painted line for big heigth.
+	pi.pain.line(x + height_/2 + 1,
+		     y - offset_ - height_/2,
+		     x + dim.wid - height_/2 - 2,
+		     y - offset_ - height_/2,
+		     Line_color, Painter::line_solid, height_);
 }
 
 
-int InsetLine::latex(odocstream & os, OutputParams const &) const
+void InsetLine::latex(otexstream & os, OutputParams const &) const
 {
 	bool have_offset = true;
 	Length offset_len = Length(to_ascii(getParam("offset")));
@@ -183,12 +182,11 @@ int InsetLine::latex(odocstream & os, OutputParams const &) const
 	if (have_offset)
 		os	<< "[" << from_ascii(offset) << "]";
 	os << "{" << from_ascii(width) << "}{" << from_ascii(height) << '}';
-
-	return 0;
 }
 
 
-int InsetLine::plaintext(odocstream & os, OutputParams const &) const
+int InsetLine::plaintext(odocstringstream & os,
+        OutputParams const &, size_t) const
 {
 	os << "\n-------------------------------------------\n";
 	return PLAINTEXT_NEWLINE;
@@ -204,8 +202,7 @@ int InsetLine::docbook(odocstream & os, OutputParams const &) const
 
 docstring InsetLine::xhtml(XHTMLStream & xs, OutputParams const &) const
 {
-	xs << html::CompTag("hr");
-	xs.cr();
+	xs << html::CompTag("hr") << html::CR();
 	return docstring();
 }