X-Git-Url: https://git.lyx.org/gitweb/?a=blobdiff_plain;f=src%2Finsets%2FInsetLabel.cpp;h=4dd0713730e921e74f444c2462bc6b90326000ec;hb=d6a93143ec2146210d79f58cac42f9608da86100;hp=5217dffd1aad3d0aae47b6a1c41457d7ed5e3e26;hpb=5577e877bb0a25a0919db09b10effe9f54ff1333;p=lyx.git

diff --git a/src/insets/InsetLabel.cpp b/src/insets/InsetLabel.cpp
index 5217dffd1a..4dd0713730 100644
--- a/src/insets/InsetLabel.cpp
+++ b/src/insets/InsetLabel.cpp
@@ -49,54 +49,78 @@ namespace lyx {
 
 
 InsetLabel::InsetLabel(Buffer * buf, InsetCommandParams const & p)
-	: InsetCommand(buf, p, "label")
+	: InsetCommand(buf, p)
 {}
 
 
 void InsetLabel::initView()
 {
-	updateCommand(getParam("name"));
+	// This seems to be used only for inset creation.
+	// Therefore we do not update refs here, since this would
+	// erroneously change refs from existing duplicate labels
+	// (#8141).
+	updateLabel(getParam("name"));
 }
 
 
-void InsetLabel::updateCommand(docstring const & new_label, bool updaterefs)
+void InsetLabel::uniqueLabel(docstring & label) const
 {
-	docstring const old_label = getParam("name");
-	docstring label = new_label;
+	docstring const new_label = label;
 	int i = 1;
 	while (buffer().insetLabel(label)) {
 		label = new_label + '-' + convert<docstring>(i);
 		++i;
 	}
-
 	if (label != new_label) {
 		// Warn the user that the label has been changed to something else.
 		frontend::Alert::warning(_("Label names must be unique!"),
 			bformat(_("The label %1$s already exists,\n"
 			"it will be changed to %2$s."), new_label, label));
 	}
+}
 
-	buffer().undo().beginUndoGroup();
+
+void InsetLabel::updateLabel(docstring const & new_label)
+{
+	docstring label = new_label;
+	uniqueLabel(label);
 	setParam("name", label);
+}
+
+
+void InsetLabel::updateLabelAndRefs(docstring const & new_label,
+		Cursor * cursor)
+{
+	docstring const old_label = getParam("name");
+	docstring label = new_label;
+	uniqueLabel(label);
+	if (label == old_label)
+		return;
 
-	if (updaterefs) {
-		Buffer::References & refs = buffer().references(old_label);
-		Buffer::References::iterator it = refs.begin();
-		Buffer::References::iterator end = refs.end();
-		for (; it != end; ++it) {
-			buffer().undo().recordUndo(it->second);
-			if (it->first->lyxCode() == MATH_REF_CODE) {
-				InsetMathHull * mi =
-					static_cast<InsetMathHull *>(it->first);
-				mi->asRefInset()->changeTarget(label);
-			} else {
-				InsetCommand * ref =
-					static_cast<InsetCommand *>(it->first);
-				ref->setParam("reference", label);
-			}
+	// This handles undo groups automagically
+	UndoGroupHelper ugh(&buffer());
+	if (cursor)
+		cursor->recordUndo();
+	setParam("name", label);
+	updateReferences(old_label, label);
+}
+
+
+void InsetLabel::updateReferences(docstring const & old_label,
+		docstring const & new_label)
+{
+	UndoGroupHelper ugh;
+	for (auto const & p: buffer().references(old_label)) {
+		ugh.resetBuffer(p.second.buffer());
+		CursorData(p.second).recordUndo();
+		if (p.first->lyxCode() == MATH_REF_CODE) {
+			InsetMathRef * mi = p.first->asInsetMath()->asRefInset();
+			mi->changeTarget(new_label);
+		} else {
+			InsetCommand * ref = p.first->asInsetCommand();
+			ref->setParam("reference", new_label);
 		}
 	}
-	buffer().undo().endUndoGroup();
 }
 
 
@@ -127,9 +151,9 @@ void InsetLabel::updateBuffer(ParIterator const & par, UpdateType utype)
 	buffer().setInsetLabel(label, this);
 	screen_label_ = label;
 
-	if (utype) {
+	if (utype == OutputUpdate) {
 		// save info on the active counter
-		Counters const & cnts = 
+		Counters const & cnts =
 			buffer().masterBuffer()->params().documentClass().counters();
 		active_counter_ = cnts.currentCounter();
 		Language const * lang = par->getParLanguage(buffer().params());
@@ -137,34 +161,33 @@ void InsetLabel::updateBuffer(ParIterator const & par, UpdateType utype)
 			counter_value_ = cnts.theCounter(active_counter_, lang->code());
 			pretty_counter_ = cnts.prettyCounter(active_counter_, lang->code());
 		} else {
-			counter_value_ = from_ascii("??");
-			pretty_counter_ = from_ascii("??");
+			counter_value_ = from_ascii("#");
+			pretty_counter_ = from_ascii("#");
 		}
 	}
 }
 
 
-void InsetLabel::addToToc(DocIterator const & cpit)
+void InsetLabel::addToToc(DocIterator const & cpit, bool output_active,
+						  UpdateType, TocBackend & backend) const
 {
 	docstring const & label = getParam("name");
-	Toc & toc = buffer().tocBackend().toc("label");
+	shared_ptr<Toc> toc = backend.toc("label");
 	if (buffer().insetLabel(label) != this) {
-		toc.push_back(TocItem(cpit, 0, screen_label_));
-		return;
-	}
-	toc.push_back(TocItem(cpit, 0, screen_label_));
-	Buffer::References const & refs = buffer().references(label);
-	Buffer::References::const_iterator it = refs.begin();
-	Buffer::References::const_iterator end = refs.end();
-	for (; it != end; ++it) {
-		DocIterator const ref_pit(it->second);
-		if (it->first->lyxCode() == MATH_REF_CODE)
-			toc.push_back(TocItem(ref_pit, 1,
-				static_cast<InsetMathHull *>(it->first)->asRefInset()
-					->screenLabel()));
-		else
-			toc.push_back(TocItem(ref_pit, 1,
-				static_cast<InsetRef *>(it->first)->screenLabel()));
+		toc->push_back(TocItem(cpit, 0, screen_label_, output_active));
+	} else {
+		toc->push_back(TocItem(cpit, 0, screen_label_, output_active));
+		for (auto const & p : buffer().references(label)) {
+			DocIterator const ref_pit(p.second);
+			if (p.first->lyxCode() == MATH_REF_CODE)
+				toc->push_back(TocItem(ref_pit, 1,
+						p.first->asInsetMath()->asRefInset()->screenLabel(),
+						output_active));
+			else
+				toc->push_back(TocItem(ref_pit, 1,
+						static_cast<InsetRef *>(p.first)->getTOCString(),
+						output_active));
+		}
 	}
 }
 
@@ -174,10 +197,19 @@ bool InsetLabel::getStatus(Cursor & cur, FuncRequest const & cmd,
 {
 	bool enabled;
 	switch (cmd.action()) {
-	case LFUN_LABEL_INSERT_AS_REF:
-	case LFUN_LABEL_COPY_AS_REF:
+	case LFUN_LABEL_INSERT_AS_REFERENCE:
+	case LFUN_LABEL_COPY_AS_REFERENCE:
 		enabled = true;
 		break;
+	case LFUN_INSET_MODIFY:
+		if (cmd.getArg(0) == "changetype") {
+			// this is handled by InsetCommand,
+			// but not by InsetLabel.
+			enabled = false;
+			break;
+		}
+		// no "changetype":
+		// fall through
 	default:
 		return InsetCommand::getStatus(cur, cmd, status);
 	}
@@ -192,20 +224,28 @@ void InsetLabel::doDispatch(Cursor & cur, FuncRequest & cmd)
 	switch (cmd.action()) {
 
 	case LFUN_INSET_MODIFY: {
+		// the only other option here is "changetype", and we
+		// do not have different types.
+		if (cmd.getArg(0) != "label") {
+			cur.undispatched();
+			return;
+		}
 		InsetCommandParams p(LABEL_CODE);
 		// FIXME UNICODE
-		InsetCommand::string2params("label", to_utf8(cmd.argument()), p);
+		InsetCommand::string2params(to_utf8(cmd.argument()), p);
 		if (p.getCmdName().empty()) {
 			cur.noScreenUpdate();
 			break;
 		}
-		if (p["name"] != params()["name"])
-			updateCommand(p["name"]);
+		if (p["name"] != params()["name"]) {
+			// undo is handled in updateLabelAndRefs
+			updateLabelAndRefs(p["name"], &cur);
+		}
 		cur.forceBufferUpdate();
 		break;
 	}
 
-	case LFUN_LABEL_COPY_AS_REF: {
+	case LFUN_LABEL_COPY_AS_REFERENCE: {
 		InsetCommandParams p(REF_CODE, "ref");
 		p["reference"] = getParam("name");
 		cap::clearSelection();
@@ -213,10 +253,10 @@ void InsetLabel::doDispatch(Cursor & cur, FuncRequest & cmd)
 		break;
 	}
 
-	case LFUN_LABEL_INSERT_AS_REF: {
+	case LFUN_LABEL_INSERT_AS_REFERENCE: {
 		InsetCommandParams p(REF_CODE, "ref");
 		p["reference"] = getParam("name");
-		string const data = InsetCommand::params2string("ref", p);
+		string const data = InsetCommand::params2string(p);
 		lyx::dispatch(FuncRequest(LFUN_INSET_INSERT, data));
 		break;
 	}
@@ -228,7 +268,8 @@ void InsetLabel::doDispatch(Cursor & cur, FuncRequest & cmd)
 }
 
 
-int InsetLabel::plaintext(odocstream & os, OutputParams const &) const
+int InsetLabel::plaintext(odocstringstream & os,
+        OutputParams const &, size_t) const
 {
 	docstring const str = getParam("name");
 	os << '<' << str << '>';
@@ -249,11 +290,11 @@ docstring InsetLabel::xhtml(XHTMLStream & xs, OutputParams const &) const
 {
 	// FIXME XHTML
 	// Unfortunately, the name attribute has been deprecated, so we have to use
-	// id here to get the document to validate as XHTML 1.1. This will cause a 
+	// id here to get the document to validate as XHTML 1.1. This will cause a
 	// problem with some browsers, though, I'm sure. (Guess which!) So we will
-	// have to figure out what to do about this later. 
-	string const attr = "id=\"" + html::cleanAttr(to_utf8(getParam("name"))) + "\"";
-	xs << html::CompTag("a", attr);
+	// have to figure out what to do about this later.
+	docstring const attr = "id=\"" + html::cleanAttr(getParam("name")) + '"';
+	xs << html::CompTag("a", to_utf8(attr));
 	return docstring();
 }