X-Git-Url: https://git.lyx.org/gitweb/?a=blobdiff_plain;f=src%2Fgraphics%2FGraphicsConverter.cpp;h=ebb074cb4112cf7556ec3cd187a9fe9cf4318eeb;hb=338cef2a976d5bf36c334d2cc8ce437da7f6d815;hp=82e7edf37fe7edc420459744d8b04ff7b1161693;hpb=72a6c77a510de0651056ea7f0cb58e25d80a8b53;p=lyx.git diff --git a/src/graphics/GraphicsConverter.cpp b/src/graphics/GraphicsConverter.cpp index 82e7edf37f..ebb074cb41 100644 --- a/src/graphics/GraphicsConverter.cpp +++ b/src/graphics/GraphicsConverter.cpp @@ -24,7 +24,8 @@ #include "support/lstrings.h" #include "support/os.h" -#include +#include "support/bind.h" +#include "support/TempFile.h" #include #include @@ -36,7 +37,7 @@ namespace lyx { namespace graphics { -class Converter::Impl : public boost::signals::trackable { +class Converter::Impl : public boost::signals2::trackable { public: /// Impl(FileName const &, string const &, string const &, string const &); @@ -54,7 +55,7 @@ public: /** At the end of the conversion process inform the outside world * by emitting a signal. */ - typedef boost::signal SignalType; + typedef boost::signals2::signal SignalType; /// SignalType finishedConversion; @@ -96,7 +97,7 @@ void Converter::startConversion() const } -boost::signals::connection Converter::connect(slot_type const & slot) const +boost::signals2::connection Converter::connect(slot_type const & slot) const { return pimpl_->finishedConversion.connect(slot); } @@ -111,7 +112,7 @@ FileName const & Converter::convertedFile() const /** Build the conversion script. * The script is output to the stream \p script. */ -static void build_script(FileName const & from_file, string const & to_file_base, +static void build_script(string const & from_file, string const & to_file_base, string const & from_format, string const & to_format, ostream & script); @@ -133,16 +134,18 @@ Converter::Impl::Impl(FileName const & from_file, string const & to_file_base, // The conversion commands are stored in a stringstream ostringstream script; - build_script(from_file, to_file_base, from_format, to_format, script); + build_script(from_file.toFilesystemEncoding(), + to_file_.toFilesystemEncoding(), + from_format, to_format, script); LYXERR(Debug::GRAPHICS, "\tConversion script:" "\n--------------------------------------\n" << script.str() << "\n--------------------------------------\n"); // Output the script to file. - static int counter = 0; - script_file_ = FileName(onlyPath(to_file_base) + "lyxconvert" + - convert(counter++) + ".py"); + TempFile tempfile(to_file_.onlyPath(), "lyxconvertXXXXXX.py"); + tempfile.setAutoRemove(false); + script_file_ = tempfile.name(); ofstream fs(script_file_.toFilesystemEncoding().c_str()); if (!fs.good()) { @@ -178,7 +181,7 @@ void Converter::Impl::startConversion() ForkedCall::SignalTypePtr ptr = ForkedCallQueue::add(script_command_); - ptr->connect(boost::bind(&Impl::converted, this, _1, _2)); + ptr->connect(bind(&Impl::converted, this, _1, _2)); } @@ -208,8 +211,8 @@ static string const move_file(string const & from_file, string const & to_file) return string(); ostringstream command; - command << "fromfile = toUnicode(" << from_file << ")\n" - << "tofile = toUnicode(" << to_file << ")\n\n" + command << "fromfile = " << from_file << "\n" + << "tofile = " << to_file << "\n\n" << "try:\n" << " os.rename(fromfile, tofile)\n" << "except:\n" @@ -248,17 +251,25 @@ static void build_conversion_command(string const & command, ostream & script) " sys.exit(1)\n\n"; // Delete the infile - script << "unlinkNoThrow(infile)\n\n"; + script << "if infile != outfile:\n" + " unlinkNoThrow(infile)\n\n"; } -static void build_script(FileName const & from_file, - string const & to_file_base, +static string const strip_digit(string const & format) +{ + // Strip trailing digits from format names e.g. "pdf6" -> "pdf" + return format.substr(0, format.find_last_not_of("0123456789") + 1); +} + + +static void build_script(string const & from_file, + string const & to_file, string const & from_format, string const & to_format, ostream & script) { - LASSERT(from_format != to_format, /**/); + LASSERT(from_format != to_format, return); LYXERR(Debug::GRAPHICS, "build_script ... "); typedef Graph::EdgePath EdgePath; @@ -270,39 +281,28 @@ static void build_script(FileName const & from_file, " try:\n" " os.unlink(file)\n" " except:\n" - " pass\n\n" - "def toUnicode(file):\n" - " ''' if possible, convert to python unicode format '''\n" - " try:\n" - " return unicode(file, 'utf8')\n" - " except:\n" - " return file\n\n"; - - // we do not use ChangeExtension because this is a basename - // which may nevertheless contain a '.' - string const to_file = to_file_base + '.' - + formats.extension(to_format); + " pass\n\n"; EdgePath const edgepath = from_format.empty() ? EdgePath() : theConverters().getPath(from_format, to_format); // Create a temporary base file-name for all intermediate steps. - // Remember to remove the temp file because we only want the name... - static int counter = 0; - string const tmp = "gconvert" + convert(counter++); - FileName const to_base = FileName::tempName(tmp); + string const from_ext = getExtension(from_file); + TempFile tempfile(addExtension("gconvertXXXXXX", from_ext)); + tempfile.setAutoRemove(false); + string outfile = tempfile.name().toFilesystemEncoding(); + string const to_base = from_ext.empty() ? outfile : removeExtension(outfile); // Create a copy of the file in case the original name contains // problematic characters like ' or ". We can work around that problem // in python, but the converters might be shell scripts and have more // troubles with it. - string outfile = addExtension(to_base.absFileName(), getExtension(from_file.absFileName())); - script << "infile = toUnicode(" - << quoteName(from_file.absFileName(), quote_python) - << ")\n" - "outfile = toUnicode(" - << quoteName(outfile, quote_python) << ")\n" + script << "infile = " + << quoteName(from_file, quote_python) + << "\n" + "outfile = " + << quoteName(outfile, quote_python) << "\n" "shutil.copy(infile, outfile)\n"; // Some converters (e.g. lilypond) can only output files to the @@ -310,28 +310,29 @@ static void build_script(FileName const & from_file, // This has the added benefit that all other files that may be // generated by the converter are deleted when LyX closes and do not // clutter the real working directory. - script << "os.chdir(toUnicode(" - << quoteName(onlyPath(outfile)) << "))\n"; + script << "os.chdir(" + << quoteName(onlyPath(outfile)) << ")\n"; if (edgepath.empty()) { // Either from_format is unknown or we don't have a // converter path from from_format to to_format, so we use // the default converter. script << "infile = outfile\n" - << "outfile = toUnicode(" - << quoteName(to_file, quote_python) << ")\n"; + << "outfile = " + << quoteName(to_file, quote_python) << "\n"; ostringstream os; os << os::python() << ' ' - << libScriptSearch("$$s/scripts/convertDefault.py", - quote_python) << ' '; - if (!from_format.empty()) - os << from_format << ':'; + << commandPrep("$$s/scripts/convertDefault.py") << ' '; + if (from_format.empty()) + os << "unknown "; + else + os << strip_digit(from_format) << ' '; // The extra " quotes around infile and outfile are needed // because the filename may contain spaces and it is used // as argument of os.system(). os << "' + '\"' + infile + '\"' + ' " - << to_format << ":' + '\"' + outfile + '\"' + '"; + << strip_digit(to_format) << " ' + '\"' + outfile + '\"' + '"; string const command = os.str(); LYXERR(Debug::GRAPHICS, @@ -357,25 +358,36 @@ static void build_script(FileName const & from_file, // Build the conversion command string const infile = outfile; string const infile_base = changeExtension(infile, string()); - outfile = addExtension(to_base.absFileName(), conv.To->extension()); + outfile = conv.result_file().empty() + ? addExtension(to_base, conv.To()->extension()) + : addName(subst(conv.result_dir(), + token_base, infile_base), + subst(conv.result_file(), + token_base, onlyFileName(infile_base))); + + // If two formats share the same extension we may get identical names + if (outfile == infile && conv.result_file().empty()) { + TempFile tempfile(addExtension("gconvertXXXXXX", conv.To()->extension())); + tempfile.setAutoRemove(false); + outfile = tempfile.name().toFilesystemEncoding(); + } // Store these names in the python script - script << "infile = toUnicode(" - << quoteName(infile, quote_python) << ")\n" - "infile_base = toUnicode(" - << quoteName(infile_base, quote_python) << ")\n" - "outfile = toUnicode(" - << quoteName(outfile, quote_python) << ")\n" + script << "infile = " + << quoteName(infile, quote_python) << "\n" + "infile_base = " + << quoteName(infile_base, quote_python) << "\n" + "outfile = " + << quoteName(outfile, quote_python) << "\n" "outdir = os.path.dirname(outfile)\n" ; // See comment about extra " quotes above (although that // applies only for the first loop run here). - string command = conv.command; + string command = conv.command(); command = subst(command, token_from, "' + '\"' + infile + '\"' + '"); command = subst(command, token_base, "' + '\"' + infile_base + '\"' + '"); command = subst(command, token_to, "' + '\"' + outfile + '\"' + '"); command = subst(command, token_todir, "' + '\"' + outdir + '\"' + '"); - command = libScriptSearch(command, quote_python); build_conversion_command(command, script); }