X-Git-Url: https://git.lyx.org/gitweb/?a=blobdiff_plain;f=src%2Ffrontends%2Fqt4%2FGuiWorkArea.cpp;h=ef79b02fe3e1c7b0f76ef3e8b53cbf8866bbe2af;hb=8b7584846c4e1a9c87a004fab479722fee7e3013;hp=f47429ce7e96648ba648aaaa2e9b62c4cd7a70b9;hpb=570f96bc6e9af6c488234c7f261b320844f97dc0;p=lyx.git diff --git a/src/frontends/qt4/GuiWorkArea.cpp b/src/frontends/qt4/GuiWorkArea.cpp index f47429ce7e..ef79b02fe3 100644 --- a/src/frontends/qt4/GuiWorkArea.cpp +++ b/src/frontends/qt4/GuiWorkArea.cpp @@ -32,12 +32,12 @@ #include "GuiView.h" #include "KeySymbol.h" #include "Language.h" -#include "LyXFunc.h" +#include "LyX.h" #include "LyXRC.h" #include "LyXVC.h" -#include "MetricsInfo.h" #include "qt_helpers.h" #include "Text.h" +#include "TextMetrics.h" #include "version.h" #include "graphics/GraphicsImage.h" @@ -69,15 +69,10 @@ #include #include -#include +#include "support/bind.h" #include -#ifdef Q_WS_X11 -#include -extern "C" int XEventsQueued(Display *display, int mode); -#endif - #ifdef Q_WS_WIN int const CursorWidth = 2; #else @@ -230,8 +225,7 @@ private: // This is a 'heartbeat' generating synthetic mouse move events when the // cursor is at the top or bottom edge of the viewport. One scroll per 0.2 s SyntheticMouseEvent::SyntheticMouseEvent() - : timeout(200), restart_timeout(true), - x_old(-1), y_old(-1), min_scrollbar_old(-1), max_scrollbar_old(-1) + : timeout(200), restart_timeout(true) {} @@ -239,17 +233,17 @@ GuiWorkArea::GuiWorkArea(QWidget *) : buffer_view_(0), lyx_view_(0), cursor_visible_(false), need_resize_(false), schedule_redraw_(false), - preedit_lines_(1), completer_(new GuiCompleter(this)), + preedit_lines_(1), completer_(new GuiCompleter(this, this)), context_target_pos_() { } GuiWorkArea::GuiWorkArea(Buffer & buffer, GuiView & gv) - : buffer_view_(0), lyx_view_(0), + : buffer_view_(0), read_only_(buffer.isReadonly()), lyx_view_(0), cursor_visible_(false), need_resize_(false), schedule_redraw_(false), - preedit_lines_(1), completer_(new GuiCompleter(this)), + preedit_lines_(1), completer_(new GuiCompleter(this, this)), context_target_pos_() { setGuiView(gv); @@ -294,10 +288,10 @@ void GuiWorkArea::init() setFocusPolicy(Qt::StrongFocus); - viewport()->setCursor(Qt::IBeamCursor); + setCursorShape(Qt::IBeamCursor); synthetic_mouse_event_.timeout.timeout.connect( - boost::bind(&GuiWorkArea::generateSyntheticMouseEvent, + bind(&GuiWorkArea::generateSyntheticMouseEvent, this)); // Initialize the vertical Scroll Bar @@ -321,10 +315,30 @@ GuiWorkArea::~GuiWorkArea() delete buffer_view_; delete cursor_; // Completer has a QObject parent and is thus automatically destroyed. + // See #4758. // delete completer_; } +Qt::CursorShape GuiWorkArea::cursorShape() const +{ + return viewport()->cursor().shape(); +} + + +void GuiWorkArea::setCursorShape(Qt::CursorShape shape) +{ + viewport()->setCursor(shape); +} + + +void GuiWorkArea::updateCursorShape() +{ + setCursorShape(buffer_view_->clickableInset() + ? Qt::PointingHandCursor : Qt::IBeamCursor); +} + + void GuiWorkArea::setGuiView(GuiView & gv) { lyx_view_ = &gv; @@ -396,7 +410,19 @@ void GuiWorkArea::stopBlinkingCursor() void GuiWorkArea::startBlinkingCursor() { + // do not show the cursor if the view is busy + if (view().busy()) + return; + + Point p; + int h = 0; + buffer_view_->cursorPosAndHeight(p, h); + // Don't start blinking if the cursor isn't on screen. + if (!buffer_view_->cursorInView(p, h)) + return; + showCursor(); + //we're not supposed to cache this value. int const time = QApplication::cursorFlashTime() / 2; if (time <= 0) @@ -417,6 +443,7 @@ void GuiWorkArea::redraw(bool update_metrics) if (update_metrics || lyx_view_ != guiApp->currentView() || lyx_view_->currentWorkArea() != this) { // FIXME: it would be nice to optimize for the off-screen case. + buffer_view_->cursor().fixIfBroken(); buffer_view_->updateMetrics(); buffer_view_->cursor().fixIfBroken(); } @@ -439,6 +466,10 @@ void GuiWorkArea::redraw(bool update_metrics) if (lyxerr.debugging(Debug::WORKAREA)) buffer_view_->coordCache().dump(); + + setReadOnly(buffer_view_->buffer().isReadonly()); + + updateCursorShape(); } @@ -462,14 +493,15 @@ void GuiWorkArea::processKeySym(KeySymbol const & key, KeyModifier mod) void GuiWorkArea::dispatch(FuncRequest const & cmd0, KeyModifier mod) { // Handle drag&drop - if (cmd0.action == LFUN_FILE_OPEN) { - lyx_view_->dispatch(cmd0); + if (cmd0.action() == LFUN_FILE_OPEN) { + DispatchResult dr; + lyx_view_->dispatch(cmd0, dr); return; } FuncRequest cmd; - if (cmd0.action == LFUN_MOUSE_PRESS) { + if (cmd0.action() == LFUN_MOUSE_PRESS) { if (mod == ShiftModifier) cmd = FuncRequest(cmd0, "region-select"); else if (mod == ControlModifier) @@ -481,7 +513,7 @@ void GuiWorkArea::dispatch(FuncRequest const & cmd0, KeyModifier mod) cmd = cmd0; bool const notJustMovingTheMouse = - cmd.action != LFUN_MOUSE_MOTION || cmd.button() != mouse_button::none; + cmd.action() != LFUN_MOUSE_MOTION || cmd.button() != mouse_button::none; // In order to avoid bad surprise in the middle of an operation, we better stop // the blinking cursor. @@ -491,7 +523,7 @@ void GuiWorkArea::dispatch(FuncRequest const & cmd0, KeyModifier mod) buffer_view_->mouseEventDispatch(cmd); // Skip these when selecting - if (cmd.action != LFUN_MOUSE_MOTION) { + if (cmd.action() != LFUN_MOUSE_MOTION) { completer_->updateVisibility(false, false); lyx_view_->updateDialogs(); lyx_view_->updateStatusBar(); @@ -507,6 +539,8 @@ void GuiWorkArea::dispatch(FuncRequest const & cmd0, KeyModifier mod) // Show the cursor immediately after any operation startBlinkingCursor(); } + + updateCursorShape(); } @@ -541,6 +575,12 @@ void GuiWorkArea::showCursor() if (cursor_visible_) return; + Point p; + int h = 0; + buffer_view_->cursorPosAndHeight(p, h); + if (!buffer_view_->cursorInView(p, h)) + return; + // RTL or not RTL bool l_shape = false; Font const & realfont = buffer_view_->cursor().real_current_font; @@ -555,19 +595,14 @@ void GuiWorkArea::showCursor() if (realfont.language() == latex_language) l_shape = false; - Point p; - int h = 0; - buffer_view_->cursorPosAndHeight(p, h); // show cursor on screen Cursor & cur = buffer_view_->cursor(); bool completable = cur.inset().showCompletionCursor() && completer_->completionAvailable() && !completer_->popupVisible() && !completer_->inlineVisible(); - if (buffer_view_->cursorInView(p, h)) { - cursor_visible_ = true; - showCursor(p.x_, p.y_, h, l_shape, isrtl, completable); - } + cursor_visible_ = true; + showCursor(p.x_, p.y_, h, l_shape, isrtl, completable); } @@ -607,7 +642,7 @@ void GuiWorkArea::updateScrollbar() void GuiWorkArea::scrollTo(int value) { stopBlinkingCursor(); - buffer_view_->scrollDocView(value); + buffer_view_->scrollDocView(value, true); if (lyxrc.cursor_follows_scrollbar) { buffer_view_->setCursorFromScrollbar(); @@ -643,11 +678,14 @@ bool GuiWorkArea::event(QEvent * e) // which are otherwise reserved to focus switching between controls // within a dialog. QKeyEvent * ke = static_cast(e); - if ((ke->key() != Qt::Key_Tab && ke->key() != Qt::Key_Backtab) - || ke->modifiers() & Qt::ControlModifier) - return QAbstractScrollArea::event(e); - keyPressEvent(ke); - return true; + if ((ke->key() == Qt::Key_Tab && ke->modifiers() == Qt::NoModifier) + || (ke->key() == Qt::Key_Backtab && ( + ke->modifiers() == Qt::ShiftModifier + || ke->modifiers() == Qt::NoModifier))) { + keyPressEvent(ke); + return true; + } + return QAbstractScrollArea::event(e); } default: @@ -697,14 +735,7 @@ void GuiWorkArea::contextMenuEvent(QContextMenuEvent * e) void GuiWorkArea::focusInEvent(QFocusEvent * e) { - /* - LYXERR(Debug::DEBUG, "GuiWorkArea::focusInEvent(): " << this << std::endl); - GuiWorkArea * old_gwa = theGuiApp()->currentView()->currentWorkArea(); - if (old_gwa) - old_gwa->stopBlinkingCursor(); - lyx_view_->setCurrentWorkArea(this); - */ - + LYXERR(Debug::DEBUG, "GuiWorkArea::focusInEvent(): " << this << endl); if (lyx_view_->currentWorkArea() != this) lyx_view_->setCurrentWorkArea(this); @@ -715,7 +746,7 @@ void GuiWorkArea::focusInEvent(QFocusEvent * e) void GuiWorkArea::focusOutEvent(QFocusEvent * e) { - LYXERR(Debug::DEBUG, "GuiWorkArea::focusOutEvent(): " << this << std::endl); + LYXERR(Debug::DEBUG, "GuiWorkArea::focusOutEvent(): " << this << endl); stopBlinkingCursor(); QAbstractScrollArea::focusOutEvent(e); } @@ -766,18 +797,19 @@ void GuiWorkArea::mouseMoveEvent(QMouseEvent * e) e->accept(); // If we're above or below the work area... - if (e->y() <= 20 || e->y() >= viewport()->height() - 20) { + if ((e->y() <= 20 || e->y() >= viewport()->height() - 20) + && e->buttons() == mouse_button::button1) { // Make sure only a synthetic event can cause a page scroll, // so they come at a steady rate: if (e->y() <= 20) // _Force_ a scroll up: - cmd.y = -40; + cmd.set_y(e->y() - 21); else - cmd.y = viewport()->height(); + cmd.set_y(e->y() + 21); // Store the event, to be handled when the timeout expires. synthetic_mouse_event_.cmd = cmd; - if (synthetic_mouse_event_.timeout.running()) + if (synthetic_mouse_event_.timeout.running()) { // Discard the event. Note that it _may_ be handled // when the timeout expires if // synthetic_mouse_event_.cmd has not been overwritten. @@ -786,7 +818,8 @@ void GuiWorkArea::mouseMoveEvent(QMouseEvent * e) // occurred after the one used to start the timeout // in the first place. return; - + } + synthetic_mouse_event_.restart_timeout = true; synthetic_mouse_event_.timeout.start(); // Fall through to handle this event... @@ -802,24 +835,6 @@ void GuiWorkArea::mouseMoveEvent(QMouseEvent * e) synthetic_mouse_event_.restart_timeout = false; return; } - - // Has anything changed on-screen since the last QMouseEvent - // was received? - if (e->x() == synthetic_mouse_event_.x_old - && e->y() == synthetic_mouse_event_.y_old - && synthetic_mouse_event_.min_scrollbar_old == verticalScrollBar()->minimum() - && synthetic_mouse_event_.max_scrollbar_old == verticalScrollBar()->maximum()) { - // Nothing changed on-screen since the last QMouseEvent. - return; - } - - // Yes something has changed. Store the params used to check this. - synthetic_mouse_event_.x_old = e->x(); - synthetic_mouse_event_.y_old = e->y(); - synthetic_mouse_event_.min_scrollbar_old = verticalScrollBar()->minimum(); - synthetic_mouse_event_.max_scrollbar_old = verticalScrollBar()->maximum(); - - // ... and dispatch the event to the LyX core. dispatch(cmd); } @@ -828,9 +843,26 @@ void GuiWorkArea::wheelEvent(QWheelEvent * ev) { // Wheel rotation by one notch results in a delta() of 120 (see // documentation of QWheelEvent) - int const delta = ev->delta() / 120; - if (ev->modifiers() & Qt::ControlModifier) { - docstring arg = convert(5 * delta); + double const delta = ev->delta() / 120.0; + bool zoom = false; + switch (lyxrc.scroll_wheel_zoom) { + case LyXRC::SCROLL_WHEEL_ZOOM_CTRL: + zoom = ev->modifiers() & Qt::ControlModifier; + zoom &= !(ev->modifiers() & (Qt::ShiftModifier | Qt::AltModifier)); + break; + case LyXRC::SCROLL_WHEEL_ZOOM_SHIFT: + zoom = ev->modifiers() & Qt::ShiftModifier; + zoom &= !(ev->modifiers() & (Qt::ControlModifier | Qt::AltModifier)); + break; + case LyXRC::SCROLL_WHEEL_ZOOM_ALT: + zoom = ev->modifiers() & Qt::AltModifier; + zoom &= !(ev->modifiers() & (Qt::ShiftModifier | Qt::ControlModifier)); + break; + case LyXRC::SCROLL_WHEEL_ZOOM_OFF: + break; + } + if (zoom) { + docstring arg = convert(int(5 * delta)); lyx::dispatch(FuncRequest(LFUN_BUFFER_ZOOM_IN, arg)); return; } @@ -842,11 +874,8 @@ void GuiWorkArea::wheelEvent(QWheelEvent * ev) int scroll_value = lines > page_step ? page_step : lines * verticalScrollBar()->singleStep(); - // Take into account the rotation. - scroll_value *= delta; - - // Take into account user preference. - scroll_value = int(scroll_value * lyxrc.mouse_wheel_speed); + // Take into account the rotation and the user preferences. + scroll_value = int(scroll_value * delta * lyxrc.mouse_wheel_speed); LYXERR(Debug::SCROLLING, "wheelScrollLines = " << lines << " delta = " << delta << " scroll_value = " << scroll_value << " page_step = " << page_step); @@ -859,23 +888,81 @@ void GuiWorkArea::wheelEvent(QWheelEvent * ev) void GuiWorkArea::generateSyntheticMouseEvent() { + int const e_y = synthetic_mouse_event_.cmd.y(); + int const wh = buffer_view_->workHeight(); + bool const up = e_y < 0; + bool const down = e_y > wh; + // Set things off to generate the _next_ 'pseudo' event. - if (synthetic_mouse_event_.restart_timeout) + int step = 50; + if (synthetic_mouse_event_.restart_timeout) { + // This is some magic formulae to determine the speed + // of scrolling related to the position of the mouse. + int time = 200; + if (up || down) { + int dist = up ? -e_y : e_y - wh; + time = max(min(200, 250000 / (dist * dist)), 1) ; + + if (time < 40) { + step = 80000 / (time * time); + time = 40; + } + } + synthetic_mouse_event_.timeout.setTimeout(time); synthetic_mouse_event_.timeout.start(); + } - // Has anything changed on-screen since the last timeout signal - // was received? - int const min_scrollbar = verticalScrollBar()->minimum(); - int const max_scrollbar = verticalScrollBar()->maximum(); - if (min_scrollbar == synthetic_mouse_event_.min_scrollbar_old - && max_scrollbar == synthetic_mouse_event_.max_scrollbar_old) { + // Can we scroll further ? + int const value = verticalScrollBar()->value(); + if (value == verticalScrollBar()->maximum() + || value == verticalScrollBar()->minimum()) { + synthetic_mouse_event_.timeout.stop(); return; } - // Yes it has. Store the params used to check this. - synthetic_mouse_event_.min_scrollbar_old = min_scrollbar; - synthetic_mouse_event_.max_scrollbar_old = max_scrollbar; - // ... and dispatch the event to the LyX core. - dispatch(synthetic_mouse_event_.cmd); + + // Scroll + if (step <= 2 * wh) { + buffer_view_->scroll(up ? -step : step); + buffer_view_->updateMetrics(); + } else { + buffer_view_->scrollDocView(value + up ? -step : step, false); + } + + // In which paragraph do we have to set the cursor ? + Cursor & cur = buffer_view_->cursor(); + TextMetrics const & tm = buffer_view_->textMetrics(cur.text()); + + pair p = up ? tm.first() : tm.last(); + ParagraphMetrics const & pm = *p.second; + pit_type const pit = p.first; + + if (pm.rows().empty()) + return; + + // Find the row at which we set the cursor. + RowList::const_iterator rit = pm.rows().begin(); + RowList::const_iterator rlast = pm.rows().end(); + int yy = pm.position() - pm.ascent(); + for (--rlast; rit != rlast; ++rit) { + int h = rit->height(); + if ((up && yy + h > 0) + || (!up && yy + h > wh - defaultRowHeight())) + break; + yy += h; + } + + // Find the position of the cursor + bool bound; + int x = synthetic_mouse_event_.cmd.x(); + pos_type const pos = rit->pos() + tm.getColumnNearX(pit, *rit, x, bound); + + // Set the cursor + cur.pit() = pit; + cur.pos() = pos; + cur.boundary(bound); + + buffer_view_->buffer().changed(false); + return; } @@ -906,11 +993,10 @@ void GuiWorkArea::keyPressEvent(QKeyEvent * ev) // do nothing if there are other events // (the auto repeated events come too fast) - // \todo FIXME: remove hard coded Qt keys, process the key binding + // it looks like this is only needed on X11 #ifdef Q_WS_X11 - if (XEventsQueued(QX11Info::display(), 0) > 1 && ev->isAutoRepeat() - && (Qt::Key_PageDown || Qt::Key_PageUp)) { - LYXERR(Debug::KEY, "system is busy: scroll key event ignored"); + if (qApp->hasPendingEvents() && ev->isAutoRepeat()) { + LYXERR(Debug::KEY, "system is busy: keyPress event ignored"); ev->ignore(); return; } @@ -1195,10 +1281,10 @@ void GuiWorkArea::updateWindowTitle() maximize_title = fileName.displayName(30); minimize_title = from_utf8(fileName.onlyFileName()); if (buf.lyxvc().inUse()) { - if (buf.lyxvc().locker().empty()) - maximize_title += _(" (version control)"); - else + if (buf.lyxvc().locking()) maximize_title += _(" (version control, locking)"); + else + maximize_title += _(" (version control)"); } if (!buf.isClean()) { maximize_title += _(" (changed)"); @@ -1219,8 +1305,11 @@ void GuiWorkArea::updateWindowTitle() } -void GuiWorkArea::setReadOnly(bool) +void GuiWorkArea::setReadOnly(bool read_only) { + if (read_only_ == read_only) + return; + read_only_ = read_only; updateWindowTitle(); if (this == lyx_view_->currentWorkArea()) lyx_view_->updateDialogs(); @@ -1243,7 +1332,7 @@ bool GuiWorkArea::isFullScreen() EmbeddedWorkArea::EmbeddedWorkArea(QWidget * w): GuiWorkArea(w) { buffer_ = theBufferList().newBuffer( - support::FileName::tempName().absFilename() + "_embedded.internal"); + support::FileName::tempName().absFileName() + "_embedded.internal"); buffer_->setUnnamed(true); buffer_->setFullyLoaded(true); setBuffer(*buffer_); @@ -1254,7 +1343,7 @@ EmbeddedWorkArea::EmbeddedWorkArea(QWidget * w): GuiWorkArea(w) EmbeddedWorkArea::~EmbeddedWorkArea() { // No need to destroy buffer and bufferview here, because it is done - // in theBuffeerList() destruction loop at application exit + // in theBufferList() destruction loop at application exit } @@ -1272,12 +1361,26 @@ void EmbeddedWorkArea::hideEvent(QHideEvent * ev) } +QSize EmbeddedWorkArea::sizeHint () const +{ + // FIXME(?): + // GuiWorkArea sets the size to the screen's viewport + // by returning a value this gets overridden + // EmbeddedWorkArea is now sized to fit in the layout + // of the parent, and has a minimum size set in GuiWorkArea + // which is what we return here + return QSize(100, 70); +} + + void EmbeddedWorkArea::disable() { stopBlinkingCursor(); if (view().currentWorkArea() != this) return; - LASSERT(view().currentMainWorkArea(), /* */); + // No problem if currentMainWorkArea() is 0 (setCurrentWorkArea() + // tolerates it and shows the background logo), what happens if + // an EmbeddedWorkArea is closed after closing all document WAs view().setCurrentWorkArea(view().currentMainWorkArea()); } @@ -1369,10 +1472,24 @@ TabWorkArea::TabWorkArea(QWidget * parent) } +void TabWorkArea::mouseDoubleClickEvent(QMouseEvent * event) +{ + if (event->button() != Qt::LeftButton) + return; + + // return early if double click on existing tabs + for (int i = 0; i < count(); ++i) + if (tabBar()->tabRect(i).contains(event->pos())) + return; + + dispatch(FuncRequest(LFUN_BUFFER_NEW)); +} + + void TabWorkArea::setFullScreen(bool full_screen) { for (int i = 0; i != count(); ++i) { - if (GuiWorkArea * wa = dynamic_cast(widget(i))) + if (GuiWorkArea * wa = workArea(i)) wa->setFullScreen(full_screen); } @@ -1403,10 +1520,18 @@ GuiWorkArea * TabWorkArea::currentWorkArea() } +GuiWorkArea * TabWorkArea::workArea(int index) +{ + return dynamic_cast(widget(index)); +} + + GuiWorkArea * TabWorkArea::workArea(Buffer & buffer) { + // FIXME: this method doesn't work if we have more than work area + // showing the same buffer. for (int i = 0; i != count(); ++i) { - GuiWorkArea * wa = dynamic_cast(widget(i)); + GuiWorkArea * wa = workArea(i); LASSERT(wa, return 0); if (&wa->bufferView().buffer() == &buffer) return wa; @@ -1418,7 +1543,7 @@ GuiWorkArea * TabWorkArea::workArea(Buffer & buffer) void TabWorkArea::closeAll() { while (count()) { - GuiWorkArea * wa = dynamic_cast(widget(0)); + GuiWorkArea * wa = workArea(0); LASSERT(wa, /**/); removeTab(0); delete wa; @@ -1501,7 +1626,7 @@ void TabWorkArea::on_currentTabChanged(int i) // returns e.g. on application destruction if (i == -1) return; - GuiWorkArea * wa = dynamic_cast(widget(i)); + GuiWorkArea * wa = workArea(i); LASSERT(wa, return); wa->setUpdatesEnabled(true); wa->redraw(true); @@ -1510,7 +1635,7 @@ void TabWorkArea::on_currentTabChanged(int i) currentWorkAreaChanged(wa); LYXERR(Debug::GUI, "currentTabChanged " << i - << "File" << wa->bufferView().buffer().absFileName()); + << " File: " << wa->bufferView().buffer().absFileName()); } @@ -1520,7 +1645,7 @@ void TabWorkArea::closeCurrentBuffer() if (clicked_tab_ == -1) wa = currentWorkArea(); else { - wa = dynamic_cast(widget(clicked_tab_)); + wa = workArea(clicked_tab_); LASSERT(wa, /**/); } wa->view().closeWorkArea(wa); @@ -1533,7 +1658,7 @@ void TabWorkArea::hideCurrentTab() if (clicked_tab_ == -1) wa = currentWorkArea(); else { - wa = dynamic_cast(widget(clicked_tab_)); + wa = workArea(clicked_tab_); LASSERT(wa, /**/); } wa->view().hideWorkArea(wa); @@ -1547,7 +1672,7 @@ void TabWorkArea::closeTab(int index) if (index == -1) wa = currentWorkArea(); else { - wa = dynamic_cast(widget(index)); + wa = workArea(index); LASSERT(wa, /**/); } wa->view().closeWorkArea(wa); @@ -1658,7 +1783,7 @@ void TabWorkArea::updateTabTexts() // collect full names first: path into postfix, empty prefix and // filename without extension for (size_t i = 0; i < n; ++i) { - GuiWorkArea * i_wa = dynamic_cast(widget(i)); + GuiWorkArea * i_wa = workArea(i); FileName const fn = i_wa->bufferView().buffer().fileName(); paths.push_back(DisplayPath(i, fn)); } @@ -1742,7 +1867,7 @@ void TabWorkArea::updateTabTexts() // set new tab titles for (It it = paths.begin(); it != paths.end(); ++it) { - GuiWorkArea * i_wa = dynamic_cast(widget(it->tab())); + GuiWorkArea * i_wa = workArea(it->tab()); Buffer & buf = i_wa->bufferView().buffer(); if (!buf.fileName().empty() && !buf.isClean()) setTabText(it->tab(), it->displayString() + "*");