X-Git-Url: https://git.lyx.org/gitweb/?a=blobdiff_plain;f=src%2Ffrontends%2Fqt4%2FGuiCitation.h;h=65e0dd69db0dcd5e9479eacd30056bbf3c44926f;hb=43c09d723435a5b203f2ac0c39e2086de836b386;hp=6d7273dbc6d5c05f068af38a7d0253e94baf8c04;hpb=2cf301033e456abd7fe6984503ec1a1a4e7fc231;p=lyx.git

diff --git a/src/frontends/qt4/GuiCitation.h b/src/frontends/qt4/GuiCitation.h
index 6d7273dbc6..65e0dd69db 100644
--- a/src/frontends/qt4/GuiCitation.h
+++ b/src/frontends/qt4/GuiCitation.h
@@ -44,7 +44,6 @@ public:
 	~GuiCitation();
 
 private Q_SLOTS:
-	void cleanUp();
 	void on_okPB_clicked();
 	void on_cancelPB_clicked();
 	void on_restorePB_clicked();
@@ -62,7 +61,7 @@ private Q_SLOTS:
 	void setCitedKeys();
 	/// performs a limited update, suitable for internal call
 	void updateControls();
-	
+
 
 private:
 	/// Dialog inherited methods
@@ -91,26 +90,29 @@ private:
 	/// check whether key is already selected
 	bool isSelected(const QModelIndex &);
 	/// update the display of BibTeX information
-	void updateInfo(QModelIndex const &);
+	void updateInfo(BiblioInfo const & bi, QModelIndex const &);
 	/// enable/disable buttons
 	void setButtons();
 	/// fill the styles combo
-	void fillStyles();
+	void fillStyles(BiblioInfo const & bi);
 	/// fill the fields combo
-	void fillFields();
+	void fillFields(BiblioInfo const & bi);
 	/// fill the entries combo
-	void fillEntries();
+	void fillEntries(BiblioInfo const & bi);
 	/// set the styles combo
 	void updateStyle();
 	/// set the formatting widgets
 	void updateFormatting(CiteStyle currentStyle);
 	///
+	void updateControls(BiblioInfo const & bi);
+	///
 	void init();
 	/// Clear selected keys
 	void clearSelection();
-	
+
 	/// Find keys containing a string.
 	void findKey(
+		BiblioInfo const & bi, //< optimize by passing this
 		QString const & str, //< string expression
 		bool only_keys, //< set to true if only keys shall be searched.
 		docstring field, //<field to search, empty for all fields
@@ -121,14 +123,14 @@ private:
 		);
 
 	/// List of example cite strings
-	QStringList citationStyles(int);
+	QStringList citationStyles(BiblioInfo const & bi, int);
 
 	/// Set the Params variable for the Controller.
 	void apply(int const choice, bool const full, bool const force,
 					  QString before, QString after);
 
 	///
-	void filterByEntryType(
+	void filterByEntryType(BiblioInfo const & bi,
 		std::vector<docstring> & keyVector, docstring entryType);
 	///
 	CiteEngine citeEngine() const;
@@ -136,6 +138,7 @@ private:
 	/// Search a given string within the passed keys.
 	/// \return the vector of matched keys.
 	std::vector<docstring> searchKeys(
+		BiblioInfo const & bi, //< optimize by passing this
 		std::vector<docstring> const & keys_to_search, //< Keys to search.
 		bool only_keys, //< whether to search only the keys
 		docstring const & search_expression, //< Search expression (regex possible)
@@ -145,6 +148,8 @@ private:
 		); //
 
 	/// The BibTeX information available to the dialog
+	/// Calls to this method will lead to checks of modification times and
+	/// the like, so it should be avoided.
 	BiblioInfo const & bibInfo() const;
 
 	/// last used citation style