X-Git-Url: https://git.lyx.org/gitweb/?a=blobdiff_plain;f=src%2FVCBackend.cpp;h=ca603c9e1f8ed89c1c3ea9cd35ed045815485c41;hb=110445e3e2fe9beab1c38d2806cfd126dae967a9;hp=d242a21e499d557eb696be7c83c5477a619750ef;hpb=77cdef1fe0ca069c916e0f824c1b7ff98f771748;p=lyx.git

diff --git a/src/VCBackend.cpp b/src/VCBackend.cpp
index d242a21e49..ca603c9e1f 100644
--- a/src/VCBackend.cpp
+++ b/src/VCBackend.cpp
@@ -61,7 +61,7 @@ int VCS::doVCCommand(string const & cmd, FileName const & path, bool reportError
 	if (ret && reportError) {
 		docstring rcsmsg;
 		if (prefixIs(cmd, "ci "))
-			rcsmsg = "\n" + _("Perhaps the RCS package is not installed on your system?");
+			rcsmsg = "\n" + _("Check whether the GNU RCS package is installed on your system.");
 		frontend::Alert::error(_("Revision control error."),
 			bformat(_("Some problem occurred while running the command:\n"
 				  "'%1$s'.") + rcsmsg,
@@ -107,7 +107,6 @@ bool VCS::makeRCSRevision(string const &version, string &revis) const
 
 FileName VCS::checkParentDirs(FileName const & start, std::string const & file)
 {
-	static FileName empty;
 	FileName dirname = start.onlyPath();
 	do {
 		FileName tocheck = FileName(addPathName(dirname.absFileName(), file));
@@ -117,7 +116,7 @@ FileName VCS::checkParentDirs(FileName const & start, std::string const & file)
 		// this construct because of #8295
 		dirname = FileName(dirname.absFileName()).parentPath();
 	} while (!dirname.empty());
-	return empty;
+	return FileName();
 }
 
 
@@ -162,8 +161,8 @@ bool RCS::retrieve(FileName const & file)
 {
 	LYXERR(Debug::LYXVC, "LyXVC::RCS: retrieve.\n\t" << file);
 	// The caller ensures that file does not exist, so no need to check that.
-	return doVCCommandCall("co -q -r " + quoteName(file.toFilesystemEncoding()),
-	                       FileName()) == 0;
+	int const ret = doVCCommandCall("co -q -r " + quoteName(file.toFilesystemEncoding()));
+	return ret == 0;
 }
 
 
@@ -1157,22 +1156,21 @@ bool CVS::prepareFileRevisionEnabled()
 //
 /////////////////////////////////////////////////////////////////////
 
-SVN::SVN(FileName const & m, Buffer * b) : VCS(b)
+SVN::SVN(Buffer * b) : VCS(b)
 {
 	// Here we know that the buffer file is either already in SVN or
 	// about to be registered
-	master_ = m;
 	locked_mode_ = false;
 	scanMaster();
 }
 
 
-FileName const SVN::findFile(FileName const & file)
+bool SVN::findFile(FileName const & file)
 {
 	// First we check the existence of repository meta data.
 	if (VCS::checkParentDirs(file, ".svn").empty()) {
 		LYXERR(Debug::LYXVC, "Cannot find SVN meta data for " << file);
-		return FileName();
+		return false;
 	}
 
 	// Now we check the status of the file.
@@ -1181,7 +1179,7 @@ FileName const SVN::findFile(FileName const & file)
 	bool found = 0 == doVCCommandCall("svn info " + quoteName(fname),
 						file.onlyPath());
 	LYXERR(Debug::LYXVC, "SVN control: " << (found ? "enabled" : "disabled"));
-	return found ? file : FileName();
+	return found;
 }
 
 
@@ -1190,12 +1188,8 @@ void SVN::scanMaster()
 	// vcstatus code is somewhat superflous,
 	// until we want to implement read-only toggle for svn.
 	vcstatus_ = NOLOCKING;
-	if (checkLockMode()) {
-		if (isLocked())
-			vcstatus_ = LOCKED;
-		else
-			vcstatus_ = UNLOCKED;
-	}
+	if (checkLockMode())
+		vcstatus_ = isLocked() ? LOCKED : UNLOCKED;
 }
 
 
@@ -1822,21 +1816,20 @@ bool SVN::toggleReadOnlyEnabled()
 //
 /////////////////////////////////////////////////////////////////////
 
-GIT::GIT(FileName const & m, Buffer * b) : VCS(b)
+GIT::GIT(Buffer * b) : VCS(b)
 {
 	// Here we know that the buffer file is either already in GIT or
 	// about to be registered
-	master_ = m;
 	scanMaster();
 }
 
 
-FileName const GIT::findFile(FileName const & file)
+bool GIT::findFile(FileName const & file)
 {
 	// First we check the existence of repository meta data.
 	if (VCS::checkParentDirs(file, ".git").empty()) {
 		LYXERR(Debug::LYXVC, "Cannot find GIT meta data for " << file);
-		return FileName();
+		return false;
 	}
 
 	// Now we check the status of the file.
@@ -1844,7 +1837,7 @@ FileName const GIT::findFile(FileName const & file)
 	FileName tmpf = tempfile.name();
 	if (tmpf.empty()) {
 		LYXERR(Debug::LYXVC, "Could not generate logfile " << tmpf);
-		return FileName();
+		return false;
 	}
 
 	string const fname = onlyFileName(file.absFileName());
@@ -1857,7 +1850,7 @@ FileName const GIT::findFile(FileName const & file)
 	tmpf.refresh();
 	bool found = !tmpf.isFileEmpty();
 	LYXERR(Debug::LYXVC, "GIT control: " << (found ? "enabled" : "disabled"));
-	return found ? file : FileName();
+	return found;
 }