X-Git-Url: https://git.lyx.org/gitweb/?a=blobdiff_plain;f=src%2FRowPainter.h;h=ca719bd228e1b06ca249a0c9c5c3493e8fdbe6bb;hb=bf56e2c8e1afa857cd5e313c19948040e41b8227;hp=0628f3288f2a4c81488ab24b7425a0d6125f9968;hpb=9c55af4a223ce4db29d643251109e245665344bd;p=lyx.git

diff --git a/src/RowPainter.h b/src/RowPainter.h
index 0628f3288f..ca719bd228 100644
--- a/src/RowPainter.h
+++ b/src/RowPainter.h
@@ -14,8 +14,8 @@
 #ifndef ROWPAINTER_H
 #define ROWPAINTER_H
 
-#include "Bidi.h"
 #include "Changes.h"
+#include "Row.h"
 
 #include "support/types.h"
 
@@ -30,27 +30,11 @@ class PainterInfo;
 class Paragraph;
 class ParagraphList;
 class ParagraphMetrics;
-class Row;
 class Text;
 class TextMetrics;
 
 namespace frontend { class Painter; }
 
-/**
- * FIXME: Re-implement row painting using row elements.
- *
- * This is not difficult in principle, but the code is intricate and
- * needs some careful analysis. The first thing that needs to be done
- * is to break row elements with the same criteria. Currently breakRow
- * does not consider on-the-fly spell-checking, but it is not clear to
- * me that it is required. Moreover, this thing would only work if we
- * are sure that the Row object is up-to-date when drawing happens.
- * This depends on the update machinery.
- *
- * This would allow to get rid of the Bidi class.
- */
-
-
 /**
  * A class used for painting an individual row of text.
  * FIXME: get rid of that class.
@@ -59,40 +43,35 @@ class RowPainter {
 public:
 	/// initialise and run painter
 	RowPainter(PainterInfo & pi, Text const & text,
-		pit_type pit, Row const & row, int x, int y);
+	           Row const & row, int x, int y);
 
 	/// paint various parts
 	/// FIXME: transfer to TextMetrics
-	void paintAppendix();
-	void paintDepthBar();
-	void paintChangeBar();
-	void paintTooLargeMarks(bool const left, bool const right);
-	void paintFirst();
-	void paintLast();
+	void paintAppendix() const;
+	void paintDepthBar() const;
+	void paintChangeBar() const;
+	void paintTooLargeMarks(bool const left, bool const right) const;
+	void paintFirst() const;
+	void paintLast() const;
 	void paintText();
 	void paintOnlyInsets();
-	void paintSelection();
+	void paintSelection() const;
 
 private:
-	void paintSeparator(double orig_x, double width, FontInfo const & font);
-	void paintForeignMark(double orig_x, Language const * lang, int desc = 0);
-	void paintMisspelledMark(double orig_x, bool changed);
-	void paintChars(pos_type & vpos, Font const & font);
-	int paintAppendixStart(int y);
-	void paintFromPos(pos_type & vpos, bool changed);
-	void paintInset(Inset const * inset, pos_type const pos);
-	void paintInlineCompletion(Font const & font);
-
-	/// return left margin
-	int leftMargin() const;
+	void paintForeignMark(Row::Element const & e) const;
+	void paintStringAndSel(Row::Element const & e) const;
+	void paintMisspelledMark(Row::Element const & e) const;
+	void paintChange(Row::Element const & e) const;
+	void paintAppendixStart(int y) const;
+	void paintInset(Row::Element const & e) const;
 
 	/// return the label font for this row
 	FontInfo labelFont() const;
 
 	///
-	void paintLabel();
+	void paintLabel() const;
 	///
-	void paintTopLevelLabel();
+	void paintTopLevelLabel() const;
 
 
 	/// contains painting related information.
@@ -100,20 +79,16 @@ private:
 
 	/// Text for the row
 	Text const & text_;
-	TextMetrics & text_metrics_;
+	TextMetrics const & text_metrics_;
 	ParagraphList const & pars_;
 
 	/// The row to paint
 	Row const & row_;
 
 	/// Row's paragraph
-	pit_type const pit_;
 	Paragraph const & par_;
 	ParagraphMetrics const & pm_;
 
-	/// bidi cache
-	Bidi bidi_;
-
 	/// row changed? (change tracking)
 	Change const change_;
 
@@ -122,10 +97,6 @@ private:
 	int const yo_;    // current baseline
 	double x_;
 	int width_;
-	float solid_line_thickness_;
-	int solid_line_offset_;
-	float dotted_line_thickness_;
-	int dotted_line_offset_;
 };
 
 } // namespace lyx