X-Git-Url: https://git.lyx.org/gitweb/?a=blobdiff_plain;f=src%2FParagraph.cpp;h=e7b2c78564a446497cddfb1d140eeda11d0eff2a;hb=449c766e03d94ddf6c823cfcae845f76f83c0e1c;hp=71f68919da549c89f296c04450e92d8f693ec9ea;hpb=b55a6454d905e0f46cc8ada6d7929483e5ffe62d;p=lyx.git

diff --git a/src/Paragraph.cpp b/src/Paragraph.cpp
index 71f68919da..e7b2c78564 100644
--- a/src/Paragraph.cpp
+++ b/src/Paragraph.cpp
@@ -25,7 +25,7 @@
 #include "BufferParams.h"
 #include "Changes.h"
 #include "Counters.h"
-#include "Encoding.h"
+#include "BufferEncodings.h"
 #include "InsetList.h"
 #include "Language.h"
 #include "LaTeXFeatures.h"
@@ -69,8 +69,10 @@ using namespace lyx::support;
 namespace lyx {
 
 namespace {
+
 /// Inset identifier (above 0x10ffff, for ucs-4)
 char_type const META_INSET = 0x200001;
+
 }
 
 
@@ -94,7 +96,7 @@ public:
 	///
 	void result(SpellChecker::Result r) { result_ = r; }
 	///
-	bool inside(pos_type pos) const { return range_.inside(pos); }
+	bool contains(pos_type pos) const { return range_.contains(pos); }
 	///
 	bool covered(FontSpan const & r) const
 	{
@@ -102,8 +104,9 @@ public:
 		// 2. last of new range inside current range or
 		// 3. first of current range inside new range or
 		// 4. last of current range inside new range
-		return range_.inside(r.first) || range_.inside(r.last) ||
-			r.inside(range_.first) || r.inside(range_.last);
+		//FIXME: is this the same as !range_.intersect(r).empty() ?
+		return range_.contains(r.first) || range_.contains(r.last) ||
+			r.contains(range_.first) || r.contains(range_.last);
 	}
 	///
 	void shift(pos_type pos, int offset)
@@ -129,7 +132,8 @@ private:
 
 class SpellCheckerState {
 public:
-	SpellCheckerState() {
+	SpellCheckerState()
+	{
 		needs_refresh_ = true;
 		current_change_number_ = 0;
 	}
@@ -188,7 +192,7 @@ public:
 		RangesIterator et = ranges_.end();
 		RangesIterator it = ranges_.begin();
 		for (; it != et; ++it) {
-			if(it->inside(pos)) {
+			if(it->contains(pos)) {
 				return it->result();
 			}
 		}
@@ -202,27 +206,31 @@ public:
 		RangesIterator et = ranges_.end();
 		RangesIterator it = ranges_.begin();
 		for (; it != et; ++it) {
-			if(it->inside(pos)) {
+			if(it->contains(pos)) {
 				return it->range();
 			}
 		}
 		return empty_;
 	}
 
-	bool needsRefresh() const {
+	bool needsRefresh() const
+	{
 		return needs_refresh_;
 	}
 
-	SpellChecker::ChangeNumber currentChangeNumber() const {
+	SpellChecker::ChangeNumber currentChangeNumber() const
+	{
 		return current_change_number_;
 	}
 
-	void refreshRange(pos_type & first, pos_type & last) const {
+	void refreshRange(pos_type & first, pos_type & last) const
+	{
 		first = refresh_.first;
 		last = refresh_.last;
 	}
 
-	void needsRefresh(pos_type pos) {
+	void needsRefresh(pos_type pos)
+	{
 		if (needs_refresh_ && pos != -1) {
 			if (pos < refresh_.first)
 				refresh_.first = pos;
@@ -237,13 +245,13 @@ public:
 		needs_refresh_ = pos != -1;
 	}
 
-	void needsCompleteRefresh(SpellChecker::ChangeNumber change_number) {
+	void needsCompleteRefresh(SpellChecker::ChangeNumber change_number)
+	{
 		needs_refresh_ = true;
 		refresh_.first = 0;
 		refresh_.last = -1;
 		current_change_number_ = change_number;
 	}
-
 private:
 	typedef vector<SpellResultRange> Ranges;
 	typedef Ranges::const_iterator RangesIterator;
@@ -274,6 +282,10 @@ private:
 
 class Paragraph::Private
 {
+	// Enforce our own "copy" constructor by declaring the standard one and
+	// the assignment operator private without implementing them.
+	Private(Private const &);
+	Private & operator=(Private const &);
 public:
 	///
 	Private(Paragraph * owner, Layout const & layout);
@@ -384,9 +396,10 @@ public:
 	Language * getSpellLanguage(pos_type const from) const;
 
 	Language * locateSpellRange(pos_type & from, pos_type & to,
-								SkipPositions & skips) const;
+				    SkipPositions & skips) const;
 
-	bool hasSpellerChange() const {
+	bool hasSpellerChange() const
+	{
 		SpellChecker::ChangeNumber speller_change_number = 0;
 		if (theSpellChecker())
 			speller_change_number = theSpellChecker()->changeNumber();
@@ -405,14 +418,16 @@ public:
 		speller_state_.setRange(fp, state);
 	}
 
-	void requestSpellCheck(pos_type pos) {
+	void requestSpellCheck(pos_type pos)
+	{
 		if (pos == -1)
 			speller_state_.needsCompleteRefresh(speller_state_.currentChangeNumber());
 		else
 			speller_state_.needsRefresh(pos);
 	}
 
-	void readySpellCheck() {
+	void readySpellCheck()
+	{
 		speller_state_.needsRefresh(-1);
 	}
 
@@ -489,7 +504,7 @@ public:
 	TextContainer text_;
 
 	typedef set<docstring> Words;
-	typedef map<Language, Words> LangWordsMap;
+	typedef map<string, Words> LangWordsMap;
 	///
 	LangWordsMap words_;
 	///
@@ -575,16 +590,16 @@ Paragraph::Private::Private(Private const & p, Paragraph * owner,
 
 
 void Paragraph::addChangesToToc(DocIterator const & cdit,
-	Buffer const & buf) const
+	Buffer const & buf, bool output_active) const
 {
-	d->changes_.addToToc(cdit, buf);
+	d->changes_.addToToc(cdit, buf, output_active);
 }
 
 
 bool Paragraph::isDeleted(pos_type start, pos_type end) const
 {
-	LASSERT(start >= 0 && start <= size(), /**/);
-	LASSERT(end > start && end <= size() + 1, /**/);
+	LASSERT(start >= 0 && start <= size(), return false);
+	LASSERT(end > start && end <= size() + 1, return false);
 
 	return d->changes_.isDeleted(start, end);
 }
@@ -592,8 +607,8 @@ bool Paragraph::isDeleted(pos_type start, pos_type end) const
 
 bool Paragraph::isChanged(pos_type start, pos_type end) const
 {
-	LASSERT(start >= 0 && start <= size(), /**/);
-	LASSERT(end > start && end <= size() + 1, /**/);
+	LASSERT(start >= 0 && start <= size(), return false);
+	LASSERT(end > start && end <= size() + 1, return false);
 
 	return d->changes_.isChanged(start, end);
 }
@@ -638,7 +653,7 @@ void Paragraph::setChange(Change const & change)
 
 void Paragraph::setChange(pos_type pos, Change const & change)
 {
-	LASSERT(pos >= 0 && pos <= size(), /**/);
+	LASSERT(pos >= 0 && pos <= size(), return);
 	d->changes_.set(change, pos);
 
 	// see comment in setChange(Change const &) above
@@ -650,15 +665,15 @@ void Paragraph::setChange(pos_type pos, Change const & change)
 
 Change const & Paragraph::lookupChange(pos_type pos) const
 {
-	LASSERT(pos >= 0 && pos <= size(), /**/);
+	LBUFERR(pos >= 0 && pos <= size());
 	return d->changes_.lookup(pos);
 }
 
 
 void Paragraph::acceptChanges(pos_type start, pos_type end)
 {
-	LASSERT(start >= 0 && start <= size(), /**/);
-	LASSERT(end > start && end <= size() + 1, /**/);
+	LASSERT(start >= 0 && start <= size(), return);
+	LASSERT(end > start && end <= size() + 1, return);
 
 	for (pos_type pos = start; pos < end; ++pos) {
 		switch (lookupChange(pos).type) {
@@ -692,8 +707,8 @@ void Paragraph::acceptChanges(pos_type start, pos_type end)
 
 void Paragraph::rejectChanges(pos_type start, pos_type end)
 {
-	LASSERT(start >= 0 && start <= size(), /**/);
-	LASSERT(end > start && end <= size() + 1, /**/);
+	LASSERT(start >= 0 && start <= size(), return);
+	LASSERT(end > start && end <= size() + 1, return);
 
 	for (pos_type pos = start; pos < end; ++pos) {
 		switch (lookupChange(pos).type) {
@@ -728,7 +743,7 @@ void Paragraph::rejectChanges(pos_type start, pos_type end)
 void Paragraph::Private::insertChar(pos_type pos, char_type c,
 		Change const & change)
 {
-	LASSERT(pos >= 0 && pos <= int(text_.size()), /**/);
+	LASSERT(pos >= 0 && pos <= int(text_.size()), return);
 
 	// track change
 	changes_.insert(change, pos);
@@ -757,10 +772,10 @@ void Paragraph::Private::insertChar(pos_type pos, char_type c,
 
 
 bool Paragraph::insertInset(pos_type pos, Inset * inset,
-				   Change const & change)
+				   Font const & font, Change const & change)
 {
-	LASSERT(inset, /**/);
-	LASSERT(pos >= 0 && pos <= size(), /**/);
+	LASSERT(inset, return false);
+	LASSERT(pos >= 0 && pos <= size(), return false);
 
 	// Paragraph::insertInset() can be used in cut/copy/paste operation where
 	// d->inset_owner_ is not set yet.
@@ -768,13 +783,14 @@ bool Paragraph::insertInset(pos_type pos, Inset * inset,
 		return false;
 
 	d->insertChar(pos, META_INSET, change);
-	LASSERT(d->text_[pos] == META_INSET, /**/);
+	LASSERT(d->text_[pos] == META_INSET, return false);
 
 	// Add a new entry in the insetlist_.
 	d->insetlist_.insert(inset, pos);
 
 	// Some insets require run of spell checker
 	requestSpellCheck(pos);
+	setFont(pos, font);
 	return true;
 }
 
@@ -836,8 +852,8 @@ bool Paragraph::eraseChar(pos_type pos, bool trackChanges)
 
 int Paragraph::eraseChars(pos_type start, pos_type end, bool trackChanges)
 {
-	LASSERT(start >= 0 && start <= size(), /**/);
-	LASSERT(end >= start && end <= size() + 1, /**/);
+	LASSERT(start >= 0 && start <= size(), return 0);
+	LASSERT(end >= start && end <= size() + 1, return 0);
 
 	pos_type i = start;
 	for (pos_type count = end - start; count; --count) {
@@ -859,7 +875,13 @@ int Paragraph::Private::latexSurrogatePair(otexstream & os, char_type c,
 	// FIXME: change tracking
 	// Is this correct WRT change tracking?
 	Encoding const & encoding = *(runparams.encoding);
-	docstring const latex1 = encoding.latexChar(next).first;
+	docstring latex1 = encoding.latexChar(next).first;
+	if (runparams.inIPA) {
+		string const tipashortcut = Encodings::TIPAShortcut(next);
+		if (!tipashortcut.empty()) {
+			latex1 = from_ascii(tipashortcut);
+		}
+	}
 	docstring const latex2 = encoding.latexChar(c).first;
 	if (docstring(1, next) == latex1) {
 		// the encoding supports the combination
@@ -1027,15 +1049,17 @@ void Paragraph::Private::latexInset(BufferParams const & bparams,
 				    unsigned int & column)
 {
 	Inset * inset = owner_->getInset(i);
-	LASSERT(inset, /**/);
+	LBUFERR(inset);
 
 	if (style.pass_thru) {
-		inset->plaintext(os.os(), runparams);
+		odocstringstream ods;
+		inset->plaintext(ods, runparams);
+		os << ods.str();
 		return;
 	}
 
 	// FIXME: move this to InsetNewline::latex
-	if (inset->lyxCode() == NEWLINE_CODE) {
+	if (inset->lyxCode() == NEWLINE_CODE || inset->lyxCode() == SEPARATOR_CODE) {
 		// newlines are handled differently here than
 		// the default in simpleTeXSpecialChars().
 		if (!style.newline_allowed) {
@@ -1283,7 +1307,7 @@ void Paragraph::Private::latexSpecialChar(otexstream & os,
 		docstring nextlatex;
 		bool nexttipas = false;
 		string nexttipashortcut;
-		if (next != '\0' && next != META_INSET) {
+		if (next != '\0' && next != META_INSET && encoding.encodable(next)) {
 			nextlatex = encoding.latexChar(next).first;
 			if (runparams.inIPA) {
 				nexttipashortcut = Encodings::TIPAShortcut(next);
@@ -1358,16 +1382,19 @@ bool Paragraph::Private::latexSpecialT1(char_type const c, otexstream & os,
 
 
 bool Paragraph::Private::latexSpecialT3(char_type const c, otexstream & os,
-	pos_type /*i*/, unsigned int & /*column*/)
+	pos_type /*i*/, unsigned int & column)
 {
 	switch (c) {
 	case '*':
 	case '[':
 	case ']':
-	case '|':
 	case '\"':
 		os.put(c);
 		return true;
+	case '|':
+		os << "\\textvertline{}";
+		column += 14;
+		return true;
 	default:
 		return false;
 	}
@@ -1428,7 +1455,8 @@ void Paragraph::Private::validate(LaTeXFeatures & features) const
 	if (layout_->inpreamble && inset_owner_) {
 		bool const is_command = layout_->latextype == LATEX_COMMAND;
 		Buffer const & buf = inset_owner_->buffer();
-		BufferParams const & bp = buf.params();
+		BufferParams const & bp = features.runparams().is_child
+			? buf.masterParams() : buf.params();
 		Font f;
 		TexRow texrow;
 		// Using a string stream here circumvents the encoding
@@ -1442,18 +1470,25 @@ void Paragraph::Private::validate(LaTeXFeatures & features) const
 			// we have to provide all the optional arguments here, even though
 			// the last one is the only one we care about.
 			// Separate handling of optional argument inset.
-			if (layout_->optargs != 0 || layout_->reqargs != 0)
-				latexArgInsets(*owner_, os, features.runparams(),
-					layout_->reqargs, layout_->optargs);
-			else
-				os << from_ascii(layout_->latexparam());
+			if (!layout_->latexargs().empty()) {
+				OutputParams rp = features.runparams();
+				rp.local_font = &owner_->getFirstFontSettings(bp);
+				latexArgInsets(*owner_, os, rp, layout_->latexargs());
+			}
+			os << from_ascii(layout_->latexparam());
 		}
 		docstring::size_type const length = ods.str().length();
 		// this will output "{" at the beginning, but not at the end
 		owner_->latex(bp, f, os, features.runparams(), 0, -1, true);
 		if (ods.str().length() > length) {
-			if (is_command)
+			if (is_command) {
 				ods << '}';
+				if (!layout_->postcommandargs().empty()) {
+					OutputParams rp = features.runparams();
+					rp.local_font = &owner_->getFirstFontSettings(bp);
+					latexArgInsets(*owner_, os, rp, layout_->postcommandargs(), "post:");
+				}
+			}
 			string const snippet = to_utf8(ods.str());
 			features.addPreambleSnippet(snippet);
 		}
@@ -1486,7 +1521,7 @@ void Paragraph::Private::validate(LaTeXFeatures & features) const
 			icit->inset->validate(features);
 			if (layout_->needprotect &&
 			    icit->inset->lyxCode() == FOOT_CODE)
-				features.require("NeedLyXFootnoteCode");
+				features.require("footmisc");
 		}
 	}
 
@@ -1499,7 +1534,7 @@ void Paragraph::Private::validate(LaTeXFeatures & features) const
 				break;
 			}
 		}
-		Encodings::validate(text_[i], features);
+		BufferEncodings::validate(text_[i], features);
 	}
 }
 
@@ -1641,6 +1676,9 @@ void Paragraph::write(ostream & os, BufferParams const & bparams,
 					os << "\n\\end_inset\n\n";
 					column = 0;
 				}
+				// FIXME This can be removed again once the mystery
+				// crash has been resolved.
+				os << flush;
 			}
 			break;
 		case '\\':
@@ -1676,6 +1714,9 @@ void Paragraph::write(ostream & os, BufferParams const & bparams,
 
 	flushString(os, write_buffer);
 	os << "\n\\end_layout\n";
+	// FIXME This can be removed again once the mystery
+	// crash has been resolved.
+	os << flush;
 }
 
 
@@ -1754,16 +1795,6 @@ void Paragraph::insertChar(pos_type pos, char_type c,
 }
 
 
-bool Paragraph::insertInset(pos_type pos, Inset * inset,
-			    Font const & font, Change const & change)
-{
-	bool const success = insertInset(pos, inset, change);
-	// Set the font/language of the inset...
-	setFont(pos, font);
-	return success;
-}
-
-
 void Paragraph::resetFonts(Font const & font)
 {
 	d->fontlist_.clear();
@@ -1777,7 +1808,7 @@ Font const & Paragraph::getFontSettings(BufferParams const & bparams,
 {
 	if (pos > size()) {
 		LYXERR0("pos: " << pos << " size: " << size());
-		LASSERT(pos <= size(), /**/);
+		LBUFERR(false);
 	}
 
 	FontList::const_iterator cit = d->fontlist_.fontIterator(pos);
@@ -1802,9 +1833,9 @@ Font const & Paragraph::getFontSettings(BufferParams const & bparams,
 
 FontSpan Paragraph::fontSpan(pos_type pos) const
 {
-	LASSERT(pos <= size(), /**/);
-	pos_type start = 0;
+	LBUFERR(pos < size());
 
+	pos_type start = 0;
 	FontList::const_iterator cit = d->fontlist_.begin();
 	FontList::const_iterator end = d->fontlist_.end();
 	for (; cit != end; ++cit) {
@@ -1821,8 +1852,8 @@ FontSpan Paragraph::fontSpan(pos_type pos) const
 	}
 
 	// This should not happen, but if so, we take no chances.
-	// LYXERR0("Paragraph::getEndPosOfFontSpan: This should not happen!");
-	return FontSpan(pos, pos);
+	LYXERR0("Paragraph::fontSpan: position not found in fontinfo table!");
+	LASSERT(false, return FontSpan(pos, pos));
 }
 
 
@@ -1853,7 +1884,7 @@ Font const & Paragraph::getFirstFontSettings(BufferParams const & bparams) const
 Font const Paragraph::getFont(BufferParams const & bparams, pos_type pos,
 				 Font const & outerfont) const
 {
-	LASSERT(pos >= 0, /**/);
+	LBUFERR(pos >= 0);
 
 	Font font = getFontSettings(bparams, pos);
 
@@ -1902,7 +1933,7 @@ FontSize Paragraph::highestFontInRange
 char_type Paragraph::getUChar(BufferParams const & bparams, pos_type pos) const
 {
 	char_type c = d->text_[pos];
-	if (!lyxrc.rtl_support || !getFontSettings(bparams, pos).isRightToLeft())
+	if (!getFontSettings(bparams, pos).isRightToLeft())
 		return c;
 
 	// FIXME: The arabic special casing is due to the difference of arabic
@@ -1946,7 +1977,7 @@ char_type Paragraph::getUChar(BufferParams const & bparams, pos_type pos) const
 
 void Paragraph::setFont(pos_type pos, Font const & font)
 {
-	LASSERT(pos <= size(), /**/);
+	LASSERT(pos <= size(), return);
 
 	// First, reduce font against layout/label font
 	// Update: The setCharFont() routine in text2.cpp already
@@ -2058,8 +2089,7 @@ docstring Paragraph::expandParagraphLabel(Layout const & layout,
 	bool const in_appendix = process_appendix && d->params_.appendix();
 	docstring fmt = translateIfPossible(layout.labelstring(in_appendix), lang);
 
-	if (fmt.empty() && layout.labeltype == LABEL_COUNTER
-	    && !layout.counter.empty())
+	if (fmt.empty() && !layout.counter.empty())
 		return tclass.counters().theCounter(layout.counter, lang);
 
 	// handle 'inherited level parts' in 'fmt',
@@ -2113,17 +2143,17 @@ void Paragraph::setBeginOfBody()
 	// remove unnecessary getChar() calls
 	pos_type i = 0;
 	pos_type end = size();
-	if (i < end && !isNewline(i)) {
+	if (i < end && !(isNewline(i) || isEnvSeparator(i))) {
 		++i;
 		char_type previous_char = 0;
 		char_type temp = 0;
 		if (i < end) {
 			previous_char = d->text_[i];
-			if (!isNewline(i)) {
+			if (!(isNewline(i) || isEnvSeparator(i))) {
 				++i;
 				while (i < end && previous_char != ' ') {
 					temp = d->text_[i];
-					if (isNewline(i))
+					if (isNewline(i) || isEnvSeparator(i))
 						break;
 					++i;
 					previous_char = temp;
@@ -2150,7 +2180,7 @@ bool Paragraph::usePlainLayout() const
 
 bool Paragraph::isPassThru() const
 {
-	return inInset().getLayout().isPassThru() || d->layout_->pass_thru;
+	return inInset().isPassThru() || d->layout_->pass_thru;
 }
 
 namespace {
@@ -2178,36 +2208,37 @@ string correction(string const & orig)
 }
 
 
-string const corrected_env(string const & suffix, string const & env,
-	InsetCode code, bool const lastpar)
+bool corrected_env(otexstream & os, string const & suffix, string const & env,
+	InsetCode code, bool const lastpar, int & col)
 {
-	string output = suffix + "{";
+	string macro = suffix + "{";
 	if (noTrivlistCentering(code)) {
 		if (lastpar) {
 			// the last paragraph in non-trivlist-aligned
 			// context is special (to avoid unwanted whitespace)
-			if (suffix == "\\begin")
-				return "\\" + correction(env) + "{}";
-			return string();
+			if (suffix == "\\begin") {
+				macro = "\\" + correction(env) + "{}";
+				os << from_ascii(macro);
+				col += macro.size();
+				return true;
+			}
+			return false;
 		}
-		output += correction(env);
+		macro += correction(env);
 	} else
-		output += env;
-	output += "}";
-	if (suffix == "\\begin")
-		output += "\n";
-	return output;
-}
-
-
-void adjust_column(string const & str, int & column)
-{
-	if (!contains(str, "\n"))
-		column += str.size();
-	else {
-		string tmp;
-		column = rsplit(str, tmp, '\n').size();
+		macro += env;
+	macro += "}";
+	if (suffix == "\\par\\end") {
+		os << breakln;
+		col = 0;
 	}
+	os << from_ascii(macro);
+	col += macro.size();
+	if (suffix == "\\begin") {
+		os << breakln;
+		col = 0;
+	}
+	return true;
 }
 
 } // namespace anon
@@ -2218,7 +2249,8 @@ int Paragraph::Private::startTeXParParams(BufferParams const & bparams,
 {
 	int column = 0;
 
-	if (params_.noindent() && !layout_->pass_thru) {
+	if (params_.noindent() && !layout_->pass_thru
+	    && (layout_->toggle_indent != ITOGGLE_NEVER)) {
 		os << "\\noindent ";
 		column += 10;
 	}
@@ -2257,28 +2289,20 @@ int Paragraph::Private::startTeXParParams(BufferParams const & bparams,
 	case LYX_ALIGN_DECIMAL:
 		break;
 	case LYX_ALIGN_LEFT: {
-		string output;
 		if (owner_->getParLanguage(bparams)->babel() != "hebrew")
-			output = corrected_env(begin_tag, "flushleft", code, lastpar);
+			corrected_env(os, begin_tag, "flushleft", code, lastpar, column);
 		else
-			output = corrected_env(begin_tag, "flushright", code, lastpar);
-		os << from_ascii(output);
-		adjust_column(output, column);
+			corrected_env(os, begin_tag, "flushright", code, lastpar, column);
 		break;
 	} case LYX_ALIGN_RIGHT: {
 		string output;
 		if (owner_->getParLanguage(bparams)->babel() != "hebrew")
-			output = corrected_env(begin_tag, "flushright", code, lastpar);
+			corrected_env(os, begin_tag, "flushright", code, lastpar, column);
 		else
-			output = corrected_env(begin_tag, "flushleft", code, lastpar);
-		os << from_ascii(output);
-		adjust_column(output, column);
+			corrected_env(os, begin_tag, "flushleft", code, lastpar, column);
 		break;
 	} case LYX_ALIGN_CENTER: {
-		string output;
-		output = corrected_env(begin_tag, "center", code, lastpar);
-		os << from_ascii(output);
-		adjust_column(output, column);
+		corrected_env(os, begin_tag, "center", code, lastpar, column);
 		break;
 	}
 	}
@@ -2310,8 +2334,9 @@ bool Paragraph::Private::endTeXParParams(BufferParams const & bparams,
 		break;
 	}
 
-	string output;
-	string const end_tag = "\n\\par\\end";
+	bool output = false;
+	int col = 0;
+	string const end_tag = "\\par\\end";
 	InsetCode code = ownerCode();
 	bool const lastpar = runparams.isLastPar;
 
@@ -2324,26 +2349,23 @@ bool Paragraph::Private::endTeXParParams(BufferParams const & bparams,
 		break;
 	case LYX_ALIGN_LEFT: {
 		if (owner_->getParLanguage(bparams)->babel() != "hebrew")
-			output = corrected_env(end_tag, "flushleft", code, lastpar);
+			output = corrected_env(os, end_tag, "flushleft", code, lastpar, col);
 		else
-			output = corrected_env(end_tag, "flushright", code, lastpar);
-		os << from_ascii(output);
+			output = corrected_env(os, end_tag, "flushright", code, lastpar, col);
 		break;
 	} case LYX_ALIGN_RIGHT: {
 		if (owner_->getParLanguage(bparams)->babel() != "hebrew")
-			output = corrected_env(end_tag, "flushright", code, lastpar);
+			output = corrected_env(os, end_tag, "flushright", code, lastpar, col);
 		else
-			output = corrected_env(end_tag, "flushleft", code, lastpar);
-		os << from_ascii(output);
+			output = corrected_env(os, end_tag, "flushleft", code, lastpar, col);
 		break;
 	} case LYX_ALIGN_CENTER: {
-		output = corrected_env(end_tag, "center", code, lastpar);
-		os << from_ascii(output);
+		corrected_env(os, end_tag, "center", code, lastpar, col);
 		break;
 	}
 	}
 
-	return !output.empty() || lastpar;
+	return output || lastpar;
 }
 
 
@@ -2409,6 +2431,10 @@ void Paragraph::latex(BufferParams const & bparams,
 			os << '{';
 			++column;
 		}
+		if (!style.leftdelim().empty()) {
+			os << style.leftdelim();
+			column += style.leftdelim().size();
+		}
 		if (allowcust)
 			column += d->startTeXParParams(bparams, os, runparams);
 	}
@@ -2439,6 +2465,11 @@ void Paragraph::latex(BufferParams const & bparams,
 				++column;
 			}
 
+			if (!style.leftdelim().empty()) {
+				os << style.leftdelim();
+				column += style.leftdelim().size();
+			}
+
 			if (allowcust)
 				column += d->startTeXParParams(bparams, os,
 							    runparams);
@@ -2447,7 +2478,7 @@ void Paragraph::latex(BufferParams const & bparams,
 		Change const & change = runparams.inDeletedInset
 			? runparams.changeOfDeletedInset : lookupChange(i);
 
-		if (bparams.outputChanges && runningChange != change) {
+		if (bparams.output_changes && runningChange != change) {
 			if (open_font) {
 				column += running_font.latexWriteEndChanges(
 						os, bparams, runparams, basefont, basefont);
@@ -2463,7 +2494,7 @@ void Paragraph::latex(BufferParams const & bparams,
 
 		// do not output text which is marked deleted
 		// if change tracking output is disabled
-		if (!bparams.outputChanges && change.deleted()) {
+		if (!bparams.output_changes && change.deleted()) {
 			continue;
 		}
 
@@ -2629,6 +2660,11 @@ void Paragraph::latex(BufferParams const & bparams,
 		os << "}]~";
 	}
 
+	if (!style.rightdelim().empty()) {
+		os << style.rightdelim();
+		column += style.rightdelim().size();
+	}
+
 	if (allowcust && d->endTeXParParams(bparams, os, runparams)
 	    && runparams.encoding != prev_encoding) {
 		runparams.encoding = prev_encoding;
@@ -2790,6 +2826,22 @@ void Paragraph::simpleDocBookOnePar(Buffer const & buf,
 }
 
 
+namespace {
+void doFontSwitch(vector<html::FontTag> & tagsToOpen,
+                  vector<html::EndFontTag> & tagsToClose,
+                  bool & flag, FontState curstate, html::FontTypes type)
+{
+	if (curstate == FONT_ON) {
+		tagsToOpen.push_back(html::FontTag(type));
+		flag = true;
+	} else if (flag) {
+		tagsToClose.push_back(html::EndFontTag(type));
+		flag = false;
+	}
+}
+}
+
+
 docstring Paragraph::simpleLyXHTMLOnePar(Buffer const & buf,
 				    XHTMLStream & xs,
 				    OutputParams const & runparams,
@@ -2798,65 +2850,317 @@ docstring Paragraph::simpleLyXHTMLOnePar(Buffer const & buf,
 {
 	docstring retval;
 
+	// track whether we have opened these tags
 	bool emph_flag = false;
 	bool bold_flag = false;
+	bool noun_flag = false;
+	bool ubar_flag = false;
+	bool dbar_flag = false;
+	bool sout_flag = false;
+	bool wave_flag = false;
+	// shape tags
+	bool shap_flag = false;
+	// family tags
+	bool faml_flag = false;
+	// size tags
+	bool size_flag = false;
 
 	Layout const & style = *d->layout_;
 
 	xs.startParagraph(allowEmpty());
 
-	if (!runparams.for_toc && runparams.html_make_pars) {
-		// generate a magic label for this paragraph
-		string const attr = "id='" + magicLabel() + "'";
-		xs << html::CompTag("a", attr);
-	}
-
 	FontInfo font_old =
 		style.labeltype == LABEL_MANUAL ? style.labelfont : style.font;
 
+	FontShape  curr_fs   = INHERIT_SHAPE;
+	FontFamily curr_fam  = INHERIT_FAMILY;
+	FontSize   curr_size = FONT_SIZE_INHERIT;
+	
+	string const default_family = 
+		buf.masterBuffer()->params().fonts_default_family;		
+
+	vector<html::FontTag> tagsToOpen;
+	vector<html::EndFontTag> tagsToClose;
+	
 	// parsing main loop
 	for (pos_type i = initial; i < size(); ++i) {
 		// let's not show deleted material in the output
 		if (isDeleted(i))
 			continue;
 
-		Font font = getFont(buf.params(), i, outerfont);
+		Font const font = getFont(buf.masterBuffer()->params(), i, outerfont);
 
 		// emphasis
-		if (font_old.emph() != font.fontInfo().emph()) {
-			if (font.fontInfo().emph() == FONT_ON) {
-				xs << html::StartTag("em");
-				emph_flag = true;
-			} else if (emph_flag && i != initial) {
-				xs << html::EndTag("em");
-				emph_flag = false;
+		FontState curstate = font.fontInfo().emph();
+		if (font_old.emph() != curstate)
+			doFontSwitch(tagsToOpen, tagsToClose, emph_flag, curstate, html::FT_EMPH);
+
+		// noun
+		curstate = font.fontInfo().noun();
+		if (font_old.noun() != curstate)
+			doFontSwitch(tagsToOpen, tagsToClose, noun_flag, curstate, html::FT_NOUN);
+
+		// underbar
+		curstate = font.fontInfo().underbar();
+		if (font_old.underbar() != curstate)
+			doFontSwitch(tagsToOpen, tagsToClose, ubar_flag, curstate, html::FT_UBAR);
+	
+		// strikeout
+		curstate = font.fontInfo().strikeout();
+		if (font_old.strikeout() != curstate)
+			doFontSwitch(tagsToOpen, tagsToClose, sout_flag, curstate, html::FT_SOUT);
+
+		// double underbar
+		curstate = font.fontInfo().uuline();
+		if (font_old.uuline() != curstate)
+			doFontSwitch(tagsToOpen, tagsToClose, dbar_flag, curstate, html::FT_DBAR);
+
+		// wavy line
+		curstate = font.fontInfo().uwave();
+		if (font_old.uwave() != curstate)
+			doFontSwitch(tagsToOpen, tagsToClose, wave_flag, curstate, html::FT_WAVE);
+
+		// bold
+		// a little hackish, but allows us to reuse what we have.
+		curstate = (font.fontInfo().series() == BOLD_SERIES ? FONT_ON : FONT_OFF);
+		if (font_old.series() != font.fontInfo().series())
+			doFontSwitch(tagsToOpen, tagsToClose, bold_flag, curstate, html::FT_BOLD);
+
+		// Font shape
+		curr_fs = font.fontInfo().shape();
+		FontShape old_fs = font_old.shape();
+		if (old_fs != curr_fs) {
+			if (shap_flag) {
+				switch (old_fs) {
+				case ITALIC_SHAPE:
+					tagsToClose.push_back(html::EndFontTag(html::FT_ITALIC));
+					break;
+				case SLANTED_SHAPE:
+					tagsToClose.push_back(html::EndFontTag(html::FT_SLANTED));
+					break;
+				case SMALLCAPS_SHAPE:
+					tagsToClose.push_back(html::EndFontTag(html::FT_SMALLCAPS));
+					break;
+				case UP_SHAPE:
+				case INHERIT_SHAPE:
+					break;
+				default:
+					// the other tags are for internal use
+					LATTEST(false);
+					break;
+				}
+				shap_flag = false;
+			}
+			switch (curr_fs) {
+			case ITALIC_SHAPE:
+				tagsToOpen.push_back(html::FontTag(html::FT_ITALIC));
+				shap_flag = true;
+				break;
+			case SLANTED_SHAPE:
+				tagsToOpen.push_back(html::FontTag(html::FT_SLANTED));
+				shap_flag = true;
+				break;
+			case SMALLCAPS_SHAPE:
+				tagsToOpen.push_back(html::FontTag(html::FT_SMALLCAPS));
+				shap_flag = true;
+				break;
+			case UP_SHAPE:
+			case INHERIT_SHAPE:
+				break;
+			default:
+				// the other tags are for internal use
+				LATTEST(false);
+				break;
 			}
 		}
-		// bold
-		if (font_old.series() != font.fontInfo().series()) {
-			if (font.fontInfo().series() == BOLD_SERIES) {
-				xs << html::StartTag("strong");
-				bold_flag = true;
-			} else if (bold_flag && i != initial) {
-				xs << html::EndTag("strong");
-				bold_flag = false;
+
+		// Font family
+		curr_fam = font.fontInfo().family();
+		FontFamily old_fam = font_old.family();
+		if (old_fam != curr_fam) {
+			if (faml_flag) {
+				switch (old_fam) {
+				case ROMAN_FAMILY:
+					tagsToClose.push_back(html::EndFontTag(html::FT_ROMAN));
+					break;
+				case SANS_FAMILY:
+					tagsToClose.push_back(html::EndFontTag(html::FT_SANS));
+					break;
+				case TYPEWRITER_FAMILY:
+					tagsToClose.push_back(html::EndFontTag(html::FT_TYPE));
+					break;
+				case INHERIT_FAMILY:
+					break;
+				default:
+					// the other tags are for internal use
+					LATTEST(false);
+					break;
+				}
+				faml_flag = false;
+			}
+			switch (curr_fam) {
+			case ROMAN_FAMILY:
+				// we will treat a "default" font family as roman, since we have
+				// no other idea what to do.
+				if (default_family != "rmdefault" && default_family != "default") {
+					tagsToOpen.push_back(html::FontTag(html::FT_ROMAN));
+					faml_flag = true;
+				}
+				break;
+			case SANS_FAMILY:
+				if (default_family != "sfdefault") {
+					tagsToOpen.push_back(html::FontTag(html::FT_SANS));
+					faml_flag = true;
+				}
+				break;
+			case TYPEWRITER_FAMILY:
+				if (default_family != "ttdefault") {
+					tagsToOpen.push_back(html::FontTag(html::FT_TYPE));
+					faml_flag = true;
+				}
+				break;
+			case INHERIT_FAMILY:
+				break;
+			default:
+				// the other tags are for internal use
+				LATTEST(false);
+				break;
+			}
+		}
+
+		// Font size
+		curr_size = font.fontInfo().size();
+		FontSize old_size = font_old.size();
+		if (old_size != curr_size) {
+			if (size_flag) {
+				switch (old_size) {
+				case FONT_SIZE_TINY:
+					tagsToClose.push_back(html::EndFontTag(html::FT_SIZE_TINY));
+					break;
+				case FONT_SIZE_SCRIPT:
+					tagsToClose.push_back(html::EndFontTag(html::FT_SIZE_SCRIPT));
+					break;
+				case FONT_SIZE_FOOTNOTE:
+					tagsToClose.push_back(html::EndFontTag(html::FT_SIZE_FOOTNOTE));
+					break;
+				case FONT_SIZE_SMALL:
+					tagsToClose.push_back(html::EndFontTag(html::FT_SIZE_SMALL));
+					break;
+				case FONT_SIZE_LARGE:
+					tagsToClose.push_back(html::EndFontTag(html::FT_SIZE_LARGE));
+					break;
+				case FONT_SIZE_LARGER:
+					tagsToClose.push_back(html::EndFontTag(html::FT_SIZE_LARGER));
+					break;
+				case FONT_SIZE_LARGEST:
+					tagsToClose.push_back(html::EndFontTag(html::FT_SIZE_LARGEST));
+					break;
+				case FONT_SIZE_HUGE:
+					tagsToClose.push_back(html::EndFontTag(html::FT_SIZE_HUGE));
+					break;
+				case FONT_SIZE_HUGER:
+					tagsToClose.push_back(html::EndFontTag(html::FT_SIZE_HUGER));
+					break;
+				case FONT_SIZE_INCREASE:
+					tagsToClose.push_back(html::EndFontTag(html::FT_SIZE_INCREASE));
+					break;
+				case FONT_SIZE_DECREASE:
+					tagsToClose.push_back(html::EndFontTag(html::FT_SIZE_DECREASE));
+					break;
+				case FONT_SIZE_INHERIT:
+				case FONT_SIZE_NORMAL:
+					break;
+				default:
+					// the other tags are for internal use
+					LATTEST(false);
+					break;
+				}
+				size_flag = false;
+			}
+			switch (curr_size) {
+			case FONT_SIZE_TINY:
+				tagsToOpen.push_back(html::FontTag(html::FT_SIZE_TINY));
+				size_flag = true;
+				break;
+			case FONT_SIZE_SCRIPT:
+				tagsToOpen.push_back(html::FontTag(html::FT_SIZE_SCRIPT));
+				size_flag = true;
+				break;
+			case FONT_SIZE_FOOTNOTE:
+				tagsToOpen.push_back(html::FontTag(html::FT_SIZE_FOOTNOTE));
+				size_flag = true;
+				break;
+			case FONT_SIZE_SMALL:
+				tagsToOpen.push_back(html::FontTag(html::FT_SIZE_SMALL));
+				size_flag = true;
+				break;
+			case FONT_SIZE_LARGE:
+				tagsToOpen.push_back(html::FontTag(html::FT_SIZE_LARGE));
+				size_flag = true;
+				break;
+			case FONT_SIZE_LARGER:
+				tagsToOpen.push_back(html::FontTag(html::FT_SIZE_LARGER));
+				size_flag = true;
+				break;
+			case FONT_SIZE_LARGEST:
+				tagsToOpen.push_back(html::FontTag(html::FT_SIZE_LARGEST));
+				size_flag = true;
+				break;
+			case FONT_SIZE_HUGE:
+				tagsToOpen.push_back(html::FontTag(html::FT_SIZE_HUGE));
+				size_flag = true;
+				break;
+			case FONT_SIZE_HUGER:
+				tagsToOpen.push_back(html::FontTag(html::FT_SIZE_HUGER));
+				size_flag = true;
+				break;
+			case FONT_SIZE_INCREASE:
+				tagsToOpen.push_back(html::FontTag(html::FT_SIZE_INCREASE));
+				size_flag = true;
+				break;
+			case FONT_SIZE_DECREASE:
+				tagsToOpen.push_back(html::FontTag(html::FT_SIZE_DECREASE));
+				size_flag = true;
+				break;
+			case FONT_SIZE_NORMAL:
+			case FONT_SIZE_INHERIT:
+				break;
+			default:
+				// the other tags are for internal use
+				LATTEST(false);
+				break;
 			}
 		}
+
 		// FIXME XHTML
 		// Other such tags? What about the other text ranges?
 
+		vector<html::EndFontTag>::const_iterator cit = tagsToClose.begin();
+		vector<html::EndFontTag>::const_iterator cen = tagsToClose.end();
+		for (; cit != cen; ++cit)
+			xs << *cit;
+
+		vector<html::FontTag>::const_iterator sit = tagsToOpen.begin();
+		vector<html::FontTag>::const_iterator sen = tagsToOpen.end();
+		for (; sit != sen; ++sit)
+			xs << *sit;
+
+		tagsToClose.clear();
+		tagsToOpen.clear();
+
 		Inset const * inset = getInset(i);
 		if (inset) {
 			if (!runparams.for_toc || inset->isInToc()) {
 				OutputParams np = runparams;
+				np.local_font = &font;
 				if (!inset->getLayout().htmlisblock())
 					np.html_in_par = true;
 				retval += inset->xhtml(xs, np);
 			}
 		} else {
-			char_type c = d->text_[i];
+			char_type c = getUChar(buf.masterBuffer()->params(), i);
 
-			if (style.pass_thru)
+			if (style.pass_thru || runparams.pass_thru)
 				xs << c;
 			else if (c == '-') {
 				docstring str;
@@ -2892,8 +3196,7 @@ docstring Paragraph::simpleLyXHTMLOnePar(Buffer const & buf,
 bool Paragraph::isHfill(pos_type pos) const
 {
 	Inset const * inset = getInset(pos);
-	return inset && (inset->lyxCode() == SPACE_CODE &&
-			 inset->isStretchableSpace());
+	return inset && inset->isHfill();
 }
 
 
@@ -2904,6 +3207,13 @@ bool Paragraph::isNewline(pos_type pos) const
 }
 
 
+bool Paragraph::isEnvSeparator(pos_type pos) const
+{
+	Inset const * inset = getInset(pos);
+	return inset && inset->lyxCode() == SEPARATOR_CODE;
+}
+
+
 bool Paragraph::isLineSeparator(pos_type pos) const
 {
 	char_type const c = d->text_[pos];
@@ -2990,8 +3300,7 @@ Paragraph::getParLanguage(BufferParams const & bparams) const
 
 bool Paragraph::isRTL(BufferParams const & bparams) const
 {
-	return lyxrc.rtl_support
-		&& getParLanguage(bparams)->rightToLeft()
+	return getParLanguage(bparams)->rightToLeft()
 		&& !inInset().getLayout().forceLTR();
 }
 
@@ -3046,7 +3355,7 @@ docstring Paragraph::asString(int options) const
 }
 
 
-docstring Paragraph::asString(pos_type beg, pos_type end, int options) const
+docstring Paragraph::asString(pos_type beg, pos_type end, int options, const OutputParams *runparams) const
 {
 	odocstringstream os;
 
@@ -3063,9 +3372,12 @@ docstring Paragraph::asString(pos_type beg, pos_type end, int options) const
 		    || (c == '\n' && (options & AS_STR_NEWLINES)))
 			os.put(c);
 		else if (c == META_INSET && (options & AS_STR_INSETS)) {
-			getInset(i)->toString(os);
-			if (getInset(i)->asInsetMath())
-				os << " ";
+			if (c == META_INSET && (options & AS_STR_PLAINTEXT)) {
+				LASSERT(runparams != 0, return docstring());
+				getInset(i)->plaintext(os, *runparams);
+			} else {
+				getInset(i)->toString(os);
+			}
 		}
 	}
 
@@ -3073,7 +3385,7 @@ docstring Paragraph::asString(pos_type beg, pos_type end, int options) const
 }
 
 
-void Paragraph::forToc(docstring & os, size_t maxlen) const
+void Paragraph::forOutliner(docstring & os, size_t maxlen) const
 {
 	if (!d->params_.labelString().empty())
 		os += d->params_.labelString() + ' ';
@@ -3086,34 +3398,11 @@ void Paragraph::forToc(docstring & os, size_t maxlen) const
 		else if (c == '\t' || c == '\n')
 			os += ' ';
 		else if (c == META_INSET)
-			getInset(i)->forToc(os, maxlen);
+			getInset(i)->forOutliner(os, maxlen);
 	}
 }
 
 
-docstring Paragraph::stringify(pos_type beg, pos_type end, int options, OutputParams & runparams) const
-{
-	odocstringstream os;
-
-	if (beg == 0
-		&& options & AS_STR_LABEL
-		&& !d->params_.labelString().empty())
-		os << d->params_.labelString() << ' ';
-
-	for (pos_type i = beg; i < end; ++i) {
-		char_type const c = d->text_[i];
-		if (isPrintable(c) || c == '\t'
-		    || (c == '\n' && (options & AS_STR_NEWLINES)))
-			os.put(c);
-		else if (c == META_INSET && (options & AS_STR_INSETS)) {
-			getInset(i)->plaintext(os, runparams);
-		}
-	}
-
-	return os.str();
-}
-
-
 void Paragraph::setInsetOwner(Inset const * inset)
 {
 	d->inset_owner_ = inset;
@@ -3167,8 +3456,7 @@ void Paragraph::setPlainOrDefaultLayout(DocumentClass const & tclass)
 
 Inset const & Paragraph::inInset() const
 {
-	LASSERT(d->inset_owner_, throw ExceptionMessage(BufferException,
-		_("Memory problem"), _("Paragraph not properly initialized")));
+	LBUFERR(d->inset_owner_);
 	return *d->inset_owner_;
 }
 
@@ -3201,46 +3489,6 @@ bool Paragraph::allowEmpty() const
 }
 
 
-char_type Paragraph::transformChar(char_type c, pos_type pos) const
-{
-	if (!Encodings::isArabicChar(c))
-		return c;
-
-	char_type prev_char = ' ';
-	char_type next_char = ' ';
-
-	for (pos_type i = pos - 1; i >= 0; --i) {
-		char_type const par_char = d->text_[i];
-		if (!Encodings::isArabicComposeChar(par_char)) {
-			prev_char = par_char;
-			break;
-		}
-	}
-
-	for (pos_type i = pos + 1, end = size(); i < end; ++i) {
-		char_type const par_char = d->text_[i];
-		if (!Encodings::isArabicComposeChar(par_char)) {
-			next_char = par_char;
-			break;
-		}
-	}
-
-	if (Encodings::isArabicChar(next_char)) {
-		if (Encodings::isArabicChar(prev_char) &&
-			!Encodings::isArabicSpecialChar(prev_char))
-			return Encodings::transformChar(c, Encodings::FORM_MEDIAL);
-		else
-			return Encodings::transformChar(c, Encodings::FORM_INITIAL);
-	} else {
-		if (Encodings::isArabicChar(prev_char) &&
-			!Encodings::isArabicSpecialChar(prev_char))
-			return Encodings::transformChar(c, Encodings::FORM_FINAL);
-		else
-			return Encodings::transformChar(c, Encodings::FORM_ISOLATED);
-	}
-}
-
-
 bool Paragraph::brokenBiblio() const
 {
 	// there is a problem if there is no bibitem at position 0 or
@@ -3262,7 +3510,7 @@ int Paragraph::fixBiblio(Buffer const & buffer)
 	if (d->layout_->labeltype != LABEL_BIBLIO)
 		return 0;
 
-	bool const track_changes = buffer.params().trackChanges;
+	bool const track_changes = buffer.params().track_changes;
 	int bibitem_pos = d->insetlist_.find(BIBITEM_CODE);
 	bool const hasbibitem0 = bibitem_pos == 0;
 
@@ -3277,8 +3525,7 @@ int Paragraph::fixBiblio(Buffer const & buffer)
 		// these, which there should be.
 		// FIXME: why does it make sense to do that rather
 		// than keep the first? (JMarc)
-		Inset * inset = d->insetlist_.release(bibitem_pos);
-		eraseChar(bibitem_pos, track_changes);
+		Inset * inset = releaseInset(bibitem_pos);
 		d->insetlist_.begin()->inset = inset;
 		return -bibitem_pos;
 	}
@@ -3294,7 +3541,8 @@ int Paragraph::fixBiblio(Buffer const & buffer)
 		inset = new InsetBibitem(const_cast<Buffer *>(&buffer),
 					 InsetCommandParams(BIBITEM_CODE));
 
-	insertInset(0, inset, Change(track_changes ? Change::INSERTED 
+	Font font(inherit_font, buffer.params().language);
+	insertInset(0, inset, font, Change(track_changes ? Change::INSERTED 
 				                   : Change::UNCHANGED));
 
 	return 1;
@@ -3366,9 +3614,11 @@ void Paragraph::changeCase(BufferParams const & bparams, pos_type pos,
 	// process sequences of modified characters; in change
 	// tracking mode, this approach results in much better
 	// usability than changing case on a char-by-char basis
-	docstring changes;
+	// We also need to track the current font, since font
+	// changes within sequences can occur.
+	vector<pair<char_type, Font> > changes;
 
-	bool const trackChanges = bparams.trackChanges;
+	bool const trackChanges = bparams.track_changes;
 
 	bool capitalize = true;
 
@@ -3400,7 +3650,7 @@ void Paragraph::changeCase(BufferParams const & bparams, pos_type pos,
 		}
 
 		if (oldChar != newChar) {
-			changes += newChar;
+			changes.push_back(make_pair(newChar, getFontSettings(bparams, pos)));
 			if (pos != right - 1)
 				continue;
 			// step behind the changing area
@@ -3409,9 +3659,8 @@ void Paragraph::changeCase(BufferParams const & bparams, pos_type pos,
 
 		int erasePos = pos - changes.size();
 		for (size_t i = 0; i < changes.size(); i++) {
-			insertChar(pos, changes[i],
-				   getFontSettings(bparams,
-						   erasePos),
+			insertChar(pos, changes[i].first,
+				   changes[i].second,
 				   trackChanges);
 			if (!eraseChar(erasePos, trackChanges)) {
 				++erasePos;
@@ -3550,20 +3799,28 @@ void Paragraph::locateWord(pos_type & from, pos_type & to,
 
 void Paragraph::collectWords()
 {
-	pos_type n = size();
-	for (pos_type pos = 0; pos < n; ++pos) {
+	for (pos_type pos = 0; pos < size(); ++pos) {
 		if (isWordSeparator(pos))
 			continue;
 		pos_type from = pos;
 		locateWord(from, pos, WHOLE_WORD);
-		if ((pos - from) >= (int)lyxrc.completion_minlength) {
-			docstring word = asString(from, pos, AS_STR_NONE);
-			FontList::const_iterator cit = d->fontlist_.fontIterator(pos);
-			if (cit == d->fontlist_.end())
-				return;
-			Language const * lang = cit->font().language();
-			d->words_[*lang].insert(word);
-		}
+		// Work around MSVC warning: The statement
+		// if (pos < from + lyxrc.completion_minlength)
+		// triggers a signed vs. unsigned warning.
+		// I don't know why this happens, it could be a MSVC bug, or
+		// related to LLP64 (windows) vs. LP64 (unix) programming
+		// model, or the C++ standard might be ambigous in the section
+		// defining the "usual arithmetic conversions". However, using
+		// a temporary variable is safe and works on all compilers.
+		pos_type const endpos = from + lyxrc.completion_minlength;
+		if (pos < endpos)
+			continue;
+		FontList::const_iterator cit = d->fontlist_.fontIterator(from);
+		if (cit == d->fontlist_.end())
+			return;
+		Language const * lang = cit->font().language();
+		docstring const word = asString(from, pos, AS_STR_NONE);
+		d->words_[lang->lang()].insert(word);
 	}
 }
 
@@ -3724,7 +3981,7 @@ SpellChecker::Result Paragraph::spellCheck(pos_type & from, pos_type & to,
 
 	wl = WordLangTuple(word, lang);
 
-	if (!word.size())
+	if (word.empty())
 		return result;
 
 	if (needsSpellCheck() || check_learned) {
@@ -3821,7 +4078,7 @@ void Paragraph::Private::markMisspelledWords(
 void Paragraph::spellCheck() const
 {
 	SpellChecker * speller = theSpellChecker();
-	if (!speller || !size() ||!needsSpellCheck())
+	if (!speller || empty() ||!needsSpellCheck())
 		return;
 	pos_type start;
 	pos_type endpos;