X-Git-Url: https://git.lyx.org/gitweb/?a=blobdiff_plain;f=src%2FBuffer.cpp;h=aa6d936aec8e6fa00b4c92a4e71c386280e21078;hb=94f0968e9212f24997cfee0d17c6f060210edbc6;hp=df5811c8f0abb1c8d0425a3e6f01f6a31244007c;hpb=f49cdf34201f3e0d23898259a2966bd9e38e6c53;p=lyx.git diff --git a/src/Buffer.cpp b/src/Buffer.cpp index df5811c8f0..aa6d936aec 100644 --- a/src/Buffer.cpp +++ b/src/Buffer.cpp @@ -126,9 +126,7 @@ namespace os = support::os; namespace { -// Do not remove the comment below, so we get merge conflict in -// independent branches. Instead add your own. -int const LYX_FORMAT = 413; // rgh: html_css_as_file +int const LYX_FORMAT = LYX_FORMAT_LYX; typedef map DepClean; typedef map > RefCache; @@ -358,6 +356,7 @@ Buffer::Impl::Impl(Buffer * owner, FileName const & file, bool readonly_, bibfile_cache_valid_ = cloned_buffer_->d->bibfile_cache_valid_; bibfile_status_ = cloned_buffer_->d->bibfile_status_; cite_labels_valid_ = cloned_buffer_->d->cite_labels_valid_; + unnamed = cloned_buffer_->d->unnamed; } @@ -401,7 +400,7 @@ Buffer::~Buffer() Impl::BufferPositionMap::iterator end = d->children_positions.end(); for (; it != end; ++it) { Buffer * child = const_cast(it->first); - if (d->cloned_buffer_) + if (isClone()) delete child; // The child buffer might have been closed already. else if (theBufferList().isLoaded(child)) @@ -713,10 +712,10 @@ int Buffer::readHeader(Lexer & lex) params().indiceslist().clear(); params().backgroundcolor = lyx::rgbFromHexName("#ffffff"); params().isbackgroundcolor = false; - params().fontcolor = lyx::rgbFromHexName("#000000"); + params().fontcolor = RGBColor(0, 0, 0); params().isfontcolor = false; - params().notefontcolor = lyx::rgbFromHexName("#cccccc"); - params().boxbgcolor = lyx::rgbFromHexName("#ff0000"); + params().notefontcolor = RGBColor(0xCC, 0xCC, 0xCC); + params().boxbgcolor = RGBColor(0xFF, 0, 0); params().html_latex_start.clear(); params().html_latex_end.clear(); params().html_math_img_scale = 1.0; @@ -954,7 +953,7 @@ void Buffer::setFullyLoaded(bool value) PreviewLoader * Buffer::loader() const { - if (lyxrc.preview == LyXRC::PREVIEW_OFF) + if (!isExporting() && lyxrc.preview == LyXRC::PREVIEW_OFF) return 0; if (!d->preview_loader_) d->preview_loader_ = new PreviewLoader(*this); @@ -1302,7 +1301,7 @@ bool Buffer::write(ostream & ofs) const bool Buffer::makeLaTeXFile(FileName const & fname, string const & original_path, OutputParams const & runparams_in, - bool output_preamble, bool output_body) const + OutputWhat output) const { OutputParams runparams = runparams_in; @@ -1312,7 +1311,7 @@ bool Buffer::makeLaTeXFile(FileName const & fname, runparams.encoding = encodings.fromLyXName("utf8-plain"); string const encoding = runparams.encoding->iconvName(); - LYXERR(Debug::LATEX, "makeLaTeXFile encoding: " << encoding << "..."); + LYXERR(Debug::LATEX, "makeLaTeXFile encoding: " << encoding << ", fname=" << fname.realPath()); ofdocstream ofs; try { ofs.reset(encoding); } @@ -1341,8 +1340,7 @@ bool Buffer::makeLaTeXFile(FileName const & fname, try { os.texrow().reset(); - writeLaTeXSource(os, original_path, - runparams, output_preamble, output_body); + writeLaTeXSource(os, original_path, runparams, output); } catch (EncodingException & e) { odocstringstream ods; @@ -1387,7 +1385,7 @@ bool Buffer::makeLaTeXFile(FileName const & fname, void Buffer::writeLaTeXSource(otexstream & os, string const & original_path, OutputParams const & runparams_in, - bool const output_preamble, bool const output_body) const + OutputWhat output) const { // The child documents, if any, shall be already loaded at this point. @@ -1402,6 +1400,11 @@ void Buffer::writeLaTeXSource(otexstream & os, validate(features); LYXERR(Debug::LATEX, " Buffer validation done."); + bool const output_preamble = + output == FullSource || output == OnlyPreamble; + bool const output_body = + output == FullSource || output == OnlyBody; + // The starting paragraph of the coming rows is the // first paragraph of the document. (Asger) if (output_preamble && runparams.nice) { @@ -1413,12 +1416,13 @@ void Buffer::writeLaTeXSource(otexstream & os, LYXERR(Debug::INFO, "lyx document header finished"); // There are a few differences between nice LaTeX and usual files: - // usual is \batchmode and has a - // special input@path to allow the including of figures - // with either \input or \includegraphics (what figinsets do). - // input@path is set when the actual parameter - // original_path is set. This is done for usual tex-file, but not - // for nice-latex-file. (Matthias 250696) + // usual files have \batchmode and special input@path to allow + // inclusion of figures specified by an explicitly relative path + // (i.e., a path starting with './' or '../') with either \input or + // \includegraphics, as the TEXINPUTS method doesn't work in this case. + // input@path is set when the actual parameter original_path is set. + // This is done for usual tex-file, but not for nice-latex-file. + // (Matthias 250696) // Note that input@path is only needed for something the user does // in the preamble, included .tex files or ERT, files included by // LyX work without it. @@ -1430,7 +1434,7 @@ void Buffer::writeLaTeXSource(otexstream & os, if (!original_path.empty()) { // FIXME UNICODE // We don't know the encoding of inputpath - docstring const inputpath = from_utf8(support::latex_path(original_path)); + docstring const inputpath = from_utf8(original_path); docstring uncodable_glyphs; Encoding const * const enc = runparams.encoding; if (enc) { @@ -1448,18 +1452,41 @@ void Buffer::writeLaTeXSource(otexstream & os, // warn user if we found uncodable glyphs. if (!uncodable_glyphs.empty()) { - frontend::Alert::warning(_("Uncodable character in file path"), - support::bformat(_("The path of your document\n" - "(%1$s)\n" - "contains glyphs that are unknown in the\n" - "current document encoding (namely %2$s).\n" - "This will likely result in incomplete output.\n\n" - "Choose an appropriate document encoding (such as utf8)\n" - "or change the file path name."), inputpath, uncodable_glyphs)); + frontend::Alert::warning( + _("Uncodable character in file path"), + support::bformat( + _("The path of your document\n" + "(%1$s)\n" + "contains glyphs that are unknown " + "in the current document encoding " + "(namely %2$s). This may result in " + "incomplete output, unless " + "TEXINPUTS contains the document " + "directory and you don't use " + "explicitly relative paths (i.e., " + "paths starting with './' or " + "'../') in the preamble or in ERT." + "\n\nIn case of problems, choose " + "an appropriate document encoding\n" + "(such as utf8) or change the " + "file path name."), + inputpath, uncodable_glyphs)); } else { + string docdir = + support::latex_path(original_path); + if (contains(docdir, '#')) { + docdir = subst(docdir, "#", "\\#"); + os << "\\catcode`\\#=11" + "\\def\\#{#}\\catcode`\\#=6\n"; + } + if (contains(docdir, '%')) { + docdir = subst(docdir, "%", "\\%"); + os << "\\catcode`\\%=11" + "\\def\\%{%}\\catcode`\\%=14\n"; + } os << "\\makeatletter\n" << "\\def\\input@path{{" - << inputpath << "/}}\n" + << docdir << "/}}\n" << "\\makeatother\n"; } } @@ -1539,7 +1566,7 @@ void Buffer::writeLaTeXSource(otexstream & os, void Buffer::makeDocBookFile(FileName const & fname, OutputParams const & runparams, - bool const body_only) const + OutputWhat output) const { LYXERR(Debug::LATEX, "makeDocBookFile..."); @@ -1552,7 +1579,7 @@ void Buffer::makeDocBookFile(FileName const & fname, updateBuffer(); updateMacroInstances(OutputUpdate); - writeDocBookSource(ofs, fname.absFileName(), runparams, body_only); + writeDocBookSource(ofs, fname.absFileName(), runparams, output); ofs.close(); if (ofs.fail()) @@ -1562,7 +1589,7 @@ void Buffer::makeDocBookFile(FileName const & fname, void Buffer::writeDocBookSource(odocstream & os, string const & fname, OutputParams const & runparams, - bool const only_body) const + OutputWhat output) const { LaTeXFeatures features(*this, params(), runparams); validate(features); @@ -1572,7 +1599,12 @@ void Buffer::writeDocBookSource(odocstream & os, string const & fname, DocumentClass const & tclass = params().documentClass(); string const top_element = tclass.latexname(); - if (!only_body) { + bool const output_preamble = + output == FullSource || output == OnlyPreamble; + bool const output_body = + output == FullSource || output == OnlyBody; + + if (output_preamble) { if (runparams.flavor == OutputParams::XML) os << "\n"; @@ -1607,29 +1639,31 @@ void Buffer::writeDocBookSource(odocstream & os, string const & fname, os << ">\n\n"; } - string top = top_element; - top += " lang=\""; - if (runparams.flavor == OutputParams::XML) - top += params().language->code(); - else - top += params().language->code().substr(0, 2); - top += '"'; - - if (!params().options.empty()) { - top += ' '; - top += params().options; + if (output_body) { + string top = top_element; + top += " lang=\""; + if (runparams.flavor == OutputParams::XML) + top += params().language->code(); + else + top += params().language->code().substr(0, 2); + top += '"'; + + if (!params().options.empty()) { + top += ' '; + top += params().options; + } + + os << "\n"; + + params().documentClass().counters().reset(); + + sgml::openTag(os, top); + os << '\n'; + docbookParagraphs(text(), *this, os, runparams); + sgml::closeTag(os, top_element); } - - os << "\n"; - - params().documentClass().counters().reset(); - - sgml::openTag(os, top); - os << '\n'; - docbookParagraphs(text(), *this, os, runparams); - sgml::closeTag(os, top_element); } @@ -1647,7 +1681,7 @@ void Buffer::makeLyXHTMLFile(FileName const & fname, updateBuffer(UpdateMaster, OutputUpdate); updateMacroInstances(OutputUpdate); - writeLyXHTMLSource(ofs, runparams); + writeLyXHTMLSource(ofs, runparams, FullSource); ofs.close(); if (ofs.fail()) @@ -1657,13 +1691,18 @@ void Buffer::makeLyXHTMLFile(FileName const & fname, void Buffer::writeLyXHTMLSource(odocstream & os, OutputParams const & runparams, - bool const only_body) const + OutputWhat output) const { LaTeXFeatures features(*this, params(), runparams); validate(features); d->bibinfo_.makeCitationLabels(*this); - if (!only_body) { + bool const output_preamble = + output == FullSource || output == OnlyPreamble; + bool const output_body = + output == FullSource || output == OnlyBody; + + if (output_preamble) { os << "\n" << "\n" // FIXME Language should be set properly. @@ -1675,7 +1714,9 @@ void Buffer::writeLyXHTMLSource(odocstream & os, docstring const & doctitle = features.htmlTitle(); os << "" - << (doctitle.empty() ? from_ascii("LyX Document") : doctitle) + << (doctitle.empty() ? + from_ascii("LyX Document") : + html::htmlize(doctitle, XHTMLStream::ESCAPE_ALL)) << "\n"; os << "\n\n" @@ -1690,14 +1731,34 @@ void Buffer::writeLyXHTMLSource(odocstream & os, << styleinfo << "\n"; } - os << "\n\n"; + + bool const needfg = params().fontcolor != RGBColor(0, 0, 0); + bool const needbg = params().backgroundcolor != RGBColor(0xFF, 0xFF, 0xFF); + if (needfg || needbg) { + os << "\n"; + } + os << "\n"; + } + + if (output_body) { + os << "\n"; + XHTMLStream xs(os); + params().documentClass().counters().reset(); + xhtmlParagraphs(text(), *this, xs, runparams); + os << "\n"; } - XHTMLStream xs(os); - params().documentClass().counters().reset(); - xhtmlParagraphs(text(), *this, xs, runparams); - if (!only_body) - os << "\n\n"; + if (output_preamble) + os << "\n"; } @@ -1977,7 +2038,15 @@ bool Buffer::getStatus(FuncRequest const & cmd, FuncStatus & flag) case LFUN_BUFFER_EXPORT: { docstring const arg = cmd.argument(); - enable = arg == "custom" || params().isExportable(to_utf8(arg)); + if (arg == "custom") { + enable = true; + break; + } + string format = to_utf8(arg); + size_t pos = format.find(' '); + if (pos != string::npos) + format = format.substr(0, pos); + enable = params().isExportable(format); if (!enable) flag.message(bformat( _("Don't know how to export to format: %1$s"), arg)); @@ -2049,16 +2118,16 @@ void Buffer::dispatch(FuncRequest const & func, DispatchResult & dr) break; case LFUN_BUFFER_EXPORT: { - bool success = doExport(argument, false, false); - dr.setError(!success); - if (!success) + ExportStatus const status = doExport(argument, false); + dr.setError(status != ExportSuccess); + if (status != ExportSuccess) dr.setMessage(bformat(_("Error exporting to format: %1$s."), func.argument())); break; } case LFUN_BUILD_PROGRAM: - doExport("program", true, false); + doExport("program", true); break; case LFUN_BUFFER_CHKTEX: @@ -2090,7 +2159,7 @@ void Buffer::dispatch(FuncRequest const & func, DispatchResult & dr) break; } else { - doExport(format_name, true, false, filename); + doExport(format_name, true, filename); } // Substitute $$FName for filename @@ -2237,10 +2306,7 @@ void Buffer::dispatch(FuncRequest const & func, DispatchResult & dr) break; } - bool const update_unincluded = - params().maintain_unincluded_children - && !params().getIncludedChildren().empty(); - if (!doExport("dvi", true, update_unincluded)) { + if (!doExport("dvi", true)) { showPrintError(absFileName()); dr.setMessage(_("Error exporting to DVI.")); break; @@ -2333,18 +2399,6 @@ void Buffer::dispatch(FuncRequest const & func, DispatchResult & dr) break; } - case LFUN_BUFFER_LANGUAGE: { - Language const * oldL = params().language; - Language const * newL = languages.getLanguage(argument); - if (!newL || oldL == newL) - break; - if (oldL->rightToLeft() == newL->rightToLeft() && !isMultiLingual()) { - changeLanguage(oldL, newL); - dr.forceBufferUpdate(); - } - break; - } - default: dispatched = false; break; @@ -3134,7 +3188,7 @@ void Buffer::changeRefsIfUnique(docstring const & from, docstring const & to, void Buffer::getSourceCode(odocstream & os, string const format, pit_type par_begin, pit_type par_end, - bool full_source) const + OutputWhat output) const { OutputParams runparams(¶ms().encoding()); runparams.nice = true; @@ -3143,21 +3197,7 @@ void Buffer::getSourceCode(odocstream & os, string const format, // No side effect of file copying and image conversion runparams.dryrun = true; - if (full_source) { - os << "% " << _("Preview source code") << "\n\n"; - d->texrow.reset(); - d->texrow.newline(); - d->texrow.newline(); - if (params().isDocBook()) - writeDocBookSource(os, absFileName(), runparams, false); - else if (runparams.flavor == OutputParams::HTML) - writeLyXHTMLSource(os, runparams, false); - else { - // latex or literate - otexstream ots(os, d->texrow); - writeLaTeXSource(ots, string(), runparams, true, true); - } - } else { + if (output == CurrentParagraph) { runparams.par_begin = par_begin; runparams.par_end = par_end; if (par_begin + 1 == par_end) { @@ -3186,6 +3226,27 @@ void Buffer::getSourceCode(odocstream & os, string const format, otexstream ots(os, texrow); latexParagraphs(*this, text(), ots, runparams); } + } else { + os << "% "; + if (output == FullSource) + os << _("Preview source code"); + else if (output == OnlyPreamble) + os << _("Preview preamble"); + else if (output == OnlyBody) + os << _("Preview body"); + os << "\n\n"; + d->texrow.reset(); + d->texrow.newline(); + d->texrow.newline(); + if (params().isDocBook()) + writeDocBookSource(os, absFileName(), runparams, output); + else if (runparams.flavor == OutputParams::HTML) + writeLyXHTMLSource(os, runparams, output); + else { + // latex or literate + otexstream ots(os, d->texrow); + writeLaTeXSource(ots, string(), runparams, output); + } } } @@ -3416,23 +3477,22 @@ bool Buffer::autoSave() const } -namespace { - // helper class, to guarantee this gets reset properly - class MarkAsExporting { - public: - MarkAsExporting(Buffer const * buf) : buf_(buf) - { - LASSERT(buf_, /* */); - buf_->setExportStatus(true); - } - ~MarkAsExporting() - { - buf_->setExportStatus(false); - } - private: - Buffer const * const buf_; - }; -} +// helper class, to guarantee this gets reset properly +class Buffer::MarkAsExporting { +public: + MarkAsExporting(Buffer const * buf) : buf_(buf) + { + LASSERT(buf_, /* */); + buf_->setExportStatus(true); + } + ~MarkAsExporting() + { + buf_->setExportStatus(false); + } +private: + Buffer const * const buf_; +}; + void Buffer::setExportStatus(bool e) const @@ -3452,12 +3512,49 @@ bool Buffer::isExporting() const } -bool Buffer::doExport(string const & format, bool put_in_tempdir, +Buffer::ExportStatus Buffer::doExport(string const & target, bool put_in_tempdir) + const +{ + string result_file; + return doExport(target, put_in_tempdir, result_file); +} + +Buffer::ExportStatus Buffer::doExport(string const & target, bool put_in_tempdir, + string & result_file) const +{ + bool const update_unincluded = + params().maintain_unincluded_children + && !params().getIncludedChildren().empty(); + + // (1) export with all included children (omit \includeonly) + if (update_unincluded) { + ExportStatus const status = + doExport(target, put_in_tempdir, true, result_file); + if (status != ExportSuccess) + return status; + } + // (2) export with included children only + return doExport(target, put_in_tempdir, false, result_file); +} + + +Buffer::ExportStatus Buffer::doExport(string const & target, bool put_in_tempdir, bool includeall, string & result_file) const { + LYXERR(Debug::FILES, "target=" << target); + OutputParams runparams(¶ms().encoding()); + string format = target; + string dest_filename; + size_t pos = target.find(' '); + if (pos != string::npos) { + dest_filename = target.substr(pos + 1, target.length() - pos - 1); + format = target.substr(0, pos); + runparams.export_folder = FileName(dest_filename).onlyPath().realPath(); + FileName(dest_filename).onlyPath().createPath(); + LYXERR(Debug::FILES, "format=" << format << ", dest_filename=" << dest_filename << ", export_folder=" << runparams.export_folder); + } MarkAsExporting exporting(this); string backend_format; - OutputParams runparams(¶ms().encoding()); runparams.flavor = OutputParams::LATEX; runparams.linelen = lyxrc.plaintext_linelen; runparams.includeall = includeall; @@ -3483,17 +3580,20 @@ bool Buffer::doExport(string const & format, bool put_in_tempdir, _("No information for exporting the format %1$s."), formats.prettyName(format))); } - return false; + return ExportNoPathToFormat; } runparams.flavor = converters.getFlavor(path); } else { backend_format = format; + LYXERR(Debug::FILES, "backend_format=" << backend_format); // FIXME: Don't hardcode format names here, but use a flag if (backend_format == "pdflatex") runparams.flavor = OutputParams::PDFLATEX; else if (backend_format == "luatex") runparams.flavor = OutputParams::LUATEX; + else if (backend_format == "dviluatex") + runparams.flavor = OutputParams::DVILUATEX; else if (backend_format == "xetex") runparams.flavor = OutputParams::XETEX; } @@ -3502,6 +3602,7 @@ bool Buffer::doExport(string const & format, bool put_in_tempdir, filename = addName(temppath(), filename); filename = changeExtension(filename, formats.extension(backend_format)); + LYXERR(Debug::FILES, "filename=" << filename); // Plain text backend if (backend_format == "text") { @@ -3541,13 +3642,13 @@ bool Buffer::doExport(string const & format, bool put_in_tempdir, d->cloned_buffer_->d->errorLists["Export"] = d->errorLists["Export"]; } - return false; + return ExportError; } } else if (!lyxrc.tex_allows_spaces && contains(filePath(), ' ')) { Alert::error(_("File name error"), _("The directory path to the document cannot contain spaces.")); - return false; + return ExportTexPathHasSpaces; } else { runparams.nice = false; if (!makeLaTeXFile(FileName(filename), filePath(), runparams)) { @@ -3555,7 +3656,7 @@ bool Buffer::doExport(string const & format, bool put_in_tempdir, d->cloned_buffer_->d->errorLists["Export"] = d->errorLists["Export"]; } - return false; + return ExportError; } } @@ -3604,19 +3705,23 @@ bool Buffer::doExport(string const & format, bool put_in_tempdir, } if (!success) - return false; + return ExportConverterError; if (put_in_tempdir) { result_file = tmp_result_file.absFileName(); - return true; + return ExportSuccess; } - result_file = changeExtension(d->exportFileName().absFileName(), ext); + if (dest_filename.empty()) + result_file = changeExtension(d->exportFileName().absFileName(), ext); + else + result_file = dest_filename; // We need to copy referenced files (e. g. included graphics // if format == "dvi") to the result dir. vector const files = runparams.exportdata->externalFiles(format); - string const dest = onlyPath(result_file); + string const dest = runparams.export_folder.empty() ? + onlyPath(result_file) : runparams.export_folder; bool use_force = use_gui ? lyxrc.export_overwrite == ALL_FILES : force_overwrite == ALL_FILES; CopyStatus status = use_force ? FORCE : SUCCESS; @@ -3625,14 +3730,27 @@ bool Buffer::doExport(string const & format, bool put_in_tempdir, vector::const_iterator const en = files.end(); for (; it != en && status != CANCEL; ++it) { string const fmt = formats.getFormatFromFile(it->sourceName); + string fixedName = it->exportName; + if (!runparams.export_folder.empty()) { + // Relative pathnames starting with ../ will be sanitized + // if exporting to a different folder + while (fixedName.substr(0, 3) == "../") + fixedName = fixedName.substr(3, fixedName.length() - 3); + } + FileName fixedFileName = makeAbsPath(fixedName, dest); + fixedFileName.onlyPath().createPath(); status = copyFile(fmt, it->sourceName, - makeAbsPath(it->exportName, dest), - it->exportName, status == FORCE); + fixedFileName, + it->exportName, status == FORCE, + runparams.export_folder.empty()); } if (status == CANCEL) { message(_("Document export cancelled.")); - } else if (tmp_result_file.exists()) { + return ExportCancel; + } + + if (tmp_result_file.exists()) { // Finally copy the main file use_force = use_gui ? lyxrc.export_overwrite != NO_FILES : force_overwrite != NO_FILES; @@ -3641,43 +3759,50 @@ bool Buffer::doExport(string const & format, bool put_in_tempdir, status = copyFile(format, tmp_result_file, FileName(result_file), result_file, status == FORCE); - message(bformat(_("Document exported as %1$s " - "to file `%2$s'"), - formats.prettyName(format), - makeDisplayPath(result_file))); + if (status == CANCEL) { + message(_("Document export cancelled.")); + return ExportCancel; + } else { + message(bformat(_("Document exported as %1$s " + "to file `%2$s'"), + formats.prettyName(format), + makeDisplayPath(result_file))); + } } else { // This must be a dummy converter like fax (bug 1888) message(bformat(_("Document exported as %1$s"), formats.prettyName(format))); } - return true; + return ExportSuccess; } -bool Buffer::doExport(string const & format, bool put_in_tempdir, - bool includeall) const +Buffer::ExportStatus Buffer::preview(string const & format) const { - string result_file; - // (1) export with all included children (omit \includeonly) - if (includeall && !doExport(format, put_in_tempdir, true, result_file)) - return false; - // (2) export with included children only - return doExport(format, put_in_tempdir, false, result_file); + bool const update_unincluded = + params().maintain_unincluded_children + && !params().getIncludedChildren().empty(); + return preview(format, update_unincluded); } - -bool Buffer::preview(string const & format, bool includeall) const +Buffer::ExportStatus Buffer::preview(string const & format, bool includeall) const { MarkAsExporting exporting(this); string result_file; // (1) export with all included children (omit \includeonly) - if (includeall && !doExport(format, true, true)) - return false; + if (includeall) { + ExportStatus const status = doExport(format, true, true, result_file); + if (status != ExportSuccess) + return status; + } // (2) export with included children only - if (!doExport(format, true, false, result_file)) - return false; - return formats.view(*this, FileName(result_file), format); + ExportStatus const status = doExport(format, true, false, result_file); + if (status != ExportSuccess) + return status; + if (!formats.view(*this, FileName(result_file), format)) + return PreviewError; + return PreviewSuccess; } @@ -4192,8 +4317,9 @@ int Buffer::spellCheck(DocIterator & from, DocIterator & to, WordLangTuple wl; suggestions.clear(); word_lang = WordLangTuple(); + bool const to_end = to.empty(); + DocIterator const end = to_end ? doc_iterator_end(this) : to; // OK, we start from here. - DocIterator const end = doc_iterator_end(this); for (; from != end; from.forwardPos()) { // We are only interested in text so remove the math CursorSlice. while (from.inMathed()) { @@ -4201,8 +4327,8 @@ int Buffer::spellCheck(DocIterator & from, DocIterator & to, from.pos()++; } // If from is at the end of the document (which is possible - // when leaving the mathed) LyX will crash later. - if (from == end) + // when leaving the mathed) LyX will crash later otherwise. + if (from.atEnd() || (!to_end && from >= end)) break; to = from; from.paragraph().spellCheck();