]> git.lyx.org Git - lyx.git/blobdiff - src/text3.C
prevent crash when inserting minipage in table cell,
[lyx.git] / src / text3.C
index 7ed8bedbb1748e21c96b8c53cfbfea617e4f8fbb..a468a7289665a3590980354f8cc5dc346177fa62 100644 (file)
 #include "BufferView.h"
 #include "funcrequest.h"
 #include "lyxrc.h"
+#include "Lsstream.h"
 #include "debug.h"
 #include "bufferparams.h"
 #include "buffer.h"
+#include "bufferview_funcs.h"
 #include "ParagraphParameters.h"
 #include "gettext.h"
+#include "factory.h"
 #include "intl.h"
+#include "box.h"
+#include "language.h"
+#include "support/tostr.h"
 #include "support/lstrings.h"
+#include "support/LAssert.h"
 #include "frontends/LyXView.h"
-#include "frontends/WorkArea.h"
+#include "frontends/screen.h"
+#include "frontends/Dialogs.h"
 #include "insets/insetspecialchar.h"
 #include "insets/insettext.h"
+#include "insets/insetquotes.h"
+#include "insets/insetcommand.h"
+#include "insets/insetnewline.h"
+#include "undo_funcs.h"
+#include "text_funcs.h"
+#include "Lsstream.h"
 
+#include <ctime>
+#include <clocale>
+
+using namespace lyx::support;
+using namespace bv_funcs;
+
+using std::endl;
+using std::find;
+using std::vector;
+using lyx::pos_type;
 
 extern string current_layout;
+extern int bibitemMaxWidth(BufferView *, LyXFont const &);
+
+// the selection possible is needed, that only motion events are
+// used, where the bottom press event was on the drawing area too
+bool selection_possible = false;
+
+
+namespace {
+
+       void moveCursorUpdate(BufferView * bv, bool selecting)
+       {
+               LyXText * lt = bv->getLyXText();
+
+               if (selecting || lt->selection.mark()) {
+                       lt->setSelection();
+                       if (lt->isInInset())
+                               bv->updateInset(lt->inset_owner);
+                       else
+                               bv->repaint();
+               }
+               if (!lt->isInInset()) {
+                       bv->update(lt, BufferView::SELECT);
+               } else if (bv->text->needRefresh()) {
+                       bv->update(BufferView::SELECT);
+               }
+
+               if (!lt->selection.set())
+                       bv->haveSelection(false);
+
+               bv->switchKeyMap();
+       }
+
+
+       void finishChange(BufferView * bv, bool selecting = false)
+       {
+               finishUndo();
+               moveCursorUpdate(bv, selecting);
+               bv->owner()->view_state_changed();
+       }
+
+       // check if the given co-ordinates are inside an inset at the
+       // given cursor, if one exists. If so, the inset is returned,
+       // and the co-ordinates are made relative. Otherwise, 0 is returned.
+InsetOld * checkInset(BufferView * /*bv*/, LyXText & text,
+               LyXCursor const & cur, int & x, int & y)
+       {
+               lyx::pos_type const pos = cur.pos();
+               ParagraphList::iterator par = cur.par();
+
+               if (pos >= par->size() || !par->isInset(pos))
+                       return 0;
+
+               InsetOld /*const*/ * inset = par->getInset(pos);
+
+               if (!isEditableInset(inset))
+                       return 0;
+
+               // get inset dimensions
+               Assert(par->getInset(pos));
+
+               LyXFont const & font = text.getFont(par, pos);
+
+               int const width = inset->width();
+               int const inset_x = font.isVisibleRightToLeft()
+                       ? (cur.ix() - width) : cur.ix();
+
+               Box b(
+                       inset_x + inset->scroll(),
+                       inset_x + width,
+                       cur.iy() - inset->ascent(),
+                       cur.iy() + inset->descent()
+               );
+
+               if (!b.contained(x, y)) {
+                       lyxerr[Debug::GUI] << "Missed inset at x,y "
+                                          << x << ',' << y
+                                          << " box " << b << endl;
+                       return 0;
+               }
+
+               text.setCursor(par, pos, true);
+
+               x -= b.x1;
+               // The origin of an inset is on the baseline
+               y -= text.cursor.iy();
+
+               return inset;
+       }
 
+} // anon namespace
 
-void LyXText::update(BufferView * bv, bool changed)
+
+InsetOld * LyXText::checkInsetHit(int & x, int & y)
 {
-       BufferView::UpdateCodes c = BufferView::SELECT | BufferView::FITCUR;
-       if (changed)
-               bv->update(this, c | BufferView::CHANGE);
-       else
-               bv->update(this, c);
+       int y_tmp = y + top_y();
+
+       LyXCursor cur;
+       setCursorFromCoordinates(cur, x, y_tmp);
+
+       InsetOld * inset = checkInset(bv(), *this, cur, x, y_tmp);
+       if (inset) {
+               y = y_tmp;
+               return inset;
+       }
+
+       // look at previous position
+       if (cur.pos() == 0)
+               return 0;
+
+       // move back one
+       setCursor(cur, cur.par(), cur.pos() - 1, true);
+
+       inset = checkInset(bv(), *this, cur, x, y_tmp);
+       if (inset)
+               y = y_tmp;
+       return inset;
 }
 
 
+bool LyXText::gotoNextInset(vector<InsetOld::Code> const & codes,
+                           string const & contents)
+{
+       ParagraphList::iterator end = ownerParagraphs().end();
+       ParagraphList::iterator pit = cursor.par();
+       pos_type pos = cursor.pos();
+
+       InsetOld * inset;
+       do {
+               if (pos + 1 < pit->size()) {
+                       ++pos;
+               } else  {
+                       ++pit;
+                       pos = 0;
+               }
+
+       } while (pit != end &&
+                !(pit->isInset(pos) &&
+                  (inset = pit->getInset(pos)) != 0 &&
+                  find(codes.begin(), codes.end(), inset->lyxCode()) != codes.end() &&
+                  (contents.empty() ||
+                   static_cast<InsetCommand *>(pit->getInset(pos))->getContents()
+                   == contents)));
+
+       if (pit != end) {
+               setCursor(pit, pos, false);
+               return true;
+       }
+       return false;
+}
+
+
+void LyXText::gotoInset(vector<InsetOld::Code> const & codes,
+                       bool same_content)
+{
+       bv()->beforeChange(this);
+       update();
+
+       string contents;
+       if (same_content && cursor.pos() < cursor.par()->size()
+           && cursor.par()->isInset(cursor.pos())) {
+               InsetOld const * inset = cursor.par()->getInset(cursor.pos());
+               if (find(codes.begin(), codes.end(), inset->lyxCode())
+                   != codes.end())
+                       contents = static_cast<InsetCommand const *>(inset)->getContents();
+       }
+
+       if (!gotoNextInset(codes, contents)) {
+               if (cursor.pos() || cursor.par() != ownerParagraphs().begin()) {
+                       LyXCursor tmp = cursor;
+                       cursor.par(ownerParagraphs().begin());
+                       cursor.pos(0);
+                       if (!gotoNextInset(codes, contents)) {
+                               cursor = tmp;
+                               bv()->owner()->message(_("No more insets"));
+                       }
+               } else {
+                       bv()->owner()->message(_("No more insets"));
+               }
+       }
+       update();
+       selection.cursor = cursor;
+}
+
+
+void LyXText::gotoInset(InsetOld::Code code, bool same_content)
+{
+       gotoInset(vector<InsetOld::Code>(1, code), same_content);
+}
+
+
+void LyXText::cursorPrevious()
+{
+       int y = top_y();
+
+       if (cursorRow() == rows().begin()) {
+               if (y > 0)
+                       bv()->updateScrollbar();
+               return;
+       }
+
+       RowList::iterator cursorrow = cursorRow();
+
+       setCursorFromCoordinates(cursor.x_fix(), y);
+       finishUndo();
+
+       int new_y;
+       if (cursorrow == bv()->text->cursorRow()) {
+               // we have a row which is taller than the workarea. The
+               // simplest solution is to move to the previous row instead.
+               cursorUp(true);
+               return;
+               // This is what we used to do, so we wouldn't skip right past
+               // tall rows, but it's not working right now.
+       } else {
+               if (inset_owner) {
+                       new_y = bv()->text->cursor.iy()
+                               + bv()->theLockingInset()->insetInInsetY() + y
+                               + cursorRow()->height()
+                               - bv()->workHeight() + 1;
+               } else {
+                       new_y = cursor.y()
+                               - cursorRow()->baseline()
+                               + cursorRow()->height()
+                               - bv()->workHeight() + 1;
+               }
+       }
+       //bv()->screen().draw(bv()->text, bv(), new_y < 0 ? 0 : new_y);
+       if (cursorRow() != rows().begin()) {
+               LyXCursor cur;
+               setCursor(cur, boost::prior(cursorRow())->par(),
+                         boost::prior(cursorRow())->pos(), false);
+               if (cur.y() > top_y()) {
+                       cursorUp(true);
+               }
+       }
+       bv()->updateScrollbar();
+}
+
+
+void LyXText::cursorNext()
+{
+       int topy = top_y();
+
+       if (boost::next(cursorRow()) == rows().end()) {
+               int y = cursor.y() - cursorRow()->baseline() +
+                       cursorRow()->height();
+               if (y > topy + bv()->workHeight()) {
+                       //bv()->screen().draw(bv()->text, bv(), bv()->text->top_y() + bv()->workHeight());
+                       bv()->updateScrollbar();
+               }
+               return;
+       }
+
+       int y = topy + bv()->workHeight();
+       if (inset_owner && !topy) {
+               y -= (bv()->text->cursor.iy()
+                         - bv()->text->top_y()
+                         + bv()->theLockingInset()->insetInInsetY());
+       }
+
+       getRowNearY(y);
+
+       RowList::iterator cursorrow = cursorRow();
+       setCursorFromCoordinates(cursor.x_fix(), y);
+       // + bv->workHeight());
+       finishUndo();
+
+       int new_y;
+       if (cursorrow == bv()->text->cursorRow()) {
+               // we have a row which is taller than the workarea. The
+               // simplest solution is to move to the next row instead.
+               cursorDown(true);
+               return;
+               // This is what we used to do, so we wouldn't skip right past
+               // tall rows, but it's not working right now.
+#if 0
+               new_y = bv->text->top_y() + bv->workHeight();
+#endif
+       } else {
+               if (inset_owner) {
+                       new_y = bv()->text->cursor.iy()
+                               + bv()->theLockingInset()->insetInInsetY()
+                               + y - cursorRow()->baseline();
+               } else {
+                       new_y =  cursor.y() - cursorRow()->baseline();
+               }
+       }
+       //bv()->screen().draw(bv()->text, bv(), new_y);
+
+       RowList::iterator next_row = boost::next(cursorRow());
+       if (next_row != rows().end()) {
+               LyXCursor cur;
+               setCursor(cur, next_row->par(), next_row->pos(), false);
+               if (cur.y() < top_y() + bv()->workHeight()) {
+                       cursorDown(true);
+               }
+       }
+       bv()->updateScrollbar();
+}
+
+
+void LyXText::update()
+{
+       bv()->update(this, BufferView::SELECT);
+}
+
+namespace {
+
 void specialChar(LyXText * lt, BufferView * bv, InsetSpecialChar::Kind kind)
 {
-       bv->hideCursor();
-       lt->update(bv);
+       lt->update();
        InsetSpecialChar * new_inset = new InsetSpecialChar(kind);
+       replaceSelection(lt);
        if (!bv->insertInset(new_inset))
                delete new_inset;
        else
-               bv->updateInset(new_inset, true);
+               bv->updateInset(new_inset);
 }
 
 
-Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
+void doInsertInset(LyXText * lt, FuncRequest const & cmd,
+                  bool edit, bool pastesel)
 {
+       InsetOld * inset = createInset(cmd);
+       BufferView * bv = cmd.view();
+
+       if (inset) {
+               bool gotsel = false;
+               if (lt->selection.set()) {
+                       bv->owner()->dispatch(FuncRequest(LFUN_CUT));
+                       gotsel = true;
+               }
+               if (bv->insertInset(inset)) {
+                       if (edit) {
+                               FuncRequest cmd(bv, LFUN_INSET_EDIT, "left");
+                               inset->localDispatch(cmd);
+                       }
+                       if (gotsel && pastesel)
+                               bv->owner()->dispatch(FuncRequest(LFUN_PASTE));
+               }
+               else
+                       delete inset;
+       }
+}
+
+}
+
+InsetOld::RESULT LyXText::dispatch(FuncRequest const & cmd)
+{
+       lyxerr[Debug::ACTION] << "LyXFunc::dispatch: action[" << cmd.action
+                             <<"] arg[" << cmd.argument << ']' << endl;
+
        BufferView * bv = cmd.view();
 
        switch (cmd.action) {
 
        case LFUN_APPENDIX: {
-               Paragraph * par = cursor.par();
-               bool start = !par->params().startOfAppendix();
+               ParagraphList::iterator pit = cursor.par();
+               bool start = !pit->params().startOfAppendix();
 
                // ensure that we have only one start_of_appendix in this document
-               Paragraph * tmp = ownerParagraph();
-               for (; tmp; tmp = tmp->next())
-                       tmp->params().startOfAppendix(false);
+               ParagraphList::iterator tmp = ownerParagraphs().begin();
+               ParagraphList::iterator end = ownerParagraphs().end();
+
+               for (; tmp != end; ++tmp) {
+                       if (tmp->params().startOfAppendix()) {
+                               recordUndo(bv, Undo::ATOMIC, tmp);
+                               tmp->params().startOfAppendix(false);
+                               int tmpy;
+                               setHeightOfRow(getRow(tmp, 0, tmpy));
+                               break;
+                       }
+               }
 
-               par->params().startOfAppendix(start);
+               recordUndo(bv, Undo::ATOMIC, pit);
+               pit->params().startOfAppendix(start);
 
                // we can set the refreshing parameters now
-               status(cmd.view(), LyXText::NEED_MORE_REFRESH);
-               refresh_y = 0;
-               refresh_row = 0; // not needed for full update
-               updateCounters(cmd.view());
-               setCursor(cmd.view(), cursor.par(), cursor.pos());
-               update(bv);
+               updateCounters();
+               redoHeightOfParagraph();
+               postPaint();
+               setCursor(cursor.par(), cursor.pos());
+               update();
                break;
        }
 
        case LFUN_DELETE_WORD_FORWARD:
                bv->beforeChange(this);
-               update(bv, false);
-               deleteWordForward(bv);
-               update(bv);
-               bv->finishChange();
+               update();
+               deleteWordForward();
+               update();
+               finishChange(bv);
                break;
 
        case LFUN_DELETE_WORD_BACKWARD:
                bv->beforeChange(this);
-               update(bv, false);
-               deleteWordBackward(bv);
-               update(bv, true);
-               bv->finishChange();
+               update();
+               deleteWordBackward();
+               update();
+               finishChange(bv);
                break;
 
        case LFUN_DELETE_LINE_FORWARD:
                bv->beforeChange(this);
-               update(bv, false);
-               deleteLineForward(bv);
-               update(bv);
-               bv->finishChange();
-               break;
-
-       case LFUN_SHIFT_TAB:
-       case LFUN_TAB:
-               if (!selection.mark())
-                       bv->beforeChange(this);
-               update(bv, false);
-               cursorTab(bv);
-               bv->finishChange();
+               update();
+               deleteLineForward();
+               update();
+               finishChange(bv);
                break;
 
-       case LFUN_WORDRIGHT: 
+       case LFUN_WORDRIGHT:
                if (!selection.mark())
                        bv->beforeChange(this);
-               update(bv, false);
+               update();
                if (cursor.par()->isRightToLeftPar(bv->buffer()->params))
-                       cursorLeftOneWord(bv);
+                       cursorLeftOneWord();
                else
-                       cursorRightOneWord(bv);
-               bv->finishChange();
+                       cursorRightOneWord();
+               finishChange(bv);
                break;
 
        case LFUN_WORDLEFT:
                if (!selection.mark())
                        bv->beforeChange(this);
-               update(bv, false);
+               update();
                if (cursor.par()->isRightToLeftPar(bv->buffer()->params))
-                       cursorRightOneWord(bv);
+                       cursorRightOneWord();
                else
-                       cursorLeftOneWord(bv);
-               bv->finishChange();
+                       cursorLeftOneWord();
+               finishChange(bv);
                break;
 
        case LFUN_BEGINNINGBUF:
                if (!selection.mark())
                        bv->beforeChange(this);
-               update(bv, false);
-               cursorTop(bv);
-               bv->finishChange();
+               update();
+               cursorTop();
+               finishChange(bv);
                break;
 
        case LFUN_ENDBUF:
                if (selection.mark())
                        bv->beforeChange(this);
-               update(bv, false);
-               cursorBottom(bv);
-               bv->finishChange();
+               update();
+               cursorBottom();
+               finishChange(bv);
                break;
 
        case LFUN_RIGHTSEL:
-               update(bv, false);
+               update();
                if (cursor.par()->isRightToLeftPar(bv->buffer()->params))
                        cursorLeft(bv);
                else
                        cursorRight(bv);
-               bv->finishChange(true);
+               finishChange(bv, true);
                break;
 
        case LFUN_LEFTSEL:
-               update(bv, false);
+               update();
                if (cursor.par()->isRightToLeftPar(bv->buffer()->params))
                        cursorRight(bv);
                else
                        cursorLeft(bv);
-               bv->finishChange(true);
+               finishChange(bv, true);
                break;
 
        case LFUN_UPSEL:
-               update(bv, false);
-               cursorUp(bv, true);
-               bv->finishChange(true);
+               update();
+               cursorUp(true);
+               finishChange(bv, true);
                break;
 
        case LFUN_DOWNSEL:
-               update(bv, false);
-               cursorDown(bv, true);
-               bv->finishChange(true);
+               update();
+               cursorDown(true);
+               finishChange(bv, true);
                break;
 
        case LFUN_UP_PARAGRAPHSEL:
-               update(bv, false);
-               cursorUpParagraph(bv);
-               bv->finishChange(true);
+               update();
+               cursorUpParagraph();
+               finishChange(bv, true);
                break;
 
        case LFUN_DOWN_PARAGRAPHSEL:
-               update(bv, false);
-               cursorDownParagraph(bv);
-               bv->finishChange(true);
+               update();
+               cursorDownParagraph();
+               finishChange(bv, true);
                break;
 
        case LFUN_PRIORSEL:
-               update(bv, false);
-               bv->cursorPrevious(this);
-               bv->finishChange(true);
+               update();
+               cursorPrevious();
+               finishChange(bv, true);
                break;
 
        case LFUN_NEXTSEL:
-               update(bv, false);
-               bv->cursorNext(this);
-               bv->finishChange();
+               update();
+               cursorNext();
+               finishChange(bv, true);
                break;
 
        case LFUN_HOMESEL:
-               update(bv, false);
-               cursorHome(bv);
-               bv->finishChange(true);
+               update();
+               cursorHome();
+               finishChange(bv, true);
                break;
 
        case LFUN_ENDSEL:
-               update(bv, false);
-               cursorEnd(bv);
-               bv->finishChange(true);
+               update();
+               cursorEnd();
+               finishChange(bv, true);
                break;
 
        case LFUN_WORDRIGHTSEL:
-               update(bv, false);
+               update();
                if (cursor.par()->isRightToLeftPar(bv->buffer()->params))
-                       cursorLeftOneWord(bv);
+                       cursorLeftOneWord();
                else
-                       cursorRightOneWord(bv);
-               bv->finishChange(true);
+                       cursorRightOneWord();
+               finishChange(bv, true);
                break;
 
        case LFUN_WORDLEFTSEL:
-               update(bv, false);
+               update();
                if (cursor.par()->isRightToLeftPar(bv->buffer()->params))
-                       cursorRightOneWord(bv);
+                       cursorRightOneWord();
                else
-                       cursorLeftOneWord(bv);
-               bv->finishChange(true);
+                       cursorLeftOneWord();
+               finishChange(bv, true);
+               break;
+
+       case LFUN_WORDSEL: {
+               update();
+               LyXCursor cur1 = cursor;
+               LyXCursor cur2;
+               ::getWord(cur1, cur2, lyx::WHOLE_WORD, ownerParagraphs());
+               setCursor(cur1.par(), cur1.pos());
+               bv->beforeChange(this);
+               setCursor(cur2.par(), cur2.pos());
+               finishChange(bv, true);
                break;
+       }
 
        case LFUN_RIGHT: {
                bool is_rtl = cursor.par()->isRightToLeftPar(bv->buffer()->params);
                if (!selection.mark())
                        bv->beforeChange(this);
-               update(bv);
+               update();
                if (is_rtl)
-                       cursorLeft(bv, false);
+                       cursorLeft(false);
                if (cursor.pos() < cursor.par()->size()
                    && cursor.par()->isInset(cursor.pos())
                    && isHighlyEditableInset(cursor.par()->getInset(cursor.pos()))) {
-                       Inset * tmpinset = cursor.par()->getInset(cursor.pos());
+                       InsetOld * tmpinset = cursor.par()->getInset(cursor.pos());
                        cmd.message(tmpinset->editMessage());
-                       tmpinset->edit(bv, !is_rtl);
+                       FuncRequest cmd1(bv, LFUN_INSET_EDIT, is_rtl ? "right" : "left");
+                       tmpinset->localDispatch(cmd1);
                        break;
                }
                if (!is_rtl)
-                       cursorRight(bv, false);
-               bv->finishChange(false);
+                       cursorRight(false);
+               finishChange(bv);
                break;
        }
 
@@ -263,22 +626,23 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                bool const is_rtl = cursor.par()->isRightToLeftPar(bv->buffer()->params);
                if (!selection.mark())
                        bv->beforeChange(this);
-               update(bv);
+               update();
                LyXCursor const cur = cursor;
                if (!is_rtl)
-                       cursorLeft(bv, false);
+                       cursorLeft(false);
                if ((is_rtl || cur != cursor) && // only if really moved!
                    cursor.pos() < cursor.par()->size() &&
                    cursor.par()->isInset(cursor.pos()) &&
                    isHighlyEditableInset(cursor.par()->getInset(cursor.pos()))) {
-                       Inset * tmpinset = cursor.par()->getInset(cursor.pos());
+                       InsetOld * tmpinset = cursor.par()->getInset(cursor.pos());
                        cmd.message(tmpinset->editMessage());
-                       tmpinset->edit(bv, is_rtl);
+                       FuncRequest cmd1(bv, LFUN_INSET_EDIT, is_rtl ? "left" : "right");
+                       tmpinset->localDispatch(cmd1);
                        break;
                }
                if (is_rtl)
-                       cursorRight(bv, false);
-               bv->finishChange(false);
+                       cursorRight(false);
+               finishChange(bv);
                break;
        }
 
@@ -286,90 +650,94 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                if (!selection.mark())
                        bv->beforeChange(this);
                bv->update(this, BufferView::UPDATE);
-               cursorUp(bv);
-               bv->finishChange(false);
+               cursorUp(false);
+               finishChange(bv);
                break;
 
        case LFUN_DOWN:
                if (!selection.mark())
                        bv->beforeChange(this);
                bv->update(this, BufferView::UPDATE);
-               cursorDown(bv);
-               bv->finishChange();
+               cursorDown(false);
+               finishChange(bv);
                break;
 
        case LFUN_UP_PARAGRAPH:
                if (!selection.mark())
                        bv->beforeChange(this);
                bv->update(this, BufferView::UPDATE);
-               cursorUpParagraph(bv);
-               bv->finishChange();
+               cursorUpParagraph();
+               finishChange(bv);
                break;
 
        case LFUN_DOWN_PARAGRAPH:
                if (!selection.mark())
                        bv->beforeChange(this);
                bv->update(this, BufferView::UPDATE);
-               cursorDownParagraph(bv);
-               bv->finishChange(false);
+               cursorDownParagraph();
+               finishChange(bv, false);
                break;
 
        case LFUN_PRIOR:
                if (!selection.mark())
                        bv->beforeChange(this);
                bv->update(this, BufferView::UPDATE);
-               bv->cursorPrevious(this);
-               bv->finishChange(false);
-               // was:
-               // finishUndo();
-               // moveCursorUpdate(false, false);
-               // owner_->view_state_changed();
+               cursorPrevious();
+               finishChange(bv, false);
                break;
 
        case LFUN_NEXT:
                if (!selection.mark())
                        bv->beforeChange(this);
                bv->update(this, BufferView::UPDATE);
-               bv->cursorNext(this);
-               bv->finishChange(false);
+               cursorNext();
+               finishChange(bv, false);
                break;
 
        case LFUN_HOME:
                if (!selection.mark())
                        bv->beforeChange(this);
-               update(bv);
-               cursorHome(bv);
-               bv->finishChange(false);
+               update();
+               cursorHome();
+               finishChange(bv, false);
                break;
 
        case LFUN_END:
                if (!selection.mark())
                        bv->beforeChange(this);
-               update(bv);
-               cursorEnd(bv);
-               bv->finishChange(false);
+               update();
+               cursorEnd();
+               finishChange(bv, false);
                break;
 
-       case LFUN_BREAKLINE:
-               bv->beforeChange(this);
-               insertChar(bv, Paragraph::META_NEWLINE);
-               update(bv, true);
-               setCursor(bv, cursor.par(), cursor.pos());
-               bv->moveCursorUpdate(false);
+       case LFUN_BREAKLINE: {
+               lyx::pos_type body = cursor.par()->beginningOfBody();
+
+               // Not allowed by LaTeX (labels or empty par)
+               if (cursor.pos() <= body)
+                       break;
+
+               replaceSelection(bv->getLyXText());
+               insertInset(new InsetNewline);
+               update();
+               setCursor(cursor.par(), cursor.pos());
+               moveCursorUpdate(bv, false);
                break;
+       }
 
        case LFUN_DELETE:
                if (!selection.set()) {
-                       Delete(bv);
+                       Delete();
                        selection.cursor = cursor;
-                       update(bv);
+                       update();
                        // It is possible to make it a lot faster still
                        // just comment out the line below...
-                       bv->showCursor();
                } else {
-                       bv->cut(false);
+                       update();
+                       cutSelection(true, false);
+                       update();
                }
-               bv->moveCursorUpdate(false);
+               moveCursorUpdate(bv, false);
                bv->owner()->view_state_changed();
                bv->switchKeyMap();
                break;
@@ -384,7 +752,7 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                                if (cur.pos() == 0
                                    && !(cur.par()->params().spaceTop()
                                         == VSpace (VSpace::NONE))) {
-                                       setParagraph(bv,
+                                       setParagraph(
                                                 cur.par()->params().lineTop(),
                                                 cur.par()->params().lineBottom(),
                                                 cur.par()->params().pagebreakTop(),
@@ -395,35 +763,38 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                                                 cur.par()->params().align(),
                                                 cur.par()->params().labelWidthString(), 0);
                                        cursorLeft(bv);
-                                       update(bv);
+                                       update();
                                } else {
                                        cursorLeft(bv);
-                                       Delete(bv);
+                                       Delete();
                                        selection.cursor = cursor;
-                                       update(bv);
                                }
                        } else {
-                               Delete(bv);
+                               Delete();
                                selection.cursor = cursor;
-                               update(bv);
                        }
-               } else
-                       bv->cut(false);
+               } else {
+                       update();
+                       cutSelection(true, false);
+               }
+               update();
                break;
 
 
        case LFUN_BACKSPACE:
                if (!selection.set()) {
                        if (bv->owner()->getIntl().getTransManager().backspace()) {
-                               backspace(bv);
+                               backspace();
                                selection.cursor = cursor;
-                               update(bv);
+                               update();
                                // It is possible to make it a lot faster still
                                // just comment out the line below...
-                               bv->showCursor();
                        }
-               } else
-                       bv->cut(false);
+               } else {
+                       update();
+                       cutSelection(true, false);
+                       update();
+               }
                bv->owner()->view_state_changed();
                bv->switchKeyMap();
                break;
@@ -435,7 +806,7 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                        if (cur.pos() == 0
                            && !(cur.par()->params().spaceTop()
                                 == VSpace (VSpace::NONE))) {
-                               setParagraph(bv,
+                               setParagraph(
                                         cur.par()->params().lineTop(),
                                         cur.par()->params().lineBottom(),
                                         cur.par()->params().pagebreakTop(),
@@ -444,29 +815,30 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                                         cur.par()->params().spacing(),
                                         cur.par()->params().align(),
                                         cur.par()->params().labelWidthString(), 0);
-                               update(bv);
                        } else {
-                               backspace(bv);
+                               backspace();
                                selection.cursor = cur;
-                               update(bv);
                        }
-               } else
-                       bv->cut(false);
+               } else {
+                       update();
+                       cutSelection(true, false);
+               }
+               update();
                break;
 
        case LFUN_BREAKPARAGRAPH:
-               bv->beforeChange(this);
-               breakParagraph(bv, 0);
-               update(bv);
+               replaceSelection(bv->getLyXText());
+               breakParagraph(bv->buffer()->paragraphs, 0);
+               update();
                selection.cursor = cursor;
                bv->switchKeyMap();
                bv->owner()->view_state_changed();
                break;
 
        case LFUN_BREAKPARAGRAPHKEEPLAYOUT:
-               bv->beforeChange(this);
-               breakParagraph(bv, 1);
-               update(bv);
+               replaceSelection(bv->getLyXText());
+               breakParagraph(bv->buffer()->paragraphs, 1);
+               update();
                selection.cursor = cursor;
                bv->switchKeyMap();
                bv->owner()->view_state_changed();
@@ -477,10 +849,10 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                // indentation and add a "defskip" at the top.
                // Otherwise, do the same as LFUN_BREAKPARAGRAPH.
                LyXCursor cur = cursor;
-               bv->beforeChange(this);
+               replaceSelection(bv->getLyXText());
                if (cur.pos() == 0) {
                        if (cur.par()->params().spaceTop() == VSpace(VSpace::NONE)) {
-                               setParagraph(bv,
+                               setParagraph(
                                         cur.par()->params().lineTop(),
                                         cur.par()->params().lineBottom(),
                                         cur.par()->params().pagebreakTop(),
@@ -489,14 +861,12 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                                         cur.par()->params().spacing(),
                                         cur.par()->params().align(),
                                         cur.par()->params().labelWidthString(), 1);
-                               //update(bv);
                        }
                }
                else {
-                       breakParagraph(bv, 0);
-                       //update(bv);
+                       breakParagraph(bv->buffer()->paragraphs, 0);
                }
-               update(bv);
+               update();
                selection.cursor = cur;
                bv->switchKeyMap();
                bv->owner()->view_state_changed();
@@ -504,13 +874,13 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
        }
 
        case LFUN_PARAGRAPH_SPACING: {
-               Paragraph * par = cursor.par();
-               Spacing::Space cur_spacing = par->params().spacing().getSpace();
+               ParagraphList::iterator pit = cursor.par();
+               Spacing::Space cur_spacing = pit->params().spacing().getSpace();
                float cur_value = 1.0;
                if (cur_spacing == Spacing::Other)
-                       cur_value = par->params().spacing().getValue();
+                       cur_value = pit->params().spacing().getValue();
 
-               istringstream is(cmd.argument.c_str());
+               istringstream is(STRCONV(cmd.argument));
                string tmp;
                is >> tmp;
                Spacing::Space new_spacing = cur_spacing;
@@ -538,30 +908,34 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                               << cmd.argument << endl;
                }
                if (cur_spacing != new_spacing || cur_value != new_value) {
-                       par->params().spacing(Spacing(new_spacing, new_value));
-                       redoParagraph(bv);
-                       update(bv);
+                       pit->params().spacing(Spacing(new_spacing, new_value));
+                       redoParagraph();
+                       update();
                }
                break;
        }
 
+       case LFUN_INSET_SETTINGS:
+               Assert(bv->theLockingInset());
+               bv->theLockingInset()->getLockingInset()->showInsetDialog(bv);
+               break;
+
        case LFUN_INSET_TOGGLE:
-               bv->hideCursor();
                bv->beforeChange(this);
-               update(bv, false);
-               toggleInset(bv);
-               update(bv, false);
+               update();
+               toggleInset();
+               update();
                bv->switchKeyMap();
                break;
 
-       case LFUN_PROTECTEDSPACE:
+       case LFUN_SPACE_INSERT:
                if (cursor.par()->layout()->free_spacing) {
-                       insertChar(bv, ' ');
-                       update(bv);
+                       insertChar(' ');
+                       update();
                } else {
-                       specialChar(this, bv, InsetSpecialChar::PROTECTED_SEPARATOR);
+                       doInsertInset(this, cmd, false, false);
                }
-               bv->moveCursorUpdate(false);
+               moveCursorUpdate(bv, false);
                break;
 
        case LFUN_HYPHENATION:
@@ -576,13 +950,6 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                specialChar(this, bv, InsetSpecialChar::LDOTS);
                break;
 
-       case LFUN_HFILL:
-               bv->hideCursor();
-               update(bv, false);
-               insertChar(bv, Paragraph::META_HFILL);
-               update(bv);
-               break;
-
        case LFUN_END_OF_SENTENCE:
                specialChar(this, bv, InsetSpecialChar::END_OF_SENTENCE);
                break;
@@ -593,7 +960,7 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
 
        case LFUN_MARK_OFF:
                bv->beforeChange(this);
-               update(bv, false);
+               update();
                selection.cursor = cursor;
                cmd.message(N_("Mark off"));
                break;
@@ -601,7 +968,7 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
        case LFUN_MARK_ON:
                bv->beforeChange(this);
                selection.mark(true);
-               update(bv, false);
+               update();
                selection.cursor = cursor;
                cmd.message(N_("Mark on"));
                break;
@@ -609,62 +976,93 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
        case LFUN_SETMARK:
                bv->beforeChange(this);
                if (selection.mark()) {
-                       update(bv);
+                       update();
                        cmd.message(N_("Mark removed"));
                } else {
                        selection.mark(true);
-                       update(bv);
+                       update();
                        cmd.message(N_("Mark set"));
                }
                selection.cursor = cursor;
                break;
 
        case LFUN_UPCASE_WORD:
-               update(bv, false);
-               changeCase(bv, LyXText::text_uppercase);
+               update();
+               changeCase(LyXText::text_uppercase);
                if (inset_owner)
-                       bv->updateInset(inset_owner, true);
-               update(bv);
+                       bv->updateInset(inset_owner);
+               update();
                break;
 
        case LFUN_LOWCASE_WORD:
-               update(bv, false);
-               changeCase(bv, LyXText::text_lowercase);
+               update();
+               changeCase(LyXText::text_lowercase);
                if (inset_owner)
-                       bv->updateInset(inset_owner, true);
-               update(bv);
+                       bv->updateInset(inset_owner);
+               update();
                break;
 
        case LFUN_CAPITALIZE_WORD:
-               update(bv, false);
-               changeCase(bv, LyXText::text_capitalization);
+               update();
+               changeCase(LyXText::text_capitalization);
                if (inset_owner)
-                       bv->updateInset(inset_owner, true);
-               update(bv);
+                       bv->updateInset(inset_owner);
+               update();
                break;
 
        case LFUN_TRANSPOSE_CHARS:
-               update(bv, false);
-               transposeChars(*bv);
+               update();
+               recordUndo(bv, Undo::ATOMIC, cursor.par());
+               if (transposeChars(cursor))
+                       checkParagraph(cursor.par(), cursor.pos());
                if (inset_owner)
-                       bv->updateInset(inset_owner, true);
-               update(bv);
+                       bv->updateInset(inset_owner);
+               update();
+               break;
+
+       case LFUN_PASTE: {
+               cmd.message(_("Paste"));
+               replaceSelection(bv->getLyXText());
+               size_t sel_index = 0;
+               string const & arg = cmd.argument;
+               if (isStrUnsignedInt(arg)) {
+                       size_t const paste_arg = strToUnsignedInt(arg);
+#warning FIXME Check if the arg is in the domain of available selections.
+                       sel_index = paste_arg;
+               }
+               pasteSelection(sel_index);
+               clearSelection(); // bug 393
+               update();
+               bv->switchKeyMap();
+               break;
+       }
+
+       case LFUN_CUT:
+               update();
+               cutSelection(true, true);
+               update();
+               cmd.message(_("Cut"));
+               break;
+
+       case LFUN_COPY:
+               copySelection();
+               cmd.message(_("Copy"));
                break;
 
        case LFUN_BEGINNINGBUFSEL:
                if (inset_owner)
-                       return Inset::UNDISPATCHED;
-               update(bv, false);
-               cursorTop(bv);
-               bv->finishChange(true);
+                       return UNDISPATCHED;
+               update();
+               cursorTop();
+               finishChange(bv, true);
                break;
 
        case LFUN_ENDBUFSEL:
                if (inset_owner)
-                       return Inset::UNDISPATCHED;
-               update(bv, false);
-               cursorBottom(bv);
-               bv->finishChange(true);
+                       return UNDISPATCHED;
+               update();
+               cursorBottom();
+               finishChange(bv, true);
                break;
 
        case LFUN_GETXY:
@@ -674,10 +1072,13 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
        case LFUN_SETXY: {
                int x = 0;
                int y = 0;
-               if (::sscanf(cmd.argument.c_str(), " %d %d", &x, &y) != 2)
+               istringstream is(STRCONV(cmd.argument));
+               is >> x >> y;
+               if (!is)
                        lyxerr << "SETXY: Could not parse coordinates in '"
                               << cmd.argument << std::endl;
-               setCursorFromCoordinates(bv, x, y);
+               else
+                       setCursorFromCoordinates(x, y);
                break;
        }
 
@@ -728,25 +1129,27 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                }
 
                bool change_layout = (current_layout != layout);
+
                if (!change_layout && selection.set() &&
                        selection.start.par() != selection.end.par())
                {
-                       Paragraph * spar = selection.start.par();
-                       Paragraph * epar = selection.end.par()->next();
-                       while (spar != epar) {
-                               if (spar->layout()->name() != current_layout) {
+                       ParagraphList::iterator spit = selection.start.par();
+                       ParagraphList::iterator epit = boost::next(selection.end.par());
+                       while (spit != epit) {
+                               if (spit->layout()->name() != current_layout) {
                                        change_layout = true;
                                        break;
                                }
+                               ++spit;
                        }
                }
+
                if (change_layout) {
-                       bv->hideCursor();
                        current_layout = layout;
-                       update(bv, false);
-                       setLayout(bv, layout);
+                       update();
+                       setLayout(layout);
                        bv->owner()->setLayout(layout);
-                       update(bv);
+                       update();
                        bv->switchKeyMap();
                }
                break;
@@ -755,19 +1158,368 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
        case LFUN_PASTESELECTION: {
                if (!bv->buffer())
                        break;
-               bv->hideCursor();
                // this was originally a beforeChange(bv->text), i.e
                // the outermost LyXText!
                bv->beforeChange(this);
-               string const clip(bv->workarea().getClipboard());
+               string const clip = bv->getClipboard();
                if (!clip.empty()) {
                        if (cmd.argument == "paragraph")
-                               insertStringAsParagraphs(bv, clip);
-                       else 
-                               insertStringAsLines(bv, clip);
+                               insertStringAsParagraphs(clip);
+                       else
+                               insertStringAsLines(clip);
                        clearSelection();
-                       update(bv);
+                       update();
+               }
+               break;
+       }
+
+       case LFUN_GOTOERROR:
+               gotoInset(InsetOld::ERROR_CODE, false);
+               break;
+
+       case LFUN_GOTONOTE:
+               gotoInset(InsetOld::NOTE_CODE, false);
+               break;
+
+       case LFUN_REFERENCE_GOTO:
+       {
+               vector<InsetOld::Code> tmp;
+               tmp.push_back(InsetOld::LABEL_CODE);
+               tmp.push_back(InsetOld::REF_CODE);
+               gotoInset(tmp, true);
+               break;
+       }
+
+       case LFUN_QUOTE: {
+               replaceSelection(bv->getLyXText());
+               ParagraphList::iterator pit = cursor.par();
+               lyx::pos_type pos = cursor.pos();
+               char c;
+               if (!pos)
+                       c = ' ';
+               else if (pit->isInset(pos - 1) && pit->getInset(pos - 1)->isSpace())
+                       c = ' ';
+               else
+                       c = pit->getChar(pos - 1);
+
+               LyXLayout_ptr const & style = pit->layout();
+
+               if (style->pass_thru ||
+                               pit->getFontSettings(bv->buffer()->params,
+                                        pos).language()->lang() == "hebrew" ||
+                       (!bv->insertInset(new InsetQuotes(c, bv->buffer()->params))))
+                       bv->owner()->dispatch(FuncRequest(LFUN_SELFINSERT, "\""));
+               break;
+       }
+
+       case LFUN_DATE_INSERT: {
+               replaceSelection(bv->getLyXText());
+               time_t now_time_t = time(NULL);
+               struct tm * now_tm = localtime(&now_time_t);
+               setlocale(LC_TIME, "");
+               string arg;
+               if (!cmd.argument.empty())
+                       arg = cmd.argument;
+               else
+                       arg = lyxrc.date_insert_format;
+               char datetmp[32];
+               int const datetmp_len =
+                       ::strftime(datetmp, 32, arg.c_str(), now_tm);
+
+               for (int i = 0; i < datetmp_len; i++) {
+                       insertChar(datetmp[i]);
+                       update();
                }
+               selection.cursor = cursor;
+               moveCursorUpdate(bv, false);
+               break;
+       }
+
+       case LFUN_MOUSE_TRIPLE:
+               if (!bv->buffer())
+                       break;
+               if (!isInInset() && bv->theLockingInset())
+                       break;
+               if (cmd.button() == mouse_button::button1) {
+                       if (!isInInset()) {
+                               bv->screen().toggleSelection(this, bv);
+                       }
+                       cursorHome();
+                       selection.cursor = cursor;
+                       cursorEnd();
+                       setSelection();
+                       if (!isInInset())
+                               bv->screen().toggleSelection(this, bv, false);
+                       update();
+                       bv->haveSelection(selection.set());
+               }
+               break;
+
+       case LFUN_MOUSE_DOUBLE:
+               if (!bv->buffer())
+                       break;
+               if (!isInInset() && bv->theLockingInset())
+                       break;
+               if (cmd.button() == mouse_button::button1) {
+                       if (!isInInset()) {
+                               bv->screen().toggleSelection(this, bv);
+                               selectWord(lyx::WHOLE_WORD_STRICT);
+                               bv->screen().toggleSelection(this, bv, false);
+                       } else {
+                               selectWord(lyx::WHOLE_WORD_STRICT);
+                       }
+                       update();
+                       bv->haveSelection(selection.set());
+               }
+               break;
+
+       case LFUN_MOUSE_MOTION:
+       {
+               // Only use motion with button 1
+               //if (ev.button() != mouse_button::button1)
+               //      return false;
+
+               if (!bv->buffer())
+                       break;
+
+               // Check for inset locking
+               if (bv->theLockingInset()) {
+                       InsetOld * tli = bv->theLockingInset();
+                       LyXCursor cursor = bv->text->cursor;
+                       LyXFont font = bv->text->getFont(cursor.par(), cursor.pos());
+                       int width = tli->width();
+                       int inset_x = font.isVisibleRightToLeft()
+                               ? cursor.ix() - width : cursor.ix();
+                       int start_x = inset_x + tli->scroll();
+                       FuncRequest cmd1 = cmd;
+                       cmd1.x = cmd.x - start_x;
+                       cmd1.y = cmd.y - cursor.iy() + bv->text->top_y();
+                       tli->localDispatch(cmd1);
+                       break;
+               }
+
+               // The test for not selection possible is needed, that only motion
+               // events are used, where the bottom press event was on
+               //  the drawing area too
+               if (!selection_possible) {
+                       lyxerr[Debug::ACTION]
+                               << "BufferView::Pimpl::Dispatch: no selection possible\n";
+                       break;
+               }
+
+               RowList::iterator cursorrow = bv->text->cursorRow();
+               bv->text->setCursorFromCoordinates(cmd.x, cmd.y + bv->text->top_y());
+       #if 0
+               // sorry for this but I have a strange error that the y value jumps at
+               // a certain point. This seems like an error in my xforms library or
+               // in some other local environment, but I would like to leave this here
+               // for the moment until I can remove this (Jug 20020418)
+               if (y_before < bv->text->cursor.y())
+                       lyxerr << y_before << ':'
+                              << bv->text->cursor.y() << endl;
+       #endif
+               // This is to allow jumping over large insets
+               if (cursorrow == bv->text->cursorRow()) {
+                       if (cmd.y >= bv->workHeight())
+                               bv->text->cursorDown(false);
+                       else if (cmd.y < 0)
+                               bv->text->cursorUp(false);
+               }
+
+               // Maybe an empty line was deleted
+               if (!bv->text->selection.set())
+                       bv->update(BufferView::UPDATE);
+               bv->text->setSelection();
+               bv->repaint();
+               bv->fitCursor();
+               break;
+       }
+
+       // Single-click on work area
+       case LFUN_MOUSE_PRESS:
+       {
+               if (!bv->buffer())
+                       break;
+
+               // ok ok, this is a hack (for xforms)
+               // We shouldn't go further down as we really should only do the
+               // scrolling and be done with this. Otherwise we may open some
+               // dialogs (Jug 20020424).
+               if (cmd.button() == mouse_button::button4) {
+                       bv->scroll(-lyxrc.wheel_jump);
+                       break;
+               }
+               if (cmd.button() == mouse_button::button5) {
+                       bv->scroll(lyxrc.wheel_jump);
+                       break;
+               }
+
+               int x = cmd.x;
+               int y = cmd.y;
+               InsetOld * inset_hit = bv->text->checkInsetHit(x, y);
+
+               // Middle button press pastes if we have a selection
+               // We do this here as if the selection was inside an inset
+               // it could get cleared on the unlocking of the inset so
+               // we have to check this first
+               bool paste_internally = false;
+               if (cmd.button() == mouse_button::button2 && selection.set()) {
+                       bv->owner()->dispatch(FuncRequest(LFUN_COPY));
+                       paste_internally = true;
+               }
+
+               int const screen_first = bv->text->top_y();
+
+               if (bv->theLockingInset()) {
+                       // We are in inset locking mode
+
+                       // Check whether the inset was hit. If not reset mode,
+                       // otherwise give the event to the inset
+                       if (inset_hit == bv->theLockingInset()) {
+                               FuncRequest cmd1(bv, LFUN_MOUSE_PRESS, x, y, cmd.button());
+                               bv->theLockingInset()->localDispatch(cmd1);
+                               break;
+                       }
+                       bv->unlockInset(bv->theLockingInset());
+               }
+
+               if (!inset_hit)
+                       selection_possible = true;
+
+               // Clear the selection
+               bv->screen().toggleSelection(bv->text, bv);
+               bv->text->clearSelection();
+               bv->text->partialRebreak();
+               bv->update();
+               bv->updateScrollbar();
+
+               // Single left click in math inset?
+               if (isHighlyEditableInset(inset_hit)) {
+                       // Highly editable inset, like math
+                       UpdatableInset * inset = static_cast<UpdatableInset *>(inset_hit);
+                       selection_possible = false;
+                       bv->owner()->message(inset->editMessage());
+                       // We just have to lock the inset before calling a PressEvent on it!
+                       if (!bv->lockInset(inset))
+                               lyxerr[Debug::INSETS] << "Cannot lock inset" << endl;
+                       FuncRequest cmd1(bv, LFUN_MOUSE_PRESS, x, y, cmd.button());
+                       inset->localDispatch(cmd1);
+                       break;
+               }
+               // I'm not sure we should continue here if we hit an inset (Jug20020403)
+
+               // Right click on a footnote flag opens float menu
+               if (cmd.button() == mouse_button::button3) {
+                       selection_possible = false;
+                       break;
+               }
+
+               if (!inset_hit) // otherwise it was already set in checkInsetHit(...)
+                       bv->text->setCursorFromCoordinates(x, y + screen_first);
+               finishUndo();
+               bv->text->selection.cursor = bv->text->cursor;
+               bv->text->cursor.x_fix(bv->text->cursor.x());
+
+               if (bv->fitCursor())
+                       selection_possible = false;
+
+               // Insert primary selection with middle mouse
+               // if there is a local selection in the current buffer,
+               // insert this
+               if (cmd.button() == mouse_button::button2) {
+                       if (paste_internally)
+                               bv->owner()->dispatch(FuncRequest(LFUN_PASTE));
+                       else
+                               bv->owner()->dispatch(FuncRequest(LFUN_PASTESELECTION, "paragraph"));
+                       selection_possible = false;
+               }
+               break;
+       }
+
+       case LFUN_MOUSE_RELEASE:
+       {
+               // do nothing if we used the mouse wheel
+               if (!bv->buffer())
+                       break;
+
+               if (cmd.button() == mouse_button::button4
+                || cmd.button() == mouse_button::button5)
+                       break;
+
+               // If we hit an inset, we have the inset coordinates in these
+               // and inset_hit points to the inset.  If we do not hit an
+               // inset, inset_hit is 0, and inset_x == x, inset_y == y.
+               int x = cmd.x;
+               int y = cmd.y;
+               InsetOld * inset_hit = bv->text->checkInsetHit(x, y);
+
+               if (bv->theLockingInset()) {
+                       // We are in inset locking mode.
+
+                       // LyX does a kind of work-area grabbing for insets.
+                       // Only a ButtonPress FuncRequest outside the inset will
+                       // force a insetUnlock.
+                       FuncRequest cmd1(bv, LFUN_MOUSE_RELEASE, x, y, cmd.button());
+                       bv->theLockingInset()->localDispatch(cmd1);
+                       break;
+               }
+
+               selection_possible = false;
+
+               if (cmd.button() == mouse_button::button2)
+                       break;
+
+               // finish selection
+               if (cmd.button() == mouse_button::button1)
+                       bv->haveSelection(selection.set());
+
+               bv->switchKeyMap();
+               bv->owner()->view_state_changed();
+               bv->owner()->updateMenubar();
+               bv->owner()->updateToolbar();
+
+               // Did we hit an editable inset?
+               if (inset_hit) {
+                       selection_possible = false;
+
+                       // if we reach this point with a selection, it
+                       // must mean we are currently selecting.
+                       // But we don't want to open the inset
+                       // because that is annoying for the user.
+                       // So just pretend we didn't hit it.
+                       // this is OK because a "kosher" ButtonRelease
+                       // will follow a ButtonPress that clears
+                       // the selection.
+                       // Note this also fixes selection drawing
+                       // problems if we end up opening an inset
+                       if (selection.set())
+                               break;
+
+                       // CHECK fix this proper in 0.13
+                       // well, maybe 13.0 !!!!!!!!!
+
+                       // Following a ref shouldn't issue
+                       // a push on the undo-stack
+                       // anylonger, now that we have
+                       // keybindings for following
+                       // references and returning from
+                       // references.  IMHO though, it
+                       // should be the inset's own business
+                       // to push or not push on the undo
+                       // stack. They don't *have* to
+                       // alter the document...
+                       // (Joacim)
+                       // ...or maybe the SetCursorParUndo()
+                       // below isn't necessary at all anylonger?
+                       if (inset_hit->lyxCode() == InsetOld::REF_CODE)
+                               recordUndo(bv, Undo::ATOMIC);
+
+                       bv->owner()->message(inset_hit->editMessage());
+
+                       FuncRequest cmd1(bv, LFUN_MOUSE_RELEASE, x, y, cmd.button());
+                       inset_hit->localDispatch(cmd1);
+               }
+
                break;
        }
 
@@ -783,10 +1535,10 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
 
                if (lyxrc.auto_region_delete) {
                        if (selection.set()) {
-                               cutSelection(bv, false, false);
-                               update(bv);
+                               cutSelection(false, false);
+                               update();
                        }
-                       bv->workarea().haveSelection(false);
+                       bv->haveSelection(false);
                }
 
                bv->beforeChange(this);
@@ -798,9 +1550,9 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                        bv->owner()->getIntl().getTransManager().
                                TranslateAndInsert(*cit, this);
 
-               update(bv);
+               update();
                selection.cursor = cursor;
-               bv->moveCursorUpdate(false);
+               moveCursorUpdate(bv, false);
 
                // real_current_font.number can change so we need to
                // update the minibuffer
@@ -809,9 +1561,58 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                break;
        }
 
+       case LFUN_HTMLURL: {
+               InsetCommandParams p("htmlurl");
+               string const data = InsetCommandMailer::params2string("url", p);
+               bv->owner()->getDialogs().show("url", data, 0);
+               break;
+       }
+
+       case LFUN_URL: {
+               InsetCommandParams p("url");
+               string const data = InsetCommandMailer::params2string("url", p);
+               bv->owner()->getDialogs().show("url", data, 0);
+               break;
+       }
+
+
+#if 0
+       case LFUN_INSET_LIST:
+       case LFUN_INSET_THEOREM:
+       case LFUN_INSET_CAPTION:
+#endif
+       case LFUN_INSERT_NOTE:
+       case LFUN_INSERT_BIBITEM:
+       case LFUN_INSET_ERT:
+       case LFUN_INSET_FLOAT:
+       case LFUN_INSET_FOOTNOTE:
+       case LFUN_INSET_MARGINAL:
+       case LFUN_INSET_MINIPAGE:
+       case LFUN_INSET_OPTARG:
+       case LFUN_INSET_WIDE_FLOAT:
+       case LFUN_INSET_WRAP:
+       case LFUN_TABULAR_INSERT:
+       case LFUN_ENVIRONMENT_INSERT:
+               // Open the inset, and move the current selection
+               // inside it.
+               doInsertInset(this, cmd, true, true);
+               break;
+
+       case LFUN_INDEX_INSERT:
+               // Just open the inset
+               doInsertInset(this, cmd, true, false);
+               break;
+
+       case LFUN_INDEX_PRINT:
+       case LFUN_TOC_INSERT:
+       case LFUN_HFILL:
+               // do nothing fancy
+               doInsertInset(this, cmd, false, false);
+               break;
+
        default:
-               return Inset::UNDISPATCHED;
+               return UNDISPATCHED;
        }
 
-       return Inset::DISPATCHED;
+       return DISPATCHED;
 }