]> git.lyx.org Git - lyx.git/blobdiff - src/text3.C
fix some C++ parsing bugs
[lyx.git] / src / text3.C
index 0a0e083c8b78e75ebc6868ea045dd2a98ccd2a64..34885b68033ae55c82c9b64dd5e190530907b54b 100644 (file)
@@ -31,9 +31,9 @@
 #include "frontends/Dialogs.h"
 #include "insets/insetspecialchar.h"
 #include "insets/insettext.h"
-#include "insets/insetbib.h"
 #include "insets/insetquotes.h"
 #include "insets/insetcommand.h"
+#include "insets/insetnewline.h"
 #include "undo_funcs.h"
 
 #include <ctime>
@@ -58,21 +58,18 @@ namespace {
                LyXText * lt = bv->getLyXText();
 
                if (selecting || lt->selection.mark()) {
-                       lt->setSelection(bv);
-                       if (lt->isTopLevel())
-                               bv->toggleToggle();
+                       lt->setSelection();
+                       if (lt->isInInset())
+                               bv->updateInset(lt->inset_owner);
                        else
-                               bv->updateInset(lt->inset_owner, false);
+                               bv->toggleToggle();
                }
-               if (lt->isTopLevel()) {
-                       //if (fitcur)
-                       //      bv->update(lt, BufferView::SELECT|BufferView::FITCUR);
-                       //else
-                       bv->update(lt, BufferView::SELECT|BufferView::FITCUR);
+               if (!lt->isInInset()) {
+                       bv->update(lt, BufferView::SELECT);
                        bv->showCursor();
-               } else if (bv->text->status() != LyXText::UNCHANGED) {
+               } else if (bv->text->refreshStatus() != LyXText::REFRESH_NONE) {
                        bv->theLockingInset()->hideInsetCursor(bv);
-                       bv->update(bv->text, BufferView::SELECT|BufferView::FITCUR);
+                       bv->update(BufferView::SELECT);
                        bv->showCursor();
                }
 
@@ -93,7 +90,7 @@ namespace {
        // check if the given co-ordinates are inside an inset at the
        // given cursor, if one exists. If so, the inset is returned,
        // and the co-ordinates are made relative. Otherwise, 0 is returned.
-       Inset * checkInset(BufferView * bv, LyXText const & text,
+       Inset * checkInset(BufferView * bv, LyXText & text,
                LyXCursor const & cur, int & x, int & y)
        {
                lyx::pos_type const pos = cur.pos();
@@ -130,7 +127,7 @@ namespace {
                        return 0;
                }
 
-               text.setCursor(bv, &par, pos, true);
+               text.setCursor(&par, pos, true);
 
                x -= b.x1;
                // The origin of an inset is on the baseline
@@ -142,14 +139,14 @@ namespace {
 } // anon namespace
 
 
-Inset * LyXText::checkInsetHit(BufferView * bv, int & x, int & y) const
+Inset * LyXText::checkInsetHit(int & x, int & y)
 {
-       int y_tmp = y + first_y;
+       int y_tmp = y + top_y();
 
        LyXCursor cur;
-       setCursorFromCoordinates(bv, cur, x, y_tmp);
+       setCursorFromCoordinates(cur, x, y_tmp);
 
-       Inset * inset = checkInset(bv, *this, cur, x, y_tmp);
+       Inset * inset = checkInset(bv(), *this, cur, x, y_tmp);
        if (inset) {
                y = y_tmp;
                return inset;
@@ -160,17 +157,17 @@ Inset * LyXText::checkInsetHit(BufferView * bv, int & x, int & y) const
                return 0;
 
        // move back one
-       setCursor(bv, cur, cur.par(), cur.pos() - 1, true);
+       setCursor(cur, cur.par(), cur.pos() - 1, true);
 
-       inset = checkInset(bv, *this, cur, x, y_tmp);
+       inset = checkInset(bv(), *this, cur, x, y_tmp);
        if (inset)
                y = y_tmp;
        return inset;
 }
 
 
-bool LyXText::gotoNextInset(BufferView * bv,
-       vector<Inset::Code> const & codes, string const & contents) const
+bool LyXText::gotoNextInset(vector<Inset::Code> const & codes,
+                           string const & contents)
 {
        LyXCursor res = cursor;
        Inset * inset;
@@ -193,19 +190,19 @@ bool LyXText::gotoNextInset(BufferView * bv,
                       == contents)));
 
        if (res.par()) {
-               setCursor(bv, res.par(), res.pos(), false);
+               setCursor(res.par(), res.pos(), false);
                return true;
        }
        return false;
 }
 
 
-void LyXText::gotoInset(BufferView * bv, vector<Inset::Code> const & codes,
+void LyXText::gotoInset(vector<Inset::Code> const & codes,
                                  bool same_content)
 {
-       bv->hideCursor();
-       bv->beforeChange(this);
-       update(bv, false);
+       bv()->hideCursor();
+       bv()->beforeChange(this);
+       update();
 
        string contents;
        if (same_content && cursor.par()->isInset(cursor.pos())) {
@@ -215,151 +212,149 @@ void LyXText::gotoInset(BufferView * bv, vector<Inset::Code> const & codes,
                        contents = static_cast<InsetCommand const *>(inset)->getContents();
        }
 
-       if (!gotoNextInset(bv, codes, contents)) {
+       if (!gotoNextInset(codes, contents)) {
                if (cursor.pos() || cursor.par() != ownerParagraph()) {
                        LyXCursor tmp = cursor;
                        cursor.par(ownerParagraph());
                        cursor.pos(0);
-                       if (!gotoNextInset(bv, codes, contents)) {
+                       if (!gotoNextInset(codes, contents)) {
                                cursor = tmp;
-                               bv->owner()->message(_("No more insets"));
+                               bv()->owner()->message(_("No more insets"));
                        }
                } else {
-                       bv->owner()->message(_("No more insets"));
+                       bv()->owner()->message(_("No more insets"));
                }
        }
-       update(bv, false);
+       update();
        selection.cursor = cursor;
 }
 
 
-void LyXText::gotoInset(BufferView * bv, Inset::Code code, bool same_content)
+void LyXText::gotoInset(Inset::Code code, bool same_content)
 {
-       gotoInset(bv, vector<Inset::Code>(1, code), same_content);
+       gotoInset(vector<Inset::Code>(1, code), same_content);
 }
 
 
-void LyXText::cursorPrevious(BufferView * bv)
+void LyXText::cursorPrevious()
 {
+       int y = top_y();
+
        if (!cursor.row()->previous()) {
-               if (first_y > 0) {
-                       int new_y = bv->text->first_y - bv->workHeight();
-                       bv->screen().draw(bv->text, bv, new_y < 0 ? 0 : new_y);
-                       bv->updateScrollbar();
+               if (y > 0) {
+                       int new_y = bv()->text->top_y() - bv()->workHeight();
+                       bv()->screen().draw(bv()->text, bv(), new_y < 0 ? 0 : new_y);
+                       bv()->updateScrollbar();
                }
                return;
        }
 
-       int y = first_y;
        Row * cursorrow = cursor.row();
 
-       setCursorFromCoordinates(bv, cursor.x_fix(), y);
+       setCursorFromCoordinates(cursor.x_fix(), y);
        finishUndo();
 
        int new_y;
-       if (cursorrow == bv->text->cursor.row()) {
+       if (cursorrow == bv()->text->cursor.row()) {
                // we have a row which is taller than the workarea. The
                // simplest solution is to move to the previous row instead.
-               cursorUp(bv, true);
+               cursorUp(true);
                return;
                // This is what we used to do, so we wouldn't skip right past
                // tall rows, but it's not working right now.
 #if 0
-               new_y = bv->text->first_y - bv->workHeight();
+               new_y = bv->text->top_y() - bv->workHeight();
 #endif
        } else {
                if (inset_owner) {
-                       new_y = bv->text->cursor.iy()
-                               + bv->theLockingInset()->insetInInsetY() + y
+                       new_y = bv()->text->cursor.iy()
+                               + bv()->theLockingInset()->insetInInsetY() + y
                                + cursor.row()->height()
-                               - bv->workHeight() + 1;
+                               - bv()->workHeight() + 1;
                } else {
                        new_y = cursor.y()
                                - cursor.row()->baseline()
                                + cursor.row()->height()
-                               - bv->workHeight() + 1;
+                               - bv()->workHeight() + 1;
                }
        }
-       bv->screen().draw(bv->text, bv, new_y < 0 ? 0 : new_y);
+       bv()->screen().draw(bv()->text, bv(), new_y < 0 ? 0 : new_y);
        if (cursor.row()->previous()) {
                LyXCursor cur;
-               setCursor(bv, cur, cursor.row()->previous()->par(),
-                                               cursor.row()->previous()->pos(), false);
-               if (cur.y() > first_y) {
-                       cursorUp(bv, true);
+               setCursor(cur, cursor.row()->previous()->par(),
+                         cursor.row()->previous()->pos(), false);
+               if (cur.y() > top_y()) {
+                       cursorUp(true);
                }
        }
-       bv->updateScrollbar();
+       bv()->updateScrollbar();
 }
 
 
-void LyXText::cursorNext(BufferView * bv)
+void LyXText::cursorNext()
 {
+       int topy = top_y();
+
        if (!cursor.row()->next()) {
                int y = cursor.y() - cursor.row()->baseline() +
                        cursor.row()->height();
-               if (y > int(first_y + bv->workHeight())) {
-                       bv->screen().draw(bv->text, bv,
-                                                 bv->text->first_y + bv->workHeight());
-                       bv->updateScrollbar();
+               if (y > topy + bv()->workHeight()) {
+                       bv()->screen().draw(bv()->text, bv(), bv()->text->top_y() + bv()->workHeight());
+                       bv()->updateScrollbar();
                }
                return;
        }
 
-       int y = first_y + bv->workHeight();
-       if (inset_owner && !first_y) {
-               y -= (bv->text->cursor.iy()
-                         - bv->text->first_y
-                         + bv->theLockingInset()->insetInInsetY());
+       int y = topy + bv()->workHeight();
+       if (inset_owner && !topy) {
+               y -= (bv()->text->cursor.iy()
+                         - bv()->text->top_y()
+                         + bv()->theLockingInset()->insetInInsetY());
        }
 
        getRowNearY(y);
 
        Row * cursorrow = cursor.row();
-       setCursorFromCoordinates(bv, cursor.x_fix(), y);
+       setCursorFromCoordinates(cursor.x_fix(), y);
        // + bv->workHeight());
        finishUndo();
 
        int new_y;
-       if (cursorrow == bv->text->cursor.row()) {
+       if (cursorrow == bv()->text->cursor.row()) {
                // we have a row which is taller than the workarea. The
                // simplest solution is to move to the next row instead.
-               cursorDown(bv, true);
+               cursorDown(true);
                return;
                // This is what we used to do, so we wouldn't skip right past
                // tall rows, but it's not working right now.
 #if 0
-               new_y = bv->text->first_y + bv->workHeight();
+               new_y = bv->text->top_y() + bv->workHeight();
 #endif
        } else {
                if (inset_owner) {
-                       new_y = bv->text->cursor.iy()
-                               + bv->theLockingInset()->insetInInsetY()
+                       new_y = bv()->text->cursor.iy()
+                               + bv()->theLockingInset()->insetInInsetY()
                                + y - cursor.row()->baseline();
                } else {
                        new_y =  cursor.y() - cursor.row()->baseline();
                }
        }
-       bv->screen().draw(bv->text, bv, new_y);
+       bv()->screen().draw(bv()->text, bv(), new_y);
        if (cursor.row()->next()) {
                LyXCursor cur;
-               setCursor(bv, cur, cursor.row()->next()->par(),
+               setCursor(cur, cursor.row()->next()->par(),
                                                cursor.row()->next()->pos(), false);
-               if (cur.y() < int(first_y + bv->workHeight())) {
-                       cursorDown(bv, true);
+               if (cur.y() < top_y() + bv()->workHeight()) {
+                       cursorDown(true);
                }
        }
-       bv->updateScrollbar();
+       bv()->updateScrollbar();
 }
 
 
-void LyXText::update(BufferView * bv, bool changed)
+void LyXText::update()
 {
-       BufferView::UpdateCodes c = BufferView::SELECT | BufferView::FITCUR;
-       if (changed)
-               bv->update(this, c | BufferView::CHANGE);
-       else
-               bv->update(this, c);
+       bv()->update(this, BufferView::SELECT);
 }
 
 namespace {
@@ -367,24 +362,25 @@ namespace {
 void specialChar(LyXText * lt, BufferView * bv, InsetSpecialChar::Kind kind)
 {
        bv->hideCursor();
-       lt->update(bv);
+       lt->update();
        InsetSpecialChar * new_inset = new InsetSpecialChar(kind);
        if (!bv->insertInset(new_inset))
                delete new_inset;
        else
-               bv->updateInset(new_inset, true);
+               bv->updateInset(new_inset);
 }
 
+
 void doInsertInset(LyXText * lt, FuncRequest const & cmd,
                   bool edit, bool pastesel)
 {
        Inset * inset = createInset(cmd);
        BufferView * bv = cmd.view();
-       
+
        if (inset) {
                bool gotsel = false;
                if (lt->selection.set()) {
-                       lt->cutSelection(bv, true, false);
+                       lt->cutSelection(true, false);
                        gotsel = true;
                }
                if (bv->insertInset(inset)) {
@@ -396,7 +392,6 @@ void doInsertInset(LyXText * lt, FuncRequest const & cmd,
                else
                        delete inset;
        }
-
 }
 
 }
@@ -420,6 +415,8 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                        if (tmp->params().startOfAppendix()) {
                                setUndo(bv, Undo::EDIT, tmp, tmp->next());
                                tmp->params().startOfAppendix(false);
+                               int tmpy;
+                               setHeightOfRow(getRow(tmp, 0, tmpy));
                                break;
                        }
                }
@@ -428,36 +425,35 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                par->params().startOfAppendix(start);
 
                // we can set the refreshing parameters now
-               status(cmd.view(), LyXText::NEED_MORE_REFRESH);
-               refresh_y = 0;
-               refresh_row = 0; // not needed for full update
-               updateCounters(cmd.view());
-               setCursor(cmd.view(), cursor.par(), cursor.pos());
-               update(bv);
+               updateCounters();
+               redoHeightOfParagraph();
+               postPaint(0);
+               setCursor(cursor.par(), cursor.pos());
+               update();
                break;
        }
 
        case LFUN_DELETE_WORD_FORWARD:
                bv->beforeChange(this);
-               update(bv, false);
-               deleteWordForward(bv);
-               update(bv);
+               update();
+               deleteWordForward();
+               update();
                finishChange(bv);
                break;
 
        case LFUN_DELETE_WORD_BACKWARD:
                bv->beforeChange(this);
-               update(bv, false);
-               deleteWordBackward(bv);
-               update(bv, true);
+               update();
+               deleteWordBackward();
+               update();
                finishChange(bv);
                break;
 
        case LFUN_DELETE_LINE_FORWARD:
                bv->beforeChange(this);
-               update(bv, false);
-               deleteLineForward(bv);
-               update(bv);
+               update();
+               deleteLineForward();
+               update();
                finishChange(bv);
                break;
 
@@ -465,51 +461,51 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
        case LFUN_TAB:
                if (!selection.mark())
                        bv->beforeChange(this);
-               update(bv, false);
-               cursorTab(bv);
+               update();
+               cursorTab();
                finishChange(bv);
                break;
 
        case LFUN_WORDRIGHT:
                if (!selection.mark())
                        bv->beforeChange(this);
-               update(bv, false);
+               update();
                if (cursor.par()->isRightToLeftPar(bv->buffer()->params))
-                       cursorLeftOneWord(bv);
+                       cursorLeftOneWord();
                else
-                       cursorRightOneWord(bv);
+                       cursorRightOneWord();
                finishChange(bv);
                break;
 
        case LFUN_WORDLEFT:
                if (!selection.mark())
                        bv->beforeChange(this);
-               update(bv, false);
+               update();
                if (cursor.par()->isRightToLeftPar(bv->buffer()->params))
-                       cursorRightOneWord(bv);
+                       cursorRightOneWord();
                else
-                       cursorLeftOneWord(bv);
+                       cursorLeftOneWord();
                finishChange(bv);
                break;
 
        case LFUN_BEGINNINGBUF:
                if (!selection.mark())
                        bv->beforeChange(this);
-               update(bv, false);
-               cursorTop(bv);
+               update();
+               cursorTop();
                finishChange(bv);
                break;
 
        case LFUN_ENDBUF:
                if (selection.mark())
                        bv->beforeChange(this);
-               update(bv, false);
-               cursorBottom(bv);
+               update();
+               cursorBottom();
                finishChange(bv);
                break;
 
        case LFUN_RIGHTSEL:
-               update(bv, false);
+               update();
                if (cursor.par()->isRightToLeftPar(bv->buffer()->params))
                        cursorLeft(bv);
                else
@@ -518,7 +514,7 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                break;
 
        case LFUN_LEFTSEL:
-               update(bv, false);
+               update();
                if (cursor.par()->isRightToLeftPar(bv->buffer()->params))
                        cursorRight(bv);
                else
@@ -527,79 +523,79 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                break;
 
        case LFUN_UPSEL:
-               update(bv, false);
-               cursorUp(bv, true);
+               update();
+               cursorUp(true);
                finishChange(bv, true);
                break;
 
        case LFUN_DOWNSEL:
-               update(bv, false);
-               cursorDown(bv, true);
+               update();
+               cursorDown(true);
                finishChange(bv, true);
                break;
 
        case LFUN_UP_PARAGRAPHSEL:
-               update(bv, false);
-               cursorUpParagraph(bv);
+               update();
+               cursorUpParagraph();
                finishChange(bv, true);
                break;
 
        case LFUN_DOWN_PARAGRAPHSEL:
-               update(bv, false);
-               cursorDownParagraph(bv);
+               update();
+               cursorDownParagraph();
                finishChange(bv, true);
                break;
 
        case LFUN_PRIORSEL:
-               update(bv, false);
-               cursorPrevious(bv);
+               update();
+               cursorPrevious();
                finishChange(bv, true);
                break;
 
        case LFUN_NEXTSEL:
-               update(bv, false);
-               cursorNext(bv);
+               update();
+               cursorNext();
                finishChange(bv, true);
                break;
 
        case LFUN_HOMESEL:
-               update(bv, false);
-               cursorHome(bv);
+               update();
+               cursorHome();
                finishChange(bv, true);
                break;
 
        case LFUN_ENDSEL:
-               update(bv, false);
-               cursorEnd(bv);
+               update();
+               cursorEnd();
                finishChange(bv, true);
                break;
 
        case LFUN_WORDRIGHTSEL:
-               update(bv, false);
+               update();
                if (cursor.par()->isRightToLeftPar(bv->buffer()->params))
-                       cursorLeftOneWord(bv);
+                       cursorLeftOneWord();
                else
-                       cursorRightOneWord(bv);
+                       cursorRightOneWord();
                finishChange(bv, true);
                break;
 
        case LFUN_WORDLEFTSEL:
-               update(bv, false);
+               update();
                if (cursor.par()->isRightToLeftPar(bv->buffer()->params))
-                       cursorRightOneWord(bv);
+                       cursorRightOneWord();
                else
-                       cursorLeftOneWord(bv);
+                       cursorLeftOneWord();
                finishChange(bv, true);
                break;
 
        case LFUN_WORDSEL: {
-               update(bv, false);
+               update();
                LyXCursor cur1;
                LyXCursor cur2;
                getWord(cur1, cur2, WHOLE_WORD);
-               setCursor(bv, cur1.par(), cur1.pos());
+               setCursor(cur1.par(), cur1.pos());
                bv->beforeChange(this);
-               setCursor(bv, cur2.par(), cur2.pos());
+               setCursor(cur2.par(), cur2.pos());
                finishChange(bv, true);
                break;
        }
@@ -608,9 +604,9 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                bool is_rtl = cursor.par()->isRightToLeftPar(bv->buffer()->params);
                if (!selection.mark())
                        bv->beforeChange(this);
-               update(bv, false);
+               update();
                if (is_rtl)
-                       cursorLeft(bv, false);
+                       cursorLeft(false);
                if (cursor.pos() < cursor.par()->size()
                    && cursor.par()->isInset(cursor.pos())
                    && isHighlyEditableInset(cursor.par()->getInset(cursor.pos()))) {
@@ -620,7 +616,7 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                        break;
                }
                if (!is_rtl)
-                       cursorRight(bv, false);
+                       cursorRight(false);
                finishChange(bv);
                break;
        }
@@ -631,10 +627,10 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                bool const is_rtl = cursor.par()->isRightToLeftPar(bv->buffer()->params);
                if (!selection.mark())
                        bv->beforeChange(this);
-               update(bv, false);
+               update();
                LyXCursor const cur = cursor;
                if (!is_rtl)
-                       cursorLeft(bv, false);
+                       cursorLeft(false);
                if ((is_rtl || cur != cursor) && // only if really moved!
                    cursor.pos() < cursor.par()->size() &&
                    cursor.par()->isInset(cursor.pos()) &&
@@ -645,7 +641,7 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                        break;
                }
                if (is_rtl)
-                       cursorRight(bv, false);
+                       cursorRight(false);
                finishChange(bv);
                break;
        }
@@ -670,7 +666,7 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                if (!selection.mark())
                        bv->beforeChange(this);
                bv->update(this, BufferView::UPDATE);
-               cursorUpParagraph(bv);
+               cursorUpParagraph();
                finishChange(bv);
                break;
 
@@ -678,7 +674,7 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                if (!selection.mark())
                        bv->beforeChange(this);
                bv->update(this, BufferView::UPDATE);
-               cursorDownParagraph(bv);
+               cursorDownParagraph();
                finishChange(bv, false);
                break;
 
@@ -686,7 +682,7 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                if (!selection.mark())
                        bv->beforeChange(this);
                bv->update(this, BufferView::UPDATE);
-               cursorPrevious(bv);
+               cursorPrevious();
                finishChange(bv, false);
                // was:
                // finishUndo();
@@ -698,46 +694,53 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                if (!selection.mark())
                        bv->beforeChange(this);
                bv->update(this, BufferView::UPDATE);
-               cursorNext(bv);
+               cursorNext();
                finishChange(bv, false);
                break;
 
        case LFUN_HOME:
                if (!selection.mark())
                        bv->beforeChange(this);
-               update(bv);
-               cursorHome(bv);
+               update();
+               cursorHome();
                finishChange(bv, false);
                break;
 
        case LFUN_END:
                if (!selection.mark())
                        bv->beforeChange(this);
-               update(bv);
-               cursorEnd(bv);
+               update();
+               cursorEnd();
                finishChange(bv, false);
                break;
 
-       case LFUN_BREAKLINE:
+       case LFUN_BREAKLINE: {
+               lyx::pos_type body = cursor.par()->beginningOfBody();
+
+               // Not allowed by LaTeX (labels or empty par)
+               if (cursor.pos() <= body)
+                       break;
+
                bv->beforeChange(this);
-               insertChar(bv, Paragraph::META_NEWLINE);
-               update(bv, true);
-               setCursor(bv, cursor.par(), cursor.pos());
+               insertInset(new InsetNewline);
+               update();
+               setCursor(cursor.par(), cursor.pos());
                moveCursorUpdate(bv, false);
                break;
+       }
 
        case LFUN_DELETE:
                if (!selection.set()) {
-                       Delete(bv);
+                       Delete();
                        selection.cursor = cursor;
-                       update(bv);
+                       update();
                        // It is possible to make it a lot faster still
                        // just comment out the line below...
                        bv->showCursor();
                } else {
-                       update(bv, false);
+                       update();
                        cutSelection(bv, true);
-                       update(bv);
+                       update();
                }
                moveCursorUpdate(bv, false);
                bv->owner()->view_state_changed();
@@ -754,7 +757,7 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                                if (cur.pos() == 0
                                    && !(cur.par()->params().spaceTop()
                                         == VSpace (VSpace::NONE))) {
-                                       setParagraph(bv,
+                                       setParagraph(
                                                 cur.par()->params().lineTop(),
                                                 cur.par()->params().lineBottom(),
                                                 cur.par()->params().pagebreakTop(),
@@ -765,38 +768,38 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                                                 cur.par()->params().align(),
                                                 cur.par()->params().labelWidthString(), 0);
                                        cursorLeft(bv);
-                                       update(bv);
+                                       update();
                                } else {
                                        cursorLeft(bv);
-                                       Delete(bv);
+                                       Delete();
                                        selection.cursor = cursor;
                                }
                        } else {
-                               Delete(bv);
+                               Delete();
                                selection.cursor = cursor;
                        }
                } else {
-                       update(bv, false);
+                       update();
                        cutSelection(bv, true);
                }
-               update(bv);
+               update();
                break;
 
 
        case LFUN_BACKSPACE:
                if (!selection.set()) {
                        if (bv->owner()->getIntl().getTransManager().backspace()) {
-                               backspace(bv);
+                               backspace();
                                selection.cursor = cursor;
-                               update(bv);
+                               update();
                                // It is possible to make it a lot faster still
                                // just comment out the line below...
                                bv->showCursor();
                        }
                } else {
-                       update(bv, false);
+                       update();
                        cutSelection(bv, true);
-                       update(bv);
+                       update();
                }
                bv->owner()->view_state_changed();
                bv->switchKeyMap();
@@ -809,7 +812,7 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                        if (cur.pos() == 0
                            && !(cur.par()->params().spaceTop()
                                 == VSpace (VSpace::NONE))) {
-                               setParagraph(bv,
+                               setParagraph(
                                         cur.par()->params().lineTop(),
                                         cur.par()->params().lineBottom(),
                                         cur.par()->params().pagebreakTop(),
@@ -819,20 +822,20 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                                         cur.par()->params().align(),
                                         cur.par()->params().labelWidthString(), 0);
                        } else {
-                               backspace(bv);
+                               backspace();
                                selection.cursor = cur;
                        }
                } else {
-                       update(bv, false);
+                       update();
                        cutSelection(bv, true);
                }
-               update(bv);
+               update();
                break;
 
        case LFUN_BREAKPARAGRAPH:
                bv->beforeChange(this);
-               breakParagraph(bv, 0);
-               update(bv);
+               breakParagraph(bv->buffer()->paragraphs, 0);
+               update();
                selection.cursor = cursor;
                bv->switchKeyMap();
                bv->owner()->view_state_changed();
@@ -840,8 +843,8 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
 
        case LFUN_BREAKPARAGRAPHKEEPLAYOUT:
                bv->beforeChange(this);
-               breakParagraph(bv, 1);
-               update(bv);
+               breakParagraph(bv->buffer()->paragraphs, 1);
+               update();
                selection.cursor = cursor;
                bv->switchKeyMap();
                bv->owner()->view_state_changed();
@@ -855,7 +858,7 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                bv->beforeChange(this);
                if (cur.pos() == 0) {
                        if (cur.par()->params().spaceTop() == VSpace(VSpace::NONE)) {
-                               setParagraph(bv,
+                               setParagraph(
                                         cur.par()->params().lineTop(),
                                         cur.par()->params().lineBottom(),
                                         cur.par()->params().pagebreakTop(),
@@ -864,14 +867,12 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                                         cur.par()->params().spacing(),
                                         cur.par()->params().align(),
                                         cur.par()->params().labelWidthString(), 1);
-                               //update(bv);
                        }
                }
                else {
-                       breakParagraph(bv, 0);
-                       //update(bv);
+                       breakParagraph(bv->buffer()->paragraphs, 0);
                }
-               update(bv);
+               update();
                selection.cursor = cur;
                bv->switchKeyMap();
                bv->owner()->view_state_changed();
@@ -914,8 +915,8 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                }
                if (cur_spacing != new_spacing || cur_value != new_value) {
                        par->params().spacing(Spacing(new_spacing, new_value));
-                       redoParagraph(bv);
-                       update(bv);
+                       redoParagraph();
+                       update();
                }
                break;
        }
@@ -923,16 +924,16 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
        case LFUN_INSET_TOGGLE:
                bv->hideCursor();
                bv->beforeChange(this);
-               update(bv, false);
-               toggleInset(bv);
-               update(bv, false);
+               update();
+               toggleInset();
+               update();
                bv->switchKeyMap();
                break;
 
        case LFUN_PROTECTEDSPACE:
                if (cursor.par()->layout()->free_spacing) {
-                       insertChar(bv, ' ');
-                       update(bv);
+                       insertChar(' ');
+                       update();
                } else {
                        specialChar(this, bv, InsetSpecialChar::PROTECTED_SEPARATOR);
                }
@@ -951,13 +952,6 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                specialChar(this, bv, InsetSpecialChar::LDOTS);
                break;
 
-       case LFUN_HFILL:
-               bv->hideCursor();
-               update(bv, false);
-               insertChar(bv, Paragraph::META_HFILL);
-               update(bv);
-               break;
-
        case LFUN_END_OF_SENTENCE:
                specialChar(this, bv, InsetSpecialChar::END_OF_SENTENCE);
                break;
@@ -968,7 +962,7 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
 
        case LFUN_MARK_OFF:
                bv->beforeChange(this);
-               update(bv, false);
+               update();
                selection.cursor = cursor;
                cmd.message(N_("Mark off"));
                break;
@@ -976,7 +970,7 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
        case LFUN_MARK_ON:
                bv->beforeChange(this);
                selection.mark(true);
-               update(bv, false);
+               update();
                selection.cursor = cursor;
                cmd.message(N_("Mark on"));
                break;
@@ -984,46 +978,46 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
        case LFUN_SETMARK:
                bv->beforeChange(this);
                if (selection.mark()) {
-                       update(bv);
+                       update();
                        cmd.message(N_("Mark removed"));
                } else {
                        selection.mark(true);
-                       update(bv);
+                       update();
                        cmd.message(N_("Mark set"));
                }
                selection.cursor = cursor;
                break;
 
        case LFUN_UPCASE_WORD:
-               update(bv, false);
-               changeCase(bv, LyXText::text_uppercase);
+               update();
+               changeCase(LyXText::text_uppercase);
                if (inset_owner)
-                       bv->updateInset(inset_owner, true);
-               update(bv);
+                       bv->updateInset(inset_owner);
+               update();
                break;
 
        case LFUN_LOWCASE_WORD:
-               update(bv, false);
-               changeCase(bv, LyXText::text_lowercase);
+               update();
+               changeCase(LyXText::text_lowercase);
                if (inset_owner)
-                       bv->updateInset(inset_owner, true);
-               update(bv);
+                       bv->updateInset(inset_owner);
+               update();
                break;
 
        case LFUN_CAPITALIZE_WORD:
-               update(bv, false);
-               changeCase(bv, LyXText::text_capitalization);
+               update();
+               changeCase(LyXText::text_capitalization);
                if (inset_owner)
-                       bv->updateInset(inset_owner, true);
-               update(bv);
+                       bv->updateInset(inset_owner);
+               update();
                break;
 
        case LFUN_TRANSPOSE_CHARS:
-               update(bv, false);
-               transposeChars(*bv);
+               update();
+               transposeChars();
                if (inset_owner)
-                       bv->updateInset(inset_owner, true);
-               update(bv);
+                       bv->updateInset(inset_owner);
+               update();
                break;
 
        case LFUN_PASTE:
@@ -1032,40 +1026,39 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                // clear the selection
                bv->toggleSelection();
                clearSelection();
-               update(bv, false);
-               pasteSelection(bv);
+               update();
+               pasteSelection();
                clearSelection(); // bug 393
-               update(bv, false);
-               update(bv);
+               update();
                bv->switchKeyMap();
                break;
 
        case LFUN_CUT:
                bv->hideCursor();
-               update(bv, false);
+               update();
                cutSelection(bv, true);
-               update(bv);
+               update();
                cmd.message(_("Cut"));
                break;
 
        case LFUN_COPY:
-               copySelection(bv);
+               copySelection();
                cmd.message(_("Copy"));
                break;
 
        case LFUN_BEGINNINGBUFSEL:
                if (inset_owner)
-                       return Inset::UNDISPATCHED;
-               update(bv, false);
-               cursorTop(bv);
+                       return UNDISPATCHED;
+               update();
+               cursorTop();
                finishChange(bv, true);
                break;
 
        case LFUN_ENDBUFSEL:
                if (inset_owner)
-                       return Inset::UNDISPATCHED;
-               update(bv, false);
-               cursorBottom(bv);
+                       return UNDISPATCHED;
+               update();
+               cursorBottom();
                finishChange(bv, true);
                break;
 
@@ -1082,7 +1075,7 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                        lyxerr << "SETXY: Could not parse coordinates in '"
                               << cmd.argument << std::endl;
                else
-                       setCursorFromCoordinates(bv, x, y);
+                       setCursorFromCoordinates(x, y);
                break;
        }
 
@@ -1149,10 +1142,10 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                if (change_layout) {
                        bv->hideCursor();
                        current_layout = layout;
-                       update(bv, false);
-                       setLayout(bv, layout);
+                       update();
+                       setLayout(layout);
                        bv->owner()->setLayout(layout);
-                       update(bv);
+                       update();
                        bv->switchKeyMap();
                }
                break;
@@ -1168,21 +1161,21 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                string const clip = bv->getClipboard();
                if (!clip.empty()) {
                        if (cmd.argument == "paragraph")
-                               insertStringAsParagraphs(bv, clip);
+                               insertStringAsParagraphs(clip);
                        else
-                               insertStringAsLines(bv, clip);
+                               insertStringAsLines(clip);
                        clearSelection();
-                       update(bv);
+                       update();
                }
                break;
        }
 
        case LFUN_GOTOERROR:
-               gotoInset(bv, Inset::ERROR_CODE, false);
+               gotoInset(Inset::ERROR_CODE, false);
                break;
 
        case LFUN_GOTONOTE:
-               gotoInset(bv, Inset::NOTE_CODE, false);
+               gotoInset(Inset::NOTE_CODE, false);
                break;
 
        case LFUN_REFERENCE_GOTO:
@@ -1190,7 +1183,7 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                vector<Inset::Code> tmp;
                tmp.push_back(Inset::LABEL_CODE);
                tmp.push_back(Inset::REF_CODE);
-               gotoInset(bv, tmp, true);
+               gotoInset(tmp, true);
                break;
        }
 
@@ -1230,8 +1223,8 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                        ::strftime(datetmp, 32, arg.c_str(), now_tm);
 
                for (int i = 0; i < datetmp_len; i++) {
-                       insertChar(bv, datetmp[i]);
-                       update(bv, true);
+                       insertChar(datetmp[i]);
+                       update();
                }
                selection.cursor = cursor;
                moveCursorUpdate(bv, false);
@@ -1241,20 +1234,20 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
        case LFUN_MOUSE_TRIPLE:
                if (!bv->buffer())
                        break;
-               if (isTopLevel() && bv->theLockingInset())
+               if (!isInInset() && bv->theLockingInset())
                        break;
                if (cmd.button() == mouse_button::button1) {
-                       if (isTopLevel()) {
+                       if (!isInInset()) {
                                bv->screen().hideCursor();
                                bv->screen().toggleSelection(this, bv);
                        }
-                       cursorHome(bv);
+                       cursorHome();
                        selection.cursor = cursor;
-                       cursorEnd(bv);
-                       setSelection(bv);
-                       if (isTopLevel())
+                       cursorEnd();
+                       setSelection();
+                       if (!isInInset())
                                bv->screen().toggleSelection(this, bv, false);
-                       update(bv, false);
+                       update();
                        bv->haveSelection(selection.set());
                }
                break;
@@ -1262,18 +1255,18 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
        case LFUN_MOUSE_DOUBLE:
                if (!bv->buffer())
                        break;
-               if (isTopLevel() && bv->theLockingInset())
+               if (!isInInset() && bv->theLockingInset())
                        break;
                if (cmd.button() == mouse_button::button1) {
-                       if (isTopLevel()) {
+                       if (!isInInset()) {
                                bv->screen().hideCursor();
                                bv->screen().toggleSelection(this, bv);
-                               selectWord(bv, LyXText::WHOLE_WORD_STRICT);
+                               selectWord(LyXText::WHOLE_WORD_STRICT);
                                bv->screen().toggleSelection(this, bv, false);
                        } else {
-                               selectWord(bv, LyXText::WHOLE_WORD_STRICT);
+                               selectWord(LyXText::WHOLE_WORD_STRICT);
                        }
-                       update(bv, false);
+                       update();
                        bv->haveSelection(selection.set());
                }
                break;
@@ -1299,7 +1292,7 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                        int start_x = inset_x + tli->scroll();
                        FuncRequest cmd1 = cmd;
                        cmd1.x = cmd.x - start_x;
-                       cmd1.y = cmd.y - cursor.iy() + bv->text->first_y;
+                       cmd1.y = cmd.y - cursor.iy() + bv->text->top_y();
                        tli->localDispatch(cmd1);
                        break;
                }
@@ -1316,7 +1309,7 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                bv->screen().hideCursor();
 
                Row * cursorrow = bv->text->cursor.row();
-               bv->text->setCursorFromCoordinates(bv, cmd.x, cmd.y + bv->text->first_y);
+               bv->text->setCursorFromCoordinates(cmd.x, cmd.y + bv->text->top_y());
        #if 0
                // sorry for this but I have a strange error that the y value jumps at
                // a certain point. This seems like an error in my xforms library or
@@ -1328,16 +1321,16 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
        #endif
                // This is to allow jumping over large insets
                if (cursorrow == bv->text->cursor.row()) {
-                       if (cmd.y >= int(bv->workHeight()))
-                               bv->text->cursorDown(bv, false);
+                       if (cmd.y >= bv->workHeight())
+                               bv->text->cursorDown(false);
                        else if (cmd.y < 0)
-                               bv->text->cursorUp(bv, false);
+                               bv->text->cursorUp(false);
                }
 
                // Maybe an empty line was deleted
                if (!bv->text->selection.set())
-                       bv->update(bv->text, BufferView::UPDATE);
-               bv->text->setSelection(bv);
+                       bv->update(BufferView::UPDATE);
+               bv->text->setSelection();
                bv->screen().toggleToggle(bv->text, bv);
                bv->fitCursor();
                bv->showCursor();
@@ -1365,7 +1358,7 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
 
                int x = cmd.x;
                int y = cmd.y;
-               Inset * inset_hit = bv->text->checkInsetHit(bv, x, y);
+               Inset * inset_hit = bv->text->checkInsetHit(x, y);
 
                // Middle button press pastes if we have a selection
                // We do this here as if the selection was inside an inset
@@ -1377,7 +1370,7 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                        paste_internally = true;
                }
 
-               int const screen_first = bv->text->first_y;
+               int const screen_first = bv->text->top_y();
 
                if (bv->theLockingInset()) {
                        // We are in inset locking mode
@@ -1399,7 +1392,7 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                // Clear the selection
                bv->screen().toggleSelection(bv->text, bv);
                bv->text->clearSelection();
-               bv->text->fullRebreak(bv);
+               bv->text->fullRebreak();
                bv->update();
                bv->updateScrollbar();
 
@@ -1408,7 +1401,6 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                        // Highly editable inset, like math
                        UpdatableInset * inset = static_cast<UpdatableInset *>(inset_hit);
                        selection_possible = false;
-                       bv->owner()->updateLayoutChoice();
                        bv->owner()->message(inset->editMessage());
                        //inset->edit(bv, x, y, cmd.button());
                        // We just have to lock the inset before calling a PressEvent on it!
@@ -1428,12 +1420,11 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                }
 
                if (!inset_hit) // otherwise it was already set in checkInsetHit(...)
-                       bv->text->setCursorFromCoordinates(bv, x, y + screen_first);
+                       bv->text->setCursorFromCoordinates(x, y + screen_first);
                finishUndo();
                bv->text->selection.cursor = bv->text->cursor;
                bv->text->cursor.x_fix(bv->text->cursor.x());
 
-               bv->owner()->updateLayoutChoice();
                if (bv->fitCursor())
                        selection_possible = false;
 
@@ -1465,7 +1456,7 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                // inset, inset_hit is 0, and inset_x == x, inset_y == y.
                int x = cmd.x;
                int y = cmd.y;
-               Inset * inset_hit = bv->text->checkInsetHit(bv, x, y);
+               Inset * inset_hit = bv->text->checkInsetHit(x, y);
 
                if (bv->theLockingInset()) {
                        // We are in inset locking mode.
@@ -1530,37 +1521,10 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
 
                        bv->owner()->message(inset_hit->editMessage());
 
-                       if (isHighlyEditableInset(inset_hit)) {
-                               // Highly editable inset, like math
-                               UpdatableInset * inset = (UpdatableInset *) inset_hit;
-                               FuncRequest cmd1(bv, LFUN_MOUSE_RELEASE, x, y, cmd.button());
-                               inset->localDispatch(cmd1);
-                       } else {
-                               FuncRequest cmd1(bv, LFUN_MOUSE_RELEASE, x, y, cmd.button());
-                               inset_hit->localDispatch(cmd1);
-                               // IMO this is a grosshack! Inset's should be changed so that
-                               // they call the actions they have to do with the insetButtonRel.
-                               // function and not in the edit(). This should be changed
-                               // (Jug 20020329)
-#ifdef WITH_WARNINGS
-#warning Please remove donot call inset->edit() here (Jug 20020812)
-#endif
-                               inset_hit->edit(bv, x, y, cmd.button());
-                       }
-                       break;
+                       FuncRequest cmd1(bv, LFUN_MOUSE_RELEASE, x, y, cmd.button());
+                       inset_hit->localDispatch(cmd1);
                }
 
-               // Maybe we want to edit a bibitem ale970302
-               if (bv->text->cursor.par()->bibkey) {
-                       bool const is_rtl =
-                               bv->text->cursor.par()->isRightToLeftPar(bv->buffer()->params);
-                       int const width =
-                               bibitemMaxWidth(bv, bv->buffer()->params.getLyXTextClass().defaultfont());
-                       if ((is_rtl && x > bv->text->workWidth(bv)-20-width) ||
-                                       (!is_rtl && x < 20 + width)) {
-                               bv->text->cursor.par()->bibkey->edit(bv, 0, 0, mouse_button::none);
-                       }
-               }
                break;
        }
 
@@ -1576,8 +1540,8 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
 
                if (lyxrc.auto_region_delete) {
                        if (selection.set()) {
-                               cutSelection(bv, false, false);
-                               update(bv);
+                               cutSelection(false, false);
+                               update();
                        }
                        bv->haveSelection(false);
                }
@@ -1591,7 +1555,7 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
                        bv->owner()->getIntl().getTransManager().
                                TranslateAndInsert(*cit, this);
 
-               update(bv);
+               update();
                selection.cursor = cursor;
                moveCursorUpdate(bv, false);
 
@@ -1604,13 +1568,15 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
 
        case LFUN_HTMLURL: {
                InsetCommandParams p("htmlurl");
-               bv->owner()->getDialogs().createUrl(p.getAsString());
+               string const data = InsetCommandMailer::params2string("url", p);
+               bv->owner()->getDialogs().show("url", data, 0);
                break;
        }
 
        case LFUN_URL: {
                InsetCommandParams p("url");
-               bv->owner()->getDialogs().createUrl(p.getAsString());
+               string const data = InsetCommandMailer::params2string("url", p);
+               bv->owner()->getDialogs().show("url", data, 0);
                break;
        }
 
@@ -1621,6 +1587,7 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
        case LFUN_INSET_CAPTION:
 #endif
        case LFUN_INSERT_NOTE:
+       case LFUN_INSERT_BIBITEM:
        case LFUN_INSET_ERT:
        case LFUN_INSET_FLOAT:
        case LFUN_INSET_FOOTNOTE:
@@ -1630,13 +1597,12 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
        case LFUN_INSET_WIDE_FLOAT:
        case LFUN_INSET_WRAP:
        case LFUN_TABULAR_INSERT:
+       case LFUN_ENVIRONMENT_INSERT:
                // Open the inset, and move the current selection
                // inside it.
                doInsertInset(this, cmd, true, true);
                break;
 
-       case LFUN_INSERT_URL:
-       case LFUN_INSET_EXTERNAL:
        case LFUN_INDEX_INSERT:
                // Just open the inset
                doInsertInset(this, cmd, true, false);
@@ -1645,13 +1611,14 @@ Inset::RESULT LyXText::dispatch(FuncRequest const & cmd)
        case LFUN_INDEX_PRINT:
        case LFUN_PARENTINSERT:
        case LFUN_TOC_INSERT:
+       case LFUN_HFILL:
                // do nothing fancy
                doInsertInset(this, cmd, false, false);
                break;
 
        default:
-               return Inset::UNDISPATCHED;
+               return UNDISPATCHED;
        }
 
-       return Inset::DISPATCHED;
+       return DISPATCHED;
 }