]> git.lyx.org Git - lyx.git/blobdiff - src/text2.C
zlib stuff
[lyx.git] / src / text2.C
index d183f53934bc81bd4b4f3956ca8ab179dfc3208a..fa968541e5294da887276551395f116d2c458dd2 100644 (file)
@@ -34,6 +34,7 @@
 #include "ParagraphParameters.h"
 #include "counters.h"
 #include "lyxrow_funcs.h"
+#include "metricsinfo.h"
 #include "paragraph_funcs.h"
 
 #include "insets/insetbibitem.h"
@@ -47,6 +48,8 @@
 
 #include <boost/tuple/tuple.hpp>
 
+#include <algorithm>
+
 using namespace lyx::support;
 
 using std::vector;
@@ -62,7 +65,6 @@ LyXText::LyXText(BufferView * bv)
          inset_owner(0), the_locking_inset(0), bv_owner(bv)
 {
        anchor_row_ = rows().end();
-       need_break_row = rows().end();
        need_refresh_ = true;
 }
 
@@ -72,7 +74,6 @@ LyXText::LyXText(BufferView * bv, InsetText * inset)
          inset_owner(inset), the_locking_inset(0), bv_owner(bv)
 {
        anchor_row_ = rows().end();
-       need_break_row = rows().end();
        need_refresh_ = true;
 }
 
@@ -82,7 +83,6 @@ void LyXText::init(BufferView * bview)
        bv_owner = bview;
 
        rowlist_.clear();
-       need_break_row = rows().end();
        width = height = 0;
        need_refresh_ = true;
 
@@ -92,7 +92,7 @@ void LyXText::init(BufferView * bview)
        ParagraphList::iterator pit = ownerParagraphs().begin();
        ParagraphList::iterator end = ownerParagraphs().end();
 
-       current_font = getFont(bview->buffer(), pit, 0);
+       current_font = getFont(pit, 0);
 
        for (; pit != end; ++pit)
                insertParagraph(pit, rowlist_.end());
@@ -111,24 +111,25 @@ void LyXText::init(BufferView * bview)
 // smaller. (Asger)
 // If position is -1, we get the layout font of the paragraph.
 // If position is -2, we get the font of the manual label of the paragraph.
-LyXFont const LyXText::getFont(Buffer const * buf, ParagraphList::iterator pit,
-                              pos_type pos) const
+LyXFont LyXText::getFont(ParagraphList::iterator pit, pos_type pos) const
 {
        Assert(pos >= 0);
 
        LyXLayout_ptr const & layout = pit->layout();
+#warning broken?
+       BufferParams const & params = bv()->buffer()->params;
 
        // We specialize the 95% common case:
        if (!pit->getDepth()) {
                if (layout->labeltype == LABEL_MANUAL
                    && pos < pit->beginningOfBody()) {
                        // 1% goes here
-                       LyXFont f = pit->getFontSettings(buf->params, pos);
+                       LyXFont f = pit->getFontSettings(params, pos);
                        if (pit->inInset())
                                pit->inInset()->getDrawFont(f);
                        return f.realize(layout->reslabelfont);
                } else {
-                       LyXFont f = pit->getFontSettings(buf->params, pos);
+                       LyXFont f = pit->getFontSettings(params, pos);
                        if (pit->inInset())
                                pit->inInset()->getDrawFont(f);
                        return f.realize(layout->resfont);
@@ -147,7 +148,7 @@ LyXFont const LyXText::getFont(Buffer const * buf, ParagraphList::iterator pit,
                layoutfont = layout->font;
        }
 
-       LyXFont tmpfont = pit->getFontSettings(buf->params, pos);
+       LyXFont tmpfont = pit->getFontSettings(params, pos);
        tmpfont.realize(layoutfont);
 
        if (pit->inInset())
@@ -155,13 +156,13 @@ LyXFont const LyXText::getFont(Buffer const * buf, ParagraphList::iterator pit,
 
        // Realize with the fonts of lesser depth.
        tmpfont.realize(outerFont(pit, ownerParagraphs()));
+       //tmpfont.realize(defaultfont_);
 
-       return realizeFont(tmpfont, buf->params);
+       return tmpfont;
 }
 
 
-LyXFont const LyXText::getLayoutFont(Buffer const * buf,
-                                    ParagraphList::iterator pit) const
+LyXFont LyXText::getLayoutFont(ParagraphList::iterator pit) const
 {
        LyXLayout_ptr const & layout = pit->layout();
 
@@ -169,16 +170,16 @@ LyXFont const LyXText::getLayoutFont(Buffer const * buf,
                return layout->resfont;
        }
 
-       LyXFont font(layout->font);
+       LyXFont font = layout->font;
        // Realize with the fonts of lesser depth.
        font.realize(outerFont(pit, ownerParagraphs()));
+       //font.realize(defaultfont_);
 
-       return realizeFont(font, buf->params);
+       return font;
 }
 
 
-LyXFont const LyXText::getLabelFont(Buffer const * buf,
-                                   ParagraphList::iterator pit) const
+LyXFont LyXText::getLabelFont(ParagraphList::iterator pit) const
 {
        LyXLayout_ptr const & layout = pit->layout();
 
@@ -186,11 +187,12 @@ LyXFont const LyXText::getLabelFont(Buffer const * buf,
                return layout->reslabelfont;
        }
 
-       LyXFont font(layout->labelfont);
+       LyXFont font = layout->labelfont;
        // Realize with the fonts of lesser depth.
        font.realize(outerFont(pit, ownerParagraphs()));
+       //font.realize(defaultfont_);
 
-       return realizeFont(layout->labelfont, buf->params);
+       return font;
 }
 
 
@@ -198,30 +200,27 @@ void LyXText::setCharFont(ParagraphList::iterator pit,
                          pos_type pos, LyXFont const & fnt,
                          bool toggleall)
 {
-       Buffer const * buf = bv()->buffer();
-       LyXFont font = getFont(buf, pit, pos);
-       font.update(fnt, buf->params.language, toggleall);
+       BufferParams const & params = bv()->buffer()->params;
+       LyXFont font = getFont(pit, pos);
+       font.update(fnt, params.language, toggleall);
        // Let the insets convert their font
        if (pit->isInset(pos)) {
-               Inset * inset = pit->getInset(pos);
+               InsetOld * inset = pit->getInset(pos);
                if (isEditableInset(inset)) {
-                       UpdatableInset * uinset =
-                               static_cast<UpdatableInset *>(inset);
-                       uinset->setFont(bv(), fnt, toggleall, true);
+                       static_cast<UpdatableInset *>(inset)
+                               ->setFont(bv(), fnt, toggleall, true);
                }
        }
 
-       // Plug thru to version below:
-       setCharFont(buf, pit, pos, font);
+       // Plug through to version below:
+       setCharFont(pit, pos, font);
 }
 
 
-void LyXText::setCharFont(Buffer const * buf, ParagraphList::iterator pit,
-                         pos_type pos, LyXFont const & fnt)
+void LyXText::setCharFont(
+       ParagraphList::iterator pit, pos_type pos, LyXFont const & fnt)
 {
-       LyXFont font(fnt);
-
-       LyXTextClass const & tclass = buf->params.getLyXTextClass();
+       LyXFont font = fnt;
        LyXLayout_ptr const & layout = pit->layout();
 
        // Get concrete layout font to reduce against
@@ -244,7 +243,7 @@ void LyXText::setCharFont(Buffer const * buf, ParagraphList::iterator pit,
                }
        }
 
-       layoutfont.realize(tclass.defaultfont());
+       //layoutfont.realize(defaultfont_);
 
        // Now, reduce font against full layout font
        font.reduce(layoutfont);
@@ -299,7 +298,7 @@ void LyXText::insertParagraph(ParagraphList::iterator pit,
 }
 
 
-Inset * LyXText::getInset() const
+InsetOld * LyXText::getInset() const
 {
        ParagraphList::iterator pit = cursor.par();
        pos_type const pos = cursor.pos();
@@ -313,7 +312,7 @@ Inset * LyXText::getInset() const
 
 void LyXText::toggleInset()
 {
-       Inset * inset = getInset();
+       InsetOld * inset = getInset();
        // is there an editable inset at cursor position?
        if (!isEditableInset(inset)) {
                // No, try to see if we are inside a collapsable inset
@@ -329,7 +328,7 @@ void LyXText::toggleInset()
 
        // do we want to keep this?? (JMarc)
        if (!isHighlyEditableInset(inset))
-               setCursorParUndo(bv());
+               recordUndo(bv(), Undo::ATOMIC);
 
        if (inset->isOpen()) {
                inset->close(bv());
@@ -343,7 +342,7 @@ void LyXText::toggleInset()
 
 /* used in setlayout */
 // Asger is not sure we want to do this...
-void LyXText::makeFontEntriesLayoutSpecific(Buffer const & buf,
+void LyXText::makeFontEntriesLayoutSpecific(BufferParams const & params,
                                            Paragraph & par)
 {
        LyXLayout_ptr const & layout = par.layout();
@@ -356,7 +355,7 @@ void LyXText::makeFontEntriesLayoutSpecific(Buffer const & buf,
                else
                        layoutfont = layout->font;
 
-               LyXFont tmpfont = par.getFontSettings(buf.params, pos);
+               LyXFont tmpfont = par.getFontSettings(params, pos);
                tmpfont.reduce(layoutfont);
                par.setFont(pos, tmpfont);
        }
@@ -382,7 +381,7 @@ LyXText::setLayout(LyXCursor & cur, LyXCursor & sstart_cur,
                ++endpit;
        }
 
-       setUndo(bv(), Undo::EDIT, sstart_cur.par(), boost::prior(undoendpit));
+       recordUndo(bv(), Undo::ATOMIC, sstart_cur.par(), boost::prior(undoendpit));
 
        // ok we have a selection. This is always between sstart_cur
        // and sel_end cursor
@@ -395,7 +394,7 @@ LyXText::setLayout(LyXCursor & cur, LyXCursor & sstart_cur,
 
        do {
                pit->applyLayout(lyxlayout);
-               makeFontEntriesLayoutSpecific(*bv()->buffer(), *pit);
+               makeFontEntriesLayoutSpecific(bv()->buffer()->params, *pit);
                ParagraphList::iterator fppit = pit;
                fppit->params().spaceTop(lyxlayout->fill_top ?
                                         VSpace(VSpace::VFILL)
@@ -434,7 +433,7 @@ void LyXText::setLayout(string const & layout)
                bv()->owner()->dispatch(FuncRequest(LFUN_HOME));
                bv()->owner()->dispatch(FuncRequest(LFUN_ENDSEL));
                bv()->owner()->dispatch(FuncRequest(LFUN_CUT));
-               Inset * inset = new InsetEnvironment(params, layout);
+               InsetOld * inset = new InsetEnvironment(params, layout);
                if (bv()->insertInset(inset)) {
                        //inset->edit(bv());
                        //bv()->owner()->dispatch(FuncRequest(LFUN_PASTE));
@@ -475,7 +474,7 @@ bool LyXText::changeDepth(bv_funcs::DEPTH_CHANGE type, bool test_only)
        ParagraphList::iterator pastend = boost::next(end);
 
        if (!test_only)
-               setUndo(bv(), Undo::EDIT, start, end);
+               recordUndo(bv(), Undo::ATOMIC, start, end);
 
        bool changed = false;
 
@@ -551,11 +550,9 @@ void LyXText::setFont(LyXFont const & font, bool toggleall)
                // Determine basis font
                LyXFont layoutfont;
                if (cursor.pos() < cursor.par()->beginningOfBody()) {
-                       layoutfont = getLabelFont(bv()->buffer(),
-                                                 cursor.par());
+                       layoutfont = getLabelFont(cursor.par());
                } else {
-                       layoutfont = getLayoutFont(bv()->buffer(),
-                                                  cursor.par());
+                       layoutfont = getLayoutFont(cursor.par());
                }
                // Update current font
                real_current_font.update(font,
@@ -576,7 +573,7 @@ void LyXText::setFont(LyXFont const & font, bool toggleall)
        // ok we have a selection. This is always between sel_start_cursor
        // and sel_end cursor
 
-       setUndo(bv(), Undo::EDIT, selection.start.par(), selection.end.par());
+       recordUndo(bv(), Undo::ATOMIC, selection.start.par(), selection.end.par());
        freezeUndo();
        cursor = selection.start;
        while (cursor.par() != selection.end.par() ||
@@ -692,10 +689,12 @@ void LyXText::fullRebreak()
 }
 
 
-void LyXText::rebuild()
+void LyXText::metrics(MetricsInfo & mi, Dimension & dim)
 {
+       //lyxerr << "LyXText::metrics: width: " << mi.base.textwidth << "\n";
+
+       // rebuild row cache
        rowlist_.clear();
-       need_break_row = rows().end();
        width = height = 0;
 
        anchor_row_ = rows().end();
@@ -704,17 +703,34 @@ void LyXText::rebuild()
        ParagraphList::iterator pit = ownerParagraphs().begin();
        ParagraphList::iterator end = ownerParagraphs().end();
 
-       //current_font = getFont(bview->buffer(), pit, 0);
+       for (; pit != end; ++pit) {
+               InsetList::iterator ii = pit->insetlist.begin();
+               InsetList::iterator iend = pit->insetlist.end();
+               for (; ii != iend; ++ii) {
+                       Dimension dim;
+                       MetricsInfo m = mi;
+                       ii->inset->metrics(m, dim);
+               }
 
-       for (; pit != end; ++pit)
-               insertParagraph(pit, rowlist_.end());
+               // insert a new row, starting at position 0
+               Row newrow(pit, 0);
+               RowList::iterator rit = rowlist_.insert(rowlist_.end(), newrow);
 
-       //setCursorIntern(rowlist_.begin()->par(), 0);
-       //selection.cursor = cursor;
+               // and now append the whole paragraph before the new row
+               appendParagraph(rit);
+       }
 
-       //updateCounters();
+       // compute height
+       //lyxerr << "height 0: " << height << "\n";
+       //for (RowList::iterator rit = rows().begin(); rit != rows().end(); ++rit) {
+       //      height += rit->height();
+       //}
+       //lyxerr << "height 1: " << height << "\n";
 
-       //setCursorIntern(cursor.par(), cursor.pos());
+       // final dimension
+       dim.asc = rows().begin()->ascent_of_text();
+       dim.des = height - dim.asc;
+       dim.wid = std::max(mi.base.textwidth, int(width));
 }
 
 
@@ -724,14 +740,7 @@ void LyXText::partialRebreak()
                init(bv());
                return;
        }
-
-       RowList::iterator rows_end = rows().end();
-
-       if (need_break_row != rows_end) {
-               breakAgain(need_break_row);
-               need_break_row = rows_end;
-               return;
-       }
+       breakAgain(rows().begin());
 }
 
 
@@ -905,7 +914,7 @@ void LyXText::setParagraph(bool line_top, bool line_bottom,
                ++endpit;
        }
 
-       setUndo(bv(), Undo::EDIT, selection.start.par(),
+       recordUndo(bv(), Undo::ATOMIC, selection.start.par(),
                boost::prior(undoendpit));
 
 
@@ -1095,14 +1104,14 @@ void LyXText::setCounter(Buffer const * buf, ParagraphList::iterator pit)
                // the caption hack:
                if (layout->labeltype == LABEL_SENSITIVE) {
                        ParagraphList::iterator tmppit = pit;
-                       Inset * in = 0;
+                       InsetOld * in = 0;
                        bool isOK = false;
                        while (tmppit != ownerParagraphs().end() &&
                               tmppit->inInset()
                               // the single '=' is intended below
                               && (in = tmppit->inInset()->owner())) {
-                               if (in->lyxCode() == Inset::FLOAT_CODE ||
-                                   in->lyxCode() == Inset::WRAP_CODE) {
+                               if (in->lyxCode() == InsetOld::FLOAT_CODE ||
+                                   in->lyxCode() == InsetOld::WRAP_CODE) {
                                        isOK = true;
                                        break;
                                } else {
@@ -1113,9 +1122,9 @@ void LyXText::setCounter(Buffer const * buf, ParagraphList::iterator pit)
                        if (isOK) {
                                string type;
 
-                               if (in->lyxCode() == Inset::FLOAT_CODE)
+                               if (in->lyxCode() == InsetOld::FLOAT_CODE)
                                        type = static_cast<InsetFloat*>(in)->params().type;
-                               else if (in->lyxCode() == Inset::WRAP_CODE)
+                               else if (in->lyxCode() == InsetOld::WRAP_CODE)
                                        type = static_cast<InsetWrap*>(in)->params().type;
                                else
                                        Assert(0);
@@ -1189,11 +1198,11 @@ void LyXText::updateCounters()
 }
 
 
-void LyXText::insertInset(Inset * inset)
+void LyXText::insertInset(InsetOld * inset)
 {
        if (!cursor.par()->insetAllowed(inset->lyxCode()))
                return;
-       setUndo(bv(), Undo::FINISH, cursor.par());
+       recordUndo(bv(), Undo::ATOMIC, cursor.par());
        freezeUndo();
        cursor.par()->insertInset(cursor.pos(), inset);
        // Just to rebreak and refresh correctly.
@@ -1245,7 +1254,7 @@ void LyXText::cutSelection(bool doclear, bool realcut)
                ++endpit;
        }
 
-       setUndo(bv(), Undo::DELETE, selection.start.par(),
+       recordUndo(bv(), Undo::DELETE, selection.start.par(),
                boost::prior(undoendpit));
 
 
@@ -1320,7 +1329,7 @@ void LyXText::pasteSelection(size_t sel_index)
        if (!CutAndPaste::checkPastePossible())
                return;
 
-       setUndo(bv(), Undo::INSERT, cursor.par());
+       recordUndo(bv(), Undo::INSERT, cursor.par());
 
        ParagraphList::iterator endpit;
        PitPosPair ppp;
@@ -1363,7 +1372,7 @@ void LyXText::setSelectionRange(lyx::pos_type length)
 // simple replacing. The font of the first selected character is used
 void LyXText::replaceSelectionWithString(string const & str)
 {
-       setCursorParUndo(bv());
+       recordUndo(bv(), Undo::ATOMIC);
        freezeUndo();
 
        if (!selection.set()) { // create a dummy selection
@@ -1399,7 +1408,7 @@ void LyXText::insertStringAsLines(string const & str)
        pos_type pos = cursor.pos();
        ParagraphList::iterator endpit = boost::next(cursor.par());
 
-       setCursorParUndo(bv());
+       recordUndo(bv(), Undo::ATOMIC);
 
        // only to be sure, should not be neccessary
        clearSelection();
@@ -1444,62 +1453,14 @@ void LyXText::insertStringAsParagraphs(string const & str)
 
 void LyXText::checkParagraph(ParagraphList::iterator pit, pos_type pos)
 {
-       LyXCursor tmpcursor;
-
-       pos_type z;
-       RowList::iterator row = getRow(pit, pos);
-       RowList::iterator beg = rows().begin();
-
-       // is there a break one row above
-       if (row != beg && boost::prior(row)->par() == row->par()) {
-               z = rowBreakPoint(*boost::prior(row));
-               if (z >= row->pos()) {
-                       // set the dimensions of the row above
-                       postPaint();
-
-                       breakAgain(boost::prior(row));
-
-                       // set the cursor again. Otherwise
-                       // dangling pointers are possible
-                       setCursor(cursor.par(), cursor.pos(),
-                                 false, cursor.boundary());
-                       selection.cursor = cursor;
-                       return;
-               }
-       }
-
-       breakAgain(row);
+       breakAgain(getRow(pit, pos));
        postPaint();
-
-       // set the cursor again. Otherwise dangling pointers are possible
-       // also set the selection
-
-       if (selection.set()) {
-               tmpcursor = cursor;
-               setCursorIntern(selection.cursor.par(), selection.cursor.pos(),
-                               false, selection.cursor.boundary());
-               selection.cursor = cursor;
-               setCursorIntern(selection.start.par(),
-                               selection.start.pos(),
-                               false, selection.start.boundary());
-               selection.start = cursor;
-               setCursorIntern(selection.end.par(),
-                               selection.end.pos(),
-                               false, selection.end.boundary());
-               selection.end = cursor;
-               setCursorIntern(last_sel_cursor.par(),
-                               last_sel_cursor.pos(),
-                               false, last_sel_cursor.boundary());
-               last_sel_cursor = cursor;
-               cursor = tmpcursor;
-       }
-       setCursorIntern(cursor.par(), cursor.pos(),
-                       false, cursor.boundary());
+       setCursorIntern(cursor.par(), cursor.pos(), false, cursor.boundary());
 }
 
 
 // returns false if inset wasn't found
-bool LyXText::updateInset(Inset * inset)
+bool LyXText::updateInset(InsetOld * inset)
 {
        // first check the current paragraph
        int pos = cursor.par()->getPositionOfInset(inset);
@@ -1509,7 +1470,6 @@ bool LyXText::updateInset(Inset * inset)
        }
 
        // check every paragraph
-
        ParagraphList::iterator par = ownerParagraphs().begin();
        ParagraphList::iterator end = ownerParagraphs().end();
        for (; par != end; ++par) {
@@ -1518,7 +1478,7 @@ bool LyXText::updateInset(Inset * inset)
                        checkParagraph(par, pos);
                        return true;
                }
-       };
+       }
 
        return false;
 }
@@ -1560,7 +1520,7 @@ void LyXText::setCursor(LyXCursor & cur, ParagraphList::iterator pit,
            boost::prior(row)->par() == row->par() &&
            pos < pit->size() &&
            pit->getChar(pos) == Paragraph::META_INSET) {
-               Inset * ins = pit->getInset(pos);
+               InsetOld * ins = pit->getInset(pos);
                if (ins && (ins->needFullRow() || ins->display())) {
                        --row;
                        y -= row->height();
@@ -1617,10 +1577,10 @@ float LyXText::getCursorX(RowList::iterator rit,
                          pos_type pos, pos_type last, bool boundary) const
 {
        pos_type cursor_vpos = 0;
-       float x;
-       float fill_separator;
-       float fill_hfill;
-       float fill_label_hfill;
+       int x;
+       int fill_separator;
+       int fill_hfill;
+       int fill_label_hfill;
        // This call HAS to be here because of the BidiTables!!!
        prepareToPrint(rit, x, fill_separator, fill_hfill,
                       fill_label_hfill);
@@ -1652,8 +1612,7 @@ float LyXText::getCursorX(RowList::iterator rit,
                if (body_pos > 0 && pos == body_pos - 1) {
                        x += fill_label_hfill +
                                font_metrics::width(
-                                       rit_par->layout()->labelsep,
-                                       getLabelFont(bv()->buffer(), rit_par));
+                                       rit_par->layout()->labelsep, getLabelFont(rit_par));
                        if (rit_par->isLineSeparator(body_pos - 1))
                                x -= singleWidth(rit_par, body_pos - 1);
                }
@@ -1732,9 +1691,8 @@ void LyXText::setCurrentFont()
                        }
        }
 
-       current_font =
-               pit->getFontSettings(bv()->buffer()->params, pos);
-       real_current_font = getFont(bv()->buffer(), pit, pos);
+       current_font = pit->getFontSettings(bv()->buffer()->params, pos);
+       real_current_font = getFont(pit, pos);
 
        if (cursor.pos() == pit->size() &&
            isBoundary(bv()->buffer(), *pit, cursor.pos()) &&
@@ -1754,13 +1712,12 @@ void LyXText::setCurrentFont()
 pos_type
 LyXText::getColumnNearX(RowList::iterator rit, int & x, bool & boundary) const
 {
-       float tmpx = 0.0;
-       float fill_separator;
-       float fill_hfill;
-       float fill_label_hfill;
+       int tmpx = 0;
+       int fill_separator;
+       int fill_hfill;
+       int fill_label_hfill;
 
-       prepareToPrint(rit, tmpx, fill_separator,
-                      fill_hfill, fill_label_hfill);
+       prepareToPrint(rit, tmpx, fill_separator, fill_hfill, fill_label_hfill);
 
        pos_type vc = rit->pos();
        pos_type last = lastPrintablePos(*this, rit);
@@ -1772,7 +1729,7 @@ LyXText::getColumnNearX(RowList::iterator rit, int & x, bool & boundary) const
        bool left_side = false;
 
        pos_type body_pos = rit_par->beginningOfBody();
-       float last_tmpx = tmpx;
+       int last_tmpx = tmpx;
 
        if (body_pos > 0 &&
            (body_pos - 1 > last ||
@@ -1781,7 +1738,7 @@ LyXText::getColumnNearX(RowList::iterator rit, int & x, bool & boundary) const
 
        // check for empty row
        if (!rit_par->size()) {
-               x = int(tmpx);
+               x = tmpx;
                return 0;
        }
 
@@ -1790,8 +1747,7 @@ LyXText::getColumnNearX(RowList::iterator rit, int & x, bool & boundary) const
                last_tmpx = tmpx;
                if (body_pos > 0 && c == body_pos - 1) {
                        tmpx += fill_label_hfill +
-                               font_metrics::width(layout->labelsep,
-                                              getLabelFont(bv()->buffer(), rit_par));
+                               font_metrics::width(layout->labelsep, getLabelFont(rit_par));
                        if (rit_par->isLineSeparator(body_pos - 1))
                                tmpx -= singleWidth(rit_par, body_pos - 1);
                }
@@ -1805,7 +1761,7 @@ LyXText::getColumnNearX(RowList::iterator rit, int & x, bool & boundary) const
                } else if (rit_par->isSeparator(c)) {
                        tmpx += singleWidth(rit_par, c);
                        if (c >= body_pos)
-                               tmpx+= fill_separator;
+                               tmpx += fill_separator;
                } else {
                        tmpx += singleWidth(rit_par, c);
                }
@@ -1868,11 +1824,11 @@ LyXText::getColumnNearX(RowList::iterator rit, int & x, bool & boundary) const
 
 void LyXText::setCursorFromCoordinates(int x, int y)
 {
-       LyXCursor old_cursor = cursor;
-
+       //LyXCursor old_cursor = cursor;
        setCursorFromCoordinates(cursor, x, y);
        setCurrentFont();
-       deleteEmptyParagraphMechanism(old_cursor);
+#warning DEPM disabled, otherwise crash when entering new table
+       //deleteEmptyParagraphMechanism(old_cursor);
 }
 
 
@@ -1898,7 +1854,7 @@ namespace {
                    || !cur.par()->isInset(cur.pos()))
                        return false;
 
-               Inset const * inset = cur.par()->getInset(cur.pos());
+               InsetOld const * inset = cur.par()->getInset(cur.pos());
                if (inset->needFullRow() || inset->display())
                        return true;
 
@@ -1978,7 +1934,7 @@ void LyXText::cursorUp(bool selecting)
                int y1 = cursor.iy() - topy;
                int y2 = y1;
                y -= topy;
-               Inset * inset_hit = checkInsetHit(x, y1);
+               InsetOld * inset_hit = checkInsetHit(x, y1);
                if (inset_hit && isHighlyEditableInset(inset_hit)) {
                        inset_hit->localDispatch(
                                FuncRequest(bv(), LFUN_INSET_EDIT, x, y - (y2 - y1), mouse_button::none));
@@ -2002,7 +1958,7 @@ void LyXText::cursorDown(bool selecting)
                int y1 = cursor.iy() - topy;
                int y2 = y1;
                y -= topy;
-               Inset * inset_hit = checkInsetHit(x, y1);
+               InsetOld * inset_hit = checkInsetHit(x, y1);
                if (inset_hit && isHighlyEditableInset(inset_hit)) {
                        FuncRequest cmd(bv(), LFUN_INSET_EDIT, x, y - (y2 - y1), mouse_button::none);
                        inset_hit->localDispatch(cmd);
@@ -2173,7 +2129,7 @@ bool LyXText::deleteEmptyParagraphMechanism(LyXCursor const & old_cursor)
                                ++endpit;
                        }
 
-                       setUndo(bv(), Undo::DELETE, old_cursor.par(),
+                       recordUndo(bv(), Undo::DELETE, old_cursor.par(),
                                boost::prior(endpit));
                        cursor = tmpcursor;
 
@@ -2205,7 +2161,7 @@ bool LyXText::deleteEmptyParagraphMechanism(LyXCursor const & old_cursor)
                                ++endpit;
                        }
 
-                       setUndo(bv(), Undo::DELETE, old_cursor.par(), boost::prior(endpit));
+                       recordUndo(bv(), Undo::DELETE, old_cursor.par(), boost::prior(endpit));
                        cursor = tmpcursor;
 
                        // delete old row