]> git.lyx.org Git - lyx.git/blobdiff - src/text2.C
ws changes only
[lyx.git] / src / text2.C
index aa00774ce1084da9a6c515eace02071b9d487214..e3994ced4f73dbe98d570a5ca4f59b3e74a801bc 100644 (file)
@@ -1,69 +1,79 @@
-/* This file is part of
- * ======================================================
+/**
+ * \file text2.C
+ * This file is part of LyX, the document processor.
+ * Licence details can be found in the file COPYING.
  *
- *           LyX, The Document Processor
+ * \author Asger Alstrup
+ * \author Lars Gullik Bjønnes
+ * \author Alfredo Braunstein
+ * \author Jean-Marc Lasgouttes
+ * \author Angus Leeming
+ * \author John Levon
+ * \author André Pönitz
+ * \author Allan Rae
+ * \author Dekel Tsur
+ * \author Jürgen Vigna
  *
- *           Copyright 1995 Matthias Ettrich
- *           Copyright 1995-2001 The LyX Team.
- *
- * ====================================================== */
+ * Full author contact details are available in file CREDITS.
+ */
 
 #include <config.h>
 
 #include "lyxtext.h"
-#include "LString.h"
-#include "Lsstream.h"
-#include "paragraph.h"
-#include "funcrequest.h"
-#include "frontends/LyXView.h"
-#include "undo_funcs.h"
+
 #include "buffer.h"
 #include "buffer_funcs.h"
 #include "bufferparams.h"
-#include "errorlist.h"
-#include "gettext.h"
 #include "BufferView.h"
+#include "Bullet.h"
+#include "counters.h"
 #include "CutAndPaste.h"
-#include "frontends/Painter.h"
-#include "frontends/font_metrics.h"
 #include "debug.h"
-#include "lyxrc.h"
+#include "errorlist.h"
+#include "Floating.h"
 #include "FloatList.h"
+#include "funcrequest.h"
+#include "gettext.h"
 #include "language.h"
-#include "ParagraphParameters.h"
-#include "counters.h"
+#include "lyxrc.h"
+#include "lyxrow.h"
 #include "lyxrow_funcs.h"
 #include "metricsinfo.h"
+#include "paragraph.h"
 #include "paragraph_funcs.h"
+#include "ParagraphParameters.h"
+#include "undo_funcs.h"
+#include "vspace.h"
+
+#include "frontends/font_metrics.h"
+#include "frontends/LyXView.h"
 
 #include "insets/insetbibitem.h"
 #include "insets/insetenv.h"
 #include "insets/insetfloat.h"
 #include "insets/insetwrap.h"
 
-#include "support/LAssert.h"
-#include "support/textutils.h"
 #include "support/lstrings.h"
+#include "support/textutils.h"
+#include "support/tostr.h"
+#include "support/std_sstream.h"
 
 #include <boost/tuple/tuple.hpp>
 
-#include <algorithm>
-
-using namespace lyx::support;
+using lyx::pos_type;
+using lyx::paroffset_type;
+using lyx::support::bformat;
 
-using std::vector;
-using std::copy;
 using std::endl;
-using std::find;
-using std::pair;
-using lyx::pos_type;
+using std::ostringstream;
+using std::string;
 
 
 LyXText::LyXText(BufferView * bv, InsetText * inset, bool ininset,
          ParagraphList & paragraphs)
        : height(0), width(0), anchor_y_(0),
          inset_owner(inset), the_locking_inset(0), bv_owner(bv),
-         in_inset_(ininset), paragraphs_(paragraphs)
+         in_inset_(ininset), paragraphs_(&paragraphs)
 {
 }
 
@@ -85,7 +95,7 @@ void LyXText::init(BufferView * bview)
        current_font = getFont(beg, 0);
 
        redoParagraphs(beg, end);
-       setCursorIntern(beg, 0);
+       setCursorIntern(0, 0);
        selection.cursor = cursor;
 
        updateCounters();
@@ -99,11 +109,11 @@ void LyXText::init(BufferView * bview)
 // smaller. (Asger)
 LyXFont LyXText::getFont(ParagraphList::iterator pit, pos_type pos) const
 {
-       Assert(pos >= 0);
+       BOOST_ASSERT(pos >= 0);
 
        LyXLayout_ptr const & layout = pit->layout();
 #warning broken?
-       BufferParams const & params = bv()->buffer()->params;
+       BufferParams const & params = bv()->buffer()->params();
 
        // We specialize the 95% common case:
        if (!pit->getDepth()) {
@@ -184,7 +194,7 @@ void LyXText::setCharFont(ParagraphList::iterator pit,
                          pos_type pos, LyXFont const & fnt,
                          bool toggleall)
 {
-       BufferParams const & params = bv()->buffer()->params;
+       BufferParams const & params = bv()->buffer()->params();
        LyXFont font = getFont(pit, pos);
        font.update(fnt, params.language, toggleall);
        // Let the insets convert their font
@@ -238,7 +248,7 @@ void LyXText::setCharFont(
 
 InsetOld * LyXText::getInset() const
 {
-       ParagraphList::iterator pit = cursor.par();
+       ParagraphList::iterator pit = cursorPar();
        pos_type const pos = cursor.pos();
 
        if (pos < pit->size() && pit->isInset(pos)) {
@@ -273,7 +283,7 @@ void LyXText::toggleInset()
        else
                inset->open(bv());
 
-       bv()->updateInset();
+       bv()->updateInset(inset);
 }
 
 
@@ -304,7 +314,7 @@ LyXText::setLayout(LyXCursor & cur, LyXCursor & sstart_cur,
                   LyXCursor & send_cur,
                   string const & layout)
 {
-       ParagraphList::iterator endpit = boost::next(send_cur.par());
+       ParagraphList::iterator endpit = boost::next(getPar(send_cur));
        ParagraphList::iterator undoendpit = endpit;
        ParagraphList::iterator pars_end = ownerParagraphs().end();
 
@@ -318,20 +328,21 @@ LyXText::setLayout(LyXCursor & cur, LyXCursor & sstart_cur,
                ++endpit;
        }
 
-       recordUndo(bv(), Undo::ATOMIC, sstart_cur.par(), boost::prior(undoendpit));
+       recordUndo(bv(), Undo::ATOMIC, getPar(sstart_cur), boost::prior(undoendpit));
 
        // ok we have a selection. This is always between sstart_cur
        // and sel_end cursor
        cur = sstart_cur;
-       ParagraphList::iterator pit = sstart_cur.par();
-       ParagraphList::iterator epit = boost::next(send_cur.par());
+       ParagraphList::iterator pit = getPar(sstart_cur);
+       ParagraphList::iterator epit = boost::next(getPar(send_cur));
 
+       BufferParams const & bufparams = bv()->buffer()->params();
        LyXLayout_ptr const & lyxlayout =
-               bv()->buffer()->params.getLyXTextClass()[layout];
+               bufparams.getLyXTextClass()[layout];
 
        do {
                pit->applyLayout(lyxlayout);
-               makeFontEntriesLayoutSpecific(bv()->buffer()->params, *pit);
+               makeFontEntriesLayoutSpecific(bufparams, *pit);
                pit->params().spaceTop(lyxlayout->fill_top ?
                                         VSpace(VSpace::VFILL)
                                         : VSpace(VSpace::NONE));
@@ -340,7 +351,7 @@ LyXText::setLayout(LyXCursor & cur, LyXCursor & sstart_cur,
                                            : VSpace(VSpace::NONE));
                if (lyxlayout->margintype == MARGIN_MANUAL)
                        pit->setLabelWidthString(lyxlayout->labelstring());
-               cur.par(pit);
+               cur.par(std::distance(ownerParagraphs().begin(), pit));
                ++pit;
        } while (pit != epit);
 
@@ -361,7 +372,7 @@ void LyXText::setLayout(string const & layout)
        }
 
        // special handling of new environment insets
-       BufferParams const & params = bv()->buffer()->params;
+       BufferParams const & params = bv()->buffer()->params();
        LyXLayout_ptr const & lyxlayout = params.getLyXTextClass()[layout];
        if (lyxlayout->is_environment) {
                // move everything in a new environment inset
@@ -381,7 +392,7 @@ void LyXText::setLayout(string const & layout)
 
        ParagraphList::iterator endpit = setLayout(cursor, selection.start,
                                                   selection.end, layout);
-       redoParagraphs(selection.start.par(), endpit);
+       redoParagraphs(getPar(selection.start), endpit);
 
        // we have to reset the selection, because the
        // geometry could have changed
@@ -397,13 +408,13 @@ void LyXText::setLayout(string const & layout)
 
 bool LyXText::changeDepth(bv_funcs::DEPTH_CHANGE type, bool test_only)
 {
-       ParagraphList::iterator pit = cursor.par();
-       ParagraphList::iterator end = cursor.par();
+       ParagraphList::iterator pit = cursorPar();
+       ParagraphList::iterator end = cursorPar();
        ParagraphList::iterator start = pit;
 
        if (selection.set()) {
-               pit = selection.start.par();
-               end = selection.end.par();
+               pit = getPar(selection.start);
+               end = getPar(selection.end);
                start = pit;
        }
 
@@ -479,14 +490,14 @@ void LyXText::setFont(LyXFont const & font, bool toggleall)
        if (!selection.set()) {
                // Determine basis font
                LyXFont layoutfont;
-               if (cursor.pos() < cursor.par()->beginningOfBody()) {
-                       layoutfont = getLabelFont(cursor.par());
+               if (cursor.pos() < cursorPar()->beginningOfBody()) {
+                       layoutfont = getLabelFont(cursorPar());
                } else {
-                       layoutfont = getLayoutFont(cursor.par());
+                       layoutfont = getLayoutFont(cursorPar());
                }
                // Update current font
                real_current_font.update(font,
-                                        bv()->buffer()->params.language,
+                                        bv()->buffer()->params().language,
                                         toggleall);
 
                // Reduce to implicit settings
@@ -503,25 +514,24 @@ void LyXText::setFont(LyXFont const & font, bool toggleall)
        // ok we have a selection. This is always between sel_start_cursor
        // and sel_end cursor
 
-       recordUndo(bv(), Undo::ATOMIC, selection.start.par(), selection.end.par());
+       recordUndo(bv(), Undo::ATOMIC, getPar(selection.start), getPar(selection.end));
        freezeUndo();
        cursor = selection.start;
        while (cursor.par() != selection.end.par() ||
               cursor.pos() < selection.end.pos())
        {
-               if (cursor.pos() < cursor.par()->size()) {
+               if (cursor.pos() < cursorPar()->size()) {
                        // an open footnote should behave like a closed one
-                       setCharFont(cursor.par(), cursor.pos(),
-                                   font, toggleall);
+                       setCharFont(cursorPar(), cursor.pos(), font, toggleall);
                        cursor.pos(cursor.pos() + 1);
                } else {
                        cursor.pos(0);
-                       cursor.par(boost::next(cursor.par()));
+                       cursor.par(cursor.par() + 1);
                }
        }
        unFreezeUndo();
 
-       redoParagraph(selection.start.par());
+       redoParagraph(getPar(selection.start));
 
        // we have to reset the selection, because the
        // geometry could have changed, but we keep
@@ -535,17 +545,7 @@ void LyXText::setFont(LyXFont const & font, bool toggleall)
 }
 
 
-// rebreaks all paragraphs between the specified pars
-// This function is needed after SetLayout and SetFont etc.
-void LyXText::redoParagraphs(ParagraphList::iterator start,
-  ParagraphList::iterator end)
-{
-       for ( ; start != end; ++start)
-               redoParagraph(start);
-}
-
-
-void LyXText::redoParagraph(ParagraphList::iterator pit)
+int LyXText::redoParagraphInternal(ParagraphList::iterator pit)
 {
        RowList::iterator rit = pit->rows.begin();
        RowList::iterator end = pit->rows.end();
@@ -572,15 +572,42 @@ void LyXText::redoParagraph(ParagraphList::iterator pit)
                pit->rows.push_back(row);
        }
 
-       // set height and fill of rows
+       int par_width = 0;
+       // set height and fill and width of rows
+       int const ww = workWidth();
        for (rit = pit->rows.begin(); rit != end; ++rit) {
-               rit->fill(fill(pit, rit, workWidth()));
+               int const f = fill(pit, rit, ww);
+               int const w = ww - f;
+               par_width = std::max(par_width, w);
+               rit->fill(f);
+               rit->width(w);
                prepareToPrint(pit, rit);
                setHeightOfRow(pit, rit);
                height += rit->height();
        }
 
        //lyxerr << "redoParagraph: " << pit->rows.size() << " rows\n";
+       return par_width;
+}
+
+
+int LyXText::redoParagraphs(ParagraphList::iterator start,
+  ParagraphList::iterator end)
+{
+       int pars_width = 0;
+       for ( ; start != end; ++start) {
+               int par_width = redoParagraphInternal(start);
+               pars_width = std::max(par_width, pars_width);
+       }
+       updateRowPositions();
+       return pars_width;
+}
+
+
+void LyXText::redoParagraph(ParagraphList::iterator pit)
+{
+       redoParagraphInternal(pit);
+       updateRowPositions();
 }
 
 
@@ -596,14 +623,14 @@ void LyXText::metrics(MetricsInfo & mi, Dimension & dim)
 {
        //lyxerr << "LyXText::metrics: width: " << mi.base.textwidth
        //      << " workWidth: " << workWidth() << endl;
-       //Assert(mi.base.textwidth);
+       //BOOST_ASSERT(mi.base.textwidth);
 
        // rebuild row cache
        width  = 0;
        ///height = 0;
 
        //anchor_y_ = 0;
-       redoParagraphs(ownerParagraphs().begin(), ownerParagraphs().end());
+       width = redoParagraphs(ownerParagraphs().begin(), ownerParagraphs().end());
 
        // final dimension
        dim.asc = firstRow()->ascent_of_text();
@@ -639,31 +666,13 @@ void LyXText::clearSelection()
 
 void LyXText::cursorHome()
 {
-       setCursor(cursor.par(), cursorRow()->pos());
+       setCursor(cursorPar(), cursorRow()->pos());
 }
 
 
 void LyXText::cursorEnd()
 {
-       if (cursor.par()->empty())
-               return;
-
-       RowList::iterator rit = cursorRow();
-       RowList::iterator next_rit = boost::next(rit);
-       RowList::iterator end = boost::next(rit);
-       ParagraphList::iterator pit = cursor.par();
-       pos_type last_pos = lastPos(*pit, rit);
-
-       if (next_rit == end) {
-               ++last_pos;
-       } else {
-               if (pit->empty() ||
-                   (pit->getChar(last_pos) != ' ' && !pit->isNewline(last_pos))) {
-                       ++last_pos;
-               }
-       }
-
-       setCursor(pit, last_pos);
+       setCursor(cursorPar(), cursorRow()->end() - 1);
 }
 
 
@@ -706,7 +715,7 @@ void LyXText::toggleFree(LyXFont const & font, bool toggleall)
        if (implicitSelection) {
                clearSelection();
                cursor = resetCursor;
-               setCursor(cursor.par(), cursor.pos());
+               setCursor(cursorPar(), cursor.pos());
                selection.cursor = cursor;
        }
 }
@@ -727,11 +736,11 @@ string LyXText::getStringToIndex()
        else if (selection.start.par() != selection.end.par())
                bv()->owner()->message(_("Cannot index more than one paragraph!"));
        else
-               idxstring = selectionAsString(bv()->buffer(), false);
+               idxstring = selectionAsString(*bv()->buffer(), false);
 
        // Reset cursors to their original position.
        cursor = reset_cursor;
-       setCursor(cursor.par(), cursor.pos());
+       setCursor(cursorPar(), cursor.pos());
        selection.cursor = cursor;
 
        // Clear the implicit selection.
@@ -764,7 +773,7 @@ void LyXText::setParagraph(bool line_top, bool line_bottom,
        }
 
        // make sure that the depth behind the selection are restored, too
-       ParagraphList::iterator endpit = boost::next(selection.end.par());
+       ParagraphList::iterator endpit = boost::next(getPar(selection.end));
        ParagraphList::iterator undoendpit = endpit;
        ParagraphList::iterator pars_end = ownerParagraphs().end();
 
@@ -778,16 +787,16 @@ void LyXText::setParagraph(bool line_top, bool line_bottom,
                ++endpit;
        }
 
-       recordUndo(bv(), Undo::ATOMIC, selection.start.par(),
+       recordUndo(bv(), Undo::ATOMIC, getPar(selection.start),
                boost::prior(undoendpit));
 
 
-       ParagraphList::iterator tmppit = selection.end.par();
+       int tmppit = selection.end.par();
 
-       while (tmppit != boost::prior(selection.start.par())) {
+       while (tmppit != selection.start.par() - 1) {
                setCursor(tmppit, 0);
 
-               ParagraphList::iterator pit = cursor.par();
+               ParagraphList::iterator const pit = cursorPar();
                ParagraphParameters & params = pit->params();
 
                params.lineTop(line_top);
@@ -810,10 +819,10 @@ void LyXText::setParagraph(bool line_top, bool line_bottom,
                }
                pit->setLabelWidthString(labelwidthstring);
                params.noindent(noindent);
-               tmppit = boost::prior(pit);
+               --tmppit;
        }
 
-       redoParagraphs(selection.start.par(), endpit);
+       redoParagraphs(getPar(selection.start), endpit);
 
        clearSelection();
        setCursor(selection.start.par(), selection.start.pos());
@@ -822,57 +831,139 @@ void LyXText::setParagraph(bool line_top, bool line_bottom,
        setSelection();
        setCursor(tmpcursor.par(), tmpcursor.pos());
        if (inset_owner)
-               bv()->updateInset();
+               bv()->updateInset(inset_owner);
+}
+
+
+namespace {
+
+string expandLabel(LyXTextClass const & textclass,
+       LyXLayout_ptr const & layout, bool appendix)
+{
+       string fmt = appendix ?
+               layout->labelstring_appendix() : layout->labelstring();
+
+       // handle 'inherited level parts' in 'fmt',
+       // i.e. the stuff between '@' in   '@Section@.\arabic{subsection}'
+       size_t const i = fmt.find('@', 0);
+       if (i != string::npos) {
+               size_t const j = fmt.find('@', i + 1);
+               if (j != string::npos) {
+                       string parent(fmt, i + 1, j - i - 1);
+                       string label = expandLabel(textclass, textclass[parent], appendix);
+                       fmt = string(fmt, 0, i) + label + string(fmt, j + 1, string::npos);
+               }
+       }
+
+       return textclass.counters().counterLabel(fmt);
+}
+
+
+void incrementItemDepth(ParagraphList::iterator pit,
+                       ParagraphList::iterator first_pit)
+{
+       int const cur_labeltype = pit->layout()->labeltype;
+
+       if (cur_labeltype != LABEL_ENUMERATE &&
+           cur_labeltype != LABEL_ITEMIZE)
+               return;
+
+       int const cur_depth = pit->getDepth();
+
+       ParagraphList::iterator prev_pit = boost::prior(pit);
+       while (true) {
+               int const prev_depth = prev_pit->getDepth();
+               int const prev_labeltype = prev_pit->layout()->labeltype;
+               if (prev_depth == 0 && cur_depth > 0) {
+                       if (prev_labeltype == cur_labeltype) {
+                               pit->itemdepth = prev_pit->itemdepth + 1;
+                       }
+                       break;
+               } else if (prev_depth < cur_depth) {
+                       if (prev_labeltype == cur_labeltype) {
+                               pit->itemdepth = prev_pit->itemdepth + 1;
+                               break;
+                       }
+               } else if (prev_depth == cur_depth) {
+                       if (prev_labeltype == cur_labeltype) {
+                               pit->itemdepth = prev_pit->itemdepth;
+                               break;
+                       }
+               }
+               if (prev_pit == first_pit)
+                       break;
+
+               --prev_pit;
+       }
+}
+
+
+void resetEnumCounterIfNeeded(ParagraphList::iterator pit,
+                             ParagraphList::iterator firstpit,
+                             Counters & counters)
+{
+       if (pit == firstpit)
+               return;
+
+       int const cur_depth = pit->getDepth();
+       ParagraphList::iterator prev_pit = boost::prior(pit);
+       while (true) {
+               int const prev_depth = prev_pit->getDepth();
+               int const prev_labeltype = prev_pit->layout()->labeltype;
+               if (prev_depth <= cur_depth) {
+                       if (prev_labeltype != LABEL_ENUMERATE) {
+                               switch (pit->itemdepth) {
+                               case 0:
+                                       counters.reset("enumi");
+                               case 1:
+                                       counters.reset("enumii");
+                               case 2:
+                                       counters.reset("enumiii");
+                               case 3:
+                                       counters.reset("enumiv");
+                               }
+                       }
+                       break;
+               }
+
+               if (prev_pit == firstpit)
+                       break;
+
+               --prev_pit;
+       }
 }
 
+} // anon namespace
+
 
 // set the counter of a paragraph. This includes the labels
-void LyXText::setCounter(Buffer const * buf, ParagraphList::iterator pit)
+void LyXText::setCounter(Buffer const & buf, ParagraphList::iterator pit)
 {
-       LyXTextClass const & textclass = buf->params.getLyXTextClass();
+       BufferParams const & bufparams = buf.params();
+       LyXTextClass const & textclass = bufparams.getLyXTextClass();
        LyXLayout_ptr const & layout = pit->layout();
+       ParagraphList::iterator first_pit = ownerParagraphs().begin();
+       Counters & counters = textclass.counters();
 
-       if (pit != ownerParagraphs().begin()) {
+       // Always reset
+       pit->itemdepth = 0;
 
+       if (pit == first_pit) {
+               pit->params().appendix(pit->params().startOfAppendix());
+       } else {
                pit->params().appendix(boost::prior(pit)->params().appendix());
                if (!pit->params().appendix() &&
                    pit->params().startOfAppendix()) {
                        pit->params().appendix(true);
                        textclass.counters().reset();
                }
-               pit->enumdepth = boost::prior(pit)->enumdepth;
-               pit->itemdepth = boost::prior(pit)->itemdepth;
-       } else {
-               pit->params().appendix(pit->params().startOfAppendix());
-               pit->enumdepth = 0;
-               pit->itemdepth = 0;
-       }
 
-       // Maybe we have to increment the enumeration depth.
-       // BUT, enumeration in a footnote is considered in isolation from its
-       //      surrounding paragraph so don't increment if this is the
-       //      first line of the footnote
-       // AND, bibliographies can't have their depth changed ie. they
-       //      are always of depth 0
-       if (pit != ownerParagraphs().begin()
-           && boost::prior(pit)->getDepth() < pit->getDepth()
-           && boost::prior(pit)->layout()->labeltype == LABEL_COUNTER_ENUMI
-           && pit->enumdepth < 3
-           && layout->labeltype != LABEL_BIBLIO) {
-               pit->enumdepth++;
+               // Maybe we have to increment the item depth.
+               incrementItemDepth(pit, first_pit);
        }
 
-       // Maybe we have to decrement the enumeration depth, see note above
-       if (pit != ownerParagraphs().begin()
-           && boost::prior(pit)->getDepth() > pit->getDepth()
-           && layout->labeltype != LABEL_BIBLIO) {
-               pit->enumdepth = depthHook(pit, ownerParagraphs(),
-                                          pit->getDepth())->enumdepth;
-       }
-
-       if (!pit->params().labelString().empty()) {
-               pit->params().labelString(string());
-       }
+       // erase what was there before
+       pit->params().labelString(string());
 
        if (layout->margintype == MARGIN_MANUAL) {
                if (pit->params().labelWidthString().empty())
@@ -882,85 +973,73 @@ void LyXText::setCounter(Buffer const * buf, ParagraphList::iterator pit)
        }
 
        // is it a layout that has an automatic label?
-       if (layout->labeltype >= LABEL_COUNTER_CHAPTER) {
-               int const i = layout->labeltype - LABEL_COUNTER_CHAPTER;
-
-               ostringstream s;
-
-               if (i >= 0 && i <= buf->params.secnumdepth) {
-                       string numbertype;
-                       string langtype;
+       if (layout->labeltype == LABEL_COUNTER) {
+               BufferParams const & bufparams = buf.params();
+               LyXTextClass const & textclass = bufparams.getLyXTextClass();
+               counters.step(layout->counter);
+               string label = expandLabel(textclass, layout, pit->params().appendix());
+               pit->params().labelString(label);
+       } else if (layout->labeltype == LABEL_ITEMIZE) {
+               // At some point of time we should do something more
+               // clever here, like:
+               //   pit->params().labelString(
+               //    bufparams.user_defined_bullet(pit->itemdepth).getText());
+               // for now, use a simple hardcoded label
+               string itemlabel;
+               switch (pit->itemdepth) {
+               case 0:
+                       itemlabel = "*";
+                       break;
+               case 1:
+                       itemlabel = "-";
+                       break;
+               case 2:
+                       itemlabel = "@";
+                       break;
+               case 3:
+                       itemlabel = "·";
+                       break;
+               }
 
-                       textclass.counters().step(layout->latexname());
+               pit->params().labelString(itemlabel);
+       } else if (layout->labeltype == LABEL_ENUMERATE) {
+               // Maybe we have to reset the enumeration counter.
+               resetEnumCounterIfNeeded(pit, first_pit, counters);
 
-                       // Is there a label? Useful for Chapter layout
-                       if (!pit->params().appendix()) {
-                               s << buf->B_(layout->labelstring());
-                       } else {
-                               s << buf->B_(layout->labelstring_appendix());
-                       }
+               // FIXME
+               // Yes I know this is a really, really! bad solution
+               // (Lgb)
+               string enumcounter = "enum";
 
-                       // Use of an integer is here less than elegant. For now.
-                       int head = textclass.maxcounter() - LABEL_COUNTER_CHAPTER;
-                       if (!pit->params().appendix()) {
-                               numbertype = "sectioning";
-                       } else {
-                               numbertype = "appendix";
-                               if (pit->isRightToLeftPar(buf->params))
-                                       langtype = "hebrew";
-                               else
-                                       langtype = "latin";
-                       }
-
-                       s << " "
-                         << textclass.counters()
-                               .numberLabel(layout->latexname(),
-                                            numbertype, langtype, head);
-
-                       pit->params().labelString(STRCONV(s.str()));
-
-                       // reset enum counters
-                       textclass.counters().reset("enum");
-               } else if (layout->labeltype < LABEL_COUNTER_ENUMI) {
-                       textclass.counters().reset("enum");
-               } else if (layout->labeltype == LABEL_COUNTER_ENUMI) {
-                       // FIXME
-                       // Yes I know this is a really, really! bad solution
-                       // (Lgb)
-                       string enumcounter("enum");
-
-                       switch (pit->enumdepth) {
-                       case 2:
-                               enumcounter += 'i';
-                       case 1:
-                               enumcounter += 'i';
-                       case 0:
-                               enumcounter += 'i';
-                               break;
-                       case 3:
-                               enumcounter += "iv";
-                               break;
-                       default:
-                               // not a valid enumdepth...
-                               break;
-                       }
+               switch (pit->itemdepth) {
+               case 2:
+                       enumcounter += 'i';
+               case 1:
+                       enumcounter += 'i';
+               case 0:
+                       enumcounter += 'i';
+                       break;
+               case 3:
+                       enumcounter += "iv";
+                       break;
+               default:
+                       // not a valid enumdepth...
+                       break;
+               }
 
-                       textclass.counters().step(enumcounter);
+               counters.step(enumcounter);
 
-                       s << textclass.counters()
-                               .numberLabel(enumcounter, "enumeration");
-                       pit->params().labelString(STRCONV(s.str()));
-               }
+               pit->params().labelString(counters.enumLabel(enumcounter));
        } else if (layout->labeltype == LABEL_BIBLIO) {// ale970302
-               textclass.counters().step("bibitem");
-               int number = textclass.counters().value("bibitem");
+               counters.step("bibitem");
+               int number = counters.value("bibitem");
                if (pit->bibitem()) {
                        pit->bibitem()->setCounter(number);
                        pit->params().labelString(layout->labelstring());
                }
                // In biblio should't be following counters but...
        } else {
-               string s = buf->B_(layout->labelstring());
+               string s = buf.B_(layout->labelstring());
 
                // the caption hack:
                if (layout->labeltype == LABEL_SENSITIVE) {
@@ -977,9 +1056,10 @@ void LyXText::setCounter(Buffer const * buf, ParagraphList::iterator pit)
                                        isOK = true;
                                        break;
                                } else {
-                                       tmppit = ownerParagraphs().begin();
+                                       Paragraph const * owner = &ownerPar(buf, in);
+                                       tmppit = first_pit;
                                        for ( ; tmppit != end; ++tmppit)
-                                               if (&*tmppit == in->parOwner())
+                                               if (&*tmppit == owner)
                                                        break;
                                }
                        }
@@ -992,14 +1072,14 @@ void LyXText::setCounter(Buffer const * buf, ParagraphList::iterator pit)
                                else if (in->lyxCode() == InsetOld::WRAP_CODE)
                                        type = static_cast<InsetWrap*>(in)->params().type;
                                else
-                                       Assert(0);
+                                       BOOST_ASSERT(false);
 
                                Floating const & fl = textclass.floats().getType(type);
 
-                               textclass.counters().step(fl.type());
+                               counters.step(fl.type());
 
                                // Doesn't work... yet.
-                               s = bformat(_("%1$s #:"), buf->B_(fl.name()));
+                               s = bformat(_("%1$s #:"), buf.B_(fl.name()));
                        } else {
                                // par->SetLayout(0);
                                // s = layout->labelstring;
@@ -1008,20 +1088,6 @@ void LyXText::setCounter(Buffer const * buf, ParagraphList::iterator pit)
                }
                pit->params().labelString(s);
 
-               // reset the enumeration counter. They are always reset
-               // when there is any other layout between
-               // Just fall-through between the cases so that all
-               // enum counters deeper than enumdepth is also reset.
-               switch (pit->enumdepth) {
-               case 0:
-                       textclass.counters().reset("enumi");
-               case 1:
-                       textclass.counters().reset("enumii");
-               case 2:
-                       textclass.counters().reset("enumiii");
-               case 3:
-                       textclass.counters().reset("enumiv");
-               }
        }
 }
 
@@ -1030,7 +1096,7 @@ void LyXText::setCounter(Buffer const * buf, ParagraphList::iterator pit)
 void LyXText::updateCounters()
 {
        // start over
-       bv()->buffer()->params.getLyXTextClass().counters().reset();
+       bv()->buffer()->params().getLyXTextClass().counters().reset();
 
        ParagraphList::iterator beg = ownerParagraphs().begin();
        ParagraphList::iterator end = ownerParagraphs().end();
@@ -1045,7 +1111,7 @@ void LyXText::updateCounters()
                        pit->params().depth(maxdepth);
 
                // setCounter can potentially change the labelString.
-               setCounter(bv()->buffer(), pit);
+               setCounter(*bv()->buffer(), pit);
 
                string const & newLabel = pit->params().labelString();
 
@@ -1057,16 +1123,16 @@ void LyXText::updateCounters()
 
 void LyXText::insertInset(InsetOld * inset)
 {
-       if (!cursor.par()->insetAllowed(inset->lyxCode()))
+       if (!cursorPar()->insetAllowed(inset->lyxCode()))
                return;
-       recordUndo(bv(), Undo::ATOMIC, cursor.par());
+       recordUndo(bv(), Undo::ATOMIC, cursorPar());
        freezeUndo();
-       cursor.par()->insertInset(cursor.pos(), inset);
+       cursorPar()->insertInset(cursor.pos(), inset);
        // Just to rebreak and refresh correctly.
        // The character will not be inserted a second time
        insertChar(Paragraph::META_INSET);
        // If we enter a highly editable inset the cursor should be before
-       // the inset. After an Undo LyX tries to call inset->edit(...) 
+       // the inset. After an Undo LyX tries to call inset->edit(...)
        // and fails if the cursor is behind the inset and getInset
        // does not return the inset!
        if (isHighlyEditableInset(inset))
@@ -1085,7 +1151,7 @@ void LyXText::cutSelection(bool doclear, bool realcut)
        // finished. The solution used currently just works, to make it
        // faster we need to be more clever and probably also have more
        // calls to stuffClipboard. (Lgb)
-       bv()->stuffClipboard(selectionAsString(bv()->buffer(), true));
+       bv()->stuffClipboard(selectionAsString(*bv()->buffer(), true));
 
        // This doesn't make sense, if there is no selection
        if (!selection.set())
@@ -1095,7 +1161,7 @@ void LyXText::cutSelection(bool doclear, bool realcut)
        // and selection.end
 
        // make sure that the depth behind the selection are restored, too
-       ParagraphList::iterator endpit = boost::next(selection.end.par());
+       ParagraphList::iterator endpit = boost::next(getPar(selection.end.par()));
        ParagraphList::iterator undoendpit = endpit;
        ParagraphList::iterator pars_end = ownerParagraphs().end();
 
@@ -1109,39 +1175,40 @@ void LyXText::cutSelection(bool doclear, bool realcut)
                ++endpit;
        }
 
-       recordUndo(bv(), Undo::DELETE, selection.start.par(),
+       recordUndo(bv(), Undo::DELETE, getPar(selection.start),
                   boost::prior(undoendpit));
 
-       endpit = selection.end.par();
+       endpit = getPar(selection.end.par());
        int endpos = selection.end.pos();
 
+       BufferParams const & bufparams = bv()->buffer()->params();
        boost::tie(endpit, endpos) = realcut ?
-               CutAndPaste::cutSelection(bv()->buffer()->params,
+               CutAndPaste::cutSelection(bufparams,
                                          ownerParagraphs(),
-                                         selection.start.par(), endpit,
+                                         getPar(selection.start.par()), endpit,
                                          selection.start.pos(), endpos,
-                                         bv()->buffer()->params.textclass,
+                                         bufparams.textclass,
                                          doclear)
-               : CutAndPaste::eraseSelection(bv()->buffer()->params,
+               : CutAndPaste::eraseSelection(bufparams,
                                              ownerParagraphs(),
-                                             selection.start.par(), endpit,
+                                             getPar(selection.start.par()), endpit,
                                              selection.start.pos(), endpos,
                                              doclear);
        // sometimes necessary
        if (doclear)
-               selection.start.par()->stripLeadingSpaces();
+               getPar(selection.start.par())->stripLeadingSpaces();
 
-       redoParagraphs(selection.start.par(), boost::next(endpit));
+       redoParagraphs(getPar(selection.start.par()), boost::next(endpit));
        // cutSelection can invalidate the cursor so we need to set
        // it anew. (Lgb)
        // we prefer the end for when tracking changes
        cursor.pos(endpos);
-       cursor.par(endpit);
+       cursor.par(parOffset(endpit));
 
        // need a valid cursor. (Lgb)
        clearSelection();
 
-       setCursor(cursor.par(), cursor.pos());
+       setCursor(cursorPar(), cursor.pos());
        selection.cursor = cursor;
        updateCounters();
 }
@@ -1150,7 +1217,7 @@ void LyXText::cutSelection(bool doclear, bool realcut)
 void LyXText::copySelection()
 {
        // stuff the selection onto the X clipboard, from an explicit copy request
-       bv()->stuffClipboard(selectionAsString(bv()->buffer(), true));
+       bv()->stuffClipboard(selectionAsString(*bv()->buffer(), true));
 
        // this doesnt make sense, if there is no selection
        if (!selection.set())
@@ -1160,16 +1227,16 @@ void LyXText::copySelection()
        // and sel_end cursor
 
        // copy behind a space if there is one
-       while (selection.start.par()->size() > selection.start.pos()
-              && selection.start.par()->isLineSeparator(selection.start.pos())
+       while (getPar(selection.start)->size() > selection.start.pos()
+              && getPar(selection.start)->isLineSeparator(selection.start.pos())
               && (selection.start.par() != selection.end.par()
                   || selection.start.pos() < selection.end.pos()))
                selection.start.pos(selection.start.pos() + 1);
 
-       CutAndPaste::copySelection(selection.start.par(),
-                                  selection.end.par(),
+       CutAndPaste::copySelection(getPar(selection.start.par()),
+                                  getPar(selection.end.par()),
                                   selection.start.pos(), selection.end.pos(),
-                                  bv()->buffer()->params.textclass);
+                                  bv()->buffer()->params().textclass);
 }
 
 
@@ -1179,7 +1246,7 @@ void LyXText::pasteSelection(size_t sel_index)
        if (!CutAndPaste::checkPastePossible())
                return;
 
-       recordUndo(bv(), Undo::INSERT, cursor.par());
+       recordUndo(bv(), Undo::INSERT, cursorPar());
 
        ParagraphList::iterator endpit;
        PitPosPair ppp;
@@ -1189,13 +1256,13 @@ void LyXText::pasteSelection(size_t sel_index)
        boost::tie(ppp, endpit) =
                CutAndPaste::pasteSelection(*bv()->buffer(),
                                            ownerParagraphs(),
-                                           cursor.par(), cursor.pos(),
-                                           bv()->buffer()->params.textclass,
+                                           cursorPar(), cursor.pos(),
+                                           bv()->buffer()->params().textclass,
                                            sel_index, el);
        bufferErrors(*bv()->buffer(), el);
        bv()->showErrorList(_("Paste"));
 
-       redoParagraphs(cursor.par(), endpit);
+       redoParagraphs(cursorPar(), endpit);
 
        setCursor(cursor.par(), cursor.pos());
        clearSelection();
@@ -1232,15 +1299,15 @@ void LyXText::replaceSelectionWithString(string const & str)
 
        // Get font setting before we cut
        pos_type pos = selection.end.pos();
-       LyXFont const font = selection.start.par()
-               ->getFontSettings(bv()->buffer()->params,
+       LyXFont const font = getPar(selection.start)
+               ->getFontSettings(bv()->buffer()->params(),
                                  selection.start.pos());
 
        // Insert the new string
        string::const_iterator cit = str.begin();
        string::const_iterator end = str.end();
        for (; cit != end; ++cit) {
-               selection.end.par()->insertChar(pos, (*cit), font);
+               getPar(selection.end)->insertChar(pos, (*cit), font);
                ++pos;
        }
 
@@ -1254,9 +1321,9 @@ void LyXText::replaceSelectionWithString(string const & str)
 // needed to insert the selection
 void LyXText::insertStringAsLines(string const & str)
 {
-       ParagraphList::iterator pit = cursor.par();
+       ParagraphList::iterator pit = cursorPar();
        pos_type pos = cursor.pos();
-       ParagraphList::iterator endpit = boost::next(cursor.par());
+       ParagraphList::iterator endpit = boost::next(cursorPar());
 
        recordUndo(bv(), Undo::ATOMIC);
 
@@ -1265,8 +1332,8 @@ void LyXText::insertStringAsLines(string const & str)
 
        bv()->buffer()->insertStringAsLines(pit, pos, current_font, str);
 
-       redoParagraphs(cursor.par(), endpit);
-       setCursor(cursor.par(), cursor.pos());
+       redoParagraphs(cursorPar(), endpit);
+       setCursor(cursorPar(), cursor.pos());
        selection.cursor = cursor;
        setCursor(pit, pos);
        setSelection();
@@ -1301,12 +1368,16 @@ void LyXText::insertStringAsParagraphs(string const & str)
 }
 
 
-bool LyXText::setCursor(ParagraphList::iterator pit,
-                       pos_type pos,
-                       bool setfont, bool boundary)
+void LyXText::setCursor(ParagraphList::iterator pit, pos_type pos)
+{
+       setCursor(parOffset(pit), pos);
+}
+
+
+bool LyXText::setCursor(paroffset_type par, pos_type pos, bool setfont, bool boundary)
 {
        LyXCursor old_cursor = cursor;
-       setCursorIntern(pit, pos, setfont, boundary);
+       setCursorIntern(par, pos, setfont, boundary);
        return deleteEmptyParagraphMechanism(old_cursor);
 }
 
@@ -1318,42 +1389,31 @@ void LyXText::redoCursor()
 }
 
 
-void LyXText::setCursor(LyXCursor & cur, ParagraphList::iterator pit,
-                       pos_type pos, bool boundary)
+void LyXText::setCursor(LyXCursor & cur, paroffset_type par,
+       pos_type pos, bool boundary)
 {
-       Assert(pit != ownerParagraphs().end());
+       BOOST_ASSERT(par != int(ownerParagraphs().size()));
 
-       cur.par(pit);
+       cur.par(par);
        cur.pos(pos);
        cur.boundary(boundary);
-       if (noRows())
+
+       // no rows, no fun...
+       if (ownerParagraphs().begin()->rows.empty())
                return;
 
        // get the cursor y position in text
-       int y = 0;
-       RowList::iterator row = getRow(pit, pos, y);
-       RowList::iterator old_row = row;
-       // if we are before the first char of this row and are still in the
-       // same paragraph and there is a previous row then put the cursor on
-       // the end of the previous row
-       cur.iy(y + row->baseline());
-       if (row != pit->rows.begin()
-           && pos
-           && pos < pit->size()
-           && pit->getChar(pos) == Paragraph::META_INSET) {
-               InsetOld * ins = pit->getInset(pos);
-               if (ins && (ins->needFullRow() || ins->display())) {
-                       --row;
-                       y -= row->height();
-               }
-       }
+
+       ParagraphList::iterator pit = getPar(par);
+       RowList::iterator row = getRow(pit, pos);
+       int y = row->y();
 
        // y is now the beginning of the cursor row
        y += row->baseline();
        // y is now the cursor baseline
        cur.y(y);
 
-       pos_type last = lastPrintablePos(*pit, old_row);
+       pos_type last = lastPos(*pit, row);
 
        // None of these should happen, but we're scaredy-cats
        if (pos > pit->size()) {
@@ -1375,22 +1435,6 @@ void LyXText::setCursor(LyXCursor & cur, ParagraphList::iterator pit,
        float x = getCursorX(pit, row, pos, last, boundary);
        cur.x(int(x));
        cur.x_fix(cur.x());
-       if (old_row != row) {
-               x = getCursorX(pit, old_row, pos, last, boundary);
-               cur.ix(int(x));
-       } else
-               cur.ix(cur.x());
-/* We take out this for the time being because 1) the redraw code is not
-   prepared to this yet and 2) because some good policy has yet to be decided
-   while editting: for instance how to act on rows being created/deleted
-   because of DEPM.
-*/
-#if 0
-       //if the cursor is in a visible row, anchor to it
-       int topy = top_y();
-       if (topy < y && y < topy + bv()->workHeight())
-               anchor_row(row);
-#endif
 }
 
 
@@ -1407,7 +1451,7 @@ float LyXText::getCursorX(ParagraphList::iterator pit, RowList::iterator rit,
        if (last < rit_pos)
                cursor_vpos = rit_pos;
        else if (pos > last && !boundary)
-               cursor_vpos = (pit->isRightToLeftPar(bv()->buffer()->params))
+               cursor_vpos = (pit->isRightToLeftPar(bv()->buffer()->params()))
                        ? rit_pos : last + 1;
        else if (pos > rit_pos && (pos > last || boundary))
                // Place cursor after char at (logical) position pos - 1
@@ -1450,10 +1494,10 @@ float LyXText::getCursorX(ParagraphList::iterator pit, RowList::iterator rit,
 }
 
 
-void LyXText::setCursorIntern(ParagraphList::iterator pit,
+void LyXText::setCursorIntern(paroffset_type par,
                              pos_type pos, bool setfont, bool boundary)
 {
-       setCursor(cursor, pit, pos, boundary);
+       setCursor(cursor, par, pos, boundary);
        if (setfont)
                setCurrentFont();
 }
@@ -1462,7 +1506,7 @@ void LyXText::setCursorIntern(ParagraphList::iterator pit,
 void LyXText::setCurrentFont()
 {
        pos_type pos = cursor.pos();
-       ParagraphList::iterator pit = cursor.par();
+       ParagraphList::iterator pit = cursorPar();
 
        if (cursor.boundary() && pos > 0)
                --pos;
@@ -1481,14 +1525,15 @@ void LyXText::setCurrentFont()
                        }
        }
 
-       current_font = pit->getFontSettings(bv()->buffer()->params, pos);
+       BufferParams const & bufparams = bv()->buffer()->params();
+       current_font = pit->getFontSettings(bufparams, pos);
        real_current_font = getFont(pit, pos);
 
        if (cursor.pos() == pit->size() &&
-           isBoundary(bv()->buffer(), *pit, cursor.pos()) &&
+           isBoundary(*bv()->buffer(), *pit, cursor.pos()) &&
            !cursor.boundary()) {
                Language const * lang =
-                       pit->getParLanguage(bv()->buffer()->params);
+                       pit->getParLanguage(bufparams);
                current_font.setLanguage(lang);
                current_font.setNumber(LyXFont::OFF);
                real_current_font.setLanguage(lang);
@@ -1508,7 +1553,7 @@ pos_type LyXText::getColumnNearX(ParagraphList::iterator pit,
        double fill_label_hfill = rit->fill_label_hfill();
 
        pos_type vc = rit->pos();
-       pos_type last = lastPrintablePos(*pit, rit);
+       pos_type last = lastPos(*pit, rit);
        pos_type c = 0;
        LyXLayout_ptr const & layout = pit->layout();
 
@@ -1571,7 +1616,7 @@ pos_type LyXText::getColumnNearX(ParagraphList::iterator pit,
        // If lastrow is false, we don't need to compute
        // the value of rtl.
        bool const rtl = (lastrow)
-               ? pit->isRightToLeftPar(bv()->buffer()->params)
+               ? pit->isRightToLeftPar(bv()->buffer()->params())
                : false;
        if (lastrow &&
                 ((rtl  &&  left_side && vc == rit->pos() && x < tmpx - 5) ||
@@ -1586,7 +1631,7 @@ pos_type LyXText::getColumnNearX(ParagraphList::iterator pit,
                bool const rtl = (bidi_level(c) % 2 == 1);
                if (left_side == rtl) {
                        ++c;
-                       boundary = isBoundary(bv()->buffer(), *pit, c);
+                       boundary = isBoundary(*bv()->buffer(), *pit, c);
                }
        }
 
@@ -1613,56 +1658,20 @@ void LyXText::setCursorFromCoordinates(int x, int y)
 }
 
 
-namespace {
-
-       /**
-        * return true if the cursor given is at the end of a row,
-        * and the next row is filled by an inset that spans an entire
-        * row.
-        */
-       bool beforeFullRowInset(LyXText & lt, LyXCursor const & cur)
-       {
-               RowList::iterator row = lt.getRow(cur);
-               RowList::iterator next = boost::next(row);
-
-               if (next == cur.par()->rows.end() || next->pos() != cur.pos())
-                       return false;
-
-               if (cur.pos() == cur.par()->size() || !cur.par()->isInset(cur.pos()))
-                       return false;
-
-               InsetOld const * inset = cur.par()->getInset(cur.pos());
-               if (inset->needFullRow() || inset->display())
-                       return true;
-
-               return false;
-       }
-}
-
-
 void LyXText::setCursorFromCoordinates(LyXCursor & cur, int x, int y)
 {
        // Get the row first.
        ParagraphList::iterator pit;
        RowList::iterator rit = getRowNearY(y, pit);
+       y = rit->y();
+
        bool bound = false;
        pos_type const column = getColumnNearX(pit, rit, x, bound);
-       cur.par(pit);
+       cur.par(parOffset(pit));
        cur.pos(rit->pos() + column);
        cur.x(x);
        cur.y(y + rit->baseline());
 
-       if (beforeFullRowInset(*this, cur)) {
-               pos_type const last = lastPrintablePos(*pit, rit);
-               RowList::iterator next_rit = rit;
-               ParagraphList::iterator next_pit = pit;
-               nextRow(next_pit, next_rit);
-               cur.ix(int(getCursorX(pit, next_rit, cur.pos(), last, bound)));
-               cur.iy(y + rit->height() + next_rit->baseline());
-       } else {
-               cur.iy(cur.y());
-               cur.ix(cur.x());
-       }
        cur.boundary(bound);
 }
 
@@ -1673,31 +1682,30 @@ void LyXText::cursorLeft(bool internal)
                bool boundary = cursor.boundary();
                setCursor(cursor.par(), cursor.pos() - 1, true, false);
                if (!internal && !boundary &&
-                   isBoundary(bv()->buffer(), *cursor.par(), cursor.pos() + 1))
+                   isBoundary(*bv()->buffer(), *cursorPar(), cursor.pos() + 1))
                        setCursor(cursor.par(), cursor.pos() + 1, true, true);
-       } else if (cursor.par() != ownerParagraphs().begin()) {
+       } else if (cursor.par() != 0) {
                // steps into the paragraph above
-               ParagraphList::iterator pit = boost::prior(cursor.par());
-               setCursor(pit, pit->size());
+               setCursor(cursor.par() - 1, boost::prior(cursorPar())->size());
        }
 }
 
 
 void LyXText::cursorRight(bool internal)
 {
-       bool const at_end = (cursor.pos() == cursor.par()->size());
+       bool const at_end = (cursor.pos() == cursorPar()->size());
        bool const at_newline = !at_end &&
-               cursor.par()->isNewline(cursor.pos());
+               cursorPar()->isNewline(cursor.pos());
 
        if (!internal && cursor.boundary() && !at_newline)
                setCursor(cursor.par(), cursor.pos(), true, false);
        else if (!at_end) {
                setCursor(cursor.par(), cursor.pos() + 1, true, false);
                if (!internal &&
-                   isBoundary(bv()->buffer(), *cursor.par(), cursor.pos()))
+                   isBoundary(*bv()->buffer(), *cursorPar(), cursor.pos()))
                        setCursor(cursor.par(), cursor.pos(), true, true);
-       } else if (boost::next(cursor.par()) != ownerParagraphs().end())
-               setCursor(boost::next(cursor.par()), 0);
+       } else if (cursor.par() + 1 != int(ownerParagraphs().size()))
+               setCursor(cursor.par() + 1, 0);
 }
 
 
@@ -1708,8 +1716,8 @@ void LyXText::cursorUp(bool selecting)
        int y = cursor.y() - cursorRow()->baseline() - 1;
        setCursorFromCoordinates(x, y);
        if (!selecting) {
-               int topy = top_y();
-               int y1 = cursor.iy() - topy;
+               int topy = bv_owner->top_y();
+               int y1 = cursor.y() - topy;
                int y2 = y1;
                y -= topy;
                InsetOld * inset_hit = checkInsetHit(x, y1);
@@ -1734,8 +1742,8 @@ void LyXText::cursorDown(bool selecting)
        int y = cursor.y() - cursorRow()->baseline() + cursorRow()->height() + 1;
        setCursorFromCoordinates(x, y);
        if (!selecting && cursorRow() == cursorIRow()) {
-               int topy = top_y();
-               int y1 = cursor.iy() - topy;
+               int topy = bv_owner->top_y();
+               int y1 = cursor.y() - topy;
                int y2 = y1;
                y -= topy;
                InsetOld * inset_hit = checkInsetHit(x, y1);
@@ -1754,15 +1762,15 @@ void LyXText::cursorDown(bool selecting)
 void LyXText::cursorUpParagraph()
 {
        if (cursor.pos() > 0)
-               setCursor(cursor.par(), 0);
-       else if (cursor.par() != ownerParagraphs().begin())
-               setCursor(boost::prior(cursor.par()), 0);
+               setCursor(cursorPar(), 0);
+       else if (cursorPar() != ownerParagraphs().begin())
+               setCursor(boost::prior(cursorPar()), 0);
 }
 
 
 void LyXText::cursorDownParagraph()
 {
-       ParagraphList::iterator par = cursor.par();
+       ParagraphList::iterator par = cursorPar();
        ParagraphList::iterator next_par = boost::next(par);
 
        if (next_par != ownerParagraphs().end())
@@ -1788,8 +1796,8 @@ void LyXText::fixCursorAfterDelete(LyXCursor & cur, LyXCursor const & where)
 
        // check also if we don't want to set the cursor on a spot behind the
        // pagragraph because we erased the last character.
-       if (cur.pos() > cur.par()->size())
-               cur.pos(cur.par()->size());
+       if (cur.pos() > getPar(cur)->size())
+               cur.pos(getPar(cur)->size());
 
        // recompute row et al. for this cursor
        setCursor(cur, cur.par(), cur.pos(), cur.boundary());
@@ -1802,8 +1810,13 @@ bool LyXText::deleteEmptyParagraphMechanism(LyXCursor const & old_cursor)
        if (selection.set())
                return false;
 
+       // Don't do anything if the cursor is invalid
+       if (old_cursor.par() == -1)
+               return false;
+
        // We allow all kinds of "mumbo-jumbo" when freespacing.
-       if (old_cursor.par()->isFreeSpacing())
+       ParagraphList::iterator const old_pit = getPar(old_cursor);
+       if (old_pit->isFreeSpacing())
                return false;
 
        /* Ok I'll put some comments here about what is missing.
@@ -1835,11 +1848,11 @@ bool LyXText::deleteEmptyParagraphMechanism(LyXCursor const & old_cursor)
 
                // Only if the cursor has really moved
                if (old_cursor.pos() > 0
-                   && old_cursor.pos() < old_cursor.par()->size()
-                   && old_cursor.par()->isLineSeparator(old_cursor.pos())
-                   && old_cursor.par()->isLineSeparator(old_cursor.pos() - 1)) {
-                       bool erased = old_cursor.par()->erase(old_cursor.pos() - 1);
-                       redoParagraph(old_cursor.par());
+                   && old_cursor.pos() < old_pit->size()
+                   && old_pit->isLineSeparator(old_cursor.pos())
+                   && old_pit->isLineSeparator(old_cursor.pos() - 1)) {
+                       bool erased = old_pit->erase(old_cursor.pos() - 1);
+                       redoParagraph(old_pit);
 
                        if (!erased)
                                return false;
@@ -1863,7 +1876,7 @@ bool LyXText::deleteEmptyParagraphMechanism(LyXCursor const & old_cursor)
                return false;
 
        // Do not delete empty paragraphs with keepempty set.
-       if (old_cursor.par()->allowEmpty())
+       if (old_pit->allowEmpty())
                return false;
 
        // only do our magic if we changed paragraph
@@ -1874,30 +1887,29 @@ bool LyXText::deleteEmptyParagraphMechanism(LyXCursor const & old_cursor)
        // we can't possibly have deleted a paragraph before this point
        bool deleted = false;
 
-       if (old_cursor.par()->empty() ||
-           (old_cursor.par()->size() == 1 &&
-            old_cursor.par()->isLineSeparator(0))) {
+       if (old_pit->empty() ||
+           (old_pit->size() == 1 && old_pit->isLineSeparator(0))) {
                // ok, we will delete something
                LyXCursor tmpcursor;
 
                deleted = true;
 
-               bool selection_position_was_oldcursor_position = (
-                       selection.cursor.par()  == old_cursor.par()
-                       && selection.cursor.pos() == old_cursor.pos());
+               bool selection_position_was_oldcursor_position =
+                       selection.cursor.par() == old_cursor.par()
+                       && selection.cursor.pos() == old_cursor.pos();
 
                tmpcursor = cursor;
                cursor = old_cursor; // that undo can restore the right cursor position
 
-               ParagraphList::iterator endpit = boost::next(old_cursor.par());
+               ParagraphList::iterator endpit = boost::next(old_pit);
                while (endpit != ownerParagraphs().end() && endpit->getDepth())
                        ++endpit;
-       
-               recordUndo(bv(), Undo::DELETE, old_cursor.par(), boost::prior(endpit));
+
+               recordUndo(bv(), Undo::DELETE, old_pit, boost::prior(endpit));
                cursor = tmpcursor;
 
                // delete old par
-               ownerParagraphs().erase(old_cursor.par());
+               ownerParagraphs().erase(old_pit);
                redoParagraph();
 
                // correct cursor y
@@ -1909,8 +1921,8 @@ bool LyXText::deleteEmptyParagraphMechanism(LyXCursor const & old_cursor)
                }
        }
        if (!deleted) {
-               if (old_cursor.par()->stripLeadingSpaces()) {
-                       redoParagraph(old_cursor.par());
+               if (old_pit->stripLeadingSpaces()) {
+                       redoParagraph(old_pit);
                        // correct cursor y
                        setCursorIntern(cursor.par(), cursor.pos());
                        selection.cursor = cursor;
@@ -1922,7 +1934,7 @@ bool LyXText::deleteEmptyParagraphMechanism(LyXCursor const & old_cursor)
 
 ParagraphList & LyXText::ownerParagraphs() const
 {
-       return paragraphs_;
+       return *paragraphs_;
 }