]> git.lyx.org Git - lyx.git/blobdiff - src/text2.C
move some selection related stuff over to textcursor.C
[lyx.git] / src / text2.C
index c7babeb609ecf9f262e0211f224fd09dc28293e4..1b805a51404aef41b2217bba9009971372ed94a4 100644 (file)
 
 #include "lyxtext.h"
 #include "LString.h"
+#include "Lsstream.h"
 #include "paragraph.h"
+#include "funcrequest.h"
 #include "frontends/LyXView.h"
 #include "undo_funcs.h"
 #include "buffer.h"
+#include "buffer_funcs.h"
 #include "bufferparams.h"
+#include "errorlist.h"
 #include "gettext.h"
 #include "BufferView.h"
 #include "CutAndPaste.h"
 #include "paragraph_funcs.h"
 
 #include "insets/insetbibitem.h"
+#include "insets/insetenv.h"
 #include "insets/insetfloat.h"
+#include "insets/insetwrap.h"
 
 #include "support/LAssert.h"
 #include "support/textutils.h"
 #include "support/lstrings.h"
 
-#include "support/BoostFormat.h"
 #include <boost/tuple/tuple.hpp>
 
 using std::vector;
@@ -326,7 +331,7 @@ void LyXText::toggleInset()
                // No, try to see if we are inside a collapsable inset
                if (inset_owner && inset_owner->owner()
                    && inset_owner->owner()->isOpen()) {
-                       bv()->unlockInset(static_cast<UpdatableInset *>(inset_owner->owner()));
+                       bv()->unlockInset(inset_owner->owner());
                        inset_owner->owner()->close(bv());
                        bv()->getLyXText()->cursorRight(bv());
                }
@@ -389,7 +394,7 @@ LyXText::setLayout(LyXCursor & cur, LyXCursor & sstart_cur,
                ++endpit;
        }
 
-       setUndo(bv(), Undo::EDIT, sstart_cur.par(), undoendpit);
+       setUndo(bv(), Undo::EDIT, sstart_cur.par(), boost::prior(undoendpit));
 
        // ok we have a selection. This is always between sstart_cur
        // and sel_end cursor
@@ -423,22 +428,41 @@ LyXText::setLayout(LyXCursor & cur, LyXCursor & sstart_cur,
 // set layout over selection and make a total rebreak of those paragraphs
 void LyXText::setLayout(string const & layout)
 {
-       LyXCursor tmpcursor = cursor;  /* store the current cursor  */
+       LyXCursor tmpcursor = cursor;  // store the current cursor
 
        // if there is no selection just set the layout
-       // of the current paragraph  */
+       // of the current paragraph
        if (!selection.set()) {
                selection.start = cursor;  // dummy selection
                selection.end = cursor;
        }
+
+       // special handling of new environment insets
+       BufferParams const & params = bv()->buffer()->params;
+       LyXLayout_ptr const & lyxlayout = params.getLyXTextClass()[layout];
+       if (lyxlayout->is_environment) {
+               // move everything in a new environment inset
+               lyxerr << "setting layout " << layout << endl;
+               bv()->owner()->dispatch(FuncRequest(LFUN_HOME));
+               bv()->owner()->dispatch(FuncRequest(LFUN_ENDSEL));
+               bv()->owner()->dispatch(FuncRequest(LFUN_CUT));
+               Inset * inset = new InsetEnvironment(params, layout);
+               if (bv()->insertInset(inset)) {
+                       //inset->edit(bv());
+                       //bv()->owner()->dispatch(FuncRequest(LFUN_PASTE));
+               }
+               else
+                       delete inset;
+               return;
+       }
+
        ParagraphList::iterator endpit = setLayout(cursor, selection.start,
                                                   selection.end, layout);
        redoParagraphs(selection.start, endpit);
 
        // we have to reset the selection, because the
        // geometry could have changed
-       setCursor(selection.start.par(),
-                 selection.start.pos(), false);
+       setCursor(selection.start.par(), selection.start.pos(), false);
        selection.cursor = cursor;
        setCursor(selection.end.par(), selection.end.pos(), false);
        updateCounters();
@@ -463,7 +487,7 @@ bool LyXText::changeDepth(bv_funcs::DEPTH_CHANGE type, bool test_only)
        ParagraphList::iterator pastend = boost::next(end);
 
        if (!test_only)
-               setUndo(bv(), Undo::EDIT, start, pastend);
+               setUndo(bv(), Undo::EDIT, start, end);
 
        bool changed = false;
 
@@ -504,10 +528,9 @@ bool LyXText::changeDepth(bv_funcs::DEPTH_CHANGE type, bool test_only)
 
        // Wow, redoParagraphs is stupid.
        LyXCursor tmpcursor;
-       setCursor(tmpcursor, &(*start), 0);
+       setCursor(tmpcursor, start, 0);
 
-       //redoParagraphs(tmpcursor, &(*pastend));
-       redoParagraphs(tmpcursor, &(*pastend));
+       redoParagraphs(tmpcursor, pastend);
 
        // We need to actually move the text->cursor. I don't
        // understand why ...
@@ -565,8 +588,7 @@ void LyXText::setFont(LyXFont const & font, bool toggleall)
        // ok we have a selection. This is always between sel_start_cursor
        // and sel_end cursor
 
-       setUndo(bv(), Undo::EDIT,
-               selection.start.par(), boost::next(selection.end.par()));
+       setUndo(bv(), Undo::EDIT, selection.start.par(), selection.end.par());
        freezeUndo();
        cursor = selection.start;
        while (cursor.par() != selection.end.par() ||
@@ -600,7 +622,7 @@ void LyXText::setFont(LyXFont const & font, bool toggleall)
 
 void LyXText::redoHeightOfParagraph()
 {
-       RowList::iterator tmprow = cursor.row();
+       RowList::iterator tmprow = cursorRow();
        int y = cursor.y() - tmprow->baseline();
 
        setHeightOfRow(tmprow);
@@ -620,7 +642,7 @@ void LyXText::redoHeightOfParagraph()
 
 void LyXText::redoDrawingOfParagraph(LyXCursor const & cur)
 {
-       RowList::iterator tmprow = cur.row();
+       RowList::iterator tmprow = getRow(cur);
 
        int y = cur.y() - tmprow->baseline();
        setHeightOfRow(tmprow);
@@ -636,13 +658,13 @@ void LyXText::redoDrawingOfParagraph(LyXCursor const & cur)
 }
 
 
-// deletes and inserts again all paragaphs between the cursor
+// deletes and inserts again all paragraphs between the cursor
 // and the specified par
 // This function is needed after SetLayout and SetFont etc.
 void LyXText::redoParagraphs(LyXCursor const & cur,
                             ParagraphList::iterator endpit)
 {
-       RowList::iterator tmprit = cur.row();
+       RowList::iterator tmprit = getRow(cur);
        int y = cur.y() - tmprit->baseline();
 
        ParagraphList::iterator first_phys_pit;
@@ -650,7 +672,7 @@ void LyXText::redoParagraphs(LyXCursor const & cur,
        if (tmprit == rows().begin()) {
                // A trick/hack for UNDO.
                // This is needed because in an UNDO/REDO we could have
-               // changed the ownerParagrah() so the paragraph inside
+               // changed the ownerParagraph() so the paragraph inside
                // the row is NOT my really first par anymore.
                // Got it Lars ;) (Jug 20011206)
                first_phys_pit = ownerParagraphs().begin();
@@ -687,10 +709,10 @@ void LyXText::redoParagraphs(LyXCursor const & cur,
        }
        if (prevrit != rows().end()) {
                setHeightOfRow(prevrit);
-               const_cast<LyXText *>(this)->postPaint(y - prevrit->height());
+               postPaint(y - prevrit->height());
        } else {
                setHeightOfRow(rows().begin());
-               const_cast<LyXText *>(this)->postPaint(0);
+               postPaint(0);
        }
        if (tmprit != rows().end())
                setHeightOfRow(tmprit);
@@ -700,6 +722,14 @@ void LyXText::redoParagraphs(LyXCursor const & cur,
 
 
 void LyXText::fullRebreak()
+{
+       need_break_row = rows().begin();
+       partialRebreak();
+       setCursorIntern(cursor.par(), cursor.pos());
+}
+
+
+void LyXText::partialRebreak()
 {
        if (rows().empty()) {
                init(bv());
@@ -726,98 +756,18 @@ void LyXText::fullRebreak()
 // need the selection cursor:
 void LyXText::setSelection()
 {
-       bool const lsel = selection.set();
-
-       if (!selection.set()) {
-               last_sel_cursor = selection.cursor;
-               selection.start = selection.cursor;
-               selection.end = selection.cursor;
-       }
-
-       selection.set(true);
-
-       // first the toggling area
-       if (cursor.y() < last_sel_cursor.y()
-           || (cursor.y() == last_sel_cursor.y()
-               && cursor.x() < last_sel_cursor.x())) {
-               toggle_end_cursor = last_sel_cursor;
-               toggle_cursor = cursor;
-       } else {
-               toggle_end_cursor = cursor;
-               toggle_cursor = last_sel_cursor;
-       }
-
-       last_sel_cursor = cursor;
-
-       // and now the whole selection
-
-       if (selection.cursor.par() == cursor.par())
-               if (selection.cursor.pos() < cursor.pos()) {
-                       selection.end = cursor;
-                       selection.start = selection.cursor;
-               } else {
-                       selection.end = selection.cursor;
-                       selection.start = cursor;
-               }
-       else if (selection.cursor.y() < cursor.y() ||
-                (selection.cursor.y() == cursor.y()
-                 && selection.cursor.x() < cursor.x())) {
-               selection.end = cursor;
-               selection.start = selection.cursor;
-       }
-       else {
-               selection.end = selection.cursor;
-               selection.start = cursor;
-       }
-
-       // a selection with no contents is not a selection
-       if (selection.start.par() == selection.end.par() &&
-           selection.start.pos() == selection.end.pos())
-               selection.set(false);
+       bool const lsel = TextCursor::setSelection();
 
        if (inset_owner && (selection.set() || lsel))
                inset_owner->setUpdateStatus(bv(), InsetText::SELECTION);
 }
 
 
-string const LyXText::selectionAsString(Buffer const * buffer,
-                                       bool label) const
-{
-       if (!selection.set()) return string();
-
-       // should be const ...
-       ParagraphList::iterator startpit = selection.start.par();
-       ParagraphList::iterator endpit = selection.end.par();
-       pos_type const startpos(selection.start.pos());
-       pos_type const endpos(selection.end.pos());
-
-       if (startpit == endpit) {
-               return startpit->asString(buffer, startpos, endpos, label);
-       }
-
-       string result;
-
-       // First paragraph in selection
-       result += startpit->asString(buffer, startpos, startpit->size(), label) + "\n\n";
-
-       // The paragraphs in between (if any)
-       ParagraphList::iterator pit = boost::next(startpit);
-       for (; pit != endpit; ++pit) {
-               result += pit->asString(buffer, 0, pit->size(), label) + "\n\n";
-       }
-
-       // Last paragraph in selection
-       result += endpit->asString(buffer, 0, endpos, label);
-
-       return result;
-}
-
 
 void LyXText::clearSelection()
 {
-       selection.set(false);
-       selection.mark(false);
-       last_sel_cursor = selection.end = selection.start = selection.cursor = cursor;
+       TextCursor::clearSelection();
+
        // reset this in the bv_owner!
        if (bv_owner && bv_owner->text)
                bv_owner->text->xsel_cache.set(false);
@@ -826,7 +776,7 @@ void LyXText::clearSelection()
 
 void LyXText::cursorHome()
 {
-       setCursor(cursor.par(), cursor.row()->pos());
+       setCursor(cursor.par(), cursorRow()->pos());
 }
 
 
@@ -835,7 +785,7 @@ void LyXText::cursorEnd()
        if (cursor.par()->empty())
                return;
 
-       RowList::iterator rit = cursor.row();
+       RowList::iterator rit = cursorRow();
        RowList::iterator next_rit = boost::next(rit);
        ParagraphList::iterator pit = rit->par();
        pos_type last_pos = lastPos(*this, rit);
@@ -861,12 +811,9 @@ void LyXText::cursorTop()
 
 void LyXText::cursorBottom()
 {
-#warning FIXME
-       // This is how it should be:
-       // ParagraphList::iterator lastpit = boost::prior(ownerParagraphs().end());
-       ParagraphList::iterator lastpit = &ownerParagraphs().back();
-       int pos = lastpit->size();
-       setCursor(lastpit, pos);
+       ParagraphList::iterator lastpit =
+               boost::prior(ownerParagraphs().end());
+       setCursor(lastpit, lastpit->size());
 }
 
 
@@ -963,19 +910,20 @@ void LyXText::setParagraph(bool line_top, bool line_bottom,
                        ++endpit;
                        undoendpit = endpit;
                }
-       } else if (endpit!= pars_end) {
+       } else if (endpit != pars_end) {
                // because of parindents etc.
                ++endpit;
        }
 
-       setUndo(bv(), Undo::EDIT, selection.start.par(), undoendpit);
+       setUndo(bv(), Undo::EDIT, selection.start.par(),
+               boost::prior(undoendpit));
 
 
        ParagraphList::iterator tmppit = selection.end.par();
 
        while (tmppit != boost::prior(selection.start.par())) {
                setCursor(tmppit, 0);
-               postPaint(cursor.y() - cursor.row()->baseline());
+               postPaint(cursor.y() - cursorRow()->baseline());
 
                ParagraphList::iterator pit = cursor.par();
                ParagraphParameters & params = pit->params();
@@ -1168,28 +1116,26 @@ void LyXText::setCounter(Buffer const * buf, ParagraphList::iterator pit)
                                        isOK = true;
                                        break;
                                } else {
-                                       tmppit = in->parOwner();
+                                       tmppit = std::find(ownerParagraphs().begin(), ownerParagraphs().end(), *in->parOwner());
                                }
                        }
 
                        if (isOK) {
-                               Floating const & fl
-                                       = textclass.floats().getType(static_cast<InsetFloat*>(in)->type());
+                               string type;
+
+                               if (in->lyxCode() == Inset::FLOAT_CODE)
+                                       type = static_cast<InsetFloat*>(in)->params().type;
+                               else if (in->lyxCode() == Inset::WRAP_CODE)
+                                       type = static_cast<InsetWrap*>(in)->params().type;
+                               else
+                                       lyx::Assert(0);
+
+                               Floating const & fl = textclass.floats().getType(type);
 
                                textclass.counters().step(fl.type());
 
                                // Doesn't work... yet.
-#if USE_BOOST_FORMAT
-                               s = boost::io::str(boost::format(_("%1$s #:")) % buf->B_(fl.name()));
-                               // s << boost::format(_("%1$s %1$d:")
-                               //        % fl.name()
-                               //        % buf->counters().value(fl.name());
-#else
-                               ostringstream o;
-                               //o << fl.name() << ' ' << buf->counters().value(fl.name()) << ":";
-                               o << buf->B_(fl.name()) << " #:";
-                               s = STRCONV(o.str());
-#endif
+                               s = bformat(_("%1$s #:"), buf->B_(fl.name()));
                        } else {
                                // par->SetLayout(0);
                                // s = layout->labelstring;
@@ -1225,14 +1171,16 @@ void LyXText::updateCounters()
        // CHECK if this is really needed. (Lgb)
        bv()->buffer()->params.getLyXTextClass().counters().reset();
 
-       for (; pit != ownerParagraphs().end(); ++pit) {
+       ParagraphList::iterator beg = ownerParagraphs().begin();
+       ParagraphList::iterator end = ownerParagraphs().end();
+       for (; pit != end; ++pit) {
                while (rowit->par() != pit)
                        ++rowit;
 
                string const oldLabel = pit->params().labelString();
 
-               int maxdepth = 0;
-               if (pit != ownerParagraphs().begin())
+               size_t maxdepth = 0;
+               if (pit != beg)
                        maxdepth = boost::prior(pit)->getMaxDepthAfter();
 
                if (pit->params().depth() > maxdepth)
@@ -1255,8 +1203,7 @@ void LyXText::insertInset(Inset * inset)
 {
        if (!cursor.par()->insetAllowed(inset->lyxCode()))
                return;
-       setUndo(bv(), Undo::FINISH, cursor.par(),
-               boost::next(cursor.par()));
+       setUndo(bv(), Undo::FINISH, cursor.par());
        freezeUndo();
        cursor.par()->insertInset(cursor.pos(), inset);
        // Just to rebreak and refresh correctly.
@@ -1308,19 +1255,22 @@ void LyXText::cutSelection(bool doclear, bool realcut)
                ++endpit;
        }
 
-       setUndo(bv(), Undo::DELETE, selection.start.par(), undoendpit);
+       setUndo(bv(), Undo::DELETE, selection.start.par(),
+               boost::prior(undoendpit));
 
 
        endpit = selection.end.par();
        int endpos = selection.end.pos();
 
        boost::tie(endpit, endpos) = realcut ?
-               CutAndPaste::cutSelection(ownerParagraphs(),
+               CutAndPaste::cutSelection(bv()->buffer()->params,
+                                         ownerParagraphs(),
                                          selection.start.par(), endpit,
                                          selection.start.pos(), endpos,
                                          bv()->buffer()->params.textclass,
                                          doclear)
-               : CutAndPaste::eraseSelection(ownerParagraphs(),
+               : CutAndPaste::eraseSelection(bv()->buffer()->params,
+                                             ownerParagraphs(),
                                              selection.start.par(), endpit,
                                              selection.start.pos(), endpos,
                                              doclear);
@@ -1374,23 +1324,28 @@ void LyXText::copySelection()
 }
 
 
-void LyXText::pasteSelection()
+void LyXText::pasteSelection(size_t sel_index)
 {
        // this does not make sense, if there is nothing to paste
        if (!CutAndPaste::checkPastePossible())
                return;
 
-       setUndo(bv(), Undo::INSERT,
-               cursor.par(), boost::next(cursor.par()));
+       setUndo(bv(), Undo::INSERT, cursor.par());
 
        ParagraphList::iterator endpit;
        PitPosPair ppp;
 
-       boost::tie(ppp, endpit) = 
-               CutAndPaste::pasteSelection(ownerParagraphs(), 
-                                           cursor.par(), cursor.pos(), 
-                                           bv()->buffer()->params.textclass);
-       
+       ErrorList el;
+
+       boost::tie(ppp, endpit) =
+               CutAndPaste::pasteSelection(*bv()->buffer(),
+                                           ownerParagraphs(),
+                                           cursor.par(), cursor.pos(),
+                                           bv()->buffer()->params.textclass,
+                                           sel_index, el);
+       parseErrors(*bv()->buffer(), el);
+       bv()->showErrorList(_("Paste"));
+
        redoParagraphs(cursor, endpit);
 
        setCursor(cursor.par(), cursor.pos());
@@ -1433,7 +1388,9 @@ void LyXText::replaceSelectionWithString(string const & str)
                                  selection.start.pos());
 
        // Insert the new string
-       for (string::const_iterator cit = str.begin(); cit != str.end(); ++cit) {
+       string::const_iterator cit = str.begin();
+       string::const_iterator end = str.end();
+       for (; cit != end; ++cit) {
                selection.end.par()->insertChar(pos, (*cit), font);
                ++pos;
        }
@@ -1473,7 +1430,9 @@ void LyXText::insertStringAsParagraphs(string const & str)
 {
        string linestr(str);
        bool newline_inserted = false;
-       for (string::size_type i = 0; i < linestr.length(); ++i) {
+       string::size_type const siz = linestr.length();
+
+       for (string::size_type i = 0; i < siz; ++i) {
                if (linestr[i] == '\n') {
                        if (newline_inserted) {
                                // we know that \r will be ignored by
@@ -1535,7 +1494,6 @@ void LyXText::checkParagraph(ParagraphList::iterator pit, pos_type pos)
        // check the special right address boxes
        if (pit->layout()->margintype == MARGIN_RIGHT_ADDRESS_BOX) {
                tmpcursor.par(pit);
-               tmpcursor.row(row);
                tmpcursor.y(y);
                tmpcursor.x(0);
                tmpcursor.x_fix(0);
@@ -1638,7 +1596,6 @@ void LyXText::setCursor(LyXCursor & cur, ParagraphList::iterator pit,
                }
        }
 
-       cur.row(row);
        // y is now the beginning of the cursor row
        y += row->baseline();
        // y is now the cursor baseline
@@ -1750,7 +1707,7 @@ float LyXText::getCursorX(RowList::iterator rit,
 void LyXText::setCursorIntern(ParagraphList::iterator pit,
                              pos_type pos, bool setfont, bool boundary)
 {
-       InsetText * it = static_cast<InsetText *>(pit->inInset());
+       UpdatableInset * it = pit->inInset();
        if (it) {
                if (it != inset_owner) {
                        lyxerr[Debug::INSETS] << "InsetText   is " << it
@@ -1795,7 +1752,7 @@ void LyXText::setCurrentFont()
                        --pos;
                else // potentional bug... BUG (Lgb)
                        if (pit->isSeparator(pos)) {
-                               if (pos > cursor.row()->pos() &&
+                               if (pos > cursorRow()->pos() &&
                                    bidi_level(pos) % 2 ==
                                    bidi_level(pos - 1) % 2)
                                        --pos;
@@ -1863,7 +1820,7 @@ LyXText::getColumnNearX(RowList::iterator rit, int & x, bool & boundary) const
                if (body_pos > 0 && c == body_pos - 1) {
                        tmpx += fill_label_hfill +
                                font_metrics::width(layout->labelsep,
-                                              getLabelFont(bv()->buffer(), &*rit_par));
+                                              getLabelFont(bv()->buffer(), rit_par));
                        if (rit_par->isLineSeparator(body_pos - 1))
                                tmpx -= singleWidth(rit_par, body_pos - 1);
                }
@@ -1895,9 +1852,12 @@ LyXText::getColumnNearX(RowList::iterator rit, int & x, bool & boundary) const
        boundary = false;
        // This (rtl_support test) is not needed, but gives
        // some speedup if rtl_support=false
+       RowList::iterator next_rit = boost::next(rit);
+
        bool const lastrow = lyxrc.rtl_support &&
-               (boost::next(rit) == rowlist_.end() ||
-                boost::next(rit)->par() != rit_par);
+               (next_rit == rowlist_.end() ||
+                next_rit->par() != rit_par);
+
        // If lastrow is false, we don't need to compute
        // the value of rtl.
        bool const rtl = (lastrow)
@@ -1952,10 +1912,12 @@ namespace {
         * and the next row is filled by an inset that spans an entire
         * row.
         */
-       bool beforeFullRowInset(LyXText & lt, LyXCursor const & cur) {
-               RowList::iterator row = cur.row();
+       bool beforeFullRowInset(LyXText & lt, LyXCursor const & cur)
+       {
+               RowList::iterator row = lt.getRow(cur);
                if (boost::next(row) == lt.rows().end())
                        return false;
+
                Row const & next = *boost::next(row);
 
                if (next.pos() != cur.pos() || next.par() != cur.par())
@@ -1964,9 +1926,11 @@ namespace {
                if (cur.pos() == cur.par()->size()
                    || !cur.par()->isInset(cur.pos()))
                        return false;
+
                Inset const * inset = cur.par()->getInset(cur.pos());
                if (inset->needFullRow() || inset->display())
                        return true;
+
                return false;
        }
 }
@@ -1983,14 +1947,15 @@ void LyXText::setCursorFromCoordinates(LyXCursor & cur, int x, int y)
        cur.pos(row->pos() + column);
        cur.x(x);
        cur.y(y + row->baseline());
-       cur.row(row);
 
        if (beforeFullRowInset(*this, cur)) {
-               pos_type last = lastPrintablePos(*this, row);
-               float x = getCursorX(boost::next(row), cur.pos(), last, bound);
+               pos_type const last = lastPrintablePos(*this, row);
+               RowList::iterator next_row = boost::next(row);
+
+               float x = getCursorX(next_row, cur.pos(), last, bound);
                cur.ix(int(x));
-               cur.iy(y + row->height() + boost::next(row)->baseline());
-               cur.irow(boost::next(row));
+               cur.iy(y + row->height() + next_row->baseline());
+               cur.irow(next_row);
        } else {
                cur.iy(cur.y());
                cur.ix(cur.x());
@@ -2037,7 +2002,7 @@ void LyXText::cursorUp(bool selecting)
 {
 #if 1
        int x = cursor.x_fix();
-       int y = cursor.y() - cursor.row()->baseline() - 1;
+       int y = cursor.y() - cursorRow()->baseline() - 1;
        setCursorFromCoordinates(x, y);
        if (!selecting) {
                int topy = top_y();
@@ -2046,12 +2011,13 @@ void LyXText::cursorUp(bool selecting)
                y -= topy;
                Inset * inset_hit = checkInsetHit(x, y1);
                if (inset_hit && isHighlyEditableInset(inset_hit)) {
-                       inset_hit->edit(bv(), x, y - (y2 - y1), mouse_button::none);
+                       inset_hit->localDispatch(
+                               FuncRequest(bv(), LFUN_INSET_EDIT, x, y - (y2 - y1), mouse_button::none));
                }
        }
 #else
        setCursorFromCoordinates(bv(), cursor.x_fix(),
-                                cursor.y() - cursor.row()->baseline() - 1);
+                                cursor.y() - cursorRow()->baseline() - 1);
 #endif
 }
 
@@ -2060,23 +2026,24 @@ void LyXText::cursorDown(bool selecting)
 {
 #if 1
        int x = cursor.x_fix();
-       int y = cursor.y() - cursor.row()->baseline() +
-               cursor.row()->height() + 1;
+       int y = cursor.y() - cursorRow()->baseline() +
+               cursorRow()->height() + 1;
        setCursorFromCoordinates(x, y);
-       if (!selecting && cursor.row() == cursor.irow()) {
+       if (!selecting && cursorRow() == cursor.irow()) {
                int topy = top_y();
                int y1 = cursor.iy() - topy;
                int y2 = y1;
                y -= topy;
                Inset * inset_hit = checkInsetHit(x, y1);
                if (inset_hit && isHighlyEditableInset(inset_hit)) {
-                       inset_hit->edit(bv(), x, y - (y2 - y1), mouse_button::none);
+                       FuncRequest cmd(bv(), LFUN_INSET_EDIT, x, y - (y2 - y1), mouse_button::none);
+                       inset_hit->localDispatch(cmd);
                }
        }
 #else
        setCursorFromCoordinates(bv(), cursor.x_fix(),
-                                cursor.y() - cursor.row()->baseline()
-                                + cursor.row()->height() + 1);
+                                cursor.y() - cursorRow()->baseline()
+                                + cursorRow()->height() + 1);
 #endif
 }
 
@@ -2094,10 +2061,13 @@ void LyXText::cursorUpParagraph()
 
 void LyXText::cursorDownParagraph()
 {
-       if (boost::next(cursor.par()) != ownerParagraphs().end()) {
-               setCursor(boost::next(cursor.par()), 0);
+       ParagraphList::iterator par = cursor.par();
+       ParagraphList::iterator next_par = boost::next(par);
+
+       if (next_par != ownerParagraphs().end()) {
+               setCursor(next_par, 0);
        } else {
-               setCursor(cursor.par(), cursor.par()->size());
+               setCursor(par, par->size());
        }
 }
 
@@ -2200,7 +2170,7 @@ bool LyXText::deleteEmptyParagraphMechanism(LyXCursor const & old_cursor)
                return false;
 
        // Do not delete empty paragraphs with keepempty set.
-       if (old_cursor.par()->layout()->keepempty)
+       if (old_cursor.par()->allowEmpty())
                return false;
 
        // only do our magic if we changed paragraph
@@ -2223,10 +2193,10 @@ bool LyXText::deleteEmptyParagraphMechanism(LyXCursor const & old_cursor)
                        selection.cursor.par()  == old_cursor.par()
                        && selection.cursor.pos() == old_cursor.pos());
 
-               if (old_cursor.row() != rows().begin()) {
+               if (getRow(old_cursor) != rows().begin()) {
                        RowList::iterator
-                               prevrow = boost::prior(old_cursor.row());
-                       const_cast<LyXText *>(this)->postPaint(old_cursor.y() - old_cursor.row()->baseline() - prevrow->height());
+                               prevrow = boost::prior(getRow(old_cursor));
+                       postPaint(old_cursor.y() - getRow(old_cursor)->baseline() - prevrow->height());
                        tmpcursor = cursor;
                        cursor = old_cursor; // that undo can restore the right cursor position
                        #warning FIXME. --end() iterator is usable here
@@ -2236,11 +2206,12 @@ bool LyXText::deleteEmptyParagraphMechanism(LyXCursor const & old_cursor)
                                ++endpit;
                        }
 
-                       setUndo(bv(), Undo::DELETE, old_cursor.par(), endpit);
+                       setUndo(bv(), Undo::DELETE, old_cursor.par(),
+                               boost::prior(endpit));
                        cursor = tmpcursor;
 
                        // delete old row
-                       removeRow(old_cursor.row());
+                       removeRow(getRow(old_cursor));
                        // delete old par
                        ownerParagraphs().erase(old_cursor.par());
 
@@ -2248,15 +2219,15 @@ bool LyXText::deleteEmptyParagraphMechanism(LyXCursor const & old_cursor)
                         * the parindent that can occur or dissappear.
                         * The next row can change its height, if
                         * there is another layout before */
-                       if (boost::next(prevrow) != rows().end()) {
-                               breakAgain(boost::next(prevrow));
+                       RowList::iterator tmprit = boost::next(prevrow);
+                       if (tmprit != rows().end()) {
+                               breakAgain(tmprit);
                                updateCounters();
                        }
                        setHeightOfRow(prevrow);
                } else {
-                       RowList::iterator nextrow = boost::next(old_cursor.row());
-                       const_cast<LyXText *>(this)->postPaint(
-                               old_cursor.y() - old_cursor.row()->baseline());
+                       RowList::iterator nextrow = boost::next(getRow(old_cursor));
+                       postPaint(old_cursor.y() - getRow(old_cursor)->baseline());
 
                        tmpcursor = cursor;
                        cursor = old_cursor; // that undo can restore the right cursor position
@@ -2267,11 +2238,11 @@ bool LyXText::deleteEmptyParagraphMechanism(LyXCursor const & old_cursor)
                                ++endpit;
                        }
 
-                       setUndo(bv(), Undo::DELETE, old_cursor.par(), endpit);
+                       setUndo(bv(), Undo::DELETE, old_cursor.par(), boost::prior(endpit));
                        cursor = tmpcursor;
 
                        // delete old row
-                       removeRow(old_cursor.row());
+                       removeRow(getRow(old_cursor));
                        // delete old par
                        ownerParagraphs().erase(old_cursor.par());
 
@@ -2346,7 +2317,7 @@ void LyXText::postPaint(int start_y)
        // We are an inset's lyxtext. Tell the top-level lyxtext
        // it needs to update the row we're in.
        LyXText * t = bv()->text;
-       t->postRowPaint(t->cursor.row(), t->cursor.y() - t->cursor.row()->baseline());
+       t->postRowPaint(t->cursorRow(), t->cursor.y() - t->cursorRow()->baseline());
 }
 
 
@@ -2373,7 +2344,7 @@ void LyXText::postRowPaint(RowList::iterator rit, int start_y)
        // We are an inset's lyxtext. Tell the top-level lyxtext
        // it needs to update the row we're in.
        LyXText * t = bv()->text;
-       t->postRowPaint(t->cursor.row(), t->cursor.y() - t->cursor.row()->baseline());
+       t->postRowPaint(t->cursorRow(), t->cursor.y() - t->cursorRow()->baseline());
 }