]> git.lyx.org Git - lyx.git/blobdiff - src/text2.C
cosmetic fix
[lyx.git] / src / text2.C
index 27f4e64374493242a1ab49381de0c89375569e44..0231873fdba58e52a297de778a16b46248ce909c 100644 (file)
 
 #include "lyxtext.h"
 #include "LString.h"
+#include "Lsstream.h"
 #include "paragraph.h"
+#include "funcrequest.h"
 #include "frontends/LyXView.h"
 #include "undo_funcs.h"
 #include "buffer.h"
+#include "buffer_funcs.h"
 #include "bufferparams.h"
+#include "errorlist.h"
 #include "gettext.h"
 #include "BufferView.h"
 #include "CutAndPaste.h"
 #include "ParagraphParameters.h"
 #include "counters.h"
 #include "lyxrow_funcs.h"
+#include "metricsinfo.h"
 #include "paragraph_funcs.h"
 
 #include "insets/insetbibitem.h"
+#include "insets/insetenv.h"
 #include "insets/insetfloat.h"
+#include "insets/insetwrap.h"
 
 #include "support/LAssert.h"
 #include "support/textutils.h"
 #include "support/lstrings.h"
 
-#include "support/BoostFormat.h"
 #include <boost/tuple/tuple.hpp>
 
+#include <algorithm>
+
+using namespace lyx::support;
+
 using std::vector;
 using std::copy;
 using std::endl;
@@ -56,9 +66,7 @@ LyXText::LyXText(BufferView * bv)
 {
        anchor_row_ = rows().end();
        need_break_row = rows().end();
-       refresh_row = rows().end();
-
-       clearPaint();
+       need_refresh_ = true;
 }
 
 
@@ -68,31 +76,30 @@ LyXText::LyXText(BufferView * bv, InsetText * inset)
 {
        anchor_row_ = rows().end();
        need_break_row = rows().end();
-       refresh_row = rows().end();
-
-       clearPaint();
+       need_refresh_ = true;
 }
 
 
-void LyXText::init(BufferView * bview, bool reinit)
+void LyXText::init(BufferView * bview)
 {
-       if (reinit) {
-               rowlist_.clear();
-               need_break_row = rows().end();
-               width = height = 0;
-               top_y(0);
-               clearPaint();
-       } else if (!rowlist_.empty())
-               return;
+       bv_owner = bview;
+
+       rowlist_.clear();
+       need_break_row = rows().end();
+       width = height = 0;
+       need_refresh_ = true;
+
+       anchor_row_ = rows().end();
+       anchor_row_offset_ = 0;
 
        ParagraphList::iterator pit = ownerParagraphs().begin();
        ParagraphList::iterator end = ownerParagraphs().end();
 
        current_font = getFont(bview->buffer(), pit, 0);
 
-       for (; pit != end; ++pit) {
+       for (; pit != end; ++pit)
                insertParagraph(pit, rowlist_.end());
-       }
+
        setCursorIntern(rowlist_.begin()->par(), 0);
        selection.cursor = cursor;
 
@@ -110,7 +117,7 @@ void LyXText::init(BufferView * bview, bool reinit)
 LyXFont const LyXText::getFont(Buffer const * buf, ParagraphList::iterator pit,
                               pos_type pos) const
 {
-       lyx::Assert(pos >= 0);
+       Assert(pos >= 0);
 
        LyXLayout_ptr const & layout = pit->layout();
 
@@ -199,7 +206,7 @@ void LyXText::setCharFont(ParagraphList::iterator pit,
        font.update(fnt, buf->params.language, toggleall);
        // Let the insets convert their font
        if (pit->isInset(pos)) {
-               Inset * inset = pit->getInset(pos);
+               InsetOld * inset = pit->getInset(pos);
                if (isEditableInset(inset)) {
                        UpdatableInset * uinset =
                                static_cast<UpdatableInset *>(inset);
@@ -252,17 +259,6 @@ void LyXText::setCharFont(Buffer const * buf, ParagraphList::iterator pit,
 // removes the row and reset the touched counters
 void LyXText::removeRow(RowList::iterator rit)
 {
-       /* FIXME: when we cache the bview, this should just
-        * become a postPaint(), I think */
-       if (refresh_row == rit) {
-               if (rit == rows().begin())
-                       refresh_row = boost::next(rit);
-               else
-                       refresh_row = boost::prior(rit);
-
-               // what about refresh_y
-       }
-
        if (anchor_row_ == rit) {
                if (rit != rows().begin()) {
                        anchor_row_ = boost::prior(rit);
@@ -306,7 +302,7 @@ void LyXText::insertParagraph(ParagraphList::iterator pit,
 }
 
 
-Inset * LyXText::getInset() const
+InsetOld * LyXText::getInset() const
 {
        ParagraphList::iterator pit = cursor.par();
        pos_type const pos = cursor.pos();
@@ -320,13 +316,13 @@ Inset * LyXText::getInset() const
 
 void LyXText::toggleInset()
 {
-       Inset * inset = getInset();
+       InsetOld * inset = getInset();
        // is there an editable inset at cursor position?
        if (!isEditableInset(inset)) {
                // No, try to see if we are inside a collapsable inset
                if (inset_owner && inset_owner->owner()
                    && inset_owner->owner()->isOpen()) {
-                       bv()->unlockInset(static_cast<UpdatableInset *>(inset_owner->owner()));
+                       bv()->unlockInset(inset_owner->owner());
                        inset_owner->owner()->close(bv());
                        bv()->getLyXText()->cursorRight(bv());
                }
@@ -336,7 +332,7 @@ void LyXText::toggleInset()
 
        // do we want to keep this?? (JMarc)
        if (!isHighlyEditableInset(inset))
-               setCursorParUndo(bv());
+               recordUndo(bv(), Undo::ATOMIC);
 
        if (inset->isOpen()) {
                inset->close(bv());
@@ -389,7 +385,7 @@ LyXText::setLayout(LyXCursor & cur, LyXCursor & sstart_cur,
                ++endpit;
        }
 
-       setUndo(bv(), Undo::EDIT, sstart_cur.par(), undoendpit);
+       recordUndo(bv(), Undo::ATOMIC, sstart_cur.par(), boost::prior(undoendpit));
 
        // ok we have a selection. This is always between sstart_cur
        // and sel_end cursor
@@ -423,22 +419,41 @@ LyXText::setLayout(LyXCursor & cur, LyXCursor & sstart_cur,
 // set layout over selection and make a total rebreak of those paragraphs
 void LyXText::setLayout(string const & layout)
 {
-       LyXCursor tmpcursor = cursor;  /* store the current cursor  */
+       LyXCursor tmpcursor = cursor;  // store the current cursor
 
        // if there is no selection just set the layout
-       // of the current paragraph  */
+       // of the current paragraph
        if (!selection.set()) {
                selection.start = cursor;  // dummy selection
                selection.end = cursor;
        }
+
+       // special handling of new environment insets
+       BufferParams const & params = bv()->buffer()->params;
+       LyXLayout_ptr const & lyxlayout = params.getLyXTextClass()[layout];
+       if (lyxlayout->is_environment) {
+               // move everything in a new environment inset
+               lyxerr << "setting layout " << layout << endl;
+               bv()->owner()->dispatch(FuncRequest(LFUN_HOME));
+               bv()->owner()->dispatch(FuncRequest(LFUN_ENDSEL));
+               bv()->owner()->dispatch(FuncRequest(LFUN_CUT));
+               InsetOld * inset = new InsetEnvironment(params, layout);
+               if (bv()->insertInset(inset)) {
+                       //inset->edit(bv());
+                       //bv()->owner()->dispatch(FuncRequest(LFUN_PASTE));
+               }
+               else
+                       delete inset;
+               return;
+       }
+
        ParagraphList::iterator endpit = setLayout(cursor, selection.start,
                                                   selection.end, layout);
        redoParagraphs(selection.start, endpit);
 
        // we have to reset the selection, because the
        // geometry could have changed
-       setCursor(selection.start.par(),
-                 selection.start.pos(), false);
+       setCursor(selection.start.par(), selection.start.pos(), false);
        selection.cursor = cursor;
        setCursor(selection.end.par(), selection.end.pos(), false);
        updateCounters();
@@ -463,7 +478,7 @@ bool LyXText::changeDepth(bv_funcs::DEPTH_CHANGE type, bool test_only)
        ParagraphList::iterator pastend = boost::next(end);
 
        if (!test_only)
-               setUndo(bv(), Undo::EDIT, start, pastend);
+               recordUndo(bv(), Undo::ATOMIC, start, end);
 
        bool changed = false;
 
@@ -504,10 +519,9 @@ bool LyXText::changeDepth(bv_funcs::DEPTH_CHANGE type, bool test_only)
 
        // Wow, redoParagraphs is stupid.
        LyXCursor tmpcursor;
-       setCursor(tmpcursor, &(*start), 0);
+       setCursor(tmpcursor, start, 0);
 
-       //redoParagraphs(tmpcursor, &(*pastend));
-       redoParagraphs(tmpcursor, &(*pastend));
+       redoParagraphs(tmpcursor, pastend);
 
        // We need to actually move the text->cursor. I don't
        // understand why ...
@@ -565,8 +579,7 @@ void LyXText::setFont(LyXFont const & font, bool toggleall)
        // ok we have a selection. This is always between sel_start_cursor
        // and sel_end cursor
 
-       setUndo(bv(), Undo::EDIT,
-               selection.start.par(), boost::next(selection.end.par()));
+       recordUndo(bv(), Undo::ATOMIC, selection.start.par(), selection.end.par());
        freezeUndo();
        cursor = selection.start;
        while (cursor.par() != selection.end.par() ||
@@ -600,57 +613,36 @@ void LyXText::setFont(LyXFont const & font, bool toggleall)
 
 void LyXText::redoHeightOfParagraph()
 {
-       RowList::iterator tmprow = cursor.row();
-       int y = cursor.y() - tmprow->baseline();
+       RowList::iterator tmprow = cursorRow();
 
        setHeightOfRow(tmprow);
 
        while (tmprow != rows().begin()
               && boost::prior(tmprow)->par() == tmprow->par()) {
                --tmprow;
-               y -= tmprow->height();
                setHeightOfRow(tmprow);
        }
 
-       postPaint(y);
+       postPaint();
 
        setCursor(cursor.par(), cursor.pos(), false, cursor.boundary());
 }
 
 
-void LyXText::redoDrawingOfParagraph(LyXCursor const & cur)
-{
-       RowList::iterator tmprow = cur.row();
-
-       int y = cur.y() - tmprow->baseline();
-       setHeightOfRow(tmprow);
-
-       while (tmprow != rows().begin()
-              && boost::prior(tmprow)->par() == tmprow->par())  {
-               --tmprow;
-               y -= tmprow->height();
-       }
-
-       postPaint(y);
-       setCursor(cur.par(), cur.pos());
-}
-
-
-// deletes and inserts again all paragaphs between the cursor
+// deletes and inserts again all paragraphs between the cursor
 // and the specified par
 // This function is needed after SetLayout and SetFont etc.
 void LyXText::redoParagraphs(LyXCursor const & cur,
                             ParagraphList::iterator endpit)
 {
-       RowList::iterator tmprit = cur.row();
-       int y = cur.y() - tmprit->baseline();
+       RowList::iterator tmprit = getRow(cur);
 
        ParagraphList::iterator first_phys_pit;
        RowList::iterator prevrit;
        if (tmprit == rows().begin()) {
                // A trick/hack for UNDO.
                // This is needed because in an UNDO/REDO we could have
-               // changed the ownerParagrah() so the paragraph inside
+               // changed the ownerParagraph() so the paragraph inside
                // the row is NOT my really first par anymore.
                // Got it Lars ;) (Jug 20011206)
                first_phys_pit = ownerParagraphs().begin();
@@ -661,7 +653,6 @@ void LyXText::redoParagraphs(LyXCursor const & cur,
                       && boost::prior(tmprit)->par() == first_phys_pit)
                {
                        --tmprit;
-                       y -= tmprit->height();
                }
                prevrit = boost::prior(tmprit);
        }
@@ -685,13 +676,11 @@ void LyXText::redoParagraphs(LyXCursor const & cur,
                if (tmppit == endpit)
                        break;
        }
-       if (prevrit != rows().end()) {
+       if (prevrit != rows().end())
                setHeightOfRow(prevrit);
-               const_cast<LyXText *>(this)->postPaint(y - prevrit->height());
-       } else {
+       else
                setHeightOfRow(rows().begin());
-               const_cast<LyXText *>(this)->postPaint(0);
-       }
+       postPaint();
        if (tmprit != rows().end())
                setHeightOfRow(tmprit);
 
@@ -700,6 +689,59 @@ void LyXText::redoParagraphs(LyXCursor const & cur,
 
 
 void LyXText::fullRebreak()
+{
+       init(bv());
+       setCursorIntern(cursor.par(), cursor.pos());
+}
+
+
+void LyXText::metrics(MetricsInfo & mi, Dimension & dim)
+{
+       //lyxerr << "LyXText::metrics: width: " << mi.base.textwidth << "\n";
+
+       // rebuild row cache
+       rowlist_.clear();
+       need_break_row = rows().end();
+       width = height = 0;
+
+       anchor_row_ = rows().end();
+       anchor_row_offset_ = 0;
+
+       ParagraphList::iterator pit = ownerParagraphs().begin();
+       ParagraphList::iterator end = ownerParagraphs().end();
+
+       for (; pit != end; ++pit) {
+               InsetList::iterator ii = pit->insetlist.begin();
+               InsetList::iterator iend = pit->insetlist.end();
+               for (; ii != iend; ++ii) {
+                       Dimension dim;
+                       MetricsInfo m = mi;
+                       ii->inset->metrics(m, dim);
+               }
+
+               // insert a new row, starting at position 0
+               Row newrow(pit, 0);
+               RowList::iterator rit = rowlist_.insert(rowlist_.end(), newrow);
+
+               // and now append the whole paragraph before the new row
+               appendParagraph(rit);
+       }
+
+       // compute height
+       //lyxerr << "height 0: " << height << "\n";
+       //for (RowList::iterator rit = rows().begin(); rit != rows().end(); ++rit) {
+       //      height += rit->height();
+       //}
+       //lyxerr << "height 1: " << height << "\n";
+
+       // final dimension
+       dim.asc = rows().begin()->ascent_of_text();
+       dim.des = height - dim.asc;
+       dim.wid = std::max(mi.base.textwidth, int(width));
+}
+
+
+void LyXText::partialRebreak()
 {
        if (rows().empty()) {
                init(bv());
@@ -726,98 +768,18 @@ void LyXText::fullRebreak()
 // need the selection cursor:
 void LyXText::setSelection()
 {
-       bool const lsel = selection.set();
-
-       if (!selection.set()) {
-               last_sel_cursor = selection.cursor;
-               selection.start = selection.cursor;
-               selection.end = selection.cursor;
-       }
-
-       selection.set(true);
-
-       // first the toggling area
-       if (cursor.y() < last_sel_cursor.y()
-           || (cursor.y() == last_sel_cursor.y()
-               && cursor.x() < last_sel_cursor.x())) {
-               toggle_end_cursor = last_sel_cursor;
-               toggle_cursor = cursor;
-       } else {
-               toggle_end_cursor = cursor;
-               toggle_cursor = last_sel_cursor;
-       }
-
-       last_sel_cursor = cursor;
-
-       // and now the whole selection
-
-       if (selection.cursor.par() == cursor.par())
-               if (selection.cursor.pos() < cursor.pos()) {
-                       selection.end = cursor;
-                       selection.start = selection.cursor;
-               } else {
-                       selection.end = selection.cursor;
-                       selection.start = cursor;
-               }
-       else if (selection.cursor.y() < cursor.y() ||
-                (selection.cursor.y() == cursor.y()
-                 && selection.cursor.x() < cursor.x())) {
-               selection.end = cursor;
-               selection.start = selection.cursor;
-       }
-       else {
-               selection.end = selection.cursor;
-               selection.start = cursor;
-       }
-
-       // a selection with no contents is not a selection
-       if (selection.start.par() == selection.end.par() &&
-           selection.start.pos() == selection.end.pos())
-               selection.set(false);
+       bool const lsel = TextCursor::setSelection();
 
        if (inset_owner && (selection.set() || lsel))
-               inset_owner->setUpdateStatus(bv(), InsetText::SELECTION);
+               inset_owner->setUpdateStatus(InsetText::SELECTION);
 }
 
 
-string const LyXText::selectionAsString(Buffer const * buffer,
-                                       bool label) const
-{
-       if (!selection.set()) return string();
-
-       // should be const ...
-       ParagraphList::iterator startpit = selection.start.par();
-       ParagraphList::iterator endpit = selection.end.par();
-       pos_type const startpos(selection.start.pos());
-       pos_type const endpos(selection.end.pos());
-
-       if (startpit == endpit) {
-               return startpit->asString(buffer, startpos, endpos, label);
-       }
-
-       string result;
-
-       // First paragraph in selection
-       result += startpit->asString(buffer, startpos, startpit->size(), label) + "\n\n";
-
-       // The paragraphs in between (if any)
-       ParagraphList::iterator pit = boost::next(startpit);
-       for (; pit != endpit; ++pit) {
-               result += pit->asString(buffer, 0, pit->size(), label) + "\n\n";
-       }
-
-       // Last paragraph in selection
-       result += endpit->asString(buffer, 0, endpos, label);
-
-       return result;
-}
-
 
 void LyXText::clearSelection()
 {
-       selection.set(false);
-       selection.mark(false);
-       last_sel_cursor = selection.end = selection.start = selection.cursor = cursor;
+       TextCursor::clearSelection();
+
        // reset this in the bv_owner!
        if (bv_owner && bv_owner->text)
                bv_owner->text->xsel_cache.set(false);
@@ -826,7 +788,7 @@ void LyXText::clearSelection()
 
 void LyXText::cursorHome()
 {
-       setCursor(cursor.par(), cursor.row()->pos());
+       setCursor(cursor.par(), cursorRow()->pos());
 }
 
 
@@ -835,7 +797,7 @@ void LyXText::cursorEnd()
        if (cursor.par()->empty())
                return;
 
-       RowList::iterator rit = cursor.row();
+       RowList::iterator rit = cursorRow();
        RowList::iterator next_rit = boost::next(rit);
        ParagraphList::iterator pit = rit->par();
        pos_type last_pos = lastPos(*this, rit);
@@ -861,12 +823,9 @@ void LyXText::cursorTop()
 
 void LyXText::cursorBottom()
 {
-#warning FIXME
-       // This is how it should be:
-       // ParagraphList::iterator lastpit = boost::prior(ownerParagraphs().end());
-       ParagraphList::iterator lastpit = &ownerParagraphs().back();
-       int pos = lastpit->size();
-       setCursor(lastpit, pos);
+       ParagraphList::iterator lastpit =
+               boost::prior(ownerParagraphs().end());
+       setCursor(lastpit, lastpit->size());
 }
 
 
@@ -885,7 +844,7 @@ void LyXText::toggleFree(LyXFont const & font, bool toggleall)
        LyXCursor resetCursor = cursor;
        bool implicitSelection = (font.language() == ignore_language
                                  && font.number() == LyXFont::IGNORE)
-               ? selectWordWhenUnderCursor(WHOLE_WORD_STRICT) : false;
+               ? selectWordWhenUnderCursor(lyx::WHOLE_WORD_STRICT) : false;
 
        // Set font
        setFont(font, toggleall);
@@ -899,7 +858,7 @@ void LyXText::toggleFree(LyXFont const & font, bool toggleall)
                selection.cursor = cursor;
        }
        if (inset_owner)
-               inset_owner->setUpdateStatus(bv(), InsetText::CURSOR_PAR);
+               inset_owner->setUpdateStatus(InsetText::CURSOR_PAR);
 }
 
 
@@ -909,7 +868,8 @@ string LyXText::getStringToIndex()
        // If there is a change in the language the implicit word selection
        // is disabled.
        LyXCursor const reset_cursor = cursor;
-       bool const implicitSelection = selectWordWhenUnderCursor(PREVIOUS_WORD);
+       bool const implicitSelection =
+               selectWordWhenUnderCursor(lyx::PREVIOUS_WORD);
 
        string idxstring;
        if (!selection.set())
@@ -963,19 +923,19 @@ void LyXText::setParagraph(bool line_top, bool line_bottom,
                        ++endpit;
                        undoendpit = endpit;
                }
-       } else if (endpit!= pars_end) {
+       } else if (endpit != pars_end) {
                // because of parindents etc.
                ++endpit;
        }
 
-       setUndo(bv(), Undo::EDIT, selection.start.par(), undoendpit);
+       recordUndo(bv(), Undo::ATOMIC, selection.start.par(),
+               boost::prior(undoendpit));
 
 
        ParagraphList::iterator tmppit = selection.end.par();
 
        while (tmppit != boost::prior(selection.start.par())) {
                setCursor(tmppit, 0);
-               postPaint(cursor.y() - cursor.row()->baseline());
 
                ParagraphList::iterator pit = cursor.par();
                ParagraphParameters & params = pit->params();
@@ -1002,6 +962,7 @@ void LyXText::setParagraph(bool line_top, bool line_bottom,
                params.noindent(noindent);
                tmppit = boost::prior(pit);
        }
+       postPaint();
 
        redoParagraphs(selection.start, endpit);
 
@@ -1157,39 +1118,37 @@ void LyXText::setCounter(Buffer const * buf, ParagraphList::iterator pit)
                // the caption hack:
                if (layout->labeltype == LABEL_SENSITIVE) {
                        ParagraphList::iterator tmppit = pit;
-                       Inset * in = 0;
+                       InsetOld * in = 0;
                        bool isOK = false;
                        while (tmppit != ownerParagraphs().end() &&
                               tmppit->inInset()
                               // the single '=' is intended below
                               && (in = tmppit->inInset()->owner())) {
-                               if (in->lyxCode() == Inset::FLOAT_CODE ||
-                                   in->lyxCode() == Inset::WRAP_CODE) {
+                               if (in->lyxCode() == InsetOld::FLOAT_CODE ||
+                                   in->lyxCode() == InsetOld::WRAP_CODE) {
                                        isOK = true;
                                        break;
                                } else {
-                                       tmppit = in->parOwner();
+                                       tmppit = std::find(ownerParagraphs().begin(), ownerParagraphs().end(), *in->parOwner());
                                }
                        }
 
                        if (isOK) {
-                               Floating const & fl
-                                       = textclass.floats().getType(static_cast<InsetFloat*>(in)->type());
+                               string type;
+
+                               if (in->lyxCode() == InsetOld::FLOAT_CODE)
+                                       type = static_cast<InsetFloat*>(in)->params().type;
+                               else if (in->lyxCode() == InsetOld::WRAP_CODE)
+                                       type = static_cast<InsetWrap*>(in)->params().type;
+                               else
+                                       Assert(0);
+
+                               Floating const & fl = textclass.floats().getType(type);
 
                                textclass.counters().step(fl.type());
 
                                // Doesn't work... yet.
-#if USE_BOOST_FORMAT
-                               s = boost::io::str(boost::format(_("%1$s #:")) % buf->B_(fl.name()));
-                               // s << boost::format(_("%1$s %1$d:")
-                               //        % fl.name()
-                               //        % buf->counters().value(fl.name());
-#else
-                               ostringstream o;
-                               //o << fl.name() << ' ' << buf->counters().value(fl.name()) << ":";
-                               o << buf->B_(fl.name()) << " #:";
-                               s = STRCONV(o.str());
-#endif
+                               s = bformat(_("%1$s #:"), buf->B_(fl.name()));
                        } else {
                                // par->SetLayout(0);
                                // s = layout->labelstring;
@@ -1225,14 +1184,16 @@ void LyXText::updateCounters()
        // CHECK if this is really needed. (Lgb)
        bv()->buffer()->params.getLyXTextClass().counters().reset();
 
-       for (; pit != ownerParagraphs().end(); ++pit) {
+       ParagraphList::iterator beg = ownerParagraphs().begin();
+       ParagraphList::iterator end = ownerParagraphs().end();
+       for (; pit != end; ++pit) {
                while (rowit->par() != pit)
                        ++rowit;
 
                string const oldLabel = pit->params().labelString();
 
-               int maxdepth = 0;
-               if (pit != ownerParagraphs().begin())
+               size_t maxdepth = 0;
+               if (pit != beg)
                        maxdepth = boost::prior(pit)->getMaxDepthAfter();
 
                if (pit->params().depth() > maxdepth)
@@ -1251,12 +1212,11 @@ void LyXText::updateCounters()
 }
 
 
-void LyXText::insertInset(Inset * inset)
+void LyXText::insertInset(InsetOld * inset)
 {
        if (!cursor.par()->insetAllowed(inset->lyxCode()))
                return;
-       setUndo(bv(), Undo::FINISH, cursor.par(),
-               boost::next(cursor.par()));
+       recordUndo(bv(), Undo::ATOMIC, cursor.par());
        freezeUndo();
        cursor.par()->insertInset(cursor.pos(), inset);
        // Just to rebreak and refresh correctly.
@@ -1308,19 +1268,22 @@ void LyXText::cutSelection(bool doclear, bool realcut)
                ++endpit;
        }
 
-       setUndo(bv(), Undo::DELETE, selection.start.par(), undoendpit);
+       recordUndo(bv(), Undo::DELETE, selection.start.par(),
+               boost::prior(undoendpit));
 
 
        endpit = selection.end.par();
        int endpos = selection.end.pos();
 
        boost::tie(endpit, endpos) = realcut ?
-               CutAndPaste::cutSelection(ownerParagraphs(),
+               CutAndPaste::cutSelection(bv()->buffer()->params,
+                                         ownerParagraphs(),
                                          selection.start.par(), endpit,
                                          selection.start.pos(), endpos,
                                          bv()->buffer()->params.textclass,
                                          doclear)
-               : CutAndPaste::eraseSelection(ownerParagraphs(),
+               : CutAndPaste::eraseSelection(bv()->buffer()->params,
+                                             ownerParagraphs(),
                                              selection.start.par(), endpit,
                                              selection.start.pos(), endpos,
                                              doclear);
@@ -1367,37 +1330,42 @@ void LyXText::copySelection()
                   || selection.start.pos() < selection.end.pos()))
                selection.start.pos(selection.start.pos() + 1);
 
-       CutAndPaste::copySelection(&*selection.start.par(),
-                                  &*selection.end.par(),
+       CutAndPaste::copySelection(selection.start.par(),
+                                  selection.end.par(),
                                   selection.start.pos(), selection.end.pos(),
                                   bv()->buffer()->params.textclass);
 }
 
 
-void LyXText::pasteSelection()
+void LyXText::pasteSelection(size_t sel_index)
 {
        // this does not make sense, if there is nothing to paste
        if (!CutAndPaste::checkPastePossible())
                return;
 
-       setUndo(bv(), Undo::INSERT,
-               cursor.par(), boost::next(cursor.par()));
+       recordUndo(bv(), Undo::INSERT, cursor.par());
+
+       ParagraphList::iterator endpit;
+       PitPosPair ppp;
 
-       Paragraph * endpar;
-       ParagraphList::iterator actpit = cursor.par();
-       int pos = cursor.pos();
+       ErrorList el;
 
-       Paragraph * actpar = &*actpit;
-       CutAndPaste::pasteSelection(&actpar, &endpar, pos,
-                                   bv()->buffer()->params.textclass);
+       boost::tie(ppp, endpit) =
+               CutAndPaste::pasteSelection(*bv()->buffer(),
+                                           ownerParagraphs(),
+                                           cursor.par(), cursor.pos(),
+                                           bv()->buffer()->params.textclass,
+                                           sel_index, el);
+       bufferErrors(*bv()->buffer(), el);
+       bv()->showErrorList(_("Paste"));
 
-       redoParagraphs(cursor, endpar);
+       redoParagraphs(cursor, endpit);
 
        setCursor(cursor.par(), cursor.pos());
        clearSelection();
 
        selection.cursor = cursor;
-       setCursor(actpit, pos);
+       setCursor(ppp.first, ppp.second);
        setSelection();
        updateCounters();
 }
@@ -1418,7 +1386,7 @@ void LyXText::setSelectionRange(lyx::pos_type length)
 // simple replacing. The font of the first selected character is used
 void LyXText::replaceSelectionWithString(string const & str)
 {
-       setCursorParUndo(bv());
+       recordUndo(bv(), Undo::ATOMIC);
        freezeUndo();
 
        if (!selection.set()) { // create a dummy selection
@@ -1433,7 +1401,9 @@ void LyXText::replaceSelectionWithString(string const & str)
                                  selection.start.pos());
 
        // Insert the new string
-       for (string::const_iterator cit = str.begin(); cit != str.end(); ++cit) {
+       string::const_iterator cit = str.begin();
+       string::const_iterator end = str.end();
+       for (; cit != end; ++cit) {
                selection.end.par()->insertChar(pos, (*cit), font);
                ++pos;
        }
@@ -1452,7 +1422,7 @@ void LyXText::insertStringAsLines(string const & str)
        pos_type pos = cursor.pos();
        ParagraphList::iterator endpit = boost::next(cursor.par());
 
-       setCursorParUndo(bv());
+       recordUndo(bv(), Undo::ATOMIC);
 
        // only to be sure, should not be neccessary
        clearSelection();
@@ -1473,7 +1443,9 @@ void LyXText::insertStringAsParagraphs(string const & str)
 {
        string linestr(str);
        bool newline_inserted = false;
-       for (string::size_type i = 0; i < linestr.length(); ++i) {
+       string::size_type const siz = linestr.length();
+
+       for (string::size_type i = 0; i < siz; ++i) {
                if (linestr[i] == '\n') {
                        if (newline_inserted) {
                                // we know that \r will be ignored by
@@ -1497,19 +1469,16 @@ void LyXText::checkParagraph(ParagraphList::iterator pit, pos_type pos)
 {
        LyXCursor tmpcursor;
 
-       int y = 0;
        pos_type z;
-       RowList::iterator row = getRow(pit, pos, y);
+       RowList::iterator row = getRow(pit, pos);
        RowList::iterator beg = rows().begin();
 
        // is there a break one row above
-       if (row != beg
-           && boost::prior(row)->par() == row->par()) {
+       if (row != beg && boost::prior(row)->par() == row->par()) {
                z = rowBreakPoint(*boost::prior(row));
                if (z >= row->pos()) {
                        // set the dimensions of the row above
-                       y -= boost::prior(row)->height();
-                       postPaint(y);
+                       postPaint();
 
                        breakAgain(boost::prior(row));
 
@@ -1522,26 +1491,8 @@ void LyXText::checkParagraph(ParagraphList::iterator pit, pos_type pos)
                }
        }
 
-       int const tmpheight = row->height();
-       pos_type const tmplast = lastPos(*this, row);
-
        breakAgain(row);
-       if (row->height() == tmpheight && lastPos(*this, row) == tmplast) {
-               postRowPaint(row, y);
-       } else {
-               postPaint(y);
-       }
-
-       // check the special right address boxes
-       if (pit->layout()->margintype == MARGIN_RIGHT_ADDRESS_BOX) {
-               tmpcursor.par(pit);
-               tmpcursor.row(row);
-               tmpcursor.y(y);
-               tmpcursor.x(0);
-               tmpcursor.x_fix(0);
-               tmpcursor.pos(pos);
-               redoDrawingOfParagraph(tmpcursor);
-       }
+       postPaint();
 
        // set the cursor again. Otherwise dangling pointers are possible
        // also set the selection
@@ -1571,7 +1522,7 @@ void LyXText::checkParagraph(ParagraphList::iterator pit, pos_type pos)
 
 
 // returns false if inset wasn't found
-bool LyXText::updateInset(Inset * inset)
+bool LyXText::updateInset(InsetOld * inset)
 {
        // first check the current paragraph
        int pos = cursor.par()->getPositionOfInset(inset);
@@ -1609,11 +1560,13 @@ bool LyXText::setCursor(ParagraphList::iterator pit,
 void LyXText::setCursor(LyXCursor & cur, ParagraphList::iterator pit,
                        pos_type pos, bool boundary)
 {
-       lyx::Assert(pit != ownerParagraphs().end());
+       Assert(pit != ownerParagraphs().end());
 
        cur.par(pit);
        cur.pos(pos);
        cur.boundary(boundary);
+       if (rows().empty())
+               return;
 
        // get the cursor y position in text
        int y = 0;
@@ -1621,7 +1574,6 @@ void LyXText::setCursor(LyXCursor & cur, ParagraphList::iterator pit,
        RowList::iterator beg = rows().begin();
 
        RowList::iterator old_row = row;
-       cur.irow(row);
        // if we are before the first char of this row and are still in the
        // same paragraph and there is a previous row then put the cursor on
        // the end of the previous row
@@ -1631,14 +1583,13 @@ void LyXText::setCursor(LyXCursor & cur, ParagraphList::iterator pit,
            boost::prior(row)->par() == row->par() &&
            pos < pit->size() &&
            pit->getChar(pos) == Paragraph::META_INSET) {
-               Inset * ins = pit->getInset(pos);
+               InsetOld * ins = pit->getInset(pos);
                if (ins && (ins->needFullRow() || ins->display())) {
                        --row;
                        y -= row->height();
                }
        }
 
-       cur.row(row);
        // y is now the beginning of the cursor row
        y += row->baseline();
        // y is now the cursor baseline
@@ -1689,10 +1640,10 @@ float LyXText::getCursorX(RowList::iterator rit,
                          pos_type pos, pos_type last, bool boundary) const
 {
        pos_type cursor_vpos = 0;
-       float x;
-       float fill_separator;
-       float fill_hfill;
-       float fill_label_hfill;
+       int x;
+       int fill_separator;
+       int fill_hfill;
+       int fill_label_hfill;
        // This call HAS to be here because of the BidiTables!!!
        prepareToPrint(rit, x, fill_separator, fill_hfill,
                       fill_label_hfill);
@@ -1750,7 +1701,7 @@ float LyXText::getCursorX(RowList::iterator rit,
 void LyXText::setCursorIntern(ParagraphList::iterator pit,
                              pos_type pos, bool setfont, bool boundary)
 {
-       InsetText * it = static_cast<InsetText *>(pit->inInset());
+       UpdatableInset * it = pit->inInset();
        if (it) {
                if (it != inset_owner) {
                        lyxerr[Debug::INSETS] << "InsetText   is " << it
@@ -1795,7 +1746,7 @@ void LyXText::setCurrentFont()
                        --pos;
                else // potentional bug... BUG (Lgb)
                        if (pit->isSeparator(pos)) {
-                               if (pos > cursor.row()->pos() &&
+                               if (pos > cursorRow()->pos() &&
                                    bidi_level(pos) % 2 ==
                                    bidi_level(pos - 1) % 2)
                                        --pos;
@@ -1826,13 +1777,12 @@ void LyXText::setCurrentFont()
 pos_type
 LyXText::getColumnNearX(RowList::iterator rit, int & x, bool & boundary) const
 {
-       float tmpx = 0.0;
-       float fill_separator;
-       float fill_hfill;
-       float fill_label_hfill;
+       int tmpx = 0;
+       int fill_separator;
+       int fill_hfill;
+       int fill_label_hfill;
 
-       prepareToPrint(rit, tmpx, fill_separator,
-                      fill_hfill, fill_label_hfill);
+       prepareToPrint(rit, tmpx, fill_separator, fill_hfill, fill_label_hfill);
 
        pos_type vc = rit->pos();
        pos_type last = lastPrintablePos(*this, rit);
@@ -1844,7 +1794,7 @@ LyXText::getColumnNearX(RowList::iterator rit, int & x, bool & boundary) const
        bool left_side = false;
 
        pos_type body_pos = rit_par->beginningOfBody();
-       float last_tmpx = tmpx;
+       int last_tmpx = tmpx;
 
        if (body_pos > 0 &&
            (body_pos - 1 > last ||
@@ -1853,7 +1803,7 @@ LyXText::getColumnNearX(RowList::iterator rit, int & x, bool & boundary) const
 
        // check for empty row
        if (!rit_par->size()) {
-               x = int(tmpx);
+               x = tmpx;
                return 0;
        }
 
@@ -1863,7 +1813,7 @@ LyXText::getColumnNearX(RowList::iterator rit, int & x, bool & boundary) const
                if (body_pos > 0 && c == body_pos - 1) {
                        tmpx += fill_label_hfill +
                                font_metrics::width(layout->labelsep,
-                                              getLabelFont(bv()->buffer(), &*rit_par));
+                                              getLabelFont(bv()->buffer(), rit_par));
                        if (rit_par->isLineSeparator(body_pos - 1))
                                tmpx -= singleWidth(rit_par, body_pos - 1);
                }
@@ -1877,7 +1827,7 @@ LyXText::getColumnNearX(RowList::iterator rit, int & x, bool & boundary) const
                } else if (rit_par->isSeparator(c)) {
                        tmpx += singleWidth(rit_par, c);
                        if (c >= body_pos)
-                               tmpx+= fill_separator;
+                               tmpx += fill_separator;
                } else {
                        tmpx += singleWidth(rit_par, c);
                }
@@ -1895,9 +1845,12 @@ LyXText::getColumnNearX(RowList::iterator rit, int & x, bool & boundary) const
        boundary = false;
        // This (rtl_support test) is not needed, but gives
        // some speedup if rtl_support=false
+       RowList::iterator next_rit = boost::next(rit);
+
        bool const lastrow = lyxrc.rtl_support &&
-               (boost::next(rit) == rowlist_.end() ||
-                boost::next(rit)->par() != rit_par);
+               (next_rit == rowlist_.end() ||
+                next_rit->par() != rit_par);
+
        // If lastrow is false, we don't need to compute
        // the value of rtl.
        bool const rtl = (lastrow)
@@ -1937,11 +1890,11 @@ LyXText::getColumnNearX(RowList::iterator rit, int & x, bool & boundary) const
 
 void LyXText::setCursorFromCoordinates(int x, int y)
 {
-       LyXCursor old_cursor = cursor;
-
+       //LyXCursor old_cursor = cursor;
        setCursorFromCoordinates(cursor, x, y);
        setCurrentFont();
-       deleteEmptyParagraphMechanism(old_cursor);
+#warning DEPM disabled, otherwise crash when entering new table
+       //deleteEmptyParagraphMechanism(old_cursor);
 }
 
 
@@ -1952,10 +1905,12 @@ namespace {
         * and the next row is filled by an inset that spans an entire
         * row.
         */
-       bool beforeFullRowInset(LyXText & lt, LyXCursor const & cur) {
-               RowList::iterator row = cur.row();
+       bool beforeFullRowInset(LyXText & lt, LyXCursor const & cur)
+       {
+               RowList::iterator row = lt.getRow(cur);
                if (boost::next(row) == lt.rows().end())
                        return false;
+
                Row const & next = *boost::next(row);
 
                if (next.pos() != cur.pos() || next.par() != cur.par())
@@ -1964,9 +1919,11 @@ namespace {
                if (cur.pos() == cur.par()->size()
                    || !cur.par()->isInset(cur.pos()))
                        return false;
-               Inset const * inset = cur.par()->getInset(cur.pos());
+
+               InsetOld const * inset = cur.par()->getInset(cur.pos());
                if (inset->needFullRow() || inset->display())
                        return true;
+
                return false;
        }
 }
@@ -1983,18 +1940,17 @@ void LyXText::setCursorFromCoordinates(LyXCursor & cur, int x, int y)
        cur.pos(row->pos() + column);
        cur.x(x);
        cur.y(y + row->baseline());
-       cur.row(row);
 
        if (beforeFullRowInset(*this, cur)) {
-               pos_type last = lastPrintablePos(*this, row);
-               float x = getCursorX(boost::next(row), cur.pos(), last, bound);
+               pos_type const last = lastPrintablePos(*this, row);
+               RowList::iterator next_row = boost::next(row);
+
+               float x = getCursorX(next_row, cur.pos(), last, bound);
                cur.ix(int(x));
-               cur.iy(y + row->height() + boost::next(row)->baseline());
-               cur.irow(boost::next(row));
+               cur.iy(y + row->height() + next_row->baseline());
        } else {
                cur.iy(cur.y());
                cur.ix(cur.x());
-               cur.irow(row);
        }
        cur.boundary(bound);
 }
@@ -2037,21 +1993,22 @@ void LyXText::cursorUp(bool selecting)
 {
 #if 1
        int x = cursor.x_fix();
-       int y = cursor.y() - cursor.row()->baseline() - 1;
+       int y = cursor.y() - cursorRow()->baseline() - 1;
        setCursorFromCoordinates(x, y);
        if (!selecting) {
                int topy = top_y();
                int y1 = cursor.iy() - topy;
                int y2 = y1;
                y -= topy;
-               Inset * inset_hit = checkInsetHit(x, y1);
+               InsetOld * inset_hit = checkInsetHit(x, y1);
                if (inset_hit && isHighlyEditableInset(inset_hit)) {
-                       inset_hit->edit(bv(), x, y - (y2 - y1), mouse_button::none);
+                       inset_hit->localDispatch(
+                               FuncRequest(bv(), LFUN_INSET_EDIT, x, y - (y2 - y1), mouse_button::none));
                }
        }
 #else
        setCursorFromCoordinates(bv(), cursor.x_fix(),
-                                cursor.y() - cursor.row()->baseline() - 1);
+                                cursor.y() - cursorRow()->baseline() - 1);
 #endif
 }
 
@@ -2060,23 +2017,23 @@ void LyXText::cursorDown(bool selecting)
 {
 #if 1
        int x = cursor.x_fix();
-       int y = cursor.y() - cursor.row()->baseline() +
-               cursor.row()->height() + 1;
+       int y = cursor.y() - cursorRow()->baseline() + cursorRow()->height() + 1;
        setCursorFromCoordinates(x, y);
-       if (!selecting && cursor.row() == cursor.irow()) {
+       if (!selecting && cursorRow() == cursorIRow()) {
                int topy = top_y();
                int y1 = cursor.iy() - topy;
                int y2 = y1;
                y -= topy;
-               Inset * inset_hit = checkInsetHit(x, y1);
+               InsetOld * inset_hit = checkInsetHit(x, y1);
                if (inset_hit && isHighlyEditableInset(inset_hit)) {
-                       inset_hit->edit(bv(), x, y - (y2 - y1), mouse_button::none);
+                       FuncRequest cmd(bv(), LFUN_INSET_EDIT, x, y - (y2 - y1), mouse_button::none);
+                       inset_hit->localDispatch(cmd);
                }
        }
 #else
        setCursorFromCoordinates(bv(), cursor.x_fix(),
-                                cursor.y() - cursor.row()->baseline()
-                                + cursor.row()->height() + 1);
+                                cursor.y() - cursorRow()->baseline()
+                                + cursorRow()->height() + 1);
 #endif
 }
 
@@ -2094,10 +2051,13 @@ void LyXText::cursorUpParagraph()
 
 void LyXText::cursorDownParagraph()
 {
-       if (boost::next(cursor.par()) != ownerParagraphs().end()) {
-               setCursor(boost::next(cursor.par()), 0);
+       ParagraphList::iterator par = cursor.par();
+       ParagraphList::iterator next_par = boost::next(par);
+
+       if (next_par != ownerParagraphs().end()) {
+               setCursor(next_par, 0);
        } else {
-               setCursor(cursor.par(), cursor.par()->size());
+               setCursor(par, par->size());
        }
 }
 
@@ -2200,7 +2160,7 @@ bool LyXText::deleteEmptyParagraphMechanism(LyXCursor const & old_cursor)
                return false;
 
        // Do not delete empty paragraphs with keepempty set.
-       if (old_cursor.par()->layout()->keepempty)
+       if (old_cursor.par()->allowEmpty())
                return false;
 
        // only do our magic if we changed paragraph
@@ -2223,10 +2183,9 @@ bool LyXText::deleteEmptyParagraphMechanism(LyXCursor const & old_cursor)
                        selection.cursor.par()  == old_cursor.par()
                        && selection.cursor.pos() == old_cursor.pos());
 
-               if (old_cursor.row() != rows().begin()) {
-                       RowList::iterator
-                               prevrow = boost::prior(old_cursor.row());
-                       const_cast<LyXText *>(this)->postPaint(old_cursor.y() - old_cursor.row()->baseline() - prevrow->height());
+               if (getRow(old_cursor) != rows().begin()) {
+                       RowList::iterator prevrow = boost::prior(getRow(old_cursor));
+                       postPaint();
                        tmpcursor = cursor;
                        cursor = old_cursor; // that undo can restore the right cursor position
                        #warning FIXME. --end() iterator is usable here
@@ -2236,11 +2195,12 @@ bool LyXText::deleteEmptyParagraphMechanism(LyXCursor const & old_cursor)
                                ++endpit;
                        }
 
-                       setUndo(bv(), Undo::DELETE, old_cursor.par(), endpit);
+                       recordUndo(bv(), Undo::DELETE, old_cursor.par(),
+                               boost::prior(endpit));
                        cursor = tmpcursor;
 
                        // delete old row
-                       removeRow(old_cursor.row());
+                       removeRow(getRow(old_cursor));
                        // delete old par
                        ownerParagraphs().erase(old_cursor.par());
 
@@ -2248,15 +2208,15 @@ bool LyXText::deleteEmptyParagraphMechanism(LyXCursor const & old_cursor)
                         * the parindent that can occur or dissappear.
                         * The next row can change its height, if
                         * there is another layout before */
-                       if (boost::next(prevrow) != rows().end()) {
-                               breakAgain(boost::next(prevrow));
+                       RowList::iterator tmprit = boost::next(prevrow);
+                       if (tmprit != rows().end()) {
+                               breakAgain(tmprit);
                                updateCounters();
                        }
                        setHeightOfRow(prevrow);
                } else {
-                       RowList::iterator nextrow = boost::next(old_cursor.row());
-                       const_cast<LyXText *>(this)->postPaint(
-                               old_cursor.y() - old_cursor.row()->baseline());
+                       RowList::iterator nextrow = boost::next(getRow(old_cursor));
+                       postPaint();
 
                        tmpcursor = cursor;
                        cursor = old_cursor; // that undo can restore the right cursor position
@@ -2267,11 +2227,11 @@ bool LyXText::deleteEmptyParagraphMechanism(LyXCursor const & old_cursor)
                                ++endpit;
                        }
 
-                       setUndo(bv(), Undo::DELETE, old_cursor.par(), endpit);
+                       recordUndo(bv(), Undo::DELETE, old_cursor.par(), boost::prior(endpit));
                        cursor = tmpcursor;
 
                        // delete old row
-                       removeRow(old_cursor.row());
+                       removeRow(getRow(old_cursor));
                        // delete old par
                        ownerParagraphs().erase(old_cursor.par());
 
@@ -2314,66 +2274,26 @@ ParagraphList & LyXText::ownerParagraphs() const
 }
 
 
-LyXText::refresh_status LyXText::refreshStatus() const
+bool LyXText::needRefresh() const
 {
-       return refresh_status_;
+       return need_refresh_;
 }
 
 
 void LyXText::clearPaint()
 {
-       refresh_status_ = REFRESH_NONE;
-       refresh_row = rows().end();
-       refresh_y = 0;
+       need_refresh_ = false;
 }
 
 
-void LyXText::postPaint(int start_y)
+void LyXText::postPaint()
 {
-       refresh_status old = refresh_status_;
-
-       refresh_status_ = REFRESH_AREA;
-       refresh_row = rows().end();
-
-       if (old != REFRESH_NONE && refresh_y < start_y)
-               return;
-
-       refresh_y = start_y;
-
-       if (!inset_owner)
-               return;
+       need_refresh_ = true;
 
        // We are an inset's lyxtext. Tell the top-level lyxtext
        // it needs to update the row we're in.
-       LyXText * t = bv()->text;
-       t->postRowPaint(t->cursor.row(), t->cursor.y() - t->cursor.row()->baseline());
-}
-
-
-// FIXME: we should probably remove this y parameter,
-// make refresh_y be 0, and use row->y etc.
-void LyXText::postRowPaint(RowList::iterator rit, int start_y)
-{
-       if (refresh_status_ != REFRESH_NONE && refresh_y < start_y) {
-               refresh_status_ = REFRESH_AREA;
-               return;
-       } else {
-               refresh_y = start_y;
-       }
-
-       if (refresh_status_ == REFRESH_AREA)
-               return;
-
-       refresh_status_ = REFRESH_ROW;
-       refresh_row = rit;
-
-       if (!inset_owner)
-               return;
-
-       // We are an inset's lyxtext. Tell the top-level lyxtext
-       // it needs to update the row we're in.
-       LyXText * t = bv()->text;
-       t->postRowPaint(t->cursor.row(), t->cursor.y() - t->cursor.row()->baseline());
+       if (inset_owner)
+               bv()->text->postPaint();
 }