]> git.lyx.org Git - lyx.git/blobdiff - src/text.C
layout as string
[lyx.git] / src / text.C
index 0a965a0d32052bbc49945177706df79d4f9469bb..04152131f3762414206b422e0d75bd985a31f7cc 100644 (file)
@@ -11,9 +11,9 @@
 #include <config.h>
 
 #include "lyxtext.h"
-#include "layout.h"
+#include "lyxrow.h"
+#include "lyxtextclasslist.h"
 #include "paragraph.h"
-#include "lyx_gui_misc.h"
 #include "gettext.h"
 #include "bufferparams.h"
 #include "buffer.h"
@@ -45,6 +45,7 @@ using std::max;
 using std::min;
 using std::endl;
 using std::pair;
+using lyx::pos_type;
 
 namespace {
 
@@ -67,24 +68,32 @@ int LyXText::workWidth(BufferView * bview) const
 int LyXText::workWidth(BufferView * bview, Inset * inset) const
 {
        Paragraph * par = 0;
-       Paragraph::size_type pos = 0;
-
-       Buffer::inset_iterator it = bview->buffer()->inset_iterator_begin();
-
-       for (; it != bview->buffer()->inset_iterator_end(); ++it) {
-               if (*it == inset) {
-                       par = it.getPar();
-                       pos = it.getPos();
-                       break;
+       pos_type pos = -1;
+
+       par = inset->parOwner();
+       if (par)
+               pos = par->getPositionOfInset(inset);
+
+       if (!par || pos == -1) {
+               lyxerr << "LyXText::workWidth: something is wrong,"
+                       " fall back to the brute force method" << endl;
+               Buffer::inset_iterator it = bview->buffer()->inset_iterator_begin();
+               Buffer::inset_iterator end = bview->buffer()->inset_iterator_end();
+               for (; it != end; ++it) {
+                       if (*it == inset) {
+                               par = it.getPar();
+                               pos = it.getPos();
+                               break;
+                       }
                }
        }
+       
        if (!par) {
                return workWidth(bview);
        }
        
        LyXLayout const & layout =
-               textclasslist.Style(bview->buffer()->params.textclass,
-                                   par->getLayout());
+               textclasslist[bview->buffer()->params.textclass][par->layout()];
 
        if (layout.margintype != MARGIN_RIGHT_ADDRESS_BOX) {
                // Optimization here: in most cases, the real row is
@@ -98,10 +107,10 @@ int LyXText::workWidth(BufferView * bview, Inset * inset) const
                int dummy_y;
                Row * row = getRow(par, pos, dummy_y);
                Row * frow = row;
-               while(frow->previous() && frow->par() == frow->previous()->par())
+               while (frow->previous() && frow->par() == frow->previous()->par())
                        frow = frow->previous();
                unsigned int maxw = 0;
-               while(frow->next() && frow->par() == frow->next()->par()) {
+               while (frow->next() && frow->par() == frow->next()->par()) {
                        if ((frow != row) && (maxw < frow->width()))
                                maxw = frow->width();
                        frow = frow->next();
@@ -123,10 +132,10 @@ int LyXText::getRealCursorX(BufferView * bview) const
 
 
 unsigned char LyXText::transformChar(unsigned char c, Paragraph * par,
-                       Paragraph::size_type pos) const
+                       pos_type pos) const
 {
        if (!Encodings::is_arabic(c))
-               if (lyxrc.font_norm_type == LyXRC::ISO_8859_6_8 && isdigit(c))
+               if (lyxrc.font_norm_type == LyXRC::ISO_8859_6_8 && IsDigit(c))
                        return c + (0xb0 - '0');
                else
                        return c;
@@ -134,7 +143,7 @@ unsigned char LyXText::transformChar(unsigned char c, Paragraph * par,
        unsigned char const prev_char = pos > 0 ? par->getChar(pos-1) : ' ';
        unsigned char next_char = ' ';
 
-       for (Paragraph::size_type i = pos+1; i < par->size(); ++i)
+       for (pos_type i = pos+1; i < par->size(); ++i)
                if (!Encodings::IsComposeChar_arabic(par->getChar(i))) {
                        next_char = par->getChar(i);
                        break;
@@ -179,7 +188,7 @@ unsigned char LyXText::transformChar(unsigned char c, Paragraph * par,
 // Lgb
 
 int LyXText::singleWidth(BufferView * bview, Paragraph * par,
-                        Paragraph::size_type pos) const
+                         pos_type pos) const
 {
        char const c = par->getChar(pos);
        return singleWidth(bview, par, pos, c);
@@ -187,7 +196,7 @@ int LyXText::singleWidth(BufferView * bview, Paragraph * par,
 
 
 int LyXText::singleWidth(BufferView * bview, Paragraph * par,
-                         Paragraph::size_type pos, char c) const
+                         pos_type pos, char c) const
 {
        LyXFont const font = getFont(bview->buffer(), par, pos);
 
@@ -213,7 +222,10 @@ int LyXText::singleWidth(BufferView * bview, Paragraph * par,
        } else if (c == Paragraph::META_INSET) {
                Inset * tmpinset = par->getInset(pos);
                if (tmpinset) {
-#if 0 // seems not to be needed, but ...
+#if 1
+                       // this IS needed otherwise on initialitation we don't get the fill
+                       // of the row right (ONLY on initialization if we read a file!)
+                       // should be changed! (Jug 20011204)
                        tmpinset->update(bview, font);
 #endif
                        return tmpinset->width(bview, font);
@@ -229,20 +241,19 @@ int LyXText::singleWidth(BufferView * bview, Paragraph * par,
 
 
 // Returns the paragraph position of the last character in the specified row
-Paragraph::size_type LyXText::rowLast(Row const * row) const
+pos_type LyXText::rowLast(Row const * row) const
 {
-       if (row->next() == 0)
+       if (!row->next() || row->next()->par() != row->par()) {
                return row->par()->size() - 1;
-       else if (row->next()->par() != row->par()) 
-               return row->par()->size() - 1;
-       else 
+       } else {
                return row->next()->pos() - 1;
+       }
 }
 
 
-Paragraph::size_type LyXText::rowLastPrintable(Row const * row) const
+pos_type LyXText::rowLastPrintable(Row const * row) const
 {
-       Paragraph::size_type const last = rowLast(row);
+       pos_type const last = rowLast(row);
        if (last >= row->pos()
            && row->next()
            && row->next()->par() == row->par()
@@ -270,8 +281,8 @@ void LyXText::computeBidiTables(Buffer const * buf, Row * row) const
        }
 
        if (bidi_end + 2 - bidi_start >
-           static_cast<Paragraph::size_type>(log2vis_list.size())) {
-               Paragraph::size_type new_size = 
+           static_cast<pos_type>(log2vis_list.size())) {
+               pos_type new_size = 
                        (bidi_end + 2 - bidi_start < 500) ?
                        500 : 2 * (bidi_end + 2 - bidi_start);
                log2vis_list.resize(new_size);
@@ -282,19 +293,18 @@ void LyXText::computeBidiTables(Buffer const * buf, Row * row) const
        vis2log_list[bidi_end + 1 - bidi_start] = -1;
        log2vis_list[bidi_end + 1 - bidi_start] = -1;
 
-       Paragraph::size_type    stack[2];
+       pos_type stack[2];
        bool const rtl_par =
                row->par()->getParLanguage(buf->params)->RightToLeft();
        int level = 0;
        bool rtl = false;
        bool rtl0 = false;
-       Paragraph::size_type const main_body =
-               beginningOfMainBody(buf, row->par());
+       pos_type const main_body = beginningOfMainBody(buf, row->par());
 
-       for (Paragraph::size_type lpos = bidi_start;
+       for (pos_type lpos = bidi_start;
             lpos <= bidi_end; ++lpos) {
                bool is_space = row->par()->isLineSeparator(lpos);
-               Paragraph::size_type const pos =
+               pos_type const pos =
                        (is_space && lpos + 1 <= bidi_end &&
                         !row->par()->isLineSeparator(lpos + 1) &&
                         !row->par()->isNewline(lpos + 1))
@@ -345,8 +355,7 @@ void LyXText::computeBidiTables(Buffer const * buf, Row * row) const
                bidi_levels[lpos - bidi_start] = new_level;
 
                while (level > new_level2) {
-                       Paragraph::size_type old_lpos =
-                               stack[--level];
+                       pos_type old_lpos = stack[--level];
                        int delta = lpos - old_lpos - 1;
                        if (level % 2)
                                delta = -delta;
@@ -358,15 +367,15 @@ void LyXText::computeBidiTables(Buffer const * buf, Row * row) const
        }
 
        while (level > 0) {
-               Paragraph::size_type const old_lpos = stack[--level];
+               pos_type const old_lpos = stack[--level];
                int delta = bidi_end - old_lpos;
                if (level % 2)
                        delta = -delta;
                log2vis_list[old_lpos - bidi_start] += delta;
        }
 
-       Paragraph::size_type vpos = bidi_start - 1;
-       for (Paragraph::size_type lpos = bidi_start;
+       pos_type vpos = bidi_start - 1;
+       for (pos_type lpos = bidi_start;
             lpos <= bidi_end; ++lpos) {
                vpos += log2vis_list[lpos - bidi_start];
                vis2log_list[vpos - bidi_start] = lpos;
@@ -377,7 +386,7 @@ void LyXText::computeBidiTables(Buffer const * buf, Row * row) const
 
 // This method requires a previous call to ComputeBidiTables()
 bool LyXText::isBoundary(Buffer const * buf, Paragraph * par,
-                        Paragraph::size_type pos) const
+                        pos_type pos) const
 {
        if (!lyxrc.rtl_support || pos == 0)
                return false;
@@ -397,8 +406,7 @@ bool LyXText::isBoundary(Buffer const * buf, Paragraph * par,
 
 
 bool LyXText::isBoundary(Buffer const * buf, Paragraph * par,
-                        Paragraph::size_type pos,
-                        LyXFont const & font) const
+                        pos_type pos, LyXFont const & font) const
 {
        if (!lyxrc.rtl_support)
                return false;    // This is just for speedup
@@ -410,213 +418,251 @@ bool LyXText::isBoundary(Buffer const * buf, Paragraph * par,
        return rtl != rtl2;
 }
 
+void LyXText::drawNewline(DrawRowParams & p, pos_type const pos)
+{
+       // Draw end-of-line marker
+       LyXFont const font = getFont(p.bv->buffer(), p.row->par(), pos);
+       int const wid = lyxfont::width('n', font);
+       int const asc = lyxfont::maxAscent(font);
+       int const y = p.yo + p.row->baseline();
+       int xp[3];
+       int yp[3];
+               
+       yp[0] = int(y - 0.875 * asc * 0.75);
+       yp[1] = int(y - 0.500 * asc * 0.75);
+       yp[2] = int(y - 0.125 * asc * 0.75);
+       if (bidi_level(pos) % 2 == 0) {
+               xp[0] = int(p.x + wid * 0.375);
+               xp[1] = int(p.x);
+               xp[2] = int(p.x + wid * 0.375);
+       } else { 
+               xp[0] = int(p.x + wid * 0.625);
+               xp[1] = int(p.x + wid);
+               xp[2] = int(p.x + wid * 0.625);
+       }
+       p.pain->lines(xp, yp, 3, LColor::eolmarker);
+       yp[0] = int(y - 0.500 * asc * 0.75);
+       yp[1] = int(y - 0.500 * asc * 0.75);
+       yp[2] = int(y - asc * 0.75);
+       if (bidi_level(pos) % 2 == 0) {
+               xp[0] = int(p.x);
+               xp[1] = int(p.x + wid);
+               xp[2] = int(p.x + wid);
+       } else {
+               xp[0] = int(p.x + wid);
+               xp[1] = int(p.x);
+               xp[2] = int(p.x);
+       }
+       p.pain->lines(xp, yp, 3, LColor::eolmarker);
+
+       p.x += wid;
+}
 
-void LyXText::draw(BufferView * bview, Row const * row,
-                   Paragraph::size_type & vpos,
-                   int offset, float & x, bool cleared)
+void LyXText::drawInset(DrawRowParams & p, pos_type const pos)
 {
-       Painter & pain = bview->painter();
-       
-       Paragraph::size_type pos = vis2log(vpos);
-       char c = row->par()->getChar(pos);
-       float tmpx = x;
+       Inset * inset = p.row->par()->getInset(pos);
 
-       if (IsNewlineChar(c)) {
-               ++vpos;
-               // Draw end-of-line marker
-               LyXFont const font = getFont(bview->buffer(), row->par(), pos);
-               int const wid = lyxfont::width('n', font);
-               int const asc = lyxfont::maxAscent(font);
-               int const y = offset + row->baseline();
-               int xp[3];
-               int yp[3];
-               
-               if (bidi_level(pos) % 2 == 0) {
-                       xp[0] = int(x + wid * 0.375);
-                       yp[0] = int(y - 0.875 * asc * 0.75);
-                       
-                       xp[1] = int(x);
-                       yp[1] = int(y - 0.500 * asc * 0.75);
-                       
-                       xp[2] = int(x + wid * 0.375);
-                       yp[2] = int(y - 0.125 * asc * 0.75);
-                       
-                       pain.lines(xp, yp, 3, LColor::eolmarker);
-                       
-                       xp[0] = int(x);
-                       yp[0] = int(y - 0.500 * asc * 0.75);
-                       
-                       xp[1] = int(x + wid);
-                       yp[1] = int(y - 0.500 * asc * 0.75);
-                       
-                       xp[2] = int(x + wid);
-                       yp[2] = int(y - asc * 0.75);
-                       
-                       pain.lines(xp, yp, 3, LColor::eolmarker);
+       // FIXME: shouldn't happen
+       if (!inset) {
+               return;
+       }
+       LyXFont const & font = getFont(p.bv->buffer(), p.row->par(), pos);
+
+       inset->update(p.bv, font, false);
+       inset->draw(p.bv, font, p.yo + p.row->baseline(), p.x, p.cleared);
+       if (!need_break_row && !inset_owner 
+           && p.bv->text->status() == CHANGED_IN_DRAW) {
+               Row * prev = p.row->previous();
+               if (prev && prev->par() == p.row->par()) {
+                       breakAgainOneRow(p.bv, prev);
+                       if (prev->next() != p.row) {
+                               // breakAgainOneRow() has removed p.row
+                               p.row = 0;  // see what this breaks
+                               need_break_row = prev;
+                       } else {
+                               need_break_row = p.row;
+                       }
                } else {
-                       xp[0] = int(x + wid * 0.625);
-                       yp[0] = int(y - 0.875 * asc * 0.75);
-                       
-                       xp[1] = int(x + wid);
-                       yp[1] = int(y - 0.500 * asc * 0.75);
-                       
-                       xp[2] = int(x + wid * 0.625);
-                       yp[2] = int(y - 0.125 * asc * 0.75);
-                       
-                       pain.lines(xp, yp, 3, LColor::eolmarker);
-                       
-                       xp[0] = int(x + wid);
-                       yp[0] = int(y - 0.500 * asc * 0.75);
-                       
-                       xp[1] = int(x);
-                       yp[1] = int(y - 0.500 * asc * 0.75);
-                       
-                       xp[2] = int(x);
-                       yp[2] = int(y - asc * 0.75);
-                       
-                       pain.lines(xp, yp, 3, LColor::eolmarker);
+                       need_break_row = p.row;
                }
-               x += wid;
-               return;
+               setCursor(p.bv, cursor.par(), cursor.pos());
        }
+}
 
-       LyXFont font = getFont(bview->buffer(), row->par(), pos);
-       LyXFont font2 = font;
 
-       if (c == Paragraph::META_INSET) {
-               Inset * tmpinset = row->par()->getInset(pos);
-               if (tmpinset) {
-                       tmpinset->update(bview, font, false);
-                       tmpinset->draw(bview, font, offset+row->baseline(), x,
-                                      cleared);
-                       if (!need_break_row && !inset_owner &&
-                           bview->text->status() == CHANGED_IN_DRAW)
-                       {
-                               if (row->previous() && row->previous()->par() == row->par())
-                                       breakAgainOneRow(bview, row->previous());
-                               setCursor(bview, cursor.par(), cursor.pos());
-                               need_break_row = const_cast<Row *>(row);
+void LyXText::drawForeignMark(DrawRowParams & p, float const orig_x, LyXFont const & orig_font)
+{
+       if (!lyxrc.mark_foreign_language)
+               return; 
+       if (orig_font.language() == latex_language)
+               return;
+       if (orig_font.language() == p.bv->buffer()->params.language)
+               return;
+       int const y = p.yo + p.row->height() - 1;
+       p.pain->line(int(orig_x), y, int(p.x), y, LColor::language);
+}
+
+void LyXText::drawHebrewComposeChar(DrawRowParams & p, pos_type & vpos)
+{
+       pos_type pos = vis2log(vpos);
+       string str;
+
+       // first char 
+       char c = p.row->par()->getChar(pos);
+       str += c;
+       ++vpos; 
+       LyXFont const & font = getFont(p.bv->buffer(), p.row->par(), pos);
+       int const width = lyxfont::width(c, font);
+       int dx = 0;
+       for (pos_type i = pos-1; i >= 0; --i) {
+               c = p.row->par()->getChar(i);
+               if (!Encodings::IsComposeChar_hebrew(c)) {
+                       if (IsPrintableNonspace(c)) {
+                               int const width2 = 
+                                       singleWidth(p.bv, p.row->par(), i, c);
+                               // dalet / resh
+                               dx = (c == 'ø' || c == 'ã')
+                                       ? width2 - width 
+                                       : (width2 - width) / 2;
                        }
+                       break;
                }
-               ++vpos;
+       }
+       // Draw nikud
+       p.pain->text(int(p.x) + dx, p.yo + p.row->baseline(), str, font);
+}
 
-               if (lyxrc.mark_foreign_language &&
-                       font.language() != latex_language &&
-                   font.language() != bview->buffer()->params.language) {
-                       int const y = offset + row->height() - 1;
-                       pain.line(int(tmpx), y, int(x), y, LColor::language);
+void LyXText::drawArabicComposeChar(DrawRowParams & p, pos_type & vpos)
+{
+       pos_type pos = vis2log(vpos);
+       string str;
+       // first char 
+       char c = p.row->par()->getChar(pos);
+       c = transformChar(c, p.row->par(), pos);
+       str +=c;
+       ++vpos;
+       LyXFont const & font = getFont(p.bv->buffer(), p.row->par(), pos);
+       int const width = lyxfont::width(c, font);
+       int dx = 0;
+       for (pos_type i = pos-1; i >= 0; --i) {
+               c = p.row->par()->getChar(i);
+               if (!Encodings::IsComposeChar_arabic(c)) {
+                       if (IsPrintableNonspace(c)) {
+                               int const width2 = 
+                                       singleWidth(p.bv, p.row->par(), i, c);
+                               dx = (width2 - width) / 2;
+                       }
+                       break;
                }
+       }
+       // Draw nikud
+       p.pain->text(int(p.x) + dx, p.yo + p.row->baseline(), str, font);
+}
+void LyXText::drawChars(DrawRowParams & p, pos_type & vpos,
+                        bool hebrew, bool arabic)
+{
+       pos_type pos = vis2log(vpos);
+       pos_type const last = rowLastPrintable(p.row);
+       LyXFont const & orig_font = getFont(p.bv->buffer(), p.row->par(), pos);
+       // first character
+       string str;
+       str += p.row->par()->getChar(pos);
+       if (arabic) {
+               unsigned char c = str[0];
+               str[0] = transformChar(c, p.row->par(), pos);
+       }
+       ++vpos;
 
-               return;
+       // collect as much similar chars as we can
+       while (vpos <= last && (pos = vis2log(vpos)) >= 0) {
+               char c = p.row->par()->getChar(pos);
+               if (!IsPrintableNonspace(c))
+                       break;
+               if (arabic && Encodings::IsComposeChar_arabic(c))
+                       break;
+               if (hebrew && Encodings::IsComposeChar_hebrew(c))
+                       break;
+               if (orig_font != getFont(p.bv->buffer(), p.row->par(), pos))
+                       break;
+               str += c;
+               ++vpos;
        }
+       // Draw text and set the new x position
+       p.pain->text(int(p.x), p.yo + p.row->baseline(), str, orig_font);
+       p.x += lyxfont::width(str, orig_font);
+}
 
-       // usual characters, no insets
+void LyXText::draw(DrawRowParams & p, pos_type & vpos)
+{
+       pos_type const pos = vis2log(vpos);
+       Paragraph * par = p.row->par();
 
-       // Collect character that we can draw in one command
-
-       // This is dirty, but fast. Notice that it will never be too small.
-       // For the record, I'll note that Microsoft Word has a limit
-       // of 768 here. We have none :-) (Asger)
-       // Ok. I am the first to admit that the use of std::string will be
-       // a tiny bit slower than using a POD char array. However, I claim
-       // that this slowdown is so small that it is close to inperceptive.
-       // So IMHO we should go with the easier and clearer implementation.
-       // And even if 1024 is a large number here it might overflow, string
-       // will only overflow if the machine is out of memory...
-       static string textstring;
-       textstring = c;
-       ++vpos;
+       LyXFont const & orig_font = getFont(p.bv->buffer(), par, pos);
 
-       Paragraph::size_type const last = rowLastPrintable(row);
-
-       if (font.language()->lang() == "hebrew") {
-               if (Encodings::IsComposeChar_hebrew(c)) {
-                       int const width = lyxfont::width(c, font2);
-                       int dx = 0;
-                       for (Paragraph::size_type i = pos-1; i >= 0; --i) {
-                               c = row->par()->getChar(i);
-                               if (!Encodings::IsComposeChar_hebrew(c)) {
-                                       if (IsPrintableNonspace(c)) {
-                                               int const width2 =
-                                                       singleWidth(bview,
-                                                                   row->par(),
-                                                                   i, c);
-                                               dx = (c == 'ø' || c == 'ã') // dalet / resh
-                                                       ? width2 - width : (width2 - width) / 2;
-                                       }
-                                       break;
-                               }
-                       }
-                       // Draw nikud
-                       pain.text(int(x) + dx, offset + row->baseline(),
-                                 textstring, font);
-               } else {
-                       while (vpos <= last &&
-                              (pos = vis2log(vpos)) >= 0
-                              && IsPrintableNonspace(c = row->par()->getChar(pos))
-                              && !Encodings::IsComposeChar_hebrew(c)
-                              && font2 == getFont(bview->buffer(), row->par(), pos)) {
-                               textstring += c;
-                               ++vpos;
-                       }
-                       // Draw text and set the new x position
-                       pain.text(int(x), offset + row->baseline(),
-                                 textstring, font);
-                       x += lyxfont::width(textstring, font);
-               }
-       } else if (font.language()->lang() == "arabic" &&
-                  (lyxrc.font_norm_type == LyXRC::ISO_8859_6_8 ||
-                   lyxrc.font_norm_type == LyXRC::ISO_10646_1)) {
-               if (Encodings::IsComposeChar_arabic(c)) {
-                       c = transformChar(c, row->par(), pos);
-                       textstring = c;
-                       int const width = lyxfont::width(c, font2);
-                       int dx = 0;
-                       for (Paragraph::size_type i = pos-1; i >= 0; --i) {
-                               c = row->par()->getChar(i);
-                               if (!Encodings::IsComposeChar_arabic(c)) {
-                                       if (IsPrintableNonspace(c)) {
-                                               int const width2 =
-                                                       singleWidth(bview,
-                                                                   row->par(),
-                                                                   i, c);
-                                               dx = (width2 - width) / 2;
-                                       }
-                                       break;
-                               }
-                       }
-                       // Draw nikud
-                       pain.text(int(x) + dx, offset + row->baseline(), 
-                                 textstring, font);
-               } else {
-                       textstring = transformChar(c, row->par(), pos);
-                       while (vpos <= last &&
-                              (pos = vis2log(vpos)) >= 0
-                              && IsPrintableNonspace(c = row->par()->getChar(pos))
-                              && !Encodings::IsComposeChar_arabic(c)
-                              && font2 == getFont(bview->buffer(), row->par(), pos)) {
-                               c = transformChar(c, row->par(), pos);
-                               textstring += c;
-                               ++vpos;
-                       }
-                       // Draw text and set the new x position
-                       pain.text(int(x), offset + row->baseline(),
-                                 textstring, font);
-                       x += lyxfont::width(textstring, font);
-               }
-       } else {
-               while (vpos <= last &&
-                      (pos = vis2log(vpos)) >= 0
-                      && IsPrintableNonspace(c = row->par()->getChar(pos))
-                      && font2 == getFont(bview->buffer(), row->par(), pos)) {
-                       textstring += c;
-                       ++vpos;
-               }
-               // Draw text and set the new x position
-               pain.text(int(x), offset + row->baseline(), textstring, font);
-               x += lyxfont::width(textstring, font);
+       float const orig_x = p.x;
+        
+       char const c = par->getChar(pos);
+       if (IsNewlineChar(c)) {
+               ++vpos;
+               drawNewline(p, pos);
+               return;
+       } else if (IsInsetChar(c)) {
+               drawInset(p, pos);
+               ++vpos;
+               drawForeignMark(p, orig_x, orig_font);
+               return;
        }
 
+       // usual characters, no insets
+
+       // special case languages
+       bool const hebrew = (orig_font.language()->lang() == "hebrew");
+       bool const arabic = 
+               orig_font.language()->lang() == "arabic" &&
+               (lyxrc.font_norm_type == LyXRC::ISO_8859_6_8 ||
+               lyxrc.font_norm_type == LyXRC::ISO_10646_1);
+
+       // draw as many chars as we can
+       if ((!hebrew && !arabic)
+               || (hebrew && !Encodings::IsComposeChar_hebrew(c))
+               || (arabic && !Encodings::IsComposeChar_arabic(c))) {
+               drawChars(p, vpos, true, false);
+       } else if (hebrew) {
+               drawHebrewComposeChar(p, vpos);
+       } else if (arabic) {
+               drawArabicComposeChar(p, vpos);
+       }
+
+       drawForeignMark(p, orig_x, orig_font);
 #ifdef INHERIT_LANGUAGE
 #ifdef WITH_WARNINGS
        if ((font.language() == inherit_language) ||
@@ -624,17 +670,6 @@ void LyXText::draw(BufferView * bview, Row const * row,
                lyxerr << "No this shouldn't happen!\n";
 #endif
 #endif
-       if (lyxrc.mark_foreign_language &&
-           font.language() != latex_language &&
-           font.language() != bview->buffer()->params.language) {
-               int const y = offset + row->height() - 1;
-               pain.line(int(tmpx), y, int(x), y,
-                         LColor::language);
-       }
-
-       // If we want ulem.sty support, drawing
-       // routines should go here. (Asger)
-       // Why shouldn't LyXFont::drawText handle it internally?
 }
 
 
@@ -645,8 +680,8 @@ void LyXText::draw(BufferView * bview, Row const * row,
 int LyXText::leftMargin(BufferView * bview, Row const * row) const
 {
        LyXTextClass const & tclass =
-               textclasslist.TextClass(bview->buffer()->params.textclass);
-       LyXLayout const & layout = tclass[row->par()->getLayout()];
+               textclasslist[bview->buffer()->params.textclass];
+       LyXLayout const & layout = tclass[row->par()->layout()];
        
        string parindent = layout.parindent; 
 
@@ -658,13 +693,13 @@ int LyXText::leftMargin(BufferView * bview, Row const * row) const
        // I have had this idea very late, so it seems to be a
        // later added hack and this is true
        if (!row->par()->getDepth()) {
-               if (!row->par()->getLayout()) {
+               if (row->par()->layout() == tclass.defaultLayoutName()) {
                        // find the previous same level paragraph
                        if (row->par()->previous()) {
                                Paragraph * newpar = row->par()
                                        ->depthHook(row->par()->getDepth());
                                if (newpar &&
-                                   tclass[newpar->getLayout()].nextnoindent)
+                                   tclass[newpar->layout()].nextnoindent)
                                        parindent.erase();
                        }
                }
@@ -676,9 +711,8 @@ int LyXText::leftMargin(BufferView * bview, Row const * row) const
                
                // make a corresponding row. Needed to call LeftMargin()
                
-               // check wether it is a sufficent paragraph 
-               if (newpar && tclass[newpar->getLayout()].isEnvironment())
-               {
+               // check wether it is a sufficent paragraph
+               if (newpar && tclass[newpar->layout()].isEnvironment()) {
                        Row dummyrow;
                        dummyrow.par(newpar);
                        dummyrow.pos(newpar->size());
@@ -690,14 +724,13 @@ int LyXText::leftMargin(BufferView * bview, Row const * row) const
                        // LeftMargin() is always called
                        row->par()->params().depth(0);
                }
-               
-               if (newpar && !row->par()->getLayout()) {
+
+               if (newpar && row->par()->layout() == tclass.defaultLayoutName()) {
                        if (newpar->params().noindent())
                                parindent.erase();
                        else
-                               parindent = tclass[newpar->getLayout()].parindent;
+                               parindent = tclass[newpar->layout()].parindent;
                }
-               
        }
        
        LyXFont const labelfont = getLabelFont(bview->buffer(), row->par());
@@ -801,26 +834,28 @@ int LyXText::leftMargin(BufferView * bview, Row const * row) const
                         && ! row->par()->isFirstInSequence()))
                    && align == LYX_ALIGN_BLOCK
                    && !row->par()->params().noindent()
-                   && (row->par()->layout ||
+                       // in tabulars paragraphs are never indented!
+                       && (!row->par()->inInset() || row->par()->inInset()->owner()->lyxCode() != Inset::TABULAR_CODE)
+                   && (row->par()->layout() != tclass.defaultLayoutName() ||
                        bview->buffer()->params.paragraph_separation ==
-                       BufferParams::PARSEP_INDENT))
+                       BufferParams::PARSEP_INDENT)) {
                        x += lyxfont::signedWidth(parindent,
                                                  tclass.defaultfont());
-               else if (layout.labeltype == LABEL_BIBLIO) {
+               else if (layout.labeltype == LABEL_BIBLIO) {
                        // ale970405 Right width for bibitems
                        x += bibitemMaxWidth(bview, tclass.defaultfont());
                }
        }
+       
        return x;
 }
 
 
 int LyXText::rightMargin(Buffer const * buf, Row const * row) const
 {
-       LyXTextClass const & tclass =
-               textclasslist.TextClass(buf->params.textclass);
-       LyXLayout const & layout = tclass[row->par()->getLayout()];
-               
+       LyXTextClass const & tclass = textclasslist[buf->params.textclass];
+       LyXLayout const & layout = tclass[row->par()->layout()];
+       
        int x = LYX_PAPER_MARGIN
                + lyxfont::signedWidth(tclass.rightmargin(),
                                       tclass.defaultfont());
@@ -841,8 +876,7 @@ int LyXText::rightMargin(Buffer const * buf, Row const * row) const
                // make a corresponding row. Needed to call LeftMargin()
                
                // check wether it is a sufficent paragraph
-               if (newpar
-                   && tclass[newpar->getLayout()].isEnvironment()) {
+               if (newpar && tclass[newpar->layout()].isEnvironment()) {
                        Row dummyrow;
                        dummyrow.par(newpar);
                        dummyrow.pos(0);
@@ -865,8 +899,7 @@ int LyXText::rightMargin(Buffer const * buf, Row const * row) const
 
 int LyXText::labelEnd(BufferView * bview, Row const * row) const
 {
-       if (textclasslist.Style(bview->buffer()->params.textclass,
-                               row->par()->getLayout()).margintype
+       if (textclasslist[bview->buffer()->params.textclass][row->par()->layout()].margintype
            == MARGIN_MANUAL) {
                Row tmprow;
                tmprow = *row;
@@ -881,7 +914,7 @@ int LyXText::labelEnd(BufferView * bview, Row const * row) const
 
 
 // get the next breakpoint in a given paragraph
-Paragraph::size_type
+pos_type
 LyXText::nextBreakPoint(BufferView * bview, Row const * row, int width) const
 {
        Paragraph * par = row->par();
@@ -889,21 +922,19 @@ LyXText::nextBreakPoint(BufferView * bview, Row const * row, int width) const
        if (width < 0)
                return par->size();
 
-       Paragraph::size_type const pos = row->pos();
-
+       pos_type const pos = row->pos();
 
        // position of the last possible breakpoint 
        // -1 isn't a suitable value, but a flag
-       Paragraph::size_type last_separator = -1;
+       pos_type last_separator = -1;
        width -= rightMargin(bview->buffer(), row);
        
-       Paragraph::size_type const main_body =
+       pos_type const main_body =
                beginningOfMainBody(bview->buffer(), par);
        LyXLayout const & layout =
-               textclasslist.Style(bview->buffer()->params.textclass,
-                                   par->getLayout());
-       Paragraph::size_type i = pos;
-
+               textclasslist[bview->buffer()->params.textclass][par->layout()];
+       pos_type i = pos;
+       
        if (layout.margintype == MARGIN_RIGHT_ADDRESS_BOX) {
                /* special code for right address boxes, only newlines count */
                while (i < par->size()) {
@@ -911,15 +942,15 @@ LyXText::nextBreakPoint(BufferView * bview, Row const * row, int width) const
                                last_separator = i;
                                i = par->size() - 1; // this means break
                                //x = width;
-                       } else if (par->getChar(i) == Paragraph::META_INSET &&
-                                  par->getInset(i) && par->getInset(i)->display()){
+                       } else if (par->isInset(i) && par->getInset(i) 
+                               && par->getInset(i)->display()) {
                                par->getInset(i)->display(false);
                        }
                        ++i;
                }
        } else {
                // Last position is an invariant
-               Paragraph::size_type const last = 
+               pos_type const last = 
                        par->size();
                // this is the usual handling
                int x = leftMargin(bview, row);
@@ -927,29 +958,30 @@ LyXText::nextBreakPoint(BufferView * bview, Row const * row, int width) const
                while (doitonetime || ((x < width) && (i < last))) {
                        doitonetime = false;
                        char const c = par->getChar(i);
+                       Inset * in = 0;
+                       if (c == Paragraph::META_INSET)
+                               in = par->getInset(i);
                        if (IsNewlineChar(c)) {
                                last_separator = i;
                                x = width; // this means break
-                       } else if (c == Paragraph::META_INSET &&
-                                  par->getInset(i)) {
-                               
+                       } else if (in && !in->isChar()) {
                                // check wether a Display() inset is
                                // valid here. if not, change it to
                                // non-display
-                               if (par->getInset(i)->display() &&
+                               if (in->display() &&
                                    (layout.isCommand() ||
                                     (layout.labeltype == LABEL_MANUAL
-                                     && i < beginningOfMainBody(bview->buffer(), par)))) {
+                                     && i < beginningOfMainBody(bview->buffer(), par))))
+                               {
                                        // display istn't allowd
-                                       par->getInset(i)->display(false);
+                                       in->display(false);
                                        x += singleWidth(bview, par, i, c);
-                               } else if (par->getInset(i)->display() ||
-                                        par->getInset(i)->needFullRow()) {
+                               } else if (in->display() || in->needFullRow()) {
                                        // So break the line here
                                        if (i == pos) {
                                                if (pos < last-1) {
                                                        last_separator = i;
-                                                       if (IsLineSeparatorChar(par->getChar(i+1)))
+                                                       if (par->isLineSeparator(i+1))
                                                                ++last_separator;
                                                } else
                                                        last_separator = last; // to avoid extra rows
@@ -958,9 +990,19 @@ LyXText::nextBreakPoint(BufferView * bview, Row const * row, int width) const
                                        x = width;  // this means break
                                } else {
                                        x += singleWidth(bview, par, i, c);
+                                       // we have to check this separately as we could have a
+                                       // lineseparator and then the algorithm below would prefer
+                                       // that which IS wrong! We should always break on an inset
+                                       // if it's too long and not on the last separator.
+                                       // Maybe the only exeption is insets used as chars but
+                                       // then we would have to have a special function inside
+                                       // the inset to tell us this. Till then we leave it as
+                                       // it is now. (Jug 20020106)
+                                       if (pos < i && x >= width && last_separator >= 0)
+                                               last_separator = i - 1;
                                }
                        } else  {
-                               if (IsLineSeparatorChar(c))
+                               if (par->isLineSeparator(i))
                                        last_separator = i;
                                x += singleWidth(bview, par, i, c);
                        }
@@ -975,8 +1017,12 @@ LyXText::nextBreakPoint(BufferView * bview, Row const * row, int width) const
                                        x = left_margin;
                        }
                }
+               if ((pos+1 < i) && (last_separator < 0) && (x >= width))
+                       last_separator = i - 2;
+               else if ((pos < i) && (last_separator < 0) && (x >= width))
+                       last_separator = i - 1;
                // end of paragraph is always a suitable separator
-               if (i == last && x < width)
+               else if (i == last && x < width)
                        last_separator = i;
        }
        
@@ -1002,11 +1048,10 @@ int LyXText::fill(BufferView * bview, Row * row, int paper_width) const
 
        int w;
        // get the pure distance
-       Paragraph::size_type const last = rowLastPrintable(row);
+       pos_type const last = rowLastPrintable(row);
        
        // special handling of the right address boxes
-       if (textclasslist.Style(bview->buffer()->params.textclass,
-                               row->par()->getLayout()).margintype
+       if (textclasslist[bview->buffer()->params.textclass][row->par()->layout()].margintype
            == MARGIN_RIGHT_ADDRESS_BOX)
        {
                int const tmpfill = row->fill();
@@ -1016,11 +1061,10 @@ int LyXText::fill(BufferView * bview, Row * row, int paper_width) const
        } else
                w = leftMargin(bview, row);
        
-       LyXLayout const & layout = textclasslist.Style(bview->buffer()->params.textclass,
-                                                      row->par()->getLayout());
-       Paragraph::size_type const main_body = 
+       LyXLayout const & layout = textclasslist[bview->buffer()->params.textclass][row->par()->layout()];
+       pos_type const main_body = 
                beginningOfMainBody(bview->buffer(), row->par());
-       Paragraph::size_type i = row->pos();
+       pos_type i = row->pos();
 
        while (i <= last) {
                if (main_body > 0 && i == main_body) {
@@ -1044,13 +1088,6 @@ int LyXText::fill(BufferView * bview, Row * row, int paper_width) const
        }
        
        int const fill = paper_width - w - rightMargin(bview->buffer(), row);
-#ifdef WITH_WARNINGS
-#warning Please fix me (Jug!)
-#endif
-#if 0
-       if (fill < 0)
-               return 0;
-#endif
        return fill;
 }
 
@@ -1058,7 +1095,7 @@ int LyXText::fill(BufferView * bview, Row * row, int paper_width) const
 // returns the minimum space a manual label needs on the screen in pixel
 int LyXText::labelFill(BufferView * bview, Row const * row) const
 {
-       Paragraph::size_type last = beginningOfMainBody(bview->buffer(), row->par()) - 1;
+       pos_type last = beginningOfMainBody(bview->buffer(), row->par()) - 1;
        // -1 because a label ends either with a space that is in the label, 
        // or with the beginning of a footnote that is outside the label.
 
@@ -1074,7 +1111,7 @@ int LyXText::labelFill(BufferView * bview, Row const * row) const
                --last;
        
        int w = 0;
-       Paragraph::size_type i = row->pos();
+       pos_type i = row->pos();
        while (i <= last) {
                w += singleWidth(bview, row->par(), i);
                ++i;
@@ -1095,9 +1132,8 @@ int LyXText::labelFill(BufferView * bview, Row const * row) const
 // on the very last column doesnt count
 int LyXText::numberOfSeparators(Buffer const * buf, Row const * row) const
 {
-       Paragraph::size_type const last = rowLast(row);
-       Paragraph::size_type p =
-               max(row->pos(), beginningOfMainBody(buf, row->par()));
+       pos_type const last = rowLast(row);
+       pos_type p = max(row->pos(), beginningOfMainBody(buf, row->par()));
        int n = 0;
        for (; p < last; ++p) {
                if (row->par()->isSeparator(p)) {
@@ -1113,18 +1149,21 @@ int LyXText::numberOfSeparators(Buffer const * buf, Row const * row) const
 // ignored. This is *MUCH* more usefull than not to ignore!
 int LyXText::numberOfHfills(Buffer const * buf, Row const * row) const
 {
-       Paragraph::size_type const last = rowLast(row);
-       Paragraph::size_type first = row->pos();
+       pos_type const last = rowLast(row);
+       pos_type first = row->pos();
+       
        if (first) { /* hfill *DO* count at the beginning 
                      * of paragraphs! */
-               while(first <= last && row->par()->isHfill(first))
+               while (first <= last && row->par()->isHfill(first)) {
                        ++first;
+               }
        }
 
        first = max(first, beginningOfMainBody(buf, row->par()));
        int n = 0;
-       for (Paragraph::size_type p = first; p <= last; ++p) {
+       for (pos_type p = first; p <= last; ++p) {
                // last, because the end is ignored!
+               
                if (row->par()->isHfill(p)) {
                        ++n;
                }
@@ -1136,18 +1175,18 @@ int LyXText::numberOfHfills(Buffer const * buf, Row const * row) const
 // like NumberOfHfills, but only those in the manual label!
 int LyXText::numberOfLabelHfills(Buffer const * buf, Row const * row) const
 {
-       Paragraph::size_type last = rowLast(row);
-       Paragraph::size_type first = row->pos();
+       pos_type last = rowLast(row);
+       pos_type first = row->pos();
        if (first) { /* hfill *DO* count at the beginning 
                      * of paragraphs! */
-               while(first < last && row->par()->isHfill(first))
+               while (first < last && row->par()->isHfill(first))
                        ++first;
        }
 
        last = min(last, beginningOfMainBody(buf, row->par()));
        int n = 0;
-       for (Paragraph::size_type p = first;
-            p < last; ++p) {  // last, because the end is ignored!
+       for (pos_type p = first; p < last; ++p) {
+               // last, because the end is ignored!
                if (row->par()->isHfill(p)) {
                        ++n;
                }
@@ -1159,15 +1198,23 @@ int LyXText::numberOfLabelHfills(Buffer const * buf, Row const * row) const
 // returns true, if a expansion is needed.
 // Rules are given by LaTeX
 bool LyXText::hfillExpansion(Buffer const * buf, Row const * row_ptr,
-                             Paragraph::size_type pos) const
+                             pos_type pos) const
 {
        // by the way, is it a hfill?
        if (!row_ptr->par()->isHfill(pos))
                return false;
        
        // at the end of a row it does not count
-       if (pos >= rowLast(row_ptr))
-               return false;
+       // unless another hfill exists on the line
+       if (pos >= rowLast(row_ptr)) {
+               pos_type i = row_ptr->pos();
+               while (i < pos && !row_ptr->par()->isHfill(i)) {
+                       ++i;
+               }
+               if (i == pos) {
+                       return false;
+               }
+       } 
        
        // at the beginning of a row it does not count, if it is not 
        // the first row of a paragaph
@@ -1175,8 +1222,7 @@ bool LyXText::hfillExpansion(Buffer const * buf, Row const * row_ptr,
                return true;
        
        // in some labels  it does not count
-       if (textclasslist.Style(buf->params.textclass,
-                               row_ptr->par()->getLayout()).margintype
+       if (textclasslist[buf->params.textclass][row_ptr->par()->layout()].margintype
            != MARGIN_MANUAL
            && pos < beginningOfMainBody(buf, row_ptr->par()))
                return false; 
@@ -1184,7 +1230,7 @@ bool LyXText::hfillExpansion(Buffer const * buf, Row const * row_ptr,
        // if there is anything between the first char of the row and
        // the sepcified position that is not a newline and not a hfill,
        // the hfill will count, otherwise not
-       Paragraph::size_type i = row_ptr->pos();
+       pos_type i = row_ptr->pos();
        while (i < pos && (row_ptr->par()->isNewline(i)
                           || row_ptr->par()->isHfill(i)))
                ++i;
@@ -1222,8 +1268,7 @@ void LyXText::setHeightOfRow(BufferView * bview, Row * row_ptr) const
        Paragraph * par = row_ptr->par();
        Paragraph * firstpar = row_ptr->par();
    
-       LyXLayout const & layout = textclasslist.Style(bview->buffer()->params.textclass,
-                                                      firstpar->getLayout());
+       LyXLayout const & layout = textclasslist[bview->buffer()->params.textclass][firstpar->layout()];
 
        // as max get the first character of this row then it can increes but not
        // decrees the height. Just some point to start with so we don't have to
@@ -1250,13 +1295,13 @@ void LyXText::setHeightOfRow(BufferView * bview, Row * row_ptr) const
        int maxdesc = int(lyxfont::maxDescent(font) *
                          layout.spacing.getValue() *
                          spacing_val);
-       Paragraph::size_type const pos_end = rowLast(row_ptr);
+       pos_type const pos_end = rowLast(row_ptr);
        int labeladdon = 0;
        int maxwidth = 0;
 
        // Check if any insets are larger
-       for (Paragraph::size_type pos = row_ptr->pos(); pos <= pos_end; ++pos) {
-               if (row_ptr->par()->getChar(pos) == Paragraph::META_INSET) {
+       for (pos_type pos = row_ptr->pos(); pos <= pos_end; ++pos) {
+               if (row_ptr->par()->isInset(pos)) {
                        tmpfont = getFont(bview->buffer(), row_ptr->par(), pos);
                        tmpinset = row_ptr->par()->getInset(pos);
                        if (tmpinset) {
@@ -1309,9 +1354,7 @@ void LyXText::setHeightOfRow(BufferView * bview, Row * row_ptr) const
                        {
                                maxasc += bview->buffer()->params.getDefSkip().inPixels(bview);
                        } else if (firstpar->previous() &&
-                                  textclasslist.Style(bview->buffer()->params.textclass,
-                                                      firstpar->previous()->
-                                                      getLayout()).isParagraph() &&
+                                  textclasslist[bview->buffer()->params.textclass][firstpar->previous()->layout()].isParagraph() &&
                                   firstpar->previous()->getDepth() == 0)
                        {
                                // is it right to use defskip here too? (AS)
@@ -1324,9 +1367,8 @@ void LyXText::setHeightOfRow(BufferView * bview, Row * row_ptr) const
                        maxasc += LYX_PAPER_MARGIN;
       
                // add the vertical spaces, that the user added
-               if (firstpar->params().spaceTop().kind() != VSpace::NONE)
-                       maxasc += int(firstpar->params().spaceTop().inPixels(bview));
-      
+               maxasc += getLengthMarkerHeight(bview, firstpar->params().spaceTop());
                // do not forget the DTP-lines!
                // there height depends on the font of the nearest character
                if (firstpar->params().lineTop())
@@ -1389,7 +1431,7 @@ void LyXText::setHeightOfRow(BufferView * bview, Row * row_ptr) const
                        Paragraph * prev = row_ptr->par()->previous();
                        if (prev)
                                prev = row_ptr->par()->depthHook(row_ptr->par()->getDepth());
-                       if (prev && prev->getLayout() == firstpar->getLayout() &&
+                       if (prev && prev->layout() == firstpar->layout() &&
                                prev->getDepth() == firstpar->getDepth() &&
                                prev->getLabelWidthString() == firstpar->getLabelWidthString())
                        {
@@ -1398,9 +1440,7 @@ void LyXText::setHeightOfRow(BufferView * bview, Row * row_ptr) const
                                tmptop = layout.topsep;
            
                                if (row_ptr->previous()->par()->getDepth() >= row_ptr->par()->getDepth())
-                                       tmptop -= textclasslist.Style(bview->buffer()->params.textclass,
-                                                                     row_ptr->previous()->par()->
-                                                                     getLayout()).bottomsep;
+                                       tmptop -= textclasslist[bview->buffer()->params.textclass][row_ptr->previous()->par()->layout()].bottomsep;
            
                                if (tmptop > 0)
                                        layoutasc = (tmptop * defaultHeight());
@@ -1413,13 +1453,12 @@ void LyXText::setHeightOfRow(BufferView * bview, Row * row_ptr) const
         
                        prev = row_ptr->par()->outerHook();
                        if (prev)  {
-                               maxasc += int(textclasslist.Style(bview->buffer()->params.textclass,
-                                             prev->getLayout()).parsep * defaultHeight());
+                               maxasc += int(textclasslist[bview->buffer()->params.textclass][prev->layout()].parsep * defaultHeight());
                        } else {
                                if (firstpar->previous() &&
                                        firstpar->previous()->getDepth() == 0 &&
-                                       firstpar->previous()->getLayout() !=
-                                       firstpar->getLayout())
+                                       firstpar->previous()->layout() !=
+                                       firstpar->layout())
                                {
                                        // avoid parsep
                                } else if (firstpar->previous()) {
@@ -1438,8 +1477,7 @@ void LyXText::setHeightOfRow(BufferView * bview, Row * row_ptr) const
                        maxdesc += LYX_PAPER_MARGIN;
          
                // add the vertical spaces, that the user added
-               if (firstpar->params().spaceBottom().kind() != VSpace::NONE)
-                       maxdesc += int(firstpar->params().spaceBottom().inPixels(bview));
+               maxdesc += getLengthMarkerHeight(bview, firstpar->params().spaceBottom());
          
                // do not forget the DTP-lines!
                // there height depends on the font of the nearest character
@@ -1447,7 +1485,7 @@ void LyXText::setHeightOfRow(BufferView * bview, Row * row_ptr) const
                        maxdesc += 2 * lyxfont::ascent('x',
                                                       getFont(bview->buffer(),
                                                               par,
-                                                              max(Paragraph::size_type(0), par->size() - 1)));
+                                                              max(pos_type(0), par->size() - 1)));
          
                // and now the pagebreaks
                if (firstpar->params().pagebreakBottom())
@@ -1456,22 +1494,21 @@ void LyXText::setHeightOfRow(BufferView * bview, Row * row_ptr) const
                // and now the layout spaces, for example before and after
                // a section, or between the items of a itemize or enumerate
                // environment
-               if (!firstpar->params().pagebreakBottom() && row_ptr->par()->next()) {
+               if (!firstpar->params().pagebreakBottom()
+                   && row_ptr->par()->next()) {
                        Paragraph * nextpar = row_ptr->par()->next();
                        Paragraph * comparepar = row_ptr->par();
                        float usual = 0;
                        float unusual = 0;
             
                        if (comparepar->getDepth() > nextpar->getDepth()) {
-                               usual = (textclasslist.Style(bview->buffer()->params.textclass,
-                                        comparepar->getLayout()).bottomsep * defaultHeight());
+                               usual = (textclasslist[bview->buffer()->params.textclass][comparepar->layout()].bottomsep * defaultHeight());
                                comparepar = comparepar->depthHook(nextpar->getDepth());
-                               if (comparepar->getLayout()!= nextpar->getLayout()
+                               if (comparepar->layout()!= nextpar->layout()
                                        || nextpar->getLabelWidthString() != 
                                        comparepar->getLabelWidthString())
                                {
-                                       unusual = (textclasslist.Style(bview->buffer()->params.textclass,
-                                                  comparepar->getLayout()).bottomsep * defaultHeight());
+                                       unusual = (textclasslist[bview->buffer()->params.textclass][comparepar->layout()].bottomsep * defaultHeight());
                                }
                                if (unusual > usual)
                                        layoutdesc = unusual;
@@ -1479,11 +1516,10 @@ void LyXText::setHeightOfRow(BufferView * bview, Row * row_ptr) const
                                        layoutdesc = usual;
                        } else if (comparepar->getDepth() ==  nextpar->getDepth()) {
                                
-                               if (comparepar->getLayout()!= nextpar->getLayout()
+                               if (comparepar->layout() != nextpar->layout()
                                        || nextpar->getLabelWidthString() != 
                                        comparepar->getLabelWidthString())
-                                       layoutdesc = int(textclasslist.Style(bview->buffer()->params.textclass,
-                                                                                                                comparepar->getLayout()).bottomsep * defaultHeight());
+                                       layoutdesc = int(textclasslist[bview->buffer()->params.textclass][comparepar->layout()].bottomsep * defaultHeight());
                        }
                }
        }
@@ -1502,13 +1538,15 @@ void LyXText::setHeightOfRow(BufferView * bview, Row * row_ptr) const
        float x = 0;
        if (layout.margintype != MARGIN_RIGHT_ADDRESS_BOX) {
                float dummy;
+               // this IS needed
+               row_ptr->width(maxwidth);
                prepareToPrint(bview, row_ptr, x, dummy, dummy, dummy, false);
        }
        row_ptr->width(int(maxwidth + x));
        if (inset_owner) {
                Row * r = firstrow;
                width = max(0,workWidth(bview));
-               while(r) {
+               while (r) {
                        if (r->width() > width)
                                width = r->width();
                        r = r->next();
@@ -1521,35 +1559,34 @@ void LyXText::setHeightOfRow(BufferView * bview, Row * row_ptr) const
  * start at the implicit given position */
 void LyXText::appendParagraph(BufferView * bview, Row * row) const
 {
-   bool not_ready = true;
+       bool not_ready = true;
    
-   // The last character position of a paragraph is an invariant so we can 
-   // safely get it here. (Asger)
-   Paragraph::size_type const lastposition = row->par()->size();
-   do {
-      // Get the next breakpoint
-      Paragraph::size_type z = nextBreakPoint(bview, row, workWidth(bview));
+       // The last character position of a paragraph is an invariant so we can 
+       // safely get it here. (Asger)
+       pos_type const lastposition = row->par()->size();
+       do {
+               // Get the next breakpoint
+               pos_type z = nextBreakPoint(bview, row, workWidth(bview));
       
-      Row * tmprow = row;
+               Row * tmprow = row;
 
-      // Insert the new row
-      if (z < lastposition) {
-        ++z;
-        insertRow(row, row->par(), z);
-        row = row->next();
+               // Insert the new row
+               if (z < lastposition) {
+                       ++z;
+                       insertRow(row, row->par(), z);
+                       row = row->next();
 
-        row->height(0);
-      } else
-        not_ready = false;
+                       row->height(0);
+               } else
+                       not_ready = false;
       
-      // Set the dimensions of the row
-#ifdef WITH_WARNINGS
-#warning Something is rotten here! (Jug)
-#endif
-      tmprow->fill(fill(bview, tmprow, workWidth(bview)));
-      setHeightOfRow(bview, tmprow);
+               // Set the dimensions of the row
+               // fixed fill setting now by calling inset->update() in
+               // SingleWidth when needed!
+               tmprow->fill(fill(bview, tmprow, workWidth(bview)));
+               setHeightOfRow(bview, tmprow);
 
-   } while (not_ready);
+       } while (not_ready);
 }
 
 
@@ -1559,7 +1596,7 @@ void LyXText::breakAgain(BufferView * bview, Row * row) const
    
        do  {
                // get the next breakpoint
-               Paragraph::size_type z = nextBreakPoint(bview, row, workWidth(bview));
+               pos_type z = nextBreakPoint(bview, row, workWidth(bview));
                Row * tmprow = row;
 
                if (z < row->par()->size()) {
@@ -1603,7 +1640,7 @@ void LyXText::breakAgain(BufferView * bview, Row * row) const
 void LyXText::breakAgainOneRow(BufferView * bview, Row * row)
 {
        // get the next breakpoint
-       Paragraph::size_type z = nextBreakPoint(bview, row, workWidth(bview));
+       pos_type z = nextBreakPoint(bview, row, workWidth(bview));
        Row * tmprow = row;
 
        if (z < row->par()->size()) {
@@ -1615,7 +1652,7 @@ void LyXText::breakAgainOneRow(BufferView * bview, Row * row)
                        row = row->next();
                        row->height(0);
                } else  {
-                       row= row->next();
+                       row = row->next();
                        ++z;
                        if (row->pos() != z)
                                row->pos(z);
@@ -1643,8 +1680,7 @@ void LyXText::breakAgainOneRow(BufferView * bview, Row * row)
 void LyXText::breakParagraph(BufferView * bview, char keep_layout)
 {
    LyXLayout const & layout =
-          textclasslist.Style(bview->buffer()->params.textclass,
-                              cursor.par()->getLayout());
+          textclasslist[bview->buffer()->params.textclass][cursor.par()->layout()];
 
    // this is only allowed, if the current paragraph is not empty or caption
    if ((cursor.par()->size() <= 0)
@@ -1673,10 +1709,10 @@ void LyXText::breakParagraph(BufferView * bview, char keep_layout)
    if (layout.labeltype == LABEL_SENSITIVE) {
      if (!cursor.pos())
             // set to standard-layout
-            cursor.par()->setLayout(0);
+            cursor.par()->applyLayout(0);
      else
             // set to standard-layout
-            cursor.par()->next()->setLayout(0);
+            cursor.par()->next()->applyLayout(0);
    }
    
    /* if the cursor is at the beginning of a row without prior newline, 
@@ -1749,8 +1785,8 @@ void LyXText::insertChar(BufferView * bview, char c)
        // disable the double-space checking
 
        bool const freeSpacing = 
-               textclasslist.Style(bview->buffer()->params.textclass,
-                              cursor.row()->par()->getLayout()).free_spacing;
+               textclasslist[bview->buffer()->params.textclass][cursor.row()->par()->layout()].free_spacing ||
+               cursor.row()->par()->isFreeSpacing();
 
 
        if (lyxrc.auto_number) {
@@ -1759,7 +1795,7 @@ void LyXText::insertChar(BufferView * bview, char c)
                static string const number_seperators = ".,:";
 
                if (current_font.number() == LyXFont::ON) {
-                       if (!isdigit(c) && !contains(number_operators, c) &&
+                       if (!IsDigit(c) && !contains(number_operators, c) &&
                            !(contains(number_seperators, c) &&
                              cursor.pos() >= 1 &&
                              cursor.pos() < cursor.par()->size() &&
@@ -1769,9 +1805,9 @@ void LyXText::insertChar(BufferView * bview, char c)
                              getFont(bview->buffer(),
                                      cursor.par(),
                                      cursor.pos() - 1).number() == LyXFont::ON)
-                           )
+                          )
                                number(bview); // Set current_font.number to OFF
-               } else if (isdigit(c) &&
+               } else if (IsDigit(c) &&
                           real_current_font.isVisibleRightToLeft()) {
                        number(bview); // Set current_font.number to ON
 
@@ -1780,8 +1816,8 @@ void LyXText::insertChar(BufferView * bview, char c)
                                if (contains(number_unary_operators, c) &&
                                    (cursor.pos() == 1 ||
                                     cursor.par()->isSeparator(cursor.pos() - 2) ||
-                                    cursor.par()->isNewline(cursor.pos() - 2) )
-                                  ) {
+                                    cursor.par()->isNewline(cursor.pos() - 2))
+                                 ) {
                                        setCharFont(bview->buffer(),
                                                    cursor.par(),
                                                    cursor.pos() - 1,
@@ -1820,7 +1856,7 @@ void LyXText::insertChar(BufferView * bview, char c)
                                     * current font */
 
        // Get the font that is used to calculate the baselineskip
-       Paragraph::size_type const lastpos = cursor.par()->size();
+       pos_type const lastpos = cursor.par()->size();
        LyXFont rawparfont =
                cursor.par()->getFontSettings(bview->buffer()->params,
                                              lastpos - 1);
@@ -1845,8 +1881,8 @@ void LyXText::insertChar(BufferView * bview, char c)
                        return;
                }
        } else if (IsNewlineChar(c)) {
-               if (cursor.par() == cursor.par()
-                   && cursor.pos() <= beginningOfMainBody(bview->buffer(), cursor.par())) {
+               if (cursor.pos() <= beginningOfMainBody(bview->buffer(),
+                                                       cursor.par())) {
                        charInserted();
                        return;
                }
@@ -1862,11 +1898,13 @@ void LyXText::insertChar(BufferView * bview, char c)
        }
    
        // the display inset stuff
-       if (cursor.row()->par()->getChar(cursor.row()->pos()) == Paragraph::META_INSET
-           && cursor.row()->par()->getInset(cursor.row()->pos())
-           && (cursor.row()->par()->getInset(cursor.row()->pos())->display() ||
-               cursor.row()->par()->getInset(cursor.row()->pos())->needFullRow()))
-               cursor.row()->fill(-1); // to force a new break  
+       if (cursor.row()->par()->isInset(cursor.row()->pos())) {
+               Inset * inset = cursor.row()->par()->getInset(cursor.row()->pos());
+               if (inset && (inset->display() || inset->needFullRow())) { 
+                       // force a new break
+                       cursor.row()->fill(-1); // to force a new break  
+               }
+       }
 
        // get the cursor row fist
        Row * row = cursor.row();
@@ -1888,9 +1926,11 @@ void LyXText::insertChar(BufferView * bview, char c)
        // Is there a break one row above
        if ((cursor.par()->isLineSeparator(cursor.pos())
             || cursor.par()->isNewline(cursor.pos())
+                || ((cursor.pos() < cursor.par()->size()) &&
+                        cursor.par()->isInset(cursor.pos()+1))
             || cursor.row()->fill() == -1)
            && row->previous() && row->previous()->par() == row->par()) {
-               Paragraph::size_type z = nextBreakPoint(bview,
+               pos_type z = nextBreakPoint(bview,
                                                           row->previous(),
                                                           workWidth(bview));
                if (z >= row->pos()) {
@@ -1988,8 +2028,7 @@ void LyXText::insertChar(BufferView * bview, char c)
                redoHeightOfParagraph(bview, cursor);
        } else {
                // now the special right address boxes
-               if (textclasslist.Style(bview->buffer()->params.textclass,
-                                  cursor.par()->getLayout()).margintype
+               if (textclasslist[bview->buffer()->params.textclass][cursor.par()->layout()].margintype
                    == MARGIN_RIGHT_ADDRESS_BOX) {
                        redoDrawingOfParagraph(bview, cursor); 
                }
@@ -2029,7 +2068,7 @@ void LyXText::prepareToPrint(BufferView * bview,
        fill_separator = 0;
        fill_label_hfill = 0;
 
-        bool const is_rtl =
+       bool const is_rtl =
                row->par()->isRightToLeftPar(bview->buffer()->params);
        if (is_rtl) {
                x = (workWidth(bview) > 0)
@@ -2038,12 +2077,12 @@ void LyXText::prepareToPrint(BufferView * bview,
                x = (workWidth(bview) > 0) ? leftMargin(bview, row) : 0;
        
        // is there a manual margin with a manual label
-       if (textclasslist.Style(bview->buffer()->params.textclass,
-                          row->par()->getLayout()).margintype == MARGIN_MANUAL
-           && textclasslist.Style(bview->buffer()->params.textclass,
-                             row->par()->getLayout()).labeltype == LABEL_MANUAL) {
-              
-               /* one more since labels are left aligned */ 
+       LyXTextClass const & tclass = textclasslist[bview->buffer()->params.textclass];
+       LyXLayout const & layout = tclass[row->par()->layout()];
+       
+       if (layout.margintype == MARGIN_MANUAL
+           && layout.labeltype == LABEL_MANUAL) {
+               // one more since labels are left aligned
                nlh = numberOfLabelHfills(bview->buffer(), row) + 1;
                if (nlh && !row->par()->getLabelWidthString().empty()) {
                        fill_label_hfill = labelFill(bview, row) / nlh;
@@ -2056,19 +2095,22 @@ void LyXText::prepareToPrint(BufferView * bview,
        if (nh) {
                if (w > 0)
                        fill_hfill = w / nh;
-       } else  {
+       // we don't have to look at the alignment if it is ALIGN_LEFT and
+       // if the row is already larger then the permitted width as then
+       // we force the LEFT_ALIGN'edness!
+       } else if (static_cast<int>(row->width()) < workWidth(bview)) {
                // is it block, flushleft or flushright? 
                // set x how you need it
                int align;
                if (row->par()->params().align() == LYX_ALIGN_LAYOUT) {
-                       align = textclasslist.Style(bview->buffer()->params.textclass, row->par()->getLayout()).align;
+                       align = layout.align;
                } else {
                        align = row->par()->params().align();
                }
                
                // center displayed insets 
                Inset * inset;
-               if (row->par()->getChar(row->pos()) == Paragraph::META_INSET
+               if (row->par()->isInset(row->pos())
                    && (inset=row->par()->getInset(row->pos()))
                    && (inset->display())) // || (inset->scroll() < 0)))
                    align = (inset->lyxCode() == Inset::MATHMACRO_CODE)
@@ -2079,7 +2121,7 @@ void LyXText::prepareToPrint(BufferView * bview,
                        ns = numberOfSeparators(bview->buffer(), row);
                        if (ns && row->next() && row->next()->par() == row->par() &&
                            !(row->next()->par()->isNewline(row->next()->pos() - 1))
-                           && !(row->next()->par()->getChar(row->next()->pos()) == Paragraph::META_INSET
+                           && !(row->next()->par()->isInset(row->next()->pos())
                                 && row->next()->par()->getInset(row->next()->pos())
                                 && row->next()->par()->getInset(row->next()->pos())->display())
                                )
@@ -2102,19 +2144,16 @@ void LyXText::prepareToPrint(BufferView * bview,
 
        computeBidiTables(bview->buffer(), row);
        if (is_rtl) {
-               Paragraph::size_type main_body = 
+               pos_type main_body = 
                        beginningOfMainBody(bview->buffer(), row->par());
-               Paragraph::size_type last = rowLast(row);
+               pos_type last = rowLast(row);
 
                if (main_body > 0 &&
-                   (main_body-1 > last || 
-                    !row->par()->isLineSeparator(main_body-1))) {
-                       LyXLayout const & layout =
-                               textclasslist.Style(bview->buffer()->params.textclass,
-                                                   row->par()->getLayout());
+                   (main_body - 1 > last || 
+                    !row->par()->isLineSeparator(main_body - 1))) {
                        x += lyxfont::width(layout.labelsep,
                                            getLabelFont(bview->buffer(), row->par()));
-                       if (main_body-1 <= last)
+                       if (main_body - 1 <= last)
                                x += fill_label_hfill;
                }
        }
@@ -2149,7 +2188,7 @@ void LyXText::cursorRightOneWord(BufferView * bview) const
                }
                // Advance through word.
                while (tmpcursor.pos() < tmpcursor.par()->size() &&
-                       tmpcursor.par()->isWord( tmpcursor.pos())) {
+                       tmpcursor.par()->isWord(tmpcursor.pos())) {
                  //     printf("Current pos2 %d", tmpcursor.pos()) ;
                        tmpcursor.pos(tmpcursor.pos() + 1);
                        ++steps;
@@ -2166,7 +2205,7 @@ void LyXText::cursorTab(BufferView * bview) const
            && !tmpcursor.par()->isNewline(tmpcursor.pos()))
         tmpcursor.pos(tmpcursor.pos() + 1);
 
-    if (tmpcursor.pos() == tmpcursor.par()->size()){
+    if (tmpcursor.pos() == tmpcursor.par()->size()) {
         if (tmpcursor.par()->next()) {
             tmpcursor.par(tmpcursor.par()->next());
             tmpcursor.pos(0);
@@ -2203,13 +2242,13 @@ void LyXText::cursorLeftOneWord(LyXCursor  & cur)  const
                || cur.par()->isHfill(cur.pos() - 1))) {
                cur.pos(cur.pos() - 1);
        } else if (!cur.pos()) {
-               if (cur.par()->previous()){
+               if (cur.par()->previous()) {
                        cur.par(cur.par()->previous());
                        cur.pos(cur.par()->size());
                }
        } else {                // Here, cur != 0 
                while (cur.pos() > 0 &&
-                      cur.par()->isWord(cur.pos()-1) )
+                      cur.par()->isWord(cur.pos()-1))
                        cur.pos(cur.pos() - 1);
        }
 }
@@ -2221,7 +2260,7 @@ void LyXText::getWord(LyXCursor & from, LyXCursor & to,
 {
        // first put the cursor where we wana start to select the word
        from = cursor;
-       switch(loc) {
+       switch (loc) {
        case WHOLE_WORD_STRICT:
                if (cursor.pos() == 0 || cursor.pos() == cursor.par()->size()
                    || cursor.par()->isSeparator(cursor.pos())
@@ -2253,7 +2292,7 @@ void LyXText::getWord(LyXCursor & from, LyXCursor & to,
        while (to.pos() < to.par()->size()
               && !to.par()->isSeparator(to.pos())
               && !to.par()->isKomma(to.pos())
-              && !to.par()->isHfill(to.pos()) )
+              && !to.par()->isHfill(to.pos()))
        {
                to.pos(to.pos() + 1);
        }
@@ -2270,7 +2309,7 @@ void LyXText::selectWord(BufferView * bview, word_location const loc)
        if (to == from)
                return;
        selection.cursor = cursor;
-       setCursor(bview, to.par(), to.pos() );
+       setCursor(bview, to.par(), to.pos());
        setSelection(bview);
 }
 
@@ -2299,9 +2338,7 @@ string const LyXText::selectNextWordToSpellcheck(BufferView * bview,
                        value += float(cursor.y())/float(height);
                        return str;
                }
-#warning Dekel please have a look on this one RTL? (Jug)
-#warning DEKEL!
-               // we have to go on checking so move cusor to the right
+               // we have to go on checking so move cusor to the next char
                if (cursor.pos() == cursor.par()->size()) {
                        if (!cursor.par()->next())
                                return str;
@@ -2348,7 +2385,7 @@ string const LyXText::selectNextWordToSpellcheck(BufferView * bview,
        }               
   
        // Update the value if we changed paragraphs
-       if (cursor.par() != tmppar){
+       if (cursor.par() != tmppar) {
                setCursor(bview, cursor.par(), cursor.pos());
                value = float(cursor.y())/float(height);
        }
@@ -2365,7 +2402,7 @@ string const LyXText::selectNextWordToSpellcheck(BufferView * bview,
        // Finally, we copy the word to a string and return it
        string str;
        if (selection.cursor.pos() < cursor.pos()) {
-               Paragraph::size_type i;
+               pos_type i;
                for (i = selection.cursor.pos(); i < cursor.pos(); ++i) {
                        if (!cursor.par()->isInset(i))
                                str += cursor.par()->getChar(i);
@@ -2501,7 +2538,7 @@ void LyXText::changeRegionCase(BufferView * bview,
        setUndo(bview, Undo::FINISH,
                from.par(), to.par()->next());
 
-       Paragraph::size_type pos = from.pos();
+       pos_type pos = from.pos();
        Paragraph * par = from.par();
 
        while (par && (pos != to.pos() || par != to.par())) {
@@ -2544,7 +2581,7 @@ void LyXText::transposeChars(BufferView & bview)
        setUndo(&bview, Undo::FINISH,
                tmppar, tmppar->next()); 
 
-       Paragraph::size_type tmppos = cursor.pos();
+       pos_type tmppos = cursor.pos();
 
        // First decide if it is possible to transpose at all
 
@@ -2609,7 +2646,7 @@ void LyXText::Delete(BufferView * bview)
 void LyXText::backspace(BufferView * bview)
 {
        // Get the font that is used to calculate the baselineskip
-       Paragraph::size_type lastpos = cursor.par()->size();
+       pos_type lastpos = cursor.par()->size();
        LyXFont rawparfont =
                cursor.par()->getFontSettings(bview->buffer()->params,
                                              lastpos - 1);
@@ -2630,7 +2667,7 @@ void LyXText::backspace(BufferView * bview)
                        
                        if (cursor.par()->previous()) {
                                Paragraph * tmppar = cursor.par()->previous();
-                               if (cursor.par()->getLayout() == tmppar->getLayout()
+                               if (cursor.par()->layout() == tmppar->layout()
                                    && cursor.par()->getAlign() == tmppar->getAlign()) {
                                        // Inherit bottom DTD from the paragraph below.
                                        // (the one we are deleting)
@@ -2682,11 +2719,12 @@ void LyXText::backspace(BufferView * bview)
                  
                   Correction: Pasting is always allowed with standard-layout
                */
+               LyXTextClass const & tclass = textclasslist[bview->buffer()->params.textclass];
+               
                if (cursor.par() != tmppar
-                   && (cursor.par()->getLayout() == tmppar->getLayout()
-                       || tmppar->getLayout() == 0 /*standard*/)
-                   && cursor.par()->getAlign() == tmppar->getAlign())
-               {
+                   && (cursor.par()->layout() == tmppar->layout()
+                       || tmppar->layout() == tclass.defaultLayoutName())
+                   && cursor.par()->getAlign() == tmppar->getAlign()) {
                        removeParagraph(tmprow);
                        removeRow(tmprow);
                        cursor.par()->pasteParagraph(bview->buffer()->params);
@@ -2732,7 +2770,7 @@ void LyXText::backspace(BufferView * bview)
                                false, cursor.boundary());
                
                // some insets are undeletable here
-               if (cursor.par()->getChar(cursor.pos()) == Paragraph::META_INSET) {
+               if (cursor.par()->isInset(cursor.pos())) {
                        if (!cursor.par()->getInset(cursor.pos())->deletable())
                                return; 
                        // force complete redo when erasing display insets
@@ -2747,7 +2785,7 @@ void LyXText::backspace(BufferView * bview)
                
                Row * row = cursor.row();
                int y = cursor.y() - row->baseline();
-               Paragraph::size_type z;
+               pos_type z;
                /* remember that a space at the end of a row doesnt count
                 * when calculating the fill */ 
                if (cursor.pos() < rowLast(row) ||
@@ -2916,8 +2954,9 @@ void LyXText::backspace(BufferView * bview)
                redoHeightOfParagraph(bview, cursor);
        } else {
                // now the special right address boxes
-               if (textclasslist.Style(bview->buffer()->params.textclass,
-                                       cursor.par()->getLayout()).margintype == MARGIN_RIGHT_ADDRESS_BOX) {
+               if (textclasslist
+                   [bview->buffer()->params.textclass]
+                   [cursor.par()->layout()].margintype == MARGIN_RIGHT_ADDRESS_BOX) {
                        redoDrawingOfParagraph(bview, cursor); 
                }
        }
@@ -2930,10 +2969,10 @@ bool LyXText::paintRowBackground(DrawRowParams & p)
        Inset * inset = 0;
        LyXFont font(LyXFont::ALL_SANE);
 
-       Paragraph::size_type const last = rowLastPrintable(p.row);
+       pos_type const last = rowLastPrintable(p.row);
 
        if (!p.bv->screen()->forceClear() && last == p.row->pos()
-               && isMetaInset(p.row->par(), p.row->pos())) {
+               && p.row->par()->isInset(p.row->pos())) {
                inset = p.row->par()->getInset(p.row->pos());
                if (inset) {
                        clear_area = inset->doClearArea();
@@ -3043,15 +3082,17 @@ void LyXText::paintRowSelection(DrawRowParams & p)
  
        Buffer const * buffer = p.bv->buffer();
        Paragraph * par = row->par();
-       Paragraph::size_type main_body = beginningOfMainBody(buffer, par);
-       Paragraph::size_type const last = rowLastPrintable(row);
+       pos_type main_body = beginningOfMainBody(buffer, par);
+       pos_type const last = rowLastPrintable(row);
  
-       for (Paragraph::size_type vpos = row->pos(); vpos <= last; ++vpos)  {
-               Paragraph::size_type pos = vis2log(vpos);
+       for (pos_type vpos = row->pos(); vpos <= last; ++vpos)  {
+               pos_type pos = vis2log(vpos);
                float const old_tmpx = tmpx;
                if (main_body > 0 && pos == main_body - 1) {
-                       LyXLayout const & layout = textclasslist.Style(buffer->params.textclass,
-                               par->getLayout());
+                       LyXLayout const & layout =
+                               textclasslist
+                               [buffer->params.textclass]
+                               [par->layout()];
                        LyXFont const lfont = getLabelFont(buffer, par);
                         
  
@@ -3138,6 +3179,97 @@ void LyXText::paintRowDepthBar(DrawRowParams & p)
        }
 }
 
+
+int LyXText::getLengthMarkerHeight(BufferView * bv, VSpace const & vsp) const
+{
+       int const arrow_size = 4;
+       int const space_size = int(vsp.inPixels(bv));
+
+       if (vsp.kind() != VSpace::LENGTH) {
+               return space_size;
+       }
+       LyXFont font;
+       font.decSize();
+       int const min_size = max(3 * arrow_size,
+                                     lyxfont::maxAscent(font)
+                                     + lyxfont::maxDescent(font));
+
+       if (vsp.length().len().value() < 0.0)
+               return min_size;
+       else 
+               return max(min_size, space_size);
+}
+
+int LyXText::drawLengthMarker(DrawRowParams & p, string const & prefix,
+                             VSpace const & vsp, int start)
+{
+       int const arrow_size = 4;
+       int const size = getLengthMarkerHeight(p.bv, vsp);
+       int const end = start + size;
+
+       // the label to display (if any)
+       string str;
+       // y-values for top arrow
+       int ty1, ty2;
+       // y-values for bottom arrow
+       int by1, by2;
+       switch (vsp.kind()) {
+       case VSpace::LENGTH:
+       {
+               str = prefix + " (" + vsp.asLyXCommand() + ")";
+               // adding or removing space
+               bool const added = !(vsp.length().len().value() < 0.0);
+               ty1 = added ? (start + arrow_size) : start;
+               ty2 = added ? start : (start + arrow_size);
+               by1 = added ? (end - arrow_size) : end;
+               by2 = added ? end : (end - arrow_size);
+               break;
+       }
+       case VSpace:: VFILL:
+               str = prefix + " (vertical fill)";
+               ty1 = ty2 = start;
+               by1 = by2 = end;
+               break;
+       default:
+               // nothing to draw here
+               return size;
+       }
+       int const leftx = p.xo + leftMargin(p.bv, p.row);
+       int const midx = leftx + arrow_size;
+       int const rightx = midx + arrow_size;
+       // first the string
+       int w = 0;
+       int a = 0;
+       int d = 0;
+       LyXFont font;
+       font.setColor(LColor::added_space).decSize();
+       lyxfont::rectText(str, font, w, a, d);
+       p.pain->rectText(leftx + 2 * arrow_size + 5, 
+                        start + ((end - start) / 2) + d,
+                        str, font,
+                        backgroundColor(),
+                        backgroundColor());
+       
+       // top arrow
+       p.pain->line(leftx, ty1, midx, ty2, LColor::added_space);
+       p.pain->line(midx, ty2, rightx, ty1, LColor::added_space);
+
+       // bottom arrow
+       p.pain->line(leftx, by1, midx, by2, LColor::added_space);
+       p.pain->line(midx, by2, rightx, by1, LColor::added_space);
+
+       // joining line
+       p.pain->line(midx, ty2, midx, by2, LColor::added_space);
+
+       return size;
+}
  
 void LyXText::paintFirstRow(DrawRowParams & p)
 {
@@ -3150,7 +3282,7 @@ void LyXText::paintFirstRow(DrawRowParams & p)
        }
        
        int y_top = 0;
-               
+
        // think about the margins
        if (!p.row->previous() && bv_owner)
                y_top += LYX_PAPER_MARGIN;
@@ -3158,7 +3290,8 @@ void LyXText::paintFirstRow(DrawRowParams & p)
        // draw a top pagebreak
        if (parparams.pagebreakTop()) {
                int const y = p.yo + y_top + 2*defaultHeight();
-               p.pain->line(0, y, p.width, y, LColor::pagebreak, Painter::line_onoffdash);
+               p.pain->line(p.xo, y, p.xo + p.width, y, 
+                       LColor::pagebreak, Painter::line_onoffdash);
  
                int w = 0;
                int a = 0;
@@ -3174,29 +3307,14 @@ void LyXText::paintFirstRow(DrawRowParams & p)
                y_top += 3 * defaultHeight();
        }
        
-       // draw a vfill top
-       if (parparams.spaceTop().kind() == VSpace::VFILL) {
-               int const y1 = p.yo + y_top + 3 * defaultHeight();
-               int const y2 = p.yo + 2 + y_top;
-               p.pain->line(0, y1, LYX_PAPER_MARGIN, y1, LColor::vfillline);
-               
-               p.pain->line(0, y2, LYX_PAPER_MARGIN, y2, LColor::vfillline);
-
-               int const x = LYX_PAPER_MARGIN / 2;
-               p.pain->line(x, y2, x, y1, LColor::vfillline);
-               
-               y_top += 3 * defaultHeight();
-       }
-       
-       // think about user added space
-       y_top += int(parparams.spaceTop().inPixels(p.bv));
+       // draw the additional space if needed:
+       y_top += drawLengthMarker(p, _("Space above"),
+                                 parparams.spaceTop(), p.yo + y_top);
        
        Buffer const * buffer = p.bv->buffer();
-       LyXLayout const & layout =
-               textclasslist.Style(buffer->params.textclass, par->getLayout());
+
+       LyXTextClass const & tclass = textclasslist[buffer->params.textclass];
+       LyXLayout const & layout = tclass[par->layout()];
 
        // think about the parskip
        // some parskips VERY EASY IMPLEMENTATION
@@ -3207,8 +3325,7 @@ void LyXText::paintFirstRow(DrawRowParams & p)
                                y_top += buffer->params.getDefSkip().inPixels(p.bv);
                        } else {
                                LyXLayout const & playout =
-                                       textclasslist.Style(buffer->params.textclass,
-                                               par->previous()->getLayout()); 
+                                       tclass[par->previous()->layout()]; 
                                if (playout.latextype == LATEX_PARAGRAPH
                                        && !par->previous()->getDepth()) {
                                        // is it right to use defskip here, too? (AS) 
@@ -3228,8 +3345,8 @@ void LyXText::paintFirstRow(DrawRowParams & p)
                y_top += asc;
  
                int const w = (inset_owner ?  inset_owner->width(p.bv, font) : ww);
-               int const xp = static_cast<int>(inset_owner ? p.x : 0);
-               p.pain->line(xp, p.yo + y_top, w, p.yo + y_top,
+               int const xp = static_cast<int>(inset_owner ? p.xo : 0);
+               p.pain->line(xp, p.yo + y_top, xp + w, p.yo + y_top,
                        LColor::topline, Painter::line_solid,
                        Painter::line_thick);
                
@@ -3270,7 +3387,7 @@ void LyXText::paintFirstRow(DrawRowParams & p)
                                                        lyxfont::width(str, font);
                                        }
  
-                                       p.pain->text(int(x), p.yo +
+                                       p.pain->text(int(x),
                                                p.yo + p.row->baseline() - 
                                                p.row->ascent_of_text() - maxdesc,
                                                str, font);
@@ -3279,9 +3396,10 @@ void LyXText::paintFirstRow(DrawRowParams & p)
                                if (is_rtl) {
                                        x = ww - leftMargin(p.bv, p.row)
                                                + lyxfont::width(layout.labelsep, font);
-                               } else
+                               } else {
                                        x = p.x - lyxfont::width(layout.labelsep, font)
                                                - lyxfont::width(str, font);
+                               }
 
                                p.pain->text(int(x), p.yo + p.row->baseline(), str, font);
                        }
@@ -3309,7 +3427,7 @@ void LyXText::paintFirstRow(DrawRowParams & p)
                        float x = p.x;
                        if (layout.labeltype == LABEL_CENTERED_TOP_ENVIRONMENT) {
                                x = ((is_rtl ? leftMargin(p.bv, p.row) : p.x)
-                                        + ww - rightMargin(buffer, p.row) ) / 2; 
+                                        + ww - rightMargin(buffer, p.row)) / 2; 
                                x -= lyxfont::width(str, font) / 2;
                        } else if (is_rtl) {
                                x = ww - leftMargin(p.bv, p.row) - 
@@ -3340,7 +3458,7 @@ void LyXText::paintLastRow(DrawRowParams & p)
 {
        Paragraph * par = p.row->par();
        ParagraphParameters const & parparams = par->params();
-       int y_bottom = p.row->height();
+       int y_bottom = p.row->height() - 1;
        
        // think about the margins
        if (!p.row->next() && bv_owner)
@@ -3354,7 +3472,8 @@ void LyXText::paintLastRow(DrawRowParams & p)
                pb_font.setColor(LColor::pagebreak).decSize();
                int const y = p.yo + y_bottom - 2 * defaultHeight();
  
-               p.pain->line(0, y, ww, y, LColor::pagebreak, Painter::line_onoffdash);
+               p.pain->line(p.xo, y, p.xo + p.width, y, LColor::pagebreak,
+                            Painter::line_onoffdash);
  
                int w = 0;
                int a = 0;
@@ -3367,22 +3486,12 @@ void LyXText::paintLastRow(DrawRowParams & p)
                y_bottom -= 3 * defaultHeight();
        }
        
-       // draw a vfill bottom
-       if (parparams.spaceBottom().kind() == VSpace::VFILL) {
-               int const x = LYX_PAPER_MARGIN / 2; 
-               int const x2 = LYX_PAPER_MARGIN;
-               int const y = p.yo + y_bottom - 3 * defaultHeight();
-               int const y2 = p.yo + y_bottom - 2;
-               
-               p.pain->line(0, y, x2, y, LColor::vfillline);
-               p.pain->line(0, y2, x2, y2, LColor::vfillline);
-               p.pain->line(x, y, x, y2, LColor::vfillline);
-               y_bottom -= 3 * defaultHeight();
-       }
-       
-       // think about user added space
-       y_bottom -= int(parparams.spaceBottom().inPixels(p.bv));
+       // draw the additional space if needed:
+       int const height =  getLengthMarkerHeight(p.bv,
+                                                 parparams.spaceBottom());
+       y_bottom -= drawLengthMarker(p, _("Space below"),
+                                    parparams.spaceBottom(),
+                                    p.yo + y_bottom - height);
        
        Buffer const * buffer = p.bv->buffer();
  
@@ -3391,20 +3500,19 @@ void LyXText::paintLastRow(DrawRowParams & p)
                LyXFont font(LyXFont::ALL_SANE);
                int const asc = lyxfont::ascent('x',
                        getFont(buffer, par,
-                       max(Paragraph::size_type(0), par->size() - 1)));
+                       max(pos_type(0), par->size() - 1)));
  
                y_bottom -= asc;
  
                int const w = (inset_owner ?  inset_owner->width(p.bv, font) : ww);
-               int const xp = static_cast<int>(inset_owner ? p.x : 0);
+               int const xp = static_cast<int>(inset_owner ? p.xo : 0);
                int const y = p.yo + y_bottom; 
-               p.pain->line(xp, y, w, y, LColor::topline, Painter::line_solid,
+               p.pain->line(xp, y, xp + w, y, LColor::topline, Painter::line_solid,
                          Painter::line_thick);
  
                y_bottom -= asc;
        }
 
-       Paragraph::size_type const last = rowLastPrintable(p.row);
        bool const is_rtl = p.row->par()->isRightToLeftPar(p.bv->buffer()->params);
        int const endlabel = par->getEndLabel(buffer->params);
  
@@ -3413,7 +3521,7 @@ void LyXText::paintLastRow(DrawRowParams & p)
        case END_LABEL_BOX:
        case END_LABEL_FILLED_BOX:
        {
-               LyXFont const font = getFont(buffer, par, last);
+               LyXFont const font = getLabelFont(buffer, par);
                int const size = int(0.75 * lyxfont::maxAscent(font));
                int const y = (p.yo + p.row->baseline()) - size;
                int x = is_rtl ? LYX_PAPER_MARGIN : ww - LYX_PAPER_MARGIN - size;
@@ -3422,21 +3530,18 @@ void LyXText::paintLastRow(DrawRowParams & p)
                        x += (size - p.row->fill() + 1) * (is_rtl ? -1 : 1);
  
                if (endlabel == END_LABEL_BOX) {
-                       p.pain->line(x, y, x, y + size, LColor::eolmarker);
-                       p.pain->line(x + size, y, x + size , y + size, LColor::eolmarker);
-                       p.pain->line(x, y, x + size, y, LColor::eolmarker);
-                       p.pain->line(x, y + size, x + size, y + size, LColor::eolmarker);
+                       p.pain->rectangle(x, y, size, size, LColor::eolmarker);
                } else {
-                       p.pain->fillRectangle(x, y, size, size, LColor::eolmarker);
+                       p.pain->fillRectangle(x, y, size, size,
+                                             LColor::eolmarker);
                }
                break;
        }
        case END_LABEL_STATIC:
        {
                LyXFont font(LyXFont::ALL_SANE);
-               LyXTextClass::LayoutList::size_type layout = par->getLayout();
-               string const str = textclasslist.
-                       Style(buffer->params.textclass, layout).endlabelstring();
+               string const & layout = par->layout();
+               string const str = textclasslist[buffer->params.textclass][layout].endlabelstring();
                font = getLabelFont(buffer, par);
                int const x = is_rtl ?
                        int(p.x) - lyxfont::width(str, font)
@@ -3454,8 +3559,8 @@ void LyXText::paintRowText(DrawRowParams & p)
        Paragraph * par = p.row->par();
        Buffer const * buffer = p.bv->buffer(); 
  
-       Paragraph::size_type const last = rowLastPrintable(p.row);
-       Paragraph::size_type main_body = 
+       pos_type const last = rowLastPrintable(p.row);
+       pos_type main_body = 
                beginningOfMainBody(buffer, par);
        if (main_body > 0 && 
                (main_body - 1 > last || 
@@ -3464,11 +3569,11 @@ void LyXText::paintRowText(DrawRowParams & p)
        }
        
        LyXLayout const & layout =
-               textclasslist.Style(buffer->params.textclass, par->getLayout());
+               textclasslist[buffer->params.textclass][par->layout()];
 
-       Paragraph::size_type vpos = p.row->pos();
+       pos_type vpos = p.row->pos();
        while (vpos <= last) {
-               Paragraph::size_type pos = vis2log(vpos);
+               pos_type pos = vis2log(vpos);
                if (main_body > 0 && pos == main_body - 1) {
                        int const lwidth = lyxfont::width(layout.labelsep,
                                getLabelFont(buffer, par));
@@ -3484,7 +3589,7 @@ void LyXText::paintRowText(DrawRowParams & p)
                        int const y1 = y0 - defaultHeight() / 2;
 
                        p.pain->line(int(p.x), y1, int(p.x), y0,
-                                    LColor::vfillline);
+                                    LColor::added_space);
                        
                        if (hfillExpansion(buffer, p.row, pos)) {
                                int const y2 = (y0 + y1) / 2;
@@ -3492,19 +3597,19 @@ void LyXText::paintRowText(DrawRowParams & p)
                                if (pos >= main_body) {
                                        p.pain->line(int(p.x), y2,
                                                  int(p.x + p.hfill), y2,
-                                                 LColor::vfillline,
+                                                 LColor::added_space,
                                                  Painter::line_onoffdash);
                                        p.x += p.hfill;
                                } else {
                                        p.pain->line(int(p.x), y2,
                                                  int(p.x + p.label_hfill), y2,
-                                                 LColor::vfillline,
+                                                 LColor::added_space,
                                                  Painter::line_onoffdash);
                                        p.x += p.label_hfill;
                                }
                                p.pain->line(int(p.x), y1,
                                             int(p.x), y0,
-                                            LColor::vfillline);
+                                            LColor::added_space);
                        }
                        p.x += 2;
                        ++vpos;
@@ -3514,7 +3619,7 @@ void LyXText::paintRowText(DrawRowParams & p)
                                p.x += p.separator;
                        ++vpos;
                } else {
-                       draw(p.bv, p.row, vpos, p.yo, p.x, p.cleared);
+                       draw(p, vpos);
                }
        }
 }
@@ -3574,7 +3679,7 @@ void LyXText::getVisibleRow(BufferView * bv, int y_offset, int x_offset,
        // paint text
        paintRowText(p); 
 }
-
 
 int LyXText::defaultHeight() const
 {
@@ -3585,7 +3690,7 @@ int LyXText::defaultHeight() const
    
 /* returns the column near the specified x-coordinate of the row 
 * x is set to the real beginning of this column  */ 
-Paragraph::size_type
+pos_type
 LyXText::getColumnNearX(BufferView * bview, Row * row, int & x,
                        bool & boundary) const
 {
@@ -3597,16 +3702,15 @@ LyXText::getColumnNearX(BufferView * bview, Row * row, int & x,
        prepareToPrint(bview, row, tmpx, fill_separator,
                       fill_hfill, fill_label_hfill);
 
-       Paragraph::size_type vc = row->pos();
-       Paragraph::size_type last = rowLastPrintable(row);
-       Paragraph::size_type c = 0;
+       pos_type vc = row->pos();
+       pos_type last = rowLastPrintable(row);
+       pos_type c = 0;
        LyXLayout const & layout =
-               textclasslist.Style(bview->buffer()->params.textclass,
-                                   row->par()->getLayout());
+               textclasslist[bview->buffer()->params.textclass][
+                                   row->par()->layout()];
        bool left_side = false;
 
-       Paragraph::size_type
-               main_body = beginningOfMainBody(bview->buffer(), row->par());
+       pos_type main_body = beginningOfMainBody(bview->buffer(), row->par());
        float last_tmpx = tmpx;
        
        if (main_body > 0 &&
@@ -3661,8 +3765,8 @@ LyXText::getColumnNearX(BufferView * bview, Row * row, int & x,
        if (row->pos() > last)  // Row is empty?
                c = row->pos();
        else if (lastrow &&
-                ( ( rtl &&  left_side && vc == row->pos() && x < tmpx - 5) ||
-                  (!rtl && !left_side && vc == last + 1   && x > tmpx + 5) ))
+                ((rtl &&  left_side && vc == row->pos() && x < tmpx - 5) ||
+                  (!rtl && !left_side && vc == last + 1   && x > tmpx + 5)))
                c = last + 1;
        else if (vc == row->pos()) {
                c = vis2log(vc);
@@ -3690,11 +3794,10 @@ LyXText::getColumnNearX(BufferView * bview, Row * row, int & x,
        x = int(tmpx);
        return c;
 }
-
 
 // returns pointer to a specified row
-Row * LyXText::getRow(Paragraph * par,
-                      Paragraph::size_type pos, int & y) const
+Row * LyXText::getRow(Paragraph * par, pos_type pos, int & y) const
 {
        if (!firstrow)
                return 0;
@@ -3719,3 +3822,25 @@ Row * LyXText::getRow(Paragraph * par,
        
        return tmprow;
 }
+
+
+Row * LyXText::getRowNearY(int & y) const
+{
+       // If possible we should optimize this method. (Lgb)
+       Row * tmprow = firstrow;
+       int tmpy = 0;
+       
+       while (tmprow->next() && tmpy + tmprow->height() <= y) {
+               tmpy += tmprow->height();
+               tmprow = tmprow->next();
+       }
+       
+       y = tmpy;   // return the real y
+       return tmprow;
+}
+
+
+int LyXText::getDepth() const
+{
+       return cursor.par()->getDepth();
+}