]> git.lyx.org Git - lyx.git/blobdiff - src/tabular.C
lowercase tabular identifiers
[lyx.git] / src / tabular.C
index 25697c118f6cee99018706591de3423f4c2f3bb5..f38c41a0cc572a1ef3ce59d59c3a74fdbc07e76c 100644 (file)
@@ -42,8 +42,6 @@ using std::vector;
 
 static int const WIDTH_OF_LINE = 5;
 
-extern BufferView * current_view;
-
 /// Define a few methods for the inner structs
 
 LyXTabular::cellstruct::cellstruct() 
@@ -53,9 +51,9 @@ LyXTabular::cellstruct::cellstruct()
     multicolumn = LyXTabular::CELL_NORMAL;
     alignment = LYX_ALIGN_CENTER;
     valignment = LYX_VALIGN_TOP;
-    top_line = false;
+    top_line = true;
     bottom_line = false;
-    left_line = false;
+    left_line = true;
     right_line = false;
     usebox = BOX_NONE;
     rotate = false;
@@ -94,7 +92,9 @@ LyXTabular::LyXTabular(InsetTabular * inset, LyXTabular const & lt)
 {
     owner_ = inset;
     Init(lt.rows_, lt.columns_);
+#ifdef WITH_WARNINGS
 #warning Jürgen, can you make it the other way round. So that copy assignment depends on the copy constructor and not the other way. (Lgb)
+#endif
     operator=(lt);
 }
 
@@ -106,13 +106,6 @@ LyXTabular::LyXTabular(Buffer const * buf, InsetTabular * inset, LyXLex & lex)
 }
 
 
-LyXTabular::~LyXTabular()
-{
-    delete[] rowofcell;
-    delete[] columnofcell;
-}
-
-
 LyXTabular & LyXTabular::operator=(LyXTabular const & lt)
 {
     // If this and lt is not of the same size we have a serious bug
@@ -144,8 +137,8 @@ LyXTabular * LyXTabular::Clone(InsetTabular * inset)
     LyXTabular * result = new LyXTabular(inset, *this);
     // don't know if this is good but I need to Clone also
     // the text-insets here, this is for the Undo-facility!
-    for(int i = 0; i < rows_; ++i) {
-       for(int j = 0; j < columns_; ++j) {
+    for (int i = 0; i < rows_; ++i) {
+       for (int j = 0; j < columns_; ++j) {
            result->cell_info[i][j].inset = cell_info[i][j].inset;
            result->cell_info[i][j].inset.setOwner(inset);
        }
@@ -157,14 +150,12 @@ LyXTabular * LyXTabular::Clone(InsetTabular * inset)
 /* activates all lines and sets all widths to 0 */ 
 void LyXTabular::Init(int rows_arg, int columns_arg)
 {
-
     rows_ = rows_arg;
     columns_ = columns_arg;
     row_info = row_vector(rows_, rowstruct());
     column_info = column_vector(columns_, columnstruct());
     cell_info = cell_vvector(rows_, cell_vector(columns_, cellstruct()));
 
-    // Jürgen, use iterators.
     int cellno = 0;
     for (int i = 0; i < rows_; ++i) {
         for (int j = 0; j < columns_; ++j) {
@@ -172,22 +163,20 @@ void LyXTabular::Init(int rows_arg, int columns_arg)
            cell_info[i][j].inset.SetDrawFrame(0, InsetText::LOCKED);
             cell_info[i][j].cellno = cellno++;
         }
+       cell_info[i].back().right_line = true;
     }
-    //row_info[i - 1].bottom_line = true;
-    //row_info[0].bottom_line = true;
     row_info.back().bottom_line = true;
     row_info.front().bottom_line = true;
 
     for (int i = 0; i < columns_; ++i) {
         calculate_width_of_column(i);
     }
-    //column_info[columns_ - 1].right_line = true;
     column_info.back().right_line = true;
    
     calculate_width_of_tabular();
 
-    rowofcell = 0;
-    columnofcell = 0;
+    rowofcell = vector<int>();
+    columnofcell = vector<int>();
     set_row_column_number_info();
     is_long_tabular = false;
     rotate = false;
@@ -214,13 +203,13 @@ void LyXTabular::AppendRow(int cell)
     cell_vvector c_info = cell_vvector(rows_, cell_vector(columns_,
                                                          cellstruct()));
 
-    for(int i = 0; i <= row; ++i) {
-       for(int j = 0; j < columns_; ++j) {
+    for (int i = 0; i <= row; ++i) {
+       for (int j = 0; j < columns_; ++j) {
            c_info[i][j] = cell_info[i][j];
        }
     }
-    for(int i = row + 1; i < rows_; ++i) {
-       for(int j = 0; j < columns_; ++j) {
+    for (int i = row + 1; i < rows_; ++i) {
+       for (int j = 0; j < columns_; ++j) {
            c_info[i][j] = cell_info[i-1][j];
        }
     }
@@ -254,7 +243,7 @@ void LyXTabular::AppendColumn(int cell)
    
     cell_vvector c_info = cell_vvector(rows_, cell_vector(columns_,
                                                          cellstruct()));
-    int column = column_of_cell(cell);
+    int const column = column_of_cell(cell);
     column_vector::iterator cit = column_info.begin() + column + 1;
     column_info.insert(cit, columnstruct());
 
@@ -275,9 +264,10 @@ void LyXTabular::AppendColumn(int cell)
         }
     }
     cell_info = c_info;
-    ++column;
+    //++column;
     for (int i = 0; i < rows_; ++i) {
-       cell_info[i][column].inset.clear();
+       //cell_info[i][column].inset.clear();
+       cell_info[i][column + 1].inset.clear();
     }
     Reinit();
 }
@@ -301,7 +291,6 @@ void LyXTabular::DeleteColumn(int column)
 
 void LyXTabular::Reinit()
 {   
-    // Jürgen, use iterators.
     for (int i = 0; i < rows_; ++i) {
        for (int j = 0; j < columns_; ++j) {
            cell_info[i][j].width_of_cell = 0;
@@ -318,14 +307,11 @@ void LyXTabular::Reinit()
 }
 
 
-void LyXTabular::set_row_column_number_info()
+void LyXTabular::set_row_column_number_info(bool oldformat)
 {
-    int c = 0;
-    int column = 0;
     numberofcells = -1;
-    int row = 0;
-    for (; row < rows_; ++row) {
-       for (column = 0; column<columns_; ++column) {
+    for (int row = 0; row < rows_; ++row) {
+       for (int column = 0; column<columns_; ++column) {
            if (cell_info[row][column].multicolumn
                != LyXTabular::CELL_PART_OF_MULTICOLUMN)
                ++numberofcells;
@@ -333,15 +319,12 @@ void LyXTabular::set_row_column_number_info()
        }
     }
     ++numberofcells; // because this is one more than as we start from 0
-    row = 0;
-    column = 0;
 
-    delete [] rowofcell;
-    rowofcell = new int[numberofcells];
-    delete [] columnofcell;
-    columnofcell = new int[numberofcells];
-  
-    while (c < numberofcells && row < rows_ && column < columns_) {
+    rowofcell.resize(numberofcells);
+    columnofcell.resize(numberofcells);
+
+    for (int row = 0, column = 0, c = 0;
+        c < numberofcells && row < rows_ && column < columns_;) {
        rowofcell[c] = row;
        columnofcell[c] = column;
        ++c;
@@ -355,10 +338,19 @@ void LyXTabular::set_row_column_number_info()
            ++row;
        }
     }
-    for (row = 0; row < rows_; ++row) {
-       for (column = 0; column<columns_; ++column) {
+
+    for (int row = 0; row < rows_; ++row) {
+       for (int column = 0; column < columns_; ++column) {
            if (IsPartOfMultiColumn(row,column))
                continue;
+           // now set the right line of multicolumns right for oldformat read
+           if (oldformat &&
+               cell_info[row][column].multicolumn==CELL_BEGIN_OF_MULTICOLUMN)
+           {
+               int cn=cells_in_multicolumn(cell_info[row][column].cellno);
+               cell_info[row][column].right_line =
+                   cell_info[row][column+cn-1].right_line;
+           }
            cell_info[row][column].inset.SetAutoBreakRows(
                !GetPWidth(GetCellNumber(row, column)).empty());
        }
@@ -400,7 +392,7 @@ bool LyXTabular::BottomLine(int cell, bool onlycolumn) const
     // no bottom line underneath non-existent cells if you please
     // Isn't that a programming error? Is so this should
     // be an Assert instead. (Lgb)
-    if(cell >= numberofcells)
+    if (cell >= numberofcells)
        return false;
 
     if (!onlycolumn && IsMultiColumn(cell))
@@ -473,9 +465,8 @@ int LyXTabular::GetAdditionalHeight(int cell) const
     int const row = row_of_cell(cell);
     if (!row) return 0;
 
-#warning Jürgen, should the types change? (Lgb)
-    int top = 1; // bool top = true; ??
-    int bottom = 1; // bool bottom = true; ??
+    bool top = true;
+    bool bottom = true;
 
     for (int column = 0; column < columns_ - 1 && bottom; ++column) {
        switch (cell_info[row - 1][column].multicolumn) {
@@ -520,8 +511,7 @@ int LyXTabular::GetWidthOfColumn(int cell) const
     int const column1 = column_of_cell(cell);
     int const column2 = right_column_of_cell(cell);
     int result = 0;
-    int i = column1;
-    for (; i <= column2; ++i) {
+    for (int i = column1; i <= column2; ++i) {
        result += column_info[i].width_of_column;
     }
     return result;
@@ -545,15 +535,14 @@ bool LyXTabular::SetWidthOfMulticolCell(int cell, int new_width)
     int const column2 = right_column_of_cell(cell);
 
     // first set columns to 0 so we can calculate the right width
-    int i = column1;
-    for (; i <= column2; ++i) {
+    for (int i = column1; i <= column2; ++i) {
         cell_info[row][i].width_of_cell = 0;
     }
     // set the width to MAX_WIDTH until width > 0
     int width = (new_width + 2 * WIDTH_OF_LINE);
-    for (i = column1;
-        i < column2 && width > column_info[i].width_of_column;
-        ++i) {
+
+    int i = column1;
+    for (; i < column2 && width > column_info[i].width_of_column; ++i) {
         cell_info[row][i].width_of_cell = column_info[i].width_of_column;
         width -= column_info[i].width_of_column;
     }
@@ -574,7 +563,7 @@ void LyXTabular::recalculateMulticolCells(int cell, int new_width)
     int i = column1;
     for (; i <= column2; ++i)
         cell_info[row][i].width_of_cell = 0;
-    for(i = cell + 1; (i < numberofcells) && (!IsMultiColumn(i)); ++i)
+    for (i = cell + 1; (i < numberofcells) && (!IsMultiColumn(i)); ++i)
         ;
     if (i < numberofcells)
         recalculateMulticolCells(i, GetWidthOfCell(i) - (2 * WIDTH_OF_LINE));
@@ -604,13 +593,13 @@ bool LyXTabular::SetWidthOfCell(int cell, int new_width)
     }
     if (tmp) {
         int i = 0;
-        for(; i<columns_; ++i)
+        for (; i<columns_; ++i)
             calculate_width_of_column_NMC(i);
-        for(i = 0; (i < numberofcells) && !IsMultiColumn(i); ++i)
+        for (i = 0; (i < numberofcells) && !IsMultiColumn(i); ++i)
             ;
         if (i < numberofcells)
             recalculateMulticolCells(i, GetWidthOfCell(i)-(2 * WIDTH_OF_LINE));
-        for(i = 0; i < columns_; ++i)
+        for (i = 0; i < columns_; ++i)
             calculate_width_of_column(i);
         calculate_width_of_tabular();
         return true;
@@ -621,7 +610,6 @@ bool LyXTabular::SetWidthOfCell(int cell, int new_width)
 
 bool LyXTabular::SetAlignment(int cell, LyXAlignment align, bool onlycolumn)
 {
-#warning Please fix align type. (Lgb)
     if (!IsMultiColumn(cell) || onlycolumn)
         column_info[column_of_cell(cell)].alignment = align;
     if (!onlycolumn)
@@ -630,9 +618,8 @@ bool LyXTabular::SetAlignment(int cell, LyXAlignment align, bool onlycolumn)
 }
 
 
-bool LyXTabular::SetVAlignment(int cell, char align, bool onlycolumn)
+bool LyXTabular::SetVAlignment(int cell, VAlignment align, bool onlycolumn)
 {
-#warning Please fix align type. (Lgb)
     if (!IsMultiColumn(cell) || onlycolumn)
         column_info[column_of_cell(cell)].valignment = align;
     if (!onlycolumn)
@@ -649,7 +636,7 @@ bool LyXTabular::SetColumnPWidth(int cell, string const & width)
     column_info[j].p_width = width;
     if (flag) // do this only if there is a width
        SetAlignment(cell, LYX_ALIGN_LEFT);
-    for(int i = 0; i < rows_; ++i) {
+    for (int i = 0; i < rows_; ++i) {
        int c = GetCellNumber(i, j);
        flag = !GetPWidth(c).empty(); // because of multicolumns!
        GetCellInset(c)->SetAutoBreakRows(flag);
@@ -671,9 +658,9 @@ bool LyXTabular::SetMColumnPWidth(int cell, string const & width)
 }
 
 
-bool LyXTabular::SetAlignSpecial(int cell, string const & special, int what)
+bool LyXTabular::SetAlignSpecial(int cell, string const & special,
+                                LyXTabular::Feature what)
 {
-#warning Fix the "what" type. (Lgb)
     if (what == SET_SPECIAL_MULTI)
         cellinfo_of_cell(cell)->align_special = special;
     else
@@ -734,9 +721,8 @@ bool LyXTabular::SetRightLine(int cell, bool line, bool onlycolumn)
 }
 
 
-char LyXTabular::GetAlignment(int cell, bool onlycolumn) const
+LyXAlignment LyXTabular::GetAlignment(int cell, bool onlycolumn) const
 {
-#warning Fix return type. (Lgb)
     if (!onlycolumn && IsMultiColumn(cell))
        return cellinfo_of_cell(cell)->alignment;
     else
@@ -744,9 +730,9 @@ char LyXTabular::GetAlignment(int cell, bool onlycolumn) const
 }
 
 
-char LyXTabular::GetVAlignment(int cell, bool onlycolumn) const
+LyXTabular::VAlignment
+LyXTabular::GetVAlignment(int cell, bool onlycolumn) const
 {
-#warning Fix return type. (Lgb)
     if (!onlycolumn && IsMultiColumn(cell))
        return cellinfo_of_cell(cell)->valignment;
     else
@@ -890,7 +876,7 @@ void LyXTabular::calculate_width_of_tabular()
 int LyXTabular::row_of_cell(int cell) const
 {
     if (cell >= numberofcells)
-        return rows_-1;
+        return rows_ - 1;
     else if (cell < 0)
         return 0;
     return rowofcell[cell];
@@ -900,7 +886,7 @@ int LyXTabular::row_of_cell(int cell) const
 int LyXTabular::column_of_cell(int cell) const
 {
     if (cell >= numberofcells)
-        return columns_-1;
+        return columns_ - 1;
     else if (cell < 0)
         return 0;
     return columnofcell[cell];
@@ -912,168 +898,520 @@ int LyXTabular::right_column_of_cell(int cell) const
     int const row = row_of_cell(cell);
     int column = column_of_cell(cell);
     while (column < (columns_ - 1) &&
-          cell_info[row][column+1].multicolumn == LyXTabular::CELL_PART_OF_MULTICOLUMN)
+          cell_info[row][column + 1].multicolumn == LyXTabular::CELL_PART_OF_MULTICOLUMN)
        ++column;
     return column;
 }
 
 
-const string write_attribute(const string name, const int value)
+// Perfect case for a template... (Lgb)
+#if 1
+template<class T>
+string const write_attribute(string const & name, T const & t)
+{
+     string str = " " + name + "=\"" + tostr(t) + "\"";
+     return str;
+}
+
+template <>
+string const write_attribute(string const & name, bool const & b)
+{
+       return write_attribute(name, int(b));
+}
+
+#else
+
+string const write_attribute(string const & name, int value)
 {
     string str = " " + name + "=\"" + tostr(value) + "\"";
     return str;
 }
 
 
-const string write_attribute(string name, const string & value)
+string const write_attribute(string const & name, string const & value)
 {
     string str = " " + name + "=\"" + value + "\"";
     return str;
 }
 
 
-const string write_attribute(string name, const bool value)
+string const write_attribute(string const & name, bool value)
 {
-    string str = " " + name + "=\"" + tostr((int)value) + "\"";
+    string str = " " + name + "=\"" + tostr(static_cast<int>(value)) + "\"";
     return str;
 }
+#endif
+
+
+//  #if 0
+//  static inline
+//  string const type2string(LyXAlignment num)
+//  {
+//      switch(num) {
+//      case LYX_ALIGN_NONE:
+//     return "none";
+//      case LYX_ALIGN_BLOCK:
+//     return "block";
+//      case LYX_ALIGN_LEFT:
+//     return "left";
+//      case LYX_ALIGN_CENTER:
+//     return "center";
+//      case LYX_ALIGN_RIGHT:
+//     return "right";
+//      case LYX_ALIGN_LAYOUT:
+//     return "layout";
+//      case LYX_ALIGN_SPECIAL:
+//     return "special";
+//      }
+//      return string();
+//  }
+
+
+//  static inline
+//  string const type2string(LyXTabular::VAlignment num)
+//  {
+//      switch(num) {
+//      case LyXTabular::LYX_VALIGN_TOP:
+//     return "top";
+//      case LyXTabular::LYX_VALIGN_CENTER:
+//     return "center";
+//      case LyXTabular::LYX_VALIGN_BOTTOM:
+//     return "bottom";
+//      }
+//      return string();
+//  }
+
+
+//  static inline
+//  string const type2string(LyXTabular::BoxType num)
+//  {
+//      switch(num) {
+//      case LyXTabular::BOX_NONE:
+//     return "none";
+//      case LyXTabular::BOX_PARBOX:
+//     return "parbox";
+//      case LyXTabular::BOX_MINIPAGE:
+//     return "minipage";
+//      }
+//      return string();
+//  }
+
+//  static inline
+//  string const type2string(bool flag)
+//  {
+//      return (flag ? "true" : "false");
+//  }
+//  #else
+template<>
+inline
+string const tostr(LyXAlignment const & num)
+{
+    switch(num) {
+    case LYX_ALIGN_NONE:
+       return "none";
+    case LYX_ALIGN_BLOCK:
+       return "block";
+    case LYX_ALIGN_LEFT:
+       return "left";
+    case LYX_ALIGN_CENTER:
+       return "center";
+    case LYX_ALIGN_RIGHT:
+       return "right";
+    case LYX_ALIGN_LAYOUT:
+       return "layout";
+    case LYX_ALIGN_SPECIAL:
+       return "special";
+    }
+    return string();
+}
+
+
+template<>
+inline
+string const tostr(LyXTabular::VAlignment const & num)
+{
+    switch(num) {
+    case LyXTabular::LYX_VALIGN_TOP:
+       return "top";
+    case LyXTabular::LYX_VALIGN_CENTER:
+       return "center";
+    case LyXTabular::LYX_VALIGN_BOTTOM:
+       return "bottom";
+    }
+    return string();
+}
+
+
+template<>
+inline
+string const tostr(LyXTabular::BoxType const & num)
+{
+    switch(num) {
+    case LyXTabular::BOX_NONE:
+       return "none";
+    case LyXTabular::BOX_PARBOX:
+       return "parbox";
+    case LyXTabular::BOX_MINIPAGE:
+       return "minipage";
+    }
+    return string();
+}
+
+// We already have a function like this in lstring.h (Lgb)
+//string const type2string(bool flag)
+//{
+//    return (flag ? "true" : "false");
+//}
+
+
+//#endif
+
+
 
 
 void LyXTabular::Write(Buffer const * buf, ostream & os) const
 {
     // header line
-    os << "<LyXTabular" <<
-       write_attribute("version", 1) <<
-       write_attribute("rows", rows_) <<
-       write_attribute("columns", columns_) <<
-       ">\n";
+    os << "<lyxtabular"
+       << write_attribute("version", 2)
+       << write_attribute("rows", rows_)
+       << write_attribute("columns", columns_)
+       << ">\n";
     // global longtable options
-    os << "<Features" <<
-       write_attribute("rotate", rotate) <<
-       write_attribute("islongtable", is_long_tabular) <<
-       write_attribute("endhead", endhead) <<
-       write_attribute("endfirsthead", endfirsthead) <<
-       write_attribute("endfoot", endfoot) <<
-       write_attribute("endlastfoot", endlastfoot) <<
-       ">\n\n";
+    os << "<features"
+//#if 0
+//       << write_attribute("rotate", type2string(rotate))
+//       << write_attribute("islongtable", type2string(is_long_tabular))
+//#else
+       << write_attribute("rotate", tostr(rotate))
+       << write_attribute("islongtable", tostr(is_long_tabular))
+//#endif
+       << write_attribute("endhead", endhead)
+       << write_attribute("endfirsthead", endfirsthead)
+       << write_attribute("endfoot", endfoot)
+       << write_attribute("endlastfoot", endlastfoot)
+       << ">\n";
+    for (int j = 0; j < columns_; ++j) {
+       os << "<column"
+//#if 0
+//        << write_attribute("alignment", type2string(column_info[j].alignment))
+//        << write_attribute("valignment", type2string(column_info[j].valignment))
+//        << write_attribute("leftline", type2string(column_info[j].left_line))
+//        << write_attribute("rightline", type2string(column_info[j].right_line))
+//#else
+          << write_attribute("alignment", tostr(column_info[j].alignment))
+          << write_attribute("valignment", tostr(column_info[j].valignment))
+          << write_attribute("leftline", tostr(column_info[j].left_line))
+          << write_attribute("rightline", tostr(column_info[j].right_line))
+//#endif
+          << write_attribute("width",
+                             VSpace(column_info[j].p_width)
+                             .asLyXCommand())
+          << write_attribute("special", column_info[j].align_special)
+          << ">\n";
+    }
     for (int i = 0; i < rows_; ++i) {
-       os << "<Row" <<
-           write_attribute("topline", row_info[i].top_line) <<
-           write_attribute("bottomline", row_info[i].bottom_line) <<
-           write_attribute("newpage", row_info[i].newpage) <<
-           ">\n";
+       os << "<row"
+//#if 0
+//        << write_attribute("topline", type2string(row_info[i].top_line))
+//        << write_attribute("bottomline", type2string(row_info[i].bottom_line))
+//        << write_attribute("newpage", type2string(row_info[i].newpage))
+//#else
+          << write_attribute("topline", tostr(row_info[i].top_line))
+          << write_attribute("bottomline", tostr(row_info[i].bottom_line))
+          << write_attribute("newpage", tostr(row_info[i].newpage))
+//#endif
+          << ">\n";
        for (int j = 0; j < columns_; ++j) {
+#if 0
            if (!i) {
-               os << "<Column" <<
-                   write_attribute("alignment", column_info[j].alignment) <<
-                   write_attribute("valignment", column_info[j].valignment) <<
-                   write_attribute("leftline", column_info[j].left_line) <<
-                   write_attribute("rightline", column_info[j].right_line) <<
-                   write_attribute("width", VSpace(column_info[j].p_width).asLyXCommand()) <<
-                   write_attribute("special", column_info[j].align_special) <<
-                   ">\n";
+               os << "<column"
+//#if 0
+//                << write_attribute("alignment", type2string(column_info[j].alignment))
+//                << write_attribute("valignment", type2string(column_info[j].valignment))
+//                << write_attribute("leftline", type2string(column_info[j].left_line))
+//                << write_attribute("rightline", type2string(column_info[j].right_line))
+//#else
+                  << write_attribute("alignment", tostr(column_info[j].alignment))
+                  << write_attribute("valignment", tostr(column_info[j].valignment))
+                  << write_attribute("leftline", tostr(column_info[j].left_line))
+                  << write_attribute("rightline", tostr(column_info[j].right_line))
+
+//#endif
+                  << write_attribute("width",
+                                     VSpace(column_info[j].p_width)
+                                     .asLyXCommand())
+                  << write_attribute("special", column_info[j].align_special)
+                  << ">\n";
            } else {
-               os << "<Column>\n";
+               os << "<column>\n";
            }
-           os << "<Cell" <<
-               write_attribute("multicolumn", cell_info[i][j].multicolumn) <<
-               write_attribute("alignment", cell_info[i][j].alignment) <<
-               write_attribute("valignment", cell_info[i][j].valignment) <<
-               write_attribute("topline", cell_info[i][j].top_line) <<
-               write_attribute("bottomline", cell_info[i][j].bottom_line) <<
-               write_attribute("leftline", cell_info[i][j].left_line) <<
-               write_attribute("rightline", cell_info[i][j].right_line) <<
-               write_attribute("rotate", cell_info[i][j].rotate) <<
-               write_attribute("usebox", (int)cell_info[i][j].usebox) <<
-               write_attribute("width", cell_info[i][j].p_width) <<
-               write_attribute("special", cell_info[i][j].align_special) <<
-               ">\n";
+#endif
+           os << "<cell"
+              << write_attribute("multicolumn", cell_info[i][j].multicolumn)
+//#if 0
+//            << write_attribute("alignment", type2string(cell_info[i][j].alignment))
+//            << write_attribute("valignment", type2string(cell_info[i][j].valignment))
+//            << write_attribute("topline", type2string(cell_info[i][j].top_line))
+//            << write_attribute("bottomline", type2string(cell_info[i][j].bottom_line))
+//            << write_attribute("leftline", type2string(cell_info[i][j].left_line))
+//            << write_attribute("rightline", type2string(cell_info[i][j].right_line))
+//            << write_attribute("rotate", type2string(cell_info[i][j].rotate))
+//            << write_attribute("usebox", type2string(cell_info[i][j].usebox))
+//#else
+              << write_attribute("alignment", tostr(cell_info[i][j].alignment))
+              << write_attribute("valignment", tostr(cell_info[i][j].valignment))
+              << write_attribute("topline", tostr(cell_info[i][j].top_line))
+              << write_attribute("bottomline", tostr(cell_info[i][j].bottom_line))
+              << write_attribute("leftline", tostr(cell_info[i][j].left_line))
+              << write_attribute("rightline", tostr(cell_info[i][j].right_line))
+              << write_attribute("rotate", tostr(cell_info[i][j].rotate))
+              << write_attribute("usebox", tostr(cell_info[i][j].usebox))
+//#endif
+              << write_attribute("width", cell_info[i][j].p_width)
+              << write_attribute("special", cell_info[i][j].align_special)
+              << ">\n";
            os << "\\begin_inset ";
            cell_info[i][j].inset.Write(buf, os);
            os << "\n\\end_inset \n"
-              << "</Cell>\n"
-              << "</Column>\n";
+              << "</cell>\n";
+#if 0
+              << "</column>\n";
+#endif
        }
-       os << "</Row>\n";
+       os << "</row>\n";
     }
-    os << "</LyXTabular>\n";
+    os << "</lyxtabular>\n";
+}
+
+
+// I would have liked a fromstr template a lot better. (Lgb)
+
+static inline
+bool string2type(string const str, LyXAlignment & num)
+{
+    if (str == "none")
+       num = LYX_ALIGN_NONE;
+    else if (str == "block")
+       num = LYX_ALIGN_BLOCK;
+    else if (str == "left")
+       num = LYX_ALIGN_LEFT;
+    else if (str == "center")
+       num = LYX_ALIGN_CENTER;
+    else if (str == "right")
+       num = LYX_ALIGN_RIGHT;
+    else
+       return false;
+    return true;
+}
+
+
+static inline
+bool string2type(string const str, LyXTabular::VAlignment & num)
+{
+    if (str == "top")
+       num = LyXTabular::LYX_VALIGN_TOP;
+    else if (str == "center")
+       num = LyXTabular::LYX_VALIGN_CENTER;
+    else if (str == "bottom")
+       num = LyXTabular::LYX_VALIGN_BOTTOM;
+    else
+       return false;
+    return true;
+}
+
+
+static inline
+bool string2type(string const str, LyXTabular::BoxType & num)
+{
+    if (str == "none")
+       num = LyXTabular::BOX_NONE;
+    else if (str == "parbox")
+       num = LyXTabular::BOX_PARBOX;
+    else if (str == "minipage")
+       num = LyXTabular::BOX_MINIPAGE;
+    else
+       return false;
+    return true;
+}
+
+
+static inline
+bool string2type(string const str, bool & num)
+{
+    if (str == "true")
+       num = true;
+    else if (str == "false")
+       num = false;
+    else
+       return false;
+    return true;
 }
 
 
 static
-bool getTokenValue(string const str, const char * token, string & ret)
+bool getTokenValue(string const str, const char * token, string & ret)
 {
-    int pos = str.find(token);
-    char ch = str[pos+strlen(token)];
+    size_t token_length = strlen(token);
+    string::size_type pos = str.find(token);
 
-    if ((pos < 0) || (ch != '='))
+    if (pos == string::npos || pos+token_length+1 >= str.length()
+       || str[pos+token_length] != '=')
        return false;
     ret.erase();
-    pos += strlen(token)+1;
-    ch = str[pos];
+    pos += token_length + 1;
+    char ch = str[pos];
     if ((ch != '"') && (ch != '\'')) { // only read till next space
        ret += ch;
        ch = ' ';
     }
-    while((pos < int(str.length()-1)) && (str[++pos] != ch))
+    while((pos < str.length() - 1) && (str[++pos] != ch))
        ret += str[pos];
 
     return true;
 }
 
 
+//#define USE_OLD_READFORMAT
+
+//#ifndef USE_OLD_READFORMAT
 static
-bool getTokenValue(string const str, const char * token, int & num)
+bool getTokenValue(string const str, const char * token, int & num)
 {
-    int pos = str.find(token);
-    char ch = str[pos+strlen(token)];
-
-    if ((pos < 0) || (ch != '='))
+    string tmp;
+    if (!getTokenValue(str, token, tmp))
        return false;
-    string ret;
-    //ret.erase(); // why? (Lgb)
-    pos += strlen(token)+1;
-    ch = str[pos];
-    if ((ch != '"') && (ch != '\'')) { // only read till next space
-       if (!isdigit(ch))
-           return false;
-       ret += ch;
-    }
-    ++pos;
-    while((pos < int(str.length()-1)) && isdigit(str[pos]))
-       ret += str[pos++];
-
-    num = strToInt(ret);
+    num = strToInt(tmp);
     return true;
 }
 
 
 static
-bool getTokenValue(string const str, const char * token, bool & flag)
+bool getTokenValue(string const & str, const char * token, LyXAlignment & num)
 {
-    int pos = str.find(token);
-    char ch = str[pos+strlen(token)];
+    string tmp;
+    if (!getTokenValue(str, token, tmp))
+       return false;
+    return string2type(tmp, num);
+}
+
 
-    if ((pos < 0) || (ch != '='))
+static
+bool getTokenValue(string const & str, const char * token,
+                  LyXTabular::VAlignment & num)
+{
+    string tmp;
+    if (!getTokenValue(str, token, tmp))
        return false;
-    string ret;
-    //ret.erase(); // Why? (Lgb)
-    pos += strlen(token)+1;
-    ch = str[pos];
-    if ((ch != '"') && (ch != '\'')) { // only read till next space
-       if (!isdigit(ch))
-           return false;
-       ret += ch;
-    }
-    ++pos;
-    while((pos < int(str.length()-1)) && isdigit(str[pos]))
-       ret += str[pos++];
+    return string2type(tmp, num);
+}
 
-    flag = strToInt(ret);
-    return true;
+
+static
+bool getTokenValue(string const & str, const char * token,
+                  LyXTabular::BoxType & num)
+{
+    string tmp;
+    if (!getTokenValue(str, token, tmp))
+       return false;
+    return string2type(tmp, num);
 }
 
 
+static
+bool getTokenValue(string const & str, const char * token, bool & flag)
+{
+    string tmp;
+    if (!getTokenValue(str, token, tmp))
+       return false;
+    return string2type(tmp, flag);
+}    
+
+//#else
+
+//  static
+//  bool getTokenValue(string const & str, const char * token, int & num)
+//  {
+//      string::size_type pos = str.find(token);
+//      char ch = str[pos + strlen(token)];
+
+//      if ((pos == string::npos) || (ch != '='))
+//     return false;
+//      string ret;
+//      pos += strlen(token) + 1;
+//      ch = str[pos];
+//      if ((ch != '"') && (ch != '\'')) { // only read till next space
+//     if (!isdigit(ch))
+//         return false;
+//     ret += ch;
+//      }
+//      ++pos;
+//      while((pos < str.length() - 1) && isdigit(str[pos]))
+//     ret += str[pos++];
+
+//      num = strToInt(ret);
+//      return true;
+//  }
+
+
+//  static
+//  bool getTokenValue(string const & str, const char * token, LyXAlignment & num)
+//  {
+//      int tmp;
+//      bool const ret = getTokenValue(str, token, tmp);
+//      num = static_cast<LyXAlignment>(tmp);
+//      return ret;
+//  }
+
+
+//  static
+//  bool getTokenValue(string const & str, const char * token,
+//                LyXTabular::VAlignment & num)
+//  {
+//      int tmp;
+//      bool const ret = getTokenValue(str, token, tmp);
+//      num = static_cast<LyXTabular::VAlignment>(tmp);
+//      return ret;
+//  }
+
+
+//  static
+//  bool getTokenValue(string const & str, const char * token,
+//                LyXTabular::BoxType & num)
+//  {
+//      int tmp;
+//      bool ret = getTokenValue(str, token, tmp);
+//      num = static_cast<LyXTabular::BoxType>(tmp);
+//      return ret;
+//  }
+
+
+//  static
+//  bool getTokenValue(string const & str, const char * token, bool & flag)
+//  {
+//      string::size_type pos = str.find(token);
+//      char ch = str[pos + strlen(token)];
+
+//      if ((pos == string::npos) || (ch != '='))
+//     return false;
+//      string ret;
+//      pos += strlen(token) + 1;
+//      ch = str[pos];
+//      if ((ch != '"') && (ch != '\'')) { // only read till next space
+//     if (!isdigit(ch))
+//         return false;
+//     ret += ch;
+//      }
+//      ++pos;
+//      while((pos < str.length() - 1) && isdigit(str[pos]))
+//     ret += str[pos++];
+
+//      flag = strToInt(ret);
+//      return true;
+//  }
+
+//  #endif
+
 static inline
 void l_getline(istream & is, string & str)
 {
@@ -1083,67 +1421,100 @@ void l_getline(istream & is, string & str)
 }
 
 
+//#ifndef USE_OLD_READFORMAT
+
 void LyXTabular::Read(Buffer const * buf, LyXLex & lex)
 {
-    string line;
-    istream & is = lex.getStream();
+       string line;
+       istream & is = lex.getStream();
 
-    l_getline(is, line);
-    if (!prefixIs(line, "<LyXTabular ")) {
-       OldFormatRead(lex, line);
-       return;
-    }
+       l_getline(is, line);
+       if (!prefixIs(line, "<lyxtabular ")
+           && !prefixIs(line, "<LyXTabular ")) {
+               OldFormatRead(lex, line);
+               return;
+       }
 
-    int version;
+       int version;
+       if (!getTokenValue(line, "version", version))
+               return;
+       if (version == 1)
+               ReadOld(buf, is, lex, line);
+       else if (version == 2)
+               ReadNew(buf, is, lex, line);
+}
+
+
+//#if 0
+//void LyXTabular::ReadNew(Buffer const * buf, LyXLex & lex)
+//{
+//    string line;
+//    istream & is = lex.getStream();
+//
+//    l_getline(is, line);
+//    if (!prefixIs(line, "<LyXTabular ")) {
+//     OldFormatRead(lex, line);
+//     return;
+//    }
+//
+//    int version;
+//    if (!getTokenValue(line, "version", version))
+//     return;
+//#else
+void LyXTabular::ReadNew(Buffer const * buf, istream & is,
+                        LyXLex & lex, string const & l)
+{
+    string line(l);
+//#endif    
     int rows_arg;
-    int columns_arg;
-    if (!getTokenValue(line, "version", version))
-       return;
     if (!getTokenValue(line, "rows", rows_arg))
        return;
+    int columns_arg;
     if (!getTokenValue(line, "columns", columns_arg))
        return;
     Init(rows_arg, columns_arg);
     l_getline(is, line);
-    if (!prefixIs(line, "<Features ")) {
-       lyxerr << "Wrong tabular format (expected <Feture ...> got" <<
+    if (!prefixIs(line, "<features")) {
+       lyxerr << "Wrong tabular format (expected <features ...> got" <<
            line << ")" << endl;
        return;
     }
+    getTokenValue(line, "rotate", rotate);
     getTokenValue(line, "islongtable", is_long_tabular);
     getTokenValue(line, "endhead", endhead);
     getTokenValue(line, "endfirsthead", endfirsthead);
     getTokenValue(line, "endfoot", endfoot);
     getTokenValue(line, "endlastfoot", endlastfoot);
-    int i, j;
-    for(i = 0; i < rows_; ++i) {
+
+    for (int j = 0; j < columns_; ++j) {
+       l_getline(is,line);
+       if (!prefixIs(line,"<column")) {
+           lyxerr << "Wrong tabular format (expected <column ...> got" <<
+               line << ")" << endl;
+           return;
+       }
+       getTokenValue(line, "alignment", column_info[j].alignment);
+       getTokenValue(line, "valignment", column_info[j].valignment);
+       getTokenValue(line, "leftline", column_info[j].left_line);
+       getTokenValue(line, "rightline", column_info[j].right_line);
+       getTokenValue(line, "width", column_info[j].p_width);
+       getTokenValue(line, "special", column_info[j].align_special);
+    }
+
+    for (int i = 0; i < rows_; ++i) {
        l_getline(is, line);
-       if (!prefixIs(line, "<Row ")) {
-           lyxerr << "Wrong tabular format (expected <Row ...> got" <<
+       if (!prefixIs(line, "<row")) {
+           lyxerr << "Wrong tabular format (expected <row ...> got" <<
                line << ")" << endl;
            return;
        }
        getTokenValue(line, "topline", row_info[i].top_line);
        getTokenValue(line, "bottomline", row_info[i].bottom_line);
        getTokenValue(line, "newpage", row_info[i].newpage);
-       for (j = 0; j < columns_; ++j) {
-           l_getline(is,line);
-           if (!prefixIs(line,"<Column")) {
-               lyxerr << "Wrong tabular format (expected <Column ...> got" <<
-                   line << ")" << endl;
-               return;
-           }
-           if (!i) {
-               getTokenValue(line, "alignment", column_info[j].alignment);
-               getTokenValue(line, "valignment", column_info[j].valignment);
-               getTokenValue(line, "leftline", column_info[j].left_line);
-               getTokenValue(line, "rightline", column_info[j].right_line);
-               getTokenValue(line, "width", column_info[j].p_width);
-               getTokenValue(line, "special", column_info[j].align_special);
-           }
+       for (int j = 0; j < columns_; ++j) {
            l_getline(is, line);
-           if (!prefixIs(line, "<Cell")) {
-               lyxerr << "Wrong tabular format (expected <Cell ...> got" <<
+           if (!prefixIs(line, "<cell")) {
+               lyxerr << "Wrong tabular format (expected <cell ...> got" <<
                    line << ")" << endl;
                return;
            }
@@ -1163,31 +1534,132 @@ void LyXTabular::Read(Buffer const * buf, LyXLex & lex)
                cell_info[i][j].inset.Read(buf, lex);
                l_getline(is, line);
            }
-           if (line != "</Cell>") {
-               lyxerr << "Wrong tabular format (expected </Cell> got" <<
-                   line << ")" << endl;
-               return;
-           }
-           l_getline(is, line);
-           if (line != "</Column>") {
-               lyxerr << "Wrong tabular format (expected </Column> got" <<
+           if (line != "</cell>") {
+               lyxerr << "Wrong tabular format (expected </cell> got" <<
                    line << ")" << endl;
                return;
            }
        }
        l_getline(is, line);
-       if (line != "</Row>") {
-           lyxerr << "Wrong tabular format (expected </Row> got" <<
+       if (line != "</row>") {
+           lyxerr << "Wrong tabular format (expected </row> got" <<
                line << ")" << endl;
            return;
        }
     }
-    while (line != "</LyXTabular>") {
+    while (line != "</lyxtabular>") {
        l_getline(is, line);
     }
     set_row_column_number_info();
 }
 
+//  #else
+
+//  void LyXTabular::Read(Buffer const * buf, LyXLex & lex)
+//  {
+//      string line;
+//      istream & is = lex.getStream();
+
+//      l_getline(is, line);
+//      if (!prefixIs(line, "<LyXTabular ")) {
+//     OldFormatRead(lex, line);
+//     return;
+//      }
+
+//      int version;
+//      int rows_arg;
+//      int columns_arg;
+//      if (!getTokenValue(line, "version", version))
+//     return;
+//      if (!getTokenValue(line, "rows", rows_arg))
+//     return;
+//      if (!getTokenValue(line, "columns", columns_arg))
+//     return;
+//      Init(rows_arg, columns_arg);
+//      l_getline(is, line);
+//      if (!prefixIs(line, "<Features ")) {
+//     lyxerr << "Wrong tabular format (expected <Feture ...> got" <<
+//         line << ")" << endl;
+//     return;
+//      }
+//      getTokenValue(line, "islongtable", is_long_tabular);
+//      getTokenValue(line, "endhead", endhead);
+//      getTokenValue(line, "endfirsthead", endfirsthead);
+//      getTokenValue(line, "endfoot", endfoot);
+//      getTokenValue(line, "endlastfoot", endlastfoot);
+
+//      for (int i = 0; i < rows_; ++i) {
+//     l_getline(is, line);
+//     if (!prefixIs(line, "<Row ")) {
+//         lyxerr << "Wrong tabular format (expected <Row ...> got" <<
+//             line << ")" << endl;
+//         return;
+//     }
+//     getTokenValue(line, "topline", row_info[i].top_line);
+//     getTokenValue(line, "bottomline", row_info[i].bottom_line);
+//     getTokenValue(line, "newpage", row_info[i].newpage);
+//     for (int j = 0; j < columns_; ++j) {
+//         l_getline(is,line);
+//         if (!prefixIs(line,"<Column")) {
+//             lyxerr << "Wrong tabular format (expected <Column ...> got" <<
+//                 line << ")" << endl;
+//             return;
+//         }
+//         if (!i) {
+//             getTokenValue(line, "alignment", column_info[j].alignment);
+//             getTokenValue(line, "valignment", column_info[j].valignment);
+//             getTokenValue(line, "leftline", column_info[j].left_line);
+//             getTokenValue(line, "rightline", column_info[j].right_line);
+//             getTokenValue(line, "width", column_info[j].p_width);
+//             getTokenValue(line, "special", column_info[j].align_special);
+//         }
+//         l_getline(is, line);
+//         if (!prefixIs(line, "<Cell")) {
+//             lyxerr << "Wrong tabular format (expected <Cell ...> got" <<
+//                 line << ")" << endl;
+//             return;
+//         }
+//         getTokenValue(line, "multicolumn", cell_info[i][j].multicolumn);
+//         getTokenValue(line, "alignment", cell_info[i][j].alignment);
+//         getTokenValue(line, "valignment", cell_info[i][j].valignment);
+//         getTokenValue(line, "topline", cell_info[i][j].top_line);
+//         getTokenValue(line, "bottomline", cell_info[i][j].bottom_line);
+//         getTokenValue(line, "leftline", cell_info[i][j].left_line);
+//         getTokenValue(line, "rightline", cell_info[i][j].right_line);
+//         getTokenValue(line, "rotate", cell_info[i][j].rotate);
+//         getTokenValue(line, "usebox", cell_info[i][j].usebox);
+//         getTokenValue(line, "width", cell_info[i][j].p_width);
+//         getTokenValue(line, "special", cell_info[i][j].align_special);
+//         l_getline(is, line);
+//         if (prefixIs(line, "\\begin_inset")) {
+//             cell_info[i][j].inset.Read(buf, lex);
+//             l_getline(is, line);
+//         }
+//         if (line != "</Cell>") {
+//             lyxerr << "Wrong tabular format (expected </Cell> got" <<
+//                 line << ")" << endl;
+//             return;
+//         }
+//         l_getline(is, line);
+//         if (line != "</Column>") {
+//             lyxerr << "Wrong tabular format (expected </Column> got" <<
+//                 line << ")" << endl;
+//             return;
+//         }
+//     }
+//     l_getline(is, line);
+//     if (line != "</Row>") {
+//         lyxerr << "Wrong tabular format (expected </Row> got" <<
+//             line << ")" << endl;
+//         return;
+//     }
+//      }
+//      while (line != "</LyXTabular>") {
+//     l_getline(is, line);
+//      }
+//      set_row_column_number_info();
+//  }
+//  #endif
 
 void LyXTabular::OldFormatRead(LyXLex & lex, string const & fl)
 {
@@ -1204,7 +1676,6 @@ void LyXTabular::OldFormatRead(LyXLex & lex, string const & fl)
     int e = 0;
     int f = 0;
     int g = 0;
-    int h = 0;
        
     istream & is = lex.getStream();
     string s(fl);
@@ -1251,12 +1722,12 @@ void LyXTabular::OldFormatRead(LyXLex & lex, string const & fl)
        cont_row_info = vector<int>(rows_arg);
        SetLongTabular(is_long_tabular_arg);
        SetRotateTabular(rotate_arg);
-       endhead = a;
-       endfirsthead = b;
-       endfoot = c;
-       endlastfoot = d;
+       endhead = a + 1;
+       endfirsthead = b + 1;
+       endfoot = c + 1;
+       endlastfoot = d + 1;
        for (i = 0; i < rows_; ++i) {
-           a = b = c = d = e = f = g = h = 0;
+           a = b = c = d = e = f = g = 0;
            is >> a >> b >> c >> d;
            row_info[i].top_line = a;
            row_info[i].bottom_line = b;
@@ -1267,12 +1738,22 @@ void LyXTabular::OldFormatRead(LyXLex & lex, string const & fl)
            string s1;
            string s2;
            is >> a >> b >> c;
+#if 1
            char ch; // skip '"'
            is >> ch;
+#else
+           // ignore is buggy but we will use it later (Lgb)
+           is.ignore(); // skip '"'
+#endif    
            getline(is, s1, '"');
+#if 1
            is >> ch; // skip '"'
+#else
+           // ignore is buggy but we will use it later (Lgb)
+           is.ignore(); // skip '"'
+#endif
            getline(is, s2, '"');
-           column_info[i].alignment = static_cast<char>(a);
+           column_info[i].alignment = static_cast<LyXAlignment>(a);
            column_info[i].left_line = b;
            column_info[i].right_line = c;
            column_info[i].p_width = s1;
@@ -1283,23 +1764,35 @@ void LyXTabular::OldFormatRead(LyXLex & lex, string const & fl)
                string s1;
                string s2;
                is >> a >> b >> c >> d >> e >> f >> g;
+#if 1
                char ch;
                is >> ch; // skip '"'
+#else
+               // ignore is buggy but we will use it later (Lgb)
+               is.ignore(); // skip '"'
+#endif
                getline(is, s1, '"');
+#if 1
                is >> ch; // skip '"'
+#else
+               // ignore is buggy but we will use it later (Lgb)
+               is.ignore(); // skip '"'
+#endif
                getline(is, s2, '"');
                cell_info[i][j].multicolumn = static_cast<char>(a);
-               cell_info[i][j].alignment = static_cast<char>(b);
+               cell_info[i][j].alignment = static_cast<LyXAlignment>(b);
                cell_info[i][j].top_line = static_cast<char>(c);
                cell_info[i][j].bottom_line = static_cast<char>(d);
+               cell_info[i][j].left_line = column_info[j].left_line;
+               cell_info[i][j].right_line = column_info[j].right_line;
                cell_info[i][j].rotate = static_cast<bool>(f);
-               cell_info[i][j].usebox = static_cast<bool>(g);
+               cell_info[i][j].usebox = static_cast<BoxType>(g);
                cell_info[i][j].align_special = s1;
                cell_info[i][j].p_width = s2;
            }
        }
     }
-    set_row_column_number_info();
+    set_row_column_number_info(true);
 
     LyXParagraph * par = new LyXParagraph;
     LyXParagraph * return_par = 0;
@@ -1310,7 +1803,8 @@ void LyXTabular::OldFormatRead(LyXLex & lex, string const & fl)
     string tmptok;
     int pos = 0;
     char depth = 0;
-    LyXFont font(LyXFont::ALL_SANE);
+    LyXFont font(LyXFont::ALL_INHERIT);
+    font.setLanguage(owner_->BufferOwner()->GetLanguage());
 
     while (lex.IsOK()) {
         lex.nextToken();
@@ -1351,7 +1845,7 @@ void LyXTabular::OldFormatRead(LyXLex & lex, string const & fl)
     InsetText * inset = GetCellInset(cell);
     int row;
 
-    for(int i = 0; i < par->Last(); ++i) {
+    for (int i = 0; i < par->Last(); ++i) {
        if (par->IsNewline(i)) {
            ++cell;
            if (cell > GetNumberOfCells()) {
@@ -1379,7 +1873,7 @@ void LyXTabular::OldFormatRead(LyXLex & lex, string const & fl)
                par->InsertChar(i, ' ');
            }
        }
-       par->CopyIntoMinibuffer(current_view->buffer()->params, i);
+       par->CopyIntoMinibuffer(*owner_->BufferOwner(), i);
        inset->par->InsertFromMinibuffer(inset->par->Last());
     }
     delete par;
@@ -1551,7 +2045,7 @@ int LyXTabular::DocBookEndOfCell(ostream & os, int cell, int & depth) const
 bool LyXTabular::IsMultiColumn(int cell, bool real) const
 {
     return ((!real || (column_of_cell(cell) != right_column_of_cell(cell))) &&
-       (cellinfo_of_cell(cell)->multicolumn !=LyXTabular::CELL_NORMAL));
+       (cellinfo_of_cell(cell)->multicolumn != LyXTabular::CELL_NORMAL));
 }
 
 
@@ -1615,9 +2109,8 @@ int LyXTabular::UnsetMultiColumn(int cell)
 }
 
 
-void LyXTabular::SetLongTabular(int what)
+void LyXTabular::SetLongTabular(bool what)
 {
-#warning Should what be bool? (Lgb)
     is_long_tabular = what;
 }
 
@@ -1731,9 +2224,8 @@ void LyXTabular::SetUsebox(int cell, BoxType type)
 }
 
 
-int LyXTabular::GetUsebox(int cell) const
+LyXTabular::BoxType LyXTabular::GetUsebox(int cell) const
 {
-#warning should the return type change? (Lgb)
     if (column_info[column_of_cell(cell)].p_width.empty() &&
         !(IsMultiColumn(cell) && !cellinfo_of_cell(cell)->p_width.empty()))
         return BOX_NONE;
@@ -1867,7 +2359,7 @@ int LyXTabular::GetHeightOfTabular() const
 {
     int height = 0;
 
-    for(int row = 0; row < rows_; ++row)
+    for (int row = 0; row < rows_; ++row)
         height += GetAscentOfRow(row) + GetDescentOfRow(row) +
            GetAdditionalHeight(GetCellNumber(row, 0));
     return height;
@@ -1878,13 +2370,15 @@ bool LyXTabular::IsPartOfMultiColumn(int row, int column) const
 {
     if ((row >= rows_) || (column >= columns_))
         return false;
-    return (cell_info[row][column].multicolumn==CELL_PART_OF_MULTICOLUMN);
+    return (cell_info[row][column].multicolumn == CELL_PART_OF_MULTICOLUMN);
 }
 
 
 int LyXTabular::TeXTopHLine(ostream & os, int row) const
 {
-#warning should this return a bool? (Lgb)
+    if ((row < 0) || (row >= rows_))
+       return 0;
+
     int const fcell = GetFirstCellInRow(row);
     int const n = NumberOfCellsInRow(fcell) + fcell;
     int tmp = 0;
@@ -1895,7 +2389,7 @@ int LyXTabular::TeXTopHLine(ostream & os, int row) const
     }
     if (tmp == (n - fcell)){
        os << "\\hline ";
-    } else {
+    } else if (tmp) {
        for (int i = fcell; i < n; ++i) {
            if (TopLine(i)) {
                os << "\\cline{"
@@ -1905,18 +2399,19 @@ int LyXTabular::TeXTopHLine(ostream & os, int row) const
                   << "} ";
            }
        }
+    } else {
+       return 0;
     }
-    if (tmp) {
-       os << endl;
-       return 1;
-    }
-    return 0;
+    os << "\n";
+    return 1;
 }
 
 
 int LyXTabular::TeXBottomHLine(ostream & os, int row) const
 {
-#warning should this return a bool? (Lgb)
+    if ((row < 0) || (row >= rows_))
+       return 0;
+
     int const fcell = GetFirstCellInRow(row);
     int const n = NumberOfCellsInRow(fcell) + fcell;
     int tmp = 0;
@@ -1927,7 +2422,7 @@ int LyXTabular::TeXBottomHLine(ostream & os, int row) const
     }
     if (tmp == (n-fcell)){
        os << "\\hline";
-    } else {
+    } else if (tmp) {
        for (int i = fcell; i < n; ++i) {
            if (BottomLine(i)) {
                os << "\\cline{"
@@ -1937,12 +2432,11 @@ int LyXTabular::TeXBottomHLine(ostream & os, int row) const
                   << "} ";
            }
        }
+    } else {
+       return 0;
     }
-    if (tmp) {
-       os << endl;
-       return 1;
-    }
-    return 0;
+    os << "\n";
+    return 1;
 }
 
 
@@ -1951,18 +2445,18 @@ int LyXTabular::TeXCellPreamble(ostream & os, int cell) const
     int ret = 0;
 
     if (GetRotateCell(cell)) {
-       os << "\\begin{sideways}" << endl;
+       os << "\\begin{sideways}\n";
        ++ret;
     }
     if (IsMultiColumn(cell)) {
        os << "\\multicolumn{" << cells_in_multicolumn(cell) << "}{";
-       if (!cellinfo_of_cell(cell+1)->align_special.empty()) {
-           os << cellinfo_of_cell(cell+1)->align_special << "}{";
+       if (!cellinfo_of_cell(cell)->align_special.empty()) {
+           os << cellinfo_of_cell(cell)->align_special << "}{";
        } else {
            if (LeftLine(cell))
                os << '|';
            if (!GetPWidth(cell).empty()) {
-               switch(GetVAlignment(cell)) {
+               switch (GetVAlignment(cell)) {
                case LYX_VALIGN_TOP:
                    os << "p";
                    break;
@@ -1997,7 +2491,7 @@ int LyXTabular::TeXCellPreamble(ostream & os, int cell) const
     }
     if (GetUsebox(cell) == BOX_PARBOX) {
        os << "\\parbox[";
-       switch(GetVAlignment(cell)) {
+       switch (GetVAlignment(cell)) {
        case LYX_VALIGN_TOP:
            os << "t";
            break;
@@ -2011,7 +2505,7 @@ int LyXTabular::TeXCellPreamble(ostream & os, int cell) const
        os << "]{" << GetPWidth(cell) << "}{";
     } else if (GetUsebox(cell) == BOX_MINIPAGE) {
        os << "\\begin{minipage}[";
-       switch(GetVAlignment(cell)) {
+       switch (GetVAlignment(cell)) {
        case LYX_VALIGN_TOP:
            os << "t";
            break;
@@ -2062,7 +2556,7 @@ int LyXTabular::Latex(Buffer const * buf,
     //+---------------------------------------------------------------------
 
     if (rotate) {
-       os << "\\begin{sideways}" << endl;
+       os << "\\begin{sideways}\n";
        ++ret;
     }
     if (is_long_tabular)
@@ -2075,7 +2569,7 @@ int LyXTabular::Latex(Buffer const * buf,
        if (!column_info[i].align_special.empty()) {
            os << column_info[i].align_special;
        } else if (!column_info[i].p_width.empty()) {
-           switch(column_info[i].valignment) {
+           switch (column_info[i].valignment) {
            case LYX_VALIGN_TOP:
                os << "p";
                break;
@@ -2105,17 +2599,17 @@ int LyXTabular::Latex(Buffer const * buf,
        if (column_info[i].right_line)
            os << '|';
     }
-    os << "}" << endl;
+    os << "}\n";
     ++ret;
 
     //+---------------------------------------------------------------------
     //+                      the single row and columns (cells)            +
     //+---------------------------------------------------------------------
 
-    int bret;
-    for(int i = 0; i < rows_; ++i) {
+    //int bret;
+    for (int i = 0; i < rows_; ++i) {
        ret += TeXTopHLine(os, i);
-       bret = ret;
+       int bret = ret;
        if (IsLongTabular()) {
            if ((endhead < 0) && (i == (abs(endhead)-1))) {
                os << "\\endhead\n";
@@ -2135,23 +2629,31 @@ int LyXTabular::Latex(Buffer const * buf,
            }
        }
        if (ret > bret) {
-           if (i > 0)
-               ret += TeXBottomHLine(os, i-1);
+           ret += TeXBottomHLine(os, i-1);
            ret += TeXTopHLine(os, i);
        }
-       for(int j = 0; j < columns_; ++j) {
+       for (int j = 0; j < columns_; ++j) {
            if (IsPartOfMultiColumn(i,j))
                continue;
            ret += TeXCellPreamble(os, cell);
-           ret += GetCellInset(cell)->Latex(buf, os, fragile, fp);
+           InsetText * inset = GetCellInset(cell);
+
+           bool rtl = inset->par->isRightToLeftPar(buf->params) &&
+                   inset->par->Last() > 0 && GetPWidth(cell).empty();
+           if (rtl)
+               os << "\\R{";
+           ret += inset->Latex(buf, os, fragile, fp);
+           if (rtl)
+               os << "}";
+
            ret += TeXCellPostamble(os, cell);
            if (!IsLastCellInRow(cell)) { // not last cell in row
-               os << "&" << endl;
+               os << "&\n";
                ++ret;
            }
            ++cell;
        }
-       os << "\\\\" << endl;
+       os << "\\\\\n";
        ret += TeXBottomHLine(os, i);
        bret = ret;
        if (IsLongTabular()) {
@@ -2171,8 +2673,8 @@ int LyXTabular::Latex(Buffer const * buf,
                os << "\\endlastfoot\n";
                ++ret;
            }
-           if (ret > bret)
-               ret += TeXBottomHLine(os, i);
+//         if (ret > bret)
+//             ret += TeXBottomHLine(os, i);
            if (row_info[i].newpage) {
                os << "\\newpage\n";
                ++ret;
@@ -2197,19 +2699,318 @@ int LyXTabular::Latex(Buffer const * buf,
 }
 
 
+int LyXTabular::DocBook(Buffer const * buf, ostream & os) const
+{
+    int ret = 0;
+
+    //+---------------------------------------------------------------------
+    //+                      first the opening preamble                    +
+    //+---------------------------------------------------------------------
+
+    os << "<tgroup cols=\"" << columns_
+       << "\" colsep=\"1\" rowsep=\"1\">\n";
+    
+    for (int i = 0; i < columns_; ++i) {
+        os << "<colspec colname=\"col" << i << "\" align=\"";
+       switch (column_info[i].alignment) {
+       case LYX_ALIGN_LEFT:
+           os << "left";
+           break;
+       case LYX_ALIGN_RIGHT:
+           os << "right";
+           break;
+       default:
+           os << "center";
+           break;
+       }
+       os << "\"/>\n";
+       ++ret;
+    }
+
+    //+---------------------------------------------------------------------
+    //+                      the single row and columns (cells)            +
+    //+---------------------------------------------------------------------
+
+    int cell = 0;
+    os << "<tbody>\n";
+    for (int i = 0; i < rows_; ++i) {
+        os << "<row>\n";
+       for (int j = 0; j < columns_; ++j) {
+           if (IsPartOfMultiColumn(i, j))
+               continue;
+           
+           os << "<entry align=\"";
+           switch (GetAlignment(cell)) {
+           case LYX_ALIGN_LEFT:
+               os << "left";
+               break;
+           case LYX_ALIGN_RIGHT:
+               os << "right";
+               break;
+           default:
+               os << "center";
+               break;
+           }
+           
+           os << "\" valign=\"";
+           switch (GetVAlignment(cell)) {
+           case LYX_VALIGN_TOP:
+               os << "top";
+               break;
+           case LYX_VALIGN_BOTTOM:
+               os << "bottom";
+               break;
+           case LYX_VALIGN_CENTER:
+               os << "middle";
+           }
+           os << "\"";
+           
+           if (IsMultiColumn(cell)) {
+               os << " namest=\"col" << j << "\" ";
+               os << "nameend=\"col" << j + cells_in_multicolumn(cell) - 1<< "\"";
+           }
+           
+           os << ">";
+           ret += GetCellInset(cell)->DocBook(buf, os);
+           os << "</entry>";
+           ++cell;
+       }
+       os << "</row>\n";
+    }
+    os << "</tbody>\n";
+    //+---------------------------------------------------------------------
+    //+                      the closing of the tabular                    +
+    //+---------------------------------------------------------------------
+
+    os << "</tgroup>";
+    ++ret;
+
+    return ret;
+}
+
+
+static
+inline
+void print_n_chars(ostream & os, unsigned char ch, int n)
+{
+       os << string(n, ch);
+}
+
+
+int LyXTabular::AsciiTopHLine(ostream & os, int row,
+                             vector<unsigned int> const & clen) const
+{
+    int const fcell = GetFirstCellInRow(row);
+    int const n = NumberOfCellsInRow(fcell) + fcell;
+    int tmp = 0;
+
+    for (int i = fcell; i < n; ++i) {
+       if (TopLine(i)) {
+           ++tmp;
+           break;
+       }
+    }
+    if (!tmp)
+       return 0;
+
+    unsigned char ch;
+    for (int i = fcell; i < n; ++i) {
+       if (TopLine(i)) {
+           if (LeftLine(i))
+               os << "+-";
+           else
+               os << "--";
+           ch = '-';
+       } else {
+           os << "  ";
+           ch = ' ';
+       }
+       int column = column_of_cell(i);
+       int len = clen[column];
+       while(IsPartOfMultiColumn(row, ++column))
+           len += clen[column] + 4;
+       print_n_chars(os, ch, len);
+       if (TopLine(i)) {
+           if (RightLine(i))
+               os << "-+";
+           else
+               os << "--";
+       } else {
+           os << "  ";
+       }
+    }
+    os << endl;
+    return 1;
+}
+
+
+int LyXTabular::AsciiBottomHLine(ostream & os, int row,
+                                vector<unsigned int> const & clen) const
+{
+    int const fcell = GetFirstCellInRow(row);
+    int const n = NumberOfCellsInRow(fcell) + fcell;
+    int tmp = 0;
+
+    for (int i = fcell; i < n; ++i) {
+       if (BottomLine(i)) {
+           ++tmp;
+           break;
+       }
+    }
+    if (!tmp)
+       return 0;
+
+    unsigned char ch;
+    for (int i = fcell; i < n; ++i) {
+       if (BottomLine(i)) {
+           if (LeftLine(i))
+               os << "+-";
+           else
+               os << "--";
+           ch = '-';
+       } else {
+           os << "  ";
+           ch = ' ';
+       }
+       int column = column_of_cell(i);
+       int len = clen[column];
+       while(IsPartOfMultiColumn(row, ++column))
+           len += clen[column] + 4;
+       print_n_chars(os, ch, len);
+       if (BottomLine(i)) {
+           if (RightLine(i))
+               os << "-+";
+           else
+               os << "--";
+       } else {
+           os << "  ";
+       }
+    }
+    os << endl;
+    return 1;
+}
+
+
+int LyXTabular::AsciiPrintCell(Buffer const * buf, ostream & os,
+                              int cell, int row, int column,
+                              vector<unsigned int> const & clen) const
+{
+    ostringstream sstr;
+    int ret = GetCellInset(cell)->Ascii(buf, sstr, 0);
+
+    if (LeftLine(cell))
+       os << "| ";
+    else
+       os << "  ";
+
+    unsigned int len1 = sstr.str().length();
+    unsigned int len2 = clen[column];
+    while(IsPartOfMultiColumn(row, ++column))
+       len2 += clen[column] + 4;
+    len2 -= len1;
+
+    switch (GetAlignment(cell)) {
+    default:
+    case LYX_ALIGN_LEFT:
+       len1 = 0;
+       break;
+    case LYX_ALIGN_RIGHT:
+       len1 = len2;
+       len2 = 0;
+       break;
+    case LYX_ALIGN_CENTER:
+       len1 = len2 / 2;
+       len2 -= len1;
+       break;
+    }
+
+    for (unsigned int i = 0; i < len1; ++i)
+       os << " ";
+    os << sstr.str();
+    for (unsigned int i = 0; i < len2; ++i)
+       os << " ";
+    if (RightLine(cell))
+       os << " |";
+    else
+       os << "  ";
+
+    return ret * 0; // eh? (Lgb)
+}
+
+
+int LyXTabular::Ascii(Buffer const * buf, ostream & os) const
+{
+    int ret = 0;
+
+    //+---------------------------------------------------------------------
+    //+           first calculate the width of the single columns          +
+    //+---------------------------------------------------------------------
+    vector<unsigned int> clen(columns_);
+
+    // first all non (real) multicolumn cells!
+    for (int j = 0; j < columns_; ++j) {
+       clen[j] = 0;
+       for (int i = 0; i < rows_; ++i) {
+           int cell = GetCellNumber(i, j);
+           if (IsMultiColumn(cell, true))
+               continue;
+           ostringstream sstr;
+           GetCellInset(cell)->Ascii(buf, sstr, 0);
+           if (clen[j] < sstr.str().length())
+               clen[j] = sstr.str().length();
+       }
+    }
+    // then all (real) multicolumn cells!
+    for (int j = 0; j < columns_; ++j) {
+       for (int i = 0; i < rows_; ++i) {
+           int cell = GetCellNumber(i, j);
+           if (!IsMultiColumn(cell, true) || IsPartOfMultiColumn(i, j))
+               continue;
+           ostringstream sstr;
+           GetCellInset(cell)->Ascii(buf, sstr, 0);
+           int len = int(sstr.str().length());
+           int const n = cells_in_multicolumn(cell);
+           for (int k = j; (len > 0) && (k < (j + n - 1)); ++k)
+               len -= clen[k];
+           if (len > int(clen[j + n - 1]))
+               clen[j + n - 1] = len;
+       }
+    }
+    int cell = 0;
+    for (int i = 0; i < rows_; ++i) {
+       AsciiTopHLine(os, i, clen);
+       for (int j = 0; j < columns_; ++j) {
+           if (IsPartOfMultiColumn(i,j))
+               continue;
+           ret += AsciiPrintCell(buf, os, cell, i, j, clen);
+           ++cell;
+       }
+       os << endl;
+       AsciiBottomHLine(os, i, clen);
+    }
+    return ret;
+}
+
+
 InsetText * LyXTabular::GetCellInset(int cell) const
 {
     return & cell_info[row_of_cell(cell)][column_of_cell(cell)].inset;
 }
 
 
+InsetText * LyXTabular::GetCellInset(int row, int column) const
+{
+    return GetCellInset(GetCellNumber(row, column));
+}
+
+
 void LyXTabular::Validate(LaTeXFeatures & features) const
 {
     if (IsLongTabular())
         features.longtable = true;
     if (NeedRotating())
        features.rotating = true;
-    for(int cell = 0; cell < numberofcells; ++cell) {
+    for (int cell = 0; cell < numberofcells; ++cell) {
        if (GetVAlignment(cell) != LYX_VALIGN_TOP)
            features.array = true;
        GetCellInset(cell)->Validate(features);
@@ -2217,15 +3018,15 @@ void LyXTabular::Validate(LaTeXFeatures & features) const
 }
 
 
-bool LyXTabular::UseParbox(int cell) const
+LyXTabular::BoxType LyXTabular::UseParbox(int cell) const
 {
     LyXParagraph * par = GetCellInset(cell)->par;
 
-    for(; par; par = par->next) {
-       for(int i = 0; i < par->Last(); ++i) {
+    for (; par; par = par->next) {
+       for (int i = 0; i < par->Last(); ++i) {
            if (par->GetChar(i) == LyXParagraph::META_NEWLINE)
-               return true;
+               return BOX_PARBOX;
        }
     }
-    return false;
+    return BOX_NONE;
 }