use more explicit on constructors use the pimpl idom to reduce size with about 500k

[lyx.git] / src / support / lstrings.C

diff --git a/src/support/lstrings.C b/src/support/lstrings.C
index b811d4c9a61a3e793cdfc6f401875a14510fae22..efc8df4165953f2767c41a304fd70f3031589673 100644 (file)
--- a/src/support/lstrings.C
+++ b/src/support/lstrings.C
@@ -2,11 +2,7 @@
 
 #include <algorithm>
 
-#ifdef __GLIBCPP__
-#include <ctype.h>
-#else
 #include <cctype>
-#endif
 #include <cstdlib>
 
 #include "LString.h"
@@ -15,9 +11,13 @@
 
 using std::count;
 using std::transform;
+#ifndef __GLIBCPP__
+// The new glibstdc++-v3 has not worked out all the quirks regarding cctype
+// yet. So currently it failes if the to using lines below are stated.
 using std::tolower;
 using std::toupper;
-
+#endif
+       
 int compare_no_case(string const & s, string const & s2)
 {
        // ANSI C
@@ -98,15 +98,15 @@ int  strToInt(string const & str)
 string lowercase(string const & a)
 {
        string tmp(a);
-#ifdef __GLIBCPP__
+//#ifdef __GLIBCPP__
        string::iterator result = tmp.begin();
        for (string::iterator first = tmp.begin();
             first != tmp.end(); ++first, ++result) {
                *result = tolower(*first);
        }
-#else
-       transform(tmp.begin(), tmp.end(), tmp.begin(), tolower);
-#endif
+//#else
+//     transform(tmp.begin(), tmp.end(), tmp.begin(), tolower);
+//#endif
        return tmp;
 }
 
@@ -114,15 +114,15 @@ string lowercase(string const & a)
 string uppercase(string const & a)
 {
        string tmp(a);
-#ifdef __GLIBCPP__
+//#ifdef __GLIBCPP__
        string::iterator result = tmp.begin();
        for (string::iterator first = tmp.begin();
             first != tmp.end(); ++first, ++result) {
                *result = toupper(*first);
        }
-#else
-       transform(tmp.begin(), tmp.end(), tmp.begin(), toupper);
-#endif
+//#else
+//     transform(tmp.begin(), tmp.end(), tmp.begin(), toupper);
+//#endif
        return tmp;
 }