split LyXText::rowlist_ into individual Paragraph::rows_ chunks

[lyx.git] / src / support / forkedcontr.C

diff --git a/src/support/forkedcontr.C b/src/support/forkedcontr.C
index 0da94ef5d04fb3c2e10588e5111bdc41a1b06da6..c11daa5669c24d82cee2ab9d88c22f8ef7f596d9 100644 (file)
--- a/src/support/forkedcontr.C
+++ b/src/support/forkedcontr.C
@@ -14,10 +14,6 @@
 
 #include <config.h>
 
-#ifdef __GNUG__
-#pragma implementation
-#endif
-
 #include "forkedcontr.h"
 #include "forkedcall.h"
 #include "lyxfunctional.h"
@@ -40,6 +36,9 @@ using std::find_if;
 using std::strerror;
 #endif
 
+namespace lyx {
+namespace support {
+
 // Ensure, that only one controller exists inside process
 ForkedcallsController & ForkedcallsController::get()
 {
@@ -71,14 +70,12 @@ ForkedcallsController::~ForkedcallsController()
 }
 
 
-// Add child process information to the list of controlled processes
-void ForkedcallsController::addCall(Forkedcall const &newcall)
+void ForkedcallsController::addCall(ForkedProcess const & newcall)
 {
        if (!timeout_->running())
                timeout_->start();
 
-       Forkedcall * call = new Forkedcall(newcall);
-       forkedCalls.push_back(call);
+       forkedCalls.push_back(newcall.clone());
        childrenChanged();
 }
 
@@ -89,9 +86,10 @@ void ForkedcallsController::timer()
 {
        ListType::size_type start_size = forkedCalls.size();
 
-       for (ListType::iterator it = forkedCalls.begin();
-            it != forkedCalls.end(); ++it) {
-               Forkedcall * actCall = *it;
+       ListType::iterator it  = forkedCalls.begin();
+       ListType::iterator end = forkedCalls.end();
+       while (it != end) {
+               ForkedProcess * actCall = *it;
 
                pid_t pid = actCall->pid();
                int stat_loc;
@@ -108,7 +106,6 @@ void ForkedcallsController::timer()
 
                } else if (waitrpid == 0) {
                        // Still running. Move on to the next child.
-                       continue;
 
                } else if (WIFEXITED(stat_loc)) {
                        // Ok, the return value goes into retval.
@@ -136,19 +133,21 @@ void ForkedcallsController::timer()
                }
 
                if (remove_it) {
-                       // Emit signal and remove the item from the list
+                       forkedCalls.erase(it);
+
                        actCall->emitSignal();
                        delete actCall;
-                       // erase returns the next iterator, so decrement it
-                       // to continue the loop.
-                       ListType::iterator prev = it;
-                       --prev;
-                       forkedCalls.erase(it);
-                       it = prev;
+
+                       /* start all over: emiting the signal can result
+                        * in changing the list (Ab)
+                        */
+                       it = forkedCalls.begin();
+               } else {
+                       ++it;
                }
        }
 
-       if (!forkedCalls.empty()) {
+       if (!forkedCalls.empty() && !timeout_->running()) {
                timeout_->start();
        }
 
@@ -210,3 +209,6 @@ void ForkedcallsController::kill(pid_t pid, int tolerance)
                timeout_->stop();
        }
 }
+
+} // namespace support
+} // namespace lyx