]> git.lyx.org Git - lyx.git/blobdiff - src/support/Systemcall.cpp
InsetTabular.cpp: fix #6585 also for wrapped floats - thanks Vincent
[lyx.git] / src / support / Systemcall.cpp
index 5ba04cce4af157f16eea40acecaff5992b13e606..dda23d66bce1d83369ca2d168a30bfbfda04fbf4 100644 (file)
@@ -61,6 +61,10 @@ public:
        void appendMessage(QString const &) {}
        void appendError(QString const &) {}
        void clearMessages() {}
+       void lyxerrFlush() {}
+
+       void lyxerrConnect() {}
+       void lyxerrDisconnect() {}
 
        void warning(QString const &, QString const &) {}
        void toggleWarning(QString const &, QString const &, QString const &) {}
@@ -237,24 +241,24 @@ int Systemcall::startscript(Starttype how, string const & what, bool process_eve
 }
 
 
-SystemcallPrivate::SystemcallPrivate(const std::string& of) : 
-                                proc_(new QProcess), outindex_(0), errindex_(0),
-                                outfile(of), showout_(false), showerr_(false), process_events(false)
+SystemcallPrivate::SystemcallPrivate(const std::string& of) :
+                                process_(new QProcess), 
+                                out_index_(0),
+                                err_index_(0),
+                                out_file_(of), 
+                                process_events_(false)
 {
-       if (!outfile.empty()) {
+       if (!out_file_.empty()) {
                // Check whether we have to simply throw away the output.
-               if (outfile != os::nulldev())
-                       proc_->setStandardOutputFile(toqstr(outfile));
-       } else if (os::is_terminal(os::STDOUT))
-               setShowOut(true);
-       if (os::is_terminal(os::STDERR))
-               setShowErr(true);
-
-       connect(proc_, SIGNAL(readyReadStandardOutput()), SLOT(stdOut()));
-       connect(proc_, SIGNAL(readyReadStandardError()), SLOT(stdErr()));
-       connect(proc_, SIGNAL(error(QProcess::ProcessError)), SLOT(processError(QProcess::ProcessError)));
-       connect(proc_, SIGNAL(started()), this, SLOT(processStarted()));
-       connect(proc_, SIGNAL(finished(int, QProcess::ExitStatus)), SLOT(processFinished(int, QProcess::ExitStatus)));
+               if (out_file_ != os::nulldev())
+                       process_->setStandardOutputFile(toqstr(out_file_));
+       }
+
+       connect(process_, SIGNAL(readyReadStandardOutput()), SLOT(stdOut()));
+       connect(process_, SIGNAL(readyReadStandardError()), SLOT(stdErr()));
+       connect(process_, SIGNAL(error(QProcess::ProcessError)), SLOT(processError(QProcess::ProcessError)));
+       connect(process_, SIGNAL(started()), this, SLOT(processStarted()));
+       connect(process_, SIGNAL(finished(int, QProcess::ExitStatus)), SLOT(processFinished(int, QProcess::ExitStatus)));
 }
 
 
@@ -262,16 +266,16 @@ SystemcallPrivate::SystemcallPrivate(const std::string& of) :
 void SystemcallPrivate::startProcess(const QString& cmd)
 {
        cmd_ = cmd;
-       if (proc_) {
+       if (process_) {
                state = SystemcallPrivate::Starting;
-               proc_->start(cmd_);
+               process_->start(cmd_);
        }
 }
 
 
 void SystemcallPrivate::processEvents()
 {
-       if(process_events) {
+       if(process_events_) {
                QCoreApplication::processEvents(/*QEventLoop::ExcludeUserInputEvents*/);
        }
 }
@@ -284,20 +288,20 @@ void SystemcallPrivate::waitAndProcessEvents()
 }
 
 
-bool SystemcallPrivate::waitWhile(State waitwhile, bool proc_events, int timeout)
+bool SystemcallPrivate::waitWhile(State waitwhile, bool process_events, int timeout)
 {
-       if (!proc_)
+       if (!process_)
                return false;
 
-       process_events = proc_events;
+       process_events_ = process_events;
 
        // Block GUI while waiting,
        // relay on QProcess' wait functions
-       if (!process_events) {
+       if (!process_events_) {
                if (waitwhile == Starting)
-                       return proc_->waitForStarted(timeout);
+                       return process_->waitForStarted(timeout);
                if (waitwhile == Running)
-                       return proc_->waitForFinished(timeout);
+                       return process_->waitForFinished(timeout);
                return false;
        }
 
@@ -321,20 +325,16 @@ bool SystemcallPrivate::waitWhile(State waitwhile, bool proc_events, int timeout
 
 SystemcallPrivate::~SystemcallPrivate()
 {
-       flush();
-
-       if (outindex_) {
-               outdata_[outindex_] = '\0';
-               outindex_ = 0;
-               if (showout_)
-                       cout << outdata_;
+       if (out_index_) {
+               out_data_[out_index_] = '\0';
+               out_index_ = 0;
+               cout << out_data_;
        }
        cout.flush();
-       if (errindex_) {
-               errdata_[errindex_] = '\0';
-               errindex_ = 0;
-               if (showerr_)
-                       cerr << errdata_;
+       if (err_index_) {
+               err_data_[err_index_] = '\0';
+               err_index_ = 0;
+               cerr << err_data_;
        }
        cerr.flush();
 
@@ -342,79 +342,57 @@ SystemcallPrivate::~SystemcallPrivate()
 }
 
 
-void SystemcallPrivate::flush()
-{
-       if (proc_) {
-               // If the output has been redirected, we write it all at once.
-               // Even if we are not running in a terminal, the output could go
-               // to some log file, for example ~/.xsession-errors on *nix.
-               if (!os::is_terminal(os::STDOUT) && outfile.empty())
-                       cout << fromqstr(QString::fromLocal8Bit(
-                                               proc_->readAllStandardOutput().data()));
-               if (!os::is_terminal(os::STDERR))
-                       cerr << fromqstr(QString::fromLocal8Bit(
-                                               proc_->readAllStandardError().data()));
-       }
-}
-
-
 void SystemcallPrivate::stdOut()
 {
-       if (proc_) {
+       if (process_) {
                char c;
-               proc_->setReadChannel(QProcess::StandardOutput);
-               while (proc_->getChar(&c)) {
-                       outdata_[outindex_++] = c;
-                       if (c == '\n' || outindex_ + 1 == bufsize_) {
-                               outdata_[outindex_] = '\0';
-                               outindex_ = 0;
-                               if (showout_)
-                                       cout << outdata_;
+               process_->setReadChannel(QProcess::StandardOutput);
+               while (process_->getChar(&c)) {
+                       out_data_[out_index_++] = c;
+                       if (c == '\n' || out_index_ + 1 == buffer_size_) {
+                               out_data_[out_index_] = '\0';
+                               out_index_ = 0;
+                               ProgressInterface::instance()->appendMessage(QString::fromLocal8Bit(out_data_));
+                               cout << out_data_;
                        }
                }
        }
-       const QString data = QString::fromLocal8Bit(outdata_);
-       if (!data.isEmpty()) {
-               // TODO No good messages from the processes. Disable batch mode?
-               //ProgressInterface::instance()->appendMessage(data);
-       }
-       processEvents();
 }
 
 
 void SystemcallPrivate::stdErr()
 {
-       if (proc_) {
+       if (process_) {
                char c;
-               proc_->setReadChannel(QProcess::StandardError);
-               while (proc_->getChar(&c)) {
-                       errdata_[errindex_++] = c;
-                       if (c == '\n' || errindex_ + 1 == bufsize_) {
-                               errdata_[errindex_] = '\0';
-                               errindex_ = 0;
-                               if (showerr_)
-                                       cerr << errdata_;
+               process_->setReadChannel(QProcess::StandardError);
+               while (process_->getChar(&c)) {
+                       err_data_[err_index_++] = c;
+                       if (c == '\n' || err_index_ + 1 == buffer_size_) {
+                               err_data_[err_index_] = '\0';
+                               err_index_ = 0;
+                               ProgressInterface::instance()->appendError(QString::fromLocal8Bit(err_data_));
+                               cerr << err_data_;
                        }
                }
        }
-       const QString data = QString::fromLocal8Bit(errdata_);
-       if (!data.isEmpty())
-               ProgressInterface::instance()->appendError(data);
-       processEvents();
 }
 
 
 void SystemcallPrivate::processStarted()
 {
-       state = Running;
-       ProgressInterface::instance()->processStarted(cmd_);
+       if (state != Running) {
+               state = Running;
+               ProgressInterface::instance()->processStarted(cmd_);
+       }
 }
 
 
 void SystemcallPrivate::processFinished(int, QProcess::ExitStatus)
 {
-       state = Finished;
-       ProgressInterface::instance()->processFinished(cmd_);
+       if (state != Finished) {
+               state = Finished;
+               ProgressInterface::instance()->processFinished(cmd_);
+       }
 }
 
 
@@ -427,11 +405,11 @@ void SystemcallPrivate::processError(QProcess::ProcessError)
 
 QString SystemcallPrivate::errorMessage() const 
 {
-       if (!proc_)
+       if (!process_)
                return "No QProcess available";
 
        QString message;
-       switch (proc_->error()) {
+       switch (process_->error()) {
                case QProcess::FailedToStart:
                        message = "The process failed to start. Either the invoked program is missing, "
                                      "or you may have insufficient permissions to invoke the program.";
@@ -461,11 +439,11 @@ QString SystemcallPrivate::errorMessage() const
 
 QString SystemcallPrivate::exitStatusMessage() const
 {
-       if (!proc_)
+       if (!process_)
                return "No QProcess available";
 
        QString message;
-       switch (proc_->exitStatus()) {
+       switch (process_->exitStatus()) {
                case QProcess::NormalExit:
                        message = "The process exited normally.";
                        break;
@@ -482,24 +460,24 @@ QString SystemcallPrivate::exitStatusMessage() const
 
 int SystemcallPrivate::exitCode()
 {
-       if (!proc_)
+       if (!process_)
                return -1;
 
-       return proc_->exitCode();
+       return process_->exitCode();
 }
 
 
 QProcess* SystemcallPrivate::releaseProcess()
 {
-       QProcess* released = proc_;
-       proc_ = 0;
+       QProcess* released = process_;
+       process_ = 0;
        return released;
 }
 
 
 void SystemcallPrivate::killProcess()
 {
-       killProcess(proc_);
+       killProcess(process_);
 }