]> git.lyx.org Git - lyx.git/blobdiff - src/rowpainter.C
Two fixes involving RtL text drawing
[lyx.git] / src / rowpainter.C
index 13d7021b680ed6337d4c4a46035a8e02d8de871b..907a3c220e7c5b2cd9d7a4490380e74ad8069059 100644 (file)
@@ -69,27 +69,21 @@ public:
        void paintText();
 
 private:
-       void paintForeignMark(double orig_x, LyXFont const & orig_font);
-       void paintHebrewComposeChar(lyx::pos_type & vpos);
-       void paintArabicComposeChar(lyx::pos_type & vpos);
-       void paintChars(lyx::pos_type & vpos, bool hebrew, bool arabic);
+       void paintForeignMark(double orig_x, LyXFont const & font);
+       void paintHebrewComposeChar(lyx::pos_type & vpos, LyXFont const & font);
+       void paintArabicComposeChar(lyx::pos_type & vpos, LyXFont const & font);
+       void paintChars(lyx::pos_type & vpos, LyXFont font, 
+                       bool hebrew, bool arabic);
        int paintAppendixStart(int y);
        void paintFromPos(lyx::pos_type & vpos);
-       void paintInset(lyx::pos_type const pos);
+       void paintInset(lyx::pos_type const pos, LyXFont const & font);
 
        /// return left margin
        int leftMargin() const;
 
-       /// return the font at the given pos
-       LyXFont const getFont(lyx::pos_type pos) const;
-
        /// return the label font for this row
        LyXFont const getLabelFont() const;
 
-       /// return pixel width for the given pos
-       int singleWidth(lyx::pos_type pos) const;
-       int singleWidth(lyx::pos_type pos, char c) const;
-
        /// bufferview to paint on
        BufferView const & bv_;
 
@@ -98,7 +92,7 @@ private:
 
        /// LyXText for the row
        LyXText const & text_;
-       ParagraphList & pars_;
+       ParagraphList const & pars_;
 
        /// The row to paint
        Row const & row_;
@@ -107,6 +101,9 @@ private:
        pit_type const pit_;
        Paragraph const & par_;
 
+       /// is row erased? (change tracking)
+       bool erased_;
+
        // Looks ugly - is
        double const xo_;
        int const yo_;    // current baseline
@@ -115,9 +112,6 @@ private:
        double separator_;
        double hfill_;
        double label_hfill_;
-
-       // Hack to get 1.4cvs working
-       LyXFont font_;
 };
 
 
@@ -125,7 +119,8 @@ RowPainter::RowPainter(PainterInfo & pi,
        LyXText const & text, pit_type pit, Row const & row, int x, int y)
        : bv_(*pi.base.bv), pain_(pi.pain), text_(text), pars_(text.paragraphs()),
          row_(row), pit_(pit), par_(text.paragraphs()[pit]),
-         xo_(x), yo_(y), width_(text_.width()), font_(pi.base.font)
+         erased_(pi.erased_),
+         xo_(x), yo_(y), width_(text_.width())
 {
        RowMetrics m = text_.computeRowMetrics(pit, row_);
        x_ = m.x + xo_;
@@ -142,31 +137,6 @@ RowPainter::RowPainter(PainterInfo & pi,
 }
 
 
-/// "temporary"
-LyXFont const RowPainter::getFont(pos_type pos) const
-{
-       LyXFont lf(font_);
-       LyXFont pf(text_.getFont(par_, pos));
-       lf.reduce(LyXFont(LyXFont::ALL_SANE));
-       lf.realize(pf); 
-       lf.setLanguage(pf.language());
-       return lf;
-}
-
-
-int RowPainter::singleWidth(lyx::pos_type pos) const
-{
-       return text_.singleWidth(par_, pos);
-}
-
-
-int RowPainter::singleWidth(lyx::pos_type pos, char c) const
-{
-       LyXFont const & font = text_.getFont(par_, pos);
-       return text_.singleWidth(par_, pos, c, font);
-}
-
-
 LyXFont const RowPainter::getLabelFont() const
 {
        return text_.getLabelFont(par_);
@@ -179,13 +149,14 @@ int RowPainter::leftMargin() const
 }
 
 
-void RowPainter::paintInset(pos_type const pos)
+void RowPainter::paintInset(pos_type const pos, LyXFont const & font)
 {
        InsetBase const * inset = par_.getInset(pos);
        BOOST_ASSERT(inset);
        PainterInfo pi(const_cast<BufferView *>(&bv_), pain_);
-       pi.base.font = getFont(pos);
+       pi.base.font = font;
        pi.ltr_pos = (text_.bidi.level(pos) % 2 == 0);
+       pi.erased_ = erased_ || isDeletedText(par_, pos);
        theCoords.insets().add(inset, int(x_), yo_);
        inset->drawSelection(pi, int(x_), yo_);
        inset->draw(pi, int(x_), yo_);
@@ -193,7 +164,7 @@ void RowPainter::paintInset(pos_type const pos)
 }
 
 
-void RowPainter::paintHebrewComposeChar(pos_type & vpos)
+void RowPainter::paintHebrewComposeChar(pos_type & vpos, LyXFont const & font)
 {
        pos_type pos = text_.bidi.vis2log(vpos);
 
@@ -204,7 +175,6 @@ void RowPainter::paintHebrewComposeChar(pos_type & vpos)
        str += c;
        ++vpos;
 
-       LyXFont const & font = getFont(pos);
        int const width = font_metrics::width(c, font);
        int dx = 0;
 
@@ -212,7 +182,8 @@ void RowPainter::paintHebrewComposeChar(pos_type & vpos)
                c = par_.getChar(i);
                if (!Encodings::IsComposeChar_hebrew(c)) {
                        if (IsPrintableNonspace(c)) {
-                               int const width2 = singleWidth(i, c);
+                               int const width2 =
+                                       text_.singleWidth(par_, i, c, text_.getFont(par_, i));
                                // dalet / resh
                                dx = (c == 'ø' || c == 'ã')
                                        ? width2 - width
@@ -227,7 +198,7 @@ void RowPainter::paintHebrewComposeChar(pos_type & vpos)
 }
 
 
-void RowPainter::paintArabicComposeChar(pos_type & vpos)
+void RowPainter::paintArabicComposeChar(pos_type & vpos, LyXFont const & font)
 {
        pos_type pos = text_.bidi.vis2log(vpos);
        string str;
@@ -238,7 +209,6 @@ void RowPainter::paintArabicComposeChar(pos_type & vpos)
        str += c;
        ++vpos;
 
-       LyXFont const & font = getFont(pos);
        int const width = font_metrics::width(c, font);
        int dx = 0;
 
@@ -246,7 +216,8 @@ void RowPainter::paintArabicComposeChar(pos_type & vpos)
                c = par_.getChar(i);
                if (!Encodings::IsComposeChar_arabic(c)) {
                        if (IsPrintableNonspace(c)) {
-                               int const width2 = singleWidth(i, c);
+                               int const width2 = 
+                                       text_.singleWidth(par_, i, c, text_.getFont(par_, i));
                                dx = (width2 - width) / 2;
                        }
                        break;
@@ -257,11 +228,13 @@ void RowPainter::paintArabicComposeChar(pos_type & vpos)
 }
 
 
-void RowPainter::paintChars(pos_type & vpos, bool hebrew, bool arabic)
+void RowPainter::paintChars(pos_type & vpos, LyXFont font, 
+                           bool hebrew, bool arabic)
 {
        pos_type pos = text_.bidi.vis2log(vpos);
        pos_type const end = row_.endpos();
-       LyXFont orig_font = getFont(pos);
+       FontSpan const font_span = par_.fontSpan(pos);
+       Change::Type const prev_change = par_.lookupChange(pos);
 
        // first character
        string str;
@@ -271,20 +244,18 @@ void RowPainter::paintChars(pos_type & vpos, bool hebrew, bool arabic)
                str[0] = par_.transformChar(c, pos);
        }
 
-       bool prev_struckout = isDeletedText(par_, pos);
-       bool prev_newtext = isInsertedText(par_, pos);
-
        // collect as much similar chars as we can
-       for (++vpos; vpos < end && (pos = text_.bidi.vis2log(vpos)) >= 0; ++vpos) {
-               char c = par_.getChar(pos);
-
-               if (!IsPrintableNonspace(c))
+       for (++vpos ; vpos < end ; ++vpos) {
+               pos = text_.bidi.vis2log(vpos);
+               if (pos < font_span.first || pos > font_span.last)
                        break;
 
-               if (prev_struckout != isDeletedText(par_, pos))
+               if (prev_change != par_.lookupChange(pos))
                        break;
 
-               if (prev_newtext != isInsertedText(par_, pos))
+               char c = par_.getChar(pos);
+
+               if (!IsPrintableNonspace(c))
                        break;
 
                if (arabic && Encodings::IsComposeChar_arabic(c))
@@ -293,34 +264,31 @@ void RowPainter::paintChars(pos_type & vpos, bool hebrew, bool arabic)
                if (hebrew && Encodings::IsComposeChar_hebrew(c))
                        break;
 
-               if (orig_font != getFont(pos))
-                       break;
-
                if (arabic)
                        c = par_.transformChar(c, pos);
 
                str += c;
        }
 
-       if (prev_struckout)
-               orig_font.setColor(LColor::strikeout);
-       else if (prev_newtext)
-               orig_font.setColor(LColor::newtext);
+       if (prev_change == Change::DELETED)
+               font.setColor(LColor::strikeout);
+       else if (prev_change == Change::INSERTED)
+               font.setColor(LColor::newtext);
 
        // Draw text and set the new x position
        //lyxerr << "paint row: yo_ " << yo_ << "\n";
-       pain_.text(int(x_), yo_, str, orig_font);
-       x_ += font_metrics::width(str, orig_font);
+       pain_.text(int(x_), yo_, str, font);
+       x_ += font_metrics::width(str, font);
 }
 
 
-void RowPainter::paintForeignMark(double orig_x, LyXFont const & orig_font)
+void RowPainter::paintForeignMark(double orig_x, LyXFont const & font)
 {
        if (!lyxrc.mark_foreign_language)
                return;
-       if (orig_font.language() == latex_language)
+       if (font.language() == latex_language)
                return;
-       if (orig_font.language() == bv_.buffer()->params().language)
+       if (font.language() == bv_.buffer()->params().language)
                return;
 
        int const y = yo_ + 1;
@@ -331,26 +299,25 @@ void RowPainter::paintForeignMark(double orig_x, LyXFont const & orig_font)
 void RowPainter::paintFromPos(pos_type & vpos)
 {
        pos_type const pos = text_.bidi.vis2log(vpos);
-
-       LyXFont const & orig_font = getFont(pos);
+       LyXFont orig_font = text_.getFont(par_, pos);
+       text_.applyOuterFont(orig_font);
 
        double const orig_x = x_;
 
-       char const c = par_.getChar(pos);
-
-       if (c == Paragraph::META_INSET) {
-               paintInset(pos);
+       if (par_.isInset(pos)) {
+               paintInset(pos, orig_font);
                ++vpos;
                paintForeignMark(orig_x, orig_font);
                return;
        }
 
        // usual characters, no insets
+       char const c = par_.getChar(pos);
 
        // special case languages
-       bool const hebrew = (orig_font.language()->lang() == "hebrew");
-       bool const arabic =
-               orig_font.language()->lang() == "arabic" &&
+       std::string const & lang = orig_font.language()->lang();
+       bool const hebrew = lang == "hebrew";
+       bool const arabic = lang == "arabic" &&
                (lyxrc.font_norm_type == LyXRC::ISO_8859_6_8 ||
                lyxrc.font_norm_type == LyXRC::ISO_10646_1);
 
@@ -358,11 +325,11 @@ void RowPainter::paintFromPos(pos_type & vpos)
        if ((!hebrew && !arabic)
                || (hebrew && !Encodings::IsComposeChar_hebrew(c))
                || (arabic && !Encodings::IsComposeChar_arabic(c))) {
-               paintChars(vpos, hebrew, arabic);
+               paintChars(vpos, orig_font, hebrew, arabic);
        } else if (hebrew) {
-               paintHebrewComposeChar(vpos);
+               paintHebrewComposeChar(vpos, orig_font);
        } else if (arabic) {
-               paintArabicComposeChar(vpos);
+               paintArabicComposeChar(vpos, orig_font);
        }
 
        paintForeignMark(orig_x, orig_font);
@@ -475,7 +442,7 @@ void RowPainter::paintFirst()
 
        // start of appendix?
        if (parparams.startOfAppendix())
-               y_top += paintAppendixStart(yo_ + y_top + 2 * defaultRowHeight());
+               y_top += paintAppendixStart(yo_ - row_.ascent() + 2 * defaultRowHeight());
 
        Buffer const & buffer = *bv_.buffer();
 
@@ -507,37 +474,33 @@ void RowPainter::paintFirst()
                      || layout->latextype != LATEX_ENVIRONMENT
                      || is_seq)) {
 
-               LyXFont font = getLabelFont();
-               if (!par_.getLabelstring().empty()) {
+               LyXFont const font = getLabelFont();
+               string const str = par_.getLabelstring();
+               if (!str.empty()) {
                        double x = x_;
-                       string const str = par_.getLabelstring();
 
                        // this is special code for the chapter layout. This is
                        // printed in an extra row and has a pagebreak at
                        // the top.
                        if (layout->counter == "chapter") {
-                               if (buffer.params().secnumdepth >= 0) {
-                                       double spacing_val = 1.0;
-                                       if (!parparams.spacing().isDefault()) {
-                                               spacing_val = parparams.spacing().getValue();
-                                       } else {
-                                               spacing_val = buffer.params().spacing().getValue();
-                                       }
-#ifdef WITH_WARNINGS
-#warning Look is this correct?
-#endif
-                                       int const labeladdon = int(font_metrics::maxHeight(font) * layout->spacing.getValue() * spacing_val);
-
-                                       int const maxdesc = int(font_metrics::maxDescent(font) * layout->spacing.getValue() * spacing_val)
-                                               + int(layout->parsep) * defaultRowHeight();
-
-                                       if (is_rtl) {
-                                               x = width_ - leftMargin() -
-                                                       font_metrics::width(str, font);
-                                       }
-
-                                       pain_.text(int(x), yo_ - maxdesc - labeladdon, str, font);
+                               double spacing_val = 1.0;
+                               if (!parparams.spacing().isDefault()) {
+                                       spacing_val = parparams.spacing().getValue();
+                               } else {
+                                       spacing_val = buffer.params().spacing().getValue();
                                }
+
+                               int const labeladdon = int(font_metrics::maxHeight(font) * layout->spacing.getValue() * spacing_val);
+
+                               int const maxdesc = int(font_metrics::maxDescent(font) * layout->spacing.getValue() * spacing_val)
+                                       + int(layout->parsep) * defaultRowHeight();
+
+                               if (is_rtl) {
+                                       x = width_ - leftMargin() -
+                                               font_metrics::width(str, font);
+                               }
+
+                               pain_.text(int(x), yo_ - maxdesc - labeladdon, str, font);
                        } else {
                                if (is_rtl) {
                                        x = width_ - leftMargin()
@@ -561,11 +524,12 @@ void RowPainter::paintFirst()
                if (!par_.getLabelstring().empty()) {
                        string const str = par_.getLabelstring();
                        double spacing_val = 1.0;
-                       if (!parparams.spacing().isDefault()) {
+                       if (!parparams.spacing().isDefault())
                                spacing_val = parparams.spacing().getValue();
-                       } else {
+                       else
                                spacing_val = buffer.params().spacing().getValue();
-                       }
+
+                       int const labeladdon = int(font_metrics::maxHeight(font) * layout->spacing.getValue() * spacing_val);
 
                        int maxdesc =
                                int(font_metrics::maxDescent(font) * layout->spacing.getValue() * spacing_val
@@ -580,7 +544,7 @@ void RowPainter::paintFirst()
                                x = width_ - leftMargin() -
                                        font_metrics::width(str, font);
                        }
-                       pain_.text(int(x), yo_ - maxdesc, str, font);
+                       pain_.text(int(x), yo_ - maxdesc - labeladdon, str, font);
                }
        }
 }
@@ -641,6 +605,10 @@ void RowPainter::paintText()
        bool is_struckout = false;
        int last_strikeout_x = 0;
 
+       // Use font span to speed things up, see below 
+       FontSpan font_span;
+       LyXFont font;
+
        for (pos_type vpos = row_.pos(); vpos < end; ) {
                if (x_ > bv_.workWidth())
                        break;
@@ -652,7 +620,15 @@ void RowPainter::paintText()
                        continue;
                }
 
-               const int width_pos = singleWidth(pos);
+               // Use font span to speed things up, see above
+               if (vpos < font_span.first || vpos > font_span.last) {
+                       font_span = par_.fontSpan(vpos);
+                       font = text_.getFont(par_, vpos);
+               }
+
+               const int width_pos =
+                       text_.singleWidth(par_, pos, par_.getChar(pos), font);
+
                if (x_ + width_pos < 0) {
                        x_ += width_pos;
                        ++vpos;
@@ -669,10 +645,10 @@ void RowPainter::paintText()
                bool const highly_editable_inset = par_.isInset(pos)
                        && isHighlyEditableInset(par_.getInset(pos));
 
-               // if we reach the end of a struck out range, paint it
-               // we also don't paint across things like tables
+               // If we reach the end of a struck out range, paint it.
+               // We also don't paint across things like tables
                if (running_strikeout && (highly_editable_inset || !is_struckout)) {
-                       // calculate 1/3 height of the buffer's default font
+                       // Calculate 1/3 height of the buffer's default font
                        int const middle =
                                yo_ - font_metrics::maxAscent(text_.defaultfont_) / 3;
                        pain_.line(last_strikeout_x, middle, int(x_), middle,
@@ -743,7 +719,7 @@ void paintPar
        static PainterInfo nullpi(pi.base.bv, nop);
        int const ww = pi.base.bv->workHeight();
 
-       Paragraph & par = text.paragraphs()[pit];
+       Paragraph const & par = text.paragraphs()[pit];
 
        RowList::const_iterator const rb = par.rows().begin();
        RowList::const_iterator const re = par.rows().end();
@@ -795,6 +771,8 @@ void paintText(BufferView const & bv, ViewMetricsInfo const & vi)
 
 
        // paint one paragraph above and one below
+       // Note MV: this cannot be suppressed even for singlepar.
+       // Try viewing the User Guide Mobius figure
        if (vi.p1 > 0) {
                text->redoParagraph(vi.p1 - 1);
                paintPar(pi, *bv.text(), vi.p1 - 1, 0,