Fix loop when opening TOC widget in an empty document, basically by Richard Heck.

[lyx.git] / src / rowpainter.C

diff --git a/src/rowpainter.C b/src/rowpainter.C
index ca35c85e319d70f3842f45f9b6241390f0b68ab4..8181a7a306c9ed949911e514a4b6c54b5d70a822 100644 (file)
--- a/src/rowpainter.C
+++ b/src/rowpainter.C
@@ -191,9 +191,7 @@ void RowPainter::paintInset(pos_type const pos, LyXFont const & font)
        bool tmp = refreshInside;
        if (!in || !in->wide()) {
                refreshInside = true;
-               if (lyxerr.debugging(Debug::PAINTING)) { 
-                       lyxerr << endl << "Paint inset fully" << endl;
-               }
+               LYXERR(Debug::PAINTING) << endl << "Paint inset fully" << endl;
        }
        if (refreshInside)
                inset->drawSelection(pi, int(x_), yo_);
@@ -878,6 +876,24 @@ bool innerCursorOnRow(PainterInfo & pi, pit_type pit,
 }
 
 
+// FIXME: once wide() is obsolete, remove this as well!
+bool inNarrowInset(PainterInfo & pi)
+{
+       // check whether the current inset is nested in a non-wide inset
+       LCursor & cur = pi.base.bv->cursor();
+       for (int i = cur.depth() - 1; --i >= 0; ) {
+               InsetBase * const in = &cur[i].inset();
+               if (in) {
+                       InsetText * t = 
+                               const_cast<InsetText *>(in->asTextInset());
+                       if (t)
+                               return !t->wide();
+               }
+       }
+       return false;
+}
+
+
 void paintPar
        (PainterInfo & pi, LyXText const & text, pit_type pit, int x, int y,
         bool repaintAll)
@@ -907,11 +923,12 @@ void paintPar
                bool row_has_changed = pm.rowChangeStatus()[rowno];
 
                bool cursor_on_row = CursorOnRow(pi, pit, rit, text);
-               bool in_inset_alone_on_row = innerCursorOnRow(pi, pit, rit,
-                       text);
+               bool in_inset_alone_on_row =
+                       innerCursorOnRow(pi, pit, rit, text);
                bool leftEdgeFixed = 
                        (par.getAlign() == LYX_ALIGN_LEFT ||
                         par.getAlign() == LYX_ALIGN_BLOCK);
+               bool inNarrowIns = inNarrowInset(pi);
 
                // If this is the only object on the row, we can make it wide
                //
@@ -919,12 +936,16 @@ void paintPar
                // to touch the paragraph contents. So either we move this "wide"
                // property out of InsetText or we localize the feature to the painting
                // done here.
+               // JSpitzm: We should aim at removing wide() altogether while retaining
+               // typing speed within insets.
                for (pos_type i = rit->pos() ; i != rit->endpos(); ++i) {
                        InsetBase const * const in = par.getInset(i);
                        if (in) {
                                InsetText * t = const_cast<InsetText *>(in->asTextInset());
                                if (t)
-                                       t->setWide(in_inset_alone_on_row && leftEdgeFixed);
+                                       t->setWide(in_inset_alone_on_row
+                                                  && leftEdgeFixed
+                                                  && !inNarrowIns);
                        }
                }
 
@@ -977,9 +998,7 @@ void paintPar
        // Re-enable screen drawing for future use of the painter.
        pi.pain.setDrawingEnabled(true);
 
-       if (lyxerr.debugging(Debug::PAINTING)) {
-               LYXERR(Debug::PAINTING) << "." << endl;
-       }
+       LYXERR(Debug::PAINTING) << "." << endl;
 }
 
 } // namespace anon