]> git.lyx.org Git - lyx.git/blobdiff - src/rowpainter.C
fix reading the author field.
[lyx.git] / src / rowpainter.C
index 12b40d365a8fdecaf7061b0d2dcc50834651a306..378ffece6734424b3bd8d5d35933f64bf3cb9c1e 100644 (file)
@@ -14,6 +14,7 @@
 #include "rowpainter.h"
 
 #include "buffer.h"
+#include "coordcache.h"
 #include "cursor.h"
 #include "debug.h"
 #include "bufferparams.h"
@@ -32,6 +33,7 @@
 #include "vspace.h"
 
 #include "frontends/font_metrics.h"
+#include "frontends/nullpainter.h"
 #include "frontends/Painter.h"
 
 #include "insets/insettext.h"
 #include "support/textutils.h"
 
 using lyx::pos_type;
+using lyx::par_type;
 
 using std::endl;
 using std::max;
 using std::string;
 
-extern int NEST_MARGIN;
-extern int CHANGEBAR_MARGIN;
 
 namespace {
 
@@ -55,8 +56,8 @@ namespace {
 class RowPainter {
 public:
        /// initialise and run painter
-       RowPainter(BufferView const & bv, LyXText const & text,
-               ParagraphList::iterator pit, RowList::iterator rit, int xo, int yo);
+       RowPainter(BufferView const & bv, Painter & pain, LyXText const & text,
+               par_type pit, RowList::iterator rit, int y);
 private:
        // paint various parts
        void paintBackground();
@@ -96,13 +97,15 @@ private:
 
        /// LyXText for the row
        LyXText const & text_;
+       ParagraphList & pars_;
 
        /// The row to paint
        RowList::iterator const rit_;
        Row & row_;
 
        /// Row's paragraph
-       mutable ParagraphList::iterator  pit_;
+       par_type const pit_;
+       Paragraph const & par_;
 
        // Looks ugly - is
        double xo_;
@@ -115,24 +118,29 @@ private:
 };
 
 
-RowPainter::RowPainter(BufferView const & bv, LyXText const & text,
-     ParagraphList::iterator pit, RowList::iterator rit,
-     int xo, int yo)
-       : bv_(bv), pain_(bv_.painter()), text_(text), rit_(rit), row_(*rit),
-         pit_(pit), xo_(xo), yo_(yo), x_(row_.x()),
-               width_(text_.textWidth()),
-               separator_(row_.fill_separator()),
-               hfill_(row_.fill_hfill()),
-               label_hfill_(row_.fill_label_hfill())
+RowPainter::RowPainter(BufferView const & bv, Painter & pain,
+       LyXText const & text, par_type pit, RowList::iterator rit, int y)
+       : bv_(bv), pain_(pain), text_(text), pars_(text.paragraphs()),
+         rit_(rit), row_(*rit), pit_(pit), par_(text.paragraphs()[pit]),
+         xo_(text_.xo_), yo_(y), width_(text_.width())
 {
-       x_ += xo_;
+       //lyxerr << "RowPainter: x: " << x_ << " xo: " << xo << " yo: " << yo
+       //      << " pit->y: " << pit_->y
+       //      << " row: " << (par_.size() ? par_.getChar(row_.pos()) : 'X') << endl;
+
+       RowMetrics m = text_.computeRowMetrics(pit, row_);
+       x_ = m.x + xo_;
+
+       separator_ = m.separator;
+       hfill_ = m.hfill;
+       label_hfill_ = m.label_hfill;
 
        // background has already been cleared.
        if (&text_ == bv_.text())
                paintBackground();
 
        // paint the selection background
-       if (text_.selection.set() && &text_ == bv_.fullCursor().innerText())
+       if (bv_.cursor().selection() && &text_ == bv_.cursor().text())
                paintSelection();
 
        // vertical lines for appendix
@@ -147,7 +155,7 @@ RowPainter::RowPainter(BufferView const & bv, LyXText const & text,
        if (row_.pos() == 0)
                paintFirst();
 
-       if (row_.endpos() >= pit_->size())
+       if (row_.endpos() >= par_.size())
                paintLast();
 
        // paint text
@@ -158,26 +166,26 @@ RowPainter::RowPainter(BufferView const & bv, LyXText const & text,
 /// "temporary"
 LyXFont const RowPainter::getFont(pos_type pos) const
 {
-       return text_.getFont(pit_, pos);
+       return text_.getFont(par_, pos);
 }
 
 
 int RowPainter::singleWidth(lyx::pos_type pos) const
 {
-       return text_.singleWidth(pit_, pos);
+       return text_.singleWidth(par_, pos);
 }
 
 
 int RowPainter::singleWidth(lyx::pos_type pos, char c) const
 {
-       LyXFont const & font = text_.getFont(pit_, pos);
-       return text_.singleWidth(pit_, pos, c, font);
+       LyXFont const & font = text_.getFont(par_, pos);
+       return text_.singleWidth(par_, pos, c, font);
 }
 
 
 LyXFont const RowPainter::getLabelFont() const
 {
-       return text_.getLabelFont(pit_);
+       return text_.getLabelFont(par_);
 }
 
 
@@ -189,12 +197,13 @@ int RowPainter::leftMargin() const
 
 void RowPainter::paintInset(pos_type const pos)
 {
-       InsetOld * inset = const_cast<InsetOld*>(pit_->getInset(pos));
-
+       InsetBase const * inset = par_.getInset(pos);
        BOOST_ASSERT(inset);
-
-       PainterInfo pi(const_cast<BufferView *>(&bv_));
+       PainterInfo pi(const_cast<BufferView *>(&bv_), pain_);
        pi.base.font = getFont(pos);
+       pi.ltr_pos = (text_.bidi.level(pos) % 2 == 0);
+       theCoords.insets_.add(inset, int(x_), yo_ + row_.baseline());
+       inset->drawSelection(pi, int(x_), yo_ + row_.baseline());
        inset->draw(pi, int(x_), yo_ + row_.baseline());
        x_ += inset->width();
 }
@@ -207,7 +216,7 @@ void RowPainter::paintHebrewComposeChar(pos_type & vpos)
        string str;
 
        // first char
-       char c = pit_->getChar(pos);
+       char c = par_.getChar(pos);
        str += c;
        ++vpos;
 
@@ -216,7 +225,7 @@ void RowPainter::paintHebrewComposeChar(pos_type & vpos)
        int dx = 0;
 
        for (pos_type i = pos - 1; i >= 0; --i) {
-               c = pit_->getChar(i);
+               c = par_.getChar(i);
                if (!Encodings::IsComposeChar_hebrew(c)) {
                        if (IsPrintableNonspace(c)) {
                                int const width2 = singleWidth(i, c);
@@ -240,9 +249,9 @@ void RowPainter::paintArabicComposeChar(pos_type & vpos)
        string str;
 
        // first char
-       char c = pit_->getChar(pos);
-       c = pit_->transformChar(c, pos);
-       str +=c;
+       char c = par_.getChar(pos);
+       c = par_.transformChar(c, pos);
+       str += c;
        ++vpos;
 
        LyXFont const & font = getFont(pos);
@@ -250,7 +259,7 @@ void RowPainter::paintArabicComposeChar(pos_type & vpos)
        int dx = 0;
 
        for (pos_type i = pos - 1; i >= 0; --i) {
-               c = pit_->getChar(i);
+               c = par_.getChar(i);
                if (!Encodings::IsComposeChar_arabic(c)) {
                        if (IsPrintableNonspace(c)) {
                                int const width2 = singleWidth(i, c);
@@ -272,26 +281,26 @@ void RowPainter::paintChars(pos_type & vpos, bool hebrew, bool arabic)
 
        // first character
        string str;
-       str += pit_->getChar(pos);
+       str += par_.getChar(pos);
        if (arabic) {
                unsigned char c = str[0];
-               str[0] = pit_->transformChar(c, pos);
+               str[0] = par_.transformChar(c, pos);
        }
 
-       bool prev_struckout = isDeletedText(*pit_, pos);
-       bool prev_newtext = isInsertedText(*pit_, pos);
+       bool prev_struckout = isDeletedText(par_, pos);
+       bool prev_newtext = isInsertedText(par_, pos);
 
        // collect as much similar chars as we can
        for (++vpos; vpos < end && (pos = text_.bidi.vis2log(vpos)) >= 0; ++vpos) {
-               char c = pit_->getChar(pos);
+               char c = par_.getChar(pos);
 
                if (!IsPrintableNonspace(c))
                        break;
 
-               if (prev_struckout != isDeletedText(*pit_, pos))
+               if (prev_struckout != isDeletedText(par_, pos))
                        break;
 
-               if (prev_newtext != isInsertedText(*pit_, pos))
+               if (prev_newtext != isInsertedText(par_, pos))
                        break;
 
                if (arabic && Encodings::IsComposeChar_arabic(c))
@@ -304,7 +313,7 @@ void RowPainter::paintChars(pos_type & vpos, bool hebrew, bool arabic)
                        break;
 
                if (arabic)
-                       c = pit_->transformChar(c, pos);
+                       c = par_.transformChar(c, pos);
 
                str += c;
        }
@@ -344,7 +353,7 @@ void RowPainter::paintFromPos(pos_type & vpos)
 
        double const orig_x = x_;
 
-       char const c = pit_->getChar(pos);
+       char const c = par_.getChar(pos);
 
        if (c == Paragraph::META_INSET) {
                paintInset(pos);
@@ -388,45 +397,41 @@ void RowPainter::paintBackground()
 
 void RowPainter::paintSelection()
 {
-       bool const is_rtl = pit_->isRightToLeftPar(bv_.buffer()->params());
+       bool const is_rtl = text_.isRTL(par_);
 
        // the current selection
-       int const startx = text_.cursorX(text_.selStart());
-       int const endx = text_.cursorX(text_.selEnd());
-       int const starty = text_.cursorY(text_.selStart());
-       int const endy = text_.cursorY(text_.selEnd());
-       ParagraphList::iterator startpit = text_.getPar(text_.selStart());
-       ParagraphList::iterator endpit = text_.getPar(text_.selEnd());
-       RowList::iterator startrow = startpit->getRow(text_.selStart().pos());
-       RowList::iterator endrow = endpit->getRow(text_.selEnd().pos());
+       LCursor const & cur = bv_.cursor();
+       int const starty = text_.cursorY(cur.selBegin());
+       int const endy = text_.cursorY(cur.selEnd());
+       par_type startpit = cur.selBegin().par();
+       par_type endpit = cur.selEnd().par();
+       RowList::iterator startrow = pars_[startpit].getRow(cur.selBegin().pos());
+       RowList::iterator endrow = pars_[endpit].getRow(cur.selEnd().pos());
        int const h = row_.height();
 
-       int const row_y = pit_->y + row_.y_offset();
+       int const row_y = text_.yo_ + par_.y + row_.y_offset();
 
        bool const sel_starts_here = startpit == pit_ && startrow == rit_;
        bool const sel_ends_here   = endpit == pit_ && endrow == rit_;
        bool const sel_on_one_row  = sel_starts_here && sel_ends_here;
 
        if (text_.bidi.same_direction()) {
-               int x;
-               int w;
                if (sel_on_one_row) {
-                       if (startx < endx) {
-                               x = int(xo_) + startx;
-                               w = endx - startx;
-                       } else {
-                               x = int(xo_) + endx;
-                               w = startx - endx;
-                       }
-                       pain_.fillRectangle(x, yo_, w, h, LColor::selection);
+                       int const startx = text_.cursorX(cur.selBegin());
+                       int const endx = text_.cursorX(cur.selEnd());
+                       int const x1 = is_rtl ? endx : startx;
+                       int const x2 = is_rtl ? startx : endx;
+                       pain_.fillRectangle(x1, yo_, x2 - x1, h, LColor::selection);
                } else if (sel_starts_here) {
-                       int const x = is_rtl ? int(xo_) : int(xo_ + startx);
-                       int const w = is_rtl ? startx : (width_ - startx);
-                       pain_.fillRectangle(x, yo_, w, h, LColor::selection);
+                       int const startx = text_.cursorX(cur.selBegin());
+                       int const x1 = is_rtl ? int(xo_) : startx;
+                       int const x2 = is_rtl ? startx : int(xo_) + width_;
+                       pain_.fillRectangle(x1, yo_, x2 - x1, h, LColor::selection);
                } else if (sel_ends_here) {
-                       int const x = is_rtl ? int(xo_ + endx) : int(xo_);
-                       int const w = is_rtl ? (width_ - endx) : endx;
-                       pain_.fillRectangle(x, yo_, w, h, LColor::selection);
+                       int const endx = text_.cursorX(cur.selEnd());
+                       int const x1 = is_rtl ? endx : int(xo_);
+                       int const x2 = is_rtl ? int(xo_) + width_ : endx;
+                       pain_.fillRectangle(x1, yo_, x2 - x1, h, LColor::selection);
                } else if (row_y > starty && row_y < endy) {
                        pain_.fillRectangle(int(xo_), yo_, width_, h, LColor::selection);
                }
@@ -438,7 +443,7 @@ void RowPainter::paintSelection()
                pain_.fillRectangle(int(xo_), yo_,
                        int(x_), h, LColor::selection);
 
-       pos_type const body_pos = pit_->beginOfBody();
+       pos_type const body_pos = par_.beginOfBody();
        pos_type const end = row_.endpos();
        double tmpx = x_;
 
@@ -446,31 +451,31 @@ void RowPainter::paintSelection()
                pos_type pos = text_.bidi.vis2log(vpos);
                double const old_tmpx = tmpx;
                if (body_pos > 0 && pos == body_pos - 1) {
-                       LyXLayout_ptr const & layout = pit_->layout();
+                       LyXLayout_ptr const & layout = par_.layout();
                        LyXFont const lfont = getLabelFont();
 
                        tmpx += label_hfill_ + font_metrics::width(layout->labelsep, lfont);
 
-                       if (pit_->isLineSeparator(body_pos - 1))
+                       if (par_.isLineSeparator(body_pos - 1))
                                tmpx -= singleWidth(body_pos - 1);
                }
 
                tmpx += singleWidth(pos);
 
-               if (hfillExpansion(*pit_, row_, pos)) {
+               if (hfillExpansion(par_, row_, pos)) {
                        if (pos >= body_pos)
                                tmpx += hfill_;
                        else
                                tmpx += label_hfill_;
                } else {
-                       if (pit_->isSeparator(pos) && pos >= body_pos)
+                       if (par_.isSeparator(pos) && pos >= body_pos)
                                tmpx += separator_;
                }
 
                if (((startpit != pit_ && startrow != rit_)
-                               || text_.selStart().pos() <= pos) &&
+                               || cur.selBegin().pos() <= pos) &&
                        ((endpit != pit_ && endrow != rit_)
-                               || pos < text_.selEnd().pos())) {
+                               || pos < cur.selEnd().pos())) {
                        // Here we do not use x_ as xo_ was added to x_.
                        pain_.fillRectangle(int(old_tmpx), yo_,
                                int(tmpx - old_tmpx + 1), h, LColor::selection);
@@ -490,7 +495,7 @@ void RowPainter::paintChangeBar()
        pos_type const start = row_.pos();
        pos_type const end = row_.endpos();
 
-       if (start == end || !pit_->isChanged(start, end - 1))
+       if (start == end || !par_.isChanged(start, end - 1))
                return;
 
        int const height = text_.isLastRow(pit_, row_)
@@ -503,51 +508,49 @@ void RowPainter::paintChangeBar()
 
 void RowPainter::paintAppendix()
 {
-       if (!pit_->params().appendix())
+       if (!par_.params().appendix())
                return;
 
-       // FIXME: can be just width_ ?
-       int const ww = width_;
-
        int y = yo_;
 
-       if (pit_->params().startOfAppendix())
+       if (par_.params().startOfAppendix())
                y += 2 * defaultRowHeight();
 
        pain_.line(1, y, 1, yo_ + row_.height(), LColor::appendix);
-       pain_.line(ww - 2, y, ww - 2, yo_ + row_.height(), LColor::appendix);
+       pain_.line(width_ - 2, y, width_ - 2, yo_ + row_.height(), LColor::appendix);
 }
 
 
 void RowPainter::paintDepthBar()
 {
-       Paragraph::depth_type const depth = pit_->getDepth();
+       Paragraph::depth_type const depth = par_.getDepth();
 
        if (depth <= 0)
                return;
 
        Paragraph::depth_type prev_depth = 0;
        if (!text_.isFirstRow(pit_, row_)) {
-               ParagraphList::iterator pit2 = pit_;
+               par_type pit2 = pit_;
                if (row_.pos() == 0)
                        --pit2;
-               prev_depth = pit2->getDepth();
+               prev_depth = pars_[pit2].getDepth();
        }
 
        Paragraph::depth_type next_depth = 0;
        if (!text_.isLastRow(pit_, row_)) {
-               ParagraphList::iterator pit2 = pit_;
-               if (row_.endpos() >= pit2->size())
+               par_type pit2 = pit_;
+               if (row_.endpos() >= pars_[pit2].size())
                        ++pit2;
-               next_depth = pit2->getDepth();
+               next_depth = pars_[pit2].getDepth();
        }
 
        for (Paragraph::depth_type i = 1; i <= depth; ++i) {
-               int const w = NEST_MARGIN / 5;
-               int x = int(w * i + xo_);
-               // only consider the changebar space if we're drawing outer left
-               if (xo_ == 0)
-                       x += CHANGEBAR_MARGIN;
+               int const w = nestMargin() / 5;
+               int x = int(xo_) + w * i;
+               // only consider the changebar space if we're drawing outermost text
+               if (text_.isMainText())
+                       x += changebarMargin();
+
                int const h = yo_ + row_.height() - 1 - (i - next_depth - 1) * 3;
 
                pain_.line(x, yo_, x, h, LColor::depthbar);
@@ -586,7 +589,7 @@ int RowPainter::paintAppendixStart(int y)
 
 void RowPainter::paintFirst()
 {
-       ParagraphParameters const & parparams = pit_->params();
+       ParagraphParameters const & parparams = par_.params();
 
        int y_top = 0;
 
@@ -596,18 +599,17 @@ void RowPainter::paintFirst()
 
        Buffer const & buffer = *bv_.buffer();
 
-       LyXLayout_ptr const & layout = pit_->layout();
+       LyXLayout_ptr const & layout = par_.layout();
 
        if (buffer.params().paragraph_separation == BufferParams::PARSEP_SKIP) {
-               if (pit_ != text_.paragraphs().begin()) {
+               if (pit_ != 0) {
                        if (layout->latextype == LATEX_PARAGRAPH
-                               && !pit_->getDepth()) {
+                               && !par_.getDepth()) {
                                y_top += buffer.params().getDefSkip().inPixels(bv_);
                        } else {
-                               LyXLayout_ptr const & playout =
-                                       boost::prior(pit_)->layout();
+                               LyXLayout_ptr const & playout = pars_[pit_ - 1].layout();
                                if (playout->latextype == LATEX_PARAGRAPH
-                                       && !boost::prior(pit_)->getDepth()) {
+                                       && !pars_[pit_ - 1].getDepth()) {
                                        // is it right to use defskip here, too? (AS)
                                        y_top += buffer.params().getDefSkip().inPixels(bv_);
                                }
@@ -615,11 +617,9 @@ void RowPainter::paintFirst()
                }
        }
 
-       int const ww = bv_.workWidth();
-
-       bool const is_rtl = pit_->isRightToLeftPar(bv_.buffer()->params());
+       bool const is_rtl = text_.isRTL(par_);
        bool const is_seq = isFirstInSequence(pit_, text_.paragraphs());
-       //lyxerr << "paintFirst: " << pit_->id() << " is_seq: " << is_seq << std::endl;
+       //lyxerr << "paintFirst: " << par_.id() << " is_seq: " << is_seq << std::endl;
 
        // should we print a label?
        if (layout->labeltype >= LABEL_STATIC
@@ -628,9 +628,9 @@ void RowPainter::paintFirst()
                      || is_seq)) {
 
                LyXFont font = getLabelFont();
-               if (!pit_->getLabelstring().empty()) {
+               if (!par_.getLabelstring().empty()) {
                        double x = x_;
-                       string const str = pit_->getLabelstring();
+                       string const str = par_.getLabelstring();
 
                        // this is special code for the chapter layout. This is
                        // printed in an extra row and has a pagebreak at
@@ -649,7 +649,7 @@ void RowPainter::paintFirst()
                                                + int(layout->parsep) * defaultRowHeight();
 
                                        if (is_rtl) {
-                                               x = ww - leftMargin() -
+                                               x = width_ - leftMargin() -
                                                        font_metrics::width(str, font);
                                        }
 
@@ -660,7 +660,7 @@ void RowPainter::paintFirst()
                                }
                        } else {
                                if (is_rtl) {
-                                       x = ww - leftMargin()
+                                       x = width_ - leftMargin()
                                                + font_metrics::width(layout->labelsep, font);
                                } else {
                                        x = x_ - font_metrics::width(layout->labelsep, font)
@@ -678,8 +678,8 @@ void RowPainter::paintFirst()
                layout->labeltype == LABEL_BIBLIO ||
                layout->labeltype == LABEL_CENTERED_TOP_ENVIRONMENT)) {
                LyXFont font = getLabelFont();
-               if (!pit_->getLabelstring().empty()) {
-                       string const str = pit_->getLabelstring();
+               if (!par_.getLabelstring().empty()) {
+                       string const str = par_.getLabelstring();
                        float spacing_val = 1.0;
                        if (!parparams.spacing().isDefault()) {
                                spacing_val = parparams.spacing().getValue();
@@ -694,10 +694,10 @@ void RowPainter::paintFirst()
                        double x = x_;
                        if (layout->labeltype == LABEL_CENTERED_TOP_ENVIRONMENT) {
                                x = ((is_rtl ? leftMargin() : x_)
-                                        + ww - text_.rightMargin(*pit_)) / 2;
+                                        + width_ - text_.rightMargin(par_)) / 2;
                                x -= font_metrics::width(str, font) / 2;
                        } else if (is_rtl) {
-                               x = ww - leftMargin() -
+                               x = width_ - leftMargin() -
                                        font_metrics::width(str, font);
                        }
                        pain_.text(int(x),
@@ -710,8 +710,7 @@ void RowPainter::paintFirst()
 
 void RowPainter::paintLast()
 {
-       int const ww = bv_.workWidth();
-       bool const is_rtl = pit_->isRightToLeftPar(bv_.buffer()->params());
+       bool const is_rtl = text_.isRTL(par_);
        int const endlabel = getEndLabel(pit_, text_.paragraphs());
 
        // draw an endlabel
@@ -721,10 +720,10 @@ void RowPainter::paintLast()
                LyXFont const font = getLabelFont();
                int const size = int(0.75 * font_metrics::maxAscent(font));
                int const y = yo_ + row_.baseline() - size;
-               int x = is_rtl ? NEST_MARGIN + CHANGEBAR_MARGIN: ww - size;
+               int x = is_rtl ? nestMargin() + changebarMargin() : width_ - size;
 
-               if (row_.fill() <= size)
-                       x += (size - row_.fill() + 1) * (is_rtl ? -1 : 1);
+               if (width_ - int(row_.width()) <= size)
+                       x += (size - width_ + row_.width() + 1) * (is_rtl ? -1 : 1);
 
                if (endlabel == END_LABEL_BOX)
                        pain_.rectangle(x, y, size, size, LColor::eolmarker);
@@ -735,10 +734,10 @@ void RowPainter::paintLast()
 
        case END_LABEL_STATIC: {
                LyXFont font = getLabelFont();
-               string const & str = pit_->layout()->endlabelstring();
+               string const & str = par_.layout()->endlabelstring();
                double const x = is_rtl ?
                        x_ - font_metrics::width(str, font)
-                       : ww - text_.rightMargin(*pit_) - row_.fill();
+                       : - text_.rightMargin(par_) - row_.width();
                pain_.text(int(x), yo_ + row_.baseline(), str, font);
                break;
        }
@@ -752,13 +751,13 @@ void RowPainter::paintLast()
 void RowPainter::paintText()
 {
        pos_type const end = row_.endpos();
-       pos_type body_pos = pit_->beginOfBody();
+       pos_type body_pos = par_.beginOfBody();
        if (body_pos > 0 &&
-               (body_pos > end || !pit_->isLineSeparator(body_pos - 1))) {
+               (body_pos > end || !par_.isLineSeparator(body_pos - 1))) {
                body_pos = 0;
        }
 
-       LyXLayout_ptr const & layout = pit_->layout();
+       LyXLayout_ptr const & layout = par_.layout();
 
        bool running_strikeout = false;
        bool is_struckout = false;
@@ -768,28 +767,29 @@ void RowPainter::paintText()
                if (x_ > bv_.workWidth())
                        break;
 
-               pos_type pos = text_.bidi.vis2log(vpos);
+               pos_type const pos = text_.bidi.vis2log(vpos);
 
-               if (pos >= pit_->size()) {
+               if (pos >= par_.size()) {
                        ++vpos;
                        continue;
                }
 
-               if (x_ + singleWidth(pos) < 0) {
-                       x_ += singleWidth(pos);
+               const int width_pos = singleWidth(pos);
+               if (x_ + width_pos < 0) {
+                       x_ += width_pos;
                        ++vpos;
                        continue;
                }
 
-               is_struckout = isDeletedText(*pit_, pos);
+               is_struckout = isDeletedText(par_, pos);
 
                if (is_struckout && !running_strikeout) {
                        running_strikeout = true;
                        last_strikeout_x = int(x_);
                }
 
-               bool const highly_editable_inset = pit_->isInset(pos)
-                       && isHighlyEditableInset(pit_->getInset(pos));
+               bool const highly_editable_inset = par_.isInset(pos)
+                       && isHighlyEditableInset(par_.getInset(pos));
 
                // if we reach the end of a struck out range, paint it
                // we also don't paint across things like tables
@@ -804,10 +804,10 @@ void RowPainter::paintText()
                        int const lwidth = font_metrics::width(layout->labelsep,
                                getLabelFont());
 
-                       x_ += label_hfill_ + lwidth - singleWidth(body_pos - 1);
+                       x_ += label_hfill_ + lwidth - width_pos;
                }
 
-               if (pit_->isHfill(pos)) {
+               if (par_.isHfill(pos)) {
                        x_ += 1;
 
                        int const y0 = yo_ + row_.baseline();
@@ -815,7 +815,7 @@ void RowPainter::paintText()
 
                        pain_.line(int(x_), y1, int(x_), y0, LColor::added_space);
 
-                       if (hfillExpansion(*pit_, row_, pos)) {
+                       if (hfillExpansion(par_, row_, pos)) {
                                int const y2 = (y0 + y1) / 2;
 
                                if (pos >= body_pos) {
@@ -833,8 +833,8 @@ void RowPainter::paintText()
                        }
                        x_ += 2;
                        ++vpos;
-               } else if (pit_->isSeparator(pos)) {
-                       x_ += singleWidth(pos);
+               } else if (par_.isSeparator(pos)) {
+                       x_ += width_pos;
                        if (pos >= body_pos)
                                x_ += separator_;
                        ++vpos;
@@ -853,42 +853,53 @@ void RowPainter::paintText()
 }
 
 
-int paintPars(BufferView const & bv, LyXText const & text,
-       ParagraphList::iterator pit, int xo, int yo, int y)
+int paintPars(BufferView const & bv, Painter & pain,
+             LyXText const & text, par_type pit, par_type end)
 {
        //lyxerr << "  paintRows: pit: " << &*pit << endl;
-       int const y2 = bv.painter().paperHeight();
-       y -= bv.top_y();
+       ParagraphList & pars = text.paragraphs();
 
-       ParagraphList::iterator end = text.paragraphs().end();
+       int y = pars[pit].y + text.yo_ - bv.top_y();
 
-       for ( ; pit != end; ++pit) {
-               RowList::iterator row = pit->rows.begin();
-               RowList::iterator rend = pit->rows.end();
+       for (; pit != end; ++pit) {
+               RowList::iterator row = pars[pit].rows.begin();
+               RowList::iterator rend = pars[pit].rows.end();
 
+               // We draw full paragraphs to get the (xo, yo) cache of all
+               // contained insets right. This is needed for properly working
+               // editXY. And maybe not even sufficient.
+               // FIXME: Alfredo, please have a look at the coordinate business
+               // again.
                for ( ; row != rend; ++row) {
-                       RowPainter(bv, text, pit, row, xo, y + yo);
+                       RowPainter(bv, pain, text, pit, row, y);
                        y += row->height();
                }
-               if (yo + y >= y2)
-                       break;
-       }
 
+       }
        return y;
 }
 
 } // namespace anon
 
 
+void refreshPar(BufferView const & bv, LyXText const & text, par_type pit)
+{
+       static NullPainter nop;
+       paintPars(bv, nop, text, pit, pit + 1);
+}
+
+
 int paintText(BufferView const & bv)
 {
-       ParagraphList::iterator pit;
-       bv.text()->getRowNearY(bv.top_y(), pit);
-       return paintPars(bv, *bv.text(), pit, 0, 0, pit->y);
+       par_type pit, end;
+       getParsInRange(bv.text()->paragraphs(), bv.top_y(),
+                      bv.top_y() + bv.workHeight(), pit, end);
+       //lyxerr << "top_y: " << bv.top_y() << " y: " << pit->y << endl;
+       return paintPars(bv, bv.painter(), *bv.text(), pit, end);
 }
 
 
-void paintTextInset(LyXText const & text, PainterInfo & pi, int xo, int yo)
+void paintTextInset(LyXText const & text, PainterInfo & pi)
 {
-       paintPars(*pi.base.bv, text, text.paragraphs().begin(), xo, yo, 0);
+       paintPars(*pi.base.bv, pi.pain, text, 0, text.paragraphs().size());
 }