]> git.lyx.org Git - lyx.git/blobdiff - src/output_docbook.cpp
Fix #10328.
[lyx.git] / src / output_docbook.cpp
index a081b2db79db219474612954e7c9916444c2aa49..5e15edcee9b47b84d50432e5bd0f6d29f903f064 100644 (file)
@@ -189,31 +189,22 @@ namespace {
 
 // convenience functions
 
-void openParTag(XMLStream & xs, Paragraph const & par)
+void openParTag(XMLStream &xs, Layout const &lay)
 {
-       Layout const & lay = par.layout();
-
-       if (lay.docbookwrappertag() != "NONE")
+       if (lay.docbookwrappertag() != "NONE") {
                xs << xml::StartTag(lay.docbookwrappertag(), lay.docbookwrapperattr());
+       }
 
        string tag = lay.docbooktag();
        if (tag == "Plain Layout")
                tag = "para";
 
        xs << xml::ParTag(tag, lay.docbookattr());
-
-       if (lay.docbookitemtag() != "NONE")
-               xs << xml::StartTag(lay.docbookitemtag(), lay.docbookitemattr());
 }
 
 
-void closeTag(XMLStream & xs, Paragraph const & par)
+void closeTag(XMLStream &xs, Layout const &lay)
 {
-       Layout const & lay = par.layout();
-
-       if (lay.docbookitemtag() != "NONE")
-               xs << xml::EndTag(lay.docbookitemtag());
-
        string tag = lay.docbooktag();
        if (tag == "Plain Layout")
                tag = "para";
@@ -237,14 +228,14 @@ void closeLabelTag(XMLStream & xs, Layout const & lay)
 }
 
 
-void openItemTag(XMLStream & xs, Layout const & lay)
+void openItemTag(XMLStream &xs, Layout const &lay)
 {
        xs << xml::StartTag(lay.docbookitemtag(), lay.docbookitemattr());
 }
 
 
 // Return true when new elements are output in a paragraph, false otherwise.
-bool openInnerItemTag(XMLStream & xs, Layout const & lay)
+bool openInnerItemTag(XMLStream &xs, Layout const &lay)
 {
        if (lay.docbookiteminnertag() != "NONE") {
                xs << xml::CR();
@@ -258,7 +249,7 @@ bool openInnerItemTag(XMLStream & xs, Layout const & lay)
 }
 
 
-void closeInnerItemTag(XMLStream & xs, Layout const & lay)
+void closeInnerItemTag(XMLStream &xs, Layout const &lay)
 {
        if (lay.docbookiteminnertag()!= "NONE") {
                xs << xml::EndTag(lay.docbookiteminnertag());
@@ -267,7 +258,7 @@ void closeInnerItemTag(XMLStream & xs, Layout const & lay)
 }
 
 
-inline void closeItemTag(XMLStream & xs, Layout const & lay)
+inline void closeItemTag(XMLStream &xs, Layout const &lay)
 {
        xs << xml::EndTag(lay.docbookitemtag());
        xs << xml::CR();
@@ -275,11 +266,10 @@ inline void closeItemTag(XMLStream & xs, Layout const & lay)
 
 // end of convenience functions
 
-ParagraphList::const_iterator findLast(
+ParagraphList::const_iterator findLastParagraph(
                ParagraphList::const_iterator p,
-               ParagraphList::const_iterator const & pend,
-               LatexType type) {
-       for (++p; p != pend && p->layout().latextype == type; ++p);
+               ParagraphList::const_iterator const & pend) {
+       for (++p; p != pend && p->layout().latextype == LATEX_PARAGRAPH; ++p);
 
        return p;
 }
@@ -298,8 +288,8 @@ ParagraphList::const_iterator findEndOfEnvironment(
                ParagraphList::const_iterator const & pend)
 {
        ParagraphList::const_iterator p = pstart;
+       Layout const &bstyle = p->layout();
        size_t const depth = p->params().depth();
-
        for (++p; p != pend; ++p) {
                Layout const &style = p->layout();
                // It shouldn't happen that e.g. a section command occurs inside
@@ -319,10 +309,9 @@ ParagraphList::const_iterator findEndOfEnvironment(
                // FIXME I am not sure about the first check.
                // Surely we *could* have different layouts that count as
                // LATEX_PARAGRAPH, right?
-               if (style.latextype == LATEX_PARAGRAPH || style != p->layout())
+               if (style.latextype == LATEX_PARAGRAPH || style != bstyle)
                        return p;
        }
-
        return pend;
 }
 
@@ -402,6 +391,8 @@ ParagraphList::const_iterator makeParagraphs(
        ParagraphList::const_iterator const begin = text.paragraphs().begin();
        ParagraphList::const_iterator par = pbegin;
        for (; par != pend; ++par) {
+               Layout const &lay = par->layout();
+
                // We want to open the paragraph tag if:
                //   (i) the current layout permits multiple paragraphs
                //  (ii) we are either not already inside a paragraph (HTMLIsBlock) OR
@@ -431,7 +422,7 @@ ParagraphList::const_iterator makeParagraphs(
                }
 
                // Plain layouts must be ignored.
-               if (!special_case && buf.params().documentClass().isPlainLayout(par->layout()) && !runparams.docbook_force_pars)
+               if (!special_case && buf.params().documentClass().isPlainLayout(lay) && !runparams.docbook_force_pars)
                        special_case = true;
                // TODO: Could get rid of this with a DocBook equivalent to htmlisblock?
                if (!special_case && par->size() == 1 && par->getInset(0)) {
@@ -484,12 +475,12 @@ ParagraphList::const_iterator makeParagraphs(
 
                if (!cleaned.empty()) {
                        if (open_par)
-                               openParTag(xs, *par);
+                               openParTag(xs, lay);
 
                        xs << XMLStream::ESCAPE_NONE << os2.str();
 
                        if (close_par) {
-                               closeTag(xs, *par);
+                               closeTag(xs, lay);
                                xs << xml::CR();
                        }
                }
@@ -513,12 +504,13 @@ ParagraphList::const_iterator makeEnvironment(
                ParagraphList::const_iterator const & pbegin,
                ParagraphList::const_iterator const & pend)
 {
-       auto const begin = text.paragraphs().begin();
+       ParagraphList::const_iterator const begin = text.paragraphs().begin();
        ParagraphList::const_iterator par = pbegin;
+       Layout const &bstyle = par->layout();
        depth_type const origdepth = pbegin->params().depth();
 
        // open tag for this environment
-       openParTag(xs, *par);
+       openParTag(xs, bstyle);
        xs << xml::CR();
 
        // we will on occasion need to remember a layout from before.
@@ -537,7 +529,7 @@ ParagraphList::const_iterator makeEnvironment(
                        // One is that we are still in the environment in which we
                        // started---which we will be if the depth is the same.
                        if (par->params().depth() == origdepth) {
-                               LATTEST(par->layout() == style);
+                               LATTEST(bstyle == style);
                                if (lastlay != nullptr) {
                                        closeItemTag(xs, *lastlay);
                                        if (lastlay->docbookitemwrappertag() != "NONE") {
@@ -652,11 +644,11 @@ ParagraphList::const_iterator makeEnvironment(
                        break;
                }
                case LATEX_PARAGRAPH:
-                       send = findLast(par, pend, LATEX_PARAGRAPH);
+                       send = findLastParagraph(par, pend);
                        par = makeParagraphs(buf, xs, runparams, text, par, send);
                        break;
                case LATEX_BIB_ENVIRONMENT:
-                       send = findLast(par, pend, LATEX_BIB_ENVIRONMENT);
+                       send = findLastBibliographyParagraph(par, pend);
                        par = makeParagraphBibliography(buf, xs, runparams, text, par, send);
                        break;
                case LATEX_COMMAND:
@@ -672,7 +664,7 @@ ParagraphList::const_iterator makeEnvironment(
                        xs << xml::CR();
                }
        }
-       closeTag(xs, *par);
+       closeTag(xs, bstyle);
        xs << xml::CR();
        return pend;
 }
@@ -685,15 +677,16 @@ void makeCommand(
                Text const & text,
                ParagraphList::const_iterator const & pbegin)
 {
+       Layout const &style = pbegin->layout();
+
        // No need for labels, as they are handled by DocBook tags.
 
-       openParTag(xs, *pbegin);
+       openParTag(xs, style);
 
-       auto const begin = text.paragraphs().begin();
+       ParagraphList::const_iterator const begin = text.paragraphs().begin();
        pbegin->simpleDocBookOnePar(buf, xs, runparams,
                                                                text.outerFont(distance(begin, pbegin)));
-
-       closeTag(xs, *pbegin);
+       closeTag(xs, style);
        xs << xml::CR();
 }
 
@@ -725,19 +718,22 @@ pair<ParagraphList::const_iterator, ParagraphList::const_iterator> makeAny(
                }
                case LATEX_ENVIRONMENT:
                case LATEX_LIST_ENVIRONMENT:
-               case LATEX_ITEM_ENVIRONMENT:
+               case LATEX_ITEM_ENVIRONMENT: {
                        // FIXME Same fix here.
                        send = findEndOfEnvironment(par, pend);
                        par = makeEnvironment(buf, xs, ourparams, text, par, send);
                        break;
-               case LATEX_PARAGRAPH:
-                       send = findLast(par, pend, LATEX_PARAGRAPH);
-                       par = makeParagraphs(buf, xs, ourparams, text, par, send);
-                       break;
-               case LATEX_BIB_ENVIRONMENT:
-                       send = findLast(par, pend, LATEX_BIB_ENVIRONMENT);
+               }
+               case LATEX_BIB_ENVIRONMENT: {
+                       send = findLastBibliographyParagraph(par, pend);
                        par = makeParagraphBibliography(buf, xs, ourparams, text, par, send);
                        break;
+               }
+               case LATEX_PARAGRAPH: {
+                       send = findLastParagraph(par, pend);
+                       par = makeParagraphs(buf, xs, ourparams, text, par, send);
+                       break;
+               }
        }
 
        return make_pair(par, send);
@@ -768,34 +764,15 @@ DocBookDocumentSectioning hasDocumentSectioning(ParagraphList const &paragraphs,
 }
 
 
-bool hasOnlyNotes(Paragraph const & par)
-{
-       for (int i = 0; i < par.size(); ++i)
-               if (!par.isInset(i) || !dynamic_cast<InsetNote *>(par.insetList().get(i)))
-                       return false;
-       return true;
-}
-
-
-DocBookInfoTag getParagraphsWithInfo(ParagraphList const &paragraphs, pit_type bpit, pit_type const epit) {
+DocBookInfoTag getParagraphsWithInfo(ParagraphList const &paragraphs, pit_type const bpit, pit_type const epit) {
        set<pit_type> shouldBeInInfo;
        set<pit_type> mustBeInInfo;
 
-       // Find the first non empty paragraph by mutating bpit.
-       while (bpit < epit) {
-               Paragraph const &par = paragraphs[bpit];
-               if (par.empty() || hasOnlyNotes(par))
-                       bpit += 1;
-               else
-                       break;
-       }
-
-       // Find the last info-like paragraph.
        pit_type cpit = bpit;
        while (cpit < epit) {
                // Skip paragraphs only containing one note.
                Paragraph const &par = paragraphs[cpit];
-               if (hasOnlyNotes(par)) {
+               if (par.size() == 1 && dynamic_cast<InsetNote*>(paragraphs[cpit].insetList().get(0))) {
                        cpit += 1;
                        continue;
                }