Fix math cursor positioning bug

[lyx.git] / src / mathed / math_symbolinset.C

diff --git a/src/mathed/math_symbolinset.C b/src/mathed/math_symbolinset.C
index 272c38861dd09be9e9e0bddbf1a1e9f6c2dcc78c..2d07bd6240e7cca2e9b7e97887598dbb552b7805 100644 (file)
--- a/src/mathed/math_symbolinset.C
+++ b/src/mathed/math_symbolinset.C
@@ -1,20 +1,36 @@
+/**
+ * \file math_symbolinset.C
+ * This file is part of LyX, the document processor.
+ * Licence details can be found in the file COPYING.
+ *
+ * \author André Pönitz
+ *
+ * Full author contact details are available in file CREDITS.
+ */
 
 #include <config.h>
 
 #include "math_symbolinset.h"
+#include "dimension.h"
 #include "math_mathmlstream.h"
 #include "math_streamstr.h"
 #include "math_support.h"
 #include "math_parser.h"
+#include "math_atom.h"
 #include "LaTeXFeatures.h"
 #include "debug.h"
 
-MathSymbolInset::MathSymbolInset(const latexkeys * l)
+
+using std::string;
+using std::auto_ptr;
+
+
+MathSymbolInset::MathSymbolInset(latexkeys const * l)
        : sym_(l), h_(0)
 {}
 
 
-MathSymbolInset::MathSymbolInset(const char * name)
+MathSymbolInset::MathSymbolInset(char const * name)
        : sym_(in_word_set(name)), h_(0)
 {}
 
@@ -24,10 +40,9 @@ MathSymbolInset::MathSymbolInset(string const & name)
 {}
 
 
-
-MathInset * MathSymbolInset::clone() const
+auto_ptr<InsetBase> MathSymbolInset::doClone() const
 {
-       return new MathSymbolInset(*this);
+       return auto_ptr<InsetBase>(new MathSymbolInset(*this));
 }
 
 
@@ -37,48 +52,63 @@ string MathSymbolInset::name() const
 }
 
 
-void MathSymbolInset::metrics(MathMetricsInfo & mi) const
+void MathSymbolInset::metrics(MetricsInfo & mi, Dimension & dim) const
 {
        //lyxerr << "metrics: symbol: '" << sym_->name
        //      << "' in font: '" << sym_->inset
        //      << "' drawn as: '" << sym_->draw
-       //      << "'\n";
+       //      << "'" << std::endl;
 
        int const em = mathed_char_width(mi.base.font, 'M');
-       MathFontSetChanger dummy(mi.base, sym_->inset.c_str());
-       mathed_string_dim(mi.base.font, sym_->draw, dim_);
+       FontSetChanger dummy(mi.base, sym_->inset.c_str());
+       mathed_string_dim(mi.base.font, sym_->draw, dim);
        // correct height for broken cmex and wasy font
+#if defined(__APPLE__) && defined(__GNUC__)
+       if (sym_->inset == "cmex") {
+               h_ = 4 * dim.des / 5;
+               dim.asc += 0*h_;
+               dim.des -= h_;
+               h_ = dim.asc;
+       } else if (sym_->inset == "wasy") {
+               h_ = 4 * dim.des / 5;
+               dim.asc += h_;
+               dim.des -= h_;
+       }
+#else
        if (sym_->inset == "cmex" || sym_->inset == "wasy") {
-               h_ = 4 * dim_.d / 5;
-               dim_.a += h_;
-               dim_.d -= h_;
+               h_ = 4 * dim.des / 5;
+               dim.asc += h_;
+               dim.des -= h_;
        }
+#endif
        // seperate things a bit
        if (isRelOp())
-               dim_.w += static_cast<int>(0.5*em+0.5);
+               dim.wid += static_cast<int>(0.5 * em + 0.5);
        else
-               dim_.w += static_cast<int>(0.1667*em+0.5);
+               dim.wid += static_cast<int>(0.1667 * em + 0.5);
 
        scriptable_ = false;
        if (mi.base.style == LM_ST_DISPLAY)
                if (sym_->inset == "cmex" || sym_->extra == "funclim")
                        scriptable_ = true;
+
+       width_ = dim.wid;
 }
 
 
-void MathSymbolInset::draw(MathPainterInfo & pi, int x, int y) const
+void MathSymbolInset::draw(PainterInfo & pi, int x, int y) const
 {
        //lyxerr << "metrics: symbol: '" << sym_->name
        //      << "' in font: '" << sym_->inset
        //      << "' drawn as: '" << sym_->draw
-       //      << "'\n";
+       //      << "'" << std::endl;
        int const em = mathed_char_width(pi.base.font, 'M');
        if (isRelOp())
                x += static_cast<int>(0.25*em+0.5);
        else
                x += static_cast<int>(0.0833*em+0.5);
 
-       MathFontSetChanger dummy(pi.base, sym_->inset.c_str());
+       FontSetChanger dummy(pi.base, sym_->inset.c_str());
        drawStr(pi, pi.base.font, x, y - h_, sym_->draw);
 }
 
@@ -108,6 +138,8 @@ void MathSymbolInset::validate(LaTeXFeatures & features) const
 {
        if (sym_->inset == "msa" || sym_->inset == "msb")
                features.require("amssymb");
+       else if (sym_->inset == "wasy")
+               features.require("wasysym");
 }
 
 
@@ -154,13 +186,6 @@ char const * MathMLtype(string const & s)
 }
 
 
-bool MathSymbolInset::match(MathAtom const & at) const
-{
-       MathSymbolInset const * q = at->asSymbolInset();
-       return q && name() == q->name();
-}
-
-
 void MathSymbolInset::mathmlize(MathMLStream & os) const
 {
        char const * type = MathMLtype(sym_->extra);