]> git.lyx.org Git - lyx.git/blobdiff - src/mathed/math_gridinset.C
Andreas' patch to prevent crash on click on previewd inset
[lyx.git] / src / mathed / math_gridinset.C
index a07aaf39a0f4bc83a90f30a511d6ec9abc555f8b..c9fcfcc5141aad10451d4638a5405db61aec1113 100644 (file)
@@ -478,22 +478,29 @@ void MathGridInset::metrics(MetricsInfo & mi, Dimension & dim) const
 
 
 void MathGridInset::draw(PainterInfo & pi, int x, int y) const
+{
+       drawWithMargin(pi, x, y, 0, 0);
+}
+
+void MathGridInset::drawWithMargin(PainterInfo & pi, int x, int y,
+       int lmargin, int rmargin) const
 {
        for (idx_type idx = 0; idx < nargs(); ++idx)
-               cell(idx).draw(pi, x + cellXOffset(idx), y + cellYOffset(idx));
+               cell(idx).draw(pi, x + lmargin + cellXOffset(idx),
+                       y + cellYOffset(idx));
 
        for (row_type row = 0; row <= nrows(); ++row)
                for (unsigned int i = 0; i < rowinfo_[row].lines_; ++i) {
                        int yy = y + rowinfo_[row].offset_ - rowinfo_[row].ascent_
                                - i * hlinesep() - hlinesep()/2 - rowsep()/2;
-                       pi.pain.line(x + 1, yy,
-                                    x + dim_.width() - 1, yy,
+                       pi.pain.line(x + lmargin + 1, yy,
+                                    x + dim_.width() - rmargin - 1, yy,
                                     LColor::foreground);
                }
 
        for (col_type col = 0; col <= ncols(); ++col)
                for (unsigned int i = 0; i < colinfo_[col].lines_; ++i) {
-                       int xx = x + colinfo_[col].offset_
+                       int xx = x + lmargin + colinfo_[col].offset_
                                - i * vlinesep() - vlinesep()/2 - colsep()/2;
                        pi.pain.line(xx, y - dim_.ascent() + 1,
                                     xx, y + dim_.descent() - 1,
@@ -769,11 +776,11 @@ int MathGridInset::cellYOffset(idx_type idx) const
 bool MathGridInset::idxUpDown(LCursor & cur, bool up) const
 {
        if (up) {
-               if (cur.idx() < ncols())
+               if (cur.row() == 0)
                        return false;
                cur.idx() -= ncols();
        } else {
-               if (cur.idx() >= ncols() * (nrows() - 1))
+               if (cur.row() + 1 >= nrows())
                        return false;
                cur.idx() += ncols();
        }
@@ -1033,7 +1040,12 @@ void MathGridInset::doDispatch(LCursor & cur, FuncRequest & cmd)
 
        // insert file functions
        case LFUN_DELETE_LINE_FORWARD:
-               recordUndo(cur);
+               // FIXME: We use recordUndoInset when a change reflects more
+               // than one cell, because recordUndo does not work for
+               // multiple cells. Unfortunately this puts the cursor in front
+               // of the inset after undo. This is (especilally for large
+               // grids) annoying.
+               recordUndoInset(cur);
                //autocorrect_ = false;
                //macroModeClose();
                //if (selection_) {
@@ -1053,8 +1065,27 @@ void MathGridInset::doDispatch(LCursor & cur, FuncRequest & cmd)
                splitCell(cur);
                break;
 
+       case LFUN_CELL_BACKWARD:
+               // See below.
+               cur.selection() = false;
+               if (!idxPrev(cur)) {
+                       cmd = FuncRequest(LFUN_FINISHED_LEFT);
+                       cur.undispatched();
+               }
+               break;
+       
+       case LFUN_CELL_FORWARD:
+               // Can't handle selection by additional 'shift' as this is
+               // hard bound to LFUN_CELL_BACKWARD
+               cur.selection() = false;
+               if (!idxNext(cur)) {
+                       cmd = FuncRequest(LFUN_FINISHED_RIGHT);
+                       cur.undispatched();
+               }
+               break;
+
        case LFUN_BREAKLINE: {
-               recordUndo(cur);
+               recordUndoInset(cur);
                row_type const r = cur.row();
                addRow(r);
 
@@ -1075,7 +1106,7 @@ void MathGridInset::doDispatch(LCursor & cur, FuncRequest & cmd)
        }
 
        case LFUN_TABULAR_FEATURE: {
-               recordUndo(cur);
+               recordUndoInset(cur);
                //lyxerr << "handling tabular-feature " << cmd.argument << endl;
                istringstream is(cmd.argument);
                string s;
@@ -1101,11 +1132,21 @@ void MathGridInset::doDispatch(LCursor & cur, FuncRequest & cmd)
                                if (cur.idx() > nargs())
                                        cur.idx() -= ncols();
                        }
-               else if (s == "copy-row")
+               else if (s == "copy-row") {
+                       // Here (as later) we save the cursor col/row 
+                       // in order to restore it after operation. 
+                       row_type const r = cur.row();
+                       col_type const c = cur.col();
                        for (int i = 0, n = extractInt(is); i < n; ++i)
                                copyRow(cur.row());
-               else if (s == "swap-row")
+                       cur.idx() = index(r, c);
+               }
+               else if (s == "swap-row") {
                        swapRow(cur.row());
+                       // Trick to suppress same-idx-means-different-cell 
+                       // assertion crash:
+                       cur.pos() = 0; 
+               }
                else if (s == "add-hline-above")
                        rowinfo_[cur.row()].lines_++;
                else if (s == "add-hline-below")
@@ -1114,30 +1155,34 @@ void MathGridInset::doDispatch(LCursor & cur, FuncRequest & cmd)
                        rowinfo_[cur.row()].lines_--;
                else if (s == "delete-hline-below")
                        rowinfo_[cur.row()+1].lines_--;
-               else if (s == "append-column")
-                       for (int i = 0, n = extractInt(is); i < n; ++i) {
-                               row_type const r = cur.row();
-                               col_type const c = cur.col();
-                               addCol(c);
-                               cur.idx() = index(r, c);
-                       }
-               else if (s == "delete-column")
-                       for (int i = 0, n = extractInt(is); i < n; ++i) {
-                               row_type const r = cur.row();
-                               col_type const c = cur.col();
+               else if (s == "append-column") {
+                       row_type const r = cur.row();
+                       col_type const c = cur.col();
+                       for (int i = 0, n = extractInt(is); i < n; ++i)
+                               addCol(cur.col());
+                       cur.idx() = index(r, c);
+               }
+               else if (s == "delete-column") {
+                       row_type const r = cur.row();
+                       col_type const c = cur.col();
+                       for (int i = 0, n = extractInt(is); i < n; ++i)
                                delCol(col(cur.idx()));
-                               cur.idx() = index(r, c);
-                               if (cur.idx() > nargs())
-                                       cur.idx() -= ncols();
-                       }
-               else if (s == "copy-column")
+                       cur.idx() = index(r, min(c, cur.ncols() - 1));
+               }
+               else if (s == "copy-column") {
+                       row_type const r = cur.row();
+                       col_type const c = cur.col();
                        copyCol(cur.col());
-               else if (s == "swap-column")
+                       cur.idx() = index(r, c);
+               }
+               else if (s == "swap-column") {
                        swapCol(cur.col());
+                       cur.pos() = 0; // trick, see above
+               }
                else if (s == "add-vline-left")
-                       colinfo_[cur.col()].lines_++;                   
+                       colinfo_[cur.col()].lines_++;
                else if (s == "add-vline-right")
-                       colinfo_[cur.col()+1].lines_++;                 
+                       colinfo_[cur.col()+1].lines_++;
                else if (s == "delete-vline-left")
                        colinfo_[cur.col()].lines_--;
                else if (s == "delete-vline-right")
@@ -1151,7 +1196,6 @@ void MathGridInset::doDispatch(LCursor & cur, FuncRequest & cmd)
        }
 
        case LFUN_PASTE: {
-               recordUndo(cur);
                lyxerr << "MathGridInset: PASTE: " << cmd << std::endl;
                istringstream is(cmd.argument);
                int n = 0;
@@ -1160,10 +1204,12 @@ void MathGridInset::doDispatch(LCursor & cur, FuncRequest & cmd)
                mathed_parse_normal(grid, lyx::cap::getSelection(cur.buffer(), n));
                if (grid.nargs() == 1) {
                        // single cell/part of cell
+                       recordUndo(cur);
                        cur.cell().insert(cur.pos(), grid.cell(0));
                        cur.pos() += grid.cell(0).size();
                } else {
                        // multiple cells
+                       recordUndoInset(cur);
                        col_type const numcols =
                                min(grid.ncols(), ncols() - col(cur.idx()));
                        row_type const numrows =
@@ -1203,6 +1249,7 @@ void MathGridInset::doDispatch(LCursor & cur, FuncRequest & cmd)
                        cur.pos() = 0;
                } else {
                        cmd = FuncRequest(LFUN_FINISHED_LEFT);
+                       cur.undispatched();
                }
                break;
 
@@ -1223,6 +1270,7 @@ void MathGridInset::doDispatch(LCursor & cur, FuncRequest & cmd)
                        cur.pos() = cur.lastpos();
                } else {
                        cmd = FuncRequest(LFUN_FINISHED_RIGHT);
+                       cur.undispatched();
                }
                break;
 
@@ -1233,30 +1281,28 @@ void MathGridInset::doDispatch(LCursor & cur, FuncRequest & cmd)
 
 
 bool MathGridInset::getStatus(LCursor & cur, FuncRequest const & cmd,
-               FuncStatus & flag) const
+               FuncStatus & status) const
 {
        switch (cmd.action) {
        case LFUN_TABULAR_FEATURE: {
-               istringstream is(cmd.argument);
-               string s;
-               is >> s;
+               string const s = cmd.argument;
                if (nrows() <= 1 && (s == "delete-row" || s == "swap-row")) {
-                       flag.enabled(false);
-                       flag.message(N_("Only one row"));
+                       status.enabled(false);
+                       status.message(N_("Only one row"));
                        return true;
                }
                if (ncols() <= 1 &&
                    (s == "delete-column" || s == "swap-column")) {
-                       flag.enabled(false);
-                       flag.message(N_("Only one column"));
+                       status.enabled(false);
+                       status.message(N_("Only one column"));
                        return true;
                }
                if ((rowinfo_[cur.row()].lines_ == 0 &&
                     s == "delete-hline-above") ||
                    (rowinfo_[cur.row() + 1].lines_ == 0 &&
                     s == "delete-hline-below")) {
-                       flag.enabled(false);
-                       flag.message(N_("No hline to delete"));
+                       status.enabled(false);
+                       status.message(N_("No hline to delete"));
                        return true;
                }
 
@@ -1264,8 +1310,8 @@ bool MathGridInset::getStatus(LCursor & cur, FuncRequest const & cmd,
                     s == "delete-vline-left") ||
                    (colinfo_[cur.col() + 1].lines_ == 0 &&
                     s == "delete-vline-right")) {
-                       flag.enabled(false);
-                       flag.message(N_("No vline to delete"));
+                       status.enabled(false);
+                       status.message(N_("No vline to delete"));
                        return true;
                }
                if (s == "valign-top" || s == "valign-middle" ||
@@ -1279,34 +1325,52 @@ bool MathGridInset::getStatus(LCursor & cur, FuncRequest const & cmd,
                    s == "copy-column" || s == "swap-column" ||
                    s == "add-vline-left" || s == "add-vline-right" ||
                    s == "delete-vline-left" || s == "delete-vline-right")
-                       flag.enabled(true);
+                       status.enabled(true);
                else {
-                       flag.enabled(false);
-                       flag.message(bformat(
+                       status.enabled(false);
+                       status.message(bformat(
                                N_("Unknown tabular feature '%1$s'"), s));
                }
+
+               status.setOnOff(s == "align-left"    && halign(cur.col()) == 'l'
+                          || s == "align-right"   && halign(cur.col()) == 'r'
+                          || s == "align-center"  && halign(cur.col()) == 'c'
+                          || s == "valign-top"    && valign() == 't'
+                          || s == "valign-bottom" && valign() == 'b'
+                          || s == "valign-middle" && valign() == 'm');
+
 #if 0
                // FIXME: What did this code do?
-               // Please check wether it is still needed!
+               // Please check whether it is still needed!
                // should be more precise
                if (v_align_ == '\0') {
-                       flag.enable(true);
+                       status.enable(true);
                        break;
                }
                if (cmd.argument.empty()) {
-                       flag.enable(false);
+                       status.enable(false);
                        break;
                }
                if (!lyx::support::contains("tcb", cmd.argument[0])) {
-                       flag.enable(false);
+                       status.enable(false);
                        break;
                }
-               flag.setOnOff(cmd.argument[0] == v_align_);
-               flag.enabled(true);
+               status.setOnOff(cmd.argument[0] == v_align_);
+               status.enabled(true);
 #endif
                return true;
        }
+
+       case LFUN_CELL_SPLIT:
+               status.enabled(true);
+               return true;
+
+       case LFUN_CELL_BACKWARD:
+       case LFUN_CELL_FORWARD:
+               status.enabled(true);
+               return true;
+
        default:
-               return MathNestInset::getStatus(cur, cmd, flag);
+               return MathNestInset::getStatus(cur, cmd, status);
        }
 }