]> git.lyx.org Git - features.git/blobdiff - src/mathed/formulabase.C
Replace LString.h with support/std_string.h,
[features.git] / src / mathed / formulabase.C
index 8bdb9e11ebcdbe27b1fb727c456be6ff753f0825..c50427587aff15045308bfaa425a397065a12262 100644 (file)
@@ -1,66 +1,52 @@
-/*
-*  File:        formulabase.C
-*  Purpose:     Implementation of common parts of the LyX  math insets
-*  Author:      Alejandro Aguilar Sierra <asierra@servidor.unam.mx>
-*  Created:     January 1996
-*
-*  Copyright: 1996-1998 Alejandro Aguilar Sierra
-*
-*  Version: 0.4, Lyx project.
-*
-*   You are free to use and modify this code under the terms of
-*   the GNU General Public Licence version 2 or later.
-*/
+/**
+ * \file formulabase.C
+ * This file is part of LyX, the document processor.
+ * Licence details can be found in the file COPYING.
+ *
+ * \author Alejandro Aguilar Sierra
+ * \author André Pönitz
+ *
+ * Full author contact details are available in file CREDITS.
+ */
 
 #include <config.h>
-#include <fstream>
 
-#include "Lsstream.h"
+#include "formulabase.h"
+#include "support/std_sstream.h"
 #include "support/LAssert.h"
-
-
 #include "formula.h"
 #include "formulamacro.h"
-#include "lyxrc.h"
 #include "funcrequest.h"
 #include "BufferView.h"
 #include "lyxtext.h"
 #include "gettext.h"
-#include "LaTeXFeatures.h"
 #include "debug.h"
 #include "math_support.h"
-#include "math_metricsinfo.h"
 #include "support/lstrings.h"
+#include "support/lyxlib.h"
 #include "frontends/LyXView.h"
-#include "frontends/font_metrics.h"
-#include "frontends/mouse_state.h"
-#include "Lsstream.h"
 #include "math_arrayinset.h"
-#include "math_charinset.h"
 #include "math_deliminset.h"
 #include "math_cursor.h"
 #include "math_factory.h"
-#include "math_fontinset.h"
 #include "math_hullinset.h"
-#include "math_iterator.h"
-#include "math_macrotable.h"
 #include "math_parser.h"
-#include "math_pos.h"
 #include "math_spaceinset.h"
 #include "undo_funcs.h"
-#include "textpainter.h"
 #include "frontends/Dialogs.h"
-#include "intl.h"
 #include "ref_inset.h"
 
+
+using namespace lyx::support;
+
 using std::endl;
 using std::ostream;
 using std::vector;
 using std::abs;
 using std::max;
 
-MathCursor * mathcursor = 0;
 
+MathCursor * mathcursor = 0;
 
 namespace {
 
@@ -68,15 +54,13 @@ namespace {
 int first_x;
 int first_y;
 
-
-
 bool openNewInset(BufferView * bv, UpdatableInset * new_inset)
 {
        if (!bv->insertInset(new_inset)) {
                delete new_inset;
                return false;
        }
-       new_inset->edit(bv, true);
+       new_inset->localDispatch(FuncRequest(bv, LFUN_INSET_EDIT, "left"));
        return true;
 }
 
@@ -86,14 +70,14 @@ bool openNewInset(BufferView * bv, UpdatableInset * new_inset)
 
 
 InsetFormulaBase::InsetFormulaBase()
-       : font_(), xo_(0), yo_(0)
+       : view_(0), xo_(0), yo_(0)
 {
        // This is needed as long the math parser is not re-entrant
        initMath();
-       //lyxerr << "sizeof MathInset: " << sizeof(MathInset) << "\n";
-       //lyxerr << "sizeof MathMetricsInfo: " << sizeof(MathMetricsInfo) << "\n";
-       //lyxerr << "sizeof MathCharInset: " << sizeof(MathCharInset) << "\n";
-       //lyxerr << "sizeof LyXFont: " << sizeof(LyXFont) << "\n";
+       //lyxerr << "sizeof MathInset: " << sizeof(MathInset) << endl;
+       //lyxerr << "sizeof MetricsInfo: " << sizeof(MetricsInfo) << endl;
+       //lyxerr << "sizeof MathCharInset: " << sizeof(MathCharInset) << endl;
+       //lyxerr << "sizeof LyXFont: " << sizeof(LyXFont) << endl;
 }
 
 
@@ -124,44 +108,25 @@ void InsetFormulaBase::handleFont
 {
        // this whole function is a hack and won't work for incremental font
        // changes...
-       bv->lockedInsetStoreUndo(Undo::EDIT);
-       if (mathcursor->par()->name() == font) {
+       recordUndo(bv, Undo::ATOMIC);
+
+       if (mathcursor->inset()->name() == font)
                mathcursor->handleFont(font);
-               updateLocal(bv, true);
-       } else {
-               bool sel = mathcursor->selection();
-               if (sel)
-                       updateLocal(bv, true);
+       else {
                mathcursor->handleNest(createMathInset(font));
                mathcursor->insert(arg);
-               if (!sel)
-                       updateLocal(bv, false);
        }
 }
 
 
-// Check if uses AMS macros
-void InsetFormulaBase::validate(LaTeXFeatures &) const
-{}
-
-
-void InsetFormulaBase::metrics(BufferView * bv, LyXFont const & f) const
+BufferView * InsetFormulaBase::view() const
 {
-       font_ = f;
-       metrics(bv);
+       return view_;
 }
 
 
-void InsetFormulaBase::metrics(BufferView * bv) const
-{
-       if (bv)
-               view_ = bv->owner()->view();
-       MathMetricsInfo mi;
-       mi.base.style = LM_ST_TEXT;
-       mi.base.font  = font_;
-       mi.base.font.setColor(LColor::math);
-       par()->metrics(mi);
-}
+void InsetFormulaBase::validate(LaTeXFeatures &) const
+{}
 
 
 string const InsetFormulaBase::editMessage() const
@@ -170,42 +135,23 @@ string const InsetFormulaBase::editMessage() const
 }
 
 
-void InsetFormulaBase::edit(BufferView * bv, int x, int y, mouse_button::state)
-{
-       if (!bv->lockInset(this))
-               lyxerr[Debug::MATHED] << "Cannot lock inset!!!" << endl;
-       releaseMathCursor(bv);
-       mathcursor = new MathCursor(this, true);
-       metrics(bv);
-       mathcursor->setPos(x + xo_, y + yo_);
-       // if that is removed, we won't get the magenta box when entering an
-       // inset for the first time
-       bv->updateInset(this, false);
-}
-
-
-void InsetFormulaBase::edit(BufferView * bv, bool front)
-{
-       if (!bv->lockInset(this))
-               lyxerr << "Cannot lock math inset in edit call!\n";
-       releaseMathCursor(bv);
-       mathcursor = new MathCursor(this, front);
-       metrics(bv);
-       bv->updateInset(this, false);
-}
-
-
 void InsetFormulaBase::insetUnlock(BufferView * bv)
 {
        if (mathcursor) {
                if (mathcursor->inMacroMode()) {
                        mathcursor->macroModeClose();
-                       updateLocal(bv, true);
+                       bv->updateInset(this);
                }
                releaseMathCursor(bv);
        }
        generatePreview();
-       bv->updateInset(this, false);
+       bv->updateInset(this);
+}
+
+
+void InsetFormulaBase::getCursor(BufferView &, int & x, int & y) const
+{
+       mathcursor->getPos(x, y);
 }
 
 
@@ -227,55 +173,14 @@ void InsetFormulaBase::getCursorPos(BufferView *, int & x, int & y) const
 }
 
 
-void InsetFormulaBase::toggleInsetCursor(BufferView * bv)
-{
-       if (!mathcursor) {
-               lyxerr[Debug::MATHED] << "toggleInsetCursor impossible" << endl;
-               return;
-       }
-       //lyxerr << "toggleInsetCursor: " << isCursorVisible() << endl;
-       if (isCursorVisible())
-               hideInsetCursor(bv);
-       else
-               showInsetCursor(bv);
-}
-
-
-void InsetFormulaBase::showInsetCursor(BufferView * bv, bool)
-{
-       if (!mathcursor) {
-               lyxerr << "showInsetCursor impossible" << endl;
-               return;
-       }
-       if (isCursorVisible())
-               return;
-       int x, y, asc, des;
-       mathcursor->getPos(x, y);
-       math_font_max_dim(font_, asc, des);
-       bv->showLockedInsetCursor(x, y - yo_, asc, des);
-       setCursorVisible(true);
-       //lyxerr << "showInsetCursor: " << x << ' ' << y << endl;
-}
-
-
-void InsetFormulaBase::hideInsetCursor(BufferView * bv)
-{
-       if (!mathcursor)
-               return;
-       if (!isCursorVisible())
-               return;
-       bv->hideLockedInsetCursor();
-       setCursorVisible(false);
-       //lyxerr << "hideInsetCursor: " << endl;
-}
-
-
 void InsetFormulaBase::fitInsetCursor(BufferView * bv) const
 {
        if (!mathcursor)
                return;
        int x, y, asc, des;
-       math_font_max_dim(font_, asc, des);
+       asc = 10;
+       des = 2;
+       //math_font_max_dim(font_, asc, des);
        getCursorPos(bv, x, y);
        //y += yo_;
        //lyxerr << "fitInsetCursor: x: " << x << " y: " << y << " yo: " << yo_ << endl;
@@ -286,19 +191,7 @@ void InsetFormulaBase::fitInsetCursor(BufferView * bv) const
 void InsetFormulaBase::toggleInsetSelection(BufferView * bv)
 {
        if (mathcursor)
-               bv->updateInset(this, false);
-}
-
-
-vector<string> const InsetFormulaBase::getLabelList() const
-{
-  return vector<string>();
-}
-
-
-void InsetFormulaBase::updateLocal(BufferView * bv, bool dirty)
-{
-       bv->updateInset(this, dirty);
+               bv->updateInset(this);
 }
 
 
@@ -308,9 +201,7 @@ dispatch_result InsetFormulaBase::lfunMouseRelease(FuncRequest const & cmd)
                return UNDISPATCHED;
 
        BufferView * bv = cmd.view();
-       hideInsetCursor(bv);
-       showInsetCursor(bv);
-       bv->updateInset(this, false);
+       bv->updateInset(this);
        //lyxerr << "lfunMouseRelease: buttons: " << cmd.button() << endl;
 
        if (cmd.button() == mouse_button::button3) {
@@ -318,16 +209,18 @@ dispatch_result InsetFormulaBase::lfunMouseRelease(FuncRequest const & cmd)
                if (mathcursor->dispatch(cmd) == UNDISPATCHED) {
                        // launch math panel for right mouse button
                        lyxerr << "lfunMouseRelease: undispatched: " << cmd.button() << endl;
-                       bv->owner()->getDialogs().showMathPanel();
+                       bv->owner()->getDialogs().show("mathpanel");
                }
                return DISPATCHED;
        }
 
        if (cmd.button() == mouse_button::button2) {
+               MathArray ar;
+               asArray(bv->getClipboard(), ar);
                mathcursor->selClear();
                mathcursor->setPos(cmd.x + xo_, cmd.y + yo_);
-               mathcursor->insert(asArray(bv->getClipboard()));
-               bv->updateInset(this, true);
+               mathcursor->insert(ar);
+               bv->updateInset(this);
                return DISPATCHED;
        }
 
@@ -356,7 +249,7 @@ dispatch_result InsetFormulaBase::lfunMousePress(FuncRequest const & cmd)
                lyxerr[Debug::MATHED] << "re-create cursor" << endl;
                releaseMathCursor(bv);
                mathcursor = new MathCursor(this, cmd.x == 0);
-               metrics(bv);
+               //metrics(bv);
                mathcursor->setPos(cmd.x + xo_, cmd.y + yo_);
        }
 
@@ -374,7 +267,7 @@ dispatch_result InsetFormulaBase::lfunMousePress(FuncRequest const & cmd)
                return DISPATCHED;
        }
 
-       bv->updateInset(this, false);
+       bv->updateInset(this);
        return DISPATCHED;
 }
 
@@ -401,10 +294,8 @@ dispatch_result InsetFormulaBase::lfunMouseMotion(FuncRequest const & cmd)
                mathcursor->selStart();
 
        BufferView * bv = cmd.view();
-       hideInsetCursor(bv);
        mathcursor->setPos(cmd.x + xo_, cmd.y + yo_);
-       showInsetCursor(bv);
-       bv->updateInset(this, false);
+       bv->updateInset(this);
        return DISPATCHED;
 }
 
@@ -417,20 +308,41 @@ dispatch_result InsetFormulaBase::localDispatch(FuncRequest const & cmd)
        //      << " y: '" << cmd.y
        //      << "' button: " << cmd.button() << endl;
 
+       BufferView * bv = cmd.view();
+
        // delete empty mathbox (LFUN_BACKSPACE and LFUN_DELETE)
        bool remove_inset = false;
 
        switch (cmd.action) {
+               case LFUN_INSET_EDIT:
+                       lyxerr << "Called EDIT with '" << cmd.argument << "'" << endl;
+                       if (!bv->lockInset(this))
+                               lyxerr << "Cannot lock math inset in edit call!" << endl;
+                       releaseMathCursor(bv);
+                       if (!cmd.argument.empty()) {
+                               mathcursor = new MathCursor(this, cmd.argument == "left");
+                               //metrics(bv);
+                       } else {
+                               mathcursor = new MathCursor(this, true);
+                               //metrics(bv);
+                               mathcursor->setPos(cmd.x + xo_, cmd.y + yo_);
+                       }
+                       // if that is removed, we won't get the magenta box when entering an
+                       // inset for the first time
+                       bv->updateInset(this);
+                       return DISPATCHED;
+
                case LFUN_MOUSE_PRESS:
-                       //lyxerr << "Mouse single press\n";
+                       //lyxerr << "Mouse single press" << endl;
                        return lfunMousePress(cmd);
                case LFUN_MOUSE_MOTION:
-                       //return lfunMouseMotion(cmd);
+                       //lyxerr << "Mouse motion" << endl;
+                       return lfunMouseMotion(cmd);
                case LFUN_MOUSE_RELEASE:
-                       //lyxerr << "Mouse single release\n";
+                       //lyxerr << "Mouse single release" << endl;
                        return lfunMouseRelease(cmd);
                case LFUN_MOUSE_DOUBLE:
-                       //lyxerr << "Mouse double\n";
+                       //lyxerr << "Mouse double" << endl;
                        return localDispatch(FuncRequest(LFUN_WORDSEL));
                default:
                        break;
@@ -439,15 +351,12 @@ dispatch_result InsetFormulaBase::localDispatch(FuncRequest const & cmd)
        if (!mathcursor)
                return UNDISPATCHED;
 
-       BufferView * bv    = cmd.view();
        string argument    = cmd.argument;
        RESULT result      = DISPATCHED;
        bool sel           = false;
        bool was_macro     = mathcursor->inMacroMode();
        bool was_selection = mathcursor->selection();
 
-       hideInsetCursor(bv);
-
        mathcursor->normalize();
        mathcursor->touch();
 
@@ -457,7 +366,7 @@ dispatch_result InsetFormulaBase::localDispatch(FuncRequest const & cmd)
        case LFUN_MATH_DISPLAY:
        case LFUN_MATH_NUMBER:
        case LFUN_MATH_NONUMBER:
-       case LFUN_TABINSERT:
+       case LFUN_CELL_SPLIT:
        case LFUN_BREAKLINE:
        case LFUN_DELETE_LINE_FORWARD:
        case LFUN_INSERT_LABEL:
@@ -465,18 +374,16 @@ dispatch_result InsetFormulaBase::localDispatch(FuncRequest const & cmd)
        case LFUN_TABULAR_FEATURE:
        case LFUN_PASTESELECTION:
        case LFUN_MATH_LIMITS:
-               bv->lockedInsetStoreUndo(Undo::EDIT);
+               recordUndo(bv, Undo::ATOMIC);
                mathcursor->dispatch(cmd);
-               updateLocal(bv, true);
                break;
 
        case LFUN_RIGHTSEL:
                sel = true; // fall through...
        case LFUN_RIGHT:
                result = mathcursor->right(sel) ? DISPATCHED : FINISHED_RIGHT;
-               //lyxerr << "calling scroll 20\n";
+               //lyxerr << "calling scroll 20" << endl;
                //scroll(bv, 20);
-               updateLocal(bv, false);
                // write something to the minibuffer
                //bv->owner()->message(mathcursor->info());
                break;
@@ -485,27 +392,23 @@ dispatch_result InsetFormulaBase::localDispatch(FuncRequest const & cmd)
                sel = true; // fall through
        case LFUN_LEFT:
                result = mathcursor->left(sel) ? DISPATCHED : FINISHED;
-               updateLocal(bv, false);
                break;
 
        case LFUN_UPSEL:
                sel = true; // fall through
        case LFUN_UP:
                result = mathcursor->up(sel) ? DISPATCHED : FINISHED_UP;
-               updateLocal(bv, false);
                break;
 
        case LFUN_DOWNSEL:
                sel = true; // fall through
        case LFUN_DOWN:
                result = mathcursor->down(sel) ? DISPATCHED : FINISHED_DOWN;
-               updateLocal(bv, false);
                break;
 
        case LFUN_WORDSEL:
                mathcursor->home(false);
                mathcursor->end(true);
-               updateLocal(bv, false);
                break;
 
        case LFUN_UP_PARAGRAPHSEL:
@@ -513,7 +416,6 @@ dispatch_result InsetFormulaBase::localDispatch(FuncRequest const & cmd)
        case LFUN_DOWN_PARAGRAPHSEL:
        case LFUN_DOWN_PARAGRAPH:
                result = FINISHED;
-               updateLocal(bv, false);
                break;
 
        case LFUN_HOMESEL:
@@ -522,7 +424,6 @@ dispatch_result InsetFormulaBase::localDispatch(FuncRequest const & cmd)
        case LFUN_HOME:
        case LFUN_WORDLEFT:
                result = mathcursor->home(sel) ? DISPATCHED : FINISHED;
-               updateLocal(bv, false);
                break;
 
        case LFUN_ENDSEL:
@@ -531,7 +432,6 @@ dispatch_result InsetFormulaBase::localDispatch(FuncRequest const & cmd)
        case LFUN_END:
        case LFUN_WORDRIGHT:
                result = mathcursor->end(sel) ? DISPATCHED : FINISHED_RIGHT;
-               updateLocal(bv, false);
                break;
 
        case LFUN_PRIORSEL:
@@ -539,7 +439,6 @@ dispatch_result InsetFormulaBase::localDispatch(FuncRequest const & cmd)
        case LFUN_BEGINNINGBUFSEL:
        case LFUN_BEGINNINGBUF:
                result = FINISHED;
-               updateLocal(bv, false);
                break;
 
        case LFUN_NEXTSEL:
@@ -547,41 +446,32 @@ dispatch_result InsetFormulaBase::localDispatch(FuncRequest const & cmd)
        case LFUN_ENDBUFSEL:
        case LFUN_ENDBUF:
                result = FINISHED_RIGHT;
-               updateLocal(bv, false);
                break;
 
-       case LFUN_TAB:
+       case LFUN_CELL_FORWARD:
                mathcursor->idxNext();
-               updateLocal(bv, false);
                break;
 
-       case LFUN_SHIFT_TAB:
+       case LFUN_CELL_BACKWARD:
                mathcursor->idxPrev();
-               updateLocal(bv, false);
                break;
 
        case LFUN_DELETE_WORD_BACKWARD:
        case LFUN_BACKSPACE:
-               bv->lockedInsetStoreUndo(Undo::EDIT);
-               if (mathcursor->backspace()) {
-                       result = DISPATCHED;
-               } else {
+               recordUndo(bv, Undo::ATOMIC);
+               if (!mathcursor->backspace()) {
                        result = FINISHED;
                        remove_inset = true;
                }
-               updateLocal(bv, true);
                break;
 
        case LFUN_DELETE_WORD_FORWARD:
        case LFUN_DELETE:
-               bv->lockedInsetStoreUndo(Undo::EDIT);
-               if (mathcursor->erase()) {
-                       result = DISPATCHED;
-               } else {
+               recordUndo(bv, Undo::ATOMIC);
+               if (!mathcursor->erase()) {
                        result = FINISHED;
                        remove_inset = true;
                }
-               updateLocal(bv, true);
                break;
 
        //    case LFUN_GETXY:
@@ -589,28 +479,29 @@ dispatch_result InsetFormulaBase::localDispatch(FuncRequest const & cmd)
        //      dispatch_result = dispatch_buffer;
        //      break;
        case LFUN_SETXY: {
-               lyxerr << "LFUN_SETXY broken!\n";
+               lyxerr << "LFUN_SETXY broken!" << endl;
                int x = 0;
                int y = 0;
                istringstream is(cmd.argument.c_str());
                is >> x >> y;
                mathcursor->setPos(x, y);
-               updateLocal(bv, false);
                break;
        }
 
-       case LFUN_PASTE:
+       case LFUN_PASTE: {
+               size_t n = 0;
+               istringstream is(cmd.argument.c_str());
+               is >> n;
                if (was_macro)
                        mathcursor->macroModeClose();
-               bv->lockedInsetStoreUndo(Undo::EDIT);
-               mathcursor->selPaste();
-               updateLocal(bv, true);
+               recordUndo(bv, Undo::ATOMIC);
+               mathcursor->selPaste(n);
                break;
+       }
 
        case LFUN_CUT:
-               bv->lockedInsetStoreUndo(Undo::DELETE);
+               recordUndo(bv, Undo::DELETE);
                mathcursor->selCut();
-               updateLocal(bv, true);
                break;
 
        case LFUN_COPY:
@@ -624,9 +515,8 @@ dispatch_result InsetFormulaBase::localDispatch(FuncRequest const & cmd)
                if (cmd.argument.empty()) {
                        // do superscript if LyX handles
                        // deadkeys
-                       bv->lockedInsetStoreUndo(Undo::EDIT);
+                       recordUndo(bv, Undo::ATOMIC);
                        mathcursor->script(true);
-                       updateLocal(bv, true);
                }
                break;
 
@@ -647,7 +537,6 @@ dispatch_result InsetFormulaBase::localDispatch(FuncRequest const & cmd)
                break;
 
        //  Math fonts
-       case LFUN_GREEK_TOGGLE: handleFont(bv, cmd.argument, "lyxgreek"); break;
        case LFUN_BOLD:         handleFont(bv, cmd.argument, "mathbf"); break;
        case LFUN_SANS:         handleFont(bv, cmd.argument, "mathsf"); break;
        case LFUN_EMPH:         handleFont(bv, cmd.argument, "mathcal"); break;
@@ -656,37 +545,28 @@ dispatch_result InsetFormulaBase::localDispatch(FuncRequest const & cmd)
        case LFUN_FRAK:         handleFont(bv, cmd.argument, "mathfrak"); break;
        case LFUN_ITAL:         handleFont(bv, cmd.argument, "mathit"); break;
        case LFUN_NOUN:         handleFont(bv, cmd.argument, "mathbb"); break;
-       case LFUN_FREE:         handleFont(bv, cmd.argument, "textrm"); break;
+       case LFUN_FREEFONT_APPLY:  handleFont(bv, cmd.argument, "textrm"); break;
        case LFUN_DEFAULT:      handleFont(bv, cmd.argument, "textnormal"); break;
 
-       case LFUN_GREEK:
-               handleFont(bv, cmd.argument, "lyxgreek1");
-               if (cmd.argument.size())
-                       mathcursor->insert(asArray(cmd.argument));
-               break;
-
        case LFUN_MATH_MODE:
-               if (mathcursor->currentMode() == MathInset::TEXT_MODE) {
+               if (mathcursor->currentMode() == MathInset::TEXT_MODE)
                        mathcursor->niceInsert(MathAtom(new MathHullInset("simple")));
-                       updateLocal(bv, true);
-               } else {
+               else
                        handleFont(bv, cmd.argument, "textrm");
-               }
                //bv->owner()->message(_("math text mode toggled"));
                break;
 
        case LFUN_MATH_SIZE:
 #if 0
                if (!arg.empty()) {
-                       bv->lockedInsetStoreUndo(Undo::EDIT);
+                       recordUndo(bv, Undo::ATOMIC);
                        mathcursor->setSize(arg);
-                       updateLocal(bv, true);
                }
 #endif
                break;
 
        case LFUN_INSERT_MATRIX: {
-               bv->lockedInsetStoreUndo(Undo::EDIT);
+               recordUndo(bv, Undo::ATOMIC);
                unsigned int m = 1;
                unsigned int n = 1;
                string v_align;
@@ -698,22 +578,20 @@ dispatch_result InsetFormulaBase::localDispatch(FuncRequest const & cmd)
                v_align += 'c';
                mathcursor->niceInsert(
                        MathAtom(new MathArrayInset("array", m, n, v_align[0], h_align)));
-                       updateLocal(bv, true);
                break;
        }
 
        case LFUN_SUPERSCRIPT:
        case LFUN_SUBSCRIPT:
        {
-               bv->lockedInsetStoreUndo(Undo::EDIT);
+               recordUndo(bv, Undo::ATOMIC);
                mathcursor->script(cmd.action == LFUN_SUPERSCRIPT);
-               updateLocal(bv, true);
                break;
        }
 
        case LFUN_MATH_DELIM:
        {
-               //lyxerr << "formulabase::LFUN_MATH_DELIM, arg: '" << arg << "'\n";
+               //lyxerr << "formulabase::LFUN_MATH_DELIM, arg: '" << arg << "'" << endl;
                string ls;
                string rs = split(cmd.argument, ls, ' ');
                // Reasonable default values
@@ -722,17 +600,15 @@ dispatch_result InsetFormulaBase::localDispatch(FuncRequest const & cmd)
                if (rs.empty())
                        rs = ')';
 
-               bv->lockedInsetStoreUndo(Undo::EDIT);
+               recordUndo(bv, Undo::ATOMIC);
                mathcursor->handleNest(MathAtom(new MathDelimInset(ls, rs)));
-               updateLocal(bv, true);
                break;
        }
 
-       case LFUN_PROTECTEDSPACE:
+       case LFUN_SPACE_INSERT:
        case LFUN_MATH_SPACE:
-               bv->lockedInsetStoreUndo(Undo::EDIT);
+               recordUndo(bv, Undo::ATOMIC);
                mathcursor->insert(MathAtom(new MathSpaceInset(",")));
-               updateLocal(bv, true);
                break;
 
        case LFUN_UNDO:
@@ -746,9 +622,8 @@ dispatch_result InsetFormulaBase::localDispatch(FuncRequest const & cmd)
 
        case LFUN_INSET_ERT:
                // interpret this as if a backslash was typed
-               bv->lockedInsetStoreUndo(Undo::EDIT);
+               recordUndo(bv, Undo::ATOMIC);
                mathcursor->interpret('\\');
-               updateLocal(bv, true);
                break;
 
        case LFUN_BREAKPARAGRAPH:
@@ -761,27 +636,21 @@ dispatch_result InsetFormulaBase::localDispatch(FuncRequest const & cmd)
 // handling such that "self-insert" works on "arbitrary stuff" too, and
 // math-insert only handles special math things like "matrix".
        case LFUN_INSERT_MATH:
-               bv->lockedInsetStoreUndo(Undo::EDIT);
+               recordUndo(bv, Undo::ATOMIC);
                mathcursor->niceInsert(argument);
-               updateLocal(bv, true);
                break;
 
        case -1:
        case LFUN_SELFINSERT:
                if (!argument.empty()) {
-                       bv->lockedInsetStoreUndo(Undo::EDIT);
+                       recordUndo(bv, Undo::ATOMIC);
                        if (argument.size() == 1)
                                result = mathcursor->interpret(argument[0]) ? DISPATCHED : FINISHED_RIGHT;
                        else
-                               mathcursor->insert(asArray(argument));
-                       updateLocal(bv, true);
+                               mathcursor->insert(argument);
                }
                break;
 
-       case LFUN_MATH_PANEL:
-               result = UNDISPATCHED;
-               break;
-
        case LFUN_ESCAPE:
                if (mathcursor->selection())
                        mathcursor->selClear();
@@ -791,23 +660,31 @@ dispatch_result InsetFormulaBase::localDispatch(FuncRequest const & cmd)
 
        case LFUN_INSET_TOGGLE:
                mathcursor->insetToggle();
-               updateLocal(bv, true);
+               break;
+
+       case LFUN_DIALOG_SHOW:
+               result = UNDISPATCHED;
                break;
 
        case LFUN_DIALOG_SHOW_NEW_INSET: {
                string const & name = argument;
+               string data;
                if (name == "ref") {
-                       RefInset tmp;
-                       string const data = tmp.createDialogStr(name);
-                       bv->owner()->getDialogs().show(name, data, 0);
-               } else
+                       RefInset tmp(name);
+                       data = tmp.createDialogStr(name);
+               }
+
+               if (data.empty())
                        result = UNDISPATCHED;
+               else {
+                       bv->owner()->getDialogs().show(name, data, 0);
+               }
        }
        break;
 
        case LFUN_INSET_APPLY: {
                string const name = cmd.getArg(0);
-               InsetBase * base = 
+               InsetBase * base =
                        bv->owner()->getDialogs().getOpenInset(name);
 
                if (base) {
@@ -822,8 +699,6 @@ dispatch_result InsetFormulaBase::localDispatch(FuncRequest const & cmd)
                                result = UNDISPATCHED;
                        }
                }
-               if (result == DISPATCHED)
-                       updateLocal(bv, true);
        }
        break;
 
@@ -831,10 +706,13 @@ dispatch_result InsetFormulaBase::localDispatch(FuncRequest const & cmd)
                result = UNDISPATCHED;
        }
 
+       if (result == DISPATCHED)
+               bv->updateInset(this);
+
        mathcursor->normalize();
        mathcursor->touch();
 
-       lyx::Assert(mathcursor);
+       Assert(mathcursor);
 
        if (mathcursor->selection() || was_selection)
                toggleInsetSelection(bv);
@@ -842,7 +720,6 @@ dispatch_result InsetFormulaBase::localDispatch(FuncRequest const & cmd)
        if (result == DISPATCHED || result == DISPATCHED_NOUPDATE ||
            result == UNDISPATCHED) {
                fitInsetCursor(bv);
-               showInsetCursor(bv);
                revealCodes(bv);
                cmd.view()->stuffClipboard(mathcursor->grabSelection());
        } else {
@@ -891,21 +768,21 @@ void InsetFormulaBase::revealCodes(BufferView * bv) const
 }
 
 
-Inset::Code InsetFormulaBase::lyxCode() const
+InsetOld::Code InsetFormulaBase::lyxCode() const
 {
-       return Inset::MATH_CODE;
+       return InsetOld::MATH_CODE;
 }
 
 
 int InsetFormulaBase::ylow() const
 {
-       return yo_ - ascent(view(), font_);
+       return yo_ - dim_.asc;
 }
 
 
 int InsetFormulaBase::yhigh() const
 {
-       return yo_ + descent(view(), font_);
+       return yo_ + dim_.des;
 }
 
 
@@ -917,7 +794,7 @@ int InsetFormulaBase::xlow() const
 
 int InsetFormulaBase::xhigh() const
 {
-       return xo_ + width(view(), font_);
+       return xo_ + dim_.wid;
 }
 
 
@@ -936,7 +813,7 @@ bool InsetFormulaBase::searchForward(BufferView * bv, string const & str,
        static string laststr;
 
        if (lastformula != this || laststr != str) {
-               //lyxerr << "reset lastformula to " << this << "\n";
+               //lyxerr << "reset lastformula to " << this << endl;
                lastformula = this;
                laststr = str;
                current = ibegin(par().nucleus());
@@ -956,16 +833,16 @@ bool InsetFormulaBase::searchForward(BufferView * bv, string const & str,
                        }
                        delete mathcursor;
                        mathcursor = new MathCursor(this, true);
-                       metrics(bv);
+                       //metrics(bv);
                        mathcursor->setSelection(it, ar.size());
                        current = it;
                        it.jump(ar.size());
-                       updateLocal(bv, false);
+                       bv->updateInset(this);
                        return true;
                }
        }
 
-       //lyxerr << "not found!\n";
+       //lyxerr << "not found!" << endl;
        lastformula = 0;
        return false;
 }
@@ -974,7 +851,7 @@ bool InsetFormulaBase::searchForward(BufferView * bv, string const & str,
 bool InsetFormulaBase::searchBackward(BufferView * bv, string const & what,
                                      bool a, bool b)
 {
-       lyxerr[Debug::MATHED] << "searching backward not implemented in mathed\n";
+       lyxerr[Debug::MATHED] << "searching backward not implemented in mathed" << endl;
        return searchForward(bv, what, a, b);
 }
 
@@ -1002,7 +879,7 @@ void mathDispatchCreation(FuncRequest const & cmd, bool display)
        //      sel = "";
        //else
 
-       string sel = bv->getLyXText()->selectionAsString(bv->buffer(), false);
+       string sel = bv->getLyXText()->selectionAsString(*bv->buffer(), false);
 
        if (sel.empty()) {
                InsetFormula * f = new InsetFormula(bv);
@@ -1025,7 +902,7 @@ void mathDispatchCreation(FuncRequest const & cmd, bool display)
                        f = new InsetFormula(sel);
                else
                        f = new InsetFormulaMacro(sel);
-               bv->getLyXText()->cutSelection(bv);
+               bv->getLyXText()->cutSelection(true, false);
                openNewInset(bv, f);
        }
        cmd.message(N_("Math editor mode"));
@@ -1058,12 +935,13 @@ void mathDispatch(FuncRequest const & cmd)
                        else {
                                string s = cmd.argument;
                                string const s1 = token(s, ' ', 1);
-                               int const na = s1.empty() ? 0 : lyx::atoi(s1);
-                               openNewInset(bv, new InsetFormulaMacro(token(s, ' ', 0), na));
+                               int const nargs = s1.empty() ? 0 : atoi(s1);
+                               string const s2 = token(s, ' ', 2);
+                               string const type = s2.empty() ? "newcommand" : s2;
+                               openNewInset(bv, new InsetFormulaMacro(token(s, ' ', 0), nargs, s2));
                        }
                        break;
 
-               case LFUN_GREEK:
                case LFUN_INSERT_MATH:
                case LFUN_INSERT_MATRIX:
                case LFUN_MATH_DELIM: {
@@ -1075,6 +953,7 @@ void mathDispatch(FuncRequest const & cmd)
                        }
                        break;
                }
+
                default:
                        break;
        }