revert last patch. there's something wrong, possibly unrelated to this

[lyx.git] / src / mathed / MathMacro.cpp

diff --git a/src/mathed/MathMacro.cpp b/src/mathed/MathMacro.cpp
index 37c393e01014de2f76573dce245b8158efccd9eb..d84a64240209b97afdeb431f6d41288cfb49dc42 100644 (file)
--- a/src/mathed/MathMacro.cpp
+++ b/src/mathed/MathMacro.cpp
@@ -13,9 +13,11 @@
 #include <config.h>
 
 #include "MathMacro.h"
-#include "MathSupport.h"
+
+#include "MathCompletionList.h"
 #include "MathExtern.h"
 #include "MathStream.h"
+#include "MathSupport.h"
 
 #include "Buffer.h"
 #include "BufferView.h"
@@ -283,7 +285,7 @@ void MathMacro::updateMacro(MacroContext const & mc)
 }
 
 
-void MathMacro::updateRepresentation(Cursor const * bvCur)
+void MathMacro::updateRepresentation()
 {
        // known macro?
        if (macro_ == 0)
@@ -297,30 +299,30 @@ void MathMacro::updateRepresentation(Cursor const * bvCur)
                return;
 
        // macro changed?
-       if (needsUpdate_) {
-               needsUpdate_ = false;
-               
-               // get default values of macro
-               vector<docstring> const & defaults = macro_->defaults();
-               
-               // create MathMacroArgumentValue objects pointing to the cells of the macro
-               vector<MathData> values(nargs());
-               for (size_t i = 0; i < nargs(); ++i) {
-                       ArgumentProxy * proxy;
-                       if (i < defaults.size()) 
-                               proxy = new ArgumentProxy(*this, i, defaults[i]);
-                       else
-                               proxy = new ArgumentProxy(*this, i);
-                       values[i].insert(0, MathAtom(proxy));
-               }
-               
-               // expanding macro with the values
-               macro_->expand(values, expanded_.cell(0));
-
-               // get definition for list edit mode
-               docstring const & display = macro_->display();
-               asArray(display.empty() ? macro_->definition() : display, definition_);
+       if (!needsUpdate_)
+               return;
+       
+       needsUpdate_ = false;
+       
+       // get default values of macro
+       vector<docstring> const & defaults = macro_->defaults();
+       
+       // create MathMacroArgumentValue objects pointing to the cells of the macro
+       vector<MathData> values(nargs());
+       for (size_t i = 0; i < nargs(); ++i) {
+               ArgumentProxy * proxy;
+               if (i < defaults.size()) 
+                       proxy = new ArgumentProxy(*this, i, defaults[i]);
+               else
+                       proxy = new ArgumentProxy(*this, i);
+               values[i].insert(0, MathAtom(proxy));
        }
+       
+       // expanding macro with the values
+       macro_->expand(values, expanded_.cell(0));
+               // get definition for list edit mode
+       docstring const & display = macro_->display();
+       asArray(display.empty() ? macro_->definition() : display, definition_);
 }
 
 
@@ -515,6 +517,12 @@ void MathMacro::validate(LaTeXFeatures & features) const
 
        if (name() == "binom" || name() == "mathcircumflex")
                features.require(to_utf8(name()));
+       
+       // validate the cells and the definition
+       if (displayMode() == DISPLAY_NORMAL) {
+               definition_.validate(features);
+               InsetMathNest::validate(features);
+       }
 }
 
 
@@ -770,7 +778,7 @@ bool MathMacro::automaticPopupCompletion() const
 }
 
 
-Inset::CompletionList const * 
+CompletionList const * 
 MathMacro::createCompletionList(Cursor const & cur) const
 {
        if (displayMode() != DISPLAY_UNFOLDED)