]> git.lyx.org Git - lyx.git/blobdiff - src/mathed/InsetMathNest.cpp
Revert "Give a 2 pixels space for markers around math objects"
[lyx.git] / src / mathed / InsetMathNest.cpp
index 3794a58f607e6daec42931c6f0fa1ab1db1e5985..596e32aa006e9e2ddb413732fb77a2147cbdf7c9 100644 (file)
@@ -171,17 +171,19 @@ void InsetMathNest::cursorPos(BufferView const & bv,
 //             << " asc: " << ascent() << "  des: " << descent()
 //             << " ar.asc: " << ar.ascent() << " ar.des: " << ar.descent() << endl;
        // move cursor visually into empty cells ("blue rectangles");
-       if (ar.empty())
-               x += 2;
+       if (ar.empty()) {
+               Dimension const dim = coord_cache.getArrays().dim(&ar);
+               x += dim.wid / 3;
+       }
 }
 
 
-void InsetMathNest::metrics(MetricsInfo const & mi) const
+void InsetMathNest::cellsMetrics(MetricsInfo const & mi) const
 {
        MetricsInfo m = mi;
-       for (idx_type i = 0, n = nargs(); i != n; ++i) {
+       for (auto const & cell : cells_) {
                Dimension dim;
-               cell(i).metrics(m, dim);
+               cell.metrics(m, dim);
        }
 }
 
@@ -265,62 +267,13 @@ void InsetMathNest::dump() const
 }
 
 
-void InsetMathNest::draw(PainterInfo & pi, int x, int y) const
+void InsetMathNest::draw(PainterInfo &, int, int) const
 {
 #if 0
        if (lock_)
                pi.pain.fillRectangle(x, y - ascent(), width(), height(),
                                        Color_mathlockbg);
 #endif
-       setPosCache(pi, x, y);
-}
-
-
-void InsetMathNest::drawSelection(PainterInfo & pi, int x, int y) const
-{
-       BufferView & bv = *pi.base.bv;
-       // this should use the x/y values given, not the cached values
-       Cursor & cur = bv.cursor();
-       if (!cur.selection())
-               return;
-       if (&cur.inset() != this)
-               return;
-
-       // FIXME: hack to get position cache warm
-       bool const original_drawing_state = pi.pain.isDrawingEnabled();
-       pi.pain.setDrawingEnabled(false);
-       draw(pi, x, y);
-       pi.pain.setDrawingEnabled(original_drawing_state);
-
-       CursorSlice s1 = cur.selBegin();
-       CursorSlice s2 = cur.selEnd();
-
-       //lyxerr << "InsetMathNest::drawing selection: "
-       //      << " s1: " << s1 << " s2: " << s2 << endl;
-       if (s1.idx() == s2.idx()) {
-               MathData const & c = cell(s1.idx());
-               Geometry const & g = bv.coordCache().getArrays().geometry(&c);
-               int x1 = g.pos.x_ + c.pos2x(pi.base.bv, s1.pos());
-               int y1 = g.pos.y_ - g.dim.ascent();
-               int x2 = g.pos.x_ + c.pos2x(pi.base.bv, s2.pos());
-               int y2 = g.pos.y_ + g.dim.descent();
-               pi.pain.fillRectangle(x1, y1, x2 - x1, y2 - y1, Color_selection);
-       //lyxerr << "InsetMathNest::drawing selection 3: "
-       //      << " x1: " << x1 << " x2: " << x2
-       //      << " y1: " << y1 << " y2: " << y2 << endl;
-       } else {
-               for (idx_type i = 0; i < nargs(); ++i) {
-                       if (idxBetween(i, s1.idx(), s2.idx())) {
-                               MathData const & c = cell(i);
-                               Geometry const & g = bv.coordCache().getArrays().geometry(&c);
-                               int x1 = g.pos.x_;
-                               int y1 = g.pos.y_ - g.dim.ascent();
-                               int x2 = g.pos.x_ + g.dim.width();
-                               int y2 = g.pos.y_ + g.dim.descent();
-                               pi.pain.fillRectangle(x1, y1, x2 - x1, y2 - y1, Color_selection);
-                       }
-               }
-       }
 }
 
 
@@ -584,7 +537,7 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                parseflg |= Parse::VERBATIM;
                // fall through
        case LFUN_PASTE: {
-               if (cur.currentMode() <= TEXT_MODE)
+               if (cur.currentMode() != MATH_MODE)
                        parseflg |= Parse::TEXTMODE;
                cur.recordUndoSelection();
                cur.message(_("Paste"));
@@ -643,21 +596,42 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                cur.bv().cursor() = cur;
                break;
 
+       case LFUN_WORD_RIGHT:
+       case LFUN_WORD_LEFT:
+       case LFUN_WORD_BACKWARD:
+       case LFUN_WORD_FORWARD:
        case LFUN_CHAR_RIGHT:
        case LFUN_CHAR_LEFT:
        case LFUN_CHAR_BACKWARD:
        case LFUN_CHAR_FORWARD:
                cur.screenUpdateFlags(Update::Decoration | Update::FitCursor);
                // fall through
+       case LFUN_WORD_RIGHT_SELECT:
+       case LFUN_WORD_LEFT_SELECT:
+       case LFUN_WORD_BACKWARD_SELECT:
+       case LFUN_WORD_FORWARD_SELECT:
        case LFUN_CHAR_RIGHT_SELECT:
        case LFUN_CHAR_LEFT_SELECT:
        case LFUN_CHAR_BACKWARD_SELECT:
        case LFUN_CHAR_FORWARD_SELECT: {
                // are we in a selection?
-               bool select = (act == LFUN_CHAR_RIGHT_SELECT
+               bool select = (act == LFUN_WORD_RIGHT_SELECT
+                                          || act == LFUN_WORD_LEFT_SELECT
+                                          || act == LFUN_WORD_BACKWARD_SELECT
+                                          || act == LFUN_WORD_FORWARD_SELECT
+                              || act == LFUN_CHAR_RIGHT_SELECT
                                           || act == LFUN_CHAR_LEFT_SELECT
                                           || act == LFUN_CHAR_BACKWARD_SELECT
                                           || act == LFUN_CHAR_FORWARD_SELECT);
+               // select words
+               bool word = (act == LFUN_WORD_RIGHT_SELECT
+                            || act == LFUN_WORD_LEFT_SELECT
+                            || act == LFUN_WORD_BACKWARD_SELECT
+                            || act == LFUN_WORD_FORWARD_SELECT
+                            || act == LFUN_WORD_RIGHT
+                            || act == LFUN_WORD_LEFT
+                            || act == LFUN_WORD_BACKWARD
+                            || act == LFUN_WORD_FORWARD);
                // are we moving forward or backwards?
                // If the command was RIGHT or LEFT, then whether we're moving forward
                // or backwards depends on the cursor movement mode (logical or visual):
@@ -670,18 +644,24 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                FuncCode finish_lfun;
 
                if (act == LFUN_CHAR_FORWARD
-                               || act == LFUN_CHAR_FORWARD_SELECT) {
+                   || act == LFUN_CHAR_FORWARD_SELECT
+                   || act == LFUN_WORD_FORWARD
+                   || act == LFUN_WORD_FORWARD_SELECT) {
                        forward = true;
                        finish_lfun = LFUN_FINISHED_FORWARD;
                }
                else if (act == LFUN_CHAR_BACKWARD
-                               || act == LFUN_CHAR_BACKWARD_SELECT) {
+                        || act == LFUN_CHAR_BACKWARD_SELECT
+                        || act == LFUN_WORD_BACKWARD
+                        || act == LFUN_WORD_BACKWARD_SELECT) {
                        forward = false;
                        finish_lfun = LFUN_FINISHED_BACKWARD;
                }
                else {
                        bool right = (act == LFUN_CHAR_RIGHT_SELECT
-                                                 || act == LFUN_CHAR_RIGHT);
+                                                 || act == LFUN_CHAR_RIGHT
+                                     || act == LFUN_WORD_RIGHT_SELECT
+                                     || act == LFUN_WORD_RIGHT);
                        if (lyxrc.visual_cursor || !cur.reverseDirectionNeeded())
                                forward = right;
                        else
@@ -697,7 +677,7 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                cur.clearTargetX();
                cur.macroModeClose();
                // try moving forward or backwards as necessary...
-               if (!(forward ? cursorMathForward(cur) : cursorMathBackward(cur))) {
+               if (!(forward ? cur.mathForward(word) : cur.mathBackward(word))) {
                        // ... and if movement failed, then finish forward or backwards
                        // as necessary
                        cmd = FuncRequest(finish_lfun);
@@ -708,10 +688,14 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
 
        case LFUN_DOWN:
        case LFUN_UP:
+       case LFUN_PARAGRAPH_UP:
+       case LFUN_PARAGRAPH_DOWN:
                cur.screenUpdateFlags(Update::Decoration | Update::FitCursor);
                // fall through
        case LFUN_DOWN_SELECT:
-       case LFUN_UP_SELECT: {
+       case LFUN_UP_SELECT:
+       case LFUN_PARAGRAPH_UP_SELECT:
+       case LFUN_PARAGRAPH_DOWN_SELECT: {
                // close active macro
                if (cur.inMacroMode()) {
                        cur.macroModeClose();
@@ -719,8 +703,10 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                }
 
                // stop/start the selection
-               bool select = act == LFUN_DOWN_SELECT ||
-                       act == LFUN_UP_SELECT;
+               bool select = act == LFUN_DOWN_SELECT
+                       || act == LFUN_UP_SELECT
+                       || act == LFUN_PARAGRAPH_DOWN_SELECT
+                       || act == LFUN_PARAGRAPH_UP_SELECT;
                cur.selHandle(select);
 
                // handle autocorrect:
@@ -730,7 +716,8 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                }
 
                // go up/down
-               bool up = act == LFUN_UP || act == LFUN_UP_SELECT;
+               bool up = act == LFUN_UP || act == LFUN_UP_SELECT
+                       || act == LFUN_PARAGRAPH_UP || act == LFUN_PARAGRAPH_UP_SELECT;
                bool successful = cur.upDownInMath(up);
                if (successful)
                        break;
@@ -764,22 +751,10 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                cur.bv().cursor() = cur;
                break;
 
-       case LFUN_PARAGRAPH_UP:
-       case LFUN_PARAGRAPH_DOWN:
-               cur.screenUpdateFlags(Update::Decoration | Update::FitCursor);
-               // fall through
-       case LFUN_PARAGRAPH_UP_SELECT:
-       case LFUN_PARAGRAPH_DOWN_SELECT:
-               break;
-
        case LFUN_LINE_BEGIN:
-       case LFUN_WORD_BACKWARD:
-       case LFUN_WORD_LEFT:
                cur.screenUpdateFlags(Update::Decoration | Update::FitCursor);
                // fall through
        case LFUN_LINE_BEGIN_SELECT:
-       case LFUN_WORD_BACKWARD_SELECT:
-       case LFUN_WORD_LEFT_SELECT:
                cur.selHandle(act == LFUN_WORD_BACKWARD_SELECT ||
                                act == LFUN_WORD_LEFT_SELECT ||
                                act == LFUN_LINE_BEGIN_SELECT);
@@ -798,13 +773,9 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                }
                break;
 
-       case LFUN_WORD_FORWARD:
-       case LFUN_WORD_RIGHT:
        case LFUN_LINE_END:
                cur.screenUpdateFlags(Update::Decoration | Update::FitCursor);
                // fall through
-       case LFUN_WORD_FORWARD_SELECT:
-       case LFUN_WORD_RIGHT_SELECT:
        case LFUN_LINE_END_SELECT:
                cur.selHandle(act == LFUN_WORD_FORWARD_SELECT ||
                                act == LFUN_WORD_RIGHT_SELECT ||
@@ -843,8 +814,8 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                else if (!cur.inMacroMode())
                        cur.recordUndoSelection();
                // if the inset can not be removed from within, delete it
-               if (!cur.backspace()) {
-                       FuncRequest cmd = FuncRequest(LFUN_CHAR_DELETE_FORWARD);
+               if (!cur.backspace(cmd.getArg(0) == "force")) {
+                       FuncRequest cmd = FuncRequest(LFUN_CHAR_DELETE_FORWARD, "force");
                        cur.innerText()->dispatch(cur, cmd);
                }
                break;
@@ -857,8 +828,8 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                else
                        cur.recordUndoSelection();
                // if the inset can not be removed from within, delete it
-               if (!cur.erase()) {
-                       FuncRequest cmd = FuncRequest(LFUN_CHAR_DELETE_FORWARD);
+               if (!cur.erase(cmd.getArg(0) == "force")) {
+                       FuncRequest cmd = FuncRequest(LFUN_CHAR_DELETE_FORWARD, "force");
                        cur.innerText()->dispatch(cur, cmd);
                }
                break;
@@ -965,37 +936,37 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                break;
 
        case LFUN_FONT_BOLD:
-               if (currentMode() <= TEXT_MODE)
+               if (currentMode() != MATH_MODE)
                        handleFont(cur, cmd.argument(), "textbf");
                else
                        handleFont(cur, cmd.argument(), "mathbf");
                break;
        case LFUN_FONT_BOLDSYMBOL:
-               if (currentMode() <= TEXT_MODE)
+               if (currentMode() != MATH_MODE)
                        handleFont(cur, cmd.argument(), "textbf");
                else
                        handleFont(cur, cmd.argument(), "boldsymbol");
                break;
        case LFUN_FONT_SANS:
-               if (currentMode() <= TEXT_MODE)
+               if (currentMode() != MATH_MODE)
                        handleFont(cur, cmd.argument(), "textsf");
                else
                        handleFont(cur, cmd.argument(), "mathsf");
                break;
        case LFUN_FONT_EMPH:
-               if (currentMode() <= TEXT_MODE)
+               if (currentMode() != MATH_MODE)
                        handleFont(cur, cmd.argument(), "emph");
                else
                        handleFont(cur, cmd.argument(), "mathcal");
                break;
        case LFUN_FONT_ROMAN:
-               if (currentMode() <= TEXT_MODE)
+               if (currentMode() != MATH_MODE)
                        handleFont(cur, cmd.argument(), "textrm");
                else
                        handleFont(cur, cmd.argument(), "mathrm");
                break;
        case LFUN_FONT_TYPEWRITER:
-               if (currentMode() <= TEXT_MODE)
+               if (currentMode() != MATH_MODE)
                        handleFont(cur, cmd.argument(), "texttt");
                else
                        handleFont(cur, cmd.argument(), "mathtt");
@@ -1004,13 +975,13 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                handleFont(cur, cmd.argument(), "mathfrak");
                break;
        case LFUN_FONT_ITAL:
-               if (currentMode() <= TEXT_MODE)
+               if (currentMode() != MATH_MODE)
                        handleFont(cur, cmd.argument(), "textit");
                else
                        handleFont(cur, cmd.argument(), "mathit");
                break;
        case LFUN_FONT_NOUN:
-               if (currentMode() <= TEXT_MODE)
+               if (currentMode() != MATH_MODE)
                        // FIXME: should be "noun"
                        handleFont(cur, cmd.argument(), "textsc");
                else
@@ -1033,7 +1004,7 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                cur.macroModeClose();
                docstring const save_selection = grabAndEraseSelection(cur);
                selClearOrDel(cur);
-               if (currentMode() <= Inset::TEXT_MODE)
+               if (currentMode() != Inset::MATH_MODE)
                        cur.plainInsert(MathAtom(new InsetMathEnsureMath(buffer_)));
                else
                        cur.plainInsert(createInsetMath("text", buffer_));
@@ -1524,7 +1495,7 @@ void InsetMathNest::edit(Cursor & cur, bool front, EntryDirection entry_from)
 
 Inset * InsetMathNest::editXY(Cursor & cur, int x, int y)
 {
-       int idx_min = 0;
+       int idx_min = -1;
        int dist_min = 1000000;
        for (idx_type i = 0, n = nargs(); i != n; ++i) {
                int const d = cell(i).dist(cur.bv(), x, y);
@@ -1533,6 +1504,9 @@ Inset * InsetMathNest::editXY(Cursor & cur, int x, int y)
                        idx_min = i;
                }
        }
+       if (idx_min == -1)
+               return this;
+
        MathData & ar = cell(idx_min);
        cur.push(*this);
        cur.idx() = idx_min;
@@ -1562,6 +1536,10 @@ void InsetMathNest::lfunMousePress(Cursor & cur, FuncRequest & cmd)
                        return;
                }
        }
+
+       // set cursor after the inset if x is nearer to that position (bug 9748)
+       cur.moveToClosestEdge(cmd.x(), true);
+
        bool do_selection = cmd.button() == mouse_button::button1
                && cmd.modifier() == ShiftModifier;
        bv.mouseSetCursor(cur, do_selection);
@@ -1606,6 +1584,9 @@ void InsetMathNest::lfunMouseMotion(Cursor & cur, FuncRequest & cmd)
                return;
        }
 
+       // set cursor after the inset if x is nearer to that position (bug 9748)
+       cur.moveToClosestEdge(cmd.x());
+
        CursorSlice old = bvcur.top();
 
        // We continue with our existing selection or start a new one, so don't
@@ -1676,7 +1657,7 @@ bool InsetMathNest::interpretChar(Cursor & cur, char_type const c)
                        // remove the '\\'
                        if (c == '\\') {
                                cur.backspace();
-                               if (currentMode() <= InsetMath::TEXT_MODE)
+                               if (currentMode() != InsetMath::MATH_MODE)
                                        cur.niceInsert(createInsetMath("textbackslash", buf));
                                else
                                        cur.niceInsert(createInsetMath("backslash", buf));
@@ -1792,13 +1773,13 @@ bool InsetMathNest::interpretChar(Cursor & cur, char_type const c)
        selClearOrDel(cur);
 
        if (c == '\n') {
-               if (currentMode() <= InsetMath::TEXT_MODE)
+               if (currentMode() != InsetMath::MATH_MODE)
                        cur.insert(c);
                return true;
        }
 
        if (c == ' ') {
-               if (currentMode() <= InsetMath::TEXT_MODE) {
+               if (currentMode() != InsetMath::MATH_MODE) {
                        // insert spaces in text or undecided mode,
                        // but suppress direct insertion of two spaces in a row
                        // the still allows typing  '<space>a<space>' and deleting the 'a', but
@@ -2084,43 +2065,6 @@ void InsetMathNest::completionPosAndDim(Cursor const & cur, int & x, int & y,
 }
 
 
-bool InsetMathNest::cursorMathForward(Cursor & cur)
-{
-       if (cur.pos() != cur.lastpos() && cur.openable(cur.nextAtom())) {
-               cur.pushBackward(*cur.nextAtom().nucleus());
-               cur.inset().idxFirst(cur);
-               return true;
-       }
-       if (cur.posForward() || idxForward(cur))
-               return true;
-       // try to pop forwards --- but don't pop out of math! leave that to
-       // the FINISH lfuns
-       int s = cur.depth() - 2;
-       if (s >= 0 && cur[s].inset().asInsetMath())
-               return cur.popForward();
-       return false;
-}
-
-
-bool InsetMathNest::cursorMathBackward(Cursor & cur)
-{
-       if (cur.pos() != 0 && cur.openable(cur.prevAtom())) {
-               cur.posBackward();
-               cur.push(*cur.nextAtom().nucleus());
-               cur.inset().idxLast(cur);
-               return true;
-       }
-       if (cur.posBackward() || idxBackward(cur))
-               return true;
-       // try to pop backwards --- but don't pop out of math! leave that to
-       // the FINISH lfuns
-       int s = cur.depth() - 2;
-       if (s >= 0 && cur[s].inset().asInsetMath())
-               return cur.popBackward();
-       return false;
-}
-
-
 ////////////////////////////////////////////////////////////////////
 
 MathCompletionList::MathCompletionList(Cursor const & cur)