]> git.lyx.org Git - lyx.git/blobdiff - src/mathed/InsetMathNest.cpp
revert last patch. there's something wrong, possibly unrelated to this
[lyx.git] / src / mathed / InsetMathNest.cpp
index a6f9e7165a197e3f1c2f734a056ef4be9f2c19c4..2ba467d3f5981a9301bc091b02ff8f4e8fa2dfa5 100644 (file)
 #include "InsetMathComment.h"
 #include "InsetMathDelim.h"
 #include "InsetMathHull.h"
-//#include "InsetMathMBox.h"
 #include "InsetMathRef.h"
 #include "InsetMathScript.h"
 #include "InsetMathSpace.h"
 #include "InsetMathSymbol.h"
 #include "InsetMathUnknown.h"
+#include "MathCompletionList.h"
 #include "MathData.h"
 #include "MathFactory.h"
+#include "MathMacro.h"
 #include "MathMacroArgument.h"
 #include "MathParser.h"
 #include "MathStream.h"
 #include "MathSupport.h"
 
 #include "Bidi.h"
+#include "Buffer.h"
 #include "BufferView.h"
 #include "CoordCache.h"
 #include "Cursor.h"
 #include "CutAndPaste.h"
-#include "debug.h"
 #include "DispatchResult.h"
 #include "FuncRequest.h"
 #include "FuncStatus.h"
 #include "LyXFunc.h"
-#include "gettext.h"
-#include "Text.h"
+#include "LyXRC.h"
 #include "OutputParams.h"
-
-#include "support/lstrings.h"
-#include "support/textutils.h"
+#include "Text.h"
 
 #include "frontends/Clipboard.h"
 #include "frontends/Painter.h"
 #include "frontends/Selection.h"
 
-#include "FuncRequest.h"
+#include "support/debug.h"
+#include "support/gettext.h"
+#include "support/lstrings.h"
+#include "support/textutils.h"
+#include "support/docstream.h"
 
+#include <algorithm>
 #include <sstream>
 
+using namespace std;
+using namespace lyx::support;
 
 namespace lyx {
 
@@ -67,10 +72,6 @@ using cap::cutSelection;
 using cap::replaceSelection;
 using cap::selClearOrDel;
 
-using std::endl;
-using std::string;
-using std::istringstream;
-
 
 InsetMathNest::InsetMathNest(idx_type nargs)
        : cells_(nargs), lock_(false), mouse_hover_(false)
@@ -110,7 +111,7 @@ void InsetMathNest::cursorPos(BufferView const & bv,
 // to touch all (math)inset's draw() methods. Right now, we'll store
 // absolute value, and make them here relative, only to make them
 // absolute again when actually drawing the cursor. What a mess.
-       BOOST_ASSERT(ptr_cmp(&sl.inset(), this));
+       BOOST_ASSERT(&sl.inset() == this);
        MathData const & ar = sl.cell();
        CoordCache const & coord_cache = bv.coordCache();
        if (!coord_cache.getArrays().has(&ar)) {
@@ -131,8 +132,8 @@ void InsetMathNest::cursorPos(BufferView const & bv,
        }
        Point const pt2 = coord_cache.getInsets().xy(this);
        //lyxerr << "retrieving position cache for MathData "
-       //      << pt.x_ << ' ' << pt.y_ << std::endl;
-       x = pt.x_ - pt2.x_ + ar.pos2x(sl.pos());
+       //      << pt.x_ << ' ' << pt.y_ << endl;
+       x = pt.x_ - pt2.x_ + ar.pos2x(&bv, sl.pos());
        y = pt.y_ - pt2.y_;
 //     lyxerr << "pt.y_ : " << pt.y_ << " pt2_.y_ : " << pt2.y_
 //             << " asc: " << ascent() << "  des: " << descent()
@@ -155,7 +156,7 @@ void InsetMathNest::metrics(MetricsInfo const & mi) const
 
 bool InsetMathNest::idxNext(Cursor & cur) const
 {
-       BOOST_ASSERT(ptr_cmp(&cur.inset(), this));
+       BOOST_ASSERT(&cur.inset() == this);
        if (cur.idx() == cur.lastidx())
                return false;
        ++cur.idx();
@@ -164,7 +165,7 @@ bool InsetMathNest::idxNext(Cursor & cur) const
 }
 
 
-bool InsetMathNest::idxRight(Cursor & cur) const
+bool InsetMathNest::idxForward(Cursor & cur) const
 {
        return idxNext(cur);
 }
@@ -172,7 +173,7 @@ bool InsetMathNest::idxRight(Cursor & cur) const
 
 bool InsetMathNest::idxPrev(Cursor & cur) const
 {
-       BOOST_ASSERT(ptr_cmp(&cur.inset(), this));
+       BOOST_ASSERT(&cur.inset() == this);
        if (cur.idx() == 0)
                return false;
        --cur.idx();
@@ -181,7 +182,7 @@ bool InsetMathNest::idxPrev(Cursor & cur) const
 }
 
 
-bool InsetMathNest::idxLeft(Cursor & cur) const
+bool InsetMathNest::idxBackward(Cursor & cur) const
 {
        return idxPrev(cur);
 }
@@ -189,7 +190,7 @@ bool InsetMathNest::idxLeft(Cursor & cur) const
 
 bool InsetMathNest::idxFirst(Cursor & cur) const
 {
-       BOOST_ASSERT(ptr_cmp(&cur.inset(), this));
+       BOOST_ASSERT(&cur.inset() == this);
        if (nargs() == 0)
                return false;
        cur.idx() = 0;
@@ -200,7 +201,7 @@ bool InsetMathNest::idxFirst(Cursor & cur) const
 
 bool InsetMathNest::idxLast(Cursor & cur) const
 {
-       BOOST_ASSERT(ptr_cmp(&cur.inset(), this));
+       BOOST_ASSERT(&cur.inset() == this);
        if (nargs() == 0)
                return false;
        cur.idx() = cur.lastidx();
@@ -241,13 +242,14 @@ void InsetMathNest::drawSelection(PainterInfo & pi, int x, int y) const
        Cursor & cur = bv.cursor();
        if (!cur.selection())
                return;
-       if (!ptr_cmp(&cur.inset(), this))
+       if (&cur.inset() != this)
                return;
 
        // FIXME: hack to get position cache warm
+       bool const original_drawing_state = pi.pain.isDrawingEnabled();
        pi.pain.setDrawingEnabled(false);
        draw(pi, x, y);
-       pi.pain.setDrawingEnabled(true);
+       pi.pain.setDrawingEnabled(original_drawing_state);
 
        CursorSlice s1 = cur.selBegin();
        CursorSlice s2 = cur.selEnd();
@@ -257,9 +259,9 @@ void InsetMathNest::drawSelection(PainterInfo & pi, int x, int y) const
        if (s1.idx() == s2.idx()) {
                MathData const & c = cell(s1.idx());
                Geometry const & g = bv.coordCache().getArrays().geometry(&c);
-               int x1 = g.pos.x_ + c.pos2x(s1.pos());
+               int x1 = g.pos.x_ + c.pos2x(pi.base.bv, s1.pos());
                int y1 = g.pos.y_ - g.dim.ascent();
-               int x2 = g.pos.x_ + c.pos2x(s2.pos());
+               int x2 = g.pos.x_ + c.pos2x(pi.base.bv, s2.pos());
                int y2 = g.pos.y_ + g.dim.descent();
                pi.pain.fillRectangle(x1, y1, x2 - x1, y2 - y1, Color_selection);
        //lyxerr << "InsetMathNest::drawing selection 3: "
@@ -354,8 +356,7 @@ void InsetMathNest::normalize(NormalStream & os) const
 }
 
 
-int InsetMathNest::latex(Buffer const &, odocstream & os,
-                       OutputParams const & runparams) const
+int InsetMathNest::latex(odocstream & os, OutputParams const & runparams) const
 {
        WriteStream wi(os, runparams.moving_arg, true);
        write(wi);
@@ -370,7 +371,7 @@ bool InsetMathNest::setMouseHover(bool mouse_hover)
 }
 
 
-bool InsetMathNest::notifyCursorLeaves(Cursor & /*cur*/)
+bool InsetMathNest::notifyCursorLeaves(Cursor const & /*old*/, Cursor & /*cur*/)
 {
        // FIXME: look here
 #if 0
@@ -408,45 +409,110 @@ void InsetMathNest::handleFont
 }
 
 
-void InsetMathNest::handleFont
-       (Cursor & cur, docstring const & arg, docstring const & font)
+void InsetMathNest::handleFont(Cursor & cur, docstring const & arg,
+       docstring const & font)
 {
+       cur.recordUndoSelection();
+
        // this whole function is a hack and won't work for incremental font
        // changes...
-
-       if (cur.inset().asInsetMath()->name() == font) {
-               cur.recordUndoInset();
+       if (cur.inset().asInsetMath()->name() == font)
                cur.handleFont(to_utf8(font));
-       } else {
-               cur.recordUndo();
-               cur.handleNest(createInsetMath(font));
+       else
+               handleNest(cur, createInsetMath(font), arg);
+}
+
+
+void InsetMathNest::handleNest(Cursor & cur, MathAtom const & nest)
+{
+       handleNest(cur, nest, docstring());
+}
+
+
+void InsetMathNest::handleNest(Cursor & cur, MathAtom const & nest,
+       docstring const & arg)
+{
+       CursorSlice i1 = cur.selBegin();
+       CursorSlice i2 = cur.selEnd();
+       if (!i1.inset().asInsetMath())
+               return;
+       if (i1.idx() == i2.idx()) {
+               // the easy case where only one cell is selected
+               cur.handleNest(nest);
                cur.insert(arg);
+               return;
+       }
+       
+       // multiple selected cells in a simple non-grid inset
+       if (i1.asInsetMath()->nrows() == 0 || i1.asInsetMath()->ncols() == 0) {
+               for (idx_type i = i1.idx(); i <= i2.idx(); ++i) {
+                       // select cell
+                       cur.idx() = i;
+                       cur.pos() = 0;
+                       cur.resetAnchor();
+                       cur.pos() = cur.lastpos();
+                       cur.setSelection();
+                       
+                       // change font of cell
+                       cur.handleNest(nest);
+                       cur.insert(arg);
+                       
+                       // cur is in the font inset now. If the loop continues,
+                       // we need to get outside again for the next cell
+                       if (i + 1 <= i2.idx())
+                               cur.pop_back();
+               }
+               return;
+       }
+       
+       // the complicated case with multiple selected cells in a grid
+       row_type r1, r2;
+       col_type c1, c2;
+       cap::region(i1, i2, r1, r2, c1, c2);
+       for (row_type row = r1; row <= r2; ++row) {
+               for (col_type col = c1; col <= c2; ++col) {
+                       // select cell
+                       cur.idx() = i1.asInsetMath()->index(row, col);
+                       cur.pos() = 0;
+                       cur.resetAnchor();
+                       cur.pos() = cur.lastpos();
+                       cur.setSelection();
+                       
+                       // 
+                       cur.handleNest(nest);
+                       cur.insert(arg);
+               
+                       // cur is in the font inset now. If the loop continues,
+                       // we need to get outside again for the next cell
+                       if (col + 1 <= c2 || row + 1 <= r2)
+                               cur.pop_back();
+               }
        }
 }
 
 
 void InsetMathNest::handleFont2(Cursor & cur, docstring const & arg)
 {
-       cur.recordUndo();
+       cur.recordUndoSelection();
        Font font;
        bool b;
        font.fromString(to_utf8(arg), b);
-       if (font.fontInfo().color() != Color_inherit) {
-               MathAtom at = MathAtom(new InsetMathColor(true, font.fontInfo().color()));
-               cur.handleNest(at, 0);
-       }
+       if (font.fontInfo().color() != Color_inherit &&
+           font.fontInfo().color() != Color_ignore)
+               handleNest(cur, MathAtom(new InsetMathColor(true, font.fontInfo().color())));
+       
+       // FIXME: support other font changes here as well?
 }
 
 
 void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
 {
-       //lyxerr << "InsetMathNest: request: " << cmd << std::endl;
-       //CursorSlice sl = cur.current();
+       //lyxerr << "InsetMathNest: request: " << cmd << endl;
 
        switch (cmd.action) {
 
        case LFUN_PASTE: {
-               cur.recordUndo();
+               cur.recordUndoSelection();
                cur.message(_("Paste"));
                replaceSelection(cur);
                docstring topaste;
@@ -456,7 +522,7 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                        size_t n = 0;
                        idocstringstream is(cmd.argument());
                        is >> n;
-                       topaste = cap::getSelection(cur.buffer(), n);
+                       topaste = cap::selection(n);
                }
                cur.niceInsert(topaste);
                cur.clearSelection(); // bug 393
@@ -490,79 +556,79 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                lfunMouseRelease(cur, cmd);
                break;
 
+       case LFUN_FINISHED_LEFT: // in math, left is backwards
        case LFUN_FINISHED_BACKWARD:
                cur.bv().cursor() = cur;
                break;
 
+       case LFUN_FINISHED_RIGHT: // in math, right is forward
        case LFUN_FINISHED_FORWARD:
                ++cur.pos();
                cur.bv().cursor() = cur;
                break;
 
+       case LFUN_CHAR_RIGHT:
+       case LFUN_CHAR_LEFT:
+       case LFUN_CHAR_BACKWARD:
        case LFUN_CHAR_FORWARD:
                cur.updateFlags(Update::Decoration | Update::FitCursor);
-       case LFUN_CHAR_FORWARD_SELECT:
-               cur.selHandle(cmd.action == LFUN_CHAR_FORWARD_SELECT);
-               cur.autocorrect() = false;
-               cur.clearTargetX();
-               cur.macroModeClose();
-               if (cur.pos() != cur.lastpos() && cur.openable(cur.nextAtom())) {
-                       cur.pushLeft(*cur.nextAtom().nucleus());
-                       cur.inset().idxFirst(cur);
-               } else if (cur.posRight() || idxRight(cur)
-                       || cur.popRight() || cur.selection())
-                       ;
+       case LFUN_CHAR_RIGHT_SELECT:
+       case LFUN_CHAR_LEFT_SELECT:
+       case LFUN_CHAR_BACKWARD_SELECT:
+       case LFUN_CHAR_FORWARD_SELECT: {
+               // are we in a selection?
+               bool select = (cmd.action == LFUN_CHAR_RIGHT_SELECT 
+                                          || cmd.action == LFUN_CHAR_LEFT_SELECT
+                                          || cmd.action == LFUN_CHAR_BACKWARD_SELECT
+                                          || cmd.action == LFUN_CHAR_FORWARD_SELECT);
+               // are we moving forward or backwards? 
+               // If the command was RIGHT or LEFT, then whether we're moving forward
+               // or backwards depends on the cursor movement mode (logical or visual):
+               //  * in visual mode, since math is always LTR, right -> forward, 
+               //    left -> backwards
+               //  * in logical mode, the mapping is determined by the
+               //    reverseDirectionNeeded() function
+               
+               bool forward;
+               FuncCode finish_lfun;
+
+               if (cmd.action == LFUN_CHAR_FORWARD 
+                               || cmd.action == LFUN_CHAR_FORWARD_SELECT) {
+                       forward = true;
+                       finish_lfun = LFUN_FINISHED_FORWARD;
+               }
+               else if (cmd.action == LFUN_CHAR_BACKWARD
+                               || cmd.action == LFUN_CHAR_BACKWARD_SELECT) {
+                       forward = false;
+                       finish_lfun = LFUN_FINISHED_BACKWARD;
+               }
                else {
-                       cmd = FuncRequest(LFUN_FINISHED_FORWARD);
-                       cur.undispatched();
+                       bool right = (cmd.action == LFUN_CHAR_RIGHT_SELECT
+                                                 || cmd.action == LFUN_CHAR_RIGHT);
+                       if (lyxrc.visual_cursor || !reverseDirectionNeeded(cur))
+                               forward = right;
+                       else 
+                               forward = !right;
+
+                       if (right)
+                               finish_lfun = LFUN_FINISHED_RIGHT;
+                       else
+                               finish_lfun = LFUN_FINISHED_LEFT;
                }
-               break;
-
-       case LFUN_CHAR_BACKWARD:
-               cur.updateFlags(Update::Decoration | Update::FitCursor);
-       case LFUN_CHAR_BACKWARD_SELECT:
-               cur.selHandle(cmd.action == LFUN_CHAR_BACKWARD_SELECT);
+               // Now that we know exactly what we want to do, let's do it!
+               cur.selHandle(select);
                cur.autocorrect() = false;
                cur.clearTargetX();
                cur.macroModeClose();
-               if (cur.pos() != 0 && cur.openable(cur.prevAtom())) {
-                       cur.posLeft();
-                       cur.push(*cur.nextAtom().nucleus());
-                       cur.inset().idxLast(cur);
-               } else if (cur.posLeft() || idxLeft(cur)
-                       || cur.popLeft() || cur.selection())
-                       ;
-               else {
-                       cmd = FuncRequest(LFUN_FINISHED_BACKWARD);
+               // try moving forward or backwards as necessary...
+               if (!(forward ? cursorMathForward(cur) : cursorMathBackward(cur))) {
+                       // ... and if movement failed, then finish forward or backwards
+                       // as necessary
+                       cmd = FuncRequest(finish_lfun);
                        cur.undispatched();
                }
                break;
-
-       case LFUN_CHAR_RIGHT:
-       case LFUN_CHAR_RIGHT_SELECT:
-               //FIXME: for visual cursor, really move right
-               if (reverseDirectionNeeded(cur))
-                       lyx::dispatch(FuncRequest(
-                               cmd.action == LFUN_CHAR_RIGHT_SELECT ? 
-                                       LFUN_CHAR_BACKWARD_SELECT : LFUN_CHAR_BACKWARD));
-               else 
-                       lyx::dispatch(FuncRequest(
-                               cmd.action == LFUN_CHAR_RIGHT_SELECT ? 
-                                       LFUN_CHAR_FORWARD_SELECT : LFUN_CHAR_FORWARD));
-               break;
-
-       case LFUN_CHAR_LEFT:
-       case LFUN_CHAR_LEFT_SELECT:
-               //FIXME: for visual cursor, really move left
-               if (reverseDirectionNeeded(cur))
-                       lyx::dispatch(FuncRequest(
-                               cmd.action == LFUN_CHAR_LEFT_SELECT ? 
-                                       LFUN_CHAR_FORWARD_SELECT : LFUN_CHAR_FORWARD));
-               else 
-                       lyx::dispatch(FuncRequest(
-                               cmd.action == LFUN_CHAR_LEFT_SELECT ? 
-                                       LFUN_CHAR_BACKWARD_SELECT : LFUN_CHAR_BACKWARD));
-               break;
+       }
 
        case LFUN_DOWN:
        case LFUN_UP:
@@ -583,12 +649,8 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                // go up/down
                bool up = cmd.action == LFUN_UP || cmd.action == LFUN_UP_SELECT;
                bool successful = cur.upDownInMath(up);
-               if (successful) {
-                       // notify left insets and give them chance to set update flags
-                       lyx::notifyCursorLeaves(cur.beforeDispatchCursor(), cur);
-                       cur.fixIfBroken();
+               if (successful)
                        break;
-               }
                
                if (cur.fixIfBroken())
                        // FIXME: Something bad happened. We pass the corrected Cursor
@@ -669,16 +731,6 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                }
                break;
 
-       case LFUN_SCREEN_UP_SELECT:
-               cmd = FuncRequest(LFUN_FINISHED_BACKWARD);
-               cur.undispatched();
-               break;
-
-       case LFUN_SCREEN_DOWN_SELECT:
-               cmd = FuncRequest(LFUN_FINISHED_FORWARD);
-               cur.undispatched();
-               break;
-
        case LFUN_CELL_FORWARD:
                cur.updateFlags(Update::Decoration | Update::FitCursor);
                cur.inset().idxNext(cur);
@@ -695,7 +747,7 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                        // May affect external cell:
                        cur.recordUndoInset();
                else
-                       cur.recordUndo();
+                       cur.recordUndoSelection();
                // if the inset can not be removed from within, delete it
                if (!cur.backspace()) {
                        FuncRequest cmd = FuncRequest(LFUN_CHAR_DELETE_FORWARD);
@@ -709,7 +761,7 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                        // May affect external cell:
                        cur.recordUndoInset();
                else
-                       cur.recordUndo();
+                       cur.recordUndoSelection();
                // if the inset can not be removed from within, delete it
                if (!cur.erase()) {
                        FuncRequest cmd = FuncRequest(LFUN_CHAR_DELETE_FORWARD);
@@ -726,15 +778,17 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                }
                break;
 
+       // 'Locks' the math inset. A 'locked' math inset behaves as a unit
+       // that is traversed by a single <CursorLeft>/<CursorRight>.
        case LFUN_INSET_TOGGLE:
                cur.recordUndo();
                lock(!lock());
-               cur.popRight();
+               cur.popForward();
                break;
 
        case LFUN_SELF_INSERT:
                if (cmd.argument().size() != 1) {
-                       cur.recordUndo();
+                       cur.recordUndoSelection();
                        docstring const arg = cmd.argument();
                        if (!interpretString(cur, arg))
                                cur.insert(arg);
@@ -750,7 +804,7 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                // A side effect is that an undo before the macro is finished
                // undoes the complete macro, not only the last character.
                if (!cur.inMacroMode())
-                       cur.recordUndo();
+                       cur.recordUndoSelection();
 
                // spacial handling of space. If we insert an inset
                // via macro mode, we want to put the cursor inside it
@@ -760,8 +814,8 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                    && cur.macroModeClose()) {
                        MathAtom const atom = cur.prevAtom();
                        if (atom->asNestInset() && atom->isActive()) {
-                               cur.posLeft();
-                               cur.pushLeft(*cur.nextInset());
+                               cur.posBackward();
+                               cur.pushBackward(*cur.nextInset());
                        }
                } else if (!interpretChar(cur, cmd.argument()[0])) {
                        cmd = FuncRequest(LFUN_FINISHED_FORWARD);
@@ -789,7 +843,7 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                if (cmd.argument().empty()) {
                        // do superscript if LyX handles
                        // deadkeys
-                       cur.recordUndo();
+                       cur.recordUndoSelection();
                        script(cur, true, grabAndEraseSelection(cur));
                }
                break;
@@ -820,7 +874,7 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                if (currentMode() == TEXT_MODE)
                        handleFont(cur, cmd.argument(), "textbf");
                else
-                       handleFont(cur, cmd.argument(), "mathbf");
+                       handleFont(cur, cmd.argument(), "boldsymbol");
                break;
        case LFUN_FONT_SANS:
                if (currentMode() == TEXT_MODE)
@@ -881,8 +935,8 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                selClearOrDel(cur);
                //cur.plainInsert(MathAtom(new InsetMathMBox(cur.bv())));
                cur.plainInsert(MathAtom(new InsetMathBox(from_ascii("mbox"))));
-               cur.posLeft();
-               cur.pushLeft(*cur.nextInset());
+               cur.posBackward();
+               cur.pushBackward(*cur.nextInset());
                cur.niceInsert(save_selection);
 #else
                if (currentMode() == Inset::TEXT_MODE) {
@@ -898,7 +952,7 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
 
        case LFUN_MATH_SIZE:
 #if 0
-               cur.recordUndo();
+               cur.recordUndoSelection();
                cur.setSize(arg);
 #endif
                break;
@@ -923,7 +977,7 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
 
        case LFUN_MATH_DELIM: {
                docstring ls;
-               docstring rs = support::split(cmd.argument(), ls, ' ');
+               docstring rs = split(cmd.argument(), ls, ' ');
                // Reasonable default values
                if (ls.empty())
                        ls = '(';
@@ -966,7 +1020,7 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
 
        case LFUN_SPACE_INSERT:
        case LFUN_MATH_SPACE:
-               cur.recordUndo();
+               cur.recordUndoSelection();
                cur.insert(MathAtom(new InsetMathSpace(from_ascii(","))));
                break;
 
@@ -978,19 +1032,35 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
 
        case LFUN_MATH_SUBSCRIPT:
                // interpret this as if a _ was typed
-               cur.recordUndo();
+               cur.recordUndoSelection();
                interpretChar(cur, '_');
                break;
 
        case LFUN_MATH_SUPERSCRIPT:
                // interpret this as if a ^ was typed
-               cur.recordUndo();
+               cur.recordUndoSelection();
                interpretChar(cur, '^');
                break;
+               
+       case LFUN_MATH_MACRO_FOLD:
+       case LFUN_MATH_MACRO_UNFOLD: {
+               Cursor it = cur;
+               bool fold = cmd.action == LFUN_MATH_MACRO_FOLD;
+               bool found = findMacroToFoldUnfold(it, fold);
+               if (found) {
+                       MathMacro * macro = it.nextInset()->asInsetMath()->asMacro();
+                       cur.recordUndoInset();
+                       if (fold)
+                               macro->fold(cur);
+                       else
+                               macro->unfold(cur);
+               }
+               break;
+       }
 
        case LFUN_QUOTE_INSERT:
                // interpret this as if a straight " was typed
-               cur.recordUndo();
+               cur.recordUndoSelection();
                interpretChar(cur, '\"');
                break;
 
@@ -998,11 +1068,17 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
 // handling such that "self-insert" works on "arbitrary stuff" too, and
 // math-insert only handles special math things like "matrix".
        case LFUN_MATH_INSERT: {
-               cur.recordUndo();
-               if (cmd.argument() == "^" || cmd.argument() == "_") {
+               cur.recordUndoSelection();
+               if (cmd.argument() == "^" || cmd.argument() == "_")
                        interpretChar(cur, cmd.argument()[0]);
-               } else
-                       cur.niceInsert(cmd.argument());
+               else {
+                       MathData ar;
+                       asArray(cmd.argument(), ar);
+                       if (ar.size() == 1 && ar[0]->asNestInset())
+                               handleNest(cur, ar[0]);
+                       else
+                               cur.niceInsert(cmd.argument());
+               }
                break;
                }
 
@@ -1013,14 +1089,14 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                        InsetMathRef tmp(name);
                        data = tmp.createDialogStr(to_utf8(name));
                }
-               cur.bv().showInsetDialog(to_utf8(name), data, 0);
+               cur.bv().showDialog(to_utf8(name), data);
                break;
        }
 
        case LFUN_INSET_INSERT: {
                MathData ar;
                if (createInsetMath_fromDialogStr(cmd.argument(), ar)) {
-                       cur.recordUndo();
+                       cur.recordUndoSelection();
                        cur.insert(ar);
                } else
                        cur.undispatched();
@@ -1040,6 +1116,40 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
 }
 
 
+bool InsetMathNest::findMacroToFoldUnfold(Cursor & it, bool fold) const {
+       // look for macro to open/close, but stay in mathed
+       for (; !it.empty(); it.pop_back()) {
+                       
+               // go backward through the current cell
+               Inset * inset = it.nextInset();
+               while (inset && inset->asInsetMath()) {
+                       MathMacro * macro = inset->asInsetMath()->asMacro();
+                       if (macro) {
+                               // found the an macro to open/close?
+                               if (macro->folded() != fold)
+                                       return true;
+                               
+                               // Wrong folding state.
+                               // If this was the first we see in this slice, look further left,
+                               // otherwise go up.
+                               if (inset != it.nextInset())
+                                       break;
+                       }
+                       
+                       // go up if this was the left most position
+                       if (it.pos() == 0)
+                               break;
+                       
+                       // go left
+                       it.pos()--;
+                       inset = it.nextInset();
+               }
+       }
+       
+       return false;
+}
+
+
 bool InsetMathNest::getStatus(Cursor & cur, FuncRequest const & cmd,
                FuncStatus & flag) const
 {
@@ -1091,8 +1201,6 @@ bool InsetMathNest::getStatus(Cursor & cur, FuncRequest const & cmd,
        case LFUN_MATH_SIZE:
        case LFUN_MATH_SPACE:
        case LFUN_MATH_LIMITS:
-       case LFUN_MATH_NONUMBER:
-       case LFUN_MATH_NUMBER:
        case LFUN_MATH_EXTERN:
                flag.enabled(true);
                break;
@@ -1131,12 +1239,16 @@ bool InsetMathNest::getStatus(Cursor & cur, FuncRequest const & cmd,
                // Don't do this with multi-cell selections
                flag.enabled(cur.selBegin().idx() == cur.selEnd().idx());
                break;
-
-       case LFUN_HYPHENATION_POINT_INSERT:
-       case LFUN_LIGATURE_BREAK_INSERT:
-       case LFUN_MENU_SEPARATOR_INSERT:
-       case LFUN_DOTS_INSERT:
-       case LFUN_END_OF_SENTENCE_PERIOD_INSERT:
+               
+       case LFUN_MATH_MACRO_FOLD:
+       case LFUN_MATH_MACRO_UNFOLD: {
+               Cursor it = cur;
+               bool found = findMacroToFoldUnfold(it, cmd.action == LFUN_MATH_MACRO_FOLD);
+               flag.enabled(found);
+               break;
+       }
+               
+       case LFUN_SPECIALCHAR_INSERT:
                // FIXME: These would probably make sense in math-text mode
                flag.enabled(false);
                break;
@@ -1153,11 +1265,13 @@ bool InsetMathNest::getStatus(Cursor & cur, FuncRequest const & cmd,
 }
 
 
-void InsetMathNest::edit(Cursor & cur, bool left)
+void InsetMathNest::edit(Cursor & cur, bool front, EntryDirection entry_from)
 {
        cur.push(*this);
-       cur.idx() = left ? 0 : cur.lastidx();
-       cur.pos() = left ? 0 : cur.lastpos();
+       bool enter_front = (entry_from == Inset::ENTRY_DIRECTION_RIGHT || 
+               (entry_from == Inset::ENTRY_DIRECTION_IGNORE && front));
+       cur.idx() = enter_front ? 0 : cur.lastidx();
+       cur.pos() = enter_front ? 0 : cur.lastpos();
        cur.resetAnchor();
        //lyxerr << "InsetMathNest::edit, cur:\n" << cur << endl;
 }
@@ -1177,7 +1291,7 @@ Inset * InsetMathNest::editXY(Cursor & cur, int x, int y)
        MathData & ar = cell(idx_min);
        cur.push(*this);
        cur.idx() = idx_min;
-       cur.pos() = ar.x2pos(x - ar.xo(cur.bv()));
+       cur.pos() = ar.x2pos(&cur.bv(), x - ar.xo(cur.bv()));
 
        //lyxerr << "found cell : " << idx_min << " pos: " << cur.pos() << endl;
        if (dist_min == 0) {
@@ -1280,7 +1394,12 @@ bool InsetMathNest::interpretChar(Cursor & cur, char_type c)
                        return true;
                }
 
-               if (isAlphaASCII(c)) {
+               // do not finish macro for known * commands
+               MathWordList const & mwl = mathedWordList();
+               bool star_macro = c == '*'
+                       && (mwl.find(name.substr(1) + "*") != mwl.end()
+                           || cur.buffer().getMacro(name.substr(1) + "*", cur, true));
+               if (isAlphaASCII(c) || star_macro) {
                        cur.activeMacro()->setName(name + docstring(1, c));
                        return true;
                }
@@ -1366,14 +1485,18 @@ bool InsetMathNest::interpretChar(Cursor & cur, char_type c)
                return true;
        }
 
-       selClearOrDel(cur);
-
        if (c == '\\') {
                //lyxerr << "starting with macro" << endl;
-               cur.insert(MathAtom(new InsetMathUnknown(from_ascii("\\"), false)));
+               bool reduced = cap::reduceSelectionToOneCell(cur);
+               if (reduced || !cur.selection()) {
+                       docstring const safe = cap::grabAndEraseSelection(cur);
+                       cur.insert(MathAtom(new InsetMathUnknown(from_ascii("\\"), safe, false)));
+               }
                return true;
        }
 
+       selClearOrDel(cur);
+
        if (c == '\n') {
                if (currentMode() == InsetMath::TEXT_MODE)
                        cur.insert(c);
@@ -1406,7 +1529,7 @@ bool InsetMathNest::interpretChar(Cursor & cur, char_type c)
                        return true;
                }
 
-               if (cur.popRight()) {
+               if (cur.popForward()) {
                        // FIXME: we have to enable full redraw here because of the
                        // visual box corners that define the inset. If we know for
                        // sure that we stay within the same cell we can optimize for
@@ -1476,6 +1599,12 @@ bool InsetMathNest::interpretString(Cursor & cur, docstring const & str)
 }
 
 
+bool InsetMathNest::script(Cursor & cur, bool up)
+{
+       return script(cur, up, docstring());
+}
+
+
 bool InsetMathNest::script(Cursor & cur, bool up,
                docstring const & save_selection)
 {
@@ -1530,4 +1659,254 @@ bool InsetMathNest::script(Cursor & cur, bool up,
 }
 
 
+bool InsetMathNest::completionSupported(Cursor const & cur) const
+{
+       return cur.inMacroMode();
+}
+
+
+bool InsetMathNest::inlineCompletionSupported(Cursor const & cur) const
+{
+       return cur.inMacroMode();
+}
+
+
+bool InsetMathNest::automaticInlineCompletion() const
+{
+       return lyxrc.completion_inline_math;
+}
+
+
+bool InsetMathNest::automaticPopupCompletion() const
+{
+       return lyxrc.completion_popup_math;
+}
+
+
+CompletionList const *
+InsetMathNest::createCompletionList(Cursor const & cur) const
+{
+       if (!cur.inMacroMode())
+               return 0;
+       
+       return new MathCompletionList(cur);
+}
+
+
+docstring InsetMathNest::completionPrefix(Cursor const & cur) const
+{
+       if (!cur.inMacroMode())
+               return docstring();
+       
+       return cur.activeMacro()->name();
+}
+
+
+bool InsetMathNest::insertCompletion(Cursor & cur, docstring const & s,
+                                    bool finished)
+{
+       if (!cur.inMacroMode())
+               return false;
+
+       // append completion to active macro
+       InsetMathUnknown * inset = cur.activeMacro();
+       inset->setName(inset->name() + s);
+
+       // finish macro
+       if (finished) {
+#if 0
+               // FIXME: this creates duplicates in the completion popup
+               // which looks ugly. Moreover the changes the list lengths
+               // which seems to
+               confuse the popup as well.
+               MathCompletionList::addToFavorites(inset->name());
+#endif
+               lyx::dispatch(FuncRequest(LFUN_SELF_INSERT, " "));
+       }
+
+       return true;
+}
+
+
+void InsetMathNest::completionPosAndDim(Cursor const & cur, int & x, int & y, 
+                                       Dimension & dim) const
+{
+       Inset const * inset = cur.activeMacro();
+       if (!inset)
+               return;
+
+       // get inset dimensions
+       dim = cur.bv().coordCache().insets().dim(inset);
+       // FIXME: these 3 are no accurate, but should depend on the font.
+       // Now the popup jumps down if you enter a char with descent > 0.
+       dim.des += 3;
+       dim.asc += 3;
+
+       // and position
+       Point xy
+       = cur.bv().coordCache().insets().xy(inset);
+       x = xy.x_;
+       y = xy.y_;
+}
+
+
+bool InsetMathNest::cursorMathForward(Cursor & cur)
+{
+       if (cur.pos() != cur.lastpos() && cur.openable(cur.nextAtom())) {
+               cur.pushBackward(*cur.nextAtom().nucleus());
+               cur.inset().idxFirst(cur);
+               return true;
+       } 
+       if (cur.posForward() || idxForward(cur) || cur.selection())
+               return true;
+       // try to pop forwards --- but don't pop out of math! leave that to
+       // the FINISH lfuns
+       int s = cur.depth() - 2;
+       if (s >= 0 && cur[s].inset().asInsetMath())
+               return cur.popForward();
+       return false;
+}
+
+
+bool InsetMathNest::cursorMathBackward(Cursor & cur)
+{
+       if (cur.pos() != 0 && cur.openable(cur.prevAtom())) {
+               cur.posBackward();
+               cur.push(*cur.nextAtom().nucleus());
+               cur.inset().idxLast(cur);
+               return true;
+       } 
+       if (cur.posBackward() || idxBackward(cur) || cur.selection())
+               return true;
+       // try to pop backwards --- but don't pop out of math! leave that to 
+       // the FINISH lfuns
+       int s = cur.depth() - 2;
+       if (s >= 0 && cur[s].inset().asInsetMath())
+               return cur.popBackward();
+       return false;
+}
+
+
+////////////////////////////////////////////////////////////////////
+
+MathCompletionList::MathCompletionList(Cursor const & cur)
+{
+       // fill it with macros from the buffer
+       MacroNameSet macros;
+       cur.buffer().listMacroNames(macros);
+       MacroNameSet::const_iterator it;
+       for (it = macros.begin(); it != macros.end(); ++it) {
+               if (cur.buffer().getMacro(*it, cur, false))
+                       locals.push_back("\\" + *it);
+       }
+       sort(locals.begin(), locals.end());
+
+       if (globals.size() > 0)
+               return;
+
+       // fill in global macros
+       macros.clear();
+       MacroTable::globalMacros().getMacroNames(macros);
+       lyxerr << "Globals completion macros: ";
+       for (it = macros.begin(); it != macros.end(); ++it) {
+               lyxerr << "\\" + *it << " ";
+               globals.push_back("\\" + *it);
+       }
+       lyxerr << std::endl;
+
+       // fill in global commands
+       globals.push_back(from_ascii("\\boxed"));
+       globals.push_back(from_ascii("\\fbox"));
+       globals.push_back(from_ascii("\\framebox"));
+       globals.push_back(from_ascii("\\makebox"));
+       globals.push_back(from_ascii("\\kern"));
+       globals.push_back(from_ascii("\\xrightarrow"));
+       globals.push_back(from_ascii("\\xleftarrow"));
+       globals.push_back(from_ascii("\\split"));
+       globals.push_back(from_ascii("\\gathered"));
+       globals.push_back(from_ascii("\\aligned"));
+       globals.push_back(from_ascii("\\alignedat"));
+       globals.push_back(from_ascii("\\cases"));
+       globals.push_back(from_ascii("\\substack"));
+       globals.push_back(from_ascii("\\subarray"));
+       globals.push_back(from_ascii("\\array"));
+       globals.push_back(from_ascii("\\sqrt"));
+       globals.push_back(from_ascii("\\root"));
+       globals.push_back(from_ascii("\\tabular"));
+       globals.push_back(from_ascii("\\stackrel"));
+       globals.push_back(from_ascii("\\binom"));
+       globals.push_back(from_ascii("\\choose"));
+       globals.push_back(from_ascii("\\brace"));
+       globals.push_back(from_ascii("\\brack"));
+       globals.push_back(from_ascii("\\frac"));
+       globals.push_back(from_ascii("\\over"));
+       globals.push_back(from_ascii("\\nicefrac"));
+       globals.push_back(from_ascii("\\unitfrac"));
+       globals.push_back(from_ascii("\\unitfracthree"));
+       globals.push_back(from_ascii("\\unitone"));
+       globals.push_back(from_ascii("\\unittwo"));
+       globals.push_back(from_ascii("\\infer"));
+       globals.push_back(from_ascii("\\atop"));
+       globals.push_back(from_ascii("\\lefteqn"));
+       globals.push_back(from_ascii("\\boldsymbol"));
+       globals.push_back(from_ascii("\\bm"));
+       globals.push_back(from_ascii("\\color"));
+       globals.push_back(from_ascii("\\normalcolor"));
+       globals.push_back(from_ascii("\\textcolor"));
+       globals.push_back(from_ascii("\\dfrac"));
+       globals.push_back(from_ascii("\\tfrac"));
+       globals.push_back(from_ascii("\\dbinom"));
+       globals.push_back(from_ascii("\\tbinom"));
+       globals.push_back(from_ascii("\\hphantom"));
+       globals.push_back(from_ascii("\\phantom"));
+       globals.push_back(from_ascii("\\vphantom"));
+       MathWordList const & words = mathedWordList();
+       MathWordList::const_iterator it2;
+       lyxerr << "Globals completion commands: ";
+       for (it2 = words.begin(); it2 != words.end(); ++it2) {
+               globals.push_back("\\" + (*it2).first);
+               lyxerr << "\\" + (*it2).first << " ";
+       }
+       lyxerr << std::endl;
+       sort(globals.begin(), globals.end());
+}
+
+
+MathCompletionList::~MathCompletionList()
+{
+}
+
+
+size_type MathCompletionList::size() const
+{
+       return locals.size() + globals.size();
+}
+
+
+docstring const & MathCompletionList::data(size_t idx) const
+{
+       size_t lsize = locals.size();
+       if (idx >= lsize)
+               return globals[idx - lsize];
+       else
+               return locals[idx];
+}
+
+
+std::string MathCompletionList::icon(size_t idx) const 
+{
+       // get the latex command
+       docstring cmd;
+       size_t lsize = locals.size();
+       if (idx >= lsize)
+               cmd = globals[idx - lsize];
+       else
+               cmd = locals[idx];
+       
+       // get the icon resource name by stripping the backslash
+       return "images/math/" + to_utf8(cmd.substr(1)) + ".png";
+}
+
+std::vector<docstring> MathCompletionList::globals;
+
 } // namespace lyx