]> git.lyx.org Git - features.git/blobdiff - src/mathed/InsetMathNest.cpp
* InsetTabular cleanup:
[features.git] / src / mathed / InsetMathNest.cpp
index e0cf27a5fbd6c2c92507a7dedb6cf97ae5cdf4b2..0a7810784acb6520c0380ce029f6ef7a23588263 100644 (file)
@@ -3,7 +3,7 @@
  * This file is part of LyX, the document processor.
  * Licence details can be found in the file COPYING.
  *
- * \author André Pönitz
+ * \author André Pönitz
  *
  * Full author contact details are available in file CREDITS.
  */
 #include "InsetMathNest.h"
 
 #include "InsetMathArray.h"
+#include "InsetMathAMSArray.h"
 #include "InsetMathBig.h"
 #include "InsetMathBox.h"
 #include "InsetMathBrace.h"
+#include "InsetMathChar.h"
 #include "InsetMathColor.h"
 #include "InsetMathComment.h"
 #include "InsetMathDelim.h"
+#include "InsetMathEnsureMath.h"
 #include "InsetMathHull.h"
 #include "InsetMathRef.h"
 #include "InsetMathScript.h"
 #include "InsetMathSpace.h"
 #include "InsetMathSymbol.h"
 #include "InsetMathUnknown.h"
+#include "MathAutoCorrect.h"
+#include "MathCompletionList.h"
 #include "MathData.h"
 #include "MathFactory.h"
 #include "MathMacro.h"
 #include "Cursor.h"
 #include "CutAndPaste.h"
 #include "DispatchResult.h"
+#include "Encoding.h"
 #include "FuncRequest.h"
 #include "FuncStatus.h"
-#include "LyXFunc.h"
+#include "LyX.h"
 #include "LyXRC.h"
 #include "OutputParams.h"
 #include "Text.h"
@@ -51,6 +57,7 @@
 #include "frontends/Painter.h"
 #include "frontends/Selection.h"
 
+#include "support/lassert.h"
 #include "support/debug.h"
 #include "support/gettext.h"
 #include "support/lstrings.h"
@@ -72,9 +79,11 @@ using cap::replaceSelection;
 using cap::selClearOrDel;
 
 
-InsetMathNest::InsetMathNest(idx_type nargs)
-       : cells_(nargs), lock_(false), mouse_hover_(false)
-{}
+InsetMathNest::InsetMathNest(Buffer * buf, idx_type nargs)
+       : InsetMath(buf), cells_(nargs), lock_(false), mouse_hover_(false)
+{
+       setBuffer(*buf);
+}
 
 
 InsetMathNest::InsetMathNest(InsetMathNest const & inset)
@@ -93,6 +102,17 @@ InsetMathNest & InsetMathNest::operator=(InsetMathNest const & inset)
 }
 
 
+void InsetMathNest::setBuffer(Buffer & buffer)
+{
+       InsetMath::setBuffer(buffer);
+       for (idx_type i = 0, n = nargs(); i != n; ++i) {
+               MathData & data = cell(i);
+               for (size_t j = 0; j != data.size(); ++j)
+                       data[j].nucleus()->setBuffer(buffer);
+       }
+}
+
+
 InsetMath::idx_type InsetMathNest::nargs() const
 {
        return cells_.size();
@@ -110,7 +130,7 @@ void InsetMathNest::cursorPos(BufferView const & bv,
 // to touch all (math)inset's draw() methods. Right now, we'll store
 // absolute value, and make them here relative, only to make them
 // absolute again when actually drawing the cursor. What a mess.
-       BOOST_ASSERT(&sl.inset() == this);
+       LASSERT(&sl.inset() == this, /**/);
        MathData const & ar = sl.cell();
        CoordCache const & coord_cache = bv.coordCache();
        if (!coord_cache.getArrays().has(&ar)) {
@@ -153,9 +173,17 @@ void InsetMathNest::metrics(MetricsInfo const & mi) const
 }
 
 
+void InsetMathNest::updateLabels(ParIterator const & it, UpdateType utype)
+{
+       for (idx_type i = 0, n = nargs(); i != n; ++i)
+               cell(i).updateLabels(it, utype);
+}
+
+
+
 bool InsetMathNest::idxNext(Cursor & cur) const
 {
-       BOOST_ASSERT(&cur.inset() == this);
+       LASSERT(&cur.inset() == this, /**/);
        if (cur.idx() == cur.lastidx())
                return false;
        ++cur.idx();
@@ -172,7 +200,7 @@ bool InsetMathNest::idxForward(Cursor & cur) const
 
 bool InsetMathNest::idxPrev(Cursor & cur) const
 {
-       BOOST_ASSERT(&cur.inset() == this);
+       LASSERT(&cur.inset() == this, /**/);
        if (cur.idx() == 0)
                return false;
        --cur.idx();
@@ -189,7 +217,7 @@ bool InsetMathNest::idxBackward(Cursor & cur) const
 
 bool InsetMathNest::idxFirst(Cursor & cur) const
 {
-       BOOST_ASSERT(&cur.inset() == this);
+       LASSERT(&cur.inset() == this, /**/);
        if (nargs() == 0)
                return false;
        cur.idx() = 0;
@@ -200,7 +228,7 @@ bool InsetMathNest::idxFirst(Cursor & cur) const
 
 bool InsetMathNest::idxLast(Cursor & cur) const
 {
-       BOOST_ASSERT(&cur.inset() == this);
+       LASSERT(&cur.inset() == this, /**/);
        if (nargs() == 0)
                return false;
        cur.idx() = cur.lastidx();
@@ -334,7 +362,9 @@ MathData InsetMathNest::glue() const
 
 void InsetMathNest::write(WriteStream & os) const
 {
-       os << '\\' << name().c_str();
+       ModeSpecifier specifier(os, currentMode(), lockedMode());
+       docstring const latex_name = name();
+       os << '\\' << latex_name;
        for (size_t i = 0; i < nargs(); ++i)
                os << '{' << cell(i) << '}';
        if (nargs() == 0)
@@ -348,17 +378,18 @@ void InsetMathNest::write(WriteStream & os) const
 
 void InsetMathNest::normalize(NormalStream & os) const
 {
-       os << '[' << name().c_str();
+       os << '[' << name();
        for (size_t i = 0; i < nargs(); ++i)
                os << ' ' << cell(i);
        os << ']';
 }
 
 
-int InsetMathNest::latex(Buffer const &, odocstream & os,
-                       OutputParams const & runparams) const
+int InsetMathNest::latex(odocstream & os, OutputParams const & runparams) const
 {
-       WriteStream wi(os, runparams.moving_arg, true);
+       WriteStream wi(os, runparams.moving_arg, true,
+                      runparams.dryrun ? WriteStream::wsDryrun : WriteStream::wsDefault,
+                      runparams.encoding);
        write(wi);
        return wi.line();
 }
@@ -409,45 +440,117 @@ void InsetMathNest::handleFont
 }
 
 
-void InsetMathNest::handleFont
-       (Cursor & cur, docstring const & arg, docstring const & font)
+void InsetMathNest::handleFont(Cursor & cur, docstring const & arg,
+       docstring const & font)
 {
+       cur.recordUndoSelection();
+
        // this whole function is a hack and won't work for incremental font
        // changes...
-
-       if (cur.inset().asInsetMath()->name() == font) {
-               cur.recordUndoInset();
+       if (cur.inset().asInsetMath()->name() == font)
                cur.handleFont(to_utf8(font));
-       } else {
-               cur.recordUndo();
-               cur.handleNest(createInsetMath(font));
+       else
+               handleNest(cur, createInsetMath(font, cur.buffer()), arg);
+}
+
+
+void InsetMathNest::handleNest(Cursor & cur, MathAtom const & nest)
+{
+       handleNest(cur, nest, docstring());
+}
+
+
+void InsetMathNest::handleNest(Cursor & cur, MathAtom const & nest,
+       docstring const & arg)
+{
+       CursorSlice i1 = cur.selBegin();
+       CursorSlice i2 = cur.selEnd();
+       if (!i1.inset().asInsetMath())
+               return;
+       if (i1.idx() == i2.idx()) {
+               // the easy case where only one cell is selected
+               cur.handleNest(nest);
                cur.insert(arg);
+               return;
+       }
+
+       // multiple selected cells in a simple non-grid inset
+       if (i1.asInsetMath()->nrows() == 0 || i1.asInsetMath()->ncols() == 0) {
+               for (idx_type i = i1.idx(); i <= i2.idx(); ++i) {
+                       // select cell
+                       cur.idx() = i;
+                       cur.pos() = 0;
+                       cur.resetAnchor();
+                       cur.pos() = cur.lastpos();
+                       cur.setSelection();
+
+                       // change font of cell
+                       cur.handleNest(nest);
+                       cur.insert(arg);
+
+                       // cur is in the font inset now. If the loop continues,
+                       // we need to get outside again for the next cell
+                       if (i + 1 <= i2.idx())
+                               cur.pop_back();
+               }
+               return;
+       }
+
+       // the complicated case with multiple selected cells in a grid
+       row_type r1, r2;
+       col_type c1, c2;
+       cap::region(i1, i2, r1, r2, c1, c2);
+       for (row_type row = r1; row <= r2; ++row) {
+               for (col_type col = c1; col <= c2; ++col) {
+                       // select cell
+                       cur.idx() = i1.asInsetMath()->index(row, col);
+                       cur.pos() = 0;
+                       cur.resetAnchor();
+                       cur.pos() = cur.lastpos();
+                       cur.setSelection();
+
+                       //
+                       cur.handleNest(nest);
+                       cur.insert(arg);
+
+                       // cur is in the font inset now. If the loop continues,
+                       // we need to get outside again for the next cell
+                       if (col + 1 <= c2 || row + 1 <= r2)
+                               cur.pop_back();
+               }
        }
 }
 
 
 void InsetMathNest::handleFont2(Cursor & cur, docstring const & arg)
 {
-       cur.recordUndo();
+       cur.recordUndoSelection();
        Font font;
        bool b;
        font.fromString(to_utf8(arg), b);
-       if (font.fontInfo().color() != Color_inherit) {
-               MathAtom at = MathAtom(new InsetMathColor(true, font.fontInfo().color()));
-               cur.handleNest(at, 0);
-       }
+       if (font.fontInfo().color() != Color_inherit &&
+           font.fontInfo().color() != Color_ignore)
+               handleNest(cur, MathAtom(new InsetMathColor(buffer_, true, font.fontInfo().color())));
+
+       // FIXME: support other font changes here as well?
 }
 
 
 void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
 {
-       //lyxerr << "InsetMathNest: request: " << cmd << endl;
-       //CursorSlice sl = cur.current();
+       //LYXERR0("InsetMathNest: request: " << cmd);
+
+       Parse::flags parseflg = Parse::QUIET | Parse::USETEXT;
 
        switch (cmd.action) {
 
+       case LFUN_CLIPBOARD_PASTE:
+               parseflg |= Parse::VERBATIM;
+               // fall through
        case LFUN_PASTE: {
-               cur.recordUndo();
+               if (cur.currentMode() <= TEXT_MODE)
+                       parseflg |= Parse::TEXTMODE;
+               cur.recordUndoSelection();
                cur.message(_("Paste"));
                replaceSelection(cur);
                docstring topaste;
@@ -457,10 +560,12 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                        size_t n = 0;
                        idocstringstream is(cmd.argument());
                        is >> n;
-                       topaste = cap::getSelection(cur.buffer(), n);
+                       topaste = cap::selection(n);
                }
-               cur.niceInsert(topaste);
+               cur.niceInsert(topaste, parseflg, false);
                cur.clearSelection(); // bug 393
+               // FIXME audit setBuffer/updateLabels calls
+               cur.buffer()->updateLabels();
                cur.finishUndo();
                break;
        }
@@ -472,6 +577,8 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                // Prevent stale position >= size crash
                // Probably not necessary anymore, see eraseSelection (gb 2005-10-09)
                cur.normalize();
+               // FIXME audit setBuffer/updateLabels calls
+               cur.buffer()->updateLabels();
                break;
 
        case LFUN_COPY:
@@ -512,22 +619,22 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
        case LFUN_CHAR_BACKWARD_SELECT:
        case LFUN_CHAR_FORWARD_SELECT: {
                // are we in a selection?
-               bool select = (cmd.action == LFUN_CHAR_RIGHT_SELECT 
+               bool select = (cmd.action == LFUN_CHAR_RIGHT_SELECT
                                           || cmd.action == LFUN_CHAR_LEFT_SELECT
                                           || cmd.action == LFUN_CHAR_BACKWARD_SELECT
                                           || cmd.action == LFUN_CHAR_FORWARD_SELECT);
-               // are we moving forward or backwards? 
+               // are we moving forward or backwards?
                // If the command was RIGHT or LEFT, then whether we're moving forward
                // or backwards depends on the cursor movement mode (logical or visual):
-               //  * in visual mode, since math is always LTR, right -> forward, 
+               //  * in visual mode, since math is always LTR, right -> forward,
                //    left -> backwards
                //  * in logical mode, the mapping is determined by the
                //    reverseDirectionNeeded() function
-               
+
                bool forward;
-               kb_action finish_lfun;
+               FuncCode finish_lfun;
 
-               if (cmd.action == LFUN_CHAR_FORWARD 
+               if (cmd.action == LFUN_CHAR_FORWARD
                                || cmd.action == LFUN_CHAR_FORWARD_SELECT) {
                        forward = true;
                        finish_lfun = LFUN_FINISHED_FORWARD;
@@ -542,7 +649,7 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                                                  || cmd.action == LFUN_CHAR_RIGHT);
                        if (lyxrc.visual_cursor || !reverseDirectionNeeded(cur))
                                forward = right;
-                       else 
+                       else
                                forward = !right;
 
                        if (right)
@@ -552,7 +659,6 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                }
                // Now that we know exactly what we want to do, let's do it!
                cur.selHandle(select);
-               cur.autocorrect() = false;
                cur.clearTargetX();
                cur.macroModeClose();
                // try moving forward or backwards as necessary...
@@ -575,18 +681,18 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                        cur.macroModeClose();
                        break;
                }
-               
+
                // stop/start the selection
                bool select = cmd.action == LFUN_DOWN_SELECT ||
                        cmd.action == LFUN_UP_SELECT;
                cur.selHandle(select);
-               
+
                // go up/down
                bool up = cmd.action == LFUN_UP || cmd.action == LFUN_UP_SELECT;
                bool successful = cur.upDownInMath(up);
                if (successful)
                        break;
-               
+
                if (cur.fixIfBroken())
                        // FIXME: Something bad happened. We pass the corrected Cursor
                        // instead of letting things go worse.
@@ -603,7 +709,7 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                cur.pos() = 0;
                cur.idx() = 0;
                cur.resetAnchor();
-               cur.selection() = true;
+               cur.setSelection(true);
                cur.pos() = cur.lastpos();
                cur.idx() = cur.lastidx();
                break;
@@ -623,7 +729,7 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
        case LFUN_WORD_BACKWARD_SELECT:
        case LFUN_WORD_LEFT_SELECT:
                cur.selHandle(cmd.action == LFUN_WORD_BACKWARD_SELECT ||
-                               cmd.action == LFUN_WORD_LEFT_SELECT || 
+                               cmd.action == LFUN_WORD_LEFT_SELECT ||
                                cmd.action == LFUN_LINE_BEGIN_SELECT);
                cur.macroModeClose();
                if (cur.pos() != 0) {
@@ -666,16 +772,6 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                }
                break;
 
-       case LFUN_SCREEN_UP_SELECT:
-               cmd = FuncRequest(LFUN_FINISHED_BACKWARD);
-               cur.undispatched();
-               break;
-
-       case LFUN_SCREEN_DOWN_SELECT:
-               cmd = FuncRequest(LFUN_FINISHED_FORWARD);
-               cur.undispatched();
-               break;
-
        case LFUN_CELL_FORWARD:
                cur.updateFlags(Update::Decoration | Update::FitCursor);
                cur.inset().idxNext(cur);
@@ -692,7 +788,7 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                        // May affect external cell:
                        cur.recordUndoInset();
                else
-                       cur.recordUndo();
+                       cur.recordUndoSelection();
                // if the inset can not be removed from within, delete it
                if (!cur.backspace()) {
                        FuncRequest cmd = FuncRequest(LFUN_CHAR_DELETE_FORWARD);
@@ -706,7 +802,7 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                        // May affect external cell:
                        cur.recordUndoInset();
                else
-                       cur.recordUndo();
+                       cur.recordUndoSelection();
                // if the inset can not be removed from within, delete it
                if (!cur.erase()) {
                        FuncRequest cmd = FuncRequest(LFUN_CHAR_DELETE_FORWARD);
@@ -733,13 +829,13 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
 
        case LFUN_SELF_INSERT:
                if (cmd.argument().size() != 1) {
-                       cur.recordUndo();
+                       cur.recordUndoSelection();
                        docstring const arg = cmd.argument();
                        if (!interpretString(cur, arg))
                                cur.insert(arg);
                        break;
                }
-               // Don't record undo steps if we are in macro mode and
+               // Don't record undo steps if we are in macro mode and thus
                // cmd.argument is the next character of the macro name.
                // Otherwise we'll get an invalid cursor if we undo after
                // the macro was finished and the macro is a known command,
@@ -748,8 +844,9 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                // InsetMathFrac -> a pos value > 0 is invalid.
                // A side effect is that an undo before the macro is finished
                // undoes the complete macro, not only the last character.
+               // At the time we hit '\' we are not in macro mode, still.
                if (!cur.inMacroMode())
-                       cur.recordUndo();
+                       cur.recordUndoSelection();
 
                // spacial handling of space. If we insert an inset
                // via macro mode, we want to put the cursor inside it
@@ -769,7 +866,6 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                break;
 
        //case LFUN_SERVER_GET_XY:
-       //      sprintf(dispatch_buffer, "%d %d",);
        //      break;
 
        case LFUN_SERVER_SET_XY: {
@@ -788,7 +884,7 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                if (cmd.argument().empty()) {
                        // do superscript if LyX handles
                        // deadkeys
-                       cur.recordUndo();
+                       cur.recordUndoSelection();
                        script(cur, true, grabAndEraseSelection(cur));
                }
                break;
@@ -810,37 +906,43 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                break;
 
        //  Math fonts
-       case LFUN_FONT_FREE_APPLY:
-       case LFUN_FONT_FREE_UPDATE:
+       case LFUN_TEXTSTYLE_APPLY:
+       case LFUN_TEXTSTYLE_UPDATE:
                handleFont2(cur, cmd.argument());
                break;
 
        case LFUN_FONT_BOLD:
-               if (currentMode() == TEXT_MODE)
+               if (currentMode() <= TEXT_MODE)
                        handleFont(cur, cmd.argument(), "textbf");
                else
                        handleFont(cur, cmd.argument(), "mathbf");
                break;
+       case LFUN_FONT_BOLDSYMBOL:
+               if (currentMode() <= TEXT_MODE)
+                       handleFont(cur, cmd.argument(), "textbf");
+               else
+                       handleFont(cur, cmd.argument(), "boldsymbol");
+               break;
        case LFUN_FONT_SANS:
-               if (currentMode() == TEXT_MODE)
+               if (currentMode() <= TEXT_MODE)
                        handleFont(cur, cmd.argument(), "textsf");
                else
                        handleFont(cur, cmd.argument(), "mathsf");
                break;
        case LFUN_FONT_EMPH:
-               if (currentMode() == TEXT_MODE)
+               if (currentMode() <= TEXT_MODE)
                        handleFont(cur, cmd.argument(), "emph");
                else
                        handleFont(cur, cmd.argument(), "mathcal");
                break;
        case LFUN_FONT_ROMAN:
-               if (currentMode() == TEXT_MODE)
+               if (currentMode() <= TEXT_MODE)
                        handleFont(cur, cmd.argument(), "textrm");
                else
                        handleFont(cur, cmd.argument(), "mathrm");
                break;
        case LFUN_FONT_TYPEWRITER:
-               if (currentMode() == TEXT_MODE)
+               if (currentMode() <= TEXT_MODE)
                        handleFont(cur, cmd.argument(), "texttt");
                else
                        handleFont(cur, cmd.argument(), "mathtt");
@@ -849,43 +951,49 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                handleFont(cur, cmd.argument(), "mathfrak");
                break;
        case LFUN_FONT_ITAL:
-               if (currentMode() == TEXT_MODE)
+               if (currentMode() <= TEXT_MODE)
                        handleFont(cur, cmd.argument(), "textit");
                else
                        handleFont(cur, cmd.argument(), "mathit");
                break;
        case LFUN_FONT_NOUN:
-               if (currentMode() == TEXT_MODE)
+               if (currentMode() <= TEXT_MODE)
                        // FIXME: should be "noun"
                        handleFont(cur, cmd.argument(), "textsc");
                else
                        handleFont(cur, cmd.argument(), "mathbb");
                break;
-       /*
-       case LFUN_FONT_FREE_APPLY:
-               handleFont(cur, cmd.argument(), "textrm");
-               break;
-       */
        case LFUN_FONT_DEFAULT:
                handleFont(cur, cmd.argument(), "textnormal");
                break;
 
+       case LFUN_FONT_UNDERLINE:
+               cur.recordUndo();
+               cur.handleNest(createInsetMath("underline", cur.buffer()));
+               break;
        case LFUN_MATH_MODE: {
 #if 1
                // ignore math-mode on when already in math mode
                if (currentMode() == Inset::MATH_MODE && cmd.argument() == "on")
                        break;
+               cur.recordUndoSelection();
                cur.macroModeClose();
                docstring const save_selection = grabAndEraseSelection(cur);
                selClearOrDel(cur);
                //cur.plainInsert(MathAtom(new InsetMathMBox(cur.bv())));
-               cur.plainInsert(MathAtom(new InsetMathBox(from_ascii("mbox"))));
+               if (currentMode() <= Inset::TEXT_MODE)
+                       cur.plainInsert(MathAtom(new InsetMathEnsureMath(buffer_)));
+               else
+                       cur.plainInsert(MathAtom(new InsetMathBox(buffer_, from_ascii("mbox"))));
                cur.posBackward();
                cur.pushBackward(*cur.nextInset());
                cur.niceInsert(save_selection);
+               // FIXME audit setBuffer/updateLabels calls
+               cur.buffer()->updateLabels();
 #else
                if (currentMode() == Inset::TEXT_MODE) {
-                       cur.niceInsert(MathAtom(new InsetMathHull("simple")));
+                       cur.recordUndoSelection();
+                       cur.niceInsert(MathAtom(new InsetMathHull("simple", cur.buffer())));
                        cur.message(_("create new math text environment ($...$)"));
                } else {
                        handleFont(cur, cmd.argument(), "textrm");
@@ -895,12 +1003,34 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                break;
        }
 
-       case LFUN_MATH_SIZE:
-#if 0
-               cur.recordUndo();
-               cur.setSize(arg);
-#endif
+       case LFUN_REGEXP_MODE: {
+               InsetMathHull * i = dynamic_cast<InsetMathHull *>(cur.inset().asInsetMath());
+               if (i && i->getType() == hullRegexp) {
+                       cur.message(_("Already in regular expression mode"));
+                       break;
+               }
+               cur.macroModeClose();
+               docstring const save_selection = grabAndEraseSelection(cur);
+               selClearOrDel(cur);
+               cur.plainInsert(MathAtom(new InsetMathHull(buffer_, hullRegexp)));
+               cur.posBackward();
+               cur.pushBackward(*cur.nextInset());
+               cur.niceInsert(save_selection);
+               cur.message(_("Regular expression editor mode"));
                break;
+       }
+
+       case LFUN_MATH_FONT_STYLE: {
+               FuncRequest fr = FuncRequest(LFUN_MATH_INSERT, '\\' + cmd.argument());
+               doDispatch(cur, fr);
+               break;
+       }
+
+       case LFUN_MATH_SIZE: {
+               FuncRequest fr = FuncRequest(LFUN_MATH_INSERT, cmd.argument());
+               doDispatch(cur, fr);
+               break;
+       }
 
        case LFUN_MATH_MATRIX: {
                cur.recordUndo();
@@ -915,8 +1045,24 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                if (n < 1)
                        n = 1;
                v_align += 'c';
+               cur.niceInsert(MathAtom(new InsetMathArray(buffer_,
+                       from_ascii("array"), m, n, (char)v_align[0], h_align)));
+               break;
+       }
+
+       case LFUN_MATH_AMS_MATRIX: {
+               cur.recordUndo();
+               unsigned int m = 1;
+               unsigned int n = 1;
+               docstring name;
+               idocstringstream is(cmd.argument());
+               is >> m >> n >> name;
+               if (m < 1)
+                       m = 1;
+               if (n < 1)
+                       n = 1;
                cur.niceInsert(
-                       MathAtom(new InsetMathArray(from_ascii("array"), m, n, (char)v_align[0], h_align)));
+                       MathAtom(new InsetMathAMSArray(buffer_, name, m, n)));
                break;
        }
 
@@ -929,7 +1075,7 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                if (rs.empty())
                        rs = ')';
                cur.recordUndo();
-               cur.handleNest(MathAtom(new InsetMathDelim(ls, rs)));
+               cur.handleNest(MathAtom(new InsetMathDelim(buffer_, ls, rs)));
                break;
        }
 
@@ -964,9 +1110,19 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
        }
 
        case LFUN_SPACE_INSERT:
+               cur.recordUndoSelection();
+               cur.insert(MathAtom(new InsetMathSpace));
+               break;
+
        case LFUN_MATH_SPACE:
-               cur.recordUndo();
-               cur.insert(MathAtom(new InsetMathSpace(from_ascii(","))));
+               cur.recordUndoSelection();
+               if (cmd.argument().empty())
+                       cur.insert(MathAtom(new InsetMathSpace));
+               else {
+                       string const name = cmd.getArg(0);
+                       string const len = cmd.getArg(1);
+                       cur.insert(MathAtom(new InsetMathSpace(name, len)));
+               }
                break;
 
        case LFUN_ERT_INSERT:
@@ -977,16 +1133,16 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
 
        case LFUN_MATH_SUBSCRIPT:
                // interpret this as if a _ was typed
-               cur.recordUndo();
+               cur.recordUndoSelection();
                interpretChar(cur, '_');
                break;
 
        case LFUN_MATH_SUPERSCRIPT:
                // interpret this as if a ^ was typed
-               cur.recordUndo();
+               cur.recordUndoSelection();
                interpretChar(cur, '^');
                break;
-               
+
        case LFUN_MATH_MACRO_FOLD:
        case LFUN_MATH_MACRO_UNFOLD: {
                Cursor it = cur;
@@ -1005,7 +1161,7 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
 
        case LFUN_QUOTE_INSERT:
                // interpret this as if a straight " was typed
-               cur.recordUndo();
+               cur.recordUndoSelection();
                interpretChar(cur, '\"');
                break;
 
@@ -1013,11 +1169,19 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
 // handling such that "self-insert" works on "arbitrary stuff" too, and
 // math-insert only handles special math things like "matrix".
        case LFUN_MATH_INSERT: {
-               cur.recordUndo();
-               if (cmd.argument() == "^" || cmd.argument() == "_") {
+               cur.recordUndoSelection();
+               if (cmd.argument() == "^" || cmd.argument() == "_")
                        interpretChar(cur, cmd.argument()[0]);
-               } else
-                       cur.niceInsert(cmd.argument());
+               else {
+                       MathData ar;
+                       asArray(cmd.argument(), ar);
+                       if (cur.selection() && ar.size() == 1
+                           && ar[0]->asNestInset()
+                           && ar[0]->asNestInset()->nargs() > 1)
+                               handleNest(cur, ar[0]);
+                       else
+                               cur.niceInsert(cmd.argument());
+               }
                break;
                }
 
@@ -1025,8 +1189,11 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
                docstring const & name = cmd.argument();
                string data;
                if (name == "ref") {
-                       InsetMathRef tmp(name);
+                       InsetMathRef tmp(buffer_, name);
                        data = tmp.createDialogStr(to_utf8(name));
+               } else if (name == "mathspace") {
+                       InsetMathSpace tmp;
+                       data = tmp.createDialogStr();
                }
                cur.bv().showDialog(to_utf8(name), data);
                break;
@@ -1035,8 +1202,10 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
        case LFUN_INSET_INSERT: {
                MathData ar;
                if (createInsetMath_fromDialogStr(cmd.argument(), ar)) {
-                       cur.recordUndo();
+                       cur.recordUndoSelection();
                        cur.insert(ar);
+                       // FIXME audit setBuffer/updateLabels calls
+                       cur.buffer()->updateLabels();
                } else
                        cur.undispatched();
                break;
@@ -1058,7 +1227,7 @@ void InsetMathNest::doDispatch(Cursor & cur, FuncRequest & cmd)
 bool InsetMathNest::findMacroToFoldUnfold(Cursor & it, bool fold) const {
        // look for macro to open/close, but stay in mathed
        for (; !it.empty(); it.pop_back()) {
-                       
+
                // go backward through the current cell
                Inset * inset = it.nextInset();
                while (inset && inset->asInsetMath()) {
@@ -1067,24 +1236,24 @@ bool InsetMathNest::findMacroToFoldUnfold(Cursor & it, bool fold) const {
                                // found the an macro to open/close?
                                if (macro->folded() != fold)
                                        return true;
-                               
+
                                // Wrong folding state.
                                // If this was the first we see in this slice, look further left,
                                // otherwise go up.
                                if (inset != it.nextInset())
                                        break;
                        }
-                       
+
                        // go up if this was the left most position
                        if (it.pos() == 0)
                                break;
-                       
+
                        // go left
                        it.pos()--;
                        inset = it.nextInset();
                }
        }
-       
+
        return false;
 }
 
@@ -1097,11 +1266,11 @@ bool InsetMathNest::getStatus(Cursor & cur, FuncRequest const & cmd,
        bool ret = true;
        string const arg = to_utf8(cmd.argument());
        switch (cmd.action) {
-       case LFUN_TABULAR_FEATURE:
-               flag.enabled(false);
+       case LFUN_INSET_MODIFY:
+               flag.setEnabled(false);
                break;
 #if 0
-       case LFUN_TABULAR_FEATURE:
+       case LFUN_INSET_MODIFY:
                // FIXME: check temporarily disabled
                // valign code
                char align = mathcursor::valign();
@@ -1123,17 +1292,14 @@ bool InsetMathNest::getStatus(Cursor & cur, FuncRequest const & cmd,
        /// We have to handle them since 1.4 blocks all unhandled actions
        case LFUN_FONT_ITAL:
        case LFUN_FONT_BOLD:
+       case LFUN_FONT_BOLDSYMBOL:
        case LFUN_FONT_SANS:
        case LFUN_FONT_EMPH:
        case LFUN_FONT_TYPEWRITER:
        case LFUN_FONT_NOUN:
        case LFUN_FONT_ROMAN:
        case LFUN_FONT_DEFAULT:
-               flag.enabled(true);
-               break;
-       case LFUN_MATH_MUTATE:
-               //flag.setOnOff(mathcursor::formula()->hullType() == to_utf8(cmd.argument()));
-               flag.setOnOff(false);
+               flag.setEnabled(true);
                break;
 
        // we just need to be in math mode to enable that
@@ -1141,27 +1307,33 @@ bool InsetMathNest::getStatus(Cursor & cur, FuncRequest const & cmd,
        case LFUN_MATH_SPACE:
        case LFUN_MATH_LIMITS:
        case LFUN_MATH_EXTERN:
-               flag.enabled(true);
+               flag.setEnabled(true);
                break;
 
+       case LFUN_FONT_UNDERLINE:
        case LFUN_FONT_FRAK:
-               flag.enabled(currentMode() != TEXT_MODE);
+               flag.setEnabled(currentMode() != TEXT_MODE);
                break;
 
-       case LFUN_MATH_INSERT: {
+       case LFUN_MATH_FONT_STYLE: {
                bool const textarg =
-                       arg == "\\textbf"   || arg == "\\textsf" ||
-                       arg == "\\textrm"   || arg == "\\textmd" ||
-                       arg == "\\textit"   || arg == "\\textsc" ||
-                       arg == "\\textsl"   || arg == "\\textup" ||
-                       arg == "\\texttt"   || arg == "\\textbb" ||
-                       arg == "\\textnormal";
-               flag.enabled(currentMode() != TEXT_MODE || textarg);
+                       arg == "textbf"   || arg == "textsf" ||
+                       arg == "textrm"   || arg == "textmd" ||
+                       arg == "textit"   || arg == "textsc" ||
+                       arg == "textsl"   || arg == "textup" ||
+                       arg == "texttt"   || arg == "textbb" ||
+                       arg == "textnormal";
+               flag.setEnabled(currentMode() != TEXT_MODE || textarg);
                break;
        }
 
+       case LFUN_MATH_INSERT:
+               flag.setEnabled(currentMode() != TEXT_MODE);
+               break;
+
+       case LFUN_MATH_AMS_MATRIX:
        case LFUN_MATH_MATRIX:
-               flag.enabled(currentMode() == MATH_MODE);
+               flag.setEnabled(currentMode() == MATH_MODE);
                break;
 
        case LFUN_INSET_INSERT: {
@@ -1169,31 +1341,31 @@ bool InsetMathNest::getStatus(Cursor & cur, FuncRequest const & cmd,
                // getStatus is not called with a valid reference and the
                // dialog would not be applyable.
                string const name = cmd.getArg(0);
-               flag.enabled(name == "ref");
+               flag.setEnabled(name == "ref" || name == "mathspace");
                break;
        }
 
        case LFUN_MATH_DELIM:
        case LFUN_MATH_BIGDELIM:
                // Don't do this with multi-cell selections
-               flag.enabled(cur.selBegin().idx() == cur.selEnd().idx());
+               flag.setEnabled(cur.selBegin().idx() == cur.selEnd().idx());
                break;
-               
+
        case LFUN_MATH_MACRO_FOLD:
        case LFUN_MATH_MACRO_UNFOLD: {
                Cursor it = cur;
                bool found = findMacroToFoldUnfold(it, cmd.action == LFUN_MATH_MACRO_FOLD);
-               flag.enabled(found);
+               flag.setEnabled(found);
                break;
        }
-               
+
        case LFUN_SPECIALCHAR_INSERT:
                // FIXME: These would probably make sense in math-text mode
-               flag.enabled(false);
+               flag.setEnabled(false);
                break;
 
        case LFUN_INSET_DISSOLVE:
-               flag.enabled(!asHullInset());
+               flag.setEnabled(!asHullInset());
                break;
 
        default:
@@ -1207,7 +1379,7 @@ bool InsetMathNest::getStatus(Cursor & cur, FuncRequest const & cmd,
 void InsetMathNest::edit(Cursor & cur, bool front, EntryDirection entry_from)
 {
        cur.push(*this);
-       bool enter_front = (entry_from == Inset::ENTRY_DIRECTION_RIGHT || 
+       bool enter_front = (entry_from == Inset::ENTRY_DIRECTION_RIGHT ||
                (entry_from == Inset::ENTRY_DIRECTION_IGNORE && front));
        cur.idx() = enter_front ? 0 : cur.lastidx();
        cur.pos() = enter_front ? 0 : cur.lastpos();
@@ -1260,7 +1432,7 @@ void InsetMathNest::lfunMousePress(Cursor & cur, FuncRequest & cmd)
                // Update::FitCursor: adjust the screen to the cursor
                //                    position if needed
                // cur.result().update(): don't overwrite previously set flags.
-               cur.updateFlags(Update::Decoration | Update::FitCursor 
+               cur.updateFlags(Update::Decoration | Update::FitCursor
                                | cur.result().update());
        } else if (cmd.button() == mouse_button::button2) {
                if (cap::selection()) {
@@ -1285,7 +1457,7 @@ void InsetMathNest::lfunMouseMotion(Cursor & cur, FuncRequest & cmd)
                if (bvcur.anchor_.hasPart(cur)) {
                        //lyxerr << "## lfunMouseMotion: cursor: " << cur << endl;
                        bvcur.setCursor(cur);
-                       bvcur.selection() = true;
+                       bvcur.setSelection(true);
                        //lyxerr << "MOTION " << bvcur << endl;
                } else
                        cur.undispatched();
@@ -1302,7 +1474,7 @@ void InsetMathNest::lfunMouseRelease(Cursor & cur, FuncRequest & cmd)
                        cur.noUpdate();
                else {
                        Cursor & bvcur = cur.bv().cursor();
-                       bvcur.selection() = true;
+                       bvcur.setSelection(true);
                }
                return;
        }
@@ -1311,7 +1483,7 @@ void InsetMathNest::lfunMouseRelease(Cursor & cur, FuncRequest & cmd)
 }
 
 
-bool InsetMathNest::interpretChar(Cursor & cur, char_type c)
+bool InsetMathNest::interpretChar(Cursor & cur, char_type const c)
 {
        //lyxerr << "interpret 2: '" << c << "'" << endl;
        docstring save_selection;
@@ -1319,6 +1491,7 @@ bool InsetMathNest::interpretChar(Cursor & cur, char_type c)
                save_selection = grabAndEraseSelection(cur);
 
        cur.clearTargetX();
+       Buffer * buf = cur.buffer();
 
        // handle macroMode
        if (cur.inMacroMode()) {
@@ -1333,7 +1506,12 @@ bool InsetMathNest::interpretChar(Cursor & cur, char_type c)
                        return true;
                }
 
-               if (isAlphaASCII(c)) {
+               // do not finish macro for known * commands
+               MathWordList const & mwl = mathedWordList();
+               bool star_macro = c == '*'
+                       && (mwl.find(name.substr(1) + "*") != mwl.end()
+                           || cur.buffer()->getMacro(name.substr(1) + "*", cur, true));
+               if (isAlphaASCII(c) || star_macro) {
                        cur.activeMacro()->setName(name + docstring(1, c));
                        return true;
                }
@@ -1343,22 +1521,25 @@ bool InsetMathNest::interpretChar(Cursor & cur, char_type c)
                        // remove the '\\'
                        if (c == '\\') {
                                cur.backspace();
-                               if (currentMode() == InsetMath::TEXT_MODE)
-                                       cur.niceInsert(createInsetMath("textbackslash"));
+                               if (currentMode() <= InsetMath::TEXT_MODE)
+                                       cur.niceInsert(createInsetMath("textbackslash", buf));
                                else
-                                       cur.niceInsert(createInsetMath("backslash"));
+                                       cur.niceInsert(createInsetMath("backslash", buf));
+                       } else if (c == '^' && currentMode() == InsetMath::MATH_MODE) {
+                               cur.backspace();
+                               cur.niceInsert(createInsetMath("mathcircumflex", buf));
                        } else if (c == '{') {
                                cur.backspace();
-                               cur.niceInsert(MathAtom(new InsetMathBrace));
+                               cur.niceInsert(MathAtom(new InsetMathBrace(buf)));
                        } else if (c == '%') {
                                cur.backspace();
-                               cur.niceInsert(MathAtom(new InsetMathComment));
+                               cur.niceInsert(MathAtom(new InsetMathComment(buf)));
                        } else if (c == '#') {
-                               BOOST_ASSERT(cur.activeMacro());
+                               LASSERT(cur.activeMacro(), /**/);
                                cur.activeMacro()->setName(name + docstring(1, c));
                        } else {
                                cur.backspace();
-                               cur.niceInsert(createInsetMath(docstring(1, c)));
+                               cur.niceInsert(createInsetMath(docstring(1, c), buf));
                        }
                        return true;
                }
@@ -1394,48 +1575,60 @@ bool InsetMathNest::interpretChar(Cursor & cur, char_type c)
                }
 
                // leave macro mode and try again if necessary
-               cur.macroModeClose();
+               if (cur.macroModeClose()) {
+                       MathAtom const atom = cur.prevAtom();
+                       if (atom->asNestInset() && atom->isActive()) {
+                               cur.posBackward();
+                               cur.pushBackward(*cur.nextInset());
+                       }
+               }
                if (c == '{')
-                       cur.niceInsert(MathAtom(new InsetMathBrace));
+                       cur.niceInsert(MathAtom(new InsetMathBrace(buf)));
                else if (c != ' ')
                        interpretChar(cur, c);
                return true;
        }
 
-       // This is annoying as one has to press <space> far too often.
-       // Disable it.
 
-#if 0
-               // leave autocorrect mode if necessary
-               if (autocorrect() && c == ' ') {
-                       autocorrect() = false;
-                       return true;
-               }
-#endif
+       // leave autocorrect mode if necessary
+       if (lyxrc.autocorrection_math && c == ' ' && cur.autocorrect()) {
+               cur.autocorrect() = false;
+               cur.message(_("Autocorrect Off ('!' to enter)"));
+               return true;
+       } 
+       if (lyxrc.autocorrection_math && c == '!' && !cur.autocorrect()) {
+               cur.autocorrect() = true;
+               cur.message(_("Autocorrect On (<space> to exit)"));
+               return true;
+       }
 
        // just clear selection on pressing the space bar
        if (cur.selection() && c == ' ') {
-               cur.selection() = false;
+               cur.setSelection(false);
                return true;
        }
 
-       selClearOrDel(cur);
-
        if (c == '\\') {
                //lyxerr << "starting with macro" << endl;
-               cur.insert(MathAtom(new InsetMathUnknown(from_ascii("\\"), false)));
+               bool reduced = cap::reduceSelectionToOneCell(cur);
+               if (reduced || !cur.selection()) {
+                       docstring const safe = cap::grabAndEraseSelection(cur);
+                       cur.insert(MathAtom(new InsetMathUnknown(from_ascii("\\"), safe, false)));
+               }
                return true;
        }
 
+       selClearOrDel(cur);
+
        if (c == '\n') {
-               if (currentMode() == InsetMath::TEXT_MODE)
+               if (currentMode() <= InsetMath::TEXT_MODE)
                        cur.insert(c);
                return true;
        }
 
        if (c == ' ') {
-               if (currentMode() == InsetMath::TEXT_MODE) {
-                       // insert spaces in text mode,
+               if (currentMode() <= InsetMath::TEXT_MODE) {
+                       // insert spaces in text or undecided mode,
                        // but suppress direct insertion of two spaces in a row
                        // the still allows typing  '<space>a<space>' and deleting the 'a', but
                        // it is better than nothing...
@@ -1472,7 +1665,7 @@ bool InsetMathNest::interpretChar(Cursor & cur, char_type c)
                return cur.pos() != cur.lastpos();
        }
 
-       // These shouldn't work in text mode:
+       // These should be treated differently when not in text mode:
        if (currentMode() != InsetMath::TEXT_MODE) {
                if (c == '_') {
                        script(cur, false, save_selection);
@@ -1483,25 +1676,47 @@ bool InsetMathNest::interpretChar(Cursor & cur, char_type c)
                        return true;
                }
                if (c == '~') {
-                       cur.niceInsert(createInsetMath("sim"));
+                       cur.niceInsert(createInsetMath("sim", buf));
+                       return true;
+               }
+               if (currentMode() == InsetMath::MATH_MODE && !isAsciiOrMathAlpha(c)) {
+                       MathAtom at = createInsetMath("text", buf);
+                       at.nucleus()->cell(0).push_back(MathAtom(new InsetMathChar(c)));
+                       cur.niceInsert(at);
+                       cur.posForward();
+                       return true;
+               }
+       } else {
+               if (c == '^') {
+                       cur.niceInsert(createInsetMath("textasciicircum", buf));
+                       return true;
+               }
+               if (c == '~') {
+                       cur.niceInsert(createInsetMath("textasciitilde", buf));
                        return true;
                }
        }
 
        if (c == '{' || c == '}' || c == '&' || c == '$' || c == '#' ||
-           c == '%' || c == '_' || c == '^') {
-               cur.niceInsert(createInsetMath(docstring(1, c)));
+           c == '%' || c == '_') {
+               cur.niceInsert(createInsetMath(docstring(1, c), buf));
                return true;
        }
 
 
        // try auto-correction
-       //if (autocorrect() && hasPrevAtom() && math_autocorrect(prevAtom(), c))
-       //      return true;
+       if (lyxrc.autocorrection_math && cur.autocorrect() && cur.pos() != 0
+                 && math_autocorrect(cur.prevAtom(), c))
+               return true;
 
        // no special circumstances, so insert the character without any fuss
        cur.insert(c);
-       cur.autocorrect() = true;
+       if (lyxrc.autocorrection_math) {
+               if (!cur.autocorrect())
+                       cur.message(_("Autocorrect Off ('!' to enter)"));
+               else
+                       cur.message(_("Autocorrect On (<space> to exit)"));
+       }
        return true;
 }
 
@@ -1529,6 +1744,12 @@ bool InsetMathNest::interpretString(Cursor & cur, docstring const & str)
 }
 
 
+bool InsetMathNest::script(Cursor & cur, bool up)
+{
+       return script(cur, up, docstring());
+}
+
+
 bool InsetMathNest::script(Cursor & cur, bool up,
                docstring const & save_selection)
 {
@@ -1536,7 +1757,7 @@ bool InsetMathNest::script(Cursor & cur, bool up,
        //lyxerr << "handling script: up: " << up << endl;
        if (cur.inMacroMode() && cur.macroName() == "\\") {
                if (up)
-                       cur.niceInsert(createInsetMath("mathcircumflex"));
+                       cur.niceInsert(createInsetMath("mathcircumflex", cur.buffer()));
                else
                        interpretChar(cur, '_');
                return true;
@@ -1562,10 +1783,10 @@ bool InsetMathNest::script(Cursor & cur, bool up,
                // one if in the very first position of the array
                if (cur.pos() == 0) {
                        //lyxerr << "new scriptinset" << endl;
-                       cur.insert(new InsetMathScript(up));
+                       cur.insert(new InsetMathScript(buffer_, up));
                } else {
                        //lyxerr << "converting prev atom " << endl;
-                       cur.prevAtom() = MathAtom(new InsetMathScript(cur.prevAtom(), up));
+                       cur.prevAtom() = MathAtom(new InsetMathScript(buffer_, cur.prevAtom(), up));
                }
                --cur.pos();
                InsetMathScript * inset = cur.nextAtom().nucleus()->asScriptInset();
@@ -1607,12 +1828,12 @@ bool InsetMathNest::automaticPopupCompletion() const
 }
 
 
-Inset::CompletionList const *
+CompletionList const *
 InsetMathNest::createCompletionList(Cursor const & cur) const
 {
        if (!cur.inMacroMode())
                return 0;
-       
+
        return new MathCompletionList(cur);
 }
 
@@ -1621,7 +1842,7 @@ docstring InsetMathNest::completionPrefix(Cursor const & cur) const
 {
        if (!cur.inMacroMode())
                return docstring();
-       
+
        return cur.activeMacro()->name();
 }
 
@@ -1652,7 +1873,7 @@ bool InsetMathNest::insertCompletion(Cursor & cur, docstring const & s,
 }
 
 
-void InsetMathNest::completionPosAndDim(Cursor const & cur, int & x, int & y, 
+void InsetMathNest::completionPosAndDim(Cursor const & cur, int & x, int & y,
                                        Dimension & dim) const
 {
        Inset const * inset = cur.activeMacro();
@@ -1680,8 +1901,8 @@ bool InsetMathNest::cursorMathForward(Cursor & cur)
                cur.pushBackward(*cur.nextAtom().nucleus());
                cur.inset().idxFirst(cur);
                return true;
-       } 
-       if (cur.posForward() || idxForward(cur) || cur.selection())
+       }
+       if (cur.posForward() || idxForward(cur))
                return true;
        // try to pop forwards --- but don't pop out of math! leave that to
        // the FINISH lfuns
@@ -1699,10 +1920,10 @@ bool InsetMathNest::cursorMathBackward(Cursor & cur)
                cur.push(*cur.nextAtom().nucleus());
                cur.inset().idxLast(cur);
                return true;
-       } 
-       if (cur.posBackward() || idxBackward(cur) || cur.selection())
+       }
+       if (cur.posBackward() || idxBackward(cur))
                return true;
-       // try to pop backwards --- but don't pop out of math! leave that to 
+       // try to pop backwards --- but don't pop out of math! leave that to
        // the FINISH lfuns
        int s = cur.depth() - 2;
        if (s >= 0 && cur[s].inset().asInsetMath())
@@ -1716,11 +1937,11 @@ bool InsetMathNest::cursorMathBackward(Cursor & cur)
 MathCompletionList::MathCompletionList(Cursor const & cur)
 {
        // fill it with macros from the buffer
-       Buffer::MacroNameSet macros;
-       cur.buffer().listMacroNames(macros);
-       Buffer::MacroNameSet::const_iterator it;
+       MacroNameSet macros;
+       cur.buffer()->listMacroNames(macros);
+       MacroNameSet::const_iterator it;
        for (it = macros.begin(); it != macros.end(); ++it) {
-               if (cur.buffer().getMacro(*it, cur, false))
+               if (cur.buffer()->getMacro(*it, cur, false))
                        locals.push_back("\\" + *it);
        }
        sort(locals.begin(), locals.end());
@@ -1731,12 +1952,12 @@ MathCompletionList::MathCompletionList(Cursor const & cur)
        // fill in global macros
        macros.clear();
        MacroTable::globalMacros().getMacroNames(macros);
-       lyxerr << "Globals completion macros: ";
+       //lyxerr << "Globals completion macros: ";
        for (it = macros.begin(); it != macros.end(); ++it) {
-               lyxerr << "\\" + *it << " ";
+               //lyxerr << "\\" + *it << " ";
                globals.push_back("\\" + *it);
        }
-       lyxerr << std::endl;
+       //lyxerr << std::endl;
 
        // fill in global commands
        globals.push_back(from_ascii("\\boxed"));
@@ -1752,6 +1973,7 @@ MathCompletionList::MathCompletionList(Cursor const & cur)
        globals.push_back(from_ascii("\\alignedat"));
        globals.push_back(from_ascii("\\cases"));
        globals.push_back(from_ascii("\\substack"));
+       globals.push_back(from_ascii("\\xymatrix"));
        globals.push_back(from_ascii("\\subarray"));
        globals.push_back(from_ascii("\\array"));
        globals.push_back(from_ascii("\\sqrt"));
@@ -1760,7 +1982,8 @@ MathCompletionList::MathCompletionList(Cursor const & cur)
        globals.push_back(from_ascii("\\stackrel"));
        globals.push_back(from_ascii("\\binom"));
        globals.push_back(from_ascii("\\choose"));
-       globals.push_back(from_ascii("\\choose"));
+       globals.push_back(from_ascii("\\brace"));
+       globals.push_back(from_ascii("\\brack"));
        globals.push_back(from_ascii("\\frac"));
        globals.push_back(from_ascii("\\over"));
        globals.push_back(from_ascii("\\nicefrac"));
@@ -1772,9 +1995,13 @@ MathCompletionList::MathCompletionList(Cursor const & cur)
        globals.push_back(from_ascii("\\atop"));
        globals.push_back(from_ascii("\\lefteqn"));
        globals.push_back(from_ascii("\\boldsymbol"));
+       globals.push_back(from_ascii("\\bm"));
        globals.push_back(from_ascii("\\color"));
        globals.push_back(from_ascii("\\normalcolor"));
        globals.push_back(from_ascii("\\textcolor"));
+       globals.push_back(from_ascii("\\cfrac"));
+       globals.push_back(from_ascii("\\cfracleft"));
+       globals.push_back(from_ascii("\\cfracright"));
        globals.push_back(from_ascii("\\dfrac"));
        globals.push_back(from_ascii("\\tfrac"));
        globals.push_back(from_ascii("\\dbinom"));
@@ -1782,14 +2009,14 @@ MathCompletionList::MathCompletionList(Cursor const & cur)
        globals.push_back(from_ascii("\\hphantom"));
        globals.push_back(from_ascii("\\phantom"));
        globals.push_back(from_ascii("\\vphantom"));
-       WordList const & words = mathedWordList();
-       WordList::const_iterator it2;
-       lyxerr << "Globals completion commands: ";
+       MathWordList const & words = mathedWordList();
+       MathWordList::const_iterator it2;
+       //lyxerr << "Globals completion commands: ";
        for (it2 = words.begin(); it2 != words.end(); ++it2) {
                globals.push_back("\\" + (*it2).first);
-               lyxerr << "\\" + (*it2).first << " ";
+               //lyxerr << "\\" + (*it2).first << " ";
        }
-       lyxerr << std::endl;
+       //lyxerr << std::endl;
        sort(globals.begin(), globals.end());
 }
 
@@ -1805,7 +2032,7 @@ size_type MathCompletionList::size() const
 }
 
 
-docstring MathCompletionList::data(size_t idx) const
+docstring const & MathCompletionList::data(size_t idx) const
 {
        size_t lsize = locals.size();
        if (idx >= lsize)
@@ -1815,7 +2042,7 @@ docstring MathCompletionList::data(size_t idx) const
 }
 
 
-std::string MathCompletionList::icon(size_t idx) const 
+std::string MathCompletionList::icon(size_t idx) const
 {
        // get the latex command
        docstring cmd;
@@ -1824,7 +2051,7 @@ std::string MathCompletionList::icon(size_t idx) const
                cmd = globals[idx - lsize];
        else
                cmd = locals[idx];
-       
+
        // get the icon resource name by stripping the backslash
        return "images/math/" + to_utf8(cmd.substr(1)) + ".png";
 }